yvvan added a comment.
I've tried once again to make a clean build and it worked... :)
And I can't imagine what kind of configuration issue could it be because I
always use quite the same one :)
https://reviews.llvm.org/D34279
___
cfe-commits maili
johannes updated this revision to Diff 103320.
johannes added a comment.
- Fix a bug in getSimilarity()
- Change terminology: `label` -> `value`
- Define SNodeId: Now it cannot be implicitly constructed from an int, however
it can be converted to int. Still feels a bit weird
- Fix some issues wit
Author: teemperor
Date: Wed Jun 21 00:41:39 2017
New Revision: 305878
URL: http://llvm.org/viewvc/llvm-project?rev=305878&view=rev
Log:
Changed wording in comment
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp
URL:
http://llvm.org/vie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305875: Support MS builtins using 'long' on LP64 platforms
(authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D34377?vs=103315&id=103318#toc
Repository:
rL LLVM
https://reviews.l
Author: bruno
Date: Tue Jun 20 21:20:46 2017
New Revision: 305875
URL: http://llvm.org/viewvc/llvm-project?rev=305875&view=rev
Log:
Support MS builtins using 'long' on LP64 platforms
This allows for -fms-extensions to work the same on LP64. For example,
_BitScanReverse is expected to be 32-bit, m
Author: bruno
Date: Tue Jun 20 21:20:40 2017
New Revision: 305874
URL: http://llvm.org/viewvc/llvm-project?rev=305874&view=rev
Log:
Run dos2unix on ms-intrinsics-rotations.c test. NFC
Modified:
cfe/trunk/test/CodeGen/ms-intrinsics-rotations.c
Modified: cfe/trunk/test/CodeGen/ms-intrinsics-ro
manojgupta added a comment.
I am not sure what is the expected behavior. Maybe clang is doing the right
thing in rejecting.
But, this creates an issue in ChromeOS land where a package fails to build with
clang (https://bugs.chromium.org/p/chromium/issues/detail?id=735206).
https://reviews.llv
Author: rtrieu
Date: Tue Jun 20 20:43:13 2017
New Revision: 305872
URL: http://llvm.org/viewvc/llvm-project?rev=305872&view=rev
Log:
[ODRHash] Supply more information when generic error message is emitted.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/l
rnk accepted this revision.
rnk added a comment.
lgtm, thanks for shuffling all the tests around!
https://reviews.llvm.org/D34377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 103315.
bruno marked an inline comment as done.
bruno added a comment.
Addressing comments!
https://reviews.llvm.org/D34377
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
include/clang/B
bruno marked 3 inline comments as done.
bruno added inline comments.
Comment at: test/CodeGen/ms-intrinsics-darwin.c:1
+// RUN: %clang_cc1 -ffreestanding -fms-extensions \
+// RUN: -triple x86_64--darwin -Oz -emit-llvm %s -o - \
rnk wrote:
> I'd rather ge
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:608-611
declarations and definitions. Most importantly, if any function with a given
name is given the ``overloadable`` attribute, then all function declarations
and definitions with that name (and in t
rnk added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// N -> 'L' if target is LP64, 'int' size otherwise.
// S -> signed
Fix the comment? "long" if target is LLP64, "int" otherwise?
Comment at:
iid_iunknown updated this revision to Diff 103297.
iid_iunknown added a comment.
Fixed white spaces.
Repository:
rL LLVM
https://reviews.llvm.org/D34430
Files:
lib/Sema/SemaExprCXX.cpp
Index: lib/Sema/SemaExprCXX.cpp
===
---
iid_iunknown created this revision.
iid_iunknown added a project: clang.
This is a patch for PR33484.
The clang's typo correction logic may fall into an infinite loop when reaching
the typo correction limit.
When some complex expression has multiple typos in it, clang finds possible
corrections
saugustine added a comment.
In https://reviews.llvm.org/D34304#785984, @saugustine wrote:
> In https://reviews.llvm.org/D34304#785083, @klimek wrote:
>
> > I think it's cleaner, because it uses a concept we already have (argument
> > adapters).
>
>
> Will you point me to an example of these. Goo
bruno updated this revision to Diff 103287.
bruno retitled this revision from "Support MS builtins using 'long' on
Darwin/LP64" to "Support MS builtins using 'long' on LP64".
bruno edited the summary of this revision.
bruno added a comment.
New patch addressing comments from reviewers.
https://
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4088-4089
// C++1z [meta.unary.prop]:
// remove_all_extents_t shall be a complete type or cv void.
case UTT_IsAggregate:
Please move the UTT_Has* cases up here, since this is the rule
Should be fixed in r305860.
- Lang.
On Tue, Jun 20, 2017 at 2:19 PM, Lang Hames wrote:
> Oops - this broke Sema/ms_class_layout.cpp. Looking in to it now...
>
> - Lang.
>
> On Tue, Jun 20, 2017 at 2:06 PM, Lang Hames via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: lhames
>>
manojgupta updated this revision to Diff 103280.
https://reviews.llvm.org/D34426
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+++ lib/Driver/Driver.cpp
@@ -2759,7 +2759,7 @@
if (Final
manojgupta created this revision.
If a .h file is specifed as input, it gets compiled to a PCH file.
Handle the PCH Action and do not throw the error:
"cannot specify -o when generating multiple output files"
This fixes PR33533.
https://reviews.llvm.org/D34426
Files:
lib/Driver/Driver.cpp
On 20 June 2017 at 14:30, Lang Hames via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lhames
> Date: Tue Jun 20 16:30:43 2017
> New Revision: 305860
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305860&view=rev
> Log:
> Special-case handling of destructors in override lists when d
apazos created this revision.
Herald added subscribers: kristof.beyls, javed.absar, srhines, aemerson.
Unified logic for computing target ABI in backend and front end by moving this
common code to Support/TargetParser.
Modeled Triple::GNU after front end code (aapcs abi) and updated tests that
saugustine added a comment.
In https://reviews.llvm.org/D34304#785083, @klimek wrote:
> I think it's cleaner, because it uses a concept we already have (argument
> adapters).
Will you point me to an example of these. Google is coming up empty.
https://reviews.llvm.org/D34304
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305862: Prevent devirtualization of calls to un-instantiated
functions. (authored by ssrivastava).
Changed prior to commit:
https://reviews.llvm.org/D22057?vs=71432&id=103273#toc
Repository:
rL LLVM
Author: ssrivastava
Date: Tue Jun 20 17:08:44 2017
New Revision: 305862
URL: http://llvm.org/viewvc/llvm-project?rev=305862&view=rev
Log:
Prevent devirtualization of calls to un-instantiated functions.
PR 27895
Differential Revision: https://reviews.llvm.org/D22057
Added:
cfe/trunk/test/Cod
rnk added a comment.
Saleem, didn't something change here two months ago? Why do we want to bother
with all of this dllimport stuff in the frontend? It seems to break mingw and
add complexity for very little gain (avoiding linker provided thunks).
Repository:
rL LLVM
https://reviews.llvm.or
nemanjai added subscribers: iains, echristo.
nemanjai added a comment.
I'm not sure how much expertise there is for PPC32-Darwin. Perhaps @iains might
be able to offer some insight here. Also, @echristo might have a thing or two
to say in this regard.
Repository:
rL LLVM
https://reviews.llv
Author: lhames
Date: Tue Jun 20 16:30:43 2017
New Revision: 305860
URL: http://llvm.org/viewvc/llvm-project?rev=305860&view=rev
Log:
Special-case handling of destructors in override lists when dumping ASTs.
Fixes a bug in r305850: CXXDestructors don't have names, so we need to handle
printing of
bruno added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
bruno wrote:
> rnk wrote:
> > majnemer wrote:
> > > bruno wrote:
> > > > bruno wrote:
> > > > > rnk wrote:
> > > > > > compnerd wrote:
> > > > > > > I agree w
rnk added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
majnemer wrote:
> bruno wrote:
> > bruno wrote:
> > > rnk wrote:
> > > > compnerd wrote:
> > > > > I agree with @majnemer. Why not base this on the Int64Type?
bruno added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
majnemer wrote:
> bruno wrote:
> > bruno wrote:
> > > rnk wrote:
> > > > compnerd wrote:
> > > > > I agree with @majnemer. Why not base this on the Int64Type
Oops - this broke Sema/ms_class_layout.cpp. Looking in to it now...
- Lang.
On Tue, Jun 20, 2017 at 2:06 PM, Lang Hames via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lhames
> Date: Tue Jun 20 16:06:00 2017
> New Revision: 305850
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3
majnemer added inline comments.
Comment at: lib/AST/ASTContext.cpp:8551
+ break;
+}
case 'W':
bruno wrote:
> bruno wrote:
> > rnk wrote:
> > > compnerd wrote:
> > > > I agree with @majnemer. Why not base this on the Int64Type?
> > > I'd suggest thi
Author: stl_msft
Date: Tue Jun 20 16:10:53 2017
New Revision: 305854
URL: http://llvm.org/viewvc/llvm-project?rev=305854&view=rev
Log:
[libcxx] [test] Fix -Wmismatched-tags in
tuple_size_structured_bindings.pass.cpp.
Clang and C1XX both complain about mismatched class/struct, but libc++ and
MSV
sberg created this revision.
... once each for the syntactic and semantic form. Without this fix, behavior
of the newly added tests would have been
InitListExprIsPreOrderVisitedTwice:
syntactic: 1
semantic: 2
InitListExprIsPostOrderVisitedTwice:
syntactic: 0
semantic: 1
InitListExprIsPre
Author: lhames
Date: Tue Jun 20 16:06:00 2017
New Revision: 305850
URL: http://llvm.org/viewvc/llvm-project?rev=305850&view=rev
Log:
Preserve CXX method overrides in ASTImporter
Summary:
The ASTImporter should import CXX method overrides from the source context
when it imports a method decl.
Rev
Author: stl_msft
Date: Tue Jun 20 16:00:02 2017
New Revision: 305848
URL: http://llvm.org/viewvc/llvm-project?rev=305848&view=rev
Log:
[libcxx] [test] Strip trailing whitespace. NFC.
Modified:
libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.foreach/for_each_n.pass.cpp
libcxx/trunk
sberg created this revision.
...instead of -std=c99, as the latter lead to
error: invalid argument '-std=c99' not allowed with 'C++'
complaints in test logs
https://reviews.llvm.org/D34417
Files:
unittests/Tooling/TestVisitor.h
Index: unittests/Tooling/TestVisitor.h
Author: alexshap
Date: Tue Jun 20 15:46:58 2017
New Revision: 305845
URL: http://llvm.org/viewvc/llvm-project?rev=305845&view=rev
Log:
[clang] Fix format specifiers fixits for nested macros
ExpansionLoc was previously calculated incorrectly in the case of
nested macros expansions. In this diff w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305845: [clang] Fix format specifiers fixits for nested
macros (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D34268?vs=103093&id=103262#toc
Repository:
rL LLVM
https://re
bruno added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// l -> 'int' if builtin is a MS extensions and the target is Darwin/LP64.
+// Defaults to 'L' otherwise.
rnk wrote:
> majnemer wrote:
> > Why not just LP
Author: stl_msft
Date: Tue Jun 20 15:34:50 2017
New Revision: 305843
URL: http://llvm.org/viewvc/llvm-project?rev=305843&view=rev
Log:
[libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and
make it friendlier to C1XX.
Style/paranoia: 42.1 doesn't have an exact binary repre
Author: rnk
Date: Tue Jun 20 15:34:13 2017
New Revision: 305841
URL: http://llvm.org/viewvc/llvm-project?rev=305841&view=rev
Log:
Fix discovery of cxxabi.h in the monorepo layout
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-pro
zaks.anna added a comment.
> Hmm, should there be new tests that demonstrate that we cover the new APIs?
Unless we use a new registration mechanism for some of these APIs, I'd be fine
without adding a test for every API that has localization constraints.
Repository:
rL LLVM
https://reviews.
jyknight added a comment.
EricWF, wdyt?
https://reviews.llvm.org/D34294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
If LSan is a runtime thing, why not use weak hooks or something to detect LSan
at runtime instead of using a macro?
https://reviews.llvm.org/D34210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: tstellar
Date: Tue Jun 20 14:30:24 2017
New Revision: 305836
URL: http://llvm.org/viewvc/llvm-project?rev=305836&view=rev
Log:
Creating release candidate final from release_401 branch
Added:
libunwind/tags/RELEASE_401/final/ (props changed)
- copied from r305835, libunwind/bra
Author: tstellar
Date: Tue Jun 20 14:29:53 2017
New Revision: 305830
URL: http://llvm.org/viewvc/llvm-project?rev=305830&view=rev
Log:
Creating release candidate final from release_401 branch
Added:
libcxxabi/tags/RELEASE_401/final/ (props changed)
- copied from r305829, libcxxabi/bra
Author: tstellar
Date: Tue Jun 20 14:29:48 2017
New Revision: 305829
URL: http://llvm.org/viewvc/llvm-project?rev=305829&view=rev
Log:
Creating release candidate final from release_401 branch
Added:
libcxx/tags/RELEASE_401/final/ (props changed)
- copied from r305828, libcxx/branches/
fjricci reclaimed this revision.
fjricci added a comment.
As I've looked into this further, I do think we need
`has_feature(leak_sanitizer)` after all. For example, if a user program calls
`pthread_create()` with a custom stack size, leak sanitizer will intercept the
call to `pthread_create()`,
STL_MSFT added a comment.
Ping?
https://reviews.llvm.org/D33953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1605
+ ? CGM.getDataLayout().getAllocaAddrSpace()
+ : getContext().getTargetAddressSpace(LangAS::Default));
break;
yaxunl wrote:
> rjmccall wrote:
> > Everything a
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:959
+ /// \brief Return the target address space which is read only and can be
+ /// casted to the generic address space.
+ virtual llvm::Optional getTargetConst
ddcc added a comment.
I forgot to mention that the only remaining test failure is on
`plist-macros.cpp`; there is a `Assuming condition is true` path note that only
appears with the RangeConstraintManager but not with Z3ConstraintManager, and I
can't `#ifdef` it because the annotations are chec
ddcc updated this revision to Diff 103239.
ddcc added a comment.
Rebase, decrease simplification complexity
https://reviews.llvm.org/D28953
Files:
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
lib/StaticAnalyzer/Core/SValBuilder.cpp
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
ddcc added a comment.
> Can we drop computing these for some expressions that we know the
> RangeConstraintManager will not utilize?
It's possible, though I'm not sure what the actual limitations of the
RangeConstraintManager are, since there are a lot of intermediate steps that
attempt to tra
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305812: Fix for Bug 33471: Preventing operator auto from
resolving to a templateā¦ (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D34370?vs=103224&id=103235#toc
Repository:
Author: erichkeane
Date: Tue Jun 20 12:38:07 2017
New Revision: 305812
URL: http://llvm.org/viewvc/llvm-project?rev=305812&view=rev
Log:
Fix for Bug 33471: Preventing operator auto from resolving to a template
operator.
As the bug report says,
struct A
{
template operator T();
};
void foo()
yaxunl added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1605
+ ? CGM.getDataLayout().getAllocaAddrSpace()
+ : getContext().getTargetAddressSpace(LangAS::Default));
break;
rjmccall wrote:
> Everything about your reasoning
rnk added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// l -> 'int' if builtin is a MS extensions and the target is Darwin/LP64.
+// Defaults to 'L' otherwise.
majnemer wrote:
> Why not just LP64? Seems arbitra
Anastasia added inline comments.
Comment at: include/clang/Basic/Builtins.def:713
+ATOMIC_BUILTIN(__opencl_atomic_fetch_or, "v.", "t")
+ATOMIC_BUILTIN(__opencl_atomic_fetch_xor, "v.", "t")
+
What about min/max? I believe they will need to have the scope too.
=
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL305805.
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
erichkeane added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:870
+ DeclarationName::CXXConversionFunctionName &&
+ R.getLookupName().getCXXNameType()->getContainedDeducedType() &&
+ R.getLookupName()
rsmith wrote:
> Maybe only call thi
Author: yamaguchi
Date: Tue Jun 20 11:31:31 2017
New Revision: 305805
URL: http://llvm.org/viewvc/llvm-project?rev=305805&view=rev
Log:
[GSoC] Flag value completion for clang
This is patch for GSoC project, bash-completion for clang.
To use this on bash, please run `source clang/utils/bash-autoc
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
Comment at: lib/Sema/SemaLookup.cpp:870
+ DeclarationName::CXXConversionFunctionName &&
+ R.getLookupName().getCXXNameType()->getContainedDe
erichkeane updated this revision to Diff 103224.
erichkeane marked an inline comment as done.
erichkeane added a comment.
Hi @rsmith
Thanks for the quick response! I spent a while going over it, and think I have
what you were looking for. I Also added the operator auto * tests.
https://revie
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:959
+ /// \brief Return the target address space which is read only and can be
+ /// casted to the generic address space.
+ virtual llvm::Optional getTargetConstantAddressSpace() const {
-
zaks.anna added a comment.
> In particular, there are patches to generate more symbolic expressions, that
> could also degrade the performance (but fix some fixmes along the way).
The patch you are talking about might be promising, but needs much more
investigation and tuning for performance vs
Author: arphaman
Date: Tue Jun 20 11:16:11 2017
New Revision: 305804
URL: http://llvm.org/viewvc/llvm-project?rev=305804&view=rev
Log:
Add a missing '[' to the tests from r305719
This clarifies the tests as the missing ']' is important, and not the '['.
Modified:
cfe/trunk/test/Parser/objc-a
On 20 June 2017 at 16:53, Duncan P. N. Exon Smith
wrote:
>
> On Jun 19, 2017, at 10:53, Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: arphaman
> Date: Mon Jun 19 12:53:21 2017
> New Revision: 305719
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305719&view=rev
Author: arphaman
Date: Tue Jun 20 11:12:26 2017
New Revision: 305803
URL: http://llvm.org/viewvc/llvm-project?rev=305803&view=rev
Log:
Split the expectations in tests from r305719 over multiple lines to
enhance readability
As suggested by Duncan Exon Smith!
Modified:
cfe/trunk/test/Parser/ob
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:124
+/// CanReusePreamble + AddImplicitPreamble to make use of it.
+class PrecompiledPreamble {
+public:
klimek wrote:
> ilya-biryukov wrote:
> > klimek wrote:
> > > If
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.cpp:1605
+ ? CGM.getDataLayout().getAllocaAddrSpace()
+ : getContext().getTargetAddressSpace(LangAS::Default));
break;
Everything about your reasoning seems to apply t
wangxindsb updated this revision to Diff 103214.
wangxindsb added a comment.
Correct some error in VirtualCallChecker.cpp.
Complete the test case.
https://reviews.llvm.org/D34275
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp
test/Analysis/virtualcall.cpp
Index: test/Analysis/vi
ilya-biryukov updated this revision to Diff 103216.
ilya-biryukov added a comment.
- Made TempPCHFile an inner class of PrecompiledPreamble.
- Made PreambleFileHash an inner class of PrecompiledPreamble.
- Changed stanalone functions to members.
- Removed some member accessors that were no longer
LGTM, assuming "howLong" == 0 means 32-bit int. š
-Original Message-
From: Bruno Cardoso Lopes [mailto:bruno.card...@gmail.com]
Sent: Monday, June 19, 2017 6:45 PM
To: Duncan P. N. Exon Smith
Cc: Reid Kleckner ; Erik Schwiebert ;
Brian Kelley ; Tomasz Kukielka ;
cfe-commits
Subject: R
rjmccall added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4128
+return true;
+}
+
I don't understand the difference you're creating between traits here. Three
specific traits about destructibility allow incomplete array types regardless
bader added a comment.
Wow...
Nice catch.
For some reason I can't reproduce the problem neither.
I will drop source code change, but I'd like to modify the test anyway.
https://reviews.llvm.org/rL277024 added test/CodeGenOpenCL/sampler.cl and
modified test/SemaOpenCL/sampler_t.cl.
I want to move
wangxindsb marked 5 inline comments as done.
wangxindsb added inline comments.
Comment at: VirtualCallChecker.cpp:260
+ if (SFC->inTopFrame()) {
+ const FunctionDecl *FD = SFC->getDecl()->getAsFunction();
+if (!FD)
xazax.hun wrote:
> The formatting seems to
> On Jun 19, 2017, at 10:53, Alex Lorenz via cfe-commits
> wrote:
>
> Author: arphaman
> Date: Mon Jun 19 12:53:21 2017
> New Revision: 305719
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305719&view=rev
> Log:
> [Parser][ObjC] Use an artificial EOF token while parsing lexed ObjC methods
>
johannes added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:171
+
+std::string TreeRoot::label(NodeId Id) const {
+ const Node &N = getNode(Id);
arphaman wrote:
> I believe that this method that you call `label` actually represents the
> `value`
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:303
+/// Identifies a node in this subtree by its postorder offset.
+using SNodeId = int;
+
johannes wrote:
> arphaman wrote:
> > What's the difference between `SNodeId` and `NodeId`?
> N
johannes added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:303
+/// Identifies a node in this subtree by its postorder offset.
+using SNodeId = int;
+
arphaman wrote:
> What's the difference between `SNodeId` and `NodeId`?
NodeId is the preorder
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:171
+
+std::string TreeRoot::label(NodeId Id) const {
+ const Node &N = getNode(Id);
I believe that this method that you call `label` actually represents the
`value` attribute that's de
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:303
+/// Identifies a node in this subtree by its postorder offset.
+using SNodeId = int;
+
What's the difference between `SNodeId` and `NodeId`?
https://reviews.llvm.org/D34329
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:474
+for (SNodeId D1 = LMD1 + 1; D1 <= Id1; ++D1) {
+ double DeletionCost = 1.0;
+ ForestDist[D1][LMD2] = ForestDist[D1 - 1][LMD2] + DeletionCost;
johannes wrote:
> arphaman
johannes marked an inline comment as done.
johannes added a comment.
In https://reviews.llvm.org/D34329#785190, @arphaman wrote:
> Looking at the output of the tool, I have the following suggestion:
>
> - We should avoid implicit expressions (We don't need to see things like
> `Insert ImplicitCa
hans added a comment.
I still don't understand why this is breaking your build.
Assuming this is the line the first error refers to:
for (unsigned BinOp : {G_ADD, G_SUB, G_MUL, G_AND, G_OR, G_XOR, G_SHL}) {
I don't see how converting G_ADD, even if it is an int, to unsigned would be a
narrow
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/sampler.cl:62
+
+ const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE |
CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
+ // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)*
@__translate_sam
johannes updated this revision to Diff 103208.
johannes marked 7 inline comments as done.
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling/CMakeLists.txt
test/Tooling/clang-diff-
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r305799. I would like to test it and I think that should be possible
as soon as I land some interpreter infrastructure which is on my TODO list.
https://reviews.llvm.org/D31187
Author: vvassilev
Date: Tue Jun 20 09:59:57 2017
New Revision: 305799
URL: http://llvm.org/viewvc/llvm-project?rev=305799&view=rev
Log:
D31187: Fix removal of out-of-line definitions.
Consider:
struct MyClass {
void f() {}
}
MyClass::f(){} // expected error redefinition of f. #1
Some clients
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305798: [OpenCL] Diagnose scoped address-space qualified
variables (authored by stulova).
Changed prior to commit:
https://reviews.llvm.org/D34024?vs=101872&id=103207#toc
Repository:
rL LLVM
https:/
Author: stulova
Date: Tue Jun 20 09:50:45 2017
New Revision: 305798
URL: http://llvm.org/viewvc/llvm-project?rev=305798&view=rev
Log:
[OpenCL] Diagnose scoped address-space qualified variables
Produce an error if variables qualified with a local or
a constant address space are not declared in the
klimek added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:124
+/// CanReusePreamble + AddImplicitPreamble to make use of it.
+class PrecompiledPreamble {
+public:
ilya-biryukov wrote:
> klimek wrote:
> > If a user doesn't care about t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305797: [preprocessor] When preprocessor option
'SingleFileParseMode' is enabled, parseā¦ (authored by akirtzidis).
Changed prior to commit:
https://reviews.llvm.org/D34263?vs=103067&id=103206#toc
Repos
Author: akirtzidis
Date: Tue Jun 20 09:36:58 2017
New Revision: 305797
URL: http://llvm.org/viewvc/llvm-project?rev=305797&view=rev
Log:
[preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse
all directive blocks if the condition uses undefined macros
This is useful for
Author: bader
Date: Tue Jun 20 09:30:18 2017
New Revision: 305796
URL: http://llvm.org/viewvc/llvm-project?rev=305796&view=rev
Log:
[OpenCL] Fix OpenCL and SPIR version metadata generation.
Summary: OpenCL and SPIR version metadata must be generated once per module
instead of once per mangled gl
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D34235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
1 - 100 of 128 matches
Mail list logo
