[PATCH] D33308: [analyzer]: Improve test handling with multiple constraint managers

ddcc added a comment. @dcoughlin @zaks.anna @NoQ @xazax.hun Ping, I'd appreciate it if I could get a review for this (https://reviews.llvm.org/D33308), https://reviews.llvm.org/D28955, https://reviews.llvm.org/D28953, and https://reviews.llvm.org/D28954. Rebasing and fixing up these commits is

[PATCH] D17143: [Sema] PR25156 Crash when parsing dtor call on incomplete type

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, looks great. If you're going to be submitting multiple patches, you should really ask for commit access; it's not an arduous process. https://reviews.llvm.org/D17143 _

[PATCH] D33852: Enable __declspec(selectany) on linux

davide added inline comments. Comment at: include/clang/Basic/Attr.td:2421 -def SelectAny : InheritableAttr, TargetSpecificAttr { +def SelectAny : InheritableAttr, TargetSpecificAttr { let Spellings = [Declspec<"selectany">, GCC<"selectany">]; Prazek wrote:

Re: r303317 - The constant expression evaluator should examine function arguments for non-constexpr function calls unless the EvalInfo says to stop.

On Tue, May 30, 2017 at 07:01:22PM -0700, Nick Lewycky wrote: > Joerg Sonnenberger wrote: > > On Wed, May 17, 2017 at 11:56:55PM -, Nick Lewycky via cfe-commits > > wrote: > > > Author: nicholas > > > Date: Wed May 17 18:56:54 2017 > > > New Revision: 303317 > > > > > > URL: http://llvm.org/v

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

mclow.lists marked 7 inline comments as done. mclow.lists added inline comments. Comment at: include/numeric:154 +return reduce(__first, __last, + typename iterator_traits<_InputIterator>::value_type{}, _VSTD::plus<>()); +} wash wrote: > In the spec,

[PATCH] D33997: Implement the non-execution policy versions of `reduce` and `transform_reduce` for C++17

mclow.lists updated this revision to Diff 102125. mclow.lists added a comment. Rebased now that https://reviews.llvm.org/D34038 has landed; address Richard and Bryce's comments https://reviews.llvm.org/D33997 Files: include/numeric test/std/numerics/numeric.ops/reduce/reduce_iter_iter.pass

[PATCH] D34082: [Frontend 'Show hotness' can be used with a sampling profile

davidxl added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:32 +// RUN: -Rpass-analysis=inline -fdiagnostics-show-hotness 2>&1 | FileCheck \ +// RUN: -check-prefix=PGO_ENABLED %s +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.9 -main-f

[PATCH] D34082: [Frontend 'Show hotness' can be used with a sampling profile

anemet added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:32 +// RUN: -Rpass-analysis=inline -fdiagnostics-show-hotness 2>&1 | FileCheck \ +// RUN: -check-prefix=PGO_ENABLED %s +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.9 -main-fi

[PATCH] D34082: [Frontend 'Show hotness' can be used with a sampling profile

anemet added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:1-34 +// Generate instrumentation and sampling profile data. // RUN: llvm-profdata merge \ -// RUN: %S/Inputs/optimization-remark-with-hotness.proftext \ +// RUN: %S/Inputs/optim

r305148 - Revert "[clang] Implement -Wcast-qual for C++"

Author: lebedevri Date: Sat Jun 10 12:49:23 2017 New Revision: 305148 URL: http://llvm.org/viewvc/llvm-project?rev=305148&view=rev Log: Revert "[clang] Implement -Wcast-qual for C++" Breaks -Werror builders. Removed: cfe/trunk/test/SemaCXX/warn-cast-qual.cpp Modified: cfe/trunk/docs/Rele

[PATCH] D34082: [Frontend 'Show hotness' can be used with a sampling profile

modocache added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:32 +// RUN: -Rpass-analysis=inline -fdiagnostics-show-hotness 2>&1 | FileCheck \ +// RUN: -check-prefix=PGO_ENABLED %s +// RUN: %clang_cc1 -triple x86_64-apple-macosx10.9 -main

[PATCH] D34082: [Frontend 'Show hotness' can be used with a sampling profile

modocache created this revision. Prior to this change, using `-fdiagnostics-show-hotness` with a sampling profile specified via `-fprofile-sample-use=` would result in the Clang frontend emitting a warning: "argument '-fdiagnostics-show-hotness' requires profile-guided optimization information". O

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

This revision was automatically updated to reflect the committed changes. Closed by commit rL305147: [clang] Implement -Wcast-qual for C++ (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D33102?vs=102119&id=102120#toc Repository: rL LLVM https://reviews.llvm.org/D

r305147 - [clang] Implement -Wcast-qual for C++

Author: lebedevri Date: Sat Jun 10 12:19:19 2017 New Revision: 305147 URL: http://llvm.org/viewvc/llvm-project?rev=305147&view=rev Log: [clang] Implement -Wcast-qual for C++ Summary: This way, the behavior of that warning flag more closely resembles that of GCC. Do note that there is at least on

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

lebedev.ri updated this revision to Diff 102119. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. After further mail exchange, i will proceed to commit this as-is. No code changes, rebase before commit. Repository: rL

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

On Sat, Jun 10, 2017 at 7:05 PM, David Blaikie wrote: > > > On Sat, Jun 10, 2017 at 3:33 AM Roman Lebedev via Phabricator > wrote: >> >> lebedev.ri planned changes to this revision. >> lebedev.ri added a comment. >> >> In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: >> >> > But sure.

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

On Sat, Jun 10, 2017 at 3:33 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri planned changes to this revision. > lebedev.ri added a comment. > > In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: > > > But sure. Could you also (manually, I guess) confirm t

[PATCH] D30748: [Lexer] Finding beginning of token with escaped new line

idlecode updated this revision to Diff 102110. idlecode added a comment. Added tests for `isNewLineEscaped` - this fixed some corner cases https://reviews.llvm.org/D30748 Files: lib/Lex/Lexer.cpp unittests/Lex/LexerTest.cpp Index: unittests/Lex/LexerTest.cpp ===

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

lebedev.ri planned changes to this revision. lebedev.ri added a comment. In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: > But sure. Could you also (manually, I guess) confirm that this matches GCC's > cast-qual behavior (insofar as the warning fires in the same situations). If > th

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik marked 2 inline comments as done. szdominik added a comment. Warnings of the check's run on llvm/clang codebase. F3426875: undelegated-copy-of-base-classes-clangrun.txt https://reviews.llvm.org/D33722