[libcxx] r305136 - Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan. Reviewed as https://reviews.llvm.org/D34038.

Author: marshall Date: Fri Jun 9 21:22:13 2017 New Revision: 305136 URL: http://llvm.org/viewvc/llvm-project?rev=305136&view=rev Log: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan. Reviewed as https://reviews.llvm.org/D34038. Added: libcxx/trunk/test/std

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

wash added a comment. The init typedef test looks good to me. This all looks good to go. https://reviews.llvm.org/D34038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler added a comment. Alex, I will look into it. Thanks! Repository: rL LLVM https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17143: [Sema] PR25156 Crash when parsing dtor call on incomplete type

hintonda updated this revision to Diff 102103. hintonda added a comment. - Addressed comments. https://reviews.llvm.org/D17143 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/nested-name-spec.cpp Index: test/SemaCXX/nested-name-spec.cpp ===

[PATCH] D34055: Be more strict when checking the -flto option value

tejohnson added a comment. In https://reviews.llvm.org/D34055#777005, @yamaguchi wrote: > I think we don't need additional testcase, because this is non-functional > change. Driver.cpp will emit error if value was not "thin" nor "full". This > testcase is at clang/test/CodeGen/thinlto-backend-o

[PATCH] D17143: [Sema] PR25156 Crash when parsing dtor call on incomplete type

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:192 Found.clear(); -if (Step == 0 && LookupCtx) +if (Step == 0 && LookupCtx && !RequireCompleteDeclContext(SS, LookupCtx)) LookupQualifiedName(Found, LookupCtx); You should p

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. Looks like you haven't introduced proper constants in the header for scopes. Comment at: docs/LanguageExtensions.rst:1855 +atomic builtins are in ``explicit`` form of the corresponding OpenCL 2.0 +builtin function, and are named with a ``__opencl__`` p

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists updated this revision to Diff 102100. mclow.lists added a comment. Previous update was br0ken. This is better. :-) Add a test to ensure that the calculations are done using the correct type. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/ex

[PATCH] D33526: Fix spurious Wunused-lambda-capture warning

kongyi updated this revision to Diff 102099. Repository: rL LLVM https://reviews.llvm.org/D33526 Files: lib/Sema/SemaLambda.cpp test/SemaCXX/warn-unused-lambda-capture.cpp Index: test/SemaCXX/warn-unused-lambda-capture.cpp =

[PATCH] D34038: Implement the non-parallel versions of exclusive_scan and transform_exclusive_scan

mclow.lists updated this revision to Diff 102097. mclow.lists added a comment. Add extra tests to make sure that the calculations are not done using the source sequence value_type. https://reviews.llvm.org/D34038 Files: include/numeric test/std/numerics/numeric.ops/exclusive.scan/exclusiv

r305130 - Revert r305110 to fix buildbot

Author: rtrieu Date: Fri Jun 9 18:03:40 2017 New Revision: 305130 URL: http://llvm.org/viewvc/llvm-project?rev=305130&view=rev Log: Revert r305110 to fix buildbot Modified: cfe/trunk/lib/AST/ODRHash.cpp cfe/trunk/test/Modules/odr_hash.cpp Modified: cfe/trunk/lib/AST/ODRHash.cpp URL: ht

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

rsmith added a comment. This is a libstdc++ bug: https://gcc.gnu.org/PR79162 (They implemented a speculative fix for a different issue and ended up breaking this case.) I think for now we should say we don't support building LLVM with libstdc++7.1 in C++17 mode. Repository: rL LLVM https:/

RE: r305087 - support operator keywords used in Windows SDK

Should be fixed as of here: https://reviews.llvm.org/rL305128 . Curious that none of the other tests found this, but thankfully UBSan did! Committed as no-wait due to the breakage and not wanting to leave it broken over the weekend. -Original Message- From: Evgenii Stepanov [mailto:

r305128 - Support operator keywords used in Windows SDK(fix ubsan)

Author: erichkeane Date: Fri Jun 9 17:50:02 2017 New Revision: 305128 URL: http://llvm.org/viewvc/llvm-project?rev=305128&view=rev Log: Support operator keywords used in Windows SDK(fix ubsan) UBSan found an issue with a nullptr being assigned to a reference. This was because a following functio

r305126 - 27037: Use correct CVR qualifier on an upcast on method pointer call

Author: rsmith Date: Fri Jun 9 17:25:28 2017 New Revision: 305126 URL: http://llvm.org/viewvc/llvm-project?rev=305126&view=rev Log: 27037: Use correct CVR qualifier on an upcast on method pointer call Patch by Taiju Tsuiki! Differential Revision: https://reviews.llvm.org/D33875 Added: cfe/

[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

This revision was automatically updated to reflect the committed changes. Closed by commit rL305126: 27037: Use correct CVR qualifier on an upcast on method pointer call (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D33875?vs=101536&id=102081#toc Repository: rL LLVM

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

v.g.vassilev closed this revision. v.g.vassilev added a comment. Changing the default of clang-apply-replacements makes sense to me. This one landed in r305125. https://reviews.llvm.org/D33930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r305125 - [clang-tidy] D33930: Do not pick up by default the LLVM style if passing -format.

Author: vvassilev Date: Fri Jun 9 17:23:03 2017 New Revision: 305125 URL: http://llvm.org/viewvc/llvm-project?rev=305125&view=rev Log: [clang-tidy] D33930: Do not pick up by default the LLVM style if passing -format. This adds a new flag -style which is passed to clang-apply-replacements and de

[PATCH] D34066: [clang] Cleanup fixit.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL305124: [clang] Cleanup fixit.c (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D34066?vs=102076&id=102079#toc Repository: rL LLVM https://reviews.llvm.org/D34066 Files:

r305124 - [clang] Cleanup fixit.c

Author: alexshap Date: Fri Jun 9 17:20:52 2017 New Revision: 305124 URL: http://llvm.org/viewvc/llvm-project?rev=305124&view=rev Log: [clang] Cleanup fixit.c This diff removes temporary file t2 in fixit.c and updates the test command accordingly. NFC. Test plan: make check-all Differential re

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev closed this revision. v.g.vassilev added a comment. r305120. https://reviews.llvm.org/D29951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34066: [clang] Cleanup fixit.c

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D34066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

arphaman added a comment. Ronald, I had to revert the commit as the `availability.c` test was failing on Linux (e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/12532). Can you please look into that? I think you might have to got back to the `CHECK-1` an

r305122 - Revert r305117

Author: arphaman Date: Fri Jun 9 17:06:36 2017 New Revision: 305122 URL: http://llvm.org/viewvc/llvm-project?rev=305122&view=rev Log: Revert r305117 It caused `Index/availability.c` test failure on Linux Modified: cfe/trunk/test/Index/availability.c cfe/trunk/tools/libclang/CIndex.cpp

r305121 - Attempt to fix shared library build: RewriteFrontend depends on Serialization after r305116.

Author: rsmith Date: Fri Jun 9 17:02:33 2017 New Revision: 305121 URL: http://llvm.org/viewvc/llvm-project?rev=305121&view=rev Log: Attempt to fix shared library build: RewriteFrontend depends on Serialization after r305116. Modified: cfe/trunk/lib/Frontend/Rewrite/CMakeLists.txt Modified:

RE: r305087 - support operator keywords used in Windows SDK

Thanks, I didn't notice that one. Looking into it. -Erich -Original Message- From: Evgenii Stepanov [mailto:eugeni.stepa...@gmail.com] Sent: Friday, June 9, 2017 3:00 PM To: Keane, Erich Cc: cfe-commits Subject: Re: r305087 - support operator keywords used in Windows SDK Hi, http://

Re: r305110 - [ODRHash] Add support for TemplateArgument types.

Could this failure be due to your change: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/8365/steps/compile.llvm.stage2/logs/stdio ? On 9 June 2017 at 14:00, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rtrieu > Date: Fri Jun 9 16

Re: r305087 - support operator keywords used in Windows SDK

Hi, http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5571/steps/check-clang%20ubsan/logs/stdio tools/clang/lib/Parse/ParseExprCXX.cpp:383:26: runtime error: reference binding to null pointer of type 'clang::IdentifierInfo' #0 0x5313046 in clang::Parser::ParseOptionalCXXSco

r305120 - [modules] D29951: Load lazily the template specialization in multi-module setups.

Author: vvassilev Date: Fri Jun 9 16:54:18 2017 New Revision: 305120 URL: http://llvm.org/viewvc/llvm-project?rev=305120&view=rev Log: [modules] D29951: Load lazily the template specialization in multi-module setups. Currently, we load all template specialization if we have more than one module

[PATCH] D34066: [clang] Cleanup fixit.c

alexshap created this revision. This diff removes temporary file t2 in fixit.c and updates the test command accordingly. NFC. Repository: rL LLVM https://reviews.llvm.org/D34066 Files: fixit.c Index: fixit.c === --- fixit.c

[PATCH] D33366: Fix that global delete operator get's assigned to a submodule.

v.g.vassilev closed this revision. v.g.vassilev added a comment. r305118. https://reviews.llvm.org/D33366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r305118 - [modules] Fix that global delete operator get's assigned to a submodule.

Author: vvassilev Date: Fri Jun 9 16:36:28 2017 New Revision: 305118 URL: http://llvm.org/viewvc/llvm-project?rev=305118&view=rev Log: [modules] Fix that global delete operator get's assigned to a submodule. n the current local-submodule-visibility mode, as soon as we discover a virtual destruct

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL305117: [libclang] Merge multiple availability clauses when getting the platform's (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33478?vs=102050&id=102074#toc Repository:

r305117 - [libclang] Merge multiple availability clauses when getting the platform's

Author: arphaman Date: Fri Jun 9 16:29:45 2017 New Revision: 305117 URL: http://llvm.org/viewvc/llvm-project?rev=305117&view=rev Log: [libclang] Merge multiple availability clauses when getting the platform's availability Patch by Ronald Wampler! Differential Revision: https://reviews.llvm.org/

r305116 - Add -frewrite-imports flag.

Author: rsmith Date: Fri Jun 9 16:24:02 2017 New Revision: 305116 URL: http://llvm.org/viewvc/llvm-project?rev=305116&view=rev Log: Add -frewrite-imports flag. If specified, when preprocessing, the contents of imported .pcm files will be included in preprocessed output. The resulting preprocesse

r305110 - [ODRHash] Add support for TemplateArgument types.

Author: rtrieu Date: Fri Jun 9 16:00:10 2017 New Revision: 305110 URL: http://llvm.org/viewvc/llvm-project?rev=305110&view=rev Log: [ODRHash] Add support for TemplateArgument types. Recommit r304592 that was reverted in r304618. r305104 should have fixed the issue. Modified: cfe/trunk/lib/

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

On Fri, Jun 9, 2017 at 11:28 PM, David Blaikie wrote: > Looks all good OK, thank you. > please commit whenever you're ready - if you don't have > commit access, I (or anyone else with commit access) can commit this for > you. Will re-test and commit in +~12 hours. > On Tue, Jun 6, 2017 at 1:57 P

Re: r305103 - Bringt back -triple so the test passes on non-x86.

Thanks! Maybe we could run it on any -triple x86_64... On 09/06/17 21:47, Benjamin Kramer via cfe-commits wrote: Author: d0k Date: Fri Jun 9 14:47:36 2017 New Revision: 305103 URL: http://llvm.org/viewvc/llvm-project?rev=305103&view=rev Log: Bringt back -triple so the test passes on non-x86.

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

Looks all good, please commit whenever you're ready - if you don't have commit access, I (or anyone else with commit access) can commit this for you. On Tue, Jun 6, 2017 at 1:57 PM Roman Lebedev wrote: > On Tue, Jun 6, 2017 at 8:52 PM, David Blaikie wrote: > > > > > > On Tue, Jun 6, 2017 at 3:5

r305104 - [ODRHash] Skip inline namespaces when hashing.

Author: rtrieu Date: Fri Jun 9 15:11:51 2017 New Revision: 305104 URL: http://llvm.org/viewvc/llvm-project?rev=305104&view=rev Log: [ODRHash] Skip inline namespaces when hashing. Speculatively try to fix the underlying issue from r304592, of underlying types being confused when inline namespaces

r305103 - Bringt back -triple so the test passes on non-x86.

Author: d0k Date: Fri Jun 9 14:47:36 2017 New Revision: 305103 URL: http://llvm.org/viewvc/llvm-project?rev=305103&view=rev Log: Bringt back -triple so the test passes on non-x86. Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c Modified: cfe/trunk/test/Sema/2010-05-31-palignr.c URL: htt

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks great, thanks! https://reviews.llvm.org/D29951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

rsmith added a comment. Is there any way to add a test for this? Does it affect the behavior of clang or any in-tree clang-based tools? If this isn't visible through existing in-tree tools, it would be useful to add to unittests/ a rough skeleton of what you're doing, so you can add tests for

r305101 - Add #pragma clang module build/endbuild pragmas for performing a module build

Author: rsmith Date: Fri Jun 9 14:22:32 2017 New Revision: 305101 URL: http://llvm.org/viewvc/llvm-project?rev=305101&view=rev Log: Add #pragma clang module build/endbuild pragmas for performing a module build as part of a compilation. This is intended for two purposes: 1) Writing self-containe

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

yawanng updated this revision to Diff 102064. yawanng marked 6 inline comments as done. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/FileOpenFlagCheck.cpp clang-tidy/android

[PATCH] D16717: [clang-tidy] Add non-constant references in function parameters check.

lebedev.ri added a comment. // Don't warn on dependent types in templates. Hmm, i wanted to try to fix my Bug 32683 about templated references being ignored, and i found out that it is actually intentional... Reading https://google.github.io/styl

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler marked 2 inline comments as done. rdwampler added a comment. I don't have commit access, but I would grateful if you can commit it. https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

arphaman added a comment. Do you have commit access or shall I commit it on your behalf? https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

r305094 - [ASTMatchers] Fix use after free.

Author: d0k Date: Fri Jun 9 12:55:42 2017 New Revision: 305094 URL: http://llvm.org/viewvc/llvm-project?rev=305094&view=rev Log: [ASTMatchers] Fix use after free. Found by asan. Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp Modified: cfe/trunk/lib/ASTMatchers/Dynamic/Parser.cpp UR

[PATCH] D34055: Be more strict when checking the -flto option value

yamaguchi updated this revision to Diff 102051. yamaguchi added a comment. I think we don't need additional testcase, because this is non-functional change. Driver.cpp will emit error if value was not "thin" nor "full". This testcase is at clang/test/CodeGen/thinlto-backend-option.ll. https://

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

chh added a comment. I understood the mentioned ODR issue, which is useful for users to understand the compiler choice. For -fno-exceptions users, they should change source code to work with mixed cases, or just ignore mixed cases and suppress this warning. https://reviews.llvm.org/D34002 _

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

rdwampler updated this revision to Diff 102050. rdwampler added a comment. Remove an unnecessary check when determining a mismatch of availabilities Simplify invocation of FileCheck in availability.c https://reviews.llvm.org/D33478 Files: test/Index/availability.c tools/libclang/CIndex.cpp

[PATCH] D32942: [clang-tidy] readability-function-size: add NestingThreshold param.

lebedev.ri added a comment. In https://reviews.llvm.org/D32942#776915, @malcolm.parsons wrote: > Does this check consider `else if` chains to be nesting? > > void nesting() { // 1 > if (true) { // 2 >int j; > } else if (true) { // 2 or 3? >int j; > } else if (true) {

[PATCH] D17143: [Sema] PR25156 Crash when parsing dtor call on incomplete type

hintonda updated this revision to Diff 102049. hintonda added a comment. Rebase and move test to existing file. https://reviews.llvm.org/D17143 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/nested-name-spec.cpp Index: test/SemaCXX/nested-name-spec.cpp ==

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. In https://reviews.llvm.org/D34002#776948, @chh wrote: > Thanks for providing the ODR reason for Android -fno-exceptions users to > change source code or suppress this warning themselves. I'm not sure I understand your comment. Could you clarify? Here's an explanation

[PATCH] D34022: Repair 2010-05-31-palignr.c test

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r305089. https://reviews.llvm.org/D34022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r305089 - Repair 2010-05-31-palignr.c test

Author: vvassilev Date: Fri Jun 9 11:42:26 2017 New Revision: 305089 URL: http://llvm.org/viewvc/llvm-project?rev=305089&view=rev Log: Repair 2010-05-31-palignr.c test This test was silently failing since a long time because it failed to include stdlib.h (as it's running in a freestanding enviro

r305087 - support operator keywords used in Windows SDK

Author: erichkeane Date: Fri Jun 9 11:29:35 2017 New Revision: 305087 URL: http://llvm.org/viewvc/llvm-project?rev=305087&view=rev Log: support operator keywords used in Windows SDK to support operator keywords used in Windows SDK, alter token type when seen in system headers Hello, I submitte

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

v.g.vassilev created this revision. This allows multi-module / incremental compilation environments to have unique initializer symbols. Patch by Axel Naumann! Repository: rL LLVM https://reviews.llvm.org/D34059 Files: lib/CodeGen/CGDeclCXX.cpp Index: lib/CodeGen/CGDeclCXX.cpp =

[PATCH] D29951: Load lazily the template specialization in multi-module setups.

v.g.vassilev updated this revision to Diff 102045. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Address comments. https://reviews.llvm.org/D29951 Files: include/clang/Serialization/ASTReader.h lib/Serialization/ASTReaderDecl.cpp Index: lib/Serialization/ASTR

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

chh added a comment. Thanks for providing the ODR reason for Android -fno-exceptions users to change source code or suppress this warning themselves. https://reviews.llvm.org/D34002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D34055: Be more strict when checking the -flto option value

tejohnson added a comment. Make sure you add cfe-commits to the mailing list for clang changes (and llvm-commits for llvm changes, I accidentally added that one first and then fixed it), since all patches should go to the full mailing list. This fix looks correct to me. Please add a test case t

[PATCH] D33499: [PPC] PPC32/Darwin ABI info

kparzysz added a comment. Ping. The bug reporter has verified that this patch fixes the problem. Repository: rL LLVM https://reviews.llvm.org/D33499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:60 + + LangOptions LangOpts = getLangOpts(); + SourceRange FlagsRange(FlagArg->getLocStart(), FlagArg->ge

Re: r305044 - [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only.

Hi Manuel, Apologies, I will start a RFC giving more context. Also I’ll ask for feedback for another preprocessor change related to this I’d propose as follow-up. > On Jun 9, 2017, at 3:07 AM, Manuel Klimek wrote: > > Hey ho, > > this looks like a really cool new feature, and the CL looks goo

[PATCH] D33467: Fix LLVM build errors if necent build of GCC 7 is used

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. @rsmith, what's the right way to proceed here? Repository: rL LLVM https://reviews.llvm.org/D33467 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] r305082 - [clang-tidy] readability-function-size: add NestingThreshold param.

Author: lebedevri Date: Fri Jun 9 09:22:10 2017 New Revision: 305082 URL: http://llvm.org/viewvc/llvm-project?rev=305082&view=rev Log: [clang-tidy] readability-function-size: add NestingThreshold param. Summary: Finds compound statements which create next nesting level after `NestingThreshold`

r305076 - [DebugInfo] Fix comment, NFC.

Author: abataev Date: Fri Jun 9 08:55:08 2017 New Revision: 305076 URL: http://llvm.org/viewvc/llvm-project?rev=305076&view=rev Log: [DebugInfo] Fix comment, NFC. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llvm.org/viewvc/llv

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Thanks Alex... On Fri, Jun 9, 2017 at 1:02 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Fixes committed in r305024 and r305057. > > On Fri, Jun 9, 2017 at 12:07 AM, Alexander Kornienko > wrote: > >> It looks like the buildbots have exceptions turned off by defau

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL305075: [DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D33735?vs=101908&id=102024#toc Repository:

r305075 - [DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer.

Author: abataev Date: Fri Jun 9 08:40:18 2017 New Revision: 305075 URL: http://llvm.org/viewvc/llvm-project?rev=305075&view=rev Log: [DebugInfo] Add kind of ImplicitParamDecl for emission of FlagObjectPointer. Summary: If the first parameter of the function is the ImplicitParamDecl, codegen auto

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dberris updated this revision to Diff 102018. dberris edited the summary of this revision. dberris added a comment. Adding related bug. https://reviews.llvm.org/D34052 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/xray-log-args-class.cpp Index: test/Sema/xray-log-args-class.cpp =

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dberris created this revision. Before this change, we couldn't capture the `this` pointer that's implicitly the first argument of class member functions. There are some interesting things we can do with capturing even just this single argument for zero-argument member functions. https://reviews.

[PATCH] D34050: Support capturing the implicit `this` argument to C++ class member functions

dberris abandoned this revision. dberris added a comment. Fail... it's been a while since I've done this. Will try again. https://reviews.llvm.org/D34050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

r305068 - Revert of r305066 "Reapply Frontend support for Nios2 target"

Author: n.bozhenov Date: Fri Jun 9 07:09:29 2017 New Revision: 305068 URL: http://llvm.org/viewvc/llvm-project?rev=305068&view=rev Log: Revert of r305066 "Reapply Frontend support for Nios2 target" Removed: cfe/trunk/include/clang/Basic/BuiltinsNios2.def cfe/trunk/test/Driver/nios2-cpu.c

[clang-tools-extra] r305067 - [clang-tools-extra] ReleaseNotes.rst: test commit: whitespace fix

Author: lebedevri Date: Fri Jun 9 07:00:04 2017 New Revision: 305067 URL: http://llvm.org/viewvc/llvm-project?rev=305067&view=rev Log: [clang-tools-extra] ReleaseNotes.rst: test commit: whitespace fix Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/

r305066 - Reapply "Frontend support for Nios2 target"

Author: n.bozhenov Date: Fri Jun 9 05:56:18 2017 New Revision: 305066 URL: http://llvm.org/viewvc/llvm-project?rev=305066&view=rev Log: Reapply "Frontend support for Nios2 target" Summary: - Implements TargetInfo class for Nios2 target. - Enables handling of -march and -mcpu options for Nios2 ta

Re: r305044 - [libclang] Introduce a new parsing option 'CXTranslationUnit_SingleFileParse' that puts preprocessor in a mode for parsing a single file only.

Hey ho, this looks like a really cool new feature, and the CL looks good to me; I was wondering whether in the future we can send CLs like this through pre-commit review, or have an RFC email thread. If you have more stuff landing, a single RFC email thread describing how the features work togethe

r305061 - Speed up preamble loading

Author: erikjv Date: Fri Jun 9 03:29:58 2017 New Revision: 305061 URL: http://llvm.org/viewvc/llvm-project?rev=305061&view=rev Log: Speed up preamble loading Cache filename - SourceLocation pairs to speed up preamble loading and global completion. This is especially relevant for windows, where p

[PATCH] D33493: Speed up preamble loading

This revision was automatically updated to reflect the committed changes. Closed by commit rL305061: Speed up preamble loading (authored by erikjv). Changed prior to commit: https://reviews.llvm.org/D33493?vs=101995&id=102003#toc Repository: rL LLVM https://reviews.llvm.org/D33493 Files:

Re: [clang-tools-extra] r304977 - [clang-tidy] New checker to replace dynamic exception specifications

Fixes committed in r305024 and r305057. On Fri, Jun 9, 2017 at 12:07 AM, Alexander Kornienko wrote: > It looks like the buildbots have exceptions turned off by default, so the > tests need to use `-fexceptions` explicitly. Testing a fix... > > On Thu, Jun 8, 2017 at 11:26 PM, Galina Kistanova >

[PATCH] D34002: [clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed.

alexfh added a comment. In https://reviews.llvm.org/D34002#776551, @chh wrote: > Android source is suppressing misc-noexcept-move-constructor warnings > because -fno-exceptions is used and Android does not like to add more > exception specific code. As I've said, the lack of `noexcept` on mov

[clang-tools-extra] r305057 - Revert "[clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed."

Author: alexfh Date: Fri Jun 9 02:34:58 2017 New Revision: 305057 URL: http://llvm.org/viewvc/llvm-project?rev=305057&view=rev Log: Revert "[clang-tidy] When" -fno-exceptions is used", this warning is better to be suppressed." This reverts commit r304949. https://reviews.llvm.org/D34002#775830