r304872 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-06 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Wed Jun 7 01:31:55 2017 New Revision: 304872 URL: http://llvm.org/viewvc/llvm-project?rev=304872&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe/trunk/lib/

r304870 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

2017-06-06 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Wed Jun 7 01:25:05 2017 New Revision: 304870 URL: http://llvm.org/viewvc/llvm-project?rev=304870&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema

Re: r304852 - Improve error recovery for missing 'template' keyword in contexts where the

2017-06-06 Thread Mikael Holmén via cfe-commits
Hi Richard, See below. On 06/07/2017 02:29 AM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Jun 6 19:29:44 2017 New Revision: 304852 URL: http://llvm.org/viewvc/llvm-project?rev=304852&view=rev Log: Improve error recovery for missing 'template' keyword in contexts where the t

[PATCH] D33977: [libcxx][WIP] Experimental support for a scheduler for use in the parallel stl algorithms

2017-06-06 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington created this revision. Herald added a reviewer: EricWF. This patch adds a simple work-stealing scheduler meant for use as a fallback implementation for the C++17 parallel stl algorithms. This scheme follows a very simple fork/join API that should be easy to map onto different und

[PATCH] D33976: [clang] Fix format specifiers fixits

2017-06-06 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Interestingly I got the opposite issue recently: calling through a macro with a single format specifier was *adding* new specific in the fixit in some conditions. I'm not the best person to review this change though, let me add a few folks. Repository: rL LLVM

[PATCH] D33955: [libcxx] [test] Remove a Clang/C2 workaround.

2017-06-06 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter accepted this revision. CaseyCarter added a comment. This revision is now accepted and ready to land. As the party who originally put this workaround in place, I'll happily certify that it never affected any platforms that anyone but we Microsofters care about. I'll take responsibili

r304869 - Update libdeps to add BinaryFormat, introduced in r304864.

2017-06-06 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Jun 6 23:48:49 2017 New Revision: 304869 URL: http://llvm.org/viewvc/llvm-project?rev=304869&view=rev Log: Update libdeps to add BinaryFormat, introduced in r304864. Modified: cfe/trunk/lib/AST/CMakeLists.txt cfe/trunk/lib/Driver/CMakeLists.txt Modified: cfe/tr

r304868 - Reorder and reformat.

2017-06-06 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Tue Jun 6 23:48:45 2017 New Revision: 304868 URL: http://llvm.org/viewvc/llvm-project?rev=304868&view=rev Log: Reorder and reformat. Modified: cfe/trunk/lib/AST/CMakeLists.txt Modified: cfe/trunk/lib/AST/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/cfe/trun

[PATCH] D26065: Improve diagnostics if friend function redefines file-level function.

2017-06-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 101666. sepavloff added a comment. Rebased and enhance check https://reviews.llvm.org/D26065 Files: lib/Sema/SemaDeclCXX.cpp test/CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp Index: test/CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp =

[PATCH] D26065: Improve diagnostics if friend function redefines file-level function.

2017-06-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:646 + // in this case, redefinition will be diagnosed later. + (New->isInlineSpecified() || !New->isOutOfLine() || + !New->getLexicalDeclContext()->isRecord())) { --

[PATCH] D33976: [clang] Fix format specifiers fixits

2017-06-06 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. This diff fixes printf "fixits" in the case when there is a wrapping macro and the format string needs multiple replacements. In the presence of a macro there was an extra logic in EditedSource.cpp to handle multiple uses of the same macro argument (see the old co

r304863 - Fixed warning: 'virtual void clang::ExternalASTSource::CompleteType(clang::ObjCInterfaceDecl*)' was hidden.

2017-06-06 Thread Galina Kistanova via cfe-commits
Author: gkistanova Date: Tue Jun 6 21:44:42 2017 New Revision: 304863 URL: http://llvm.org/viewvc/llvm-project?rev=304863&view=rev Log: Fixed warning: 'virtual void clang::ExternalASTSource::CompleteType(clang::ObjCInterfaceDecl*)' was hidden. Modified: cfe/trunk/include/clang/AST/ExternalA

r304862 - Fix a couple of class template argument deduction crashes with libc++'s tuple.

2017-06-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 6 21:42:27 2017 New Revision: 304862 URL: http://llvm.org/viewvc/llvm-project?rev=304862&view=rev Log: Fix a couple of class template argument deduction crashes with libc++'s tuple. RecursiveASTVisitor was not properly recursing through a SubstTemplateTypeParmTypes,

r304859 - [WebAssembly] Set MaxAtomicInlineWidth to 64.

2017-06-06 Thread Dan Gohman via cfe-commits
Author: djg Date: Tue Jun 6 21:22:40 2017 New Revision: 304859 URL: http://llvm.org/viewvc/llvm-project?rev=304859&view=rev Log: [WebAssembly] Set MaxAtomicInlineWidth to 64. The WebAssembly threads proposal has changed such that C++ implementations can now declare that atomics up to 64 bits are

[PATCH] D17215: [Sema] Fix PR14211 Crash for explicit instantiation of overloaded template function within class template

2017-06-06 Thread don hinton via Phabricator via cfe-commits
hintonda added a comment. Since I don't have commit access, could you commit this for me? thanks... don https://reviews.llvm.org/D17215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

2017-06-06 Thread don hinton via Phabricator via cfe-commits
hintonda updated this revision to Diff 101659. hintonda added a comment. Herald added a subscriber: xazax.hun. In order to fix diagnostic corruption in some of the buildbot tests (unable to reproduce locally): - make NoexceptMacro a static variable so it's lifetime doesn't end when UseNoexceptCh

[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

2017-06-06 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik marked an inline comment as done. tzik added a comment. In https://reviews.llvm.org/D33875#774293, @rsmith wrote: > Looks good to me, thanks! Do you need someone to commit this for you? Yes, could you commit this? https://reviews.llvm.org/D33875 ___

r304852 - Improve error recovery for missing 'template' keyword in contexts where the

2017-06-06 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Jun 6 19:29:44 2017 New Revision: 304852 URL: http://llvm.org/viewvc/llvm-project?rev=304852&view=rev Log: Improve error recovery for missing 'template' keyword in contexts where the template is valid with or without it (with different meanings). If we see "dependent.x<.

[libcxx] r304847 - [test] Test changes to accommodate LWG 2904 "Make variant move-assignment more exception safe"

2017-06-06 Thread Casey Carter via cfe-commits
Author: caseycarter Date: Tue Jun 6 19:06:04 2017 New Revision: 304847 URL: http://llvm.org/viewvc/llvm-project?rev=304847&view=rev Log: [test] Test changes to accommodate LWG 2904 "Make variant move-assignment more exception safe" Also: Move constexpr / triviality extension tests into the std

r304840 - [DOXYGEN] Corrected several typos and incorrect parameters description that Sony's techinical writer found during review.

2017-06-06 Thread Ekaterina Romanova via cfe-commits
Author: kromanova Date: Tue Jun 6 17:58:01 2017 New Revision: 304840 URL: http://llvm.org/viewvc/llvm-project?rev=304840&view=rev Log: [DOXYGEN] Corrected several typos and incorrect parameters description that Sony's techinical writer found during review. I got an OK from Eric Christopher to c

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

2017-06-06 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 101631. CaseyCarter edited the summary of this revision. CaseyCarter added a comment. Incorporate the libcxx test tree `special_member_gen` test into the std test, making my per-SMF triviality tests unnecessary. https://reviews.llvm.org/D32385 Files:

Re: [PATCH] D33719: Add _Float16 as a C/C++ source language type

2017-06-06 Thread Richard Smith via cfe-commits
On 5 June 2017 at 03:49, Sjoerd Meijer via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Yes, initially I wanted to unconditionally support _Float16, but now that > you asked how about it, I agree it makes more sense to enable it for C11 > and C++11 and have: KEYWORD(_Float16

[clang-tools-extra] r304837 - Adjust SetVersionPrinter call for D33899

2017-06-06 Thread Dimitry Andric via cfe-commits
Author: dim Date: Tue Jun 6 16:54:45 2017 New Revision: 304837 URL: http://llvm.org/viewvc/llvm-project?rev=304837&view=rev Log: Adjust SetVersionPrinter call for D33899 Summary: In D33899, I'm adding a `raw_ostream &` parameter to the function objects passed to `cl::SetVersionPrinter`. Adjust

[PATCH] D33959: Adjust SetVersionPrinter call for D33899

2017-06-06 Thread Dimitry Andric via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304837: Adjust SetVersionPrinter call for D33899 (authored by dim). Changed prior to commit: https://reviews.llvm.org/D33959?vs=101623&id=101630#toc Repository: rL LLVM https://reviews.llvm.org/D339

r304836 - Print registered targets in clang's version information

2017-06-06 Thread Dimitry Andric via cfe-commits
Author: dim Date: Tue Jun 6 16:54:21 2017 New Revision: 304836 URL: http://llvm.org/viewvc/llvm-project?rev=304836&view=rev Log: Print registered targets in clang's version information Summary: Other llvm tools display their registered targets when showing version information, but for some reaso

[PATCH] D33732: Catch invalid bitwise operation on vector of floats

2017-06-06 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/Sema/ext_vector_ops.c:22 + int array2[17]; + // FIXME: error message below needs type! + (void)(array2[v2ua]); // expected-error{{array subscript is no

[PATCH] D33719: Add _Float16 as a C/C++ source language type

2017-06-06 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. > About the tests and using --target=aarch64: you're right that there should > nothing be ARM specific here, but it is just that for Aarch64 it will show > "half" IR types which I preferred, while it looks like x86 way of dealing > with is to convert it and work on i16

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

2017-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Please start a thread on cfe-dev about this; most developers don't read cfe-commits, and thinking about it a bit more, I'm not confident omitting frame pointers is really a good default. I would guess there's existing code which depends on frame pointers to come up wi

[PATCH] D33900: Print registered targets in clang's version information

2017-06-06 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D33959: Adjust SetVersionPrinter call for D33899

2017-06-06 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. In https://reviews.llvm.org/D33899, I'm adding a `raw_ostream &` parameter to the function objects passed to `cl::SetVersionPrinter`. Adjust the call in clang-apply-replacements for this. https://reviews.llvm.org/D33959 Files: clang-apply-replacements/tool/ClangAp

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

2017-06-06 Thread Roman Lebedev via cfe-commits
On Tue, Jun 6, 2017 at 8:52 PM, David Blaikie wrote: > > > On Tue, Jun 6, 2017 at 3:59 AM Roman Lebedev via Phabricator > wrote: >> >> lebedev.ri added a comment. >> >> In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: >> >> > I still feel like that's more testing than would be ideal (d

[PATCH] D33955: [libcxx] [test] Remove a Clang/C2 workaround.

2017-06-06 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Remove a Clang/C2 workaround. Clang/LLVM doesn't need this workaround. https://reviews.llvm.org/D33955 Files: test/std/utilities/optional/optional.object/optional.object.mod/reset.pass.cpp Index: test/std/utilities/optional/optional.object/o

[PATCH] D33953: [libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and make it friendlier to C1XX.

2017-06-06 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Add more tests to tuple_size_structured_bindings.pass.cpp and make it friendlier to C1XX. Style/paranoia: 42.1 doesn't have an exact binary representation. Although this doesn't cause failures, it makes me uncomfortable, so I'm changing it to 42.5

[PATCH] D30375: Function with unparsed body is a definition

2017-06-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. If you want to take this path, you should also add `ActOnStartOfFunctionBody` calls to the other parts of the parser that parse function definitions: `Parser::ParseLateTemplatedFuncDef`, `Parser::ParseLexedObjCMethodDefs`, and `Parser::ParseLexedMethodDefs`. You should a

[PATCH] D33941: [Driver] Add test to cover case when LSan is not supported

2017-06-06 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rL LLVM https://reviews.llvm.org/D33941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

2017-06-06 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Do you need someone to commit this for you? https://reviews.llvm.org/D33875 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D33926: [clang] Remove double semicolons. NFC.

2017-06-06 Thread Mandeep Singh Grang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304823: [clang] Remove double semicolons. NFC. (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D33926?vs=101506&id=101604#toc Repository: rL LLVM https://reviews.llvm.org/D33

r304823 - [clang] Remove double semicolons. NFC.

2017-06-06 Thread Mandeep Singh Grang via cfe-commits
Author: mgrang Date: Tue Jun 6 14:47:56 2017 New Revision: 304823 URL: http://llvm.org/viewvc/llvm-project?rev=304823&view=rev Log: [clang] Remove double semicolons. NFC. Reviewers: rsmith, craig.topper, efriedma Reviewed By: efriedma Subscribers: efriedma, cfe-commits Tags: #clang-c Differe

[PATCH] D33493: Speed up preamble loading

2017-06-06 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. In https://reviews.llvm.org/D33493#774264, @arphaman wrote: > Can you use a local map in `TranslateStoredDiagnostics` instead of storing > one in the `ASTUnit`, or do you need to keep it around? The whole purpose is to use it between different TranslateStoredDiagnostics

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

2017-06-06 Thread Kuang He via Phabricator via cfe-commits
kuang_he updated this revision to Diff 101601. kuang_he added a comment. Patch updated addressing comment. https://reviews.llvm.org/D33833 Files: lib/AST/DeclCXX.cpp test/SemaCXX/PR33189.cpp Index: test/SemaCXX/PR33189.cpp ==

[PATCH] D33493: Speed up preamble loading

2017-06-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. Can you use a local map in `TranslateStoredDiagnostics` instead of storing one in the `ASTUnit`, or do you need to keep it around? https://reviews.llvm.org/D33493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D33926: [clang] Remove double semicolons. NFC.

2017-06-06 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. You don't need to ask for review for a trivial change like this. https://reviews.llvm.org/D33926 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D26065: Improve diagnostics if friend function redefines file-level function.

2017-06-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:646 + // in this case, redefinition will be diagnosed later. + (New->isInlineSpecified() || !New->isOutOfLine() || + !New->getLexicalDeclContext()->isRecord())) { ---

[PATCH] D27850: [libcxx] add missing constexpr to optional::value_or

2017-06-06 Thread Casey Carter via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304813: add missing constexpr to optional::value_or (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D27850?vs=82653&id=101597#toc Repository: rL LLVM https://reviews.llv

[libcxx] r304813 - add missing constexpr to optional::value_or

2017-06-06 Thread Casey Carter via cfe-commits
Author: caseycarter Date: Tue Jun 6 13:47:26 2017 New Revision: 304813 URL: http://llvm.org/viewvc/llvm-project?rev=304813&view=rev Log: add missing constexpr to optional::value_or [Credit to cpplearner] Differential Revision: https://reviews.llvm.org/D27850 Modified: libcxx/trunk/include/

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

2017-06-06 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. It seems that there's a slight bug in the patch: If I print the output of the following code using `c-index-test -test-load-source all`: void bar2(void) __attribute__((availability(macosx, introduced=10.4))) __attribute__((availability(macosx, deprecated=10.5, me

Re: [PATCH] D33102: [clang] Implement -Wcast-qual for C++

2017-06-06 Thread David Blaikie via cfe-commits
On Tue, Jun 6, 2017 at 3:59 AM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: > > > I still feel like that's more testing than would be ideal (does the > context of the cast matter? Weth

[clang-tools-extra] r304811 - [clang-tidy] misc-inaccurate-erase: support call by pointer

2017-06-06 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Tue Jun 6 12:49:45 2017 New Revision: 304811 URL: http://llvm.org/viewvc/llvm-project?rev=304811&view=rev Log: [clang-tidy] misc-inaccurate-erase: support call by pointer + replace matchesName calls with more efficient alternatives. Modified: clang-tools-extra/trunk/cla

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

2017-06-06 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. I concur this, linkers are to used through a compiler frontend and `libtool` (which wraps a compiler). Repository: rL LLVM https://reviews.llvm.org/D33726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

2017-06-06 Thread Rui Ueyama via Phabricator via cfe-commits
ruiu added a comment. I'm totally against adding per-OS path knowledge to our linker. Compilers already know include paths and I don't want to maintain another list of paths in the linker. Also this can be more confusing than useful when you are doing cross-linking. For all OSes other than Net

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

2017-06-06 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a subscriber: ruiu. krytarowski added a comment. @ruiu what's your opinion on this? Repository: rL LLVM https://reviews.llvm.org/D33726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

2017-06-06 Thread Joey Gouly via Phabricator via cfe-commits
joey created this revision. Herald added subscribers: Anastasia, yaxunl. This adds get_kernel_max_sub_group_size_for_ndrange and get_kernel_sub_group_count_for_ndrange. Note this also changes err_opencl_requires_extension to print the name of the function that the diagnostic is warning about.

[PATCH] D33944: git-clang-format: Add --cached option to format index

2017-06-06 Thread Kevin Locke via Phabricator via cfe-commits
kevinoid created this revision. kevinoid added a project: clang-tools-extra. Add --cached option to git-clang-format which behaves analogously to the use of --cached for other git subcommands, by causing the operation to work against the index state rather than the working directory state. This

[PATCH] D33478: [libclang] When getting platform availabilities, merge multiple declarations if possible

2017-06-06 Thread Ronald Wampler via Phabricator via cfe-commits
rdwampler updated this revision to Diff 101569. rdwampler added a comment. Rearrange `if` statements in `getCursorPlatformAvailabilityForDecl` to return early if we do not need to merge availability attributes. Use ranged for loop. https://reviews.llvm.org/D33478 Files: test/Index/availabili

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

2017-06-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 101571. ABataev marked an inline comment as done. ABataev added a comment. Address John comments. https://reviews.llvm.org/D33735 Files: include/clang/AST/Decl.h lib/AST/ASTImporter.cpp lib/AST/Decl.cpp lib/AST/DeclObjC.cpp lib/CodeGen/CGBlocks.cp

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

2017-06-06 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Basic/Targets.cpp:7678 +for (const char *feature : allFeatures) { +Features[feature] = isFeatureSupportedByCPU(feature, CPU); +

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

2017-06-06 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev marked 7 inline comments as done. ABataev added inline comments. Comment at: include/clang/AST/Decl.h:1387 +IPK_CapturedContext, /// Parameter for captured context +IPK_GeneralParam,/// General implicit parameter + }; rjmccall wrote: > I woul

Re: [clang-tools-extra] r304583 - [clang-tidy] Add `const` to operator() to fix a warning.

2017-06-06 Thread Alexander Kornienko via cfe-commits
On Mon, Jun 5, 2017 at 7:11 PM, David Blaikie wrote: > what was the warning? > I don't remember the exact warning text, but the idea was that a non-const operator() could not be called. The change is reasonable in any case: the operator() here has no reason to be non-const. > > On Fri, Jun 2,

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

2017-06-06 Thread don hinton via Phabricator via cfe-commits
hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopening due to test failures on Linux -- was rolled back. https://reviews.llvm.org/D20693 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D33401: [mips] Add runtime options to enable/disable generation of madd.fmt, msub.fmt

2017-06-06 Thread Stefan Maksimovic via Phabricator via cfe-commits
smaksimovic updated this revision to Diff 101562. smaksimovic added a comment. Provided define checks, one when the target feature is present, other when the feature isn't provided at all (default). https://reviews.llvm.org/D33401 Files: include/clang/Driver/Options.td lib/Basic/Targets.c

[PATCH] D33941: [Driver] Add test to cover case when LSan is not supported

2017-06-06 Thread Maxim Ostapenko via Phabricator via cfe-commits
m.ostapenko created this revision. This commit adds a testcase for uncovered code paths in LSan options parsing logic in driver. Repository: rL LLVM https://reviews.llvm.org/D33941 Files: test/Driver/fsanitize.c Index: test/Driver/fsanitize.c

[PATCH] D27918: [analyzer] OStreamChecker

2017-06-06 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 101549. gamesh411 marked an inline comment as done. gamesh411 added a comment. Update diff. https://reviews.llvm.org/D27918 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checke

[PATCH] D27918: [analyzer] OStreamChecker

2017-06-06 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Update diff. Comment at: lib/StaticAnalyzer/Checkers/OStreamFormatChecker.cpp:263-282 + mutable IdentifierInfo *II_BasicOstream, *II_Flags, *II_Setf, *II_Unsetf, + *II_Setiosflags, *II_Resetiosflags, *

[PATCH] D33857: Correctly Indent Nested JavaScript Literals.

2017-06-06 Thread Martin Probst via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304791: clang-format: [JS] Correctly Indent Nested JavaScript Literals. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D33857?vs=101296&id=101547#toc Repository: rL LLVM ht

r304791 - clang-format: [JS] Correctly Indent Nested JavaScript Literals.

2017-06-06 Thread Martin Probst via cfe-commits
Author: mprobst Date: Tue Jun 6 07:38:29 2017 New Revision: 304791 URL: http://llvm.org/viewvc/llvm-project?rev=304791&view=rev Log: clang-format: [JS] Correctly Indent Nested JavaScript Literals. Nested literals are sometimes only indented by 2 spaces, instead of respecting the IndentWidth opti

[PATCH] D33857: Correctly Indent Nested JavaScript Literals.

2017-06-06 Thread Martin Probst via Phabricator via cfe-commits
mprobst accepted this revision. mprobst added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D33857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

2017-06-06 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good, but I'm wondering if we should also change the default in clang-apply-replacements itself. https://reviews.llvm.org/D33930 ___ cfe

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-06-06 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:269 + // Support case-sensitive and case insensitive matching. + Style.IncludeRegexCaseInsensitive = false; + EXPECT_EQ("#include \"GTest/GTest.h\"\n" I think this TEST is only for

[PATCH] D33447: clang-format: add option to merge empty function body

2017-06-06 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. ping https://reviews.llvm.org/D33447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32480: clang-format: Add CompactNamespaces option

2017-06-06 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. So how do I proceed? 1. Keep the CompactNamespace option, and make "compacted" namespaces always add at most one level of indentation 2. Or assume that this can only ever usefully work with the behavior of NI_None and add an additional enum value NI_Compact. And should we

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

2017-06-06 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. In https://reviews.llvm.org/D33589#769893, @krasimir wrote: > I think that what you're trying to solve is not practically that important, > is unlikely to improve the handling of comments, and will add a lot of > complexity. Not sure the 'approach' I have in this patch i

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

2017-06-06 Thread Christian Bruel via Phabricator via cfe-commits
chrib added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { efriedma wrote: > chrib wrote: > > efriedma wrote: > > > Specifically checking for "llvm::Tripl

[PATCH] D33401: [mips] Add runtime options to enable/disable generation of madd.fmt, msub.fmt

2017-06-06 Thread Simon Dardis via Phabricator via cfe-commits
sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. The new define also requires a test in test/Preprocessor/init.c - test that by default the new define isn't present, and in some case, when supplied with the -mno-madd4 that it is present.

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-06-06 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc marked an inline comment as done. chandlerc added a comment. Added more tests, PTAL? https://reviews.llvm.org/D33932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-06-06 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc updated this revision to Diff 101544. chandlerc added a comment. Add test coverage for the case-insensitive category logic. https://reviews.llvm.org/D33932 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/S

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

2017-06-06 Thread Christian Bruel via Phabricator via cfe-commits
chrib updated this revision to Diff 101543. chrib added a comment. Herald added a subscriber: kristof.beyls. - Merge branch 'master' of ssh://codex.cro.st.com/llvm-arm/clang - Don't need a frame pointer for EABIHF also (AAPCS) https://reviews.llvm.org/D31972 Files: lib/Driver/ToolChains/Clang

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-06-06 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm. Comment at: lib/Format/Format.cpp:1406 for (const auto &Category : Style.IncludeCategories) - CategoryRegexs.emplace_back(Category.Regex); + CategoryRege

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

2017-06-06 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev updated this revision to Diff 101540. v.g.vassilev added a comment. Use string. https://reviews.llvm.org/D33930 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === --- clang-tidy/t

[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

2017-06-06 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik marked an inline comment as done. tzik added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:5108 QualType UseType = isIndirect ? Context.getPointerType(Class) : Class; +UseType = UseType.withCVRQualifiers(LHS.get()->getType().getCVRQualifiers()); ExprVa

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

2017-06-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. (tested with: gcc version 6.3.0 20170516 (Debian 6.3.0-18) ```) Repository: rL LLVM https://reviews.llvm.org/D33102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D33102: [clang] Implement -Wcast-qual for C++

2017-06-06 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In https://reviews.llvm.org/D33102#773296, @dblaikie wrote: > I still feel like that's more testing than would be ideal (does the context > of the cast matter? Wether it's dereferenced, a struct member access, > assigned, initialized, etc - it doesn't look like it fr

[PATCH] D33875: PR27037: Use correct CVR qualifier on an upcast on method pointer call

2017-06-06 Thread Taiju Tsuiki via Phabricator via cfe-commits
tzik updated this revision to Diff 101536. tzik added a comment. Cover indirect case and non-CVR qualifiers https://reviews.llvm.org/D33875 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/PR27037.cpp Index: test/SemaCXX/PR27037.cpp

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

2017-06-06 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc created this revision. Herald added subscribers: mcrosier, sanjoy, klimek. This really is a collection of improvements to the rules for LLVM include sorting: - We have gmock headers now, so it adds support for those to one of the categories. - LLVM does use 'FooTest.cpp' files to test

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

2017-06-06 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan updated this revision to Diff 101533. yvvan added a comment. Remove global completion cache part because it's probably not always valid. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp =

[PATCH] D33644: Add default values for function parameter chunks

2017-06-06 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added a comment. Waiting for review... https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33930: Do not pick up by default the LLVM style if passing -format

2017-06-06 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev created this revision. This adds a new flag `-style` which is passed to `clang-apply-replacements` and defaults to `file` meaning it would pick up the closest `.clang-format` file in tree. Repository: rL LLVM https://reviews.llvm.org/D33930 Files: clang-tidy/tool/run-clang-t

r304781 - [ARM] Add support for target("arm") and target("thumb").

2017-06-06 Thread Florian Hahn via cfe-commits
Author: fhahn Date: Tue Jun 6 04:26:15 2017 New Revision: 304781 URL: http://llvm.org/viewvc/llvm-project?rev=304781&view=rev Log: [ARM] Add support for target("arm") and target("thumb"). Summary: This patch adds support for the target("arm") and target("thumb") attributes, which can be used to

[PATCH] D33676: Place implictly declared functions at block scope

2017-06-06 Thread Momchil Velikov via Phabricator via cfe-commits
chill updated this revision to Diff 101522. chill added a comment. Update 1 notes. The scopes for compound statements are explicitly marked as such, so then `Sema::ImplicitylDefineFunction` can ascend to the nearest enclosing scope. The function scopes (ones with `Scope:FnScope`) do not necessa

r304776 - Fix a mistake in the clang format documentation (BreakBeforeTernaryOperators)

2017-06-06 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Tue Jun 6 02:26:19 2017 New Revision: 304776 URL: http://llvm.org/viewvc/llvm-project?rev=304776&view=rev Log: Fix a mistake in the clang format documentation (BreakBeforeTernaryOperators) Patch sent through github by Jason Hsu Modified: cfe/trunk/docs/ClangFormatSty

[PATCH] D30375: Function with unparsed body is a definition

2017-06-06 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 101517. sepavloff added a comment. Rebased patch https://reviews.llvm.org/D30375 Files: include/clang/AST/Decl.h include/clang/Sema/Sema.h lib/Parse/Parser.cpp lib/Sema/SemaCUDA.cpp lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplateInstantiateDecl.cp