[PATCH] D33852: Enable __declspec(selectany) on linux

martell added a comment. > ! In https://reviews.llvm.org/D33852#772290, @davide wrote: > This assumption is not quite right. Also GCC, when targeting Linux, provides > a `-fms-extensions` flag. > There's a bunch of software out there that unfortunately has to target ELF > and build with `-fms-

[PATCH] D33852: Enable __declspec(selectany) on linux

davide added a comment. In https://reviews.llvm.org/D33852#772230, @martell wrote: > @Prazek it was not disabled by mistake. > This was a MS extension and it appeared as though the test case should have > been for windows. > I updated it and made the extension available to windows only. (MSVC,

[PATCH] D33852: Enable __declspec(selectany) on linux

martell added a comment. @Prazek it wasn't disabled by mistake. This was a MS extension and it appeared as though the test case should have been for windows. I updated it and made the extension available to windows only. (MSVC, Cygwin, Mingw etc) It didn't expect anyone would want a MS extension

[PATCH] D33852: Enable __declspec(selectany) on linux

Prazek added a comment. It seems that this is separate issue - we don't generate comdat for MachO. Indeed we should warn on not supported declspec for macho. https://reviews.llvm.org/D33852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: r304663 - Fixed warning: enum constant in boolean context.

Can we get a testcase for this bug? Seems like we can't have any coverage for the case where IsArmArch is supposed to be false. On 3 Jun 2017 9:47 am, "Galina Kistanova via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: gkistanova Date: Sat Jun 3 11:47:06 2017 New Revision: 304663 UR

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

mgorny added a comment. This causes a test failure with non-standard CLANG_RESOURCE_DIR: Command Output (stderr): -- /var/tmp/portage/sys-devel/clang-/work/x/y/clang-/test/Driver/baremetal.cpp:8:22: error: expected string not found in input // CHECK-V6M-C-SAME: "-resource-dir"

[libcxxabi] r304664 - [libcxxabi] HandleLLVMOptions in out of tree build

Author: martell Date: Sat Jun 3 12:23:19 2017 New Revision: 304664 URL: http://llvm.org/viewvc/llvm-project?rev=304664&view=rev Log: [libcxxabi] HandleLLVMOptions in out of tree build Differential revision: https://reviews.llvm.org/D33753 Modified: libcxxabi/trunk/cmake/Modules/HandleOutOfT

r304663 - Fixed warning: enum constant in boolean context.

Author: gkistanova Date: Sat Jun 3 11:47:06 2017 New Revision: 304663 URL: http://llvm.org/viewvc/llvm-project?rev=304663&view=rev Log: Fixed warning: enum constant in boolean context. Modified: cfe/trunk/lib/Driver/ToolChains/Linux.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Linux.cpp UR

r304662 - tests: silence -Wobjc-root-class warnings

Author: compnerd Date: Sat Jun 3 11:18:13 2017 New Revision: 304662 URL: http://llvm.org/viewvc/llvm-project?rev=304662&view=rev Log: tests: silence -Wobjc-root-class warnings Silence warnings about no ObjC class root for the types defined for the tests. Modified: cfe/trunk/test/CodeGenObjC

r304661 - CodeGen: fix section names for different file formats

Author: compnerd Date: Sat Jun 3 11:18:09 2017 New Revision: 304661 URL: http://llvm.org/viewvc/llvm-project?rev=304661&view=rev Log: CodeGen: fix section names for different file formats This changes the codegen to match the section names according to the ObjC rewriter as well as the runtime.

[clang-tools-extra] r304657 - [clang-tidy] Make misc-static-assert accept assert(!"msg")

Author: fgross Date: Sat Jun 3 05:13:55 2017 New Revision: 304657 URL: http://llvm.org/viewvc/llvm-project?rev=304657&view=rev Log: [clang-tidy] Make misc-static-assert accept assert(!"msg") Added negated string literals to the set of IsAlwaysFalse expressions to avoid flagging of assert(!"msg"

[PATCH] D33827: [clang-tidy] misc-static-assert shouldn't flag assert(!"msg")

This revision was automatically updated to reflect the committed changes. Closed by commit rL304657: [clang-tidy] Make misc-static-assert accept assert(!"msg") (authored by fgross). Changed prior to commit: https://reviews.llvm.org/D33827?vs=101197&id=101311#toc Repository: rL LLVM https://