Author: ericwf
Date: Thu May 25 23:09:38 2017
New Revision: 303966
URL: http://llvm.org/viewvc/llvm-project?rev=303966&view=rev
Log:
Workaround debug info bug in Clangs coroutine implementation
Modified:
libcxx/trunk/test/libcxx/experimental/language.support/support.coroutines/dialect_suppor
EricWF updated this revision to Diff 100361.
EricWF added a comment.
- Fix whitespace in `__config`.
@compnerd Any final thoughts?
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
include/__hash_table
include/__mutex_base
include/__split_buffer
includ
EricWF updated this revision to Diff 100358.
EricWF added a comment.
- remove `asprintf` declaration and definition entirely. It's not used anywhere
within libc++.
https://reviews.llvm.org/D33082
Files:
include/__config
include/__locale
include/locale
include/stdio.h
include/support/
EricWF added a comment.
In https://reviews.llvm.org/D33082#765282, @bcraig wrote:
> I think that we generally shouldn't be giving functions names that are
> already claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion
> that these should always be qualified as __libcpp_* symbol
Author: ericwf
Date: Thu May 25 22:02:54 2017
New Revision: 303963
URL: http://llvm.org/viewvc/llvm-project?rev=303963&view=rev
Log:
Get working in C++03.
Clang supports coroutines in all dialects; Therefore libc++ should too,
otherwise the Clang extension is unusable.
I'm not convinced extendi
Author: gbiv
Date: Thu May 25 21:56:51 2017
New Revision: 303962
URL: http://llvm.org/viewvc/llvm-project?rev=303962&view=rev
Log:
[docs] Point coroutine link to an actual document
Unsure if there's a better document, but what we had before led to a
404. :)
Modified:
cfe/trunk/www/cxx_status
t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Richard. I've committed this as r303957.
https://reviews.llvm.org/D33568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
Author: tnorthover
Date: Thu May 25 21:16:00 2017
New Revision: 303957
URL: http://llvm.org/viewvc/llvm-project?rev=303957&view=rev
Log:
Create valid LValue to represent null pointers in constant exprs
We were leaving the SubobjectDesignator in a surprising situation, where
it was allegedly valid
Author: ericwf
Date: Thu May 25 20:52:59 2017
New Revision: 303956
URL: http://llvm.org/viewvc/llvm-project?rev=303956&view=rev
Log:
Guard against older Clang versions.
Clang started providing -fcoroutines and defining __cpp_coroutines
way before it implemented the __builtin_coro_foo functions.
ahatanak updated this revision to Diff 100354.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D32520
Files:
include/clang/Sema/Sema.h
lib/CodeGen/CGExprScalar.cpp
lib/Sema/SemaExpr.cpp
test/CodeGen/fp16vec-ops.c
test/Sema/fp16vec-sema.c
Index: test/Sema/fp16vec-sema.c
===
bcraig added a comment.
> Are you suggesting that libc++ should stop declaring/defining these
> functions, at least publically?
I think that we generally shouldn't be giving functions names that are already
claimed elsewhere (like mbsnrtowcs and wcsnrtombs). It is my opinion that
these should
Author: ericwf
Date: Thu May 25 20:27:08 2017
New Revision: 303953
URL: http://llvm.org/viewvc/llvm-project?rev=303953&view=rev
Log:
Remove incorrect #ifdef guards around variant tests.
The tests were previously guarded by #if defined(_LIBCPP_VER) ||
defined(_MSVC_STL_VER),
which is both incorre
Shiz added a comment.
@EricWF: Thanks for reviewing! Is there anything else I need to do at this
point or will it be committed automatically?
Repository:
rL LLVM
https://reviews.llvm.org/D33178
___
cfe-commits mailing list
cfe-commits@lists.llvm
Author: caseycarter
Date: Thu May 25 20:00:56 2017
New Revision: 303951
URL: http://llvm.org/viewvc/llvm-project?rev=303951&view=rev
Log:
[test] Fix breakage from r303947 =(
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_s
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
One minor nit and LGTM.
Thanks!
-eric
Comment at: lib/Basic/Targets.cpp:5353
+// enable or disable thumb-mode per function
+if (isThumb())
Mi
Author: caseycarter
Date: Thu May 25 19:37:33 2017
New Revision: 303947
URL: http://llvm.org/viewvc/llvm-project?rev=303947&view=rev
Log:
[test] make_shared(...) is, uh, libc++-specific
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.c
EricWF added a comment.
In https://reviews.llvm.org/D33538#765225, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
>
> > In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> >
> > > Do we need to conditionalize this part of libc++? Nothing in the
> > > header a
Hi, Alexander!
On Thu, May 25, 2017 at 5:16 PM, Alexander Kornienko wrote:
>
>
> On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits"
> wrote:
>
> Author: eugenezelenko
> Date: Thu May 25 12:22:29 2017
> New Revision: 303884
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
> Lo
On 25 May 2017 19:22, "Eugene Zelenko via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: eugenezelenko
Date: Thu May 25 12:22:29 2017
New Revision: 303884
URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
Log:
[Documentation] Mention hicpp check group in Clang-tidy main docu
rsmith added a comment.
In https://reviews.llvm.org/D33538#765146, @EricWF wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
> > header appears to need compiler support.
>
>
> That's correct. I was mistaken
Author: rsmith
Date: Thu May 25 19:01:53 2017
New Revision: 303945
URL: http://llvm.org/viewvc/llvm-project?rev=303945&view=rev
Log:
Factor resolving of header directives -> files out of module map parser.
Modified:
cfe/trunk/include/clang/Lex/ModuleMap.h
cfe/trunk/lib/Lex/ModuleMap.cpp
EricWF added a comment.
Also see r303936, which re-adds to the module map and
fixes the bug.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martell added a comment.
> ! In https://reviews.llvm.org/D33082#764617, @EricWF wrote:
> Defining `_GNU_SOURCE` during the library build isn't enough, it's also has
> to be defined when people are using the headers,
> and in that case we must depend on the compiler to pre-define it. Is it
> im
Author: ericwf
Date: Thu May 25 18:39:29 2017
New Revision: 303936
URL: http://llvm.org/viewvc/llvm-project?rev=303936&view=rev
Log:
Re-add to the module map.
The original issues were caused because
didn't correctly #ifdef out enough of the header, which caused incomplete
types to be used.
Thi
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Actually, looking through the comments, it appears that everyone (eventually)
agreed with the approach in the patch. I agree too. LGTM.
Mehdi, are you able to rebase and commit, or s
EricWF added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
That's correct. I was mistaken as to why this was needed. I mistook a bug in
libc++ for the reason t
Author: rtrieu
Date: Thu May 25 18:25:36 2017
New Revision: 303934
URL: http://llvm.org/viewvc/llvm-project?rev=303934&view=rev
Log:
"*" => "+" to avoid matching on empty string.
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.org
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D33568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33538#765062, @rsmith wrote:
> In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
>
> > Do we need to conditionalize this part of libc++? Nothing in the
> >
t.p.northover updated this revision to Diff 100321.
t.p.northover added a comment.
Sounds very reasonable to me. I've uploaded a new diff.
https://reviews.llvm.org/D33568
Files:
clang/lib/AST/ExprConstant.cpp
clang/test/SemaCXX/null-cast.cpp
Index: clang/test/SemaCXX/null-cast.cpp
===
Author: rtrieu
Date: Thu May 25 18:03:08 2017
New Revision: 303932
URL: http://llvm.org/viewvc/llvm-project?rev=303932&view=rev
Log:
Make test/Driver/baremetal.cpp work when output directory isn't named 'bin'.
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/bar
rsmith added a comment.
In https://reviews.llvm.org/D33538#765045, @rsmith wrote:
> Do we need to conditionalize this part of libc++? Nothing in the
> header appears to need compiler support.
Oh wait, I see what's going on. You're not testing for whether coroutines is
enabled, you're testing
george.karpenkov added a comment.
@vsk Looks reasonable to me, although I would say such a change should probably
require more tests.
However, I am not a C++ expert, and I am still not overly familiar with a
codebase, so I'm not sure whether I should be a single reviewer.
https://reviews.llvm.
rsmith added a comment.
Do we need to conditionalize this part of libc++? Nothing in the
header appears to need compiler support.
https://reviews.llvm.org/D33538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: rsmith
Date: Thu May 25 17:47:05 2017
New Revision: 303930
URL: http://llvm.org/viewvc/llvm-project?rev=303930&view=rev
Log:
Switch from using a DiagnosticTrap and a note for "while defining a special
member function" context notes to registering an entry on the context stack.
Also reorde
Author: ericwf
Date: Thu May 25 17:43:42 2017
New Revision: 303929
URL: http://llvm.org/viewvc/llvm-project?rev=303929&view=rev
Log:
Correct typo: LIBCXXABI_BUILTINS_LIBRARY -> LIBCXX_BUILTINS_LIBRARY
Modified:
libcxx/trunk/cmake/config-ix.cmake
Modified: libcxx/trunk/cmake/config-ix.cmake
U
Author: martell
Date: Thu May 25 17:37:15 2017
New Revision: 303928
URL: http://llvm.org/viewvc/llvm-project?rev=303928&view=rev
Log:
libcxx: fix bootstrapping for mingw-w64
Differential Revision: https://reviews.llvm.org/D33388
Modified:
libcxx/trunk/cmake/config-ix.cmake
libcxx/trunk/i
aoli added a comment.
@jroelofs we are not building builtins currently but we are planning to do so.
I just added some basic configurations for builtins.
https://reviews.llvm.org/D33561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
aoli updated this revision to Diff 100308.
aoli added a comment.
Add builtin configurations.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
==
On 5/25/17 2:41 PM, Hans Wennborg wrote:
The test was failing on Windows; r303910 for that.
Oh yuk.. thanks for fixing that.
Jon
On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits
wrote:
On 5/25/17 11:39 AM, Galina Kistanova wrote:
Hello Jonathan,
This commit broke o
rsmith added inline comments.
Comment at: clang/lib/AST/ExprConstant.cpp:5498-5500
Result.set((Expr*)nullptr, 0, false, true, Offset);
+Result.getLValueDesignator() =
+SubobjectDesignator(E->getType()->getPointeeType());
This is the only caller o
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
For the simple casts in the test, we were crashing because the
ZeroInitialization function created an LValue with an unexpected
SubobjectDesignator: it was valid but didn't actually refer to a valid
MostDerivedType.
Sinc
MatzeB added a comment.
FWIW, I think this makes sense.
Moving O0 and optnone get closer seems sensible. Even though -O3 with an
optnone function indeed gives you different results today.
We are basically maintaining two things for the same "do not optimize" goal.
This obviously won't make O0 and
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r303913
https://reviews.llvm.org/D33547
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Thu May 25 16:02:49 2017
New Revision: 303913
URL: http://llvm.org/viewvc/llvm-project?rev=303913&view=rev
Log:
Update the getting started documentation to match the corresponding LLVM commit
in r303912.
Modified:
cfe/trunk/www/get_started.html
Modified: cfe/trunk
alexshap added inline comments.
Comment at: clang-tidy/misc/DefaultNumericsCheck.h:20
+/// This check flags usages of ``std::numeric_limits::{min,max}()`` for
+/// unspecialized types. It is dangerous because it returns T(), which might is
+/// rarely minimum or maximum for this
aaron.ballman added a comment.
Once you fix the typo in the check, can you run it over some large C++ code
bases to see if it finds any results?
Comment at: clang-tidy/misc/DefaultNumericsCheck.cpp:30
+ ofClass(classTemplateSpecializationDecl(
+ h
Prazek added a comment.
How is that compared to https://reviews.llvm.org/D19201 and the clang patch
mentioned in this patch?
Repository:
rL LLVM
https://reviews.llvm.org/D33537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
The test was failing on Windows; r303910 for that.
On Thu, May 25, 2017 at 11:55 AM, Jonathan Roelofs via cfe-commits
wrote:
>
>
> On 5/25/17 11:39 AM, Galina Kistanova wrote:
>
> Hello Jonathan,
>
> This commit broke one of our builders:
>
> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-ex
Author: hans
Date: Thu May 25 15:39:52 2017
New Revision: 303910
URL: http://llvm.org/viewvc/llvm-project?rev=303910&view=rev
Log:
Make test/Driver/baremetal.cpp pass on Windows
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.org/
Author: erichkeane
Date: Thu May 25 15:29:17 2017
New Revision: 303909
URL: http://llvm.org/viewvc/llvm-project?rev=303909&view=rev
Log:
Earlier revert introduced an extra space, remove it.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp
Modified:
clang-
Author: rnk
Date: Thu May 25 15:28:26 2017
New Revision: 303908
URL: http://llvm.org/viewvc/llvm-project?rev=303908&view=rev
Log:
Revert "[AMDGPU] add __builtin_amdgcn_s_getpc"
This reverts commit r303861, the LLVM intrinsic was reverted.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsAMDGP
aaron.ballman created this revision.
We do not explicitly model integer promotions on unary operators even though
those promotions happen in practice. This patch tracks the most important piece
of information about the promotion on the AST node: whether the operator can
overflow or not. It then
I agree with Nico in retrospect. Setting -fno-operator-names is too big a
hammer. Instead we should add some MSVCCompat hacks to pretend we saw an
identifier token instead of a keyword token when these keywords are used as
declarators.
On Thu, May 25, 2017 at 10:14 AM, Nico Weber wrote:
> Among
pcc added inline comments.
Comment at: clang/test/CodeGen/thin_link_bitcode.c:5
+// RUN: %clang_cc1 -o %t -flto=thin -fexperimental-new-pass-manager
-fthin-link-bitcode=%t.newpm -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s
+// RUN: llvm-bcanalyzer -dump %t.newpm | FileCheck
jroelofs added a comment.
what about the builtins?
https://reviews.llvm.org/D33561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aoli updated this revision to Diff 100282.
aoli added a comment.
Fix wrong flags.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cmake
Index: cmake/caches/Android.cmake
===
--- /
aoli created this revision.
Herald added a subscriber: mgorny.
Thoes files are used to build Android toolchain.
https://reviews.llvm.org/D32816 makes it possible to build runtimes for targets.
https://reviews.llvm.org/D33561
Files:
cmake/caches/Android-stage2.cmake
cmake/caches/Android.cma
timshen added a comment.
In https://reviews.llvm.org/D33525#764251, @chandlerc wrote:
> (focusing on the LLVM side of this review for now)
>
> Can you add an LLVM-based test? Can you add this to
> `lib/Passes/PassRegistry.def`?
I see that not all passes are registered (BitcodeWriterPass). Is i
Author: ericwf
Date: Thu May 25 14:04:55 2017
New Revision: 303900
URL: http://llvm.org/viewvc/llvm-project?rev=303900&view=rev
Log:
Update more coroutine_handle signatures to reflect N4663.
Thanks to Casey Carter for pointing out the out-of-date tests and
implementation.
Modified:
libcxx/tr
BillyONeal closed this revision.
BillyONeal added a comment.
In https://reviews.llvm.org/D33340#764206, @EricWF wrote:
> Sorry for the delay reviewing such a simple change.
No problem! Their simplicity also means no likely merge conflicts :)
In https://reviews.llvm.org/D33340#764213, @EricWF w
Author: bion
Date: Thu May 25 14:01:14 2017
New Revision: 303899
URL: http://llvm.org/viewvc/llvm-project?rev=303899&view=rev
Log:
Add asserts that the nullptr is maintained in string erase operations.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_erase/iter.pa
On 5/25/17 11:39 AM, Galina Kistanova wrote:
Hello Jonathan,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio
Please have a look at this?
r303898 should take care of that.
Jon
Author: jroelofs
Date: Thu May 25 13:55:22 2017
New Revision: 303898
URL: http://llvm.org/viewvc/llvm-project?rev=303898&view=rev
Log:
Appease more buildbots about r303873
Modified:
cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/BareMetal.cpp
URL:
ht
Author: ericwf
Date: Thu May 25 13:52:34 2017
New Revision: 303895
URL: http://llvm.org/viewvc/llvm-project?rev=303895&view=rev
Log:
Update coroutine_handle::promise to reflect N4663.
This patch updates the promise() member to match the current spec.
Specifically it removes the non-const overload
EricWF added a comment.
@mclow.lists Could you update this diff with more context?
https://reviews.llvm.org/D33550
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 100269.
EricWF added a comment.
- Remove the external include guards for `__undef_macros` as requested by
@compnerd.
I couldn't come up with a easy test case that showed any notable difference
having the external guards.
https://reviews.llvm.org/D33080
Fi
This revision was automatically updated to reflect the committed changes.
CaseyCarter marked an inline comment as done.
Closed by commit rL303889: [test] Remove workaround for C1XX
conversion-to-nullptr bug (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D33290?vs=9
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303888: [test] Workaround C1XX bug in
uses_allocator_types.hpp (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D33214?vs=99086&id=100264#toc
Repository:
rL LLVM
https://
Author: caseycarter
Date: Thu May 25 12:42:21 2017
New Revision: 303889
URL: http://llvm.org/viewvc/llvm-project?rev=303889&view=rev
Log:
[test] Remove workaround for C1XX conversion-to-nullptr bug
VSO#391542 "Types can't be convertible to nullptr_t"
Also put internal bug numbers on the workarou
Author: caseycarter
Date: Thu May 25 12:42:17 2017
New Revision: 303888
URL: http://llvm.org/viewvc/llvm-project?rev=303888&view=rev
Log:
[test] Workaround C1XX bug in uses_allocator_types.hpp
VSO#109062 "Explicit template argument specification with empty template
parameter pack expansion does
Hello Jonathan,
This commit broke one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2608/steps/build-unified-tree/logs/stdio
Please have a look at this?
Thanks
Galina
On Thu, May 25, 2017 at 8:42 AM, Jonathan Roelofs via cfe-commits <
cfe-com
EricWF added a comment.
In https://reviews.llvm.org/D33080#754442, @compnerd wrote:
> I think that we should sink the `min`/`max` checks into `__undef_macros`. I
> don't like the idea of littering that check everywhere.
I would much rather litter at the cost of the implementation than needles
EricWF updated this revision to Diff 100263.
EricWF added a comment.
Add `_LIBCPP_MSVCRT_LIKE` and use it to replace `_LIBCPP_WIN32API` where
appropriate.
https://reviews.llvm.org/D33082
Files:
include/__config
include/__locale
include/locale
include/stdio.h
include/support/win32/loc
Author: eugenezelenko
Date: Thu May 25 12:22:29 2017
New Revision: 303884
URL: http://llvm.org/viewvc/llvm-project?rev=303884&view=rev
Log:
[Documentation] Mention hicpp check group in Clang-tidy main document.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/index.rst
Modified: clang-tools
EricWF marked 3 inline comments as done.
EricWF added a comment.
In https://reviews.llvm.org/D33082#760516, @martell wrote:
> I want to give some context here to dispel the confusion of what is and isn't
> win32 api specific.
>
> First lets take `vasprintf` and `asprintf ` which are not implemen
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/misc-exception-escape.rst:7
+Finds functions which should not throw exceptions:
++ Destructors
++ Copy constructors
I
Among the goals of the clang-cl project are a) being able to parse MS
system headers b) helper users to write standards-compliant C++ (in
particular, if your code builds with clang-cl without warnings, it'd be
good if it also built with regular clang then).
The regular change plus header change pl
ilya-biryukov updated this revision to Diff 100262.
ilya-biryukov added a comment.
- Fixed file comment of ClangdTests.cpp
https://reviews.llvm.org/D33416
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd
EricWF marked 6 inline comments as done.
EricWF added inline comments.
Comment at: include/__locale:370
static const mask blank = _ISblank;
-#elif defined(_LIBCPP_MSVCRT)
+#elif defined(_LIBCPP_WIN32API)
typedef unsigned short mask;
compnerd wrote:
> A
No problem, I definitely think it was the right choice.
A change that contains all of what Melanie’s original patch did, plus the
Header changes (plus the clang-tidy fixes that came out of this) would be
acceptable?
Also, I believe she’s working on the warning as well. We were discussing it,
Sometimes it’s possible to reason with the open source community, then they
change their code and make modifications which accommodate the various
compilers. E.g. we could ask chromium team if they could use the operator
symbol instead of ‘and’.
From: Nico Weber [mailto:tha...@google.com]
Sent:
On Thu, May 25, 2017 at 12:18 PM, Keane, Erich
wrote:
> How does chromium compiler in CL? It seems that it would have a similar
> problem here…
>
That's a good question! It looks like iso646.h is included, and in MSVC
that contains something like `#define and &&`. But clang's
lib/Headers/iso646
Patch and Buildbot fixes all reverted as of –r303882. Sorry for the thrash.
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Thursday, May 25, 2017 9:16 AM
To: Blower, Melanie
Cc: rnk ; Keane, Erich ; cfe-commits
; Hans Wennborg
Subject: RE: r303798 - For Micros
Author: erichkeane
Date: Thu May 25 11:24:49 2017
New Revision: 303882
URL: http://llvm.org/viewvc/llvm-project?rev=303882&view=rev
Log:
Revert MSVC CXXOperatorNames patch due to issues with Chromium
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
cfe/trunk/test/Parser/MicrosoftEx
Author: erichkeane
Date: Thu May 25 11:23:00 2017
New Revision: 303881
URL: http://llvm.org/viewvc/llvm-project?rev=303881&view=rev
Log:
Revert 303872/303877 since the patch that caused these issues
is also being reverted.
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implic
Author: jroelofs
Date: Thu May 25 11:20:51 2017
New Revision: 303880
URL: http://llvm.org/viewvc/llvm-project?rev=303880&view=rev
Log:
Relax testcase to appease buildbots
When lld isn't built, the tests as they were previously, were too picky about
the path to the linker.
Modified:
cfe/trunk
How does chromium compiler in CL? It seems that it would have a similar
problem here…
From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber
Sent: Thursday, May 25, 2017 9:16 AM
To: Blower, Melanie
Cc: rnk ; Keane, Erich ; cfe-commits
; Hans Wennborg
Subject: RE: r303798 -
In addition to this making clang-cl silently accept invalid code, it also
breaks existing valid code, building chromium now fails. Let's revert and
come up with something better asynchronously.
FAILED:
obj/third_party/WebKit/Source/core/dom/dom/CustomElementRegistry.obj
E:\b\c\goma_client/gomacc.e
Author: epilk
Date: Thu May 25 11:16:17 2017
New Revision: 303878
URL: http://llvm.org/viewvc/llvm-project?rev=303878&view=rev
Log:
Fix a test that was failing in C++11 mode introduced in r303874
Modified:
libcxx/trunk/test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_
Author: erichkeane
Date: Thu May 25 11:07:19 2017
New Revision: 303877
URL: http://llvm.org/viewvc/llvm-project?rev=303877&view=rev
Log:
Clang-tidy doesn't understand -fno-ms-compatibility, so just removing 'not'
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cas
Author: marshall
Date: Thu May 25 11:05:54 2017
New Revision: 303876
URL: http://llvm.org/viewvc/llvm-project?rev=303876&view=rev
Log:
Mark LWG#2900 as complete - we already do this, and I checked the tests in a
couple days ago (r303268 & r303824)
Modified:
libcxx/trunk/www/cxx1z_status.html
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303874: Add support for shared_ptr (authored
by epilk).
Changed prior to commit:
https://reviews.llvm.org/D30837?vs=97313&id=100251#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30837
Files:
Author: epilk
Date: Thu May 25 10:43:31 2017
New Revision: 303874
URL: http://llvm.org/viewvc/llvm-project?rev=303874&view=rev
Log:
Add support for shared_ptr
Fixes PR27566.
Differential revision: https://reviews.llvm.org/D30837
Added:
libcxx/trunk/test/libcxx/utilities/memory/util.smartpt
jroelofs closed this revision.
jroelofs added a comment.
r303873
https://reviews.llvm.org/D33259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jroelofs
Date: Thu May 25 10:42:13 2017
New Revision: 303873
URL: http://llvm.org/viewvc/llvm-project?rev=303873&view=rev
Log:
Don't defer to the GCC driver for linking arm-baremetal
Also comes with a cmake cache for building the runtime bits:
$ cmake \
-DBAREMETAL_ARMV6M_SYSROOT=/p
Author: erichkeane
Date: Thu May 25 10:39:24 2017
New Revision: 303872
URL: http://llvm.org/viewvc/llvm-project?rev=303872&view=rev
Log:
Disable MSVC-Compat mode for two tests that use C++Operator Names
MSVC doesn't support C++ operator names (using 'or' instead of ||,
'not' instead of '!', etc)
Author: ericwf
Date: Thu May 25 10:24:04 2017
New Revision: 303871
URL: http://llvm.org/viewvc/llvm-project?rev=303871&view=rev
Log:
Make git-clang-format python 3 compatible
Summary: This patch attempts to make `git-clang-format` both python2 and
python3 compatible. Currently it only works in p
Author: ericwf
Date: Thu May 25 09:59:39 2017
New Revision: 303868
URL: http://llvm.org/viewvc/llvm-project?rev=303868&view=rev
Log:
[coroutines] Diagnose when promise types fail to declare either return_void or
return_value.
Summary:
According to the PDTS it's perfectly legal to have a promise
Author: ericwf
Date: Thu May 25 09:58:46 2017
New Revision: 303867
URL: http://llvm.org/viewvc/llvm-project?rev=303867&view=rev
Log:
[coroutines] Bump __cpp_coroutines version
Summary: This patch is needed so that Libc++ can actually tess if Clang
supports coroutines, instead of just paying lip
1 - 100 of 130 matches
Mail list logo
