[libunwind] r300419 - [CMake][libunwind] Fix the -target and -gcc-toolchain flag handling

2017-04-15 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sun Apr 16 01:08:44 2017 New Revision: 300419 URL: http://llvm.org/viewvc/llvm-project?rev=300419&view=rev Log: [CMake][libunwind] Fix the -target and -gcc-toolchain flag handling CMake has the problem with the single dash variant because of the space, so use the double dash

[libcxxabi] r300418 - [CMake][libcxxabi] Fix the -target and -gcc-toolchain flag handling

2017-04-15 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sun Apr 16 01:08:34 2017 New Revision: 300418 URL: http://llvm.org/viewvc/llvm-project?rev=300418&view=rev Log: [CMake][libcxxabi] Fix the -target and -gcc-toolchain flag handling CMake has the problem with the single dash variant because of the space, so use the double dash

[libcxx] r300417 - Cleanup one more test

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 23:05:15 2017 New Revision: 300417 URL: http://llvm.org/viewvc/llvm-project?rev=300417&view=rev Log: Cleanup one more test Removed: libcxx/trunk/test/std/containers/sequences/forwardlist/forwardlist.cons/size.fail.cpp Modified: libcxx/trunk/test/std/cont

[libcxx] r300415 - Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 23:02:01 2017 New Revision: 300415 URL: http://llvm.org/viewvc/llvm-project?rev=300415&view=rev Log: Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in Modified: libcxx/trunk/include/forward_list libcxx/trunk/test/std/containers/sequences/forwardlist/forw

[libcxx] r300414 - Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 22:45:35 2017 New Revision: 300414 URL: http://llvm.org/viewvc/llvm-project?rev=300414&view=rev Log: Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in Modified: libcxx/trunk/include/list libcxx/trunk/test/std/containers/sequences/list/list.cons/assign_in

[libcxx] r300413 - Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in deque

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 22:17:01 2017 New Revision: 300413 URL: http://llvm.org/viewvc/llvm-project?rev=300413&view=rev Log: Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in deque Modified: libcxx/trunk/include/deque libcxx/trunk/test/std/containers/sequences/deque/deque.cons/a

[libcxx] r300412 - Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 21:50:40 2017 New Revision: 300412 URL: http://llvm.org/viewvc/llvm-project?rev=300412&view=rev Log: Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in Modified: libcxx/trunk/include/array libcxx/trunk/test/std/containers/sequences/array/array.size/size.pa

[libcxx] r300411 - Workaround Clang bug regarding template template parameters

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 21:47:46 2017 New Revision: 300411 URL: http://llvm.org/viewvc/llvm-project?rev=300411&view=rev Log: Workaround Clang bug regarding template template parameters Modified: libcxx/trunk/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move

[libcxx] r300410 - Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in vector.

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 21:40:45 2017 New Revision: 300410 URL: http://llvm.org/viewvc/llvm-project?rev=300410&view=rev Log: Replace _LIBCPP_HAS_NO_ with _LIBCPP_CXX03_LANG in vector. This patch cleans up all usages of the following feature test macros inside and its tests: * _LIBCPP_HA

[libcxx] r300409 - [CMake][libcxx] Fix the --target and --gcc-toolchain flag handling

2017-04-15 Thread Petr Hosek via cfe-commits
Author: phosek Date: Sat Apr 15 21:25:55 2017 New Revision: 300409 URL: http://llvm.org/viewvc/llvm-project?rev=300409&view=rev Log: [CMake][libcxx] Fix the --target and --gcc-toolchain flag handling CMake has the problem with the single dash variant because of the space, so use the double dash w

[libcxx] r300408 - Cleanup and better scope unique_ptr internals

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 21:14:31 2017 New Revision: 300408 URL: http://llvm.org/viewvc/llvm-project?rev=300408&view=rev Log: Cleanup and better scope unique_ptr internals Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llvm-pro

[libcxx] r300407 - Cleanup default_delete specializations

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 21:06:25 2017 New Revision: 300407 URL: http://llvm.org/viewvc/llvm-project?rev=300407&view=rev Log: Cleanup default_delete specializations Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llvm-project/li

[libcxx] r300406 - Overhaul unique_ptr - Implement LWG 2801, 2905, 2520.

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 20:51:04 2017 New Revision: 300406 URL: http://llvm.org/viewvc/llvm-project?rev=300406&view=rev Log: Overhaul unique_ptr - Implement LWG 2801, 2905, 2520. This patch overhauls both specializations of unique_ptr while implementing the following LWG issues: * LWG 28

[PATCH] D32112: [clang] Register isConstexpr matcher

2017-04-15 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. alexshap created this object with visibility "All Users". I was working on some analyzer / clang-tidy code and noticed that isConstexpr was not available in clang-query. This diff registers this matcher. F3226452: Screen Shot 2017-04-15 at 4.21.23 PM.png

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95382. EricWF marked an inline comment as done. EricWF added a comment. - Fix `MaybeODRUseExprs` assertion. - Remove mistakenly present `CoroutineBuilder.h` file. I'll land this later today if there are no objections. https://reviews.llvm.org/D31562 Files:

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF marked an inline comment as done. EricWF added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// GorNishanov wrote: > This file is called: > > CoroutineStmtB

[PATCH] D31538: [analyzer] MisusedMovedObjectChecker: Fix a false positive on state-resetting a base-class sub-object.

2017-04-15 Thread Peter Szecsi via Phabricator via cfe-commits
szepet accepted this revision. szepet added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Checkers/MisusedMovedObjectChecker.cpp:426 + +State = State->remove(WholeObjectRegion); C.addTransition(State); s

[PATCH] D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions.

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. This patch attempts to fix llvm.org/PR31905. However I have no clue if this fix is correct; I simply stumbled upon it. The fix is to remove the `_Builtin_stddef_max_align_t` module, making `__stddef_max_align_t.h` non-modular. This fixes the issue because including

[PATCH] D32107: [libc++][test] LWG2857 test coverage for variant

2017-04-15 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF commandeered this revision. EricWF edited reviewers, added: CaseyCarter; removed: EricWF. EricWF added a comment. LGTM, Thanks @CaseyCarter. I committed these tests and the changes to libc++'s variant in r300403. I'm hijacking this revision so I can close it. https://reviews.llvm.org/D3

[libcxx] r300403 - Implement LWG 2857 for variant. Tests from Casey Carter @ Microsoft.

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 14:32:02 2017 New Revision: 300403 URL: http://llvm.org/viewvc/llvm-project?rev=300403&view=rev Log: Implement LWG 2857 for variant. Tests from Casey Carter @ Microsoft. Also mark LWG 2857 as complete, since the changes to optional and any were completed by Marshal

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-15 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. ping https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15006: Driver: Better detection of mingw-gcc

2017-04-15 Thread Mateusz MikuĊ‚a via Phabricator via cfe-commits
mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. Looks fine for MinGW on Windows. Repository: rL LLVM https://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32110: Emit invariant.group loads with empty group md

2017-04-15 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek created this revision. As discussed here http://lists.llvm.org/pipermail/llvm-dev/2017-January/109332.html having different groups doesn't solve the problem entirly. https://reviews.llvm.org/D32110 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp I

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

2017-04-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > ... which has the wrong precedence; an extra set of parens is necessary. > However, I don't want to add a set of parens if it isn't necessary. ... One way to handle this is to not suggest the fixit if the container part of the equality check is not a DeclRefExpr

r300400 - Add isStaticStorageClass to the dynamic matcher registry so that it can be used from clang-query.

2017-04-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Apr 15 07:53:20 2017 New Revision: 300400 URL: http://llvm.org/viewvc/llvm-project?rev=300400&view=rev Log: Add isStaticStorageClass to the dynamic matcher registry so that it can be used from clang-query. Patch by Dave Lee. Modified: cfe/trunk/lib/ASTMatchers

[PATCH] D31869: Register isStaticStorageClass matcher

2017-04-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've commit in r300400. https://reviews.llvm.org/D31869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

2017-04-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D31757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[libcxx] r300399 - Simplify test helper

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 07:05:11 2017 New Revision: 300399 URL: http://llvm.org/viewvc/llvm-project?rev=300399&view=rev Log: Simplify test helper Modified: libcxx/trunk/test/support/unique_ptr_test_helper.h Modified: libcxx/trunk/test/support/unique_ptr_test_helper.h URL: http://llv

[PATCH] D31887: [clangd] Add documentation page

2017-04-15 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Great to see this coming along! Comment at: docs/clangd.rst:10 + +:program:`clangd` is an implementation of the `Language Server Protocol `_ leveraging Clang. +Clangd's goal is to provide lang

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

2017-04-15 Thread Ken-Patrick Lehrmann via Phabricator via cfe-commits
KP updated this revision to Diff 95375. KP added a comment. Rebase on current trunk. Is there any chance to get this merge ? Please let me know if anything else is needed. Thanks, Ken-Patrick https://reviews.llvm.org/D27651 Files: lib/Format/WhitespaceManager.cpp unittests/Format/FormatT

[PATCH] D32109: [Driver] Limit .exe extension addition to Windows hosts

2017-04-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai planned changes to this revision. smeenai added a comment. Forgot to fix a test https://reviews.llvm.org/D32109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32109: [Driver] Limit .exe extension addition to Windows hosts

2017-04-15 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. The driver should invoke lld as `lld-link` rather than `lld-link.exe` when cross compiling. The alternative would be to teach lld's build system to always produce `lld-link.exe` even on non-Windows hosts, but I think it's cleaner to change the driver to respect the

[libcxx] r300397 - Fix PR32642 - string::insert and string::append don't work with move_iterator.

2017-04-15 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Apr 15 01:49:02 2017 New Revision: 300397 URL: http://llvm.org/viewvc/llvm-project?rev=300397&view=rev Log: Fix PR32642 - string::insert and string::append don't work with move_iterator. Modified: libcxx/trunk/include/string libcxx/trunk/test/std/strings/basic.st