mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 298597
https://reviews.llvm.org/D30045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists closed this revision.
mclow.lists marked an inline comment as done.
mclow.lists added a comment.
Committed as revision 298681.
https://reviews.llvm.org/D31163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
mclow.lists closed this revision.
mclow.lists added a comment.
Committed as revision 298689
https://reviews.llvm.org/D31022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Fri Mar 24 00:45:39 2017
New Revision: 298689
URL: http://llvm.org/viewvc/llvm-project?rev=298689&view=rev
Log:
Implement P0298R3: 'std::byte'. Reviewed as https://reviews.llvm.org/D31022
Added:
libcxx/trunk/test/std/language.support/support.types/byte.pass.cpp
libc
echuraev added a comment.
In https://reviews.llvm.org/D31183#708833, @yaxunl wrote:
> I think this is a good feature for the convenience of user. I've seen usage
> like this.
I agree. I don't see any reasons why this case doesn't have the right to exist.
I don't think that using extra parenth
anemet updated this revision to Diff 92898.
anemet added a comment.
Address Aaron's comments.
https://reviews.llvm.org/D31166
Files:
include/clang/AST/Expr.h
include/clang/AST/ExprCXX.h
include/clang/Basic/LangOptions.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/Analysis/
Author: marshall
Date: Fri Mar 24 00:19:15 2017
New Revision: 298686
URL: http://llvm.org/viewvc/llvm-project?rev=298686&view=rev
Log:
Move the scoped_lock inside the '#ifndef NO_THREADS' block to fix the
no-threading build
Modified:
libcxx/trunk/include/mutex
Modified: libcxx/trunk/include
anemet marked 3 inline comments as done.
anemet added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:1712
BinOp.Opcode = IsInc ? BO_Add : BO_Sub;
- BinOp.FPContractable = false;
+ // FIXME: once UnaryOperator carries FPFeatures, copy it here.
BinOp.E = E;
-
EricWF added inline comments.
Comment at:
test/std/language.support/support.types/byteops/xor.assign.pass.cpp:13
+
+// XFAIL: c++98, c++03, c++11, c++14
+
Nit. These should be `// UNSUPPORTED`. `XFAIL` is for bugs we need to fix.
https://reviews.llvm.org/D3102
Author: marshall
Date: Thu Mar 23 22:40:36 2017
New Revision: 298681
URL: http://llvm.org/viewvc/llvm-project?rev=298681&view=rev
Log:
Implement Pp0156r2: 'Variadic Lock Guard, version 5' Reviewed as
https://reviews.llvm.org/D31163.
Added:
libcxx/trunk/test/std/thread/thread.mutex/thread.lo
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I still think we can come up with a better include structure, but we have
plenty of time to figure that out before the next release.
I see no reason to hold this up.
@mclow.lists is there a fe
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I'll send something to the reflectors about the explicit deduction guides
over the weekend.
https://reviews.llvm.org/D31163
___
cfe-commit
mclow.lists marked 8 inline comments as done.
mclow.lists added inline comments.
Comment at: include/mutex:176
+template unique_lock(unique_lock)
+-> unique_lock; // C++17
mclow.lists wrote:
> EricWF wrote:
> > This should be guarded behind a feature test m
mclow.lists updated this revision to Diff 92896.
mclow.lists added a comment.
Removed the deduction guides. Guarded the tests for the deduction guides with
#ifdefs.
https://reviews.llvm.org/D31163
Files:
include/__config
include/__mutex_base
include/mutex
include/shared_mutex
test/l
echristo added a comment.
Needs more testing. Might want to make sure that you actually are recording
some useful command line options and that you're looking at the cc1 command
line.
This should also be a Driver test and not CodeGen. You can then use -### to
inspect the command lines as passe
george.burgess.iv added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:4328
+ if (getToolChain().UseDwarfDebugFlags() ||
+ Args.hasArg(options::OPT_grecord_gcc_switches)) {
ArgStringList OriginalArgs;
looks like we have to consider `-gno-
Author: rsmith
Date: Thu Mar 23 20:14:25 2017
New Revision: 298676
URL: http://llvm.org/viewvc/llvm-project?rev=298676&view=rev
Log:
Fix handling of initialization from parenthesized initializer list.
This change fixes a crash on initialization of a reference from ({}) during
template instantiati
bkelley added inline comments.
Comment at: lib/AST/Type.cpp:3773
+/// lifetime semantics.
+bool Type::isNonTrivialObjCLifetimeType() const {
+ return CanonicalType.hasNonTrivialObjCLifetime();
rjmccall wrote:
> Is this method not identical in behavior to hasNonT
bkelley updated this revision to Diff 92892.
https://reviews.llvm.org/D31007
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/Sema/SemaCast.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclCXX.cpp
lib/Sema/SemaInit.cpp
test/SemaObjCXX/objc-weak.mm
Index: test/SemaObjCXX/objc-weak.mm
bkelley updated this revision to Diff 92890.
bkelley marked an inline comment as done.
bkelley added a comment.
Removed redundant conditions, per feedback from @rjmccall
https://reviews.llvm.org/D31004
Files:
lib/AST/Type.cpp
lib/Sema/SemaExprCXX.cpp
test/SemaObjCXX/objc-weak-type-traits.
bkelley added a comment.
Thanks for the feedback! Apologies for the slow turn around; I was out sick :(
Comment at: lib/AST/Type.cpp:2026
- if (Context.getLangOpts().ObjCAutoRefCount) {
-switch (getObjCLifetime()) {
-case Qualifiers::OCL_ExplicitNone:
- return t
Eugene.Zelenko added a comment.
I think will be good idea to make this check working in both ways (standard or
alternative operator representations), depending on option.
Probably readability-operators-representation will be better name for check.
See also PR25195.
https://reviews.llvm.org/D3
zhizhouy updated this revision to Diff 92885.
zhizhouy retitled this revision from "Record command lines in objects built by
clang" to "Record command lines in objects built by clang, Clang part".
zhizhouy edited the summary of this revision.
zhizhouy added a reviewer: aprantl.
zhizhouy added a co
Author: dberris
Date: Thu Mar 23 19:20:05 2017
New Revision: 298670
URL: http://llvm.org/viewvc/llvm-project?rev=298670&view=rev
Log:
[XRay] Do not depend on C++ stdlib for XRay builds
Summary:
Now that XRay doesn't require a runtime dependency on a C++ standard
library, we remove that dependency
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298670: [XRay] Do not depend on C++ stdlib for XRay builds
(authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D31313?vs=92884&id=92886#toc
Repository:
rL LLVM
https://reviews.l
dberris created this revision.
Now that XRay doesn't require a runtime dependency on a C++ standard
library, we remove that dependency from the clang linker flags.
https://reviews.llvm.org/D31313
Files:
lib/Driver/ToolChains/Gnu.cpp
Index: lib/Driver/ToolChains/Gnu.cpp
=
Author: rsmith
Date: Thu Mar 23 18:32:03 2017
New Revision: 298663
URL: http://llvm.org/viewvc/llvm-project?rev=298663&view=rev
Log:
Remove uses of std::binary_function, removed in C++17.
Modified:
cfe/trunk/include/clang/AST/TypeOrdering.h
cfe/trunk/include/clang/Basic/SourceLocation.h
Author: rsmith
Date: Thu Mar 23 18:17:58 2017
New Revision: 298657
URL: http://llvm.org/viewvc/llvm-project?rev=298657&view=rev
Log:
Remove all uses of std::mem_fun and std::bind1st removed in C++17.
Modified:
cfe/trunk/include/clang/AST/DeclContextInternals.h
cfe/trunk/include/clang/AST/
bruno added a comment.
> I would like to see this patch committed. I see clear evidence of it
> improving existing GPU targets in the master repo as well as outside of the
> main tree implementations. Bruno, do you have any more concerns?
I believe the argument lacks numbers (or at least you ha
krystyna added a comment.
I have plan to finish this patch next week, when I finish academic year at my
school. If I will have any issues with submitting, Prazek offered to help me.
https://reviews.llvm.org/D29262
___
cfe-commits mailing list
cfe-c
yaxunl added a comment.
Ping! Any further issues? We need this in to move on with Clang codegen for the
new address space mapping.
Thanks.
https://reviews.llvm.org/D31210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: dehao
Date: Thu Mar 23 16:20:17 2017
New Revision: 298647
URL: http://llvm.org/viewvc/llvm-project?rev=298647&view=rev
Log:
Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto
compile phase.
Summary: This is the test added for https://reviews.llvm.org/D31217
Re
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM but please add comments about what we're testing.
https://reviews.llvm.org/D31219
___
cfe-commits mailing list
cfe-commits@lists.llvm.
mgehre created this revision.
Herald added a subscriber: mgorny.
Flags (and replaces) the alternative tokens for binary and unary
operators, such as ``not`` (for ``!``), ``bitand`` (for ``&``), ``or`` (for
``||``)
or ``not_eq`` (for ``!=``).
https://reviews.llvm.org/D31308
Files:
clang-tidy/
stanionascu added a comment.
Thanks for review!
Would be great if somebody would commit it, as I cannot do it myself.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298639: [ThinLTO] Clang support for emitting minimized
bitcode for thin link (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D31050?vs=92647&id=92849#toc
Repository:
rL LLV
Author: tejohnson
Date: Thu Mar 23 14:47:49 2017
New Revision: 298639
URL: http://llvm.org/viewvc/llvm-project?rev=298639&view=rev
Log:
[ThinLTO] Clang support for emitting minimized bitcode for thin link
Summary:
Clang companion patch to LLVM patch D31027, which adds support
for emitting minimiz
anemet added a comment.
In https://reviews.llvm.org/D31276#708999, @hfinkel wrote:
> They're definitely on my list. I might not get to them until the weekend or
> next week, however.
Thank you. The schedule is getting tight but that should still work ;).
Actually most of the individual patch
anemet added a comment.
In https://reviews.llvm.org/D31276#708992, @hfinkel wrote:
> High-level comment ;)
>
> #pragma clang fast_math contract_fast(on)
>
>
> This seems a bit unfortunate because 'fast' appears twice? How are we
> planning on naming the other fast-math flags? Maybe we shoul
Author: erichkeane
Date: Thu Mar 23 13:51:54 2017
New Revision: 298634
URL: http://llvm.org/viewvc/llvm-project?rev=298634&view=rev
Log:
Correct class-template deprecation behavior-REDUX
Correct class-template deprecation behavior
Based on the comment in the test, and my reading of the standard,
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D30837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
What is the error in the spec?
Thanks,
Xinmin
-Original Message-
From: Francesco Petrogalli via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Thursday, March 23, 2017 10:29 AM
To: francesco.petroga...@arm.com; cber...@us.ibm.com; acja...@us.ibm.com;
hahnf...@itc.rwth-aachen.de; a
hfinkel added a comment.
In https://reviews.llvm.org/D31276#708993, @anemet wrote:
> In https://reviews.llvm.org/D31276#708976, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D31276#708968, @anemet wrote:
> >
> > > Thanks very much, Aaron! It would be great if you could also look at the
aaron.ballman added inline comments.
Comment at: include/clang/AST/ExprCXX.h:58
+ // Only meaningful for floating point types. For other types this value can
be
// set to false.
+ FPOptions FPFeatures;
Setting a class to false sounds a bit strange. May want
anemet added a comment.
In https://reviews.llvm.org/D31276#708976, @aaron.ballman wrote:
> In https://reviews.llvm.org/D31276#708968, @anemet wrote:
>
> > Thanks very much, Aaron! It would be great if you could also look at the
> > three patches that add support for the generation of the new FM
hfinkel added a comment.
High-level comment ;)
#pragma clang fast_math contract_fast(on)
This seems a bit unfortunate because 'fast' appears twice? How are we planning
on naming the other fast-math flags? Maybe we should just name it:
#pragma clang math constract_fast(on)
or
#pragma cl
fpetrogalli planned changes to this revision.
fpetrogalli added a comment.
Dear all,
thank you for reviewing this patch. We found out an error in the spec and would
like to fix it before things are used.
I will soon update this patch.
Thanks,
Francesco
https://reviews.llvm.org/D30739
___
aaron.ballman added a comment.
In https://reviews.llvm.org/D31276#708968, @anemet wrote:
> Thanks very much, Aaron! It would be great if you could also look at the
> three patches that add support for the generation of the new FMF 'contract'
> for -ffp-contract=fast. I've added them in the de
mgorny reopened this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
Reopening since it has been reverted.
Repository:
rL LLVM
https://reviews.llvm.org/D28213
___
cfe-commits mailing list
cfe-commits@lists.llvm.
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D31289
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
anemet added a comment.
Thanks very much, Aaron! It would be great if you could also look at the three
patches that add support for the generation of the new FMF 'contract' for
-ffp-contract=fast. I've added them in the dependencies of this revision.
(https://reviews.llvm.org/D31168 is not r
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
jaykang10 updated this revision to Diff 92829.
jaykang10 added a comment.
Preserved vec3 type on __builtin_astype.
https://reviews.llvm.org/D30810
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprScalar.cpp
li
anemet added inline comments.
Comment at: docs/LanguageExtensions.rst:2321
+specified for a section of the source code. This pragma can only appear at
+file scope or at the start of a compound statement. When using within a
+compound statement, the pragma is active within the s
Author: akirtzidis
Date: Thu Mar 23 11:34:47 2017
New Revision: 298622
URL: http://llvm.org/viewvc/llvm-project?rev=298622&view=rev
Log:
[index] When indexing system headers make sure to report important reference
relations
Even if we exclude plain reference occurrences, we should include
relat
anemet updated this revision to Diff 92825.
anemet marked 4 inline comments as done.
anemet added a comment.
Address Aaron's comments. Also add a code example to the documentation.
https://reviews.llvm.org/D31276
Files:
docs/LanguageExtensions.rst
include/clang/Basic/DiagnosticParseKinds.t
Author: mkurdej
Date: Thu Mar 23 11:32:06 2017
New Revision: 298621
URL: http://llvm.org/viewvc/llvm-project?rev=298621&view=rev
Log:
[clang-tidy] Fix treating non-space whitespaces in checks list.
Summary:
This furtherly improves r295303: [clang-tidy] Ignore spaces between globs in
the Checks o
Author: alexfh
Date: Thu Mar 23 11:29:39 2017
New Revision: 298619
URL: http://llvm.org/viewvc/llvm-project?rev=298619&view=rev
Log:
[clang-tidy] Don't use groups in the big regexy filter
Fixes https://bugs.llvm.org/show_bug.cgi?id=27641.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/run
curdeius added a comment.
In https://reviews.llvm.org/D30567#708797, @alexfh wrote:
> Do you have commit rights?
Yes, I will commit this ASAP.
https://reviews.llvm.org/D30567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: marshall
Date: Thu Mar 23 11:13:50 2017
New Revision: 298618
URL: http://llvm.org/viewvc/llvm-project?rev=298618&view=rev
Log:
Update the algorithm tests to not use the (deprecated) function binders. No
functional change.
Modified:
libcxx/trunk/test/std/algorithms/alg.modifying.oper
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
kill it with fire
https://reviews.llvm.org/D31288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
NoQ created this revision.
If result of an unary increment or decrement is unknown, conjure a symbol to
represent it based on the operator expression, not on the sub-expression.
In this particular test case, result of a LocAsInteger increment is unknown,
and it gets symbolicated to an `int *`-t
aaron.ballman added inline comments.
Comment at: docs/LanguageExtensions.rst:2319
+
+The ``#pragma clang fast_math`` allows floating-point fast-math options to be
+specified for a section of the source code. This pragma can only appear at
Missing "pragma" in fro
erichkeane updated this revision to Diff 92814.
erichkeane added a comment.
Update test based on the corresponding LLVM change.
https://reviews.llvm.org/D29599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Sema/Sema.h
lib/CodeGen/CGCall.cpp
lib/CodeG
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
In https://reviews.llvm.org/D31029#708567, @danielmarjamaki wrote:
> In https://reviews.llvm.org/D31029#703428, @zaks.anna wrote:
>
> > Are there other cases where makeNull would need to be replaced?
>
>
> There mi
yaxunl added a comment.
I think this is a good feature for the convenience of user. I've seen usage
like this.
https://reviews.llvm.org/D31183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
danielmarjamaki updated this revision to Diff 92810.
danielmarjamaki added a comment.
Updated the patch so all the loss of precision are detected also
Repository:
rL LLVM
https://reviews.llvm.org/D25596
Files:
lib/StaticAnalyzer/Checkers/ConversionChecker.cpp
test/Analysis/conversion.c
alexfh added a comment.
Krystyna, do you need help committing the patch after you address the
outstanding comments?
https://reviews.llvm.org/D29262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298608: [clang-tidy] Fix diag message for catch-by-value
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30592?vs=90572&id=92805#toc
Repository:
rL LLVM
https://reviews.llvm
Author: alexfh
Date: Thu Mar 23 10:17:44 2017
New Revision: 298608
URL: http://llvm.org/viewvc/llvm-project?rev=298608&view=rev
Log:
[clang-tidy] Fix diag message for catch-by-value
Summary:
```
catch (std::exception ex)
{
}
```
Was flagged with "catch handler catches a pointer value".
Reviewer
alexfh added a comment.
In https://reviews.llvm.org/D29858#707897, @watsond wrote:
> Following up. Was this checked in? Do I need to do anything further?
Committed the patch now. Thanks for the reminder!
Repository:
rL LLVM
https://reviews.llvm.org/D29858
___
Author: alexfh
Date: Thu Mar 23 10:13:54 2017
New Revision: 298607
URL: http://llvm.org/viewvc/llvm-project?rev=298607&view=rev
Log:
[clang-tidy] Catch trivially true statements like a != 1 || a != 3
Catch trivially true statements of the form a != 1 || a != 3. Statements like
these are likely er
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298607: [clang-tidy] Catch trivially true statements like a
!= 1 || a != 3 (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D29858?vs=90087&id=92802#toc
Repository:
rL LLVM
ht
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Do you have commit rights?
https://reviews.llvm.org/D30567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r298606.
Repository:
rL LLVM
https://reviews.llvm.org/D31190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: vvassilev
Date: Thu Mar 23 10:11:07 2017
New Revision: 298606
URL: http://llvm.org/viewvc/llvm-project?rev=298606&view=rev
Log:
Publish RAIIObjectsForParser.h for external usage.
Some clients (eg the cling interpreter) need to recover their parser from
errors.
Patch by Axel Naumann (D311
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good! Sorry for the delay.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ioeric added inline comments.
Comment at: clang-rename/USRFinder.cpp:200
+ // Also find all USRs of nested declarations.
+ NestedNameSpecifierLocFinder Finder(const_cast(Context));
ioeric wrote:
> It is unclear to me what `nested declarations` are.
But what i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298601: [libcxx] Improve code generation for
vector::clear(). (authored by brucem).
Changed prior to commit:
https://reviews.llvm.org/D25241?vs=73790&id=92796#toc
Repository:
rL LLVM
https://reviews
Author: brucem
Date: Thu Mar 23 09:39:23 2017
New Revision: 298601
URL: http://llvm.org/viewvc/llvm-project?rev=298601&view=rev
Log:
[libcxx] Improve code generation for vector::clear().
Summary:
By manipulating a local variable in the loop, when the loop can
be optimized away (due to no non-triv
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D31177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: marshall
Date: Thu Mar 23 09:20:43 2017
New Revision: 298600
URL: http://llvm.org/viewvc/llvm-project?rev=298600&view=rev
Log:
Use 'REQUIRES: c++98 || c++03 || c++11 || c++14' instead of the deprecated
'REQUIRES-ANY: c++98, c++03, c++11, c++14'
Modified:
libcxx/trunk/test/std/algori
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Hi Roman,
Welcome to the community! As others noted, adding a separate check so similar
functionally and implementation-wise to the existing one is not the best way to
go here. A si
EricWF accepted this revision.
EricWF added a comment.
Still LGTM
Comment at:
test/std/containers/sequences/vector/vector.modifiers/clear.pass.cpp:18
+#include "min_allocator.h"
+
+int main()
LIBCPP_ASSERT requires including test_macros.h
https://reviews.llv
Author: marshall
Date: Thu Mar 23 08:44:06 2017
New Revision: 298598
URL: http://llvm.org/viewvc/llvm-project?rev=298598&view=rev
Log:
One more file for the random_shuffle removal
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llv
Author: marshall
Date: Thu Mar 23 08:43:37 2017
New Revision: 298597
URL: http://llvm.org/viewvc/llvm-project?rev=298597&view=rev
Log:
Remove random_shuffle in C++17. Please use shuffle instead. If you have to,
you cant get it back by defining _LIBCPP_ENABLE_CXX17_REMOVED_RANDOM_SHUFFLE
before
brucem added a comment.
This was accepted long ago, and then I got sidetracked for a while. Is this
still okay to land?
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126
+}
+diag(Ctor->getLocation(), "function %0 can hide copy and move
constructors")
+<< Ctor;
+ }
leanil wrote:
> aaron.ballman wrote:
> >
arphaman updated this revision to Diff 92783.
arphaman marked an inline comment as done.
arphaman added a comment.
The condition in the if is now more clear.
Repository:
rL LLVM
https://reviews.llvm.org/D31177
Files:
lib/Sema/SemaExpr.cpp
test/SemaObjCXX/arc-ptr-comparison.mm
Index: te
arphaman added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:9431
+ ? 2
+ : 1)) {
if (convertPointersToCompositeType(*this, Loc, LHS, RHS))
ahatanak wrote:
> It wasn't clear to me why the code has to be added to the right hand
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298589: Support attributes for Objective-C categories
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D31179?vs=92454&id=92782#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: arphaman
Date: Thu Mar 23 06:44:25 2017
New Revision: 298589
URL: http://llvm.org/viewvc/llvm-project?rev=298589&view=rev
Log:
Support attributes for Objective-C categories
rdar://31095315
Differential Revision: https://reviews.llvm.org/D31179
Added:
cfe/trunk/test/SemaObjC/category
Author: arphaman
Date: Thu Mar 23 06:14:27 2017
New Revision: 298588
URL: http://llvm.org/viewvc/llvm-project?rev=298588&view=rev
Log:
[CodeGen] Emit a CoreFoundation link guard when @available is used
After r297760, __isOSVersionAtLeast in compiler-rt loads the CoreFoundation
symbols at runtime.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298588: [CodeGen] Emit a CoreFoundation link guard when
@available is used (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30977?vs=92028&id=92780#toc
Repository:
rL LLVM
arphaman added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5547
+ if (ShadowedDecl && !Redeclaration) {
+CheckShadow(NewTD, ShadowedDecl, Previous);
You don't need to use `{}` braces here.
Comment at: lib/Sema/SemaDecl.cpp:6753
Author: arphaman
Date: Thu Mar 23 05:46:05 2017
New Revision: 298587
URL: http://llvm.org/viewvc/llvm-project?rev=298587&view=rev
Log:
[ObjC][ARC] Avoid -Warc-performSelector-leaks for performSelector variations
that became supported after r297019
The commit r297019 expanded the performSelector O
lebedev.ri added a comment.
In https://reviews.llvm.org/D31252#708209, @Eugene.Zelenko wrote:
> Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Done
> Will be good idea to run Clang-tidy modernize and readability checks over new
> code.
I did run them (`-checks=*`
lebedev.ri updated this revision to Diff 92775.
lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.
No changes compared to v2, just correctly rebased the master branch now.
https://reviews.llvm.org/D31252
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readabili
lebedev.ri updated this revision to Diff 92774.
lebedev.ri added a comment.
Addressing review notes.
https://reviews.llvm.org/D31252
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/CompoundStatementSizeCheck.cpp
clang-tidy/readability/CompoundStatementSizeCheck.h
cla
danielmarjamaki added a comment.
In https://reviews.llvm.org/D31029#703428, @zaks.anna wrote:
> Are there other cases where makeNull would need to be replaced?
There might be. As I understand it, this is the only known case at the moment.
Repository:
rL LLVM
https://reviews.llvm.org/D31029
1 - 100 of 106 matches
Mail list logo
