[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

2017-03-18 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

2017-03-18 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In https://reviews.llvm.org/D30415#703652, @uweigand wrote: > In https://reviews.llvm.org/D30415#703442, @hfinkel wrote: > > > In https://reviews.llvm.org/D30415#703398, @echristo wrote: > > > > > Different suggestion: > > > > > > Remove the faltivec option. Even gcc doe

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D31114#704748, @tejohnson wrote: > In https://reviews.llvm.org/D31114#704733, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D31114#704728, @tejohnson wrote: > > > > > In https://reviews.llvm.org/D31114#704726, @mehdi_amini wrote: >

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D31114#704733, @mehdi_amini wrote: > In https://reviews.llvm.org/D31114#704728, @tejohnson wrote: > > > In https://reviews.llvm.org/D31114#704726, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D31114#704649, @tejohnson wrote: > >

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D31114#704728, @tejohnson wrote: > In https://reviews.llvm.org/D31114#704726, @mehdi_amini wrote: > > > In https://reviews.llvm.org/D31114#704649, @tejohnson wrote: > > > > > I think you won't get the correct handling of -emit-llvm and > >

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. In https://reviews.llvm.org/D31114#704726, @mehdi_amini wrote: > In https://reviews.llvm.org/D31114#704649, @tejohnson wrote: > > > I think you won't get the correct handling of -emit-llvm and -emit-llvm-bc > > since we don't get the handling for Backend_Emit* in > >

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. In https://reviews.llvm.org/D31114#704649, @tejohnson wrote: > I think you won't get the correct handling of -emit-llvm and -emit-llvm-bc > since we don't get the handling for Backend_Emit* in > EmitAssemblyHelper::EmitAssembly. I was not trying to achieve this. A

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:982 std::unique_ptr OS) { + EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); + tejohnson wrote: > Why did this move? "History

[PATCH] D30009: Add support for '#pragma clang attribute'

2017-03-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I really like the way this feature is shaping up! I apologize for how long it took to review the code (I was out for work for two weeks and this is a pretty extensive patch). Thank you for the continued efforts on this. Comment at: docs/Language

[PATCH] D30766: Add support for attribute "enum_extensibility"

2017-03-18 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the request for a FIXME and a decision from the author on error vs warning, the code LGTM. Feel free to make a decision and commit without further review. =

[PATCH] D31114: Refactor `initTargetOptions` out of `EmitAssemblyHelper::CreateTargetMachine` and use it to initialize TargetOptions for ThinLTO Backends

2017-03-18 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. I think you won't get the correct handling of -emit-llvm and -emit-llvm-bc since we don't get the handling for Backend_Emit* in EmitAssemblyHelper::EmitAssembly. Comment at: clang/lib/CodeGen/BackendUtil.cpp:595 llvm::Optional RM; RM = llvm::S

r298185 - Revert "Modules: Cache PCMs in memory and avoid a use-after-free"

2017-03-18 Thread Renato Golin via cfe-commits
Author: rengolin Date: Sat Mar 18 07:31:32 2017 New Revision: 298185 URL: http://llvm.org/viewvc/llvm-project?rev=298185&view=rev Log: Revert "Modules: Cache PCMs in memory and avoid a use-after-free" This reverts commit r298165, as it broke the ARM builds. Removed: cfe/trunk/include/clang/B

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

2017-03-18 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D31097#704626, @alexfh wrote: > In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > > > I wonder whether warning on implicit casts still makes sense for example in > > mission critical code. So maybe it is worth to have a configurati

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

2017-03-18 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D31097#704626, @alexfh wrote: > In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > > > I wonder whether warning on implicit casts still makes sense for example in > > mission critical code. So maybe it is worth to have a configur

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

2017-03-18 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D31097#704621, @xazax.hun wrote: > I wonder whether warning on implicit casts still makes sense for example in > mission critical code. So maybe it is worth to have a configuration option > with the default setting being less strict and chatty

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

2017-03-18 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. I wonder whether warning on implicit casts still makes sense for example in mission critical code. So maybe it is worth to have a configuration option with the default setting being less strict and chatty. What do you think? Repository: rL LLVM https://reviews.llv