Hi Bruno,
Thank you for the fix. I couldn't get to it today. I'll watch the sanitizer
bots more carefully in future.
On Mar 13, 2017 10:26 PM, "Bruno Cardoso Lopes"
wrote:
> Hi Eric,
>
> I fixed the build for darwin in r297703, let me know if you have any
> comments.
>
> Thanks,
>
> On Mon, Mar
Hi Eric,
I fixed the build for darwin in r297703, let me know if you have any comments.
Thanks,
On Mon, Mar 13, 2017 at 3:04 PM, Bruno Cardoso Lopes
wrote:
> Hi Eric,
>
>> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
>> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
>>
pirama marked 3 inline comments as done.
pirama added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:369
if (A->getOption().matches(options::OPT_O4) ||
-A->getOption().matches(options::OPT_Ofast))
+A->getOption().matches(options::OPT_Ofast)
Author: bruno
Date: Mon Mar 13 23:12:29 2017
New Revision: 297703
URL: http://llvm.org/viewvc/llvm-project?rev=297703&view=rev
Log:
Fix cmake to find the compiler-rt libs on darwin
Followup for r297553, which left darwin in a broken state
http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgS
pirama updated this revision to Diff 91671.
pirama added a comment.
Address review comments
https://reviews.llvm.org/D30920
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/gold-lto.c
Index: test/Driver/gold-lto.c
===
Committed r297702.
> On Mar 13, 2017, at 10:02 AM, Lobron, David wrote:
>
> Yes, please, if you don't mind! I'd like to commit both the path and the
> unit test, if possible.
>
> Thanks,
>
> David
>
>> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>>
>> Do you need someone to commit
Author: ahatanak
Date: Mon Mar 13 23:00:52 2017
New Revision: 297702
URL: http://llvm.org/viewvc/llvm-project?rev=297702&view=rev
Log:
[CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded
correctly.
This fixes PR30413.
Patch by David Lobron.
Added:
cfe/trunk/test/CodeGenObjC/i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297700: [ubsan] Add a nullability sanitizer (authored by
vedantk).
Changed prior to commit:
https://reviews.llvm.org/D30762?vs=91382&id=91658#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30762
Author: vedantk
Date: Mon Mar 13 20:56:34 2017
New Revision: 297700
URL: http://llvm.org/viewvc/llvm-project?rev=297700&view=rev
Log:
[ubsan] Add a nullability sanitizer
Teach UBSan to detect when a value with the _Nonnull type annotation
assumes a null value. Call expressions, initializers, assi
mehdi_amini added a comment.
Agree with @pcc. Unless anyone has a need to have "perfect" support for Os,
this is the right direction.
https://reviews.llvm.org/D30920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
pcc added a comment.
In https://reviews.llvm.org/D30920#700077, @tejohnson wrote:
> Until everything is converted to using size attributes, it seems like a
> correct fix for the bug is to accept these options in the gold-plugin and
> pass through the LTO API to the PassManagerBuilder.
Not nec
rnk updated this revision to Diff 91653.
rnk marked an inline comment as done.
rnk added a comment.
- Actually make this warning off by default
https://reviews.llvm.org/D30923
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.c
rnk marked an inline comment as done.
rnk added inline comments.
Comment at: test/Sema/warn-bitfield-enum-conversion.c:3
+
+enum TwoBits { Hi1 = 3 } two_bits;
+enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed;
thakis wrote:
> can you add an enum with an e
rnk updated this revision to Diff 91652.
rnk added a comment.
- Make test C++, add fixed type enum
https://reviews.llvm.org/D30923
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/SemaCXX/warn-bitfield-enum-conversi
thakis added inline comments.
Comment at: test/Sema/warn-bitfield-enum-conversion.c:3
+
+enum TwoBits { Hi1 = 3 } two_bits;
+enum TwoBitsSigned { Lo2 = -2, Hi2 = 1 } two_bits_signed;
can you add an enum with an explicit underlying type? will this warning always
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D30700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: djasper
Date: Mon Mar 13 19:40:32 2017
New Revision: 297696
URL: http://llvm.org/viewvc/llvm-project?rev=297696&view=rev
Log:
clang-format: Make it very slighly more expensive to wrap between "= {".
This prevents unwanted fallout from r296664. Specifically in proto formatting,
this change
Author: efriedma
Date: Mon Mar 13 19:18:29 2017
New Revision: 297694
URL: http://llvm.org/viewvc/llvm-project?rev=297694&view=rev
Log:
Fix crash with interrupt attribute on ARM.
An indirect call has no associated function declaration.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
cfe/trunk/
Author: ributzka
Date: Mon Mar 13 19:14:40 2017
New Revision: 297693
URL: http://llvm.org/viewvc/llvm-project?rev=297693&view=rev
Log:
Reapply [VFS] Ignore broken symlinks in the directory iterator.
Modified the tests to accept any iteration order, to run only on Unix, and added
additional error
tejohnson added a comment.
Interested in pcc's thoughts, as https://bugs.llvm.org/show_bug.cgi?id=32155
mentioned you already discussed with him. Note that some of the passes that
check PassManagerBuilder::sizeLevel are added during the ThinLTO back end (e.g.
populateModulePassManager which che
rnk created this revision.
This adds -Wbitfield-enum-conversion, which warns on implicit
conversions that happen on bitfield assignment that change the value of
some enumerators.
Values of enum type typically take on a very small range of values, so
they are frequently stored in bitfields. Unfort
craig.topper created this revision.
The fma libcalls are defined in Builtins.def using the 'e' attribute that says
that its only const if -fno-math-errno. It was apparently marked this way
because that's what the posix spec says. This determines whether the call gets
marked as const or not in S
A quick update.
The SVN mirror got corrupted by r297634. Svnsync does not like huge commits.
I'm in the middle of restoring and synch-ing up the mirror. Too soon to
give any ETA, unfortunately.
Thank you for your patience.
Thanks
Galina
On Mon, Mar 13, 2017 at 12:36 PM, Galina Kistanova
wro
majnemer added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:85
+ unsigned No = 0;
+ StringRef AwaitKindStr = 0;
+ switch (Kind) {
I'd just let the default constructor do its thing.
https://reviews.llvm.org/D30809
__
pirama created this revision.
Herald added a subscriber: mehdi_amini.
Address PR32155: Skip passing -Os and -Oz to the Gold plugin using
-plugin-opt.
https://reviews.llvm.org/D30920
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/gold-lto.c
Index: test/Driver/gold-lto.c
==
Author: rnk
Date: Mon Mar 13 17:33:04 2017
New Revision: 297680
URL: http://llvm.org/viewvc/llvm-project?rev=297680&view=rev
Log:
Widen AST bitfields too small to represent all enumerators
All of these were found by a new warning that I am prototyping,
-Wbitfield-enum-conversion.
Stmt::ExprBits:
Author: rnk
Date: Mon Mar 13 17:33:07 2017
New Revision: 297681
URL: http://llvm.org/viewvc/llvm-project?rev=297681&view=rev
Log:
Fix -Wunused-lambda-capture warning in new code
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp
URL:
http://l
pirama added inline comments.
Comment at: lib/Driver/ToolChain.cpp:652
+// libc++ may be installed per arch.
+addArchSpecificRPath(*this, Args, CmdArgs);
break;
Hahnfeld wrote:
> pirama wrote:
> > `addArchSpecificRPath` is a static function in Tools.
pirama updated this revision to Diff 91635.
pirama added a comment.
*Actually* add the command line flags.
https://reviews.llvm.org/D30700
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdi
rnk added a comment.
In https://reviews.llvm.org/D30700#695358, @Hahnfeld wrote:
> No build system will ever set `-frtlib-add-rpath` to enable this "feature".
> I'm for keeping this opt-out until we have configuration files to set this by
> default. Making it opt-in would weaken its main reason
pirama updated this revision to Diff 91633.
pirama added a comment.
- Rebase
- Added command line flag and updated tests.
https://reviews.llvm.org/D30700
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/arch-specific-libdir-rpath.c
test/Driver/arch-specific-libdir.c
test/lit.cfg
aaron.ballman added a comment.
I'm curious what kind of results you get when running this over a large code
base. There are definitely times when using == or != for a specific value is
*way* cleaner than using a switch statement, and I worry about this being so
chatty that it needs to be disabl
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:1434
+
+ // Canonicalize -fmodules-cache-path before storing it.
+ SmallString<128> P(Args.getLastArgValue(OPT_fmodules_c
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1969
+ let Content = [{
+Attribute ``enum_extensibility`` is used to distinguish between enum
definitions that are extensible and those that are not. The attribute can take
either ``closed`` or ``
aprantl created this revision.
This fixes lookup mismatches that could previously happen when the module cache
path contained a '/./' component.
In combination with https://reviews.llvm.org/D28299 this bug can cause a
use-after-free.
rdar://problem/30413458
https://reviews.llvm.org/D30915
Fi
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck
Hi Eric,
> if (APPLE AND (LIBCXX_CXX_ABI_LIBNAME STREQUAL "libcxxabi" OR
> @@ -62,12 +66,7 @@ if (APPLE AND LLVM_USE_SANITIZER)
> message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not
> supported on OS X")
>endif()
>if (LIBFILE)
> -execute_process(COMMAND ${CMAKE_CXX_
marsupial updated this revision to Diff 91627.
marsupial retitled this revision from "Add test for
PPCallbacks::MacroUndefined" to "PPCallbacks::MacroUndefined, change signature
and add test.".
marsupial edited the summary of this revision.
Herald added a subscriber: nemanjai.
https://reviews.ll
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r297671, thanks!
https://reviews.llvm.org/D30610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Mon Mar 13 16:39:00 2017
New Revision: 297671
URL: http://llvm.org/viewvc/llvm-project?rev=297671&view=rev
Log:
Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the
cppcoreguidelines-special-member-functions check.
Patch by Florian Gross.
Adde
andreybokhanko added a comment.
Hi Roger,
I'm very glad to see you started to work on this!
A somewhat obvious comment: no chance for this to be accepted without LIT
tests. I understand you have your doubts on the best approach to testing -- and
it's OK to ask either here or on llvm-dev -- but
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699695, @bruno wrote:
> Hi JinGu,
>
> I just read the discussion on cfe-dev, some comments:
>
> > My colleague and I are implementing a transformation pass between LLVM IR
> > and another IR and we want to keep the 3-component vector
vlad.tsyrklevich updated this revision to Diff 91615.
vlad.tsyrklevich added a comment.
Fix a stray assert(), correctly this time..
https://reviews.llvm.org/D30909
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h
include/clang/StaticAnalyzer/Core/PathSensitive/TaintMana
vlad.tsyrklevich updated this revision to Diff 91614.
vlad.tsyrklevich added a comment.
Fix a stray assert()
https://reviews.llvm.org/D30909
Files:
lib/StaticAnalyzer/Core/ProgramState.cpp
Index: lib/StaticAnalyzer/Core/ProgramState.cpp
==
vlad.tsyrklevich created this revision.
This is the second part of https://reviews.llvm.org/D28445, it extends taint
propagation to cases where the tainted region is a sub-region and we can't
taint a conjured symbol entirely. This required adding a new map in the GDM
that maps tainted parent sy
rsmith added inline comments.
Comment at: lib/Sema/Sema.cpp:472-477
+// If this is a function template, we should remove if it has no
+// specializations.
+if (FunctionTemplateDecl *Template = FD->getDescribedFunctionTemplate()) {
+ if (std::distance(Template->sp
bruno added a comment.
Hi Pete,
Comment at: lib/Frontend/DependencyFile.cpp:191
+ const Token &FilenameTok,
+ SrcMgr::CharacteristicKind FileType) override;
+
Is there any `FileSkipped` callback invocation that might trigger
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Pete, thanks for working on this!
LGTM with the minor comments below.
Comment at: include/clang/Lex/PPCallbacks.h:264
+ virtual void HasInclude(SourceLocation Loc, const F
bruno added a reviewer: bruno.
bruno added a comment.
Hi JinGu,
I just read the discussion on cfe-dev, some comments:
> My colleague and I are implementing a transformation pass between LLVM IR and
> another IR and we want to keep the 3-component vector types in our target IR
Why can't you go
arsenm closed this revision.
arsenm added a comment.
r297658, r297659
https://reviews.llvm.org/D30316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arsenm
Date: Mon Mar 13 14:47:53 2017
New Revision: 297659
URL: http://llvm.org/viewvc/llvm-project?rev=297659&view=rev
Log:
AMDGPU: Make 0 the private nullptr value
We can't actually pretend that 0 is valid for address space 0.
r295877 added a workaround to stop allocating user objects
t
jaykang10 added a comment.
In https://reviews.llvm.org/D30810#699428, @Anastasia wrote:
> Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation
> accordingly to make things consistent?
Probably, No... the load/store with vec3 generates vec4 temporarily to be
aligned bu
Hello everyone,
The SVN mirror in the LLVM Lab seems behind with the changes.
I'm looking at the issue.
Thank you for understanding.
Thanks
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:96
+
+ Finds uses of enumeration values in equality and inequality expressions
where a switch would be preferred.
+
Please highlight switch with `` and indent preferred on
dexonsmith closed this revision.
dexonsmith marked 3 inline comments as done.
dexonsmith added a comment.
Thanks for the review Richard! Committed in r297655 with those changes.
Sorry for the long delay on this. Somehow I missed until today the review
after my ultimate ping. I'd like to blame
Author: dexonsmith
Date: Mon Mar 13 13:45:08 2017
New Revision: 297655
URL: http://llvm.org/viewvc/llvm-project?rev=297655&view=rev
Log:
Modules: Use hash of PCM content for SIGNATURE
Change ASTFileSignature from a random 32-bit number to the hash of the
PCM content.
- Move definition ASTFileS
guansong updated this revision to Diff 91600.
https://reviews.llvm.org/D30743
Files:
lib/Driver/Tools.cpp
test/Driver/include-default-header.cl
Index: test/Driver/include-default-header.cl
===
--- /dev/null
+++ test/Driver/incl
Author: rnk
Date: Mon Mar 13 13:42:30 2017
New Revision: 297654
URL: http://llvm.org/viewvc/llvm-project?rev=297654&view=rev
Log:
Widen bitfield for type specifiers for OpenCL types
Added a static_assert to catch this issue at compile time.
Modified:
cfe/trunk/include/clang/Basic/Specifiers.
Anastasia added a comment.
In https://reviews.llvm.org/D28136#697844, @bader wrote:
> > Why do you think this is a bug? It seems to follow standard behavior in C
> > to promote char to int if required. Just like if you would have a C code:
> >
> > int as_int(int i);
> > void foo() {
> >
JonasToth added a comment.
alright. then i have a good check for myself to write ;)
https://reviews.llvm.org/D30896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jdevlieghere
Date: Mon Mar 13 13:08:11 2017
New Revision: 297649
URL: http://llvm.org/viewvc/llvm-project?rev=297649&view=rev
Log:
[Linker] Provide callback for internalization
Differential Revision: https://reviews.llvm.org/D30738
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenAct
fgross added a comment.
No commit access, could someone please take care of this? Thanks!
https://reviews.llvm.org/D30610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
Handling
enum Kind k = Kind::a;
if (k == 3) { /* something */ }
is intentionally out of scope for now as the author is doing something that I
can't trivially replace with a switch.
Comment at: clang-tools-ext
Anastasia added inline comments.
Comment at: lib/Driver/Tools.cpp:5288
// parser.
- Args.AddAllArgValues(CmdArgs, options::OPT_Xclang);
+ if (C.getDriver().isSaveTempsEnabled() &&
+ !isa(JA)) {
It would be nice to add a comment around here explaining th
jbcoe updated this revision to Diff 91588.
jbcoe added a comment.
Minor edits in response to review comments. A few questions outstanding.
https://reviews.llvm.org/D30896
Files:
clang-tools-extra/clang-tidy/misc/CMakeLists.txt
clang-tools-extra/clang-tidy/misc/MiscTidyModule.cpp
clang-too
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297642: [X86] Add checking of the scale argument to
scatter/gather builtins (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D30875?vs=91508&id=91586#toc
Repository:
rL LLVM
Author: ctopper
Date: Mon Mar 13 12:16:50 2017
New Revision: 297642
URL: http://llvm.org/viewvc/llvm-project?rev=297642&view=rev
Log:
[X86] Add checking of the scale argument to scatter/gather builtins
The only valid values for scale immediate of scatter/gather builtins are 1, 2,
4, or 8. This p
Yes, please, if you don't mind! I'd like to commit both the path and the unit
test, if possible.
Thanks,
David
> On Mar 13, 2017, at 12:47 PM, Akira Hatanaka wrote:
>
> Do you need someone to commit this patch for you?
>
>> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>>
>> Hi Akira,
Do you need someone to commit this patch for you?
> On Mar 10, 2017, at 6:44 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Thank you very much! Please let me know if I need to take any further steps
> beyond this email to cfe-commits in order for the patch and the unit test to
> be committed.
>
Anastasia added a comment.
Would you be able to update ScalarExprEmitter::VisitAsTypeExpr implementation
accordingly to make things consistent?
https://reviews.llvm.org/D30810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Anastasia added inline comments.
Comment at: test/SemaOpenCL/overload-scalar-widening.cl:4
+
+typedef short short4 __attribute__((ext_vector_type(4)));
+
I am thinking could this be a CodeGen test instead and we could check that the
right overload is selected ba
ahatanak added inline comments.
Comment at: test/Sema/enum-attr.c:27
+
+enum __attribute__((enum_extensibility(arg1))) EnumInvalidArg { //
expected-warning{{'enum_extensibility' attribute argument not supported:
'arg1'}}
+ G
arphaman wrote:
> Should this be an
ahatanak updated this revision to Diff 91577.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address Alex's review comments.
https://reviews.llvm.org/D30766
Files:
include/clang/AST/Decl.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Ba
rogfer01 created this revision.
This is the clang side of the RFC in
http://lists.llvm.org/pipermail/cfe-dev/2017-February/052549.html
Note that in contrast to the original suggestion `-fsource-asm` here we use the
preferred `-fverbose-asm`. Basically explicitly saying `-fverbose-asm` in the
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297630: [include-fixer] Add fuzzy SymbolIndex, where
identifier needn't match exactly. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D30720?vs=91042&id=91570#toc
Repository
Author: sammccall
Date: Mon Mar 13 10:55:59 2017
New Revision: 297630
URL: http://llvm.org/viewvc/llvm-project?rev=297630&view=rev
Log:
[include-fixer] Add fuzzy SymbolIndex, where identifier needn't match exactly.
Summary:
Add fuzzy SymbolIndex, where identifier needn't match exactly.
The purpo
jroelofs added a comment.
In https://reviews.llvm.org/D30158#699132, @madsravn wrote:
> In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
> >
> > > Any updates on this?
> >
> >
> > Have you run it over the test suite
JonasToth added a comment.
I like that check. But I think it could take another feature.
In my opinion it would be valueable to check if enums are compared against ints
as well.
For example
enum Kind k = Kind::a;
if (k == 3) { /* something */ }
This usecase is not specially considered here
bkramer accepted this revision.
bkramer added a comment.
lg as a prototype.
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Mon Mar 13 10:43:42 2017
New Revision: 297628
URL: http://llvm.org/viewvc/llvm-project?rev=297628&view=rev
Log:
[CodeCompletion] Format block parameter placeholders in implicit property
setters using the block type information that's obtained from the property
rdar://126042
jbcoe created this revision.
jbcoe added a project: clang-tools-extra.
Herald added subscribers: JDevlieghere, mgorny.
Add a check to find enums used in `==` or `!=` expressions. Using a switch
statement leads to more easily maintained code.
Repository:
rL LLVM
https://reviews.llvm.org/D3089
sammccall added a comment.
bkramer: ping
https://reviews.llvm.org/D30720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297627: [ASTImporter] Import fix of GCCAsmStmts w/ missing
symbolic operands (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D30831?vs=91541&id=91567#toc
Repository:
rL LLVM
h
Author: xazax
Date: Mon Mar 13 10:32:24 2017
New Revision: 297627
URL: http://llvm.org/viewvc/llvm-project?rev=297627&view=rev
Log:
[ASTImporter] Import fix of GCCAsmStmts w/ missing symbolic operands
Patch by Zoltan Gera!
Differential Revision: https://reviews.llvm.org/D30831
Modified:
cfe
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good, thank you!
https://reviews.llvm.org/D30831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
marsupial updated this revision to Diff 91563.
marsupial retitled this revision from "Send UndefMacroDirective to MacroDefined
callback" to "Add test for PPCallbacks::MacroUndefined".
marsupial edited the summary of this revision.
https://reviews.llvm.org/D29923
Files:
unittests/Basic/SourceMa
Author: sylvestre
Date: Mon Mar 13 09:42:47 2017
New Revision: 297623
URL: http://llvm.org/viewvc/llvm-project?rev=297623&view=rev
Log:
[clang-format] Add more examples and fix a bug in the py generation script
Reviewers: djasper
Reviewed By: djasper
Subscribers: cfe-commits, klimek
Differenti
v.g.vassilev added a comment.
@rsmith ping...
https://reviews.llvm.org/D29877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297620: When diagnosing taking address of packed members
skip __unaligned-qualified… (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D30884?vs=91531&id=91548#toc
Repository:
Author: rogfer01
Date: Mon Mar 13 08:18:21 2017
New Revision: 297620
URL: http://llvm.org/viewvc/llvm-project?rev=297620&view=rev
Log:
When diagnosing taking address of packed members skip __unaligned-qualified
expressions
Given that we have already explicitly stated in the qualifier that the
ex
Author: xazax
Date: Mon Mar 13 07:48:26 2017
New Revision: 297619
URL: http://llvm.org/viewvc/llvm-project?rev=297619&view=rev
Log:
[analyzer] Fix a rare crash for valist check.
It looks like on some host-triples the result of a valist related expr can be
a LazyCompoundVal. Handle that case in th
gerazo marked an inline comment as done.
gerazo added inline comments.
Comment at: lib/AST/ASTImporter.cpp:5221
IdentifierInfo *ToII = Importer.Import(S->getOutputIdentifier(I));
-if (!ToII)
- return nullptr;
+// ToII is nullptr when no symbolic name is given fo
bader added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
gerazo updated this revision to Diff 91541.
gerazo added a comment.
Better check not letting a real import problem passing through
https://reviews.llvm.org/D30831
Files:
lib/AST/ASTImporter.cpp
test/ASTMerge/asm/Inputs/asm-function.cpp
test/ASTMerge/asm/test.cpp
Index: test/ASTMerge/asm
madsravn added a comment.
In https://reviews.llvm.org/D30158#698871, @aaron.ballman wrote:
> In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
>
> > Any updates on this?
>
>
> Have you run it over the test suite on the revision before random_shuffle was
> removed from libc++?
I can't
rogfer01 added a comment.
Thanks for the review @aaron.ballman!
https://reviews.llvm.org/D30884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D30884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
echuraev updated this revision to Diff 91536.
https://reviews.llvm.org/D30643
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.cpp
lib/Sema/SemaInit.cpp
test/Parser/opencl-atomics-cl20.cl
test/SemaOpenCL/atomic-init.cl
Index: test/SemaOpenCL/atomic-init.cl
=
1 - 100 of 126 matches
Mail list logo
