alexfh added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:184
+ if (!MissingMembers.empty())
+diag(ID.first, "class '%0' defines %1 but does not define %2")
+<< ID.second << join(DefinedMembers, " and ")
A
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r297592, thank you!
https://reviews.llvm.org/D26800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Sun Mar 12 17:30:07 2017
New Revision: 297592
URL: http://llvm.org/viewvc/llvm-project?rev=297592&view=rev
Log:
Allow the nonnull attribute to be inherited as a parameter in the redefinition
of a function. Fixes PR30828.
Patch by Matt Bettinson.
Modified:
cfe/trun
Author: ctopper
Date: Sun Mar 12 17:19:10 2017
New Revision: 297590
URL: http://llvm.org/viewvc/llvm-project?rev=297590&view=rev
Log:
[AVX-512] Add range check for locality hint immediate on scatter/gather
prefetch builtins.
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D30610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297588: [x86] these aren't the undefs you're looking for
(PR32176) (authored by spatel).
Changed prior to commit:
https://reviews.llvm.org/D30834?vs=91362&id=91507#toc
Repository:
rL LLVM
https://re
Author: spatel
Date: Sun Mar 12 14:15:10 2017
New Revision: 297588
URL: http://llvm.org/viewvc/llvm-project?rev=297588&view=rev
Log:
[x86] these aren't the undefs you're looking for (PR32176)
x86 has undef SSE/AVX intrinsics that should represent a bogus register
operand.
This is not the same a
Author: ctopper
Date: Sun Mar 12 12:58:12 2017
New Revision: 297584
URL: http://llvm.org/viewvc/llvm-project?rev=297584&view=rev
Log:
[AVX-512] Fix avx512vl gather builtins to require the scale argument to be an
ICE like the rest of the gather builtins.
Modified:
cfe/trunk/include/clang/Basi
mprobst created this revision.
Herald added a subscriber: klimek.
`interface` and `type` are pseudo keywords and cause automatic semicolon
insertion when followed by a line break:
interface // gets parsed as a long variable access to "interface"
VeryLongInterfaceName {
}
With this
aaron.ballman added inline comments.
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:31
+ ->getName()
+ .find("enable_if") != StringRef::npos;
+ };
leanil wrote:
> aaron.ballman wrote:
> > This should be using `equals
aaron.ballman added a comment.
In https://reviews.llvm.org/D30158#696534, @madsravn wrote:
> Any updates on this?
Have you run it over the test suite on the revision before random_shuffle was
removed from libc++?
https://reviews.llvm.org/D30158
GorNishanov marked an inline comment as done.
GorNishanov added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:85
+ unsigned No = 0;
+ const char* AwaitKindStr = 0;
+ switch (Kind) {
majnemer wrote:
> I'd use a StringRef here.
StringRef it is.
htt
GorNishanov updated this revision to Diff 91497.
GorNishanov added a comment.
Implemented review feedback: const char * => StringRef in buildSuspendSuffixStr
https://reviews.llvm.org/D30809
Files:
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExprAgg.cpp
lib/CodeGen/CGExprScalar.cpp
lib/Cod
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersNodeTest.cpp:1501
- std::string Objc1String =
+ std::string ObjCString =
+"#pragma clang diagnostic ignored \"-Wobjc-root-class\"\n"
These changes are unrelated and should b
14 matches
Mail list logo
