twoh abandoned this revision.
twoh added a comment.
@inglorion That makes a lot of sense. Maybe we don't even need -g, because -S
-emit-llvm shows source_filename. I'll run some more experiments with
relpath/abspath and debug locations, and submit a revised patch. Thanks for the
comment!
http
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM, by the way.
https://reviews.llvm.org/D30599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
vsk added a comment.
In https://reviews.llvm.org/D30599#692210, @jroelofs wrote:
> Can the null check be performed in the callee?
Yes, but I think that would result in perplexing diagnostics, because we
wouldn't be able to report the source location of the buggy calls.
> That'd make this chec
jroelofs added a comment.
Can the null check be performed in the callee?
That'd make this check work for a few more cases that this patch doesn't cover:
- `performSelector:` messages
- messages to `id`.
https://reviews.llvm.org/D30599
___
cfe-comm
vsk created this revision.
UBSan's nonnull argument check applies when a parameter has the
"nonnull" attribute. The check currently works for FunctionDecls, but
not for ObjCMethodDecls. This patch extends the check to work for ObjC.
To do this, I introduced a new AbstractCallee class to represent
On 3/3/17 7:45 PM, Eric Fiselier wrote:
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
Ah, cool.
Jon
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 3/3/17 6:26 PM, Eri
Author: ericwf
Date: Fri Mar 3 21:23:15 2017
New Revision: 296960
URL: http://llvm.org/viewvc/llvm-project?rev=296960&view=rev
Log:
Fully Reformat fallback_malloc.cpp
This patch fully reformats fallback_malloc.cpp. Previously the test
was a mess of different styles and indentations. This made it
Author: rtrieu
Date: Fri Mar 3 21:04:15 2017
New Revision: 296958
URL: http://llvm.org/viewvc/llvm-project?rev=296958&view=rev
Log:
[ODRHash] Try again to fix build bot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm.org/viewvc/
Author: ericwf
Date: Fri Mar 3 21:03:27 2017
New Revision: 296957
URL: http://llvm.org/viewvc/llvm-project?rev=296957&view=rev
Log:
Add missing UNSUPPORTED for -fno-exception mode
Modified:
libcxxabi/trunk/test/test_exception_address_alignment.pass.cpp
Modified: libcxxabi/trunk/test/test_ex
Author: rtrieu
Date: Fri Mar 3 20:42:41 2017
New Revision: 296956
URL: http://llvm.org/viewvc/llvm-project?rev=296956&view=rev
Log:
Handle null QualType better in Stmt::Profile
If the QualType is null, calling ASTContext::getCanonicalType on it will lead
to an assert. This was found while testi
LIBCXXABI_HAS_CXA_THREAD_ATEXIT_IMPL should be set by
`check_library_exists` at the bottom of `config-ix.cmake`.
On Fri, Mar 3, 2017 at 7:22 PM, Jonathan Roelofs
wrote:
>
>
> On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
>
>> Author: ericwf
>> Date: Fri Mar 3 19:26:41 2017
>> New Revi
Author: ericwf
Date: Fri Mar 3 20:29:25 2017
New Revision: 296955
URL: http://llvm.org/viewvc/llvm-project?rev=296955&view=rev
Log:
Attempt to suppress test failures on OS X
Modified:
libcxxabi/trunk/test/libcxxabi/test/config.py
libcxxabi/trunk/test/test_exception_address_alignment.pass
On 3/3/17 6:26 PM, Eric Fiselier via cfe-commits wrote:
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk
Author: ericwf
Date: Fri Mar 3 20:15:37 2017
New Revision: 296954
URL: http://llvm.org/viewvc/llvm-project?rev=296954&view=rev
Log:
Fix CMake configuration errors on OS X
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-proj
Author: rtrieu
Date: Fri Mar 3 20:05:13 2017
New Revision: 296953
URL: http://llvm.org/viewvc/llvm-project?rev=296953&view=rev
Log:
[ODRHash] Change test to try to appease buildbot.
Modified:
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/test/Modules/odr_hash.cpp
URL:
http://llvm
Author: ericwf
Date: Fri Mar 3 20:04:45 2017
New Revision: 296952
URL: http://llvm.org/viewvc/llvm-project?rev=296952&view=rev
Log:
[libcxxabi] Fix alignment of allocated exceptions in 32 bit builds
Summary:
In 32 bit builds on a 64 bit system `std::malloc` does not return correctly
aligned mem
EricWF updated this revision to Diff 90561.
EricWF added a comment.
Merge with master
https://reviews.llvm.org/D25417
Files:
src/cxa_exception.cpp
src/fallback_malloc.cpp
src/fallback_malloc.h
test/test_exception_address_alignment.pass.cpp
Index: test/test_exception_address_alignment.p
dcoughlin added reviewers: zaks.anna, NoQ.
dcoughlin added a comment.
The analyzer has two different kinds of diagnostics: AST-based and
path-sensitive. AST-based diagnostics are similar to the diagnostics that clang
performs in Sema in that they can usually be localized to a single program
poi
Author: ericwf
Date: Fri Mar 3 19:29:51 2017
New Revision: 296942
URL: http://llvm.org/viewvc/llvm-project?rev=296942&view=rev
Log:
teach LIT how to detect the glibc version
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
http://ll
Author: ericwf
Date: Fri Mar 3 19:26:41 2017
New Revision: 296940
URL: http://llvm.org/viewvc/llvm-project?rev=296940&view=rev
Log:
Fix PR25874 - Detect features required for cxa_thread_atexit_test.pass.cpp
Modified:
libcxxabi/trunk/test/CMakeLists.txt
libcxxabi/trunk/test/cxa_thread_ate
Author: rizsotto
Date: Fri Mar 3 19:08:05 2017
New Revision: 296937
URL: http://llvm.org/viewvc/llvm-project?rev=296937&view=rev
Log:
[scan-build-py] create decorator for compiler wrapper methods
Differential Revision: https://reviews.llvm.org/D29260
Modified:
cfe/trunk/tools/scan-build-py/
Author: ericwf
Date: Fri Mar 3 19:02:35 2017
New Revision: 296936
URL: http://llvm.org/viewvc/llvm-project?rev=296936&view=rev
Log:
Turn on -Wunused-function and cleanup occurances
Modified:
libcxxabi/trunk/CMakeLists.txt
libcxxabi/trunk/cmake/config-ix.cmake
libcxxabi/trunk/src/cxa_
EricWF created this revision.
This is my attempt to improve the diagnostic messages emitted from the
unordered containers when the supplied hash doesn't meet the `Hash`
requirements.
Unfortunately producing reasonable diagnostics is tricky and it requires a
bunch of meta-programming to get rig
Author: rtrieu
Date: Fri Mar 3 18:08:58 2017
New Revision: 296932
URL: http://llvm.org/viewvc/llvm-project?rev=296932&view=rev
Log:
[ODRHash] Add support for detecting different method properties.
Now print diagnostics for static, virtual, inline, volatile, and const
differences in methods. Als
Author: pirama
Date: Fri Mar 3 17:48:15 2017
New Revision: 296929
URL: http://llvm.org/viewvc/llvm-project?rev=296929&view=rev
Log:
Restrict test arch-specific-libdir.c to Linux
Summary: This fails on Windows due to dependence on path separators.
Reviewers: rnk, srhines
Subscribers: llvm-commi
On Fri, Mar 3, 2017 at 4:01 PM, Nico Weber wrote:
> "the specified hash does not meet the Hash requirements" isn't a very
> actionable diagnostic.
>
True, For now I was only trying to out-diagnose template barf when I wrote
it initially. So in that regard it's a bit more actionable that it was,
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
This change is missing test cases.
https://reviews.llvm.org/D30592
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
pirama added a comment.
Committed. Thanks for the reviews!
Repository:
rL LLVM
https://reviews.llvm.org/D30015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296927: Add arch-specific directory to search path (authored
by pirama).
Changed prior to commit:
https://reviews.llvm.org/D30015?vs=90532&id=90545#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: pirama
Date: Fri Mar 3 17:20:49 2017
New Revision: 296927
URL: http://llvm.org/viewvc/llvm-project?rev=296927&view=rev
Log:
Add arch-specific directory to search path
Summary:
This change adds an arch-specific subdirectory in /lib/
to the linker search path. This path also gets added a
inglorion added a comment.
Checking for linux when really you want to check for ELF doesn't seem right. In
this case, I think there is an better way to do it; instead of relying on
llvm-objdump, could you emit an LLVM assembly file and check that for presence
of the string you want? I think if
thakis added a comment.
http://llvm-cs.pcc.me.uk/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h/risInSystemHeader
suggests that the analyzer has some plumbing for this, so I added dcoughlin as
reviewer, who has touched some of those lines before. dcoughlin, as background
kmarshall created this revision.
The Clang static analyzer doesn't follow the warning suppression semantics of
the "-isystem" command line flag. This patch adds a check to BugReporter which
causes it to drop any BugReports which originated from a system header
(descendant of an -isystem path).
kmarshall added a comment.
Note to reviewers: this diff is relative to "llvm/cfe" - I couldn't find a way
to specify a repository subpath to use for this diff.
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
cfe
"the specified hash does not meet the Hash requirements" isn't a very
actionable diagnostic. Is it possible to use some warning text that lets
people know what they need to do to make the compiler happy, instead of
just telling them that the compiler is unhappy?
On Fri, Mar 3, 2017 at 5:35 PM, Eri
Author: ericwf
Date: Fri Mar 3 16:47:45 2017
New Revision: 296922
URL: http://llvm.org/viewvc/llvm-project?rev=296922&view=rev
Log:
Remove the buildit and testit scripts; they haven't been supported in years
Removed:
libcxx/trunk/lib/buildit
libcxx/trunk/test/testit
Removed: libcxx/trun
NoQ added a comment.
In https://reviews.llvm.org/D30489#691475, @danielmarjamaki wrote:
> Do you agree that this is the problem? Would it be a good idea to try to keep
> the sz in the ProgramState?
Environment stores values only temporarily. It's kind of a scratch pad for
temporary symbolic c
Author: ericwf
Date: Fri Mar 3 16:35:58 2017
New Revision: 296919
URL: http://llvm.org/viewvc/llvm-project?rev=296919&view=rev
Log:
Fix hash requirements check in __hash_table.
r296565 attempted to add better diagnostics when an unordered container
is instantiated with a hash that doesn't meet t
NoQ added a comment.
The code looks good to me, but i'm expressing a tiny doubt: regardless of the
output format, the user always has the relevant argument highlighted anyway
(column number, tilde-underlined in command line, blue-ish box in scan-build,
etc.), so the only significant clarificati
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks! This bugged me as well, but i didn't think of this trick :)
https://reviews.llvm.org/D30589
___
cfe-commits mailing list
cfe-commits@lists.llvm
pirama marked an inline comment as done.
pirama added inline comments.
Comment at: lib/Driver/Tools.cpp:2007-2009
+ // In the cross-compilation case, arch-specific library path is likely
+ // unavailable at runtime.
+ if (TC.isCrossCompiling()) return;
rnk wro
mehdi_amini added a comment.
In https://reviews.llvm.org/D30239#691972, @rnk wrote:
> Do you guys think that maybe -flto should imply -fuse-ld=lld, or is that too
> much magic?
I don't know enough about windows, but I would think it may be surprising for a
user that -flto changes the linker b
pirama updated this revision to Diff 90532.
pirama edited the summary of this revision.
pirama added a comment.
Fixed comment in test and added a test for -fsanitize=address without
-shared-libasan.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChai
fgross created this revision.
Herald added a subscriber: JDevlieghere.
catch (std::exception ex)
{
}
Was flagged with "catch handler catches a pointer value".
https://reviews.llvm.org/D30592
Files:
clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
Index: clang-tidy/misc/ThrowByVa
rnk added a comment.
Do you guys think that maybe -flto should imply -fuse-ld=lld, or is that too
much magic?
Repository:
rL LLVM
https://reviews.llvm.org/D30239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
rnk accepted this revision.
rnk added a comment.
Looks good with a minor comment about a comment in the test case.
Comment at: lib/Driver/Tools.cpp:2007-2009
+ // In the cross-compilation case, arch-specific library path is likely
+ // unavailable at runtime.
+ if (TC.isCros
twoh created this revision.
This feature is needed to re-enable https://reviews.llvm.org/rL293004, which
resembles gcc's behavior in
finding the input file name from a preprocessed source. The patch has been
reverted in https://reviews.llvm.org/rL293032, because the test checks FILE
symbol of EL
lethalantidote added a comment.
Is there any subgroup that one could suggest for this warning to fall under?
https://reviews.llvm.org/D28543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rnk created this revision.
Because of the existence branches out of GNU statement expressions, it
is possible that emitting cleanups for a full expression may cause the
new insertion point to not be dominated by the result of the inner
expression. Consider this example:
struct Foo { Foo(); ~Foo
loladiro created this revision.
Some of the magic functions take arguments of arbitrary type. However,
for semantic correctness, the compiler still requires a declaration
of these functions with the correct type. Since C does not have
argument-type-overloaded function, this made those functions ha
smeenai updated this revision to Diff 90524.
smeenai added a comment.
Address comments
https://reviews.llvm.org/D27387
Files:
include/__config
include/functional
lib/CMakeLists.txt
src/functional.cpp
Index: src/functional.cpp
===
Does that mean there is a bug in libcxx that should be documented somewhere?
-- adrian
> On Mar 2, 2017, at 3:18 PM, Eric Fiselier via cfe-commits
> wrote:
>
> Author: ericwf
> Date: Thu Mar 2 17:18:40 2017
> New Revision: 296840
>
> URL: http://llvm.org/viewvc/llvm-project?rev=296840&view=re
yaxunl updated this revision to Diff 90520.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
remove redundant code.
make mov_dpp target builtin.
https://reviews.llvm.org/D30551
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
dcoughlin added a comment.
@zaks.anna: What do you think? Should we try to get this into clang 4.0?
Repository:
rL LLVM
https://reviews.llvm.org/D30565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks. looks good.
https://reviews.llvm.org/D28297
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: mehdi_amini
Date: Fri Mar 3 11:24:29 2017
New Revision: 296889
URL: http://llvm.org/viewvc/llvm-project?rev=296889&view=rev
Log:
Fix libc++ test to pass in C++03 mode
Was hitting: "error: scalar initializer cannot be empty"
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdio_h
Author: prazek
Date: Fri Mar 3 11:16:11 2017
New Revision: 296888
URL: http://llvm.org/viewvc/llvm-project?rev=296888&view=rev
Log:
[clang-tidy] Yet another docs fixes
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/trunk/docs/
a.sidorin added a comment.
Thank you Devin. Should we submit this to 4.0? I guess there are not many users
of both CSA and OpenMP but PR you pointed is already the second report about
this issue I see.
Repository:
rL LLVM
https://reviews.llvm.org/D30565
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296884: [Analyzer] Terminate analysis on OpenMP code instead
of assertion crash (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D30565?vs=90441&id=90499#toc
Repository:
rL
Author: a.sidorin
Date: Fri Mar 3 10:58:53 2017
New Revision: 296884
URL: http://llvm.org/viewvc/llvm-project?rev=296884&view=rev
Log:
[Analyzer] Terminate analysis on OpenMP code instead of assertion crash
* ExprEngine assumes that OpenMP statements should never appear in CFG.
However, curren
john.brawn created this revision.
The way -ffast-math and the various related options to tweak floating-point
handling are handled is inflexible and rather confusing. This patch
restructures things so that we go through the options adjusting our idea of
what's enabled as we go, instead of tryin
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Thanks for fixing this! It looks like this is tracked by PR31835.
https://bugs.llvm.org//show_bug.cgi?id=31835
https://reviews.llvm.org/D30565
___
dcoughlin added a comment.
Looks great. Thanks!!
https://reviews.llvm.org/D30373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sylvestre.ledru updated this revision to Diff 90486.
sylvestre.ledru added a comment.
updated => affected
+ align the vs
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
=
gerazo marked an inline comment as done.
gerazo added a comment.
Hmm... I am thinking on this issue for a week now...
I've played with the idea of implementing cleansing rules in
GenericTaintChecker. It would be elegant but unfortunately, I have to think
they are not general. Cleansing of a str
krasimir abandoned this revision.
krasimir added a comment.
This patch is superseded by https://reviews.llvm.org/D30575.
https://reviews.llvm.org/D30492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
sylvestre.ledru updated this revision to Diff 90482.
sylvestre.ledru added a comment.
With the changes requested by Daniel. This is much better indeed!
https://reviews.llvm.org/D30532
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
Index: include/clang/Format/Format.h
Abpostelnicu updated this revision to Diff 90480.
Abpostelnicu added a comment.
corrected some format issues.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Forma
Abpostelnicu updated this revision to Diff 90475.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.c
arphaman updated this revision to Diff 90473.
arphaman marked 3 inline comments as done.
arphaman added a comment.
The updated diff:
- Warns for vector types.
- Addresses Akira's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D30174
Files:
include/clang/Basic/DiagnosticSemaKinds.t
arphaman marked 3 inline comments as done.
arphaman added inline comments.
Comment at: lib/AST/DeclObjC.cpp:987
unsigned noParams = param_size();
if (noParams < 1 || noParams > 3)
family = OMF_None;
ahatanak wrote:
> It seems like this code
danielmarjamaki updated this revision to Diff 90471.
danielmarjamaki added a comment.
Fix review comment
Repository:
rL LLVM
https://reviews.llvm.org/D30341
Files:
lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp
test/Analysis/NewDelete-checker-test.cpp
test/Analysis/diagnostics/u
alexfh added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred h
xazax.hun added a comment.
In the meantime CheckBeginFunction has been implemented separately. I think you
should "abandon" this revision so it is shown as closed.
https://reviews.llvm.org/D15090
___
cfe-commits mailing list
cfe-commits@lists.llvm.
mboehme marked an inline comment as done.
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MES
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691535, @djasper wrote:
> Hm. Unfortunately, this seems to have been implemented to support Webkit
> style and Webkit style is explicit about wanting this
> (https://webkit.org/code-style-guidelines/) :(.
>
> But maybe the solutio
alexfh added a comment.
What's the practical use of newlines and tab characters in the glob list?
https://reviews.llvm.org/D30567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]
On 3 March 2017 at 12:42, Piotr Padlewski via cfe-commits
wrote:
> w.emplace_back(std::make_pair(21L, 37L);
Unbalanced ().
--
Malcolm Parsons
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
djasper added a comment.
Hm. Unfortunately, this seems to have been implemented to support Webkit style
and Webkit style is explicit about wanting this
(https://webkit.org/code-style-guidelines/) :(.
But maybe the solution to that is to add an extra flag like
AlwaysWrapInitializerList. Really
mboehme marked an inline comment as done.
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MES
mboehme added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred
mboehme created this revision.
Herald added a subscriber: JDevlieghere.
I've added a test case that (without the fix) triggers the assertion,
which happens when a move happens in an implicitly called conversion
operator.
https://reviews.llvm.org/D30569
Files:
clang-tidy/misc/UseAfterMoveCheck
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691517, @djasper wrote:
> Do you know whether that is intentional? The style guide isn't really
> conclusive.
Well i'm not sure, because as you said the document is not clear but i think
that when we have a single initialiser it
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2486
Style.BreakConstructorInitializersBeforeComma &&
!Style.ConstructorInitializerAllOnOneLineOrOnePerLine)
At any rate, I think this is what makes single-item ctor init lists
djasper added a comment.
Do you know whether that is intentional? The style guide isn't really
conclusive.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: prazek
Date: Fri Mar 3 06:42:22 2017
New Revision: 296867
URL: http://llvm.org/viewvc/llvm-project?rev=296867&view=rev
Log:
[clang-tidy] Fix modernize-use-emplace docs
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-use-emplace.rst
Modified:
clang-tools-extra/tru
a.sidorin added a comment.
`git blame` shows that OMP* statements were added to the switch block by
different authors while OpenMP support in clang was implemented. Looks like
they were put to "Should not appear" section instead of "Unsupported" by
mistake.
https://reviews.llvm.org/D30565
Abpostelnicu added a comment.
In https://reviews.llvm.org/D30487#691506, @djasper wrote:
> Before `'`? Can you give an example?
MY mistake, i wanted to write ``:`
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
djasper added a comment.
Before `'`? Can you give an example?
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Abpostelnicu added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2400
+// Returns 'true' if there is an TT_InheritanceComma in the current token list.
+static bool hasMultipleInheritance(const FormatToken &Tok) {
+ for (const FormatToken* nextTok = Tok.Next; nextTok
krasimir added a comment.
I also think that examples for the flags are good. My use case is that while
developing/debugging its nice to see a short example for a random flag in the
documentation pop-up.
https://reviews.llvm.org/D30532
___
cfe-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296864: [clang-tidy] Format code around applied fixes
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30564?vs=90452&id=90453#toc
Repository:
rL LLVM
https://reviews.llvm.or
danielmarjamaki added a comment.
To me it seems that the extent is calculated properly in ArrayBoundsV2.
Existing code:
DefinedOrUnknownSVal extentVal =
rawOffset.getRegion()->getExtent(svalBuilder);
This ugly little debug code will extract the needed VLA information from the
extentVal..
Author: alexfh
Date: Fri Mar 3 05:16:34 2017
New Revision: 296864
URL: http://llvm.org/viewvc/llvm-project?rev=296864&view=rev
Log:
[clang-tidy] Format code around applied fixes
Summary:
Add -format option (disabled by default for now) to trigger formatting
of replacements.
Reviewers: ioeric
R
alexfh updated this revision to Diff 90452.
alexfh added a comment.
Apply changes even when formatting fails.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code
ioeric added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:214
+ llvm::errs() << llvm::toString(Replacements.takeError()) << "\n";
+ continue;
+}
Maybe still apply the replacements if formatting fails?
https://reviews.llvm.org/
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
malcolm.parsons added a comment.
LGTM.
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
PTAL
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 126 matches
Mail list logo
