dlj added a comment.
In https://reviews.llvm.org/D30372#686871, @ahatanak wrote:
> Have you considered using "include_directories" in CMakeLists.txt to avoid
> including "../Something.h"?
I don't want to take that approach, and there's a specific reason why: my
concern isn't with three extra
sepavloff created this revision.
A function declared in a friend declaration may have declarations prior
to the containing class definition. If such declaration defines default
argument, the friend function declaration inherits them. This behavior
causes problems if the class where the friend is d
yaxunl updated this revision to Diff 89834.
yaxunl retitled this revision from "Allow target to specify default address
space for codegen" to "[WIP] Specify default address space for C++ on AMDGPU
Target".
yaxunl added a comment.
Herald added subscribers: tpr, dstuttard, kzhuravl.
Synch up to tr
ddcc reopened this revision.
ddcc added a comment.
This revision is now accepted and ready to land.
Looks like there were four latent test failures that had been masked due to the
way they were written. Here's the new version.
Repository:
rL LLVM
https://reviews.llvm.org/D30373
__
Author: akirtzidis
Date: Sun Feb 26 21:52:36 2017
New Revision: 296320
URL: http://llvm.org/viewvc/llvm-project?rev=296320&view=rev
Log:
[GeneratePCHAction] If preprocessor option 'AllowPCHWithCompilerErrors' is
enabled, don't delete the produced PCH file if error diagnostics occurred.
Modified:
dberris updated this revision to Diff 89830.
dberris added a comment.
- fixup: undo clang-format on ASTContext.h
- fixup: undo clang-formatting whole file
- fixup: undo clang-format on file
https://reviews.llvm.org/D30388
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/LangOptions
dberris planned changes to this revision.
dberris added a comment.
Need to undo some unnecessary formatting changes..
https://reviews.llvm.org/D30388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
dberris created this revision.
Herald added subscribers: mgorny, jfb.
The -fxray-always-instrument= and -fxray-never-instrument= flags take
filenames that are used to imbue the XRay instrumentation attributes
using a whitelist mechanism (similar to the sanitizer special cases
list). We use the sam
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D30373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: akirtzidis
Date: Sun Feb 26 20:06:18 2017
New Revision: 296306
URL: http://llvm.org/viewvc/llvm-project?rev=296306&view=rev
Log:
Add a cc1 flag for setting the existing Preprocessor option
'AllowPCHWithCompilerErrors'.
Modified:
cfe/trunk/include/clang/Driver/CC1Options.td
cfe/tr
xiangzhai updated this revision to Diff 89825.
xiangzhai added a comment.
Hi Anna,
Thanks for your review!
I updated the Glib-MallocChecker-single-size-value.patch to use **zeroVal** for
**g_malloc0** and **g_try_malloc0**
and Yes, I refer CallocMem to implement **SValBinMulOp** in the
Glib-M
thakis added a comment.
(related, and why i picked rnk as reviewer:
https://bugs.llvm.org/show_bug.cgi?id=17216
https://bugs.llvm.org/show_bug.cgi?id=17960)
https://reviews.llvm.org/D30385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
thakis created this revision.
Herald added a subscriber: klimek.
Second attempt after http://llvm.org/viewvc/llvm-project?rev=296166&view=rev
In the first attempt, `Code` (the memory buffer backing the input file) was
reset before `overwriteChangedFiles()` was called, but
`overwriteChangedFiles
thakis added a comment.
samsonov: ping
https://reviews.llvm.org/D27455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
madsravn updated this revision to Diff 89817.
madsravn marked an inline comment as done.
madsravn added a comment.
Made small changes based on comments.
https://reviews.llvm.org/D30158
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/moder
ahatanak added a comment.
Have you considered using "include_directories" in CMakeLists.txt to avoid
including "../Something.h"?
https://reviews.llvm.org/D30372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Doesn't Intel's own documentation say these are in pmmintrin.h? gcc has
them there as well.
https://software.intel.com/en-us/node/683881
~Craig
On Sun, Feb 26, 2017 at 3:58 AM, Oren Ben Simhon via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: orenb
> Date: Sun Feb 26 05:58:15 2017
Author: orenb
Date: Sun Feb 26 05:58:15 2017
New Revision: 296296
URL: http://llvm.org/viewvc/llvm-project?rev=296296&view=rev
Log:
[X86] DAZ Macros Relocation
The DAZ feature introduces the denormal zero support for x86.
Currently the definitions are located under SSE3 header, however there are
amaiorano updated this revision to Diff 89815.
amaiorano added a comment.
Made changes based on @hans 's feedback.
I looked again at the categories, and I think it makes sense with my changes.
Here's an updated screenshot that shows what the options menu in Visual Studio
looks like with these c
19 matches
Mail list logo
