Author: gbiv
Date: Wed Feb 22 23:59:56 2017
New Revision: 295935
URL: http://llvm.org/viewvc/llvm-project?rev=295935&view=rev
Log:
[CodeGen] Don't reemit expressions for pass_object_size params.
This fixes an assertion failure in cases where we had expression
statements that declared variables ne
Author: akirtzidis
Date: Wed Feb 22 23:51:47 2017
New Revision: 295934
URL: http://llvm.org/viewvc/llvm-project?rev=295934&view=rev
Log:
[c-index-test] For the 'core' invocation, avoid running it under a new thread.
It's unnecessary.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Mod
vlad.tsyrklevich updated this revision to Diff 89467.
vlad.tsyrklevich added a comment.
@NoQ I've tried to address all the issues you mentioned in this change. Let me
know if the expanded documentation doesn't address what you were looking for.
https://reviews.llvm.org/D28445
Files:
include/
Yes, approved
Best regards,
Alexey Bataev
> 23 февр. 2017 г., в 1:00, Hans Wennborg написал(а):
>
> Alexey: ping?
>
>> On Tue, Feb 21, 2017 at 11:07 AM, Hans Wennborg wrote:
>> I'm Ok with it if Alexey approves.
>>
>> On Fri, Feb 17, 2017 at 10:52 AM, Hahnfeld, Jonas
>> wrote:
>>> Hi Hans,
bmharper updated this revision to Diff 89463.
bmharper added a comment.
Fixed two small issues raised by @daphnediane
https://reviews.llvm.org/D21279
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.
Author: rtrieu
Date: Wed Feb 22 21:25:57 2017
New Revision: 295931
URL: http://llvm.org/viewvc/llvm-project?rev=295931&view=rev
Log:
[ODRHash] Handle types in ODR hashing.
Fields will now have their types added to the hash, allowing for detection of
mismatched field types. This detection allows
xiangzhai updated this revision to Diff 89460.
xiangzhai added a comment.
Hi Anna,
Thanks for your suggest!
Firstly I uploaded Glib-MallocChecker-single-size-value.patch for code review,
if submitted to UPSTREAM, then upload another one, correct?
Regards,
Leslie Zhai
Repository:
rL LLVM
h
vsk created this revision.
If a pointer is 1-byte aligned, there's no use in checking its
alignment. Somewhat surprisingly, ubsan can spend a significant amount
of time doing just that!
This loosely depends on https://reviews.llvm.org/D30283.
Testing: check-clang, check-ubsan, and a stage2 ubsan
Author: rsmith
Date: Wed Feb 22 20:09:03 2017
New Revision: 295921
URL: http://llvm.org/viewvc/llvm-project?rev=295921&view=rev
Log:
Fix tracking of whether the previous template instantiation stack matches the
current one.
Rather than attempting to compare whether the previous and current top o
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
One point to note, when we are displaying coverage for constructors that have
both the base and complete versions instrumented, e.g.:
class Foo {
public:
Foo() { }
};
Author: awatry
Date: Wed Feb 22 19:46:57 2017
New Revision: 295920
URL: http://llvm.org/viewvc/llvm-project?rev=295920&view=rev
Log:
math: Add native_tan as wrapper to tan
Trivially define native_tan as a redirect to tan.
If there are any targets with a native implementation, we can deal with it
Author: rsmith
Date: Wed Feb 22 19:43:54 2017
New Revision: 295919
URL: http://llvm.org/viewvc/llvm-project?rev=295919&view=rev
Log:
Rename ActiveTemplateInstantiation to CodeSynthesisContext in preparation for
using it for other kinds of context (where we currently produce context notes
in a high
vsk created this revision.
This patch teaches ubsan to insert an alignment check for the 'this'
pointer at the start of each method/lambda. This allows clang to emit
significantly fewer alignment checks overall, because if 'this' is
aligned, so are its fields.
This is essentially the same thing r
Author: vedantk
Date: Wed Feb 22 19:22:38 2017
New Revision: 295918
URL: http://llvm.org/viewvc/llvm-project?rev=295918&view=rev
Log:
Rename a helper function, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
cfe/trunk/lib/CodeGen/CGExprCXX.cpp
cfe/trunk/lib/CodeGen/CodeGenFunction.h
Author: rtrieu
Date: Wed Feb 22 18:23:01 2017
New Revision: 295911
URL: http://llvm.org/viewvc/llvm-project?rev=295911&view=rev
Log:
[ODRHash] Add IdentiferInfo and FieldDecl support.
IdentifierInfo is hashed based on the stored string. FieldDecl versus other
Decl is now detected, as well as dif
vsk added a comment.
Ping, is the argument in favor of making the change in my last comment
satisfactory?
https://reviews.llvm.org/D29369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: arphaman
Date: Wed Feb 22 17:18:49 2017
New Revision: 295903
URL: http://llvm.org/viewvc/llvm-project?rev=295903&view=rev
Log:
[ObjC][Modules] Don't perform property lookup in hidden class extensions
rdar://30603803
Modified:
cfe/trunk/lib/AST/DeclObjC.cpp
cfe/trunk/test/Modules/
Author: gbiv
Date: Wed Feb 22 16:38:25 2017
New Revision: 295894
URL: http://llvm.org/viewvc/llvm-project?rev=295894&view=rev
Log:
[CodeGen] Add param info for ctors with ABI args.
This fixes a few assertion failures. Please see the added test case.
Added:
cfe/trunk/test/CodeGenObjCXX/arc-at
sbenza added inline comments.
Comment at: lib/Tooling/RefactoringCallbacks.cpp:213
+llvm::errs() << "Node " << Element.Value
+ << " used in replacement template not bound in Matcher
\n";
+llvm_unreachable("Unbound node in replacement template.
zaks.anna added a comment.
Could you please split the patch into two - one with the previously reviewed
support for functions that take a single size value and another patch that
models the two size arguments (num and size). It's easier to review patches if
they do not grow new functionality. S
Author: rtrieu
Date: Wed Feb 22 16:22:42 2017
New Revision: 295890
URL: http://llvm.org/viewvc/llvm-project?rev=295890&view=rev
Log:
[ODRHash] static_cast and Stmt hashing.
Add support for static_cast in classes. Add pointer-independent profiling for
Stmt's, sharing most of the logic with Stmt::
jbangert accepted this revision.
jbangert added a comment.
Thanks, added tests for parser failures.
https://reviews.llvm.org/D29621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbangert updated this revision to Diff 89420.
jbangert marked an inline comment as done.
jbangert added a comment.
- additional tests
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallb
Author: rsmith
Date: Wed Feb 22 16:09:50 2017
New Revision: 295886
URL: http://llvm.org/viewvc/llvm-project?rev=295886&view=rev
Log:
PR32034: Evaluate _Atomic(T) in-place when T is a class or array type.
This is necessary in order for the evaluation of an _Atomic initializer for
those types to ha
Alexey: ping?
On Tue, Feb 21, 2017 at 11:07 AM, Hans Wennborg wrote:
> I'm Ok with it if Alexey approves.
>
> On Fri, Feb 17, 2017 at 10:52 AM, Hahnfeld, Jonas
> wrote:
>> Hi Hans, Alexey,
>>
>> can we merge this commit and r295474 for the 4.0 release or is it already
>> too late for that? I wil
Author: arsenm
Date: Wed Feb 22 14:55:59 2017
New Revision: 295874
URL: http://llvm.org/viewvc/llvm-project?rev=295874&view=rev
Log:
AMDGPU: Add fmed3 half builtin
Added:
cfe/trunk/test/CodeGenOpenCL/builtins-amdgcn-gfx9.cl
cfe/trunk/test/SemaOpenCL/builtins-amdgcn-error-gfx9.cl
Modified:
arsenm closed this revision.
arsenm added a comment.
r295874
https://reviews.llvm.org/D30241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya added a comment.
Thank you for the feedback. This was supposed to be first out of two patches. I
have posted the next patch here: https://reviews.llvm.org/D30268 which aims to
remove copy of __src array each time a number is parsed. I can abandon this
patch if we don't need to separat
hiraditya created this revision.
The function __num_get<_CharT>::__stage2_int_prep makes unnecessary copy of
__src into __atoms when char_type is char. This can be avoided by creating
a switch on type and just returning __src when char_type is char. Running a
synthetic benchmark shows the impact
Author: inglorion
Date: Wed Feb 22 14:29:39 2017
New Revision: 295872
URL: http://llvm.org/viewvc/llvm-project?rev=295872&view=rev
Log:
stop using associative comdats for SEH filter functions
Summary: We implement structured exception handling (SEH) by generating filter
functions for functions t
Author: gbiv
Date: Wed Feb 22 14:28:02 2017
New Revision: 295870
URL: http://llvm.org/viewvc/llvm-project?rev=295870&view=rev
Log:
[CodeGen] Note where we add ABI-specific args in ctors. NFC.
Meta: The ultimate goal is to teach ExtParameterInfo about
pass_object_size attributes. This is necessary
erik.pilkington added inline comments.
Comment at: test/CodeGenObjC/availability-check.m:16
+ // CHECK: br i1 true
+ if (__builtin_available(ios 10, *))
+;
arphaman wrote:
> Shouldn't this be `br i1 false`, since we are building for macOS so we have
> no i
Author: rsmith
Date: Wed Feb 22 14:01:55 2017
New Revision: 295866
URL: http://llvm.org/viewvc/llvm-project?rev=295866&view=rev
Log:
Improve support for 'decltype(auto)' in template template parameter matching.
A 'decltype(auto)' parameter can match any other kind of non-type template
parameter,
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D30238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
mcgrathr updated this revision to Diff 89393.
mcgrathr added a comment.
Added test case.
Repository:
rL LLVM
https://reviews.llvm.org/D30238
Files:
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/fuchsia.c
Index: test/Driver/fuchsia.c
===
hans added a comment.
In https://reviews.llvm.org/D30239#683697, @inglorion wrote:
> @mehdi_amini:
>
> > Is clang-cl using lld as default? How is the switch done? Ideally we should
> > have a nice error message from the driver if -flto is used without lld.
>
> I believe we use link.exe by defaul
On Tue, Feb 14, 2017 at 4:21 PM Mehdi AMINI via Phabricator via cfe-commits
wrote:
> mehdi_amini added a comment.
>
> In https://reviews.llvm.org/D13330#582607, @rsmith wrote:
>
> > I think this attribute is poorly named. Explicit instantiation
> definitions are *already* required to be globally
arphaman added a comment.
It seems that unresolved member expressions have other lookup issues. For
example, this will crash when code-completing as well:
struct Foo {
void foo() const;
static void foo(bool);
};
struct Bar: Foo {
void foo(bool param) {
this->Foo::foo(/*CC
Adding const to pointed/referenced types doesn't usually help the compiler,
since they don't guarantee that the underlying object is const (nor that
any use can't involve const_casting away the constness and mutating the
value anyway).
On Fri, Feb 17, 2017 at 2:34 PM Aditya Kumar via Phabricator v
inglorion added a comment.
@mehdi_amini:
> Is clang-cl using lld as default? How is the switch done? Ideally we should
> have a nice error message from the driver if -flto is used without lld.
I believe we use link.exe by default. You can use lld by passing -fuse-ld=lld
to the compiler.
I can
arphaman added inline comments.
Comment at: test/CodeGenObjC/availability-check.m:16
+ // CHECK: br i1 true
+ if (__builtin_available(ios 10, *))
+;
Shouldn't this be `br i1 false`, since we are building for macOS so we have no
iOS support at all?
https:
I'm OK with it if either Matt or Anastasia agrees.
Thanks,
Hans
On Wed, Feb 22, 2017 at 7:20 AM, Jan Vesely wrote:
> Hi Hans,
>
> I'd like this commit to make it to 4.0. I'm not sure if it falls under
> OpenCL or AMDGPU so I've added both Matt and Anastasia to cc.
>
> thank you,
> Jan
>
> On Wed
v.g.vassilev abandoned this revision.
v.g.vassilev added a comment.
Thanks for following this up. I will close it.
https://reviews.llvm.org/D25604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D30241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
sammccall updated this revision to Diff 89366.
sammccall added a comment.
git-clang-format
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMemorySymbolIndex.h
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndex.h
include-fixer/SymbolIn
teemperor added a comment.
I just tested this on Mageia and this patch is superseded by now (it was
originally written in 2013). The latest clang release is already able to
correctly handle Mageia.
(Also there is anyway comma missing at the end of each line)
https://reviews.llvm.org/D25604
sammccall updated this revision to Diff 89365.
sammccall added a comment.
Switch from SymbolInfo::WithSignals as a typedef for std::pair, to a struct
SymbolAndSignals, to have clearer semantics.
https://reviews.llvm.org/D30210
Files:
include-fixer/InMemorySymbolIndex.cpp
include-fixer/InMem
sammccall updated this revision to Diff 89360.
sammccall added a comment.
Changes based on offline discussion:
- mutable SignalInfo data split into SignalInfo::Signals
- yaml serialized data is SignalInfo::WithSignals, which is currently a
pair
- FindAllSymbols/FindAllMacros now report in batche
Hi Hans,
I'd like this commit to make it to 4.0. I'm not sure if it falls under
OpenCL or AMDGPU so I've added both Matt and Anastasia to cc.
thank you,
Jan
On Wed, 2017-02-22 at 15:01 +, Jan Vesely via cfe-commits wrote:
> Author: jvesely
> Date: Wed Feb 22 09:01:42 2017
> New Revision: 295
Author: jvesely
Date: Wed Feb 22 09:01:42 2017
New Revision: 295843
URL: http://llvm.org/viewvc/llvm-project?rev=295843&view=rev
Log:
[OpenCL] r600 needs OpenCL kernel calling convention
Differential Revision: https://reviews.llvm.org/D30236
Modified:
cfe/trunk/lib/Sema/SemaType.cpp
cfe/
Author: yrnkrn
Date: Wed Feb 22 08:32:39 2017
New Revision: 295839
URL: http://llvm.org/viewvc/llvm-project?rev=295839&view=rev
Log:
Remove superfluous initializer.
The following fully-covered switch either sets value to External or exits the
function.
Modified:
cfe/trunk/lib/AST/ASTContex
Author: rksimon
Date: Wed Feb 22 07:21:24 2017
New Revision: 295829
URL: http://llvm.org/viewvc/llvm-project?rev=295829&view=rev
Log:
Fix 'control reaches end of non-void function' warning
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
Author: rksimon
Date: Wed Feb 22 07:19:24 2017
New Revision: 295828
URL: http://llvm.org/viewvc/llvm-project?rev=295828&view=rev
Log:
Fix -Wunused-private-field warning by removing unused ODRHash reference field
from ODRDeclVisitor
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
Modified: cfe/trunk
Dear all,
This patch adds the '-target' option to the clang option to invoke to
check the syntax when scan-build is called with the --analyzer-target
option.
I'm using scan-build in cross compile project. (target: armv7-a)
Even when cross compiling, scan-build invokes clang with -triple (HOST
AR
erikjv created this revision.
If there is an unresolved member access AST node, and the base is
implicit, do not access/use it for generating candidate overloads for
code completion results (because the base is a nullptr).
Fixes PR31093.
https://reviews.llvm.org/D30248
Files:
lib/Sema/SemaCo
Author: d0k
Date: Wed Feb 22 04:19:45 2017
New Revision: 295820
URL: http://llvm.org/viewvc/llvm-project?rev=295820&view=rev
Log:
[ODRHash] Avoid dereferencing end() of a SmallVector.
Found by MSAN.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/AS
sammccall planned changes to this revision.
sammccall added a comment.
OK, some changes to come here:
- klimek thinks using a set as a pseudo-map with `mutable` is evil, which is a
fair point
- the current `SymbolReporter` interface doesn't provide enough information to
deduplicate efficiently,
klimek added inline comments.
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:251
+ } else {
+assert(false && "Must match a NamedDecl!");
+ }
You can use llvm_unreachable instead. Or do you actually want to fall through
in release mode?
==
sammccall added a comment.
Thanks for the review, still learning the style :)
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:250
+ } else {
+assert(!"Must match a NamedDecl!");
+ }
hokein wrote:
> Is the preceding `!` intended?
This does th
sammccall updated this revision to Diff 89337.
sammccall marked 7 inline comments as done.
sammccall added a comment.
Address review comments.
https://reviews.llvm.org/D30210
Files:
include-fixer/IncludeFixer.cpp
include-fixer/SymbolIndexManager.cpp
include-fixer/find-all-symbols/FindAllS
Author: klimek
Date: Wed Feb 22 03:21:22 2017
New Revision: 295818
URL: http://llvm.org/viewvc/llvm-project?rev=295818&view=rev
Log:
Completion related fixes for clang-include-fixer.el.
1. Quitting inside a process sentinel is not allowed, but the sentinel invokes
completion, where the user is fr
xiangzhai updated this revision to Diff 89333.
xiangzhai added a comment.
Fixed the confused
State->getSVal(CE->getArg(1), C.getLocationContext());
with
CE->getArg(1)
issue.
Repository:
rL LLVM
https://reviews.llvm.org/D28348
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
t
hokein added a comment.
Thanks for the contributions!
Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:244
- const auto *ND = Result.Nodes.getNodeAs("decl");
- assert(ND && "Matched declaration must be a NamedDecl!");
+ auto report = &SymbolReporter::reportSym
xiangzhai updated this revision to Diff 89331.
xiangzhai added a comment.
Hi Anna,
I added **svalBinMulOp** to take BO_Mul evalBinOp for g_malloc_n's two
arguments: CE->getArg(0) and CE->getArg(1), so it does **NOT** need to change
**MallocMemAux** any more, but just use it in this way:
Sta
Author: klimek
Date: Wed Feb 22 02:26:04 2017
New Revision: 295814
URL: http://llvm.org/viewvc/llvm-project?rev=295814&view=rev
Log:
Adds a hook clang-include-fixer-add-include-hook that is invoked with the path
and type of the added include.
This patch also adds a new function clang-include-fix
65 matches
Mail list logo
