Author: kromanova
Date: Wed Feb 1 01:37:40 2017
New Revision: 293745
URL: http://llvm.org/viewvc/llvm-project?rev=293745&view=rev
Log:
Doxygen comments for prfchwintrin.h
Added doxygen comments to prfchwintrin.h's intrinsics.
Note: The doxygen comments are automatically generated based on Sony
vsk created this revision.
C requires the operands of arithmetic expressions to be promoted if
their types are smaller than an int. Ubsan emits overflow checks when
this sort of type promotion occurs, even if there is no way to actually
get an overflow with the promoted type.
This patch teaches c
Author: rsmith
Date: Tue Jan 31 21:28:59 2017
New Revision: 293740
URL: http://llvm.org/viewvc/llvm-project?rev=293740&view=rev
Log:
Remove apparently-unnecessary copy of constructor lookup result.
Contrary to the comment, DeclContext intends to guarantee that the lookup
results for a particular
Fixed!
From: Saleem Abdulrasool
Date: Tuesday, January 31, 2017 at 6:53 PM
To: James Sun
Cc: Richard Smith , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowing
Hmm, the braces in the if (bases.find(...)...) are not needed.
Could you also a
I'm fine with these patches being merged. Hopefully we still have plenty of
time to shake out any problems between now and the release.
On 31 January 2017 at 19:09, George Burgess IV
wrote:
> > IIUC the major risk is that diagnose_if itself turns out to be broken,
> not that we'd miscompile anyt
> IIUC the major risk is that diagnose_if itself turns out to be broken,
not that we'd miscompile anything?
Correct. These patches should be NFC to code that doesn't use diagnose_if.
If something about that patch *had* to break existing non-diagnose_if-aware
code, we're now calling Sema::CheckFun
Author: hans
Date: Tue Jan 31 20:48:02 2017
New Revision: 293735
URL: http://llvm.org/viewvc/llvm-project?rev=293735&view=rev
Log:
Follow-up to r293732: add a proper triple to the test
Modified:
cfe/trunk/test/CodeGenCXX/initializer-list-ctor-order.cpp
Modified: cfe/trunk/test/CodeGenCXX/ini
Hmm, the braces in the if (bases.find(...)...) are not needed.
Could you also add a test case for virtual inheritance?
On Mon, Jan 30, 2017 at 8:34 PM, James Sun wrote:
> Hi Saleem
>
>
>
> Thanks for the quick response. A test case is added. It covers some
> ordinary cases as well as corner cas
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293732: clang-cl: Evaluate arguments left-to-right in
constructor call with initializer… (authored by hans).
Changed prior to commit:
https://reviews.llvm.org/D29350?vs=86496&id=86549#toc
Repository:
Author: hans
Date: Tue Jan 31 20:21:07 2017
New Revision: 293732
URL: http://llvm.org/viewvc/llvm-project?rev=293732&view=rev
Log:
clang-cl: Evaluate arguments left-to-right in constructor call with initializer
list (PR31831)
clang-cl would evaluate the arguments right-to-left (see PR), and for
I'm Ok with taking the larger patch (r293360 + r293369) too. It's been
in tree for a bit, there is still a number of weeks before the
release, and IIUC the major risk is that diagnose_if itself turns out
to be broken, not that we'd miscompile anything?
On Tue, Jan 31, 2017 at 11:11 AM, Richard Smi
hans added a comment.
In https://reviews.llvm.org/D29350#662525, @rnk wrote:
> Can you check if we got this wrong in clang 3.8 and 3.9? I'm wondering if
> this was a regression, or if we always got this wrong.
I tried back to 3.5, and it seems we just always got it wrong.
https://reviews.llv
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Can you check if we got this wrong in clang 3.8 and 3.9? I'm wondering if this
was a regression, or if we always got this wrong.
https://reviews.llvm.org/D29350
___
zaks.anna added a comment.
Before clang-tidy came into existence the guidelines were very clear. One
should write a clang warning if the diagnostic:
- can be implemented without path-insensitive analysis (including
flow-sensitive)
- is checking for language rules (not specific API misuse)
In m
gtbercea created this revision.
Herald added a subscriber: nemanjai.
When performing an offload, throw an error if the host tool chain uses the
altivec flag on an architecture other than PowerPC.
Repository:
rL LLVM
https://reviews.llvm.org/D29358
Files:
lib/Driver/Tools.cpp
test/OpenMP
Eugene.Zelenko added a comment.
> I think we need some sort of clear guidelines on where what functionality
> should be added. Even right now there are clang-tidy checks that finds subset
> of alpha checks, but probably having lower false positive rate. The other
> example is Use after move, th
Prazek added a comment.
In https://reviews.llvm.org/D29151#658484, @zaks.anna wrote:
> The static analyzer is definitely the place to go for bug detection that
> requires path sensitivity. It's also reasonably good for anything that needs
> flow-sensitivity. Although, most flow-sensitive analys
hamzasood updated this revision to Diff 86502.
hamzasood added a comment.
Added a FIXME comment about configuring use of the Setup Configuration API.
In its current form (RC3) the header is distributed in a nuget package, so it's
installed per-project instead of being in a system location that ca
On 31 January 2017 at 14:49, Hans Wennborg wrote:
> Richard, what do you think? I don't believe this fixes a 3.9
> regression, but the fix looks small, so it might be worth it.
>
I think on the whole the benefit of this change outweighs the risk of it
regressing something.
> On Tue, Jan 31, 20
Richard, what do you think? I don't believe this fixes a 3.9
regression, but the fix looks small, so it might be worth it.
On Tue, Jan 31, 2017 at 12:07 PM, Akira Hatanaka wrote:
> Thanks for the review. r293678.
>
> Should this be merged to 4.0?
>
>> On Jan 31, 2017, at 12:04 PM, Akira Hatanaka
r293702.
On Tue, Jan 31, 2017 at 11:12 AM, Richard Smith wrote:
> Sure, let's take this for Clang 4.
>
> On 31 January 2017 at 10:39, Hans Wennborg wrote:
>>
>> Ping?
>>
>> On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote:
>> > Should we merge this to the release branch?
>> >
>> > On Mon, J
hans created this revision.
clang-cl would evaluate the arguments right-to-left (see PR), and for
non-Windows targets I suppose we only got it because we were already emitting
left-to-right in CodeGenFunction::EmitCallArgs.
https://reviews.llvm.org/D29350
Files:
lib/CodeGen/CGClass.cpp
te
Author: dblaikie
Date: Tue Jan 31 15:28:19 2017
New Revision: 293692
URL: http://llvm.org/viewvc/llvm-project?rev=293692&view=rev
Log:
Fix modules codegen to be compatible with modules-ts
The Module::WithCodegen flag was only being set when the module was
parsed from a ModuleMap. Instead set it l
rsmith added inline comments.
Comment at: include/clang/CodeGen/ModuleBuilder.h:71
+ ///
+ /// This methods can be called before initializing the CGDebugInfo calss.
+ /// But the returned value should not be used until after initialization.
Typo 'calss'
On 26 Dec 2016, at 13:23, Marina Yatsina via cfe-commits
wrote:
>
> Author: myatsina
> Date: Mon Dec 26 06:23:42 2016
> New Revision: 290539
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290539&view=rev
> Log:
> [inline-asm]No error for conflict between inputs\outputs and clobber list
>
> A
Thanks for the review. r293678.
Should this be merged to 4.0?
> On Jan 31, 2017, at 12:04 PM, Akira Hatanaka via Phabricator via cfe-commits
> wrote:
>
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL293678: [Sema] Transform a templated name bef
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293678: [Sema] Transform a templated name before looking it
up in (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D24969?vs=82134&id=86474#toc
Repository:
rL LLVM
https://r
Author: ahatanak
Date: Tue Jan 31 13:53:32 2017
New Revision: 293678
URL: http://llvm.org/viewvc/llvm-project?rev=293678&view=rev
Log:
[Sema] Transform a templated name before looking it up in
FindInstantiatedDecl or passing it to RebuildMemberExpr.
This fixes PR30361.
rdar://problem/17341274
D
Author: rnk
Date: Tue Jan 31 13:37:45 2017
New Revision: 293677
URL: http://llvm.org/viewvc/llvm-project?rev=293677&view=rev
Log:
Extend -Wcast-calling-convention to warn on declarations as well as definitions
My original warning was very conservative and I never revisited the
heuristics that wer
On 31 January 2017 at 18:36, Hans Wennborg wrote:
>>> Can you attach all commits that need to be backported into a bug
>>> against PR31622?
>>>
>>> We should probably squash them all before merge.
>>
>> What's the status here?
>
> Ping?
Hum, I think Eric did create the bug, but now I can't rememb
> If not, perhaps we should disable the attribute for the Clang 4 release
instead
FWIW, I'd strongly prefer to do this over letting diagnose_if go into Clang
4 unpatched. So, if my patch does feel too big, I'm happy to let
diagnose_if be a new-in-clang-5 attribute. :)
On Tue, Jan 31, 2017 at 11:1
Author: mpividori
Date: Tue Jan 31 13:05:05 2017
New Revision: 293676
URL: http://llvm.org/viewvc/llvm-project?rev=293676&view=rev
Log:
[windows] [asan] Fix tests failing after 293668.
Modified:
cfe/trunk/test/Driver/cl-link.c
Modified: cfe/trunk/test/Driver/cl-link.c
URL:
http://llvm.org/v
Sure, let's take this for Clang 4.
On 31 January 2017 at 10:39, Hans Wennborg wrote:
> Ping?
>
> On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote:
> > Should we merge this to the release branch?
> >
> > On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits
> > wrote:
> >> Author:
Yes, this makes sense. We should also decide what we're going to do about
the larger diagnose_if patch that George has asked to be ported to Clang 4.
Are you comfortable taking a patch of that size? If not, perhaps we should
disable the attribute for the Clang 4 release instead.
On 31 January 2017
Author: nico
Date: Tue Jan 31 12:42:05 2017
New Revision: 293675
URL: http://llvm.org/viewvc/llvm-project?rev=293675&view=rev
Log:
Keep Chromium ObjC column limit at 80 for consistency with C++
https://reviews.llvm.org/D29337
Patch from Dan Beam !
Modified:
cfe/trunk/lib/Format/Format.cpp
M
gtbercea created this revision.
Device offloading requires the specification of an additional flag containing
the triple of the //other// architecture the code is being compiled on if such
an architecture exists. If compiling for the host, the auxiliary triple flag
will contain the triple descr
Author: mpividori
Date: Tue Jan 31 12:31:38 2017
New Revision: 293668
URL: http://llvm.org/viewvc/llvm-project?rev=293668&view=rev
Log:
[windows] [asan] Add wholearchive flag when including static lib asan.
In Windows, when the sanitizer is implemented as a static library, we use
auxiliary static
Ping?
On Thu, Jan 26, 2017 at 3:42 PM, Hans Wennborg wrote:
> Should we merge this to the release branch?
>
> On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits
> wrote:
>> Author: majnemer
>> Date: Mon Jan 16 22:14:25 2017
>> New Revision: 292194
>>
>> URL: http://llvm.org/viewvc/l
On Thu, Jan 26, 2017 at 10:23 AM, Hans Wennborg wrote:
> On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote:
>> On 20 January 2017 at 19:46, Eric Fiselier wrote:
>>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7.
>>> We should merge this into 4.0 to help get `check
Ping?
On Thu, Jan 26, 2017 at 10:21 AM, Hans Wennborg wrote:
> Ping?
>
> On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote:
>> Ping?
>>
>> On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote:
>>> Richard, what do you think?
>>>
>>> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote:
Hi Hans,
> On Jan 31, 2017, at 9:08 AM, Hans Wennborg wrote:
>
> Hi Argyrios,
>
> Can you provide more background on what this does. Is it fixing an
> existing issue or doing something new?
On second thought, let’s not get this into the stable branch, this is
introducing something new, not fi
davidb closed this revision.
davidb added a comment.
Closed by revision r293638.
Repository:
rL LLVM
https://reviews.llvm.org/D27985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
aprantl added inline comments.
Comment at: lib/CodeGen/MacroPPCallbacks.cpp:62
+: DebugInfo(DI), PP(PP), FirstInclude(false), FirstIncludeDone(false),
+ CommandIncludeFiles(0), SkipFiles(2) {
+ Parents.push_back(nullptr);
aprantl wrote:
> Comment why Sk
Merged in r293653.
Thanks,
Hans
On Mon, Jan 30, 2017 at 7:16 PM, Akira Hatanaka wrote:
> Hans, can this be merged to 4.0? This fixes a regression from 3.9 (the part I
> touched was committed a few years ago, but didn’t cause an assert until
> recently).
>
>> On Jan 30, 2017, at 6:31 PM, Akira
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293649: [X86] Teach Clang about -mfentry flag (authored by
niravd).
Changed prior to commit:
https://reviews.llvm.org/D28001?vs=83850&id=86442#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28001
Author: niravd
Date: Tue Jan 31 11:00:35 2017
New Revision: 293649
URL: http://llvm.org/viewvc/llvm-project?rev=293649&view=rev
Log:
[X86] Teach Clang about -mfentry flag
Replace mcount calls with calls to fentry.
Reviewers: hfinkel, craig.topper
Subscribers: llvm-commits
Differential Revision
Hi Argyrios,
Can you provide more background on what this does. Is it fixing an
existing issue or doing something new?
r293461 is making changes beyond Index/ so I'd like Richard to take a look too.
Thanks,
Hans
On Mon, Jan 30, 2017 at 8:18 AM, Argyrios Kyrtzidis wrote:
> Hi Hans,
>
> Could th
Merged to 4.0 as discussed on PR31782.
On Mon, Jan 30, 2017 at 5:26 PM, Justin Bogner via cfe-commits
wrote:
> Author: bogner
> Date: Mon Jan 30 19:26:09 2017
> New Revision: 293581
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293581&view=rev
> Log:
> Revert "Adorn __call_once_proxy with `inl
Author: hans
Date: Tue Jan 31 10:40:22 2017
New Revision: 293645
URL: http://llvm.org/viewvc/llvm-project?rev=293645&view=rev
Log:
Merging r293581:
r293581 | bogner | 2017-01-30 17:26:09 -0800 (Mon, 30 Jan 2017) | 12 lines
R
Author: krasimir
Date: Tue Jan 31 09:40:15 2017
New Revision: 293641
URL: http://llvm.org/viewvc/llvm-project?rev=293641&view=rev
Log:
[clang-format] Fix regression about adding leading whitespace to the content of
line comments
Summary:
The reflower didn't measure precisely the line column of a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293641: [clang-format] Fix regression about adding leading
whitespace to the content of… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29329?vs=86435&id=86437#toc
Repositor
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D29329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:530
+ auto value = RVal;
+ if (auto loc = value.getAs()) {
+value = State->getRawSVal(*loc);
NoQ wrote:
> Is there a test case for this hack?
>
> I
Author: davidb
Date: Tue Jan 31 09:18:56 2017
New Revision: 293638
URL: http://llvm.org/viewvc/llvm-project?rev=293638&view=rev
Log:
Add support for demangling C++11 thread_local variables. In clang, the grammar
for mangling for these names are " ::= TW " for
wrapper variables or " ::= TH " for
baloghadamsoftware updated this revision to Diff 86428.
baloghadamsoftware added a comment.
Updates based on the comments.
https://reviews.llvm.org/D28771
Files:
lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp
test/Analysis/Inputs/system-header-simulator-cxx.h
test/Analysis/diagnos
Author: djasper
Date: Tue Jan 31 08:39:33 2017
New Revision: 293636
URL: http://llvm.org/viewvc/llvm-project?rev=293636&view=rev
Log:
clang-format: [JS] Indent expressions in ${} relative to their surrounding
This only affects expressions inside ${} scopes of template strings.
Here, we want to in
krasimir added a comment.
@djasper: I agree with the two spaces rule. Sounds pretty reasonable. Will add
this feature eventually.
Repository:
rL LLVM
https://reviews.llvm.org/D29326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: krasimir
Date: Tue Jan 31 08:31:44 2017
New Revision: 293633
URL: http://llvm.org/viewvc/llvm-project?rev=293633&view=rev
Log:
[clang-format] Fix reflow in block comment lines with leading whitespace.
Summary:
The reflower was not taking into account the additional leading whitespace in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293633: [clang-format] Fix reflow in block comment lines
with leading whitespace. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29326?vs=86419&id=86422#toc
Repository:
rL
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
I don't know. I could also make an argument that more than one space at the
beginning of a line should just stop the reflow. E.g. I could see people
writing paragraphs like this:
/*
*
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293632: [cmake] Hint find_package() to prefer LLVM installed
alongside clang (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D29304?vs=86339&id=86421#toc
Repository:
rL LLVM
Author: mgorny
Date: Tue Jan 31 08:15:40 2017
New Revision: 293632
URL: http://llvm.org/viewvc/llvm-project?rev=293632&view=rev
Log:
[cmake] Hint find_package() to prefer LLVM installed alongside clang
Include a path hint for find_package() in ClangConfig.cmake to ensure
that CMake prefers LLVM i
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
(resend to cfe-commits instead of cfe-dev)
please see my feature proposal for an option -fallback-style=fail below.
Thanks in advance for feedback,
Paul
- Forwarded Message
Subject: [cfe-dev] [clang-format] add option -fallba
Hi Saleem
Thanks for the quick response. A test case is added. It covers some ordinary
cases as well as corner cases like multiple paths to the same base.
Thanks
James
From: Saleem Abdulrasool
Date: Monday, January 30, 2017 at 6:50 PM
To: James Sun
Cc: Richard Smith , "cfe-commits@lists.llvm
Author: chefmax
Date: Tue Jan 31 01:00:23 2017
New Revision: 293609
URL: http://llvm.org/viewvc/llvm-project?rev=293609&view=rev
Log:
[lsan] Enable LSan for x86 Linux
This is a missed part of https://reviews.llvm.org/D28609.
Enable LSan for x86 Linux in clang driver.
Differential Revision: https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293624: [clang-format] Fix regression merging comments
across newlines. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29322?vs=86412&id=86413#toc
Repository:
rL LLVM
htt
Author: krasimir
Date: Tue Jan 31 07:32:38 2017
New Revision: 293624
URL: http://llvm.org/viewvc/llvm-project?rev=293624&view=rev
Log:
[clang-format] Fix regression merging comments across newlines.
Summary:
This fixes a regression that causes example:
```
enum A {
a, // line a
// line b
b
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129
+// Additional fine-grained breaking of line comment sections is controlled
+// by the class BreakableLineCommentSection in case it is desirable to keep
+// several line comment s
krasimir updated this revision to Diff 86412.
krasimir marked an inline comment as done.
krasimir added a comment.
- Add a FIXME also in the parser
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Ind
jhenderson added a comment.
Ping
https://reviews.llvm.org/D29027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Jan 31 07:12:32 2017
New Revision: 293623
URL: http://llvm.org/viewvc/llvm-project?rev=293623&view=rev
Log:
Fix up some no-exception compile failures
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp
Modified:
libcxx/trunk/test/s
Author: djasper
Date: Tue Jan 31 07:03:07 2017
New Revision: 293622
URL: http://llvm.org/viewvc/llvm-project?rev=293622&view=rev
Log:
clang-format: [JS] Properly set scopes inside template strings.
Before:
var f = `a:${aaa
.a}
a:
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg minus adding the FIXME to the place where we need the change.
Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129
+// Additional fine-grained breaking of line com
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a lin
krasimir updated this revision to Diff 86410.
krasimir added a comment.
- Add a FIXME for separating line comment sections into child lines
https://reviews.llvm.org/D29322
Files:
lib/Format/BreakableToken.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTest.cpp
Index: unit
Author: arphaman
Date: Tue Jan 31 06:37:48 2017
New Revision: 293619
URL: http://llvm.org/viewvc/llvm-project?rev=293619&view=rev
Log:
Workaround new -Wshadow warning introduced by r293599
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp
Modified:
libcxx/
djasper marked an inline comment as done.
djasper added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:178
- LastBlockComment = &Change;
-} else if (Change.Kind == tok::unknown) {
- if ((Change.StartOfBlockComment = LastBlockComment))
krasimir added a comment.
looks good!
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added inline comments.
Comment at: lib/Format/WhitespaceManager.cpp:178
- LastBlockComment = &Change;
-} else if (Change.Kind == tok::unknown) {
- if ((Change.StartOfBlockComment = LastBlockComment))
What happened to the tok::unknown case?
Author: djasper
Date: Tue Jan 31 06:07:35 2017
New Revision: 293618
URL: http://llvm.org/viewvc/llvm-project?rev=293618&view=rev
Log:
clang-format: [JS] Fix incorrect line break in template strings.
Before:
var f = ` ${a ? 'a' : 'b'
}`;
After:
var f = ` ${
djasper added a comment.
I apologize in advance if this causes merge conflicts with r293616. However, I
do hope that that actually makes this patch easier.
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
djasper added a comment.
I have given stuff in WhitespaceManager access to the actual FormatToken in
r293616. Hopefully that simplifies this patch.
https://reviews.llvm.org/D27651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: krasimir
Date: Tue Jan 31 05:38:02 2017
New Revision: 293617
URL: http://llvm.org/viewvc/llvm-project?rev=293617&view=rev
Log:
[clang-format] Don't reflow comment lines starting with '@'.
Summary:
This patch stops reflowing comment lines starting with '@', since they commonly
have a speci
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293617: [clang-format] Don't reflow comment lines starting
with '@'. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29323?vs=86405&id=86406#toc
Repository:
rL LLVM
https:
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D29323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper added a comment.
Sorry, it took a bit longer, but I have now submitted those changes in r293616.
Repository:
rL LLVM
https://reviews.llvm.org/D28462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
djasper closed this revision.
djasper added a comment.
Submitted as r293616.
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Tue Jan 31 05:25:01 2017
New Revision: 293616
URL: http://llvm.org/viewvc/llvm-project?rev=293616&view=rev
Log:
[clang-format] Refactor WhitespaceManager and friends
The main motivation behind this is to cleanup the WhitespaceManager and
make it more extensible for future al
djasper updated this revision to Diff 86404.
djasper added a comment.
Added assert. Removed unused InToken.
https://reviews.llvm.org/D29300
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a line comment that is
klimek w
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:685
LineTok = CurrentTok->Next;
+if (CurrentTok->Next && CurrentTok->Next->NewlinesBefore > 1) {
+ // A line comment section needs to broken by a line comment that is
Could we p
Hahnfeld updated this revision to Diff 86396.
Hahnfeld retitled this revision from "[Driver] Prefer libraries installed next
to Clang over those from GCC" to "[Driver] Add CLANG_PREFER_GCC_LIBRARIES which
can be disabled".
Hahnfeld edited the summary of this revision.
Hahnfeld added a reviewer: h
djasper marked an inline comment as done.
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:904-907
+void UnwrappedLineFormatter::formatFirstToken(const AnnotatedLine &Line,
const AnnotatedLine
*Previo
klimek added a comment.
Generally looks like the right direction, minus that I'm not sure yet what the
plan for things broken in BreakableToken are.
Comment at: lib/Format/TokenAnnotator.cpp:1843
+Current->MatchingParen->opensBlockOrBlockTypeList(Style))
+ --Inden
Author: sammccall
Date: Tue Jan 31 02:24:40 2017
New Revision: 293611
URL: http://llvm.org/viewvc/llvm-project?rev=293611&view=rev
Log:
Revert r293585 "Add better ODR checking for modules."
We're seeing what we believe are false positives. (It's hard to tell with the
available diagnostics, and I'
96 matches
Mail list logo
