[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

mehdi_amini added inline comments. Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464 if (C.getDriver().isSaveTempsEnabled() && - !C.getDriver().embedBitcodeInObject() && isa(JA)) + !C.getDriver().embedBitcodeInObject() && !C.getDriver().isUsingLTO() && + isa(JA))

r293370 - Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode)

Author: mehdi_amini Date: Sat Jan 28 00:07:17 2017 New Revision: 293370 URL: http://llvm.org/viewvc/llvm-project?rev=293370&view=rev Log: Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode) Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/tr

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. > Regarding incremental solving with Z3 (or with most SMT solvers in general), > let me just lower the expectations a bit: Ok, that is good to know. It seems that the performance benefits of incremental solving are unclear, and would be nontrivial to implement (maybe stor

r293369 - Attempt to unbreak buildbots.

Author: gbiv Date: Fri Jan 27 22:16:32 2017 New Revision: 293369 URL: http://llvm.org/viewvc/llvm-project?rev=293369&view=rev Log: Attempt to unbreak buildbots. r293360 broke some ARM bots, because size_t on those targets is apparently `unsigned int`, not `unsigned long`. `sizeof(whatever)` shoul

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

steven_wu added a comment. Sorry I just notice that when I look at driver today. Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464 if (C.getDriver().isSaveTempsEnabled() && - !C.getDriver().embedBitcodeInObject() && isa(JA)) + !C.getDriver().embedBitcodeInObject() &&

r293367 - Switch the template specialization kind for a non-defining declaration of a

Author: rsmith Date: Fri Jan 27 20:56:07 2017 New Revision: 293367 URL: http://llvm.org/viewvc/llvm-project?rev=293367&view=rev Log: Switch the template specialization kind for a non-defining declaration of a non-template function instantiated from a friend declaration in a class template from TSK

r293364 - Avoid calling dump() in normal code

Author: matze Date: Fri Jan 27 20:36:00 2017 New Revision: 293364 URL: http://llvm.org/viewvc/llvm-project?rev=293364&view=rev Log: Avoid calling dump() in normal code dump() is only available in debug builds and meant for debugger usage, normal code should use something like print(errs()); Modi

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv added a comment. Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D28889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL293360: Change how we handle diagnose_if attributes. (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D28889?vs=86146&id=86155#toc Repository: rL LLVM https://reviews.llvm.org/D

r293360 - Change how we handle diagnose_if attributes.

Author: gbiv Date: Fri Jan 27 20:19:40 2017 New Revision: 293360 URL: http://llvm.org/viewvc/llvm-project?rev=293360&view=rev Log: Change how we handle diagnose_if attributes. This patch changes how we handle argument-dependent `diagnose_if` attributes. In particular, we now check them in the sam

r293358 - -Wunused-func-template: do not warn on non-template function declarations that

Author: rsmith Date: Fri Jan 27 19:50:33 2017 New Revision: 293358 URL: http://llvm.org/viewvc/llvm-project?rev=293358&view=rev Log: -Wunused-func-template: do not warn on non-template function declarations that were nonetheless instantiated (particularly, non-template friends declared within clas

r293355 - Support '#pragma clang __debug dump' within C++ classes.

Author: rsmith Date: Fri Jan 27 19:20:57 2017 New Revision: 293355 URL: http://llvm.org/viewvc/llvm-project?rev=293355&view=rev Log: Support '#pragma clang __debug dump' within C++ classes. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp URL: ht

r293354 - Convert sequence of 'if's on the same value to a switch. No functionality change intended.

Author: rsmith Date: Fri Jan 27 19:12:10 2017 New Revision: 293354 URL: http://llvm.org/viewvc/llvm-project?rev=293354&view=rev Log: Convert sequence of 'if's on the same value to a switch. No functionality change intended. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11933 } - aaron.ballman wrote: > Unintended change? ...I dunno what keeps making this change, but I'll re-undo it before I submit. https://reviews.llvm.org/D28889 ___

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv added inline comments. Comment at: test/SemaCXX/diagnose_if.cpp:615 +// evaluator isn't able to evaluate `adl::Foo(1)` to a constexpr, though. +// I'm assuming this is because we assign it to a temporary. +for (void *p : adl::Foo(1)) {} -

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv updated this revision to Diff 86146. george.burgess.iv marked 7 inline comments as done. george.burgess.iv added a comment. Addressed all feedback > Another "fun" testcase Ooh, shiny. Added. https://reviews.llvm.org/D28889 Files: include/clang/Sema/Overload.h include/cla

r293350 - When converting a template argument representing &array to an expression for a

Author: rsmith Date: Fri Jan 27 18:38:35 2017 New Revision: 293350 URL: http://llvm.org/viewvc/llvm-project?rev=293350&view=rev Log: When converting a template argument representing &array to an expression for a pointer typed template parameter, form &array rather than an array-to-pointer decay on

[PATCH] D28845: Prototype of modules codegen

rsmith added a comment. Comment at: include/clang/AST/ASTContext.h:2490 /// it is not used. - bool DeclMustBeEmitted(const Decl *D); + bool DeclMustBeEmitted(const Decl *D, bool WritingModule = false); I think the name of this flag might be out of sync

[PATCH] D21675: New ODR checker for modules

rtrieu updated this revision to Diff 86142. rtrieu added a comment. Changes made to the ODR hash algorithm: Separated Decl and Type pointers into their own DenseMap's. Removed the queue of pointers to process at the end. Instead, process pointers at first use. Save Boolean values and add them t

[PATCH] D28845: Prototype of modules codegen

dblaikie updated this revision to Diff 86140. dblaikie added a comment. - More test coverage (for local static variables) https://reviews.llvm.org/D28845 Files: include/clang/AST/ASTContext.h include/clang/AST/ExternalASTSource.h include/clang/Basic/LangOptions.def include/clang/Basic/M

[PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

This revision was automatically updated to reflect the committed changes. Closed by commit rL293344: Fix linkage of static locals in available_externally functions to be… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D29233?vs=86137&id=86138#toc Repository: rL LLV

[PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

dblaikie updated this revision to Diff 86137. dblaikie added a comment. Improve comment/mention Itanium ABI https://reviews.llvm.org/D29233 Files: lib/AST/ASTContext.cpp test/CodeGenCXX/explicit-instantiation.cpp Index: test/CodeGenCXX/explicit-instantiation.cpp ==

r293344 - Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

Author: dblaikie Date: Fri Jan 27 17:11:10 2017 New Revision: 293344 URL: http://llvm.org/viewvc/llvm-project?rev=293344&view=rev Log: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr As Mehdi put it, entities should either be available_externally+

[PATCH] D29234: [ubsan] Sanity-check shift amounts before truncation (fixes PR27271)

This revision was automatically updated to reflect the committed changes. Closed by commit rL293343: [ubsan] Sanity-check shift amounts before truncation (fixes PR27271) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29234?vs=86130&id=86134#toc Repository: rL LLVM

r293343 - [ubsan] Sanity-check shift amounts before truncation (fixes PR27271)

Author: vedantk Date: Fri Jan 27 17:02:44 2017 New Revision: 293343 URL: http://llvm.org/viewvc/llvm-project?rev=293343&view=rev Log: [ubsan] Sanity-check shift amounts before truncation (fixes PR27271) Ubsan does not report UB shifts in some cases where the shift exponent needs to be truncated t

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On 27 January 2017 at 14:44, David Blaikie wrote: > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator < > revi...@reviews.llvm.org> wrote: > >> mehdi_amini accepted this revision. >> mehdi_amini added a comment. >> This revision is now accepted and ready to land. >> >> LGTM. >> >> >

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:55 PM, David Blaikie wrote: > > > On Fri, Jan 27, 2017 at 2:51 PM Mehdi Amini wrote: >> >> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: >> >> >> >> On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: >>> >>> CC Hans. >>> >>> This is not a regression (AFAICT), but t

Re: Add warning for c++ member variable shadowing

+def warn_shadow_member_variable : Warning< + "shadowed variable '%0' in type '%1' inheriting from type '%2'">, The phrasing of this is incorrect: the things you're warning about are not variables, they're non-static data members. Perhaps something like: "non-static data member '%0' of '%1' sh

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:51 PM Mehdi Amini wrote: > On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: > > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so > may be worth considering in the 4.0 branc

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini > wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so may > be worth considering in the 4.0 branch? > > Perhaps -

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:48 PM Mehdi Amini wrote: > On Jan 27, 2017, at 2:44 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator < > revi...@reviews.llvm.org> wrote: > > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This revision i

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

Reid: Richard and I played around with this with MSVC on godbolt

[PATCH] D29234: [ubsan] Sanity-check shift amounts before truncation (fixes PR27271)

vsk created this revision. Ubsan does not report UB shifts in some cases where the shift exponent needs to be truncated to match the type of the shift base. We perform a range check on the truncated shift amount, leading to false negatives. Fix the issue (PR27271) by performing the range check on

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:44 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This revision is now accepted and ready to land. > > LGTM.

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator < revi...@reviews.llvm.org> wrote: > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This revision is now accepted and ready to land. > > LGTM. > > > > > Comment at: lib/AST/ASTContext.cpp:8909 > + >

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so > may be worth considering in the 4.0 branch? > Perhaps - I'd generally err on the "if it's not a regression, don't hold the boat". LLVM's been this way for

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

CC Hans. This is not a regression (AFAICT), but this is a quality improvement, so may be worth considering in the 4.0 branch? — Mehdi > On Jan 27, 2017, at 2:04 PM, David Blaikie via Phabricator > wrote: > > dblaikie created this revision. > > As Mehdi put it, entities should either be > a

[PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/AST/ASTContext.cpp:8909 + +// Itanium ABI (& MSVC seems to do similarly) requires static locals in +// inline functions to be emitted

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

rsmith added a comment. Another "fun" testcase: struct S { void operator++(int n) _diagnose_if(n, "wat", "warning"); }; void f(S s) { s++; // no warning s.operator++(1); // warning } Comment at: include/clang/Sema/Sema.h:2638 - /// Check the diagnose_if

[PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

dblaikie created this revision. As Mehdi put it, entities should either be available_externally+weak_odr, or linkonce_odr+linkonce_odr. While some functions are emitted a_e/weak, their local variables were emitted a_e/linkonce_odr. While it might be nice to emit them a_e/weak, the Itanium ABI (&

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

Thanks! > On Jan 27, 2017, at 9:07 AM, Hans Wennborg wrote: > > Merged in r293303. > > Thanks, > Hans > > On Fri, Jan 27, 2017 at 8:19 AM, Argyrios Kyrtzidis via cfe-commits > wrote: >> *bump* >> >>> On Jan 25, 2017, at 6:36 PM, Argyrios Kyrtzidis wrote: >>> >>> Hi Hans, >>> >>> Could thi

r293333 - PR31783: Don't request the alignment of an invalid declaration.

Author: rsmith Date: Fri Jan 27 15:28:37 2017 New Revision: 29 URL: http://llvm.org/viewvc/llvm-project?rev=29&view=rev Log: PR31783: Don't request the alignment of an invalid declaration. Fixes an assertion failure on PS4 targets. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/tr

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv updated this revision to Diff 86111. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Address feedback https://reviews.llvm.org/D28889 Files: include/clang/Sema/Overload.h include/clang/Sema/Sema.h lib/Sema/SemaChecking.cpp lib/Sem

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

george.burgess.iv added a comment. Thanks for the feedback! Comment at: lib/Sema/SemaChecking.cpp:2520 + +// TODO: Call can technically be a const CallExpr, but const_casting feels ugly, +// and I really don't want to duplicate unwrapCallExpr's logic. No caller really ---

[PATCH] D26345: Extend small data threshold driver options to PPC target

rsmith added a comment. LGTM https://reviews.llvm.org/D26345 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r293330 - Fix ASAN failure in cxa_demangle

Author: mehdi_amini Date: Fri Jan 27 14:32:16 2017 New Revision: 293330 URL: http://llvm.org/viewvc/llvm-project?rev=293330&view=rev Log: Fix ASAN failure in cxa_demangle Found with ASAN + libFuzzer by Kostya Serebryany Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test

[PATCH] D26345: Extend small data threshold driver options to PPC target

jackoalan updated this revision to Diff 86088. jackoalan added a comment. Herald added a subscriber: nemanjai. Remove already-aliased option matchings; add test case for patch. https://reviews.llvm.org/D26345 Files: lib/Driver/Tools.cpp test/Driver/ppc-eabi-small-data.c Index: test/Driver

[PATCH] D28889: Change where we handle arg-dependent diagnose_if attributes

aaron.ballman added a comment. I don't see anything that looks amiss, but you should wait for @rsmith to approve. Comment at: lib/Sema/SemaChecking.cpp:2520 + +// TODO: Call can technically be a const CallExpr, but const_casting feels ugly, +// and I really don't want to dupl

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

mehdi_amini added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:452 + if (CodeGenOpts.DebugInfoForProfiling) +getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling", 1); mehdi_amini wrote: > danielcdh wrote: > > mehdi_amini

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

mehdi_amini added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:452 + if (CodeGenOpts.DebugInfoForProfiling) +getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling", 1); danielcdh wrote: > mehdi_amini wrote: > > Why should w

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda added a comment. Thanks and sorry for the breakage. Unfortunately, I'm unable to reproduce locally (OSX), but will try to get access to linux box this weekend. Seems to be related to memory corruption wrt to improper StringRef usage, but I can't say for sure yet. https://reviews.llv

r293311 - ARM-Darwin: re-enable -momit-leaf-frame-pointer.

Author: tnorthover Date: Fri Jan 27 11:53:42 2017 New Revision: 293311 URL: http://llvm.org/viewvc/llvm-project?rev=293311&view=rev Log: ARM-Darwin: re-enable -momit-leaf-frame-pointer. In r279546 I disabled all frame pointer elimination at the front-end on ARM-Darwin (and warned about it) becaus

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

danielcdh added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:452 + if (CodeGenOpts.DebugInfoForProfiling) +getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling", 1); mehdi_amini wrote: > Why should we warn on mismatch? In

Re: [libcxx] r291928 - Update version to 5.0

Thanks! I tried to update all version numbers I could find, but I obviously missed this one :-) On Fri, Jan 13, 2017 at 10:29 AM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Jan 13 12:29:56 2017 > New Revision: 291928 > > URL: http://llvm.org/viewvc/llvm-project?rev=291928&v

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

mehdi_amini added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:452 + if (CodeGenOpts.DebugInfoForProfiling) +getModule().addModuleFlag(llvm::Module::Warning, "DebugInfoForProfiling", 1); Why should we warn on mismatch? https://reviews.llvm

[PATCH] D29198: clang-cl: Warn about /U flags that look like filenames (PR31662)

This revision was automatically updated to reflect the committed changes. Closed by commit rL293305: clang-cl: Warn about /U flags that look like filenames (PR31662) (authored by hans). Changed prior to commit: https://reviews.llvm.org/D29198?vs=85963&id=86062#toc Repository: rL LLVM https:

r293305 - clang-cl: Warn about /U flags that look like filenames (PR31662)

Author: hans Date: Fri Jan 27 11:09:41 2017 New Revision: 293305 URL: http://llvm.org/viewvc/llvm-project?rev=293305&view=rev Log: clang-cl: Warn about /U flags that look like filenames (PR31662) Both on Mac and Windows, it's common to have a 'Users' directory in the root of the filesystem, so on

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Thanks a lot - Best regards, Alexey Bataev 27.01.2017 19:57, Hans Wennborg пишет: > I've got it. Merged in r293302. > > Thanks, > Hans > > On Fri, Jan 27, 2017 at 4:49 AM, Alexey Bataev wrote: >> Yes. Could you do it yourself or you want me to do it? >> >> - >> Best regar

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

Merged in r293303. Thanks, Hans On Fri, Jan 27, 2017 at 8:19 AM, Argyrios Kyrtzidis via cfe-commits wrote: > *bump* > >> On Jan 25, 2017, at 6:36 PM, Argyrios Kyrtzidis wrote: >> >> Hi Hans, >> >> Could this go into the stable branch ? >> >>> On Jan 25, 2017, at 6:11 PM, Argyrios Kyrtzidis via

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

I've got it. Merged in r293302. Thanks, Hans On Fri, Jan 27, 2017 at 4:49 AM, Alexey Bataev wrote: > Yes. Could you do it yourself or you want me to do it? > > - > Best regards, > Alexey Bataev > > 27.01.2017 2:33, Hans Wennborg пишет: >> Should we merge this to the release branch? >

Re: [libcxx] r292607 - Don't default older GCC's to C++17, but C++14 or C++11 instead

On Thu, Jan 26, 2017 at 6:09 PM, Marshall Clow wrote: > On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg wrote: >> >> What's the status here? Waiting for Marshall? > > > I'm fine with merging this to the 4.0 branch Merged in r293301. Thanks, Hans ___ c

[libcxx] r293301 - Merging r292607:

Author: hans Date: Fri Jan 27 10:41:31 2017 New Revision: 293301 URL: http://llvm.org/viewvc/llvm-project?rev=293301&view=rev Log: Merging r292607: r292607 | ericwf | 2017-01-20 04:54:45 -0800 (Fri, 20 Jan 2017) | 1 line Don

[PATCH] D29205: Change debug-info-for-profiling from a TargetOption to a function attribute.

danielcdh updated this revision to Diff 86058. danielcdh added a comment. change to use module flag. https://reviews.llvm.org/D29205 Files: lib/CodeGen/BackendUtil.cpp lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp ==

Re: [libunwind] r292723 - X86: swap EBP, ESP on !APPLE

r293298. Thanks, Hans On Thu, Jan 26, 2017 at 6:38 PM, Saleem Abdulrasool wrote: > I think that this is safe enough and does make libunwind work on x86 Linux, > so lets go for it. > > On Thu, Jan 26, 2017 at 10:10 AM, Hans Wennborg wrote: >> >> Michał suggested on the PR that this should be mer

[libunwind] r293298 - Merging r292723:

Author: hans Date: Fri Jan 27 10:27:43 2017 New Revision: 293298 URL: http://llvm.org/viewvc/llvm-project?rev=293298&view=rev Log: Merging r292723: r292723 | compnerd | 2017-01-21 08:22:59 -0800 (Sat, 21 Jan 2017) | 17 lines

Re: r292561 - PR31701: Fix crash on invalid caused by parsing a dependent initializer when we

r293297. Cheers, Hans On Thu, Jan 26, 2017 at 4:45 PM, Richard Smith wrote: > Sure, why not. > > On 26 January 2017 at 15:56, Hans Wennborg wrote: >> >> A candidate for clang 4? >> >> On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits >> wrote: >> > Author: rsmith >> > Date: Thu Ja

Re: r293134 - [index] When indexing an ObjC method declaration use its base name for the location.

*bump* > On Jan 25, 2017, at 6:36 PM, Argyrios Kyrtzidis wrote: > > Hi Hans, > > Could this go into the stable branch ? > >> On Jan 25, 2017, at 6:11 PM, Argyrios Kyrtzidis via cfe-commits >> wrote: >> >> Author: akirtzidis >> Date: Wed Jan 25 20:11:50 2017 >> New Revision: 293134 >> >> UR

[PATCH] D29221: clang-format-vsix: "format on save" feature

amaiorano created this revision. This change adds a feature to the clang-format VS extension that optionally enables the automatic formatting of documents when saving. Since developers always need to save their files, this eases the workflow of making sure source files are properly formatted. T

[PATCH] D29118: [clang-tidy] safety-no-vector-bool

djehuti added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoVectorBoolCheck.cpp:52 +<< MatchedDecl; + } +} JonasToth wrote: > maybe an safety else with an failing assert, so you can see that unexpected > behaviour, see comment above

r293286 - [OpenCL] Add missing address spaces in IR generation of blocks

Author: stulova Date: Fri Jan 27 09:11:34 2017 New Revision: 293286 URL: http://llvm.org/viewvc/llvm-project?rev=293286&view=rev Log: [OpenCL] Add missing address spaces in IR generation of blocks Modify ObjC blocks impl wrt address spaces as follows: - keep default private address space for blo

[PATCH] D29118: [clang-tidy] safety-no-vector-bool

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/safety/NoVectorBoolCheck.cpp:50 +diag(MatchedDecl->getLocation(), + " function %0 returns an instance of std::vector") +<< MatchedDecl; jbcoe wrote: > djehuti wrote: > >

[PATCH] D29031: [mips] Add support for static model on N64

This revision was automatically updated to reflect the committed changes. Closed by commit rL293285: [mips] Add support for static model on N64 (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D29031?vs=85388&id=86047#toc Repository: rL LLVM https://reviews.llvm.org/

r293285 - [mips] Add support for static model on N64

Author: sdardis Date: Fri Jan 27 09:05:25 2017 New Revision: 293285 URL: http://llvm.org/viewvc/llvm-project?rev=293285&view=rev Log: [mips] Add support for static model on N64 The patch teaches the Clang driver how to handle the N64 static relocation model properly. It enforces the correct targe

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added a comment. Ping. https://reviews.llvm.org/D25866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r293217 - Implement a new clang-tidy check that suggests users replace dynamic exception specifications with noexcept exception specifications.

On Fri, Jan 27, 2017 at 2:36 AM, Diana Picus wrote: > Hi Don, Hi Aaron, > > I had to revert this in r293267 because all the clang-tools-extra > buildbots were still broken many hours after it was committed. > See for instance > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1039

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

aaron.ballman added a comment. There were some issues with failing tests that caused this commit to need to be reverted in r293267 See for instance: http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1039 Eugene Zelenko also had some small fixes you might want to incorporate as

Re: r292590 - [OPENMP] Fix for PR31643: Clang crashes when compiling code on Windows

Yes. Could you do it yourself or you want me to do it? - Best regards, Alexey Bataev 27.01.2017 2:33, Hans Wennborg пишет: > Should we merge this to the release branch? > > On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits > wrote: >> Author: abataev >> Date: Fri Jan 20

r293280 - [analyzer] Consider function call arguments while building CallGraph.

Author: dergachev Date: Fri Jan 27 06:14:56 2017 New Revision: 293280 URL: http://llvm.org/viewvc/llvm-project?rev=293280&view=rev Log: [analyzer] Consider function call arguments while building CallGraph. Function call can appear in the arguments of another function call, eg.: foo(bar()); Th

[PATCH] D28905: [analyzer] Consider function call arguments while building CallGraph

This revision was automatically updated to reflect the committed changes. Closed by commit rL293280: [analyzer] Consider function call arguments while building CallGraph. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D28905?vs=84973&id=86041#toc Repository: rL LL

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv added inline comments. Comment at: lib/Basic/FileManager.cpp:218 +#ifdef LLVM_ON_WIN32 + SmallString<128> NormalizedPath(Filename.str()); + llvm::sys::path::native(NormalizedPath); yaron.keren wrote: > I'd use a larger SmallString<256>, with large projec

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv added a comment. besc: I can't reproduce any crash. I tried trunk and the release_39 branch with msvc2015. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

r293270 - clang-format: [JS] do not format MPEG transport streams.

Author: mprobst Date: Fri Jan 27 03:09:11 2017 New Revision: 293270 URL: http://llvm.org/viewvc/llvm-project?rev=293270&view=rev Log: clang-format: [JS] do not format MPEG transport streams. Summary: The MPEG transport stream file format also uses ".ts" as its file extension. This change detects

[PATCH] D29186: clang-format: [JS] do not format MPEG transport streams.

This revision was automatically updated to reflect the committed changes. Closed by commit rL293270: clang-format: [JS] do not format MPEG transport streams. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D29186?vs=85934&id=86028#toc Repository: rL LLVM https://rev

[PATCH] D29186: clang-format: [JS] do not format MPEG transport streams.

mprobst added a comment. In https://reviews.llvm.org/D29186#657828, @alexeagle wrote: > confused, wasn't this committed last year? is this an extra check? I think I fixed this in tslint, but not in clang-format. At least I cannot find a trace of it (but yeah, I thought I had fixed it, too).

RE: r293207 - PR0091R3: Implement parsing support for using templates as types.

Hi Richard, I've filed this issue as PR31783. Douglas Yung > -Original Message- > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of Yung, Douglas via cfe-commits > Sent: Thursday, January 26, 2017 15:36 > To: Richard Smith > Cc: cfe-commits@lists.llvm.org > Subj