Hi Don, Hi Aaron,
I had to revert this in r293267 because all the clang-tools-extra
buildbots were still broken many hours after it was committed.
See for instance
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1039
Eugene Zelenko also had some small fixes to
modernize-use-noex
Author: rovka
Date: Fri Jan 27 01:19:22 2017
New Revision: 293267
URL: http://llvm.org/viewvc/llvm-project?rev=293267&view=rev
Log:
Revert "Implement a new clang-tidy check that suggests users replace dynamic
exception specifications with noexcept exception specifications."
This reverts commit r
zaks.anna added a comment.
The static analyzer is definitely the place to go for bug detection that
requires path sensitivity. It's also reasonably good for anything that needs
flow-sensitivity. Although, most flow-sensitive analysis (such as liveness) now
live in lib/Analysis/, which is used b
danalbert created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D29209
Files:
test/libcxx/compiler.py
test/libcxx/test/format.py
Index: test/libcxx/test/format.py
===
--- test/libcxx/test/format.py
+++ test/lib
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
This really needs a new driver flag (`-unwinder`?) similar to `-rtlib`, as
there are multiple unwinders, and it is unclear which unwinder is the proper
one on a given target. Th
wristow added a comment.
When a class that has been tagged as dllexport (for an MSVC target) contains an
atomic data member via the C11 '_Atomic' approach, the front end crashes with a
null pointer dereference.
This patch fixes it by guarding the null dereference with the approach used by
simil
I think that this is safe enough and does make libunwind work on x86 Linux,
so lets go for it.
On Thu, Jan 26, 2017 at 10:10 AM, Hans Wennborg wrote:
> Michał suggested on the PR that this should be merged to the release
> branch.
>
> Saleem, what do you think?
>
> On Sat, Jan 21, 2017 at 8:22 A
wristow created this revision.
Guard against a null pointer dereference that caused Clang to crash
when processing a class containing an _Atomic() data member,
and that is tagged with 'dllexport'.
https://reviews.llvm.org/D29208
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/atomic-dllexpor
Sorry, somehow I missed that. Ive gone ahead and reverted this change for
now (SVN r293257).
On Thu, Jan 26, 2017 at 2:30 PM, Evgenii Stepanov wrote:
> Actually, the bot has been red since Jan 21 with this exact error.
>
> On Thu, Jan 26, 2017 at 2:27 PM, Evgenii Stepanov
> wrote:
> > Hi,
> >
Author: compnerd
Date: Thu Jan 26 20:26:52 2017
New Revision: 293257
URL: http://llvm.org/viewvc/llvm-project?rev=293257&view=rev
Log:
Revert "DWARF: convert error logs to _LIBUNWIND_LOG"
This reverts SVN r292721. Avoid the use of the GNU extension as the
preprocessor in C++11 mode requires at l
compnerd accepted this revision.
compnerd added a comment.
Thanks for adding this, diagnosing what was going on here the first time around
took a little bit of thinking.
https://reviews.llvm.org/D29198
___
cfe-commits mailing list
cfe-commits@lists
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
As of r293254, the `-G=` and `-msmall-data-threshold=` flags are just aliases
of `-G`, so you don't need those parts of this patch any more. The PPC part
looks fine, but please add a testcase.
Author: rsmith
Date: Thu Jan 26 20:08:37 2017
New Revision: 293254
URL: http://llvm.org/viewvc/llvm-project?rev=293254&view=rev
Log:
[docs] Add help text and refine grouping for various options.
Also accept -G= (and -msmall-data-threshold=) as an alias for -G on MIPS as
well as Hexagon.
Modifie
On Thu, Jan 26, 2017 at 10:22 AM, Hans Wennborg wrote:
> What's the status here? Waiting for Marshall?
>
I'm fine with merging this to the 4.0 branch
-- Marshall
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: rsmith
Date: Thu Jan 26 19:54:42 2017
New Revision: 293252
URL: http://llvm.org/viewvc/llvm-project?rev=293252&view=rev
Log:
Improve workaround for Sphinx's lack of support for command line options
containing '+', '.' etc. to be more stable as the set of options changes.
Modified:
cf
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Sure, why not.
On 26 January 2017 at 15:56, Hans Wennborg wrote:
> A candidate for clang 4?
>
> On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Thu Jan 19 19:19:46 2017
> > New Revision: 292561
> >
> > URL: http://llvm.org/viewvc/llvm-project
danielcdh created this revision.
Herald added a subscriber: mehdi_amini.
cfe change for https://reviews.llvm.org/D29203
https://reviews.llvm.org/D29205
Files:
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenFunction.cpp
Index: lib/CodeGen/CodeGenFunction.cpp
===
Author: eugenezelenko
Date: Thu Jan 26 17:58:21 2017
New Revision: 293234
URL: http://llvm.org/viewvc/llvm-project?rev=293234&view=rev
Log:
[Clang-tidy documentation] Consistency (fix-it); 80 characters per line.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-no-m
Author: pcc
Date: Thu Jan 26 17:51:50 2017
New Revision: 293231
URL: http://llvm.org/viewvc/llvm-project?rev=293231&view=rev
Log:
Re-apply r292662, "IRGen: Start using the WriteThinLTOBitcode pass."
The internal build issue has been resolved.
Added:
cfe/trunk/test/CodeGenCXX/type-metadata-th
A candidate for clang 4?
On Thu, Jan 19, 2017 at 5:19 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Jan 19 19:19:46 2017
> New Revision: 292561
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292561&view=rev
> Log:
> PR31701: Fix crash on invalid caused by parsing a depen
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D29198
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Should we merge this to the release branch?
On Mon, Jan 16, 2017 at 8:14 PM, David Majnemer via cfe-commits
wrote:
> Author: majnemer
> Date: Mon Jan 16 22:14:25 2017
> New Revision: 292194
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292194&view=rev
> Log:
> [AST] AttributedType should deriv
Hi Richard,
I don't know if you have noticed, but the test you added in this commit is
failing on both the Linux and Windows PS4 bots. The test is failing with an
assertion failure:
Assertion failed: !A->getDeducedType().isNull() && "cannot request the size of
an undeduced or dependent auto ty
Should we merge this to the release branch?
On Fri, Jan 20, 2017 at 12:57 AM, Alexey Bataev via cfe-commits
wrote:
> Author: abataev
> Date: Fri Jan 20 02:57:28 2017
> New Revision: 292590
>
> URL: http://llvm.org/viewvc/llvm-project?rev=292590&view=rev
> Log:
> [OPENMP] Fix for PR31643: Clang cr
Author: rsmith
Date: Thu Jan 26 17:07:59 2017
New Revision: 293223
URL: http://llvm.org/viewvc/llvm-project?rev=293223&view=rev
Log:
[modules] Additional tests.
Added:
cfe/trunk/test/Modules/Inputs/anon-redecl/
cfe/trunk/test/Modules/Inputs/anon-redecl/a.h
cfe/trunk/test/Modules/Input
Author: rsmith
Date: Thu Jan 26 17:06:10 2017
New Revision: 293222
URL: http://llvm.org/viewvc/llvm-project?rev=293222&view=rev
Log:
Add files forgotten in r293219.
Added:
cfe/trunk/test/Modules/Inputs/merge-name-for-linkage/c1.h
cfe/trunk/test/Modules/Inputs/merge-name-for-linkage/c2.h
hans added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:252
+ InGroup>;
+def note_use_dashdash : Note<"Use '--' to treat subsequent arguments as
filenames">;
+
amccarth wrote:
> For Windows, wouldn't it make more sense to suggest us
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D29077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
aaron.ballman added a comment.
In https://reviews.llvm.org/D20693#658087, @hintonda wrote:
> Great, thanks. Could you commit for me?
Certainly! I've commit in r293217.
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@list
Author: rsmith
Date: Thu Jan 26 16:39:55 2017
New Revision: 293219
URL: http://llvm.org/viewvc/llvm-project?rev=293219&view=rev
Log:
[modules] When reading / writing a typedef that is a name for linkage for
another declaration, ensure we actually serialize / deserialize that
declaration.
Before t
Author: aaronballman
Date: Thu Jan 26 16:39:01 2017
New Revision: 293218
URL: http://llvm.org/viewvc/llvm-project?rev=293218&view=rev
Log:
Correcting a typo in the test case to appease bots.
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-noexcept.cpp
Modified: clang-tools-ex
Author: aaronballman
Date: Thu Jan 26 16:34:24 2017
New Revision: 293217
URL: http://llvm.org/viewvc/llvm-project?rev=293217&view=rev
Log:
Implement a new clang-tidy check that suggests users replace dynamic exception
specifications with noexcept exception specifications.
Patch by Don Hinton.
A
amccarth added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:252
+ InGroup>;
+def note_use_dashdash : Note<"Use '--' to treat subsequent arguments as
filenames">;
+
For Windows, wouldn't it make more sense to suggest using valid path
jbcoe added inline comments.
Comment at: clang-tools-extra/clang-tidy/safety/NoVectorBoolCheck.cpp:50
+diag(MatchedDecl->getLocation(),
+ " function %0 returns an instance of std::vector")
+<< MatchedDecl;
djehuti wrote:
> JonasToth wrote:
> >
Actually, the bot has been red since Jan 21 with this exact error.
On Thu, Jan 26, 2017 at 2:27 PM, Evgenii Stepanov
wrote:
> Hi,
>
> I'm not sure why we only see this now, but this change is breaking
> llvm bootstrap with -Werror:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds
hintonda added a comment.
Great, thanks. Could you commit for me?
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Yes, this LGTM as well. Thank you for working on this!
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lis
Hi,
I'm not sure why we only see this now, but this change is breaking
llvm bootstrap with -Werror:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/732/steps/bootstrap%20clang/logs/stdio
llvm/projects/libunwind/src/config.h:90:41: error: token pasting of
',' and __VA_ARGS__ is a G
jbcoe updated this revision to Diff 85967.
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
Responses to some change requests. Input needed on template argument matcher.
https://reviews.llvm.org/D29118
Files:
clang-tools-extra/clang-tidy/CMakeLists.txt
clang-tools-extra/clang-
On Mon, Jan 23, 2017 at 5:55 PM, Nico Weber wrote:
> On Mon, Jan 23, 2017 at 5:29 PM, Aaron Ballman
> wrote:
>>
>> On Mon, Jan 23, 2017 at 5:00 PM, Nico Weber via cfe-commits
>> wrote:
>> > On Sun, Jan 22, 2017 at 6:17 AM, Malcolm Parsons
>> >
>> > wrote:
>> >>
>> >> On 20 January 2017 at 21:32
hans created this revision.
Both on Mac and Windows, it's common to have a 'Users' directory in the root of
the filesystem, so one might specify a filename as '/Users/me/myfile.c'.
clang-cl (as well as MSVC's cl.exe) will interpret that as invoking '/U'
option, which is probably not what the us
Author: pcc
Date: Thu Jan 26 15:38:48 2017
New Revision: 293210
URL: http://llvm.org/viewvc/llvm-project?rev=293210&view=rev
Log:
Add missing x86 requirement.
Modified:
cfe/trunk/test/CodeGen/thinlto-multi-module.ll
Modified: cfe/trunk/test/CodeGen/thinlto-multi-module.ll
URL:
http://llvm.o
danalbert created this revision.
num_put::put uses %p for pointer types, but the exact format of %p is
implementation defined behavior for the C library. Compare output to
snprintf for portability.
Repository:
rL LLVM
https://reviews.llvm.org/D29197
Files:
test/std/localization/locale.cat
george.burgess.iv added a comment.
Pinging early because this is a release blocker. :)
https://reviews.llvm.org/D28889
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293209: IRGen: When loading the main module in the
distributed ThinLTO backend, look… (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D29067?vs=85618&id=85958#toc
Repository:
rL
Author: pcc
Date: Thu Jan 26 15:09:48 2017
New Revision: 293209
URL: http://llvm.org/viewvc/llvm-project?rev=293209&view=rev
Log:
IRGen: When loading the main module in the distributed ThinLTO backend, look
for the module containing the summary.
Differential Revision: https://reviews.llvm.org/D2
Author: rsmith
Date: Thu Jan 26 14:40:47 2017
New Revision: 293207
URL: http://llvm.org/viewvc/llvm-project?rev=293207&view=rev
Log:
PR0091R3: Implement parsing support for using templates as types.
This change adds a new type node, DeducedTemplateSpecializationType, to
represent a type template
On 26 January 2017 at 18:22, Hans Wennborg wrote:
> What's the status here? Waiting for Marshall?
Possibly. I can confirm this made all the problem on ARM go away with
GCC 5.3 and 6.3.
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: rampitec
Date: Thu Jan 26 10:49:21 2017
New Revision: 293190
URL: http://llvm.org/viewvc/llvm-project?rev=293190&view=rev
Log:
Use TargetMachine adjustPassManager hook
Differential Revision: https://reviews.llvm.org/D28340
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cf
alexeagle added a comment.
confused, wasn't this committed last year? is this an extra check?
https://reviews.llvm.org/D29186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ahatanak
Date: Thu Jan 26 12:51:10 2017
New Revision: 293199
URL: http://llvm.org/viewvc/llvm-project?rev=293199&view=rev
Log:
Turn on -Wblock-capture-autoreleasing by default.
Turning on the warning by default helps the users as it's a common
mistake to capture out-parameters in a block
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293197: Disable thread safety analysis for some functions in
__thread_support (authored by dim).
Changed prior to commit:
https://reviews.llvm.org/D28520?vs=85794&id=85939#toc
Repository:
rL LLVM
ht
Author: dim
Date: Thu Jan 26 12:37:18 2017
New Revision: 293197
URL: http://llvm.org/viewvc/llvm-project?rev=293197&view=rev
Log:
Disable thread safety analysis for some functions in __thread_support
Many thread-related libc++ test cases fail on FreeBSD, due to the
following -Werror warnings:
JDevlieghere updated this revision to Diff 85937.
JDevlieghere added a comment.
- Added missing instantiations in test
Repository:
rL LLVM
https://reviews.llvm.org/D28768
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/Return
Eugene.Zelenko added a comment.
In https://reviews.llvm.org/D29151#657435, @Prazek wrote:
> In https://reviews.llvm.org/D29151#656887, @Eugene.Zelenko wrote:
>
> > General question: isn't Static Analyzer is better place for such workflow
> > checks?
>
>
> Probably yes, but it is much harder to i
Author: ahatanak
Date: Thu Jan 26 12:13:06 2017
New Revision: 293194
URL: http://llvm.org/viewvc/llvm-project?rev=293194&view=rev
Log:
[Sema][ObjC] Make sure -Wblock-capture-autoreleasing issues a warning
even in the presence of nullability qualifiers.
This commit fixes bugs in r285031 where -Wbl
On Fri, Jan 20, 2017 at 1:52 PM, Renato Golin wrote:
> On 20 January 2017 at 19:46, Eric Fiselier wrote:
>> This patch fixes a libc++abi test failure when compiled with GCC 5, 6, or 7.
>> We should merge this into 4.0 to help get `check-all` clean.
>
> Hi Eric,
>
> All good on my side, pass with
What's the status here? Waiting for Marshall?
On Mon, Jan 23, 2017 at 10:20 AM, Hans Wennborg wrote:
> Sounds good to me.
>
> On Fri, Jan 20, 2017 at 11:38 AM, Eric Fiselier wrote:
>> We should merge this patch into the 4.0 release branch. It is needed to make
>> "check-all" pass when using GCC
Ping?
On Mon, Jan 23, 2017 at 4:27 PM, Hans Wennborg wrote:
> Ping?
>
> On Tue, Jan 17, 2017 at 4:16 PM, Hans Wennborg wrote:
>> Richard, what do you think?
>>
>> On Fri, Jan 13, 2017 at 3:16 PM, Eric Fiselier wrote:
>>> I would love to see this merged. It would make it easier to write libc++
>
mprobst added a comment.
PTAL, moved the check down a bit.
https://reviews.llvm.org/D29186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 85934.
mprobst added a comment.
- Move MPEG check into Format.cpp.
https://reviews.llvm.org/D29186
Files:
lib/Format/Format.cpp
tools/clang-format/ClangFormat.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
Michał suggested on the PR that this should be merged to the release branch.
Saleem, what do you think?
On Sat, Jan 21, 2017 at 8:22 AM, Saleem Abdulrasool via cfe-commits
wrote:
> Author: compnerd
> Date: Sat Jan 21 10:22:59 2017
> New Revision: 292723
>
> URL: http://llvm.org/viewvc/llvm-proje
On Thu, Jan 26, 2017 at 6:08 AM, Marshall Clow wrote:
> On Wed, Jan 25, 2017 at 10:58 PM, Marshall Clow via cfe-commits
> wrote:
>>
>> Author: marshall
>> Date: Thu Jan 26 00:58:29 2017
>> New Revision: 293154
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev
>> Log:
>> Use the n
Author: hans
Date: Thu Jan 26 11:55:46 2017
New Revision: 293193
URL: http://llvm.org/viewvc/llvm-project?rev=293193&view=rev
Log:
Merging r293154:
r293154 | marshall | 2017-01-25 22:58:29 -0800 (Wed, 25 Jan 2017) | 1 line
U
On Thu, Jan 26, 2017 at 6:05 AM, Marshall Clow wrote:
> On Wed, Jan 25, 2017 at 9:11 AM, Hans Wennborg wrote:
>>
>> Should we merge this to 4.0?
>
>
> Yes, please.
r293192.
Cheers,
Hans
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: hans
Date: Thu Jan 26 11:51:25 2017
New Revision: 293192
URL: http://llvm.org/viewvc/llvm-project?rev=293192&view=rev
Log:
Merging r292990:
r292990 | marshall | 2017-01-24 15:09:12 -0800 (Tue, 24 Jan 2017) | 1 line
C
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestJS.cpp:1002
+TEST_F(FormatTestJS, IgnoresMpegTS) {
+ char mpegTS[200];
+ mpegTS[0] = 0x47;
nit: Should be Mpeg
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D28905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Yes, things are happy again, thanks!
Our bots currently use the macOS 10.10 SDK.
On Thu, Jan 26, 2017 at 6:56 AM, Asiri Rathnayake <
asiri.rathnay...@gmail.com> wrote:
> Hi Nico,
>
> Hopefully I've sorted this out in r293166/r293167. Please let me know if
> things are not back to normal.
>
> (I'
mprobst created this revision.
Herald added a subscriber: klimek.
The MPEG transport stream file format also uses ".ts" as its file extension.
This change detects its specific framing format (0x47 every 189 bytes) and
simply ignores MPEG TS files.
https://reviews.llvm.org/D29186
Files:
tools/
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D29183#657706, @NoQ wrote:
> Hmm, we should have done better work reviewing
> https://reviews.llvm.org/D28905.
Oh, someone was quicker than me by one week...
https://reviews.llvm.org/D29183
___
baloghadamsoftware added a comment.
I wonder if this could also be a problem for nested messages in Objective-C,
since the call for VisitChildren() is also missing from
VisitObjCMessageExpr()...
https://reviews.llvm.org/D29183
___
cfe-commits mail
NoQ added a comment.
Hmm, we should have done better work reviewing https://reviews.llvm.org/D28905.
https://reviews.llvm.org/D29183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv updated this revision to Diff 85927.
faisalv added a comment.
I tried a different approach, not because I was convinced it was better, but
because it seemed (at the time) a simpler tweak - I'm not sure it is robust
enough - but would appreciate your thoughts on it.
The approach is predi
baloghadamsoftware added a comment.
Some comments how I found this bug. I got some strange false positives even
after the fix for the iterator past end checker
(https://reviews.llvm.org/D28771). I could reproduce it with the following code:
#include
using std::list;
using std::prev;
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D29183#657669, @xazax.hun wrote:
> Great find! Could you transform your examole into a testcasr that fails
> before this patch? I think there should be already some tests for call
> graphs that you can take a look at.
Yes, but I
xazax.hun added a comment.
Great find! Could you transform your examole into a testcasr that fails before
this patch? I think there should be already some tests for call graphs that
you can take a look at.
https://reviews.llvm.org/D29183
___
cfe-
baloghadamsoftware created this revision.
Take the following example:
class Int {
public:
Int(int n = 0): num(n) {}
Int(const Int& rhs): num(rhs.num) {}
Int& operator=(const Int& rhs) { num = rhs.num; }
operator int() { return num; }
private:
int num;
};
templa
emaste added a comment.
> My concern is that the stock gcc distributions for FreeBSD, NetBSD from your
> sources doesn't define __mips_abicalls,
I think we should consider that a bug in GCC that we'll rectify. If
`__mips_abicalls` is used in Linux GCC then we can expect 3rd party sources to
ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293187: [change-namespace] correctly shorten namespace when
references have leading '::' (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29182?vs=85917&id=85919#toc
Repository:
Author: ioeric
Date: Thu Jan 26 10:31:32 2017
New Revision: 293187
URL: http://llvm.org/viewvc/llvm-project?rev=293187&view=rev
Log:
[change-namespace] correctly shorten namespace when references have leading '::'
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://review
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric created this revision.
https://reviews.llvm.org/D29182
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
===
--- un
Author: arpith
Date: Thu Jan 26 09:43:27 2017
New Revision: 293183
URL: http://llvm.org/viewvc/llvm-project?rev=293183&view=rev
Log:
[OpenMP] Codegen support for 'target teams' on the NVPTX device.
This is a simple patch to teach OpenMP codegen to emit the construct
in Generic mode.
Reviewers: A
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293183: [OpenMP] Codegen support for 'target teams' on the
NVPTX device. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29143?vs=85791&id=85913#toc
Repository:
rL LLVM
http
yaxunl added a comment.
with the new pragma for associating types with extensions. This feature can be
implemented by solely modify opencl-c.h by adding #pragma OPENCL EXTENSION
cl_khr_fp64 : begin/end around vector double type definitions, e.g.
#pragma OPENCL EXTENSION cl_khr_fp64 : begin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293182: [change-namespace] add leading '::' to references in
new namespace when name… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29176?vs=85903&id=85904#toc
Repository:
Author: ioeric
Date: Thu Jan 26 09:08:44 2017
New Revision: 293182
URL: http://llvm.org/viewvc/llvm-project?rev=293182&view=rev
Log:
[change-namespace] add leading '::' to references in new namespace when name
conflict is possible.
Summary:
For example, when we change 'na' to "nb::nc", we need t
ioeric updated this revision to Diff 85903.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D29176
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespa
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Only nits below.
Comment at: change-namespace/ChangeNamespace.cpp:232
+auto &DeclNsTop = DeclNsSplitted.front();
+for (auto &Ns : NsNameSplitted)
+ if (Ns == D
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D28814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Thank you for being patient while we figured this out. :-)
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-c
davidb added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D27985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Thu Jan 26 08:36:14 2017
New Revision: 293179
URL: http://llvm.org/viewvc/llvm-project?rev=293179&view=rev
Log:
Fixed a couple of invalid statuses for 2665 and 2758
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://l
delesley added a comment.
This looks good to me.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
For example, when we change 'na' to "nb::nc", we need to add leading '::' to
references "::nc::X" in the changed namespace.
https://reviews.llvm.org/D29176
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: u
On Wed, Jan 25, 2017 at 10:58 PM, Marshall Clow via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: marshall
> Date: Thu Jan 26 00:58:29 2017
> New Revision: 293154
>
> URL: http://llvm.org/viewvc/llvm-project?rev=293154&view=rev
> Log:
> Use the new __has_feature(cxx_constexpr_string_b
On Wed, Jan 25, 2017 at 9:11 AM, Hans Wennborg wrote:
> Should we merge this to 4.0?
>
Yes, please.
-- Marshall
>
> On Tue, Jan 24, 2017 at 3:09 PM, Marshall Clow via cfe-commits
> wrote:
> > Author: marshall
> > Date: Tue Jan 24 17:09:12 2017
> > New Revision: 292990
> >
> > URL: http://llv
Anastasia added inline comments.
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu
+
Anastasia wrote:
> arsenm
1 - 100 of 114 matches
Mail list logo
