smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM apart from minor comments.
https://reviews.llvm.org/D28725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
smeenai added inline comments.
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
EricWF wrote:
> smeenai wrote:
> > EricWF wrote:
> > > smeenai wrote:
> > > > We should be able to remove this now, right
EricWF updated this revision to Diff 84438.
EricWF added a comment.
I think this patch is ready to go. @smeenai any last words?
https://reviews.llvm.org/D28725
Files:
CMakeLists.txt
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.py
test/lit.site.cfg.in
test/support/s
EricWF added inline comments.
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
smeenai wrote:
> EricWF wrote:
> > smeenai wrote:
> > > We should be able to remove this now, right?
> > I would still rat
EricWF updated this revision to Diff 84437.
EricWF added a comment.
- Address inline comments.
- Stop MSVC's default assertion handler from opening a new dialog window on
failure.
https://reviews.llvm.org/D28725
Files:
CMakeLists.txt
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/t
smeenai added inline comments.
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
EricWF wrote:
> smeenai wrote:
> > We should be able to remove this now, right?
> I would still rather strip it and re-ad
EricWF added a comment.
In https://reviews.llvm.org/D28725#646325, @smeenai wrote:
> Awesome. LGTM except that force-removing the `_DEBUG` define and then linking
> against the debug libraries might cause some wonkiness.
Ack. I'll update the patch to still force remove `_DEBUG` but then later
malcolm.parsons added a comment.
In https://reviews.llvm.org/D28672#646151, @aaron.ballman wrote:
> I'm not seeing anything wrong, per se, but why has so much of this file
> changed recently?
The script looks for doxygen docs on clang.llvm.org. Are they missing?
https://reviews.llvm.org/D286
ahatanak updated this revision to Diff 84434.
ahatanak added a comment.
Remove lifetime markers completely for variables that are declared after a
label was seen in a compound statement
I tested this patch building llvm's test-suite and SPEC benchmarks with -Os.
Surprisingly (maybe not so surpr
smeenai added a comment.
Awesome. LGTM except that force-removing the `_DEBUG` define and then linking
against the debug libraries might cause some wonkiness.
Comment at: CMakeLists.txt:394
# non-debug DLLs
remove_flags("/D_DEBUG" "/MTd" "/MDd" "/MT" "/Md" "/RTC1")
---
EricWF created this revision.
EricWF added reviewers: smeenai, rnk, majnemer, compnerd.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This patch allows libc++ to be built against the debug MSVC runtimes instead of
just the release ones.
https://reviews.llvm.org/D287
EricWF updated this revision to Diff 84433.
https://reviews.llvm.org/D28725
Files:
CMakeLists.txt
lib/CMakeLists.txt
test/CMakeLists.txt
test/libcxx/test/config.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
---
EricWF added a comment.
In https://reviews.llvm.org/D28716#646274, @grandinj wrote:
> would it be better to internally treat __attribute__((non_null)) like
> diagnose_if ? then you get all the warnings for free?
There were previous objections about using `non_null` within libc++ due to the
af
Author: ericwf
Date: Sat Jan 14 00:06:47 2017
New Revision: 292001
URL: http://llvm.org/viewvc/llvm-project?rev=292001&view=rev
Log:
[libc++] [CMake] Link with /nodefaultlibs on Windows
Summary:
This patch attempts to fix the libc++ build/link so that it doesn't use an
default C++ libraries on W
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292001: [libc++] [CMake] Link with /nodefaultlibs on Windows
(authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D28441?vs=84428&id=84430#toc
Repository:
rL LLVM
https://reviews.
EricWF updated this revision to Diff 84428.
EricWF added a comment.
- Address inline comments.
https://reviews.llvm.org/D28441
Files:
CMakeLists.txt
cmake/Modules/HandleLibcxxFlags.cmake
lib/CMakeLists.txt
test/libcxx/test/config.py
Index: test/libcxx/test/config.py
==
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/CMakeLists.txt:113
+ add_library_flags(msvcrt) # C runtime startup files
+ # Required for wide character formatting functions (e.g. `printfw`/`scanfw`)
+ add_library_flags(iso_stdio_wide_spe
smeenai added inline comments.
Comment at: lib/CMakeLists.txt:112
+ add_library_flags(vcruntime) # C++ runtime
+ add_library_flags(msvcrt) # C runtime startup files
+ add_library_flags(iso_stdio_wide_specifiers)
EricWF wrote:
> smeenai wrote:
> > EricWF wrote:
Author: marshall
Date: Fri Jan 13 23:55:17 2017
New Revision: 292000
URL: http://llvm.org/viewvc/llvm-project?rev=292000&view=rev
Log:
Mark 'constexpr char_traits' as complete.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vi
grandinj added a comment.
would it be better to internally treat __attribute__((non_null)) like
diagnose_if ? then you get all the warnings for free?
https://reviews.llvm.org/D28716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
There's a bunch of follow-up work here, but I'm fine with this for now.
https://reviews.llvm.org/D28441
___
cfe-commits mailing list
cfe-commit
smeenai added a comment.
In https://reviews.llvm.org/D28441#646145, @EricWF wrote:
> In https://reviews.llvm.org/D28441#639023, @smeenai wrote:
>
> > I think the right thing to do would be to either always compile two
> > versions of libc++, one linked against the debug libraries and the other
Author: ericwf
Date: Fri Jan 13 23:43:02 2017
New Revision: 291998
URL: http://llvm.org/viewvc/llvm-project?rev=291998&view=rev
Log:
Tweak .clang-format configuration.
Remove the custom configuration options for brace wrapping. They
don't work well for inline functions or type-traits classes.
Mo
Author: gbiv
Date: Fri Jan 13 23:19:34 2017
New Revision: 291997
URL: http://llvm.org/viewvc/llvm-project?rev=291997&view=rev
Log:
Fix a typo. NFC.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/
Author: ericwf
Date: Fri Jan 13 22:27:58 2017
New Revision: 291995
URL: http://llvm.org/viewvc/llvm-project?rev=291995&view=rev
Log:
Use __is_identifier to detect Clang extensions instead of __has_extension.
When -pedantic-errors is specified `__has_extension()` is always
false when it would othe
This patch causes `execute_process` to dump the standard error if the
command fails. This causes
the llvm-config help message to be printed as part of CMake configuration,
which is ugly and incorrect.
I've already fixed this for libc++, libc++abi, and libunwind trunk, but the
issue still exists in
Author: ericwf
Date: Fri Jan 13 21:47:49 2017
New Revision: 291993
URL: http://llvm.org/viewvc/llvm-project?rev=291993&view=rev
Log:
Don't dump llvm-config --cmakedir output if command fails.
This patch adjusts the out-of-tree CMake configuration so that
the stderr output is ignored when an old l
Author: ericwf
Date: Fri Jan 13 21:46:05 2017
New Revision: 291992
URL: http://llvm.org/viewvc/llvm-project?rev=291992&view=rev
Log:
Don't dump llvm-config --cmakedir output if command fails.
This patch adjusts the out-of-tree CMake configuration so that
the stderr output is ignored when an old l
Author: ericwf
Date: Fri Jan 13 21:35:15 2017
New Revision: 291991
URL: http://llvm.org/viewvc/llvm-project?rev=291991&view=rev
Log:
Don't dump llvm-config --cmakedir output if command fails.
This patch adjusts the out-of-tree CMake configuration so that
the stderr output is ignored when an old l
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Although `is_assignable` can often get accidentally instantiated with an
incomplete type by way of `std::tuple` or similar, which is the
rational for this test case.
https://reviews.l
ahatanak added a comment.
In https://reviews.llvm.org/D28705#646088, @rnk wrote:
> What happens with virtual bases?
>
> struct B { int x; };
> struct D : virtual B { int y; };
> void test() { D d = {1, .y = 2}; }
A class with virtual base is not considered an aggregate, so it doesn't go
EricWF added a comment.
@cpplearner Do you need somebody to commit this for you?
https://reviews.llvm.org/D27850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
In https://reviews.llvm.org/D28520#646160, @aaron.ballman wrote:
> I feel like I must be missing something; why is this disabling rather than
> specifying the thread safety behavior? e.g., `__libcpp_mutex_lock()`
> specifying that it acquires the capability and `__libcpp
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need somebody to commit this for you?
Let me know once you've committed it and I'll merge it into the 4.0 branch.
https://reviews.llvm.org/D22452
_
ahatanak updated this revision to Diff 84418.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
https://reviews.llvm.org/D28705
Files:
lib/Sema/SemaInit.cpp
test/SemaCXX/designated-initializers-base-class.cpp
Index: test/SemaCXX/designated-initi
aaron.ballman added a comment.
I feel like I must be missing something; why is this disabling rather than
specifying the thread safety behavior? e.g., `__libcpp_mutex_lock()` specifying
that it acquires the capability and `__libcpp_mutex_unlock()` specifying that
it releases it?
https://revie
aaron.ballman added a comment.
I'm not seeing anything wrong, per se, but why has so much of this file changed
recently?
https://reviews.llvm.org/D28672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
EricWF updated this revision to Diff 84414.
EricWF added a comment.
Attempt to address review comments
- Rename `LIBCXX_TARGETING_WINDOWS` to `LIBCXX_TARGETING_MSVC`. It is set to on
when CMake defines `MSVC` to `ON`. This macro is intented to represent cases
where we are targeting native Windo
EricWF added a comment.
In https://reviews.llvm.org/D28441#639023, @smeenai wrote:
> One potential issue with always forcing the non-debug msvcrt is that any apps
> that link against libc++ would also then need to use the non-debug CRT
> libraries, otherwise you'd get all sorts of fun runtime e
Author: rsmith
Date: Fri Jan 13 20:19:59 2017
New Revision: 291988
URL: http://llvm.org/viewvc/llvm-project?rev=291988&view=rev
Log:
Give more accurate descriptions of what kind of template we found in
diagnostics.
We were previouly assuming that every type template was a class template, which
i
Author: ericwf
Date: Fri Jan 13 19:58:01 2017
New Revision: 291987
URL: http://llvm.org/viewvc/llvm-project?rev=291987&view=rev
Log:
Don't force use of lld in tests on Windows
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llv
Ah. lld-link actually only accepts link-style options, so it wouldn't solve
that particular problem. Happily, it seems like we aren't relying on ld-style
options to begin with.
From: Eric Fiselier
Date: Friday, January 13, 2017 at 5:52 PM
To: Shoaib Meenai
Cc: "cfe-commits@lists.llvm.org"
Subje
On Thu, Jan 12, 2017 at 1:17 AM, Shoaib Meenai wrote:
> What was the rationale for forcing the use of lld? Were errors encountered
> with link? It's slightly annoying to have the extra dependency;
Initially I thought it was required in order to avoid re-writing all of the
linker flags.
However
Author: ericwf
Date: Fri Jan 13 19:33:53 2017
New Revision: 291986
URL: http://llvm.org/viewvc/llvm-project?rev=291986&view=rev
Log:
Remove unused parameters in C++03
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-project/libcxx/
EricWF created this revision.
EricWF added a reviewer: mclow.lists.
EricWF added a subscriber: cfe-commits.
This patch uses `diagnose_if` to attempt to catch null inputs in `std::string`.
Note that unlike `__attribute__((non_null))` `diagnose_if` does not affect
codegen.
https://reviews.llvm.o
rnk added a comment.
What happens with virtual bases?
struct B { int x; };
struct D : virtual B { int y; };
void test() { D d = {1, .y = 2}; }
Comment at: lib/Sema/SemaInit.cpp:2250
+if (auto *CXXRD = dyn_cast(RT->getDecl()))
+ FieldIndex += CXXRD->getNumBases
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Actually, this pattern annoys "warning C6326: Potential comparison of a
constant with another constant." from /analyze. I'll figure out a better fix,
probably with integral_constant.
https://reviews.llvm.org/D28592
Hello everyone,
LLVM buildmaster is back to work.
Please let me know if there are any issues.
Thanks you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
manmanren marked an inline comment as done.
manmanren added inline comments.
Comment at: include/clang/Serialization/Module.h:19
#include "clang/Basic/FileManager.h"
+#include "clang/Basic/Module.h"
#include "clang/Basic/SourceLocation.h"
rsmith wrote:
> Redund
Merged in r291978.
(Please keep the list cc'd on merge requests.)
Thanks,
Hans
On Fri, Jan 13, 2017 at 2:28 PM, Richard Smith wrote:
> Seems sensible to put this in clang 4.
>
> -- Forwarded message --
> From: Richard Smith via cfe-commits
> Date: 13 January 2017 at 14:16
> Sub
Author: ericwf
Date: Fri Jan 13 17:45:39 2017
New Revision: 291976
URL: http://llvm.org/viewvc/llvm-project?rev=291976&view=rev
Log:
Diagnose invalid memory orderings in
Added:
libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
Modified:
libcxx/trunk/include/__config
manmanren updated this revision to Diff 84406.
manmanren marked 7 inline comments as done.
manmanren added a comment.
Add CC1 option to control hashing of the module file content.
https://reviews.llvm.org/D27689
Files:
include/clang/AST/ExternalASTSource.h
include/clang/Basic/Module.h
inc
Author: djasper
Date: Fri Jan 13 17:18:16 2017
New Revision: 291974
URL: http://llvm.org/viewvc/llvm-project?rev=291974&view=rev
Log:
clang-format: Fix bug in making line break decisions.
Here, the optimization to not line wrap when it would not lead to a
reduction in columns was overwriting and
ahatanak accepted this revision.
ahatanak added a reviewer: ahatanak.
ahatanak added a comment.
This revision is now accepted and ready to land.
This looks OK to commit.
https://reviews.llvm.org/D28457
___
cfe-commits mailing list
cfe-commits@lists.
jgravelle-google abandoned this revision.
jgravelle-google added a comment.
Abandoning this in favor of https://github.com/kripken/emscripten/pull/4846
https://reviews.llvm.org/D28381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
I would love to see this merged. It would make it easier to write libc++
tests if the tests didn't have to worry about the old 4.0 behavior.
CC'ing Richard: Would merging this be OK?
On Fri, Jan 13, 2017 at 3:46 PM, George Burgess IV <
george.burgess...@gmail.com> wrote:
> Do we want to consider
Author: ericwf
Date: Fri Jan 13 16:42:53 2017
New Revision: 291969
URL: http://llvm.org/viewvc/llvm-project?rev=291969&view=rev
Log:
Diagnose non-const-callable hash functions and comparators
Added:
libcxx/trunk/test/libcxx/containers/unord/non_const_comparator.fail.cpp
Modified:
libcxx/t
Do we want to consider merging this into the release branch? Seems like
more of a bugfix than a feature to me.
On Fri, Jan 13, 2017 at 2:11 PM, Eric Fiselier via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ericwf
> Date: Fri Jan 13 16:11:40 2017
> New Revision: 291963
>
> URL: http
ahatanak created this revision.
ahatanak added reviewers: rsmith, rnk, arphaman.
ahatanak added a subscriber: cfe-commits.
CheckDesignatedInitializer wasn't taking into account the base classes when
computing the index for the field in the derived class, which caused the test
case to crash durin
Author: rsmith
Date: Fri Jan 13 16:16:41 2017
New Revision: 291964
URL: http://llvm.org/viewvc/llvm-project?rev=291964&view=rev
Log:
PR31631: fix bad CFG (and bogus warnings) when an if-statement has an
init-statement and has binary operator as its condition.
Modified:
cfe/trunk/lib/Analysis
rtrieu marked an inline comment as done.
rtrieu added a comment.
From testing, there is no difference when compiling with pre-compiled headers.
However, when building the headers, there is a 3-4% impact on compile time.
https://reviews.llvm.org/D21675
___
Author: ericwf
Date: Fri Jan 13 16:11:40 2017
New Revision: 291963
URL: http://llvm.org/viewvc/llvm-project?rev=291963&view=rev
Log:
[clang] Emit `diagnose_if` warnings from system headers
Summary: In order for libc++ to meaningfully use `diagnose_if` warnings they
need to be emitted from system
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D28703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: ericwf
Date: Fri Jan 13 16:02:08 2017
New Revision: 291961
URL: http://llvm.org/viewvc/llvm-project?rev=291961&view=rev
Log:
Add _LIBCPP_DIAGNOSE_WARNING and _LIBCPP_DIAGNOSE_ERROR macros.
Clang recently added a `diagnose_if(cond, msg, type)` attribute
which can be used to generate diagno
EricWF created this revision.
EricWF added reviewers: george.burgess.iv, rsmith, aaron.ballman.
EricWF added a subscriber: cfe-commits.
In order for libc++ to meaningfully use `diagnose_if` warnings they need to be
emitted from system headers by default. This patch changes the `diagnose_if`
warn
yaxunl retitled this revision from "Support synchronisation scope in atomic
builtin functions" to "Support synchronisation scope in Clang atomic builtin
functions".
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 84373.
yaxunl added a comment.
Fix typos and for
Should we slow down, or block commits for the time being?
It could be a total chaos when they get back...
On 13 January 2017 at 19:16, Galina Kistanova via cfe-commits
wrote:
> Just a remainder.
>
> LLVM buildmaster will be offline today hopefully for short time due for
> replacing network hardw
Author: rsmith
Date: Fri Jan 13 14:46:54 2017
New Revision: 291955
URL: http://llvm.org/viewvc/llvm-project?rev=291955&view=rev
Log:
PR31606: Generalize our tentative DR resolution for inheriting copy/move
constructors to better match the pre-P0136R1 behavior.
Modified:
cfe/trunk/include/clan
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Looks great to me, thanks! Unless someone else shouts, I'll land this for you
soon.
https://reviews.llvm.org/D28543
___
cfe-commits mailing list
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, rjmccall.
yaxunl added a subscriber: cfe-commits.
OpenCL 2.0 atomic builtin functions have a scope argument which is ideally
represented as synchronization scope argument in LLVM atomic instructions.
Clang supports translati
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks, looks good assuming your performance testing doesn't uncover anything.
Comment at: lib/AST/ODRHash.cpp:319-321
+if (!D) return;
+if (D->isImplicit())
+ r
Author: dblaikie
Date: Fri Jan 13 13:47:55 2017
New Revision: 291953
URL: http://llvm.org/viewvc/llvm-project?rev=291953&view=rev
Log:
Fix shared library build after r291938 by adding missing dependency on libOption
Thanks to Reid Kleckner for the help reproducing/fixing.
Modified:
cfe/trunk
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4237
+ /// compiler.
+ bool IsImplicitlyCreated : 1;
+
I would go with just `isImplicit`, to match other similar uses throughout the
AST. Also maybe sink this into the `Stmt` bitfields to ma
Great, thanks!
On Fri, Jan 13, 2017, 11:52 AM Hans Wennborg wrote:
> Merged in r291952.
>
> Thanks,
> Hans
>
> On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits
> wrote:
> > Author: echristo
> > Date: Thu Jan 12 19:52:04 2017
> > New Revision: 291879
> >
> > URL: http://llvm.org
yaxunl added a comment.
In https://reviews.llvm.org/D28058#645399, @dmitry wrote:
> @yaxunl, we already have the similar issue for atomics. Probably we can
> extend typedef semantic checks but I don't think it's a good idea since C and
> C++ have the similar problem but they don't provide speci
rnk added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:34
+ #if 0
+#define USE_VS_SETUP_CONFIG
+ #endif
What are the outstanding issues preventing you from enabling this by default?
Comment at: lib/Driver/MSVCToolChain.cpp:16
Merged in r291952.
Thanks,
Hans
On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits
wrote:
> Author: echristo
> Date: Thu Jan 12 19:52:04 2017
> New Revision: 291879
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291879&view=rev
> Log:
> Add a necessary newline for diagnose_if do
Merged in r291951.
Thanks,
Hans
On Fri, Jan 13, 2017 at 11:46 AM, Chandler Carruth wrote:
> Also need to pull in r291881. Sorry about that.
>
>
> On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote:
>>
>> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth
>> wrote:
>> >> This isn't quite right,
Also need to pull in r291881. Sorry about that.
On Thu, Jan 12, 2017 at 3:42 PM Hans Wennborg wrote:
> On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth
> wrote:
> >> This isn't quite right, it should either be left as-is or dropped
> >> completely. This path was allowing people to spell "-mllv
On Fri, Jan 13, 2017 at 8:06 AM, Jonathan Coe via cfe-commits
wrote:
> Author: jbcoe
> Date: Fri Jan 13 10:06:59 2017
> New Revision: 291907
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291907&view=rev
> Log:
> Revert "Support for Python 3 in libclang python bindings"
>
> This reverts commit 4
rtrieu marked 5 inline comments as done.
rtrieu added a comment.
Comments have been addressed. I will be testing it for performance impact next.
Comment at: include/clang/AST/ODRHash.h:54
+ // in Pointers.
+ size_type NextFreeIndex;
+
rsmith wrote:
> Is this
rtrieu updated this revision to Diff 84340.
https://reviews.llvm.org/D21675
Files:
include/clang/AST/DeclCXX.h
include/clang/AST/ODRHash.h
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSerializationKinds.td
lib/AST/CMakeLists.txt
lib/AST/DeclCXX.cpp
lib/AST/ODRHash.cpp
li
Author: jyknight
Date: Fri Jan 13 13:22:26 2017
New Revision: 291946
URL: http://llvm.org/viewvc/llvm-project?rev=291946&view=rev
Log:
[libc++abi] Add a silent terminate handler to libcxxabi.
The current std::terminate_handler pulls in some string code, some I/O
code, and more. Since it is automa
Merged in r291943.
Thanks,
Hans
On Thu, Jan 12, 2017 at 5:58 PM, Shoaib Meenai wrote:
> Requesting a merge to the 4.0 branch. This is a pretty small change, and it
> fixes an assertion failure on Windows (see PR31608 for details).
>
> On 1/12/17, 5:28 PM, "cfe-commits on behalf of Shoaib Meenai
EricWF added a comment.
@rsmith Ping. Would you like me to split this up into smaller change sets?
https://reviews.llvm.org/D26057
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Just a remainder.
LLVM buildmaster will be offline today hopefully for short time due for
replacing network hardware.
Thank you for understanding.
Thanks
Galina
On Thu, Jan 12, 2017 at 8:29 PM, Galina Kistanova
wrote:
> Hello everyone,
>
> LLVM buildmaster will be offline on 1/13/17 hopefull
Author: malcolm.parsons
Date: Fri Jan 13 13:02:50 2017
New Revision: 291941
URL: http://llvm.org/viewvc/llvm-project?rev=291941&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/trunk/unittes
Author: malcolm.parsons
Date: Fri Jan 13 12:56:04 2017
New Revision: 291940
URL: http://llvm.org/viewvc/llvm-project?rev=291940&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.c
Author: malcolm.parsons
Date: Fri Jan 13 12:55:32 2017
New Revision: 291939
URL: http://llvm.org/viewvc/llvm-project?rev=291939&view=rev
Log:
Remove unused lambda captures. NFC
Modified:
cfe/trunk/docs/ReleaseNotes.rst
cfe/trunk/lib/AST/CXXInheritance.cpp
cfe/trunk/lib/AST/MicrosoftMa
Author: dblaikie
Date: Fri Jan 13 12:53:43 2017
New Revision: 291938
URL: http://llvm.org/viewvc/llvm-project?rev=291938&view=rev
Log:
unique_ptrify Driver::ToolChains
Modified:
cfe/trunk/include/clang/Driver/Driver.h
cfe/trunk/lib/Driver/Driver.cpp
Modified: cfe/trunk/include/clang/Driv
Author: ericwf
Date: Fri Jan 13 12:42:41 2017
New Revision: 291935
URL: http://llvm.org/viewvc/llvm-project?rev=291935&view=rev
Log:
Fix merge error caused by r291922
Modified:
libcxx/branches/release_40/include/ios
Modified: libcxx/branches/release_40/include/ios
URL:
http://llvm.org/viewv
Author: ericwf
Date: Fri Jan 13 12:25:13 2017
New Revision: 291925
URL: http://llvm.org/viewvc/llvm-project?rev=291925&view=rev
Log:
Fix merge conflict caused by r291921
Modified:
libcxx/trunk/include/ios
Modified: libcxx/trunk/include/ios
URL:
http://llvm.org/viewvc/llvm-project/libcxx/tru
Author: ericwf
Date: Fri Jan 13 12:08:23 2017
New Revision: 291922
URL: http://llvm.org/viewvc/llvm-project?rev=291922&view=rev
Log:
Revert "Rework fix for PR19460 - Use explicit bool as an extension instead."
Modified:
libcxx/branches/release_40/include/__config
libcxx/branches/release_
erichkeane updated this revision to Diff 84330.
erichkeane added a comment.
Fixed the deprecated location 'note'. Observe the changes to a variety of
tests.
https://reviews.llvm.org/D27486
Files:
include/clang/Basic/Attr.td
include/clang/Sema/Sema.h
lib/Sema/SemaDeclAttr.cpp
lib/Sema/
Author: ericwf
Date: Fri Jan 13 12:03:46 2017
New Revision: 291921
URL: http://llvm.org/viewvc/llvm-project?rev=291921&view=rev
Log:
Revert "Rework fix for PR19460 - Use explicit bool as an extension instead."
This reverts commit 3a1b90a866b6d5d62a5f37fbfb3a1ee36cc70dd1.
Modified:
libcxx/tru
Author: dblaikie
Date: Fri Jan 13 11:34:15 2017
New Revision: 291919
URL: http://llvm.org/viewvc/llvm-project?rev=291919&view=rev
Log:
unique_ptrify createDriverOptTable
Modified:
cfe/trunk/include/clang/Driver/Driver.h
cfe/trunk/include/clang/Driver/Options.h
cfe/trunk/lib/Driver/Dri
erichkeane added a comment.
I've actually figured out how to fix the diagnosis location. I switched the
diagnosis to use the location of the actual [[deprecated]] attribute instead of
the Declaration location. IMO, this is a BETTER note anyway (since the arrow
points to the actual [[deprecate
pmatos added a comment.
Ah no, my mistake. I had the patch applied when I ran the test.
https://reviews.llvm.org/D27800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Fri Jan 13 11:18:19 2017
New Revision: 291917
URL: http://llvm.org/viewvc/llvm-project?rev=291917&view=rev
Log:
Use less byval on 32-bit Windows x86 for classes with bases
This comes up in V8, which has a Handle template class that wraps a
typed pointer, and is frequently passed
MathieuDuponchelle added a comment.
In https://reviews.llvm.org/D26082#645361, @jbcoe wrote:
> I've reverted this change and submitted https://reviews.llvm.org/D28682 to
> explicitly check the Python version.
>
> I'll pick this up again, I do want Python 3 support.
I'm not entirely sure why yo
1 - 100 of 129 matches
Mail list logo
