[PATCH] D28218: Small optimizations for SourceManager::getFileID()

djasper added a comment. Ping? https://reviews.llvm.org/D28218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM buildmaster will be unavailable on 1/13/17

Hello everyone, LLVM buildmaster will be offline on 1/13/17 hopefully for short time due for replacing network hardware. Thank you for understanding. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:86 + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; // expected-warning{{lambda capture 'i' is not required to be captured for use in an unevaluated context}} + a

r291881 - Another fix for r291850 because there are apparently targets which add

Author: chandlerc Date: Thu Jan 12 20:47:34 2017 New Revision: 291881 URL: http://llvm.org/viewvc/llvm-project?rev=291881&view=rev Log: Another fix for r291850 because there are apparently targets which add "-mllvm" flags to the CC1 invocation (notably, Hexagon seems to hit this). Modified: c

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

tejohnson added a comment. In https://reviews.llvm.org/D28588#644637, @danielcdh wrote: > Looks like this is still breaking these buildbots: > > http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3216/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Athinlto_backend.ll > > I reverted th

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:488 + +def AVRSignal : InheritableAttr, TargetSpecificAttr { + let Spellings = [GNU<"signal">]; dylanmckay wrote: > aaron.ballman wrote: > > Does this attribute appertain to any specifi

[PATCH] D28467: [Sema] Add warning for unused lambda captures

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; this is an awesome new diagnostic, thank you for working on it! Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:26 + auto explicit_initialized_va

r291880 - Implement DR1265 (wg21.link/cwg1265).

Author: rsmith Date: Thu Jan 12 20:22:01 2017 New Revision: 291880 URL: http://llvm.org/viewvc/llvm-project?rev=291880&view=rev Log: Implement DR1265 (wg21.link/cwg1265). Diasllow a declaration using the 'auto' type specifier from using two different meanings of it at once, or from declaring mult

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 84209. xiangzhai added a comment. Hi Anna, Thanks for your review! I process them (for example, g_malloc_n, take a different number of arguments) separately. And I run the testcases for Analysis/malloc.c and Analysis/gmalloc.c Regards, Leslie Zhai Rep

Re: [PATCH] D28588: Pass -fprofile-sample-use to lto backends.

On Thu, Jan 12, 2017 at 3:27 PM, Teresa Johnson via Phabricator < revi...@reviews.llvm.org> wrote: > tejohnson added a comment. > > In https://reviews.llvm.org/D28588#644489, @danielcdh wrote: > > > Thanks for the prompt response. > > > > But looks like several other tests also has "-mllvm > -debu

r291879 - Add a necessary newline for diagnose_if documentation.

Author: echristo Date: Thu Jan 12 19:52:04 2017 New Revision: 291879 URL: http://llvm.org/viewvc/llvm-project?rev=291879&view=rev Log: Add a necessary newline for diagnose_if documentation. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.t

Re: r291877 - [Sema] Restrict explicit instantation definition dllexport

Requesting a merge to the 4.0 branch. This is a pretty small change, and it fixes an assertion failure on Windows (see PR31608 for details). On 1/12/17, 5:28 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote: Author: smeenai Date: Thu Jan 12 19:28:34 2017 New Revis

[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

This revision was automatically updated to reflect the committed changes. Closed by commit rL291877: [Sema] Restrict explicit instantation definition dllexport (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D28590?vs=84062&id=84202#toc Repository: rL LLVM https://r

r291877 - [Sema] Restrict explicit instantation definition dllexport

Author: smeenai Date: Thu Jan 12 19:28:34 2017 New Revision: 291877 URL: http://llvm.org/viewvc/llvm-project?rev=291877&view=rev Log: [Sema] Restrict explicit instantation definition dllexport In the case where the template class itself is already `dllexport`, the implicit instantiation will have

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291876: [DOXYGEN] Documentation for the newly added x86 intrinsics. (authored by kromanova). Changed prior to commit: https://reviews.llvm.org/D28503?vs=84038&id=84200#toc Repository: rL LLVM https:

r291876 - [DOXYGEN] Documentation for the newly added x86 intrinsics.

Author: kromanova Date: Thu Jan 12 19:14:08 2017 New Revision: 291876 URL: http://llvm.org/viewvc/llvm-project?rev=291876&view=rev Log: [DOXYGEN] Documentation for the newly added x86 intrinsics. Added doxygen comments for the newly added intrinsics in avxintrin.h, namely _mm256_cvtsd_f64, _mm25

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

danielcdh added a comment. Looks like this is still breaking these buildbots: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/3216/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Athinlto_backend.ll I reverted the test change for now, and am thinking of how to reproduce/fix the pr

r291874 - Temporarily revert the test change in 291870, which is broken in certain buildbots.

Author: dehao Date: Thu Jan 12 19:09:43 2017 New Revision: 291874 URL: http://llvm.org/viewvc/llvm-project?rev=291874&view=rev Log: Temporarily revert the test change in 291870, which is broken in certain buildbots. Modified: cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/tes

r291871 - Update C++ status pages for Clang 4 branch:

Author: rsmith Date: Thu Jan 12 18:57:54 2017 New Revision: 291871 URL: http://llvm.org/viewvc/llvm-project?rev=291871&view=rev Log: Update C++ status pages for Clang 4 branch: * Update version number in DR tests from 4.0 to 4 * Teach make_cxx_dr_status script about version numbers that don't c

r291870 - Pass -fprofile-sample-use to lto backends.

Author: dehao Date: Thu Jan 12 18:51:55 2017 New Revision: 291870 URL: http://llvm.org/viewvc/llvm-project?rev=291870&view=rev Log: Pass -fprofile-sample-use to lto backends. Summary: LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passe

[PATCH] D27090: Add LocationContext as a parameter to checkRegionChanges

This revision was automatically updated to reflect the committed changes. Closed by commit rL291869: [analyzer] Add LocationContext as a parameter to checkRegionChanges (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D27090?vs=79204&id=84197#toc Repository: rL LLVM htt

[PATCH] D28495: [analyzer] Support inlining of '[self classMethod]' and '[[self class] classMethod]'

This revision was automatically updated to reflect the committed changes. Closed by commit rL291867: [analyzer] Support inlining of '[self classMethod]' and '[[self class]… (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D28495?vs=83720&id=84195#toc Repository: rL LLVM

r291867 - [analyzer] Support inlining of '[self classMethod]' and '[[self class] classMethod]'

Author: zaks Date: Thu Jan 12 18:50:47 2017 New Revision: 291867 URL: http://llvm.org/viewvc/llvm-project?rev=291867&view=rev Log: [analyzer] Support inlining of '[self classMethod]' and '[[self class] classMethod]' Differential Revision: https://reviews.llvm.org/D28495 Modified: cfe/trunk/

[PATCH] D28387: [tsan] Do not report errors in __destroy_helper_block_

This revision was automatically updated to reflect the committed changes. Closed by commit rL291868: [tsan] Do not report errors in __destroy_helper_block_ (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D28387?vs=83328&id=84196#toc Repository: rL LLVM https://reviews.

r291869 - [analyzer] Add LocationContext as a parameter to checkRegionChanges

Author: zaks Date: Thu Jan 12 18:50:57 2017 New Revision: 291869 URL: http://llvm.org/viewvc/llvm-project?rev=291869&view=rev Log: [analyzer] Add LocationContext as a parameter to checkRegionChanges This patch adds LocationContext to checkRegionChanges and removes wantsRegionChangeUpdate as it wa

r291866 - [analyzer] Fix false positives in Keychain API checker

Author: zaks Date: Thu Jan 12 18:50:41 2017 New Revision: 291866 URL: http://llvm.org/viewvc/llvm-project?rev=291866&view=rev Log: [analyzer] Fix false positives in Keychain API checker The checker has several false positives that this patch addresses: - Do not check if the return status has been

r291868 - [tsan] Do not report errors in __destroy_helper_block_

Author: zaks Date: Thu Jan 12 18:50:50 2017 New Revision: 291868 URL: http://llvm.org/viewvc/llvm-project?rev=291868&view=rev Log: [tsan] Do not report errors in __destroy_helper_block_ There is a synchronization point between the reference count of a block dropping to zero and it's destruction,

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

This revision was automatically updated to reflect the committed changes. Closed by commit rL291866: [analyzer] Fix false positives in Keychain API checker (authored by zaks). Changed prior to commit: https://reviews.llvm.org/D28330?vs=83160&id=84194#toc Repository: rL LLVM https://reviews.

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

danielcdh updated this revision to Diff 84193. danielcdh added a comment. Updates the unittests to clang_cc1 to see if it fixes the buildbot failure. https://reviews.llvm.org/D28588 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/thinlto_backend.ll Index: test/CodeGen/thinlto_backend.ll =

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

zaks.anna added a comment. I think it's more valuable to report a warning here even if the error message is not very precise. Marking something as in bounds when we know it's not does not feel right and could lead to inconsistent states down the road. Repository: rL LLVM https://reviews.llv

r291865 - Improve handling of instantiated thread_local variables in Itanium C++ ABI.

Author: rsmith Date: Thu Jan 12 18:43:31 2017 New Revision: 291865 URL: http://llvm.org/viewvc/llvm-project?rev=291865&view=rev Log: Improve handling of instantiated thread_local variables in Itanium C++ ABI. * Do not initialize these variables when initializing the rest of the thread_locals

[PATCH] D28590: [Sema] Restrict explicit instantation definition dllexport

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix! https://reviews.llvm.org/D28590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27486: Correct class-template deprecation behavior

erichkeane updated this revision to Diff 84192. erichkeane added a comment. I've updated this patch based on some of Richard's suggestions, simplified my implementation, and added a few more tests. Currently the A and B notes are in the wrong place, but I was hoping someone could help me figure

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:810 +if (CE->getNumArgs() == 2) + State = ProcessZeroAllocation(C, CE, 1, State); } else if (CE->getNumArgs() == 3) { Why did you remove the old beh

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

On Thu, Jan 12, 2017 at 3:01 PM, Chandler Carruth wrote: >> This isn't quite right, it should either be left as-is or dropped >> completely. This path was allowing people to spell "-mllvm >> -disable-llvm-optzns" for legacy reasons, even though the correct >> spelling is "-Xclang -disable-llvm-opt

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

tejohnson added a comment. In https://reviews.llvm.org/D28588#644489, @danielcdh wrote: > Thanks for the prompt response. > > But looks like several other tests also has "-mllvm -debug-pass=Structure" in > their tests: > > tools/clang/test/CodeGen/pgo-instrumentation.c > test/CodeGen/Generic/ll

[PATCH] D26082: Support for Python 3 in libclang python bindings

MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#644402, @jbcoe wrote: > @MathieuDuponchelle I've set up a docker image with Fedora 23 and reproduced > the errors as you reported. > > I've no immediate idea what the problem might be. Might be worth looking with > address-s

Re: [clang-tools-extra] r291446 - [include-fixer] Load symbol index asynchronously.

On 01/10/2017 01:53 PM, Benjamin Kramer wrote: I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt help? That does seem to make it work. On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote: On 01/09/2017 09

r291853 - Fix two test cases I missed updating in r291850. Sorry for the noise.

Author: chandlerc Date: Thu Jan 12 16:48:28 2017 New Revision: 291853 URL: http://llvm.org/viewvc/llvm-project?rev=291853&view=rev Log: Fix two test cases I missed updating in r291850. Sorry for the noise. Modified: cfe/trunk/test/CodeGen/always_inline.c cfe/trunk/test/Profile/gcc-flag-co

r291851 - Replace some stray uses of the old spelling of the flag with the new

Author: chandlerc Date: Thu Jan 12 16:43:37 2017 New Revision: 291851 URL: http://llvm.org/viewvc/llvm-project?rev=291851&view=rev Log: Replace some stray uses of the old spelling of the flag with the new spelling. NFC. Modified: cfe/trunk/test/CodeGen/ms-declspecs.c cfe/trunk/test/CodeGe

r291850 - Address review comments on r290392:

Author: chandlerc Date: Thu Jan 12 16:40:13 2017 New Revision: 291850 URL: http://llvm.org/viewvc/llvm-project?rev=291850&view=rev Log: Address review comments on r290392: - Don't break using '-mllvm -disable-llvm-optzns' (yet). - Don't add support for '-mllvm -disable-llvm-passes'. This is impor

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

danielcdh added a comment. Thanks for the prompt response. But looks like several other tests also has "-mllvm -debug-pass=Structure" in their tests: tools/clang/test/CodeGen/pgo-instrumentation.c test/CodeGen/Generic/llc-start-stop.ll I just verified that if I cmake with -DCMAKE_BUILD_TYPE=Re

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

tejohnson added a comment. In https://reviews.llvm.org/D28588#644472, @tejohnson wrote: > Otherwise I think "; REQUIRES: asserts" might do the trick? Looks like it - I looked at another test that used -debug output and it requires asserts. https://reviews.llvm.org/D28588 _

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

tejohnson added a comment. In https://reviews.llvm.org/D28588#644467, @danielcdh wrote: > The breaks some buildbots thus I reverted the patch: > > http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1889 > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_ch

[libcxx] r291845 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:13:09 2017 New Revision: 291845 URL: http://llvm.org/viewvc/llvm-project?rev=291845&view=rev Log: Drop 'svn' suffix from version. Modified: libcxx/branches/release_40/CMakeLists.txt Modified: libcxx/branches/release_40/CMakeLists.txt URL: http://llvm.org/vie

[libunwind] r291846 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:13:19 2017 New Revision: 291846 URL: http://llvm.org/viewvc/llvm-project?rev=291846&view=rev Log: Drop 'svn' suffix from version. Modified: libunwind/branches/release_40/CMakeLists.txt Modified: libunwind/branches/release_40/CMakeLists.txt URL: http://llvm.o

[libcxxabi] r291844 - Drop 'svn' suffix from version.

Author: hans Date: Thu Jan 12 16:12:54 2017 New Revision: 291844 URL: http://llvm.org/viewvc/llvm-project?rev=291844&view=rev Log: Drop 'svn' suffix from version. Modified: libcxxabi/branches/release_40/CMakeLists.txt Modified: libcxxabi/branches/release_40/CMakeLists.txt URL: http://llvm.o

[PATCH] D28588: Pass -fprofile-sample-use to lto backends.

danielcdh reopened this revision. danielcdh added a comment. This revision is now accepted and ready to land. The breaks some buildbots thus I reverted the patch: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/1889 http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incr

[clang-tools-extra] r291838 - Clear the release notes for 5.0.0

Author: hans Date: Thu Jan 12 15:58:40 2017 New Revision: 291838 URL: http://llvm.org/viewvc/llvm-project?rev=291838&view=rev Log: Clear the release notes for 5.0.0 Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: http://ll

r291837 - Clear the release notes for 5.0.0

Author: hans Date: Thu Jan 12 15:55:16 2017 New Revision: 291837 URL: http://llvm.org/viewvc/llvm-project?rev=291837&view=rev Log: Clear the release notes for 5.0.0 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/c

[clang-tools-extra] r291832 - Update docs/conf.py version

Author: hans Date: Thu Jan 12 15:42:38 2017 New Revision: 291832 URL: http://llvm.org/viewvc/llvm-project?rev=291832&view=rev Log: Update docs/conf.py version Modified: clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/trunk/docs/conf.py URL: http://llvm.org/viewvc/llvm-proje

r291831 - Update docs/conf.py version

Author: hans Date: Thu Jan 12 15:41:38 2017 New Revision: 291831 URL: http://llvm.org/viewvc/llvm-project?rev=291831&view=rev Log: Update docs/conf.py version Modified: cfe/trunk/docs/analyzer/conf.py cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/analyzer/conf.py URL: http://llvm.org/

[libunwind] r291830 - Bump version to 5.0.0svn

Author: hans Date: Thu Jan 12 15:37:55 2017 New Revision: 291830 URL: http://llvm.org/viewvc/llvm-project?rev=291830&view=rev Log: Bump version to 5.0.0svn Modified: libunwind/trunk/CMakeLists.txt Modified: libunwind/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libunwind/tr

[libcxxabi] r291829 - Bump version to 5.0.0svn

Author: hans Date: Thu Jan 12 15:36:22 2017 New Revision: 291829 URL: http://llvm.org/viewvc/llvm-project?rev=291829&view=rev Log: Bump version to 5.0.0svn Modified: libcxxabi/trunk/CMakeLists.txt Modified: libcxxabi/trunk/CMakeLists.txt URL: http://llvm.org/viewvc/llvm-project/libcxxabi/tr

[libunwind] r291827 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:26:18 2017 New Revision: 291827 URL: http://llvm.org/viewvc/llvm-project?rev=291827&view=rev Log: Creating release_40 branch off revision 291814 Added: libunwind/branches/release_40/ - copied from r291814, libunwind/trunk/ __

[libcxxabi] r291821 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:25:46 2017 New Revision: 291821 URL: http://llvm.org/viewvc/llvm-project?rev=291821&view=rev Log: Creating release_40 branch off revision 291814 Added: libcxxabi/branches/release_40/ - copied from r291814, libcxxabi/trunk/ __

[libcxx] r291820 - Creating release_40 branch off revision 291814

Author: hans Date: Thu Jan 12 15:25:41 2017 New Revision: 291820 URL: http://llvm.org/viewvc/llvm-project?rev=291820&view=rev Log: Creating release_40 branch off revision 291814 Added: libcxx/branches/release_40/ (props changed) - copied from r291814, libcxx/trunk/ Propchange: libcxx

r291814 - Add entry for -MJ.

Author: joerg Date: Thu Jan 12 15:11:55 2017 New Revision: 291814 URL: http://llvm.org/viewvc/llvm-project?rev=291814&view=rev Log: Add entry for -MJ. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/

[PATCH] D26082: Support for Python 3 in libclang python bindings

jbcoe added a comment. @MathieuDuponchelle I've set up a docker image with Fedora 23 and reproduced the errors as you reported. I've no immediate idea what the problem might be. Might be worth looking with address-sanitizer. Repository: rL LLVM https://reviews.llvm.org/D26082 __

r291807 - clang-format: Fix regression introduced by r291801.

Author: djasper Date: Thu Jan 12 14:06:28 2017 New Revision: 291807 URL: http://llvm.org/viewvc/llvm-project?rev=291807&view=rev Log: clang-format: Fix regression introduced by r291801. Uncovered by polly tests. Before: aa(aaa,

Re: [cfe-dev] Testcase for LLVM PR9350

On 1/6/2017 3:05 PM, Andrew Rogers wrote: Hi, This is a (tested!) patch to add checks that both pre-increment and pre-decrement don’t overflow, for both char and short integer types (since they’re both narrower than int), as per the problem fixed in PR9350. r291805. -Eli -- Employee o

Re: r290392 - Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'.

Chandler Carruth via cfe-commits writes: > Author: chandlerc > Date: Thu Dec 22 18:23:01 2016 > New Revision: 290392 > > URL: http://llvm.org/viewvc/llvm-project?rev=290392&view=rev > Log: > Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'. > > Much to my surprise, '-disable-llvm-op

r291805 - Add additional testcases for nsw markings on ++ and --.

Author: efriedma Date: Thu Jan 12 13:51:44 2017 New Revision: 291805 URL: http://llvm.org/viewvc/llvm-project?rev=291805&view=rev Log: Add additional testcases for nsw markings on ++ and --. clang has generated correct IR for char/short decrement since r126816, but we didn't have any test coverag

r291801 - clang-format: Treat braced lists like other complex parameters.

Author: djasper Date: Thu Jan 12 13:35:26 2017 New Revision: 291801 URL: http://llvm.org/viewvc/llvm-project?rev=291801&view=rev Log: clang-format: Treat braced lists like other complex parameters. Specifically, wrap before them if they are multi-line so that we don't create long hanging indents.

Re: r291783 - UsersManual.rst: Update clang-cl options list

Addressing this in r291798. On Thu, Jan 12, 2017 at 11:18 AM, Nico Weber via cfe-commits wrote: > Also, it looks like the main change is that this now lists > /execution-charset: and /source-charset:. It doesn't list /utf-8 though > (since that's just a CLIgnoredFlag behind the scenes I guess). I

r291798 - UsersManual.rst: Update clang-cl options list again

Author: hans Date: Thu Jan 12 13:26:54 2017 New Revision: 291798 URL: http://llvm.org/viewvc/llvm-project?rev=291798&view=rev Log: UsersManual.rst: Update clang-cl options list again This time, make ignored options, such as /utf-8, show up as well if they have help text. Also, since we're now ex

[PATCH] D27689: Module: hash the pcm content and use it as SIGNATURE for implicit modules.

manmanren added a comment. Bruno helped on collecting performance data for this patch: $ cat cocoa-test.h #import $ rm -rf tmp; clang -x objective-c -isysroot `xcrun --sdk macosx --show-sdk-path` -fblocks -fmodules -fmodules-cache-path=tmp cocoa-test.h -fsyntax-only clang-release (10 runs) --

[PATCH] D28614: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value

This revision was automatically updated to reflect the committed changes. Closed by commit rL291796: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D28614?vs=84135&id=84152#toc Repo

[clang-tools-extra] r291796 - [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value

Author: malcolm.parsons Date: Thu Jan 12 13:20:35 2017 New Revision: 291796 URL: http://llvm.org/viewvc/llvm-project?rev=291796&view=rev Log: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value Summary: rL270567 excluded trivially copyable types from being moved by mode

[PATCH] D28620: Guard __gnuc_va_list typedef

probinson created this revision. probinson added a reviewer: yaron.keren. probinson added a subscriber: cfe-commits. https://reviews.llvm.org/D28620 Files: lib/Headers/stdarg.h test/Headers/stdarg-gnuc_va_list.c Index: test/Headers/stdarg-gnuc_va_list.c =

r291794 - [Modules] Fix misleading warning about missing textual header in umbrella header

Author: bruno Date: Thu Jan 12 13:15:33 2017 New Revision: 291794 URL: http://llvm.org/viewvc/llvm-project?rev=291794&view=rev Log: [Modules] Fix misleading warning about missing textual header in umbrella header When a textual header is present inside a umbrella dir but not in the header, we get

Re: r291783 - UsersManual.rst: Update clang-cl options list

Also, it looks like the main change is that this now lists /execution-charset: and /source-charset:. It doesn't list /utf-8 though (since that's just a CLIgnoredFlag behind the scenes I guess). It's a bit weird to list the two -charset flags (which just check that their arg is utf-8 and error out i

Re: r291783 - UsersManual.rst: Update clang-cl options list

In r290990, Reid exposed that, and in particular the -fno variant for users who want to disable it. It seems the -fno variant doesn't show up because it has no help text :-/ On Thu, Jan 12, 2017 at 11:13 AM, Nico Weber via cfe-commits wrote: > Why do we list fdelayed-template-parsing in /? outpu

Re: r291783 - UsersManual.rst: Update clang-cl options list

Why do we list fdelayed-template-parsing in /? output now? That's on by default with clang-cl. On Thu, Jan 12, 2017 at 1:15 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Thu Jan 12 12:15:06 2017 > New Revision: 291783 > > URL: http://llvm.org/viewvc

r291783 - UsersManual.rst: Update clang-cl options list

Author: hans Date: Thu Jan 12 12:15:06 2017 New Revision: 291783 URL: http://llvm.org/viewvc/llvm-project?rev=291783&view=rev Log: UsersManual.rst: Update clang-cl options list Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc/llvm

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

yaxunl added a comment. > @yaxunl Sam, I think it would be nice to describe your recent change for > adding OpenCL extensions. Would you like to write up some text? Otherwise I > can draft something and you can review. :) Anastasia, I am busy with some other work. If you can add it I will be ha

[PATCH] D28602: [analyzer] Don't dereference the array bound to a reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291781: [analyzer] Don't dereference the array value when binding it to a reference. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D28602?vs=84097&id=84140#toc Repository:

r291781 - [analyzer] Don't dereference the array value when binding it to a reference.

Author: dergachev Date: Thu Jan 12 12:00:03 2017 New Revision: 291781 URL: http://llvm.org/viewvc/llvm-project?rev=291781&view=rev Log: [analyzer] Don't dereference the array value when binding it to a reference. This replaces the hack in r291754, which was fixing pr31592, which was caused by r29

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added a comment. Since everyone agreed on the core part of this documentation I have committed the current revision in 291780 to make it easier for the release. Feel free to give me more feedback (if any) as small changes can still be merged in. @yaxunl Sam, I think it would be nice

r291780 - [Docs][OpenCL] Added OpenCL feature description to Clang documentation.

Author: stulova Date: Thu Jan 12 11:52:22 2017 New Revision: 291780 URL: http://llvm.org/viewvc/llvm-project?rev=291780&view=rev Log: [Docs][OpenCL] Added OpenCL feature description to Clang documentation. Updated index and UsersManual with OpenCL description. Review: https://reviews.llvm.org/D2

[PATCH] D27773: [analyzer] Add checker modeling gtest APIs.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. This is done. https://reviews.llvm.org/D27773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D27090: Add LocationContext as a parameter to checkRegionChanges

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. This needs to be committed. https://reviews.llvm.org/D27090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D28606: Mention devirtualization in release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Can you write something about this option for UsersManual.rst too? Then we could make this note link to it. https://reviews.llvm.org/D28606 __

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren updated this revision to Diff 84137. manmanren added a comment. Addressing review comments. https://reviews.llvm.org/D28299 Files: include/clang/Basic/DiagnosticSerializationKinds.td include/clang/Basic/FileManager.h include/clang/Serialization/ASTReader.h include/clang/Serial

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia added inline comments. Comment at: docs/UsersManual.rst:2130 + +- x86 is used by some implementations that are x86 compatible + (e.g. `POCL `_) and currently remains for backwards pekka.jaaskelainen wrote: > Anastasia wrote: > >

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

Anastasia updated this revision to Diff 84136. Anastasia added a comment. Update based on comments from Pekka. https://reviews.llvm.org/D28080 Files: docs/UsersManual.rst www/index.html Index: docs/UsersManual.rst === --- docs

[PATCH] D28614: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value

madsravn added a comment. Looks good to me. https://reviews.llvm.org/D28614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28614: [clang-tidy] Fix check for trivially copyable types in modernize-pass-by-value

malcolm.parsons created this revision. malcolm.parsons added reviewers: madsravn, aaron.ballman, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. https://reviews.llvm.org/rL270567 excluded trivially copyable types from being moved by modernize-pass

r291775 - Revert r291774 which caused buildbot failure.

Author: dehao Date: Thu Jan 12 10:56:18 2017 New Revision: 291775 URL: http://llvm.org/viewvc/llvm-project?rev=291775&view=rev Log: Revert r291774 which caused buildbot failure. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp cfe/trunk/test/CodeGen/thinlto_backend.ll Modified: cfe/trunk/

r291774 - Pass -fprofile-sample-use to lto backends.

Author: dehao Date: Thu Jan 12 10:29:25 2017 New Revision: 291774 URL: http://llvm.org/viewvc/llvm-project?rev=291774&view=rev Log: Pass -fprofile-sample-use to lto backends. Summary: LTO backend will not invoke SampleProfileLoader pass even if -fprofile-sample-use is specified. This patch passe

[libcxx] r291773 - Add new macro _LIBCPP_BUILTIN_MEMCMP_ISCONSTEXPR to use in std::char_traits.

Author: marshall Date: Thu Jan 12 10:25:07 2017 New Revision: 291773 URL: http://llvm.org/viewvc/llvm-project?rev=291773&view=rev Log: Add new macro _LIBCPP_BUILTIN_MEMCMP_ISCONSTEXPR to use in std::char_traits. This tells whether or not the builtin function __builtin_memcmp is constexpr. Only de

[PATCH] D28610: [libcxx] Improve design documentation for the external-thread-library configuration

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. Trying to improve the documentation for the external-thread-library configuration of `libc++`. https://reviews.llvm.org/D28610 Files: docs/DesignDocs/ThreadingSupportAPI.r

[PATCH] D20428: Tracking exception specification source locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL291771: Tracking exception specification source locations (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D20428?vs=83816&id=84127#toc Repository: rL LLVM https://re

r291771 - Tracking exception specification source locations

Author: malcolm.parsons Date: Thu Jan 12 10:11:28 2017 New Revision: 291771 URL: http://llvm.org/viewvc/llvm-project?rev=291771&view=rev Log: Tracking exception specification source locations Summary: We do not currently track the source locations for exception specifications such that their sour

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons added inline comments. Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:26 + auto explicit_initialized_value_used = [j = 1] { return j + 1; }; + auto explicit_initialized_value_unused = [j = 1] {}; // expected-warning{{lambda capture 'j' is not used}} +

[PATCH] D28467: [Sema] Add warning for unused lambda captures

malcolm.parsons updated this revision to Diff 84122. malcolm.parsons marked 9 inline comments as done. malcolm.parsons added a comment. Improve warning message for use in unevaluated context. Initialise used flags in constructors. https://reviews.llvm.org/D28467 Files: include/clang/Basic/Dia

[PATCH] D26015: Correctly classify main file includes if there is a prefix added

alexfh added a comment. LG, committed as r291767. Repository: rL LLVM https://reviews.llvm.org/D26015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26015: Correctly classify main file includes if there is a prefix added

This revision was automatically updated to reflect the committed changes. Closed by commit rL291767: Correctly classify main file includes if there is a prefix added (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D26015?vs=84001&id=84121#toc Repository: rL LLVM http

[clang-tools-extra] r291767 - Correctly classify main file includes if there is a prefix added

Author: alexfh Date: Thu Jan 12 09:31:50 2017 New Revision: 291767 URL: http://llvm.org/viewvc/llvm-project?rev=291767&view=rev Log: Correctly classify main file includes if there is a prefix added Summary: Prevents misclassifying includes based on the command-line filename (e.g. if a project is

[PATCH] D20428: Tracking exception specification source locations

aaron.ballman added a comment. In https://reviews.llvm.org/D20428#644007, @hintonda wrote: > Sorry, but I do not have commit access. Ah! My apologies, I thought you did. @malcolm.parsons, can you perform the commit? I'm traveling currently and can't do it myself right now. https://reviews.l

  1   2   >