Author: klimek
Date: Wed Jan 11 01:20:46 2017
New Revision: 291653
URL: http://llvm.org/viewvc/llvm-project?rev=291653&view=rev
Log:
Only launch asynchronously if threading is enabled.
Modified:
clang-tools-extra/trunk/include-fixer/SymbolIndexManager.h
Modified: clang-tools-extra/trunk/incl
pekka.jaaskelainen requested changes to this revision.
pekka.jaaskelainen added a comment.
This revision now requires changes to proceed.
Great work.
Comment at: docs/UsersManual.rst:44
- :ref:`Objective C++ Language `
+- :ref:`OpenCL Language `: v1.0, v1.1, v1.2, v2.0.
--
dylanmckay added inline comments.
Comment at: include/clang/Basic/Attr.td:488
+
+def AVRSignal : InheritableAttr, TargetSpecificAttr {
+ let Spellings = [GNU<"signal">];
aaron.ballman wrote:
> Does this attribute appertain to any specific subjects, or can you ap
dylanmckay updated this revision to Diff 83913.
dylanmckay marked 2 inline comments as done.
dylanmckay added a comment.
[AVR] Document the 'interrupt' and 'naked' attributes
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/CodeGen/Tar
On Tue, Jan 10, 2017 at 5:59 PM, Richard Smith
wrote:
> On 10 January 2017 at 17:57, Richard Smith wrote:
>
>> On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: mren
>>> Date: Tue Jan 10 18:48:19 2017
>>> New Revision: 291628
>>>
>>> U
bruno closed this revision.
bruno added a comment.
Thanks for the review Richard.
Committed 291644
Comment at: lib/Lex/HeaderSearch.cpp:1082
+ auto TryEnterImported = [&](void) -> bool {
+if (!ModulesEnabled)
rsmith wrote:
> Maybe add a FIXME here indic
Author: bruno
Date: Tue Jan 10 20:14:51 2017
New Revision: 291644
URL: http://llvm.org/viewvc/llvm-project?rev=291644&view=rev
Log:
[Modules] Support #import when entering files with modules
Textual headers and builtins that are #import'd from different
modules should get re-entered when these mo
thakis added a comment.
Thanks! Can you add a test somewhere? `grep -R W.*uninitialized test/Sema*`
will probably show you the existing test for this code. (Another technique:
Comment some of the existing tests, run `ninja check-clang`, and see which
tests start failing.)
You can run an indiv
On 10 January 2017 at 17:57, Richard Smith wrote:
> On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: mren
>> Date: Tue Jan 10 18:48:19 2017
>> New Revision: 291628
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
>> Log:
On 10 January 2017 at 16:48, Manman Ren via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mren
> Date: Tue Jan 10 18:48:19 2017
> New Revision: 291628
>
> URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
> Log:
> Module: Do not create Implicit ImportDecl for module X if we
Quuxplusone added inline comments.
Comment at: test/SemaCXX/warn-unused-lambda-capture.cpp:17
+ auto explicit_by_value_unused = [i] {}; // expected-warning{{lambda capture
'i' is not used}}
+ auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; //
expected-warnin
lethalantidote created this revision.
lethalantidote added a reviewer: thakis.
lethalantidote added a subscriber: cfe-commits.
Elliminates uninitialized warning for volitile variables.
https://reviews.llvm.org/D28543
Files:
clang/lib/Sema/AnalysisBasedWarnings.cpp
Index: clang/lib/Sema/Anal
aaron.ballman added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:457
+/// lambda.
+bool Used = false;
+
arphaman wrote:
> malcolm.parsons wrote:
> > Should this be moved into one of the `PointerIntPair`s?
> I'm not sure.. If we needed other
Author: dcoughlin
Date: Tue Jan 10 19:02:34 2017
New Revision: 291635
URL: http://llvm.org/viewvc/llvm-project?rev=291635&view=rev
Log:
[analyzer] Fix crash in body farm for getter without implicit self.
Fix a crash in body farm when synthesizing a getter for a property
synthesized for a property
Author: phosek
Date: Tue Jan 10 18:56:10 2017
New Revision: 291632
URL: http://llvm.org/viewvc/llvm-project?rev=291632&view=rev
Log:
[CMake][libcxx] Do not rely on the existence of c++abi or unwind targets
There is no guaranteed order in which CMake files for individual
runtimes are invoked and t
aaron.ballman added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8
+The check converts dynamic exception specifications, e.g.,
+``throw()``, ``throw([,...])``, or ``throw(...)``, to
+``noexcept``, ``noexcept(false)``, blank, or a user defined m
kubabrecka added inline comments.
Comment at: libcxx/include/memory:3702
+inline T
+__libcpp_atomic_increment(T& t) _NOEXCEPT
+{
I don't think this should be named `__libcpp_atomic_increment`, because it uses
relaxed ordering and thus it's not a generic incremen
Hi Richard,
I fixed a regression caused by this commit in r291628.
Let me know if you see any problem!
Manman
> On Sep 1, 2016, at 1:15 PM, Richard Smith via cfe-commits
> wrote:
>
> Author: rsmith
> Date: Thu Sep 1 15:15:25 2016
> New Revision: 280409
>
> URL: http://llvm.org/viewvc/llvm-
Author: mren
Date: Tue Jan 10 18:48:19 2017
New Revision: 291628
URL: http://llvm.org/viewvc/llvm-project?rev=291628&view=rev
Log:
Module: Do not create Implicit ImportDecl for module X if we
are building an implemenation of module X.
This fixes a regression caused by r280409.
rdar://problem/299
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:6-8
+The check converts dynamic exception specifications, e.g.,
+``throw()``, ``throw([,...])``, or ``throw(...)``, to
+``noexcept``, ``noexcept(false)``, blank, or a user defined macro.
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir added inline comments.
Comment at: include/clang/Basic/FileManager.h:176
+ /// Manage memory buffers associated with pcm files.
+ std::unique_ptr BufferMgr;
+
manmanren wrote:
> benlangmuir wrote:
> > Why is this inside the FileManager? It isn't use
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99
+
+ assert(CRange.isValid() && "Exception Specification Range is invalid.");
+ assert(FnTy && "Functi
agutowski added a comment.
For my part, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D28503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Jan 10 17:04:46 2017
New Revision: 291610
URL: http://llvm.org/viewvc/llvm-project?rev=291610&view=rev
Log:
Remove dead code.
Modified:
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk/lib/Parse/Parser.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Par
Author: rsmith
Date: Tue Jan 10 16:59:18 2017
New Revision: 291608
URL: http://llvm.org/viewvc/llvm-project?rev=291608&view=rev
Log:
Remove a couple of parameters that are always false.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/Parser.cpp
Modified: cfe/trunk/in
probinson added a comment.
In https://reviews.llvm.org/D28404#641757, @chandlerc wrote:
> % ag OptimizeNone lib/Transforms/IPO
> lib/Transforms/IPO/ForceFunctionAttrs.cpp
> 47: .Case("optnone", Attribute::OptimizeNone)
This is implementing a debugging option, not skipping a pass.
>
Author: cryptoad
Date: Tue Jan 10 15:13:08 2017
New Revision: 291598
URL: http://llvm.org/viewvc/llvm-project?rev=291598&view=rev
Log:
[Driver] Add openSuse AArch64 Triple
Summary:
openSuse has AArch64 support, with images running on the Raspberry Pi 3.
The libraries and headers live under the aa
probinson added a comment.
I guess I'm getting irritated because people are trying to tell me what optnone
means. I know what it means; I spent probably a whole year pushing to get it
adopted.
Optnone means: When you are running optimizations, try not to optimize this
part, if you can.
That'
efriedma added a comment.
If there isn't already a LangOptions flag which reflects this, it probably
makes sense to add one.
https://reviews.llvm.org/D28526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
weimingz added a comment.
Hi Eli,
Thanks for the comments!
I though of implementation in Sema and I actually experimented a little bit.
Then it seemed that the CodeGenOpts is only available in the CGM. Any ideas?
https://reviews.llvm.org/D28526
_
hxy9243 marked an inline comment as done.
hxy9243 added a comment.
Addressed previous issues in the comments. The patch still shows consistent
perf uplift in proprietary benchmark on shared_ptr.
@EricWF @sebpop @hiraditya Any thoughts?
Repository:
rL LLVM
https://reviews.llvm.org/D24991
(explicitly adding Richard so he sees this discussion as some of this
involves a discussion between myself and him)
On Tue, Jan 10, 2017 at 4:36 PM Justin Bogner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Chandler Carruth via cfe-commits writes:
> > Author: chandlerc
> > Date: Fri De
cryptoad abandoned this revision.
cryptoad added a comment.
Nevermind, it seems to be working with empty files!
https://reviews.llvm.org/D28530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: rnk
Date: Tue Jan 10 15:27:03 2017
New Revision: 291600
URL: http://llvm.org/viewvc/llvm-project?rev=291600&view=rev
Log:
Serialize the UsesSEH bit on FunctionDecl
Fixes PR31539
Added:
cfe/trunk/test/PCH/uses-seh.cpp
Modified:
cfe/trunk/lib/Serialization/ASTReaderDecl.cpp
cfe
Chandler Carruth via cfe-commits writes:
> Author: chandlerc
> Date: Fri Dec 23 14:44:01 2016
> New Revision: 290450
>
> URL: http://llvm.org/viewvc/llvm-project?rev=290450&view=rev
> Log:
> [PM] Introduce options to enable the (still experimental) new pass
> manager, and a code path to use it.
>
cryptoad created this revision.
cryptoad added a reviewer: rengolin.
cryptoad added a subscriber: cfe-commits.
The binary files added as part of https://reviews.llvm.org/rL291598 seem to be
empty. Those are the actual files that should have been uploaded by arc.
https://reviews.llvm.org/D28530
cryptoad marked 4 inline comments as done.
cryptoad added a comment.
Thank you for the review Renato!
https://reviews.llvm.org/D28238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Tue Jan 10 14:52:50 2017
New Revision: 291597
URL: http://llvm.org/viewvc/llvm-project?rev=291597&view=rev
Log:
Don't try to check implicit conversion sequences for an object argument if
there is no object argument, when early checking of implicit conversion
sequences for a fu
Hello Benjamin,
It looks like this commit added warnings to the builder:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/3596
C:\Program Files (x86)\Microsoft Visual Studio
14.0\VC\INCLUDE\ppltasks.h(1531): warning C4530: C++ exception handler
used, but
efriedma requested changes to this revision.
efriedma added a reviewer: efriedma.
efriedma added a comment.
This revision now requires changes to proceed.
We really should be checking this much earlier.
IsGlobalLValue() in ExprConstant.cpp is the canonical place to answer the
question "is the ad
fowles added a subscriber: jdennett.
fowles added a comment.
@jdennett wanted this matcher for something he is working on and I had some
free cycles to write it up. Unfortunately, I am about to leave on an extended
vacation, so I will not be able to follow up with this patch for 2 months at
th
chandlerc added a comment.
In https://reviews.llvm.org/D28404#641696, @mehdi_amini wrote:
> In https://reviews.llvm.org/D28404#641632, @probinson wrote:
>
> > In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
> >
> > > If we want to support `-O0 -flto` and `optnone` it the way to con
mgorny created this revision.
mgorny added a reviewer: beanz.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Use the new llvm_canonicalize_cmake_booleans() function to canonicalize
booleans for lit tests. Replace the duplicate ENABLE_CLANG* variables
used to hold canoni
dim updated this revision to Diff 83851.
dim added a comment.
Let's try this simpler version instead.
https://reviews.llvm.org/D28520
Files:
include/__threading_support
Index: include/__threading_support
===
--- include/__threa
Author: rsmith
Date: Tue Jan 10 14:19:21 2017
New Revision: 291596
URL: http://llvm.org/viewvc/llvm-project?rev=291596&view=rev
Log:
Fix conversion index / argument index mismatch when diagnosing overload
resolution failure.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
cfe/trunk/test/Se
niravd added inline comments.
Comment at: include/clang/Driver/Options.td:1731
def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">,
Group;
+def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at
function entry">, Flags<[CC1Option]>, Group;
niravd updated this revision to Diff 83850.
niravd marked 2 inline comments as done.
niravd added a comment.
Address comments
https://reviews.llvm.org/D28001
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenFunction.cpp
lib/Driver/Tools
dim added a comment.
Hmm, actually this does not work. The definition of
`_LIBCPP_THREAD_SAFETY_ANNOTATION` I moved from `__mutex_base` to `__config` is
only enabled if `_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS` is manually defined.
There must have been some reason to do it like this in `__mut
yaxunl added inline comments.
Comment at: docs/UsersManual.rst:2003
+ $ clang -target nvptx64-unknown-unknown test.cl
+ $ clang -target amdgcn-unknown-amdhsa test.cl
+
$ clang -target amdgcn-amd-amdhsa-opencl test.cl
Comment at: docs/Us
jtony created this revision.
jtony added reviewers: nemanjai, kbarton, sfertile, lei, syzaara.
jtony added subscribers: llvm-commits, cfe-commits, hfinkel, echristo.
vec_rlnm was implemented according to the old ABI, which was wrong. The ABI
team have fixed the issue (although not published yet).
weimingz created this revision.
weimingz added reviewers: olista01, jmolloy.
weimingz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch adds diagnoses when initializing a global variable using the address
of another global variable that uses ROPI/RWPI reloc
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641632, @probinson wrote:
> In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
>
> > If we want to support `-O0 -flto` and `optnone` it the way to convey this
> > to the optimizer, I don't see the alternative.
>
>
> opts
Author: phosek
Date: Tue Jan 10 13:51:17 2017
New Revision: 291592
URL: http://llvm.org/viewvc/llvm-project?rev=291592&view=rev
Log:
[CMake][libcxx] Move Python check to main CMake file
This is to make sure this check is called even when building as
part of LLVM runtimes when we are doing standal
I didn't manage to reproduce this. Does adding ${PTHREAD_LIB} to
LINK_LIBS of tools/clang/tools/extra/include-fixer/plugin/CMakeLists.txt
help?
On Tue, Jan 10, 2017 at 8:31 PM, Bill Seurer wrote:
> On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote:
>>
>> Author: d0k
>> Date: Mon Jan
dim updated this revision to Diff 83843.
dim added a comment.
- Move `_LIBCPP_THREAD_SAFETY_ANNOTATION` macro definition to `__config`.
- Add `_LIBCPP_THREAD_SAFETY_ANNOTATION(no_thread_safety_analysis)` macros to
`__threading_support` function declarations which require them.
Note that I was no
probinson added a comment.
In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote:
> If we want to support `-O0 -flto` and `optnone` it the way to convey this to
> the optimizer, I don't see the alternative.
optsize != -Os (according to Chandler)
minsize != -Oz (according to Chandler)
o
amaiorano added a comment.
Last night, I realized that this problem extends to the clang/tests as well,
not just those in clang-tools-extra. Is there someone who knows Windows, Git,
and the testing pipeline that can weigh in more on this topic?
https://reviews.llvm.org/D28419
__
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641597, @probinson wrote:
> In https://reviews.llvm.org/D28404#641557, @mehdi_amini wrote:
>
> > As I stand right now, there hasn't been any correction.
> > I still consider the fact that `optnone` wouldn't produce the "same"
> >
probinson added a comment.
In https://reviews.llvm.org/D28404#641557, @mehdi_amini wrote:
> As I stand right now, there hasn't been any correction.
> I still consider the fact that `optnone` wouldn't produce the "same" result
> (modulo corner cases around `merging global variables` for instanc
On 01/09/2017 09:18 AM, Benjamin Kramer via cfe-commits wrote:
Author: d0k
Date: Mon Jan 9 09:18:28 2017
New Revision: 291446
URL: http://llvm.org/viewvc/llvm-project?rev=291446&view=rev
Log:
[include-fixer] Load symbol index asynchronously.
We don't actually need the index until parse time, s
EricWF added a comment.
In https://reviews.llvm.org/D28520#641569, @dim wrote:
> In https://reviews.llvm.org/D28520#641563, @EricWF wrote:
>
> > Also look in `__mutex` where libc++ defines its own macros for the
> > annotations.
>
>
> I assume you mean `__mutex_base`. Do we want to reuse the ma
dim added a comment.
In https://reviews.llvm.org/D28520#641563, @EricWF wrote:
> Also look in `__mutex` where libc++ defines its own macros for the
> annotations.
I assume you mean `__mutex_base`. Do we want to reuse the macros from that
file? If so we'd have to include it in `__thread_supp
EricWF added a comment.
Also look in `__mutex` where libc++ defines its own macros for the annotations.
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
sgilles marked an inline comment as done.
sgilles added a comment.
Ping - if there are no comments, could this be accepted?
https://reviews.llvm.org/D28148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
mehdi_amini added a comment.
In https://reviews.llvm.org/D28404#641538, @probinson wrote:
> > - optnone isn't *really* no optimizations: clearly this is true, but then
> > neither is -O0. We run the always inliner, a couple of other passes, and we
> > run several parts of the code generators op
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68
+ this);
+}
+
aaron.ballman wrote:
> hintonda wrote:
> > aaron.ballman wrote:
> > > Also missing: typedefs and using declarations.
> > As far as I know, it isn't legal t
Author: kli
Date: Tue Jan 10 12:57:07 2017
New Revision: 291583
URL: http://llvm.org/viewvc/llvm-project?rev=291583&view=rev
Log:
[OpenMP] Remove outdated comments. NFC.
Modified:
cfe/trunk/include/clang/Basic/OpenMPKinds.def
Modified: cfe/trunk/include/clang/Basic/OpenMPKinds.def
URL:
http
Author: mcrosier
Date: Tue Jan 10 12:55:11 2017
New Revision: 291582
URL: http://llvm.org/viewvc/llvm-project?rev=291582&view=rev
Log:
[ARM] Use generic bitreverse intrinsic, rather than ARM specific rbit.
The backend already supports lowering this intrinsic to a rbit instruction.
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291581: [analyzer] Treat pointers to static member functions
as function pointers (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D28033?vs=83828&id=83830#toc
Repository:
r
Author: dcoughlin
Date: Tue Jan 10 12:49:27 2017
New Revision: 291581
URL: http://llvm.org/viewvc/llvm-project?rev=291581&view=rev
Log:
[analyzer] Treat pointers to static member functions as function pointers
Sema treats pointers to static member functions as having function pointer
type, so tre
probinson added a comment.
In https://reviews.llvm.org/D28404#641078, @chandlerc wrote:
> For me, the arguments you're raising against -O0 and -flto don't hold up on
> closer inspection:
>
> - O0 != optnone: correct. But this is only visible in LTO. And in LTO, Os !=
> optsize, and Oz != minsiz
aaron.ballman added a comment.
In https://reviews.llvm.org/D28520#641536, @dim wrote:
> In https://reviews.llvm.org/D28520#641534, @aaron.ballman wrote:
>
> > Alternatively, these functions could be given the proper thread safety
> > annotations, couldn't they?
>
>
> Aha, I was not aware of the
dim added a comment.
In https://reviews.llvm.org/D28520#641534, @aaron.ballman wrote:
> Alternatively, these functions could be given the proper thread safety
> annotations, couldn't they?
Aha, I was not aware of the existence of these attributes. I'll take a look.
https://reviews.llvm.org/
aaron.ballman added a reviewer: delesley.
aaron.ballman added a comment.
Alternatively, these functions could be given the proper thread safety
annotations, couldn't they?
https://reviews.llvm.org/D28520
___
cfe-commits mailing list
cfe-commits@lis
Author: marshall
Date: Tue Jan 10 12:40:01 2017
New Revision: 291580
URL: http://llvm.org/viewvc/llvm-project?rev=291580&view=rev
Log:
Qualify some type names that I thought were fine, but some of the bots don't
like.
Modified:
libcxx/trunk/include/memory
Modified: libcxx/trunk/include/memo
KP updated this revision to Diff 83829.
KP added a comment.
Rename IsPointerOrReference to isPointerOrReference to comply with coding style
https://reviews.llvm.org/D27651
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
===
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:68
+ this);
+}
+
hintonda wrote:
> aaron.ballman wrote:
> > Also missing: typedefs and using declarations.
> As far as I know, it isn't legal to add dynamic exception
enyquist added a comment.
Well, your patch is here for me to try, and it looks like it's been accepted.
So I guess I should just pull my finger out and try it :)
Thanks for your response-- I'll let you know if I come across any issues.
https://reviews.llvm.org/D21279
dcoughlin updated this revision to Diff 83828.
dcoughlin added a comment.
Updating spacing, as @kromanenkov requested.
https://reviews.llvm.org/D28033
Files:
lib/StaticAnalyzer/Core/SValBuilder.cpp
test/Analysis/pointer-to-member.cpp
Index: test/Analysis/pointer-to-member.cpp
rnk added a comment.
In https://reviews.llvm.org/D28365#640868, @hamzasood wrote:
> Ha, good point. Does that include the environment stuff in Command too or
> just the linker?
Yes, please make the Command environment changes as part of a separate patch
with the linker environment changes.
hintonda updated this revision to Diff 83827.
hintonda marked an inline comment as done.
hintonda added a comment.
- Addressed comments.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexcept
dim created this revision.
dim added reviewers: EricWF, mclow.lists.
dim added subscribers: cfe-commits, emaste, joerg.
Many thread-related libc++ test cases fail on FreeBSD, due to the following
-Werror warnings:
In file included from
/share/dim/src/llvm/trunk/projects/libcxx/test/std/thread
Anastasia marked 4 inline comments as done.
Anastasia added a comment.
Ping! Any more comments here? It would be nice to commit this before the 4.0
rel branch is taken (on Jan 12).
https://reviews.llvm.org/D28080
___
cfe-commits mailing list
cfe-co
Anastasia updated this revision to Diff 83824.
Anastasia added a comment.
Updated with comments from Mats!
https://reviews.llvm.org/D28080
Files:
docs/UsersManual.rst
www/index.html
Index: www/index.html
===
--- www/index.html
hintonda marked 7 inline comments as done.
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:64
+ Finder->addMatcher(
+ parmVarDecl(hasType(pointerType(pointee(parenType(innerType(
+ functionProtoType(hasDynamicExcept
kkwli0 marked an inline comment as done.
kkwli0 added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:6444
+
+ CapturedStmt *CS = cast(AStmt);
+ // 1.2.2 OpenMP Language Terminology
ABataev wrote:
> auto *
Will do.
https://reviews.llvm.org/D28252
arphaman updated this revision to Diff 83822.
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D25213
Files:
lib/Sema/SemaExpr.cpp
test/Sema/PR28181.c
Index: test/Sema/PR28181.c
===
--- /dev/null
hiraditya added a comment.
Just for the record, I ported the patch to gcc/libstdc++ as well: PR66414
optimize std::string::find
https://github.com/gcc-mirror/gcc/commit/fc7ebc4b8d9ad7e2891b7f72152e8a2b7543cd65
Repository:
rL LLVM
https://reviews.llvm.org/D27068
__
arphaman added inline comments.
Comment at: lib/Analysis/ReachableCode.cpp:229
+ if (SilenceableCondValNotSet && SilenceableCondVal->getBegin().isValid())
+*SilenceableCondVal = UO->getSourceRange();
+ return UO->getOpcode() == UO_LNot && IsSubExprConfigValue;
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291576: CGDecl: Skip static variable initializers in
unreachable code (authored by matze).
Changed prior to commit:
https://reviews.llvm.org/D28505?vs=83754&id=83820#toc
Repository:
rL LLVM
https://
Author: matze
Date: Tue Jan 10 11:43:01 2017
New Revision: 291576
URL: http://llvm.org/viewvc/llvm-project?rev=291576&view=rev
Log:
CGDecl: Skip static variable initializers in unreachable code
This fixes http://llvm.org/PR31054
Differential Revision: https://reviews.llvm.org/D28505
Added:
arphaman updated this revision to Diff 83819.
arphaman added a comment.
Fix more issues with FIXIT for unary operators.
Repository:
rL LLVM
https://reviews.llvm.org/D28231
Files:
lib/Analysis/ReachableCode.cpp
lib/Sema/AnalysisBasedWarnings.cpp
test/Sema/warn-unreachable.c
Index: test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291574: [AArch64] Use generic bitreverse intrinsic, rather
than AArch64 specific. (authored by mcrosier).
Changed prior to commit:
https://reviews.llvm.org/D28400?vs=83367&id=83817#toc
Repository:
rL
Author: mcrosier
Date: Tue Jan 10 11:20:28 2017
New Revision: 291574
URL: http://llvm.org/viewvc/llvm-project?rev=291574&view=rev
Log:
[AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.
Differential Revision: https://reviews.llvm.org/D28400
Modified:
cfe/trunk/lib/Code
NoQ added a comment.
Thanks for working on the taint! I really wish the taint analysis in the
analyzer to flourish, and the part you've digged into is particularly
sensitive, so i'd dump some thoughts here, hopefully helpful.
**What works as it should: **
> In the second example, the SVal obta
Author: marshall
Date: Tue Jan 10 10:59:33 2017
New Revision: 291572
URL: http://llvm.org/viewvc/llvm-project?rev=291572&view=rev
Log:
Fix up some mismatched SFINAE conditionsin shared_ptr; some used '_Tp*', others
used 'element_type *'. Today, they're the same - but soon they won't be. No
funct
hintonda updated this revision to Diff 83816.
hintonda added a comment.
- Address comments.
https://reviews.llvm.org/D20428
Files:
include/clang/AST/Decl.h
include/clang/AST/TypeLoc.h
lib/AST/Decl.cpp
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaType.cpp
lib/Sema/TreeTransform.h
lib/Se
sbaranga accepted this revision.
sbaranga added a reviewer: sbaranga.
sbaranga added a comment.
This revision is now accepted and ready to land.
This looks straight-forward to me. LGTM.
-Silviu
https://reviews.llvm.org/D28400
___
cfe-commits mailin
aaron.ballman added a comment.
In https://reviews.llvm.org/D20428#641416, @hintonda wrote:
> Aaron, I've got this version in a branch, so if you like, I'd be happy to
> apply Malcolm's suggestions.
Please do; they're good suggestions.
https://reviews.llvm.org/D20428
__
1 - 100 of 144 matches
Mail list logo
