[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

Hahnfeld added a comment. Ping. Could I get comments before the branching this week? https://reviews.llvm.org/D26244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

Hahnfeld added a comment. Ping. Would this be ok to land before branching for 4.0 this week? https://reviews.llvm.org/D22452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20693: [clang-tidy] New checker to replace dynamic exception specifications

hintonda updated this revision to Diff 83588. hintonda added a comment. - Omit noexcept(false) replacement except for dtor and operator delete. https://reviews.llvm.org/D20693 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseN

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83587. xiangzhai added a comment. Hi Anna, Thanks for your review! I use: svn diff --diff-cmd=diff -x -U99 lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c > Glib-MallocChecker.patch to generate the patch, please check is it

r291425 - Implement DR1388 (wg21.link/cwg1388).

Author: rsmith Date: Mon Jan 9 01:14:40 2017 New Revision: 291425 URL: http://llvm.org/viewvc/llvm-project?rev=291425&view=rev Log: Implement DR1388 (wg21.link/cwg1388). This issue clarifies how deduction proceeds past a non-trailing function parameter pack. Essentially, the pack itself is skipp

Re: r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

On 8 January 2017 at 19:02, Faisal Vali via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: faisalv > Date: Sun Jan 8 21:02:53 2017 > New Revision: 291416 > > URL: http://llvm.org/viewvc/llvm-project?rev=291416&view=rev > Log: > [cxx1z-constexpr-lambda] Implement constant evaluation of

r291422 - Add release notes for `diagnose_if`

Author: gbiv Date: Sun Jan 8 23:58:18 2017 New Revision: 291422 URL: http://llvm.org/viewvc/llvm-project?rev=291422&view=rev Log: Add release notes for `diagnose_if` Bots seem happy with `diagnose_if` so far, so I'm optimistically adding release notes for it. Modified: cfe/trunk/docs/Releas

[PATCH] D27424: Add the diagnose_if attribute to clang.

george.burgess.iv added a comment. Thanks for the review! :) Repository: rL LLVM https://reviews.llvm.org/D27424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27424: Add the diagnose_if attribute to clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291418: Add the diagnose_if attribute to clang. (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D27424?vs=83412&id=83584#toc Repository: rL LLVM https://reviews.llvm.org/D27424

r291418 - Add the diagnose_if attribute to clang.

Author: gbiv Date: Sun Jan 8 22:12:14 2017 New Revision: 291418 URL: http://llvm.org/viewvc/llvm-project?rev=291418&view=rev Log: Add the diagnose_if attribute to clang. `diagnose_if` can be used to have clang emit either warnings or errors for function calls that meet user-specified conditions.

[PATCH] D28461: [clang] Enable using --section-ordering-file option of ld.gold

alexshap updated this revision to Diff 83582. alexshap added a comment. This revision is now accepted and ready to land. Address comments Repository: rL LLVM https://reviews.llvm.org/D28461 Files: CMakeLists.txt Index: CMakeLists.txt ==

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist created this revision. enyquist added reviewers: djasper, sylvestre.ledru. enyquist added a subscriber: cfe-commits. enyquist set the repository for this revision to rL LLVM. enyquist added a project: clang-c. Herald added a subscriber: klimek. This option behaves similarly to AlignConsec

[PATCH] D28461: [clang] Enable using --section-ordering-file option of ld.gold

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM Comment at: CMakeLists.txt:113 +check_linker_flag("-Wl,--section-ordering-file,${CLANG_ORDER_FILE}" + LINKER_ORDER_FILE_WORKS) + endif()

r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

Author: faisalv Date: Sun Jan 8 21:02:53 2017 New Revision: 291416 URL: http://llvm.org/viewvc/llvm-project?rev=291416&view=rev Log: [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions. Add a visitor for lambda expressions to RecordExprEvaluator in ExprCon

r291412 - Revert r291410 and r291411.

Author: rsmith Date: Sun Jan 8 19:18:18 2017 New Revision: 291412 URL: http://llvm.org/viewvc/llvm-project?rev=291412&view=rev Log: Revert r291410 and r291411. The test-suite bots are still failing even after r291410's fix. Modified: cfe/trunk/include/clang/Sema/Overload.h cfe/trunk/inc

r291411 - Fix test for targets whose preferred spelling for an 8-byte int is 'long long', not 'long'.

Author: rsmith Date: Sun Jan 8 19:10:14 2017 New Revision: 291411 URL: http://llvm.org/viewvc/llvm-project?rev=291411&view=rev Log: Fix test for targets whose preferred spelling for an 8-byte int is 'long long', not 'long'. Modified: cfe/trunk/test/SemaCXX/attr-mode-tmpl.cpp Modified: cfe/

r291410 - Implement C++ DR1391 (wg21.link/cwg1391)

Author: rsmith Date: Sun Jan 8 18:43:47 2017 New Revision: 291410 URL: http://llvm.org/viewvc/llvm-project?rev=291410&view=rev Log: Implement C++ DR1391 (wg21.link/cwg1391) Check for implicit conversion sequences for non-dependent function template parameters between deduction and substitution.

r291409 - [index] Introduce SymbolSubKind for reporting language-specific details.

Author: akirtzidis Date: Sun Jan 8 17:21:35 2017 New Revision: 291409 URL: http://llvm.org/viewvc/llvm-project?rev=291409&view=rev Log: [index] Introduce SymbolSubKind for reporting language-specific details. Initially reports if a constructor symbol is a copy or move constructor. Modified:

Re: [PATCH] Use the correct ObjC EH personality

Committed r291408. Thanks! On Sun, Jan 8, 2017 at 9:03 PM, Jonathan Schleifer via cfe-commits wrote: > Sorry, it seems the inline patch has been garbled. > > Trying as an attachment this time. > > > -- > Jonathan > > > ___ > cfe-commits mailing list > c

r291408 - Use the correct ObjC EH personality

Author: d0k Date: Sun Jan 8 16:58:07 2017 New Revision: 291408 URL: http://llvm.org/viewvc/llvm-project?rev=291408&view=rev Log: Use the correct ObjC EH personality This fixes ObjC exceptions on Win64 (which uses SEH), among others. Patch by Jonathan Schleifer! Modified: cfe/trunk/lib/Code

r291407 - PR31514: Add recursive self-instantiation check during template argument

Author: rsmith Date: Sun Jan 8 16:45:21 2017 New Revision: 291407 URL: http://llvm.org/viewvc/llvm-project?rev=291407&view=rev Log: PR31514: Add recursive self-instantiation check during template argument deduction in partial ordering. This prevents us from crashing due to attempting to instanti

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. This seems consistent with what GCC does. On x86 it also sets __GCC_ATOMIC_LLONG_LOCK_FREE to 2. https://reviews.llvm.org/D28213 ___ cfe

r291403 - PR30305: Implement proposed DR resolution to prevent slicing via inherited constructor.

Author: rsmith Date: Sun Jan 8 15:45:44 2017 New Revision: 291403 URL: http://llvm.org/viewvc/llvm-project?rev=291403&view=rev Log: PR30305: Implement proposed DR resolution to prevent slicing via inherited constructor. The rule we use is that a construction of a class type T from an argument o

[PATCH] D28018: AMD family 17h (znver1) enablement

GGanesh added inline comments. Comment at: lib/Basic/Targets.cpp:3189 break; + case CK_ZNVER1: +setFeatureEnabledImpl(Features, "adx", true); RKSimon wrote: > Same as what I asked on D28017 - is there an accepted order that we should be > using here? S

Re: [PATCH] Use the correct ObjC EH personality

Sorry, it seems the inline patch has been garbled. Trying as an attachment this time. 0001-Use-the-correct-ObjC-EH-personality.patch Description: Binary data -- Jonathan ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] Use the correct ObjC EH personality

Use the correct ObjC EH personality This fixes ObjC exceptions on Win64 (which uses SEH), among others. --- lib/CodeGen/CGCleanup.h | 2 ++ lib/CodeGen/CGException.cpp | 8 2 files changed, 10 insertions(+) diff --git a/lib/CodeGen/CGCleanup.h b/lib/CodeGen/CGCleanup.h index 2166490ec1

[PATCH] D18510: [cxx1z-constexpr-lambda] Make conversion function constexpr

faisalv abandoned this revision. faisalv added a comment. See richard's comment for why this attempt at implementing a compatibility warning for the constexpr conversion operator for lambda's is being abandoned. https://reviews.llvm.org/D18510 ___

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv accepted this revision. faisalv added a reviewer: faisalv. faisalv added a comment. This revision is now accepted and ready to land. committed as https://reviews.llvm.org/rL291397 https://reviews.llvm.org/D22997 ___ cfe-commits mailing list

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv closed this revision. faisalv added a comment. Committed as https://reviews.llvm.org/rL291397 https://reviews.llvm.org/D22997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291397 - [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

Author: faisalv Date: Sun Jan 8 12:56:11 2017 New Revision: 291397 URL: http://llvm.org/viewvc/llvm-project?rev=291397&view=rev Log: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker. This patch has been sitting in rev

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added inline comments. Comment at: lib/Basic/Targets.cpp:3189 break; + case CK_ZNVER1: +setFeatureEnabledImpl(Features, "adx", true); Same as what I asked on D28017 - is there an accepted order that we should be using here? https://reviews.ll

[PATCH] D28018: AMD family 17h (znver1) enablement

GGanesh removed rL LLVM as the repository for this revision. GGanesh updated this revision to Diff 83566. GGanesh added a comment. The clzero builtins and feature addition will be handled separately in another patch. SSE4a and movbe are added to the ISA list. https://reviews.llvm.org/D28018 Fi

[PATCH] D28457: Add missing const qualifier to member function Decl::isLocalExternDecl()

firolino created this revision. firolino added a reviewer: rsmith. firolino added a subscriber: cfe-commits. This patch simply adds a const qualifier to the member function Decl::isLocalExternDecl(). https://reviews.llvm.org/D28457 Files: include/clang/AST/DeclBase.h Index: include/clang/A

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood added a comment. In https://reviews.llvm.org/D28365#639260, @awson wrote: > It's weird th[[ URL | name ]]at cl.exe command-line compiler reports version > 19.10.24629 and lives in the 14.10.24629 directory (only first 2 digits are > different). > > Moreover, in their explanation blogp

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

awson added a comment. It's weird that cl.exe command-line compiler reports version 19.10.24629 and lives in the 14.10.24629 directory (only first 2 digits are different). Moreover, in their explanation blogpost

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood updated this revision to Diff 83555. hamzasood added a comment. - Added an option to set the environment in a clang::driver::Command, which makes the environment modifying introduced in the last update a bit more reliable. @rnk I looked into using the new MSVC toolchain layout to get

[PATCH] D24688: Introduce "hosted" module flag.

hfinkel added a comment. In https://reviews.llvm.org/D24688#639158, @jyknight wrote: > Since this requires everyone generating llvm IR to add this module attribute > for optimal codegen, it should be documented in release notes and the > LangRef, I think. And, for something like this, here:

[PATCH] D28289: Fix tests with CLANG_DEFAULT_LINKER

This revision was automatically updated to reflect the committed changes. Closed by commit rL291389: Fix tests with CLANG_DEFAULT_LINKER (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D28289?vs=83036&id=83553#toc Repository: rL LLVM https://reviews.llvm.org/D28289

r291389 - Fix tests with CLANG_DEFAULT_LINKER

Author: hahnfeld Date: Sun Jan 8 04:04:07 2017 New Revision: 291389 URL: http://llvm.org/viewvc/llvm-project?rev=291389&view=rev Log: Fix tests with CLANG_DEFAULT_LINKER I originally requested this to be tested in D25263 but in the end forgot to make sure that it was done. Differential Revision