jtony added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:800
- void makeLargest(bool Neg) { getIEEE().makeLargest(Neg); }
+ void makeLargest(bool Neg) {
+if (usesLayout(getSemantics())) {
I know it is allowed to return a void function call
FTR,
buildbot logs:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/2585/steps/test%20tsan%20in%20debug%20compiler-rt%20build/logs/stdio
External project cmake error log:
CMake Error at include/CMakeLists.txt:15 (file):
file COPY cannot make directory "/include/c++/v1
Hi,
this is using LLVM_BINARY_DIR when NOT LIBCXX_USING_INSTALLED_LLVM.
HandleOutOfTreeLLVM.cmake defines LLVM_BINARY_DIR only when
LIBCXX_USING_INSTALLED_LLVM. Is it supposed to come from the user
cmake arguments?
This broke sanitizer tests on Linux (check-tsan, check-msan). See
add_custom_libc
Author: akirtzidis
Date: Fri Dec 16 19:09:40 2016
New Revision: 290025
URL: http://llvm.org/viewvc/llvm-project?rev=290025&view=rev
Log:
[libclang] Remove the 'extern "C"' blocks from the implementation files.
These are unnecessary, the declarations already carry the 'extern C' property,
and if
Author: dcoughlin
Date: Fri Dec 16 19:08:17 2016
New Revision: 290023
URL: http://llvm.org/viewvc/llvm-project?rev=290023&view=rev
Log:
[analyzer] UnixAPIChecker: Don't diagnose for functions in C++ namespaces
Update the UnixAPIChecker to not diagnose for calls to functions that
are declared in C
rsmith added a comment.
I like moving `Idx` into the reader, but I have mixed feelings about the
iterator-like interface. For consistency with the rest of the `ASTRecordReader`
interface, and with how we model the writer side, I think perhaps
`Record.ReadInt()` would fit better than using `*Rec
Yes, I see, thanks Reid!
I’d just remove the 'extern "C” {‘ from the cpp file, which is not really
necessary, I’ll do it in a subsequent commit anyway.
> On Dec 16, 2016, at 4:48 PM, Yung, Douglas wrote:
>
> I think Reid already fixed the problem in r290009.
>
> Douglas Yung
>
>> -Origin
Looking into..
> On Dec 16, 2016, at 3:13 PM, Yung, Douglas wrote:
>
> Hi, this change seems to be causing the PS4 Windows build bot to be red, can
> you take a look?
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/2784
>
> C:\PROGRA~2\MICROS~1.0\
ahatanak added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:773
+ return U.IEEE.makeZero(Neg);
+} else if (usesLayout(getSemantics())) {
+ return U.Double.makeZero(Neg);
You don't need else after return.
https://reviews.llvm.org/D2
timshen created this revision.
timshen added reviewers: hfinkel, kbarton, iteratee, echristo.
timshen added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: nemanjai, mehdi_amini.
This patch changes the layout of DoubleAPFloat, and adjust all
operations to do either:
1. (IEEEdoub
Hello everyone,
LLVM buildmaster will be updated and restarted after 5 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tigerleapgorge updated this revision to Diff 81817.
tigerleapgorge added a comment.
Previous update contain typos in the RUN lines of
test/SemaCXX/virtual-base-used.cpp
This has been corrected in this latest revision.
https://reviews.llvm.org/D21626
Files:
test/Modules/Inputs/merge-using-dec
tigerleapgorge updated this revision to Diff 81810.
tigerleapgorge added a comment.
Update patch to match latest Clang C++11 diagnostics.
2 tests are changed.
test/SemaCXX/PR9572.cpp
Expect the following additional Note following existing Error.
destructor of 'Foo' is implicitly deleted b
Author: rnk
Date: Fri Dec 16 17:44:44 2016
New Revision: 290009
URL: http://llvm.org/viewvc/llvm-project?rev=290009&view=rev
Log:
Fix MSVC build of libclang after r288438
Modified:
cfe/trunk/tools/libclang/CXType.cpp
Modified: cfe/trunk/tools/libclang/CXType.cpp
URL:
http://llvm.org/viewvc/
Author: spyffe
Date: Fri Dec 16 17:45:03 2016
New Revision: 290010
URL: http://llvm.org/viewvc/llvm-project?rev=290010&view=rev
Log:
Added clangLex to the dependencies for clang-import-test.
This is part of the effort to get the i686-mingw32-RA-on-linux bot to like
clang-import-test.
Modified:
Author: pcc
Date: Fri Dec 16 17:43:51 2016
New Revision: 290008
URL: http://llvm.org/viewvc/llvm-project?rev=290008&view=rev
Log:
Add explicit triple to test to fix arm bots.
Modified:
cfe/trunk/test/CodeGen/dbg-const-int128.c
Modified: cfe/trunk/test/CodeGen/dbg-const-int128.c
URL:
http://
Author: spyffe
Date: Fri Dec 16 17:34:16 2016
New Revision: 290006
URL: http://llvm.org/viewvc/llvm-project?rev=290006&view=rev
Log:
Fixed library dependencies on clang-import-test to clean up the bots.
Modified:
cfe/trunk/tools/clang-import-test/CMakeLists.txt
Modified: cfe/trunk/tools/clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290004: Testbed and skeleton of a new expression parser
(authored by spyffe).
Changed prior to commit:
https://reviews.llvm.org/D27180?vs=81803&id=81807#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: spyffe
Date: Fri Dec 16 17:21:38 2016
New Revision: 290004
URL: http://llvm.org/viewvc/llvm-project?rev=290004&view=rev
Log:
Testbed and skeleton of a new expression parser
LLVM's JIT is now the foundation of dynamic-compilation features for many
languages. Clang also has low-level suppo
spyffe updated this revision to Diff 81803.
spyffe added a comment.
Updated CMakeFiles to fix dependencies.
- Fixed dependencies on `gen_intrinsics`
- Added a testsuite dependency on clang-import-test
Repository:
rL LLVM
https://reviews.llvm.org/D27180
Files:
test/CMakeLists.txt
test/Im
Hi, this change seems to be causing the PS4 Windows build bot to be red, can
you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/2784
C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP -DCLANG_ENABLE_ARCMT
-DCLANG_ENABLE_OBJC_REWRITER
rnk added a comment.
In https://reviews.llvm.org/D27858#625367, @thakis wrote:
> Did you measure what this does to link times?
I've measured now, and it's pretty bad. Times to link blink_core increase by
39% with -fstandalone-debug (211s -> 294s). I still think it's what we should
do by defau
https://developer.apple.com/library/content/releasenotes/General/CarbonCoreDeprecations/index.html#//apple_ref/doc/uid/TP40012224-CH1-SW16
explicitly suggests sysctl as replacement when targeting 10.8+, which
strongly suggests that it'll work.
On Fri, Dec 16, 2016 at 4:37 PM, Erik Pilkington via P
Won't that make is_win_fastlink builds slow to link? And if we do this,
then this change here makes a then-not-very-tested config the default.
(I don't have a problem with this patch, go ahead and land if you think
it's the way to go. Just wondering aloud.)
On Fri, Dec 16, 2016 at 4:39 PM, Reid K
jordan_rose updated this revision to Diff 81796.
jordan_rose added a comment.
Updated names to match LLVM style.
Repository:
rL LLVM
https://reviews.llvm.org/D27837
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaType.cpp
test/FixIt/Inputs/nullability.h
test/FixIt/null
This revert broke the build because you failed to resolve conflicts
in include/clang/Basic/OpenCLOptions.h caused by r289985. I've reverted
that file in r289997.
On Fri, Dec 16, 2016 at 1:23 PM, Yaxun Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: yaxunl
> Date: Fri Dec 16 15:
Author: rnk
Date: Fri Dec 16 16:11:28 2016
New Revision: 289997
URL: http://llvm.org/viewvc/llvm-project?rev=289997&view=rev
Log:
Really revert all changes from r289979. Apparently conflict resolution failed
Modified:
cfe/trunk/include/clang/Basic/OpenCLOptions.h
Modified: cfe/trunk/include/
Author: pcc
Date: Fri Dec 16 16:10:52 2016
New Revision: 289996
URL: http://llvm.org/viewvc/llvm-project?rev=289996&view=rev
Log:
IRGen: Fix assertion failure when creating debug info for an integer constant
wider than 64 bits.
Added:
cfe/trunk/test/CodeGen/dbg-const-int128.c
Modified:
c
Author: akirtzidis
Date: Fri Dec 16 15:40:16 2016
New Revision: 289995
URL: http://llvm.org/viewvc/llvm-project?rev=289995&view=rev
Log:
[libclang] Restore the CXXRecordDecl path for
clang_Type_getNumTemplateArguments and clang_Type_getTemplateArgumentAsType
Patch by Emilio Cobos Álvarez!
See ht
rnk added a comment.
In https://reviews.llvm.org/D27858#625367, @thakis wrote:
> Did you measure what this does to link times?
No, but I plan to recover it in Chromium by doing something like:
if (is_win && is_clang && !is_win_fastlink) {
cflags += ["-flimit-debug-info"]
}
https://re
erik.pilkington added a comment.
I seem to remember that mapping from kernel versions to marketing versions was
tossed around as a potential alternative to Gestalt. I think that the problem
was Apple sometimes introduces (or reserves the right to introduce) new SDKs in
a patch release (ie, Z in
Author: yaxunl
Date: Fri Dec 16 15:23:55 2016
New Revision: 289991
URL: http://llvm.org/viewvc/llvm-project?rev=289991&view=rev
Log:
Revert r289979 due to regressions
Removed:
cfe/trunk/test/CodeGenOpenCL/extension-begin.cl
cfe/trunk/test/SemaOpenCL/extension-begin.cl
Modified:
cfe/tr
Author: ahatanak
Date: Fri Dec 16 15:16:57 2016
New Revision: 289990
URL: http://llvm.org/viewvc/llvm-project?rev=289990&view=rev
Log:
[Sema] Transform the default arguments of a lambda expression when the
lambda expression is instantiated.
Rather than waiting until Sema::CheckCXXDefaultArgExpr t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289990: [Sema] Transform the default arguments of a lambda
expression when the (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D23096?vs=81171&id=81787#toc
Repository:
rL LL
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289989: [OpenMP] support the 'is_device_ptr' clause with
'target parallel' pragma (authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D27821?vs=81627&id=81785#toc
Repository:
rL LLVM
Author: kli
Date: Fri Dec 16 14:50:46 2016
New Revision: 289989
URL: http://llvm.org/viewvc/llvm-project?rev=289989&view=rev
Log:
[OpenMP] support the 'is_device_ptr' clause with 'target parallel' pragma
This patch is to add support of the 'is_device_ptr' clause in the 'target
parallel' pragma.
Quuxplusone added a comment.
The provided example (typoing "i" for "j") sounds like the sort of thing that
PVS-Studio catches; maybe see what wording they use for that kind of mistake?
Without investigating, I would suggest "cut-and-paste-error" or "likely-typo".
However, the attached patch *d
tigerleapgorge updated this revision to Diff 81784.
tigerleapgorge added a comment.
Forgot to include all context inside the previous revision.
Previous patch: svn diff
This patch:svn diff --diff-cmd=diff -x -U99
https://reviews.llvm.org/D20710
Files:
test/CodeGenCXX/debug-info-u
Author: ahatanak
Date: Fri Dec 16 14:25:11 2016
New Revision: 289986
URL: http://llvm.org/viewvc/llvm-project?rev=289986&view=rev
Log:
Remove the temporary fix to the RUN line that was committed in r289924.
Also, dump the AST and run FileCheck to make sure the expected nodes are
created in the AS
thakis added a comment.
Did you measure what this does to link times?
https://reviews.llvm.org/D27858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zturner
Date: Fri Dec 16 13:49:14 2016
New Revision: 289985
URL: http://llvm.org/viewvc/llvm-project?rev=289985&view=rev
Log:
Fix clang build
Modified:
cfe/trunk/include/clang/Basic/OpenCLOptions.h
Modified: cfe/trunk/include/clang/Basic/OpenCLOptions.h
URL:
http://llvm.org/viewvc/l
yaxunl added a comment.
In https://reviews.llvm.org/D27627#621533, @yaxunl wrote:
> In https://reviews.llvm.org/D27627#621473, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D27627#619928, @yaxunl wrote:
> >
> > > > Because, notably, if you do that, then an attempt to pass &x as an int*
> >
rnk created this revision.
rnk added reviewers: thakis, hans, dblaikie.
rnk added a subscriber: cfe-commits.
PDB-based debuggers do not support looking up type names across type
stream boundaries. There are two ways where users end up being unable to
look into variables with types that were requir
Author: adrian
Date: Fri Dec 16 13:39:18 2016
New Revision: 289984
URL: http://llvm.org/viewvc/llvm-project?rev=289984&view=rev
Log:
Revert "Update for LLVM global variable debug info API change."
This reverts commit r289921.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/lib/
ahatanak added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
-
This revision was automatically updated to reflect the committed changes.
yaxunl marked 2 inline comments as done.
Closed by commit rL289979: [OpenCL] Allow disabling types and declarations
associated with extensions (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D21698
Author: yaxunl
Date: Fri Dec 16 13:22:08 2016
New Revision: 289979
URL: http://llvm.org/viewvc/llvm-project?rev=289979&view=rev
Log:
[OpenCL] Allow disabling types and declarations associated with extensions
Added a map to associate types and declarations with extensions.
Refactored existing dia
Alpha updated this revision to Diff 81779.
Alpha added a comment.
It was tested against the clang extra unit tests, but not tests run with
check-clang-tools.
Updated Yaml test files to match the new format, this might need further review.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
Prazek added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+"std::mismatch; std::equal; std::search; std::cop
tigerleapgorge updated this revision to Diff 81776.
tigerleapgorge added a comment.
Lit C++11 compatibility patch #9
Update patch again to expect for latest Trunk C++11 diagnostics.
Tests in CXX directory are already passing in C++11, so they are removed from
this patch.
Of the remaining tests,
aaron.ballman added a comment.
In https://reviews.llvm.org/D27815#625271, @Prazek wrote:
> In https://reviews.llvm.org/D27815#625102, @aaron.ballman wrote:
>
> > I am really not keen on the name "obvious" for this module. What is obvious
> > to one person is not always obvious to another. Also,
Prazek marked an inline comment as done.
Prazek added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+"std::mi
Prazek added a comment.
In https://reviews.llvm.org/D27815#625102, @aaron.ballman wrote:
> I am really not keen on the name "obvious" for this module. What is obvious
> to one person is not always obvious to another. Also, if the checks are
> finding *obvious bugs*, then that suggests they shou
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289970: [analyzer] Fix crash in MallocChecker. (authored by
dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D27849?vs=81751&id=81774#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: dcoughlin
Date: Fri Dec 16 12:41:40 2016
New Revision: 289970
URL: http://llvm.org/viewvc/llvm-project?rev=289970&view=rev
Log:
[analyzer] Fix crash in MallocChecker.
Fix a crash in the MallocChecker when the extent size for the argument
to new[] is not known.
A patch by Abramo Bagnara a
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
In https://reviews.llvm.org/D21698#624967, @Anastasia wrote:
> LGTM! Small nitpicks below can be done before committing. Also it would be
> nice to double check the compile time is still fine after the last rebase.
Thanks. I did
Hi Eric,
> On Dec 2, 2016, at 3:01 AM, Eric Liu via cfe-commits
> wrote:
>
> Author: ioeric
> Date: Fri Dec 2 05:01:43 2016
> New Revision: 288493
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288493&view=rev
> Log:
> [ClangFormat] Only insert #include into the #include block in the beginn
zaks.anna added a comment.
And thank you for the awesome work and addressing the review comments!!!
https://reviews.llvm.org/D25660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
> I am doing it right now. Unfortunately I found a crash which I fixed,
Is it fixed in this patch?
> but then it turned out that overwrites of the iterator variable are not
> handled. I am working on this
> problem.
My suggestion is to commit this patch and address
Author: cbieneman
Date: Fri Dec 16 11:30:51 2016
New Revision: 289963
URL: http://llvm.org/viewvc/llvm-project?rev=289963&view=rev
Log:
[CMake] Put headers relative to clang
When libcxx isn't building with an installed LLVM we copy the libcxx headers
into the LLVM build directory so that a clang
khazem created this revision.
khazem added reviewers: dcoughlin, dergachev.a.
khazem added subscribers: cfe-commits, phosek, seanklein.
Herald added a subscriber: mgorny.
Acquiring a mutex during the Magenta kernel exception handler can cause
deadlocks and races. This patch adds a checker that en
graydon created this revision.
graydon added reviewers: manmanren, doug.gregor.
graydon added a subscriber: cfe-commits.
The module system supports accompanying a primary module (say Foo) with
an auxiliary "private" module (defined in an adjacent module.private.modulemap
file) that augments the pr
hokein updated this revision to Diff 81763.
hokein added a comment.
Update outdated comment.
https://reviews.llvm.org/D27673
Files:
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/HelperDeclRefGraph.cpp
clang-move/HelperDeclRefGraph.h
test/clang-
hokein added a comment.
Thanks for the awesome suggestions on the names. I refactored the patch, hope
it is clearer now.
Comment at: clang-move/UsedHelperDeclFinder.cpp:30
+ Result = FD;
+ if (const auto *RD = dyn_cast(FD->getParent()))
+Result = RD;
---
hokein updated this revision to Diff 81762.
hokein marked 3 inline comments as done.
hokein added a comment.
refactoring the patch.
https://reviews.llvm.org/D27673
Files:
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/HelperDeclRefGraph.cpp
clang-
aaron.ballman added a comment.
I am really not keen on the name "obvious" for this module. What is obvious to
one person is not always obvious to another. Also, if the checks are finding
*obvious bugs*, then that suggests they should be implemented in the clang
frontend rather than a tool that
jordan_rose added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
--
danielcdh updated this revision to Diff 81759.
danielcdh added a comment.
add a test.
https://reviews.llvm.org/D27832
Files:
lib/Driver/Tools.cpp
test/Driver/gold-lto-samplepgo.c
Index: test/Driver/gold-lto-samplepgo.c
===
--
Author: d0k
Date: Fri Dec 16 10:09:06 2016
New Revision: 289952
URL: http://llvm.org/viewvc/llvm-project?rev=289952&view=rev
Log:
[include-fixer] Desugar incomplete types.
This will look through typedefs so include-fixer will look up the target
of the typedef instead of the typedef itself (which
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! This is the way it is spelled in the C and C++ standards as well.
https://reviews.llvm.org/D26530
ahatanak added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8772
+def note_nullability_fix_it : Note<
+ "insert '%select{_Nonnull|_Nullable|_Null_unspecified}0' if the "
+ "%select{pointer|block pointer|member pointer|array parameter}1 "
-
Author: prakhar
Date: Thu Dec 15 01:59:24 2016
New Revision: 289786
URL: http://llvm.org/viewvc/llvm-project?rev=289786&view=rev
Log:
[ARM] Implement execute-only support in CodeGen
Summary:
This implements execute-only support for ARM code generation, which
prevents the compiler from generating
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:862
+def FormatDynamicKeyArg : InheritableAttr {
+ let Spellings = [GCC<"format_dynamic_key_arg">];
+ let Args = [IntArgument<"FormatIdx">];
Does GCC support this attribute as well? If
sbarzowski added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+"std::mismatch; std::equal; std::search; std:
arphaman added inline comments.
Comment at: include/clang/Driver/Options.td:1324
+ HelpText<"Use C++ undefined behaviour optimization for control flow paths"
+ "that reach the end of the function without executing a required return">;
+def fno_strict_return : Flag<["-"], "fn
sdardis added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8051
+ if (!LHSVecType) {
+assert(RHSVecType && "RHSVecType is not a vector!");
if (!tryVectorConvertAndSplat(*this, (IsCompAssign ? nullptr : &LHS),
bruno wrote:
> `tryVectorConvertAndSpl
arphaman added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:1078
+ QualType T = FD->getReturnType();
+ if (T.isTriviallyCopyableType(Context)) {
+// Avoid the optimization for functions that return trivially copyable
rjmccall wrote:
> arpham
sdardis updated this revision to Diff 81755.
sdardis marked an inline comment as done.
sdardis added a comment.
Addressed review comments, fixed assertion issue with expressions like scalar
-= vector.
https://reviews.llvm.org/D25866
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sem
arphaman added a comment.
In https://reviews.llvm.org/D27163#623811, @majnemer wrote:
> My 2 cents: If making this a target-specific default is not OK, why not turn
> on -fno-strict-return if -fapple-kext is specified? I believe that would
> cover the critical use case in question.
We've had
aaron.ballman added a comment.
I still think that this looks good, so if @rsmith doesn't comment over the
weekend, you can go ahead and commit on Monday -- we can handle any feedback in
post-commit review.
Comment at: include/clang/Basic/AttrDocs.td:240
+ Specifically, clang
cpplearner created this revision.
cpplearner added reviewers: mclow.lists, EricWF, howard.hinnant.
cpplearner added a subscriber: cfe-commits.
See https://github.com/cplusplus/draft/pull/839 and
https://github.com/cplusplus/fundamentals-ts/pull/73.
https://reviews.llvm.org/D27850
Files:
incl
aaron.ballman added a comment.
Modulo the comment from @ahatanak, I think this looks good. Once you have
addressed that comment, I can commit for you.
https://reviews.llvm.org/D26800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
ioeric added a comment.
Code is almost good. I'm just still a bit confused by names.
Comment at: clang-move/ClangMove.cpp:459
//
- auto InOldCCNamedOrGlobalNamespace =
- allOf(hasParent(decl(a
Anastasia added inline comments.
Comment at: test/SemaOpenCL/queue_t_overload.cl:10
+ foo(0, src2);
+ foo(q, src3); // expected-error {{call to 'foo' is ambiguous}}
+}
could we also add something non-convertible for queue i.e.
foo(1, src3);
https://reviews.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Small nitpicks below can be done before committing. Also it would be nice
to double check the compile time is still fine after the last rebase.
Thanks!
Comment
echuraev updated this revision to Diff 81742.
echuraev marked 3 inline comments as done.
https://reviews.llvm.org/D27569
Files:
include/clang/AST/OperationKinds.def
include/clang/Sema/Initialization.h
include/clang/Sema/Overload.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprAgg.cpp
lib
djasper added a comment.
Yes.. return non-zero seems right. This is an error condition.
https://reviews.llvm.org/D27440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:492
+ isDefinition(), unless(InMovedClass), InOldCC,
+ anyOf(isStaticStorageClass(), hasParent(namespaceDecl(isAnonymous();
+ auto HelperFuncOrVar = namedDecl(anyOf(functionDecl(IsOldCCHelperDefinit
hokein updated this revision to Diff 81741.
hokein marked 15 inline comments as done.
hokein added a comment.
- address code review comments
- add more tests
https://reviews.llvm.org/D27673
Files:
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/Use
baloghadamsoftware added a comment.
In https://reviews.llvm.org/D25660#613519, @zaks.anna wrote:
> Also, have you evaluated this on real codebases? What results do you see? Are
> there any false positives found? Are there any true positives found?
I am doing it right now. Unfortunately I found
amaiorano added a comment.
In https://reviews.llvm.org/D27440#624773, @djasper wrote:
> I agree that fallback-style should only be used when there is no
> .clang-format file. If we find one, and it doesn't parse correctly, we should
> neither use the fallback style nor scan in higher-level dire
Prazek marked 2 inline comments as done.
Prazek added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+"std::mi
ABataev added a comment.
LG for OpenMP part
https://reviews.llvm.org/D27794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289939: [analyzer] Add another exception for Qt in
MallocChecker (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D27717?vs=81239&id=81738#toc
Repository:
rL LLVM
https://r
Author: dergachev
Date: Fri Dec 16 06:21:55 2016
New Revision: 289939
URL: http://llvm.org/viewvc/llvm-project?rev=289939&view=rev
Log:
[analyzer] Add another exception for Qt in MallocChecker
Treat pointers passed to QObject::connectImpl() as escaping.
rdar://problem/29550440
Differential Revi
torokati44 added a comment.
I see this has been reverted in r281612, but I can no longer access the build
log serving as a reason linked in the message:
https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg35386.html
We have a few false-positive warnings that (I think) would be silenced by
mnbvmar marked 9 inline comments as done.
mnbvmar added inline comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:18
using namespace clang::ast_matchers;
+using namespace clang::tidy::utils;
+
mboehme wrote:
> Prazek wrote:
> > Prazek wrote:
> > > I don
mnbvmar updated this revision to Diff 81732.
mnbvmar marked 2 inline comments as done.
mnbvmar added a comment.
Minor changes, according to the request.
https://reviews.llvm.org/D27700
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tidy/utils/CMakeLists.txt
clang-tidy/utils/ExprSequen
firolino updated this revision to Diff 81731.
firolino added a comment.
further cleanup in getUserWrittenType
https://reviews.llvm.org/D27621
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/OneNamePerDeclarationCheck.cpp
clang-tidy/readability/OneNamePerDeclarationChec
1 - 100 of 111 matches
Mail list logo
