EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D27269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Random thought: It would be nice for C++ to have a
`non_truncating_cast(value)` which generated an error when the conversion
performs a truncation. This seems like the behavior we want
EricWF added a comment.
LGTM.
Feel free to address the inline comments or not.
Comment at:
test/std/containers/sequences/deque/deque.capacity/access.pass.cpp:55
std::deque c = make >(10);
for (unsigned i = 0; i < 10; ++i)
+assert(c[i] == static_c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
I may have considered doing the cast to `ptrdiff_t` for the other operand
instead of the `size_t` cast, but IDK which is better.
https://reviews.llvm.org/D27022
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D27021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
NoQ accepted this revision.
NoQ added a comment.
Thanks, i love dumps! Btw, did you encounter cases when types are unobvious
from the parent region?
Comment at: lib/StaticAnalyzer/Core/SymbolManager.cpp:89
+ os << "reg_$" << getSymbolID()
+ << "<" << getType().getAsString
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM nix inline comments. Please fix `MemCounter` to use `size_t` instead.
Comment at: test/support/count_new.hpp:62
int delete_called;
int last_new_size;
---
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Have you tested this against GCC which has different noexcept semantics?
If so this LGTM minus possibly addressing the inline comments.
Comment at: test/libcxx/strings/itera
zaks.anna added a comment.
It's awesome to see that all the major issues have been addressed. Thank you
for working on this and diligently working through the code review!!!
I have a few minor comments below.
Could you add this example yours as a "no-warning" test case:
const auto start = v.beg
EricWF added a comment.
FYI there is a relevent GCC bug here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71537
https://reviews.llvm.org/D26896
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Hello,
I have two patches for clang-format-vsix to offer up for review:
0001-clang-format-vsix-versioning.patch
clang-format-vsix: add a date stamp to the VSIX version number to ensure
upgradability
Presently, the version number of the VSIX matches the LLVM version number.
However, as this numbe
EricWF updated this revision to Diff 80168.
EricWF added a comment.
- Add unit tests as requested.
This patch is ready to go. If there are no objections in the next day or two
I'll commit it.
https://reviews.llvm.org/D27005
Files:
utils/lit/lit/TestRunner.py
utils/lit/tests/Inputs/testrun
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sym).In
Author: ericwf
Date: Fri Dec 2 21:29:45 2016
New Revision: 288576
URL: http://llvm.org/viewvc/llvm-project?rev=288576&view=rev
Log:
Turn off testsuite warnings by default with GCC
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http:
Author: ericwf
Date: Fri Dec 2 21:22:11 2016
New Revision: 288575
URL: http://llvm.org/viewvc/llvm-project?rev=288575&view=rev
Log:
Make make_exception_ptr abort with -fno-exceptions
Modified:
libcxx/trunk/include/exception
Modified: libcxx/trunk/include/exception
URL:
http://llvm.org/view
Author: ericwf
Date: Fri Dec 2 20:47:40 2016
New Revision: 288574
URL: http://llvm.org/viewvc/llvm-project?rev=288574&view=rev
Log:
Mark various items as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: ericwf
Date: Fri Dec 2 20:26:28 2016
New Revision: 288573
URL: http://llvm.org/viewvc/llvm-project?rev=288573&view=rev
Log:
Work around more -Wshadow warnings
Modified:
libcxx/trunk/test/libcxx/containers/sequences/vector/asan_throw.pass.cpp
libcxx/trunk/test/std/algorithms/alg.
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sy
Ack. Will do in future.
Thanks Hal
On Fri, Dec 2, 2016 at 3:54 PM, Hal Finkel wrote:
> - Original Message -
> > From: "Eric Fiselier via cfe-commits"
> > To: cfe-commits@lists.llvm.org
> > Sent: Friday, December 2, 2016 4:30:53 PM
> > Subject: [libcxx] r288544 - Work around a bug in Cl
Author: compnerd
Date: Fri Dec 2 19:57:47 2016
New Revision: 288570
URL: http://llvm.org/viewvc/llvm-project?rev=288570&view=rev
Log:
Sema: delay the DLL exported member referencing
An explicit template specialization can cause the implicit template
specialization of a type which inherits the at
Author: ericwf
Date: Fri Dec 2 19:58:07 2016
New Revision: 288571
URL: http://llvm.org/viewvc/llvm-project?rev=288571&view=rev
Log:
Fix w/o exception support
Modified:
libcxx/trunk/include/variant
Modified: libcxx/trunk/include/variant
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk
compnerd added a comment.
I think that the argument parsing should really be hoisted into the driver
rather than pushed down into the assembler. The driver can parse and validate
the options before passing them down, so when cc1as gets it, it will simply set
the value.
The newly introduced di
Author: ericwf
Date: Fri Dec 2 19:28:01 2016
New Revision: 288566
URL: http://llvm.org/viewvc/llvm-project?rev=288566&view=rev
Log:
Revert workaround for Clang bug. Thanks to Richard for the quick fix
Modified:
libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp
Modif
Author: ericwf
Date: Fri Dec 2 19:26:47 2016
New Revision: 288565
URL: http://llvm.org/viewvc/llvm-project?rev=288565&view=rev
Log:
[Sema] Don't perform aggregate initialization for types with explicit
constructors
Summary:
The C++17 rules for aggregate initialization changed to disallow types
Author: ericwf
Date: Fri Dec 2 19:21:40 2016
New Revision: 288564
URL: http://llvm.org/viewvc/llvm-project?rev=288564&view=rev
Log:
Fix -Wshadow warnings and enable warnings by default for C++ >= 11
Modified:
libcxx/trunk/include/forward_list
libcxx/trunk/test/libcxx/test/config.py
Modi
Author: rsmith
Date: Fri Dec 2 19:14:32 2016
New Revision: 288563
URL: http://llvm.org/viewvc/llvm-project?rev=288563&view=rev
Log:
DR616, and part of P0135R1: member access (or pointer-to-member access) on a
temporary produces an xvalue, not a prvalue. Support this by materializing the
temporary
srhines added a comment.
Looks good, but I I want to make sure that someone else more familiar with this
is ok with it too. Thanks.
https://reviews.llvm.org/D27377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
lhchavez created this revision.
lhchavez added a reviewer: djasper.
lhchavez added subscribers: srhines, cfe-commits.
Herald added a subscriber: klimek.
Java 8 introduced the use of using the 'default' keyword as modifier in
interface method declarations[1]. Previously it was being parsed as
being
Author: ericwf
Date: Fri Dec 2 18:33:03 2016
New Revision: 288559
URL: http://llvm.org/viewvc/llvm-project?rev=288559&view=rev
Log:
XFAIL variant tests for apple-clang
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
libcxx/trunk/test/li
Author: rsmith
Date: Fri Dec 2 18:29:06 2016
New Revision: 288558
URL: http://llvm.org/viewvc/llvm-project?rev=288558&view=rev
Log:
PR31244: Use the exception specification from the callee's type directly to
compute whether a call is noexcept, even if we can't map the callee expression
to a calle
Author: ericwf
Date: Fri Dec 2 18:27:13 2016
New Revision: 288557
URL: http://llvm.org/viewvc/llvm-project?rev=288557&view=rev
Log:
Enable warnings by default for C++ >= 11 and fix -Wshadow occurances
Modified:
libcxx/trunk/test/libcxx/test/config.py
libcxx/trunk/test/std/experimental/f
Author: ericwf
Date: Fri Dec 2 18:13:33 2016
New Revision: 288556
URL: http://llvm.org/viewvc/llvm-project?rev=288556&view=rev
Log:
Work around Clang 3.8 bugs
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
libcxx/trunk/test/libcxx/util
Author: ericwf
Date: Fri Dec 2 17:41:18 2016
New Revision: 288555
URL: http://llvm.org/viewvc/llvm-project?rev=288555&view=rev
Log:
Fix C++03 build
Modified:
libcxx/trunk/include/memory
libcxx/trunk/include/variant
Modified: libcxx/trunk/include/memory
URL:
http://llvm.org/viewvc/llvm-
Author: ericwf
Date: Fri Dec 2 17:38:31 2016
New Revision: 288554
URL: http://llvm.org/viewvc/llvm-project?rev=288554&view=rev
Log:
Make variant's index part of the hash value
Modified:
libcxx/trunk/include/memory
libcxx/trunk/include/variant
libcxx/trunk/src/experimental/filesystem/
Author: ericwf
Date: Fri Dec 2 17:17:33 2016
New Revision: 288552
URL: http://llvm.org/viewvc/llvm-project?rev=288552&view=rev
Log:
Fix generated warnings in
Modified:
libcxx/trunk/include/variant
Modified: libcxx/trunk/include/variant
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk
Author: ericwf
Date: Fri Dec 2 17:14:18 2016
New Revision: 288551
URL: http://llvm.org/viewvc/llvm-project?rev=288551&view=rev
Log:
Update darwin ABI list for
Modified:
libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.0.abilist
Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.0.0.abilist
U
Author: ericwf
Date: Fri Dec 2 17:11:28 2016
New Revision: 288550
URL: http://llvm.org/viewvc/llvm-project?rev=288550&view=rev
Log:
Update ABI lists for
Modified:
libcxx/trunk/lib/abi/CHANGELOG.TXT
libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.abilist
Modified: libcxx/trunk/lib/abi/CHA
Author: rsmith
Date: Fri Dec 2 17:00:28 2016
New Revision: 288548
URL: http://llvm.org/viewvc/llvm-project?rev=288548&view=rev
Log:
More diagnostic name fixups: w_ -> warn_, warning_ -> warn_, not_ -> note_.
In passing, add a warning group for "ignored qualifier in inline assembly"
warnings.
Mo
Author: compnerd
Date: Fri Dec 2 16:46:18 2016
New Revision: 288546
URL: http://llvm.org/viewvc/llvm-project?rev=288546&view=rev
Log:
CodeGen: export typeinfo and typeinfo name on itanium
When a C++ record is marked with dllexport mark both the typeinfo and the
typeinfo name as being exported.
- Original Message -
> From: "Eric Fiselier via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Friday, December 2, 2016 4:30:53 PM
> Subject: [libcxx] r288544 - Work around a bug in Clang's implementation of
> noexcept function types
>
> Author: ericwf
> Date: Fri Dec 2 16:30:52
Author: rsmith
Date: Fri Dec 2 16:38:31 2016
New Revision: 288545
URL: http://llvm.org/viewvc/llvm-project?rev=288545&view=rev
Log:
Mass-rename the handful of error_* diagnostics to err_*.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td
cfe/trunk/include/clang/Basic/Diagn
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:3250
+ /// This is true if this struct ends with an array marked 'flexible_array'.
+ bool HasFlexibleArrayAttr : 1;
+
How is this different from `HasFlexibleArrayMember`? Do we really need both?
ddcc created this revision.
ddcc added reviewers: NoQ, dcoughlin, zaks.anna.
ddcc added a subscriber: cfe-commits.
https://reviews.llvm.org/D27365
Files:
lib/StaticAnalyzer/Core/SymbolManager.cpp
test/Analysis/expr-inspection.c
Index: test/Analysis/expr-inspection.c
Author: ericwf
Date: Fri Dec 2 16:30:52 2016
New Revision: 288544
URL: http://llvm.org/viewvc/llvm-project?rev=288544&view=rev
Log:
Work around a bug in Clang's implementation of noexcept function types
Modified:
libcxx/trunk/test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp
Mod
hiraditya updated this revision to Diff 80134.
hiraditya added a comment.
Addressed Marshall's comments.
https://reviews.llvm.org/D27068
Files:
libcxx/benchmarks/string.bench.cpp
libcxx/include/__string
Index: libcxx/include/__string
Author: rsmith
Date: Fri Dec 2 16:14:59 2016
New Revision: 288543
URL: http://llvm.org/viewvc/llvm-project?rev=288543&view=rev
Log:
Check for SD-6 feature test macro when determining which tests should be
available, rather than #ifdef'ing away the relevant tests if it's unavailable.
Modified:
rengolin added inline comments.
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF:
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF:
"-L[[SYSROO
mgorny added inline comments.
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF:
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF:
"-L[[SYSROOT]
rsmith created this revision.
rsmith added a reviewer: EricWF.
rsmith added a subscriber: cfe-commits.
rsmith set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D27364
Files:
test/catch_function_03.pass.cpp
test/catch_member_function_pointer_02.pa
Updated version of patch attached with the changes you suggested. Let me
know if there's anything else you'd like.
On Tue, 29 Nov 2016 at 15:38 Hans Wennborg wrote:
> On Tue, Nov 29, 2016 at 12:01 PM, Antonio Maiorano
> wrote:
> > On Tue, 29 Nov 2016 at 13:42 Hans Wennborg wrote:
> >>
> >> Ver
Author: fhahn
Date: Thu Dec 1 05:02:59 2016
New Revision: 288327
URL: http://llvm.org/viewvc/llvm-project?rev=288327&view=rev
Log:
Fix crash with unsupported architectures in Linux/Gnu target triples.
Summary: This patch adds a check and an error message to
gnutools::Linker::ConstructJob in cas
On Tue, 29 Nov 2016 at 13:42 Hans Wennborg wrote:
> Very nice! I've tried this out and confirmed that the built plugin
> also works with older Visual Studio versions.
>
> Some comments below:
>
> > --- /dev/null
> > +++ b/tools/clang-format-vs/.gitignore
> > @@ -0,0 +1,11 @@
> > +# Visual Studio
I've attached a patch that works as discussed. When running CMake
with -DBUILD_CLANG_FORMAT_VS_PLUGIN=ON, it will look for nuget.exe in PATH,
or you can pass in DNUGET_EXE_PATH=C:\nuget, for e.g.
On Mon, 28 Nov 2016 at 14:31 Antonio Maiorano wrote:
> Great, I'll get this working soon and attach
Should be fixed in r288539.
On 2 December 2016 at 13:51, Richard Smith wrote:
> Looks like we need to wrap more of the test in the feature test macro.
>
> On 2 December 2016 at 13:42, Renato Golin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> It's been a while, and new patches are
Author: rsmith
Date: Fri Dec 2 15:43:36 2016
New Revision: 288539
URL: http://llvm.org/viewvc/llvm-project?rev=288539&view=rev
Log:
Fix up r288457 for compilers that don't support noexcept function types:
disable the test entirely for those cases. This is a quick patch, I'll look at
a proper feat
Looks like we need to wrap more of the test in the feature test macro.
On 2 December 2016 at 13:42, Renato Golin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> It's been a while, and new patches are coming. Should we just revert
> this for now?
>
> --renato
>
> On 2 December 2016 at 10:13
ddcc updated this revision to Diff 80129.
ddcc added a comment.
Rebase, move `assumeSymRel()` to RangedConstraintManager, make
`assumeSymUnsupported` pure virtual in SimpleConstraintManager.
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintMana
ddcc added inline comments.
Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459
// Notice that the lower bound is greater than the upper bound.
- RangeSet New = GetRange(St, Sym).Intersect(getBasicVals(), F, Upper, Lower);
+ RangeSet New = getRange(St, Sym).In
ddcc updated this revision to Diff 80128.
ddcc added a comment.
Un-change comments, misc. changes
https://reviews.llvm.org/D26691
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp
lib/StaticAnalyzer/Core/SimpleConstraintManager.h
It's been a while, and new patches are coming. Should we just revert
this for now?
--renato
On 2 December 2016 at 10:13, Renato Golin wrote:
> On 2 December 2016 at 02:06, Richard Smith via cfe-commits
> wrote:
>> Author: rsmith
>> Date: Thu Dec 1 20:06:53 2016
>> New Revision: 288457
>>
>> UR
Author: ericwf
Date: Fri Dec 2 15:32:35 2016
New Revision: 288538
URL: http://llvm.org/viewvc/llvm-project?rev=288538&view=rev
Log:
Fix copy/paste errors in new variant tests
Modified:
libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
libcxx/trunk/tes
Author: ericwf
Date: Fri Dec 2 15:17:51 2016
New Revision: 288536
URL: http://llvm.org/viewvc/llvm-project?rev=288536&view=rev
Log:
Add tests for libc++'s constexpr variant copy/move extension
Modified:
libcxx/trunk/test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp
rengolin added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.append(begin(ARMHFMuslTriples), end(AR
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.append(begin(ARMHFMuslTriples), end(ARMH
Author: gbiv
Date: Fri Dec 2 15:00:12 2016
New Revision: 288534
URL: http://llvm.org/viewvc/llvm-project?rev=288534&view=rev
Log:
[Sema] Reset a BumpPtrAllocator on clear(). NFC.
Looks like the reset() call was omitted by accident.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cf
thakis added a comment.
(Unrelated, but if you're looking at memory: When I was looking at it a while
ago, IIRC a surprising amount of memory was taken up by CXXBasePaths objects,
and just reordering fields to pack it better made that object several bytes
smaller. IIRC I accidentally reverted m
rengolin added a reviewer: compnerd.
rengolin added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.a
mgorny retitled this revision from "[Driver] Support "hardfloat" vendor triples
used by Gentoo" to "[Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi
triples".
mgorny updated the summary for this revision.
mgorny added a reviewer: atanasyan.
mgorny updated this revision to Diff 80118.
h
mgrang created this revision.
mgrang added reviewers: dgross, echristo, t.p.northover, rengolin, compnerd.
mgrang added subscribers: llvm-commits, cfe-commits.
mgrang added a project: clang-c.
Herald added a subscriber: mehdi_amini.
Related llvm patch: https://reviews.llvm.org/D27359
https://rev
hiraditya added inline comments.
Comment at: libcxx/include/__string:549
+// Stop short when source is smaller than pattern.
+ptrdiff_t __len2 = __last2 - __first2;
+if (__len2 == 0)
mclow.lists wrote:
> Is there a reason that you calculate the end po
jyu2 created this revision.
jyu2 added reviewers: cfe-commits, erichkeane, majnemer, rnk.
jyu2 set the repository for this revision to rL LLVM.
jyu2 added a project: clang-c.
The problem only happen on window ( A MSVC compatibility issues)
The nature of the problem is virtual base dtor called mor
majnemer updated this revision to Diff 80096.
majnemer added a comment.
- Simplify the mangling a little bit
https://reviews.llvm.org/D27226
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenCXX/mangle-ms-cxx11.cpp
Index: test/CodeGenCXX/mangle-ms-cxx11.cpp
===
mclow.lists added a comment.
This is starting to look good.
Comment at: libcxx/include/__string:549
+// Stop short when source is smaller than pattern.
+ptrdiff_t __len2 = __last2 - __first2;
+if (__len2 == 0)
Is there a reason that you calculate th
hiraditya updated this revision to Diff 80090.
hiraditya added a comment.
Addressed Tim's comments.
https://reviews.llvm.org/D27068
Files:
libcxx/benchmarks/string.bench.cpp
libcxx/include/__string
Index: libcxx/include/__string
=
bruno added a comment.
> The right thing to do would be to track the set of headers whose #import /
> #include-with-#pragma-once is
> visible, and only skip inclusions if there is a *visible* #import /
> #include-with-#pragma-once of that header.
This makes sense, but the situation is a bit mo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288520: With LTO and profile-use, enable hotness info in opt
remarks (authored by anemet).
Changed prior to commit:
https://reviews.llvm.org/D27332?vs=80026&id=80088#toc
Repository:
rL LLVM
https://
Author: anemet
Date: Fri Dec 2 11:54:34 2016
New Revision: 288520
URL: http://llvm.org/viewvc/llvm-project?rev=288520&view=rev
Log:
With LTO and profile-use, enable hotness info in opt remarks
This is to match the behavior of non-LTO;
when -fsave-optimization-record is passed and PGO is availabl
bruno added a comment.
Hi Alex, thanks for following up with this!
Comment at: lib/Sema/SemaDecl.cpp:11819
+ // Warn if K&R function is defined without previous declaration
+ // declaration. This warning is issued only if the difinition itself
+ // does not
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288512: [CUDA] Forward sanitizer support to host toolchain
(authored by jhen).
Changed prior to commit:
https://reviews.llvm.org/D27351?vs=80082&id=80084#toc
Repository:
rL LLVM
https://reviews.llvm
Author: jhen
Date: Fri Dec 2 11:32:18 2016
New Revision: 288512
URL: http://llvm.org/viewvc/llvm-project?rev=288512&view=rev
Log:
[CUDA] Forward sanitizer support to host toolchain
Summary:
This is an improvement on rL288448 where address sanitization was listed
as supported for the CudaToolChai
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
LGTM
https://reviews.llvm.org/D27351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
I like it!
https://reviews.llvm.org/D27351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
jhen created this revision.
jhen added a reviewer: jlebar.
jhen added subscribers: cfe-commits, hfinkel.
This is an improvement on https://reviews.llvm.org/rL288448 where address
sanitization was listed
as supported for the CudaToolChain. Since the intent is for the
CudaToolChain not to reject an
rogfer01 updated this revision to Diff 80081.
rogfer01 added a comment.
Drop attribute packed of a class when one of its fields is a non-packed non-pod
for compatibility with GCC.
https://reviews.llvm.org/D23325
Files:
include/clang/AST/Decl.h
include/clang/AST/Expr.h
include/clang/AST/S
mboehme created this revision.
mboehme added a reviewer: klimek.
mboehme added a subscriber: cfe-commits.
CXXDeleteExpr::getDestroyedType() can return a null QualType if the destroyed
type is a dependent type. This patch protects against this.
https://reviews.llvm.org/D27350
Files:
lib/Analys
anemet added a comment.
In https://reviews.llvm.org/D27332#611769, @mehdi_amini wrote:
> (You have a typo in the decription, you may want to fix it before commit)
Got it. Thanks for the reviews!
https://reviews.llvm.org/D27332
___
cfe-commits ma
Hello,
The attached patch fixes a couple of incorrect uses of std::move as
revealed by clang-tidy.
Best regards,
Michael Sharpe
diff --git lib/AST/Type.cpp lib/AST/Type.cpp
index d98d8d7..0d0cd2e 100644
--- lib/AST/Type.cpp
+++ lib/AST/Type.cpp
@@ -1050,24 +1050,24 @@ template
QualType simpleTr
mehdi_amini added a comment.
(You have a typo in the decription, you may want to fix it before commit)
https://reviews.llvm.org/D27332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D27332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Hi Hal,
I don't understand why only ASAN is enabled. What about TSAN, etc.?
Shouldn't you query whatever the host toolchain is?
I think you're right, I should just implement it as
SanitizerMask CudaToolChain::getSupportedSanitizers() const { return
HostTC.getSupportedSanitizers(); }
I will get
Anastasia added a comment.
This change seems to modify normal C behavior again. Is there any strong
motivation for doing this and if yes could it be done generically with C?
Comment at: lib/Sema/SemaChecking.cpp:2479
+// integer values.
+if (FDecl->hasAttr()) {
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:22
+
// CHECK-SPIR-CL20: !opencl.spir.version = !{[[SPIR:![0-9]+]]}
// CHECK-SPIR-CL20: !opencl.ocl.version = !{[[SPIR:![0-9]+]]}
Could we then use VER here too?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288502: [clang-tidy] Do not trigger unnecessary-value-param
check on methods marked as… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D27248?vs=79732&id=80066#toc
Repository:
r
Author: flx
Date: Fri Dec 2 08:44:16 2016
New Revision: 288502
URL: http://llvm.org/viewvc/llvm-project?rev=288502&view=rev
Log:
[clang-tidy] Do not trigger unnecessary-value-param check on methods marked as
final
Summary: Virtual method overrides of dependent types cannot be recognized unless
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// mar
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276
+// Virtual method overrides of dependent types cannot be recognized unless they
+// are marked as override or final. Test that check is not triggered on methods
+// marked with ove
Author: hokein
Date: Fri Dec 2 06:39:39 2016
New Revision: 288498
URL: http://llvm.org/viewvc/llvm-project?rev=288498&view=rev
Log:
[clang-move] some tweaks.
* Don't save SourceManager for each declarations.
* Rename some out-dated methods.
No functionality change.
Modified:
clang-tools-ex
- Original Message -
> From: "Jason Henline via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Thursday, December 1, 2016 7:42:54 PM
> Subject: r288448 - [CUDA] "Support" ASAN arguments in CudaToolChain
>
> Author: jhen
> Date: Thu Dec 1 19:42:54 2016
> New Revision: 288448
>
> U
Author: ioeric
Date: Fri Dec 2 05:23:07 2016
New Revision: 288495
URL: http://llvm.org/viewvc/llvm-project?rev=288495&view=rev
Log:
Fix a buildbot failure in include-fixer.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/IncludeFixerTest.cpp
Modified: clang-tools-extra/trunk/unitt
Author: ioeric
Date: Fri Dec 2 05:01:43 2016
New Revision: 288493
URL: http://llvm.org/viewvc/llvm-project?rev=288493&view=rev
Log:
[ClangFormat] Only insert #include into the #include block in the beginning of
the file.
Summary:
This avoid inserting #include into:
- raw string literals contain
1 - 100 of 120 matches
Mail list logo
