Does running vcvarsall put nuget on the path?
What if we require the user to specify the path to nuget in some CMake
variable? -DMSVC_NUGET_PATH=foo?
On Fri, Nov 25, 2016 at 6:58 PM Antonio Maiorano
wrote:
> Ah, no, that's not what I meant. The required referenced assemblies are
> versions that
Sorry, i think I misunderstood the original option 1. I interpreted it as
just committing changes to the vsix manifest to reference a specific
version of the assembly which we assume to be present since it should be
automatically installed with vs 2015. Is this not possible? Can't we just
point the
rsmith added a comment.
Do we still need this after https://reviews.llvm.org/D23765 lands?
https://reviews.llvm.org/D27116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg created this revision.
joerg added reviewers: klimek, rsmith.
joerg added a subscriber: cfe-commits.
joerg set the repository for this revision to rL LLVM.
joerg added a dependency: D27138: Extend CompilationDatabase by a field for the
output filename.
When integrating compilation database
vangyzen added inline comments.
Comment at:
projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp:42
+assert(std::setlocale(LC_NUMERIC, LOCALE_en_US_UTF_8) != NULL);
+char *expected = strdup(std::localecon
vangyzen added a comment.
I'm glad you mentioned a multibyte thousands_sep, because it //is// multibyte
in fr_FR.UTF-8 on FreeBSD 11. Specifically, it's a no-break space (U+00A0).
https://reviews.llvm.org/D26979
___
cfe-commits mailing list
cfe-co
vangyzen updated this revision to Diff 79322.
vangyzen added a comment.
Handle multibyte thousands_sep; do not reference possibly stale locale data
https://reviews.llvm.org/D26979
Files:
projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pa
joerg created this revision.
joerg added a reviewer: klimek.
joerg added a subscriber: cfe-commits.
joerg set the repository for this revision to rL LLVM.
In bigger projects like an Operating System, the same source code is often
compiled in slightly different ways. This could be the difference b
Author: joerg
Date: Fri Nov 25 14:15:57 2016
New Revision: 287947
URL: http://llvm.org/viewvc/llvm-project?rev=287947&view=rev
Log:
Typo.
Modified:
cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp
Modified: cfe/trunk/lib/Tooling/ArgumentsAdjusters.cpp
URL:
http://llvm.org/viewvc/llvm-project/cf
Anastasia added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:5924
- DeclContext *OriginalDC = DC;
- bool IsLocalExternDecl = SC == SC_Extern &&
- adjustContextForLocalExternDecl(DC);
+// OpenCL 1.2 spec, p6.9 r:
+// The event type canno
ABataev added inline comments.
Comment at: lib/Basic/OpenMPKinds.cpp:685
bool clang::isOpenMPWorksharingDirective(OpenMPDirectiveKind DKind) {
return DKind == OMPD_for || DKind == OMPD_for_simd ||
I think this new directive must be considered as a workshari
Hi all,
Emails from Phabricator are now sent with "senders" as:
via Phabricator
Previously, Phabricator sent emails on behalf of users using their email
addresses, which has caused DMARC failure for some mail service providers
(e.g. gmail, yahoo). Some of your emails might have been marked
Author: ioeric
Date: Fri Nov 25 10:02:49 2016
New Revision: 287929
URL: http://llvm.org/viewvc/llvm-project?rev=287929&view=rev
Log:
Do not do raw name replacement when FromDecl is a class forward-declaration.
Summary:
If the `FromDecl` is a class forward declaration, the reference is
still consi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287929: Do not do raw name replacement when FromDecl is a
class forward-declaration. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27132?vs=79307&id=79308#toc
Repository:
r
ioeric updated this revision to Diff 79307.
ioeric marked an inline comment as done.
ioeric added a comment.
- Address comments.
https://reviews.llvm.org/D27132
Files:
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/LookupTest.cpp
Index: unittests/Tooling/LookupTest.cpp
=
bkramer accepted this revision.
bkramer added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Tooling/Core/Lookup.cpp:131
+ // still considered as referring to the original definition given the nature
+ // of forward-declarations, so we can't d
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
If the `FromDecl` is a class forward declaration, the reference is
still considered as referring to the original definition given the nature
of forward-declara
Author: joerg
Date: Fri Nov 25 08:14:43 2016
New Revision: 287926
URL: http://llvm.org/viewvc/llvm-project?rev=287926&view=rev
Log:
Document the arguments form of commands.
Modified:
cfe/trunk/docs/JSONCompilationDatabase.rst
Modified: cfe/trunk/docs/JSONCompilationDatabase.rst
URL:
http://
ioeric updated this revision to Diff 79295.
ioeric marked an inline comment as done.
ioeric added a comment.
- Address review comment.
https://reviews.llvm.org/D27125
Files:
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/LookupTest.cpp
Index: unittests/Tooling/LookupTest.cpp
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287924: Consider nested namespaces in the canonical
namespace as canonical as well. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27125?vs=79295&id=79296#toc
Repository:
rL
echuraev updated this revision to Diff 79292.
echuraev marked 3 inline comments as done.
https://reviews.llvm.org/D27099
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/event_t.cl
test/SemaOpenCL/invalid-clk-events-cl2.0.cl
test/SemaOpenCL/invalid
Author: ioeric
Date: Fri Nov 25 06:39:03 2016
New Revision: 287924
URL: http://llvm.org/viewvc/llvm-project?rev=287924&view=rev
Log:
Consider nested namespaces in the canonical namespace as canonical as well.
Summary:
For example, this case was missed when looking for different but canonical
name
ioeric added a comment.
Testing sender again
https://reviews.llvm.org/D27125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Test email sender.
https://reviews.llvm.org/D27125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer added inline comments.
Comment at: lib/Tooling/Core/Lookup.cpp:27
+ llvm::SmallVector Namespaces;
+ auto GetNextNameNamespace = [](const DeclContext *Context) {
+// Look past non-namespaces and anonymous namespaces on FromContext.
GetNextName**d**Na
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
For example, this case was missed when looking for different but canonical
namespaces. UseContext in this case should be considered as in the canonical
namespa
26 matches
Mail list logo
