doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
Seem fine; I'd rename the "FIXME" to a "Note" unless you're going to pass a
flag to Type::canHaveNullability to say how to classify dependent types.
Repository:
rL LLVM
https://r
Author: ericwf
Date: Wed Nov 2 00:08:58 2016
New Revision: 285788
URL: http://llvm.org/viewvc/llvm-project?rev=285788&view=rev
Log:
Fix GCC test failure caused by manually defining _LIBCPP_HAS_NO_VARIADICS
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
Author: ericwf
Date: Tue Nov 1 22:57:34 2016
New Revision: 285786
URL: http://llvm.org/viewvc/llvm-project?rev=285786&view=rev
Log:
Fix __libcpp_is_constructible for source types with explicit conversion
operators.
Previously __libcpp_is_constructible checked the validity of reference
construct
EricWF created this revision.
EricWF added a reviewer: rsmith.
EricWF added a subscriber: cfe-commits.
[expr.cast.static] states:
> 3. A glvalue of type “cv1 T1” can be cast to type “rvalue reference to cv2
> T2” if “cv2 T2” is reference-compatible with “cv1 T1”. The result refers to
> the obje
On 10/30/16 01:57, Brad Smith via cfe-commits wrote:
On 10/25/16 19:34, Brad Smith via cfe-commits wrote:
On 10/18/16 22:13, Brad Smith via cfe-commits wrote:
On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits
wrote:
On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Thanks.
https://reviews.llvm.org/D24085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D26197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
jordan_rose created this revision.
jordan_rose added reviewers: doug.gregor, rsmith.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
jordan_rose added dependencies: D26226: Don't require nullability on template
parameters in typedefs., D258
jordan_rose created this revision.
jordan_rose added reviewers: doug.gregor, rsmith.
jordan_rose added a subscriber: cfe-commits.
jordan_rose set the repository for this revision to rL LLVM.
Previously the following code would warn on the use of `T`:
template
struct X {
typedef T *type;
Author: rsmith
Date: Tue Nov 1 19:47:52 2016
New Revision: 285779
URL: http://llvm.org/viewvc/llvm-project?rev=285779&view=rev
Log:
More forcibly resolve exception specifications when checking a function
redeclaration in C++1z mode. We need the exception specification in order for
the function's
Author: eugenezelenko
Date: Tue Nov 1 19:43:23 2016
New Revision: 285778
URL: http://llvm.org/viewvc/llvm-project?rev=285778&view=rev
Log:
[Documentation] Clang-tidy readability-redundant-declaration consistency.
Release notes checks order and consistent Clang-tidy
readability-redundant-declara
rsmith added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4256
+/// is dependent.
+class CoawaitDependentExpr : public Expr {
+ SourceLocation KeywordLoc;
Rename -> `DependentCoawaitExpr`, to match our other `Dependent*Expr` classes.
==
Author: pcc
Date: Tue Nov 1 19:08:19 2016
New Revision: 285773
URL: http://llvm.org/viewvc/llvm-project?rev=285773&view=rev
Log:
Bitcode: Change reader interface to take memory buffers.
As proposed on llvm-dev:
http://lists.llvm.org/pipermail/llvm-dev/2016-October/106595.html
This change also f
mboehme marked 4 inline comments as done.
mboehme added a comment.
Please take another look.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:467
+StringRef getName(const NamedDecl *ND) {
+ if (!ND->getIdentifier())
+return StringRef();
aaron.ballman wrot
zaks.anna added a comment.
Please, explain what variants are for in comments.
https://reviews.llvm.org/D25940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mboehme updated this revision to Diff 76655.
mboehme added a comment.
- Responses to reviewer comments
https://reviews.llvm.org/D26041
Files:
clang-tidy/misc/UseAfterMoveCheck.cpp
docs/clang-tidy/checks/misc-use-after-move.rst
test/clang-tidy/misc-use-after-move.cpp
Index: test/clang-tid
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D26189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
zaks.anna updated this revision to Diff 76643.
zaks.anna added a comment.
Addressed the review comments.
I also added ObjC +initialize method to the list because TSan does not observe
the guaranteed synchronization between +initialize and initial object accesses.
https://reviews.llvm.org/D2585
malcolm.parsons updated this revision to Diff 76642.
malcolm.parsons added a comment.
clang-format
https://reviews.llvm.org/D26206
Files:
lib/ARCMigrate/FileRemapper.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/TargetInfo.cpp
lib/Driver/Driver.cpp
lib/Driver/Job.cpp
lib/Driver/Tools.cp
nkakuev created this revision.
nkakuev added reviewers: alexfh, mgehre.
nkakuev added a subscriber: cfe-commits.
When clang-tidy suppresses a warning, ignored by NOLINT, it doesn't suppress
related notes. This leads to an assertion/crash, as described in this bug:
https://llvm.org/bugs/show_bug.
NoQ updated this revision to Diff 76641.
NoQ added a comment.
Try out a completely different approach which was also suggested by Anna.
Allow providing multiple variants of summaries for each function identifier,
with different type specifications and branches. This way we preserve type
checks
Author: dcoughlin
Date: Tue Nov 1 17:16:39 2016
New Revision: 285759
URL: http://llvm.org/viewvc/llvm-project?rev=285759&view=rev
Log:
[analyzer] Fix capitalization in ObjCSuperDealloc checker diagnostic.
Change "use of 'self'..." to "Use of 'self'...". The convention is to
start diagnostics wit
malcolm.parsons added a comment.
In https://reviews.llvm.org/D12839#585256, @aaron.ballman wrote:
> This overlap is unfortunate. misc-move-constructor-init is for move
> constructor initializer lists which accidentally initialize a member or base
> through a copy constructor rather than a move
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25659#585234, @aaron.ballman wrote:
> In https://reviews.llvm.org/D25659#585154, @malcolm.parsons wrote:
>
> > In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote:
> >
> > > (1) I think that the aliases and the originals sh
aaron.ballman added a comment.
In https://reviews.llvm.org/D12839#582828, @malcolm.parsons wrote:
> The modernize-pass-by-value check does the same thing:
>
> test/clang-tidy/misc-move-constructor-init.cpp:98:12: warning: pass by
> value and use std::move [modernize-pass-by-value]
> Positi
mlemay-intel updated this revision to Diff 76636.
mlemay-intel added a comment.
Disabled linking of the compiler-rt SafeStack runtime library for musl
environments rather than for targets that use the separate stack segment
feature. This reflects changes in my proposed musl libc patches to add
ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285752: [clang-tidy] Handle bitfields in
cppcoreguidelines-pro-type-member-init (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26119?vs=76313&id=76635#toc
Repository:
Author: malcolm.parsons
Date: Tue Nov 1 16:26:53 2016
New Revision: 285752
URL: http://llvm.org/viewvc/llvm-project?rev=285752&view=rev
Log:
[clang-tidy] Handle bitfields in cppcoreguidelines-pro-type-member-init
Summary:
Unnamed bitfields cannot be initialized.
Bitfields cannot be in-class init
aaron.ballman added a comment.
In https://reviews.llvm.org/D25659#585154, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote:
>
> > (1) I think that the aliases and the originals should be listed with
> > -list-checks, because these are names under which th
flx added a comment.
In https://reviews.llvm.org/D26195#585091, @aaron.ballman wrote:
> In https://reviews.llvm.org/D26195#584958, @flx wrote:
>
> > In https://reviews.llvm.org/D26195#584730, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D26195#584724, @flx wrote:
> > >
> > > > In h
flx added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242
+// Case where parameter in declaration is already const-qualified but not in
+// implementation. Make sure a second 'const' is not added to the declaration.
+void PositiveConstDecl
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:580
+ C.addTransition(stateFound);
+ C.addTransition(stateNotFound);
+}
NoQ wrote:
> Ouch, i have one more concern, which can be expressed with the following
> false-
flx updated this revision to Diff 76630.
Repository:
rL LLVM
https://reviews.llvm.org/D26207
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
===
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:580
+ C.addTransition(stateFound);
+ C.addTransition(stateNotFound);
+}
Ouch, i have one more concern, which can be expressed with the following
false-positive test w
malcolm.parsons added inline comments.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSourceInfo()->getType()
+ << Construct->getType()
<< FixItHint::Creat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285741: [test] Fix detecting LLVM zlib support in
stand-alone builds (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24869?vs=72258&id=76625#toc
Repository:
rL LLVM
https://
Author: mgorny
Date: Tue Nov 1 15:31:52 2016
New Revision: 285741
URL: http://llvm.org/viewvc/llvm-project?rev=285741&view=rev
Log:
[test] Fix detecting LLVM zlib support in stand-alone builds
Fix the test run to declare missing HAVE_LIBZ value in stand-alone
builds, using the LLVM_ENABLE_ZLIB t
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote:
> (1) I think that the aliases and the originals should be listed with
> -list-checks, because these are names under which the checks may be run (and
> sometimes the name may even imply different s
hans added a comment.
I didn't follow the original thread too closely as I didn't really see the
problem this was trying to address, but since I'm now cc'd I'll add my opinion.
I'm not in favour of this functionality. (But I guess I might be missing the
main use case.)
The way I see it, what f
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: chapuni
Date: Tue Nov 1 15:08:17 2016
New Revision: 285733
URL: http://llvm.org/viewvc/llvm-project?rev=285733&view=rev
Log:
clang/test/CodeGenOpenCL/convergent.cl: Satisfy -Asserts with "opt -instnamer".
Modified:
cfe/trunk/test/CodeGenOpenCL/convergent.cl
Modified: cfe/trunk/test/
Author: malcolm.parsons
Date: Tue Nov 1 15:07:05 2016
New Revision: 285731
URL: http://llvm.org/viewvc/llvm-project?rev=285731&view=rev
Log:
[clang-query] Fix Clang-tidy readability-redundant-string-cstr warnings
Reviewers: pcc, dblaikie
Subscribers: cfe-commits
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285731: [clang-query] Fix Clang-tidy
readability-redundant-string-cstr warnings (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26205?vs=76597&id=76622#toc
Repository:
NoQ added a comment.
I think i managed to understand the reasoning behind your solutions! Right now
i definitely approve all the high-level logic apart from the handling of
left/right `SVal`s for `evalAssume`, which i think could be easily improved
upon without significant drawbacks. See the in
aaron.ballman added a comment.
In https://reviews.llvm.org/D26195#584958, @flx wrote:
> In https://reviews.llvm.org/D26195#584730, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D26195#584724, @flx wrote:
> >
> > > In https://reviews.llvm.org/D26195#584712, @aaron.ballman wrote:
> > >
>
On Tue, Nov 1, 2016 at 2:59 PM, Eugene Zelenko via cfe-commits
wrote:
> Hi, Aaron!
>
> I don't think that it worth to split such trivial changes in three.
Unrelated changes should always go in as separate patches. This is
especially important for code archaeology and times when we have to
revert
aaron.ballman added inline comments.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:242
+// Case where parameter in declaration is already const-qualified but not in
+// implementation. Make sure a second 'const' is not added to the declaration.
+void Positiv
Hi, Aaron!
I don't think that it worth to split such trivial changes in three.
Eugene.
On Tue, Nov 1, 2016 at 11:51 AM, Aaron Ballman wrote:
> On Tue, Nov 1, 2016 at 2:33 PM, Eugene Zelenko via cfe-commits
> wrote:
>> Author: eugenezelenko
>> Date: Tue Nov 1 13:33:50 2016
>> New Revision: 285
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some formatting nits, this LGTM. You should run the diff through
clang-format before committing.
Comment at: lib/CodeGen/CGObjCGNU.cpp:2650
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285725: [OpenCL] Mark group functions as convergent in
opencl-c.h (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25343?vs=75203&id=76612#toc
Repository:
rL LLVM
https://rev
Author: yaxunl
Date: Tue Nov 1 13:45:32 2016
New Revision: 285725
URL: http://llvm.org/viewvc/llvm-project?rev=285725&view=rev
Log:
[OpenCL] Mark group functions as convergent in opencl-c.h
Certain OpenCL builtin functions are supposed to be executed by all threads in
a work group or sub group.
On Tue, Nov 1, 2016 at 2:33 PM, Eugene Zelenko via cfe-commits
wrote:
> Author: eugenezelenko
> Date: Tue Nov 1 13:33:50 2016
> New Revision: 285721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285721&view=rev
> Log:
> [Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks for fixing this!
https://reviews.llvm.org/D26125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285721: [Clang-tidy] Fix copy-paste error in
misc-redundant-expression detected by PVS… (authored by eugenezelenko).
Changed prior to commit:
https://reviews.llvm.org/D26176?vs=76510&id=76611#toc
Repos
Author: eugenezelenko
Date: Tue Nov 1 13:33:50 2016
New Revision: 285721
URL: http://llvm.org/viewvc/llvm-project?rev=285721&view=rev
Log:
[Clang-tidy] Fix copy-paste error in misc-redundant-expression detected by
PVS-Studio
Also fix some Include What You Use and modernize-use-bool-literals war
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
idlecode retitled this revision from "[clang-tidy] Fixed else-after-return
warning in cascade if statement" to "[clang-tidy] Fixed
readability-else-after-return for cascade statements".
idlecode updated the summary for this revision.
idlecode updated this revision to Diff 76604.
idlecode added a
http://lab.llvm.org:8011/builders/clang-3stage-ubuntu/builds/128/steps/cmake-configure/logs/stdio
-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
The code itself seems fine. The similar builder that uses the ToT Clang
does not generate any warnings.
h
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
These changes all look good to me, but it would be best to split the commit
into three parts: one for include what you use, one for
modernize-use-bool-literals, and one for the c
aaron.ballman added a comment.
I *really* like this idea, thank you for working on this! A few things:
(0) I'm uncomfortable with the lack of tests in the patch. I'm not certain of a
good way to test this, however. @alexfh, do you have ideas?
(1) I think that the aliases and the originals should
flx created this revision.
flx added reviewers: alexfh, sbenza, aaron.ballman.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D26207
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/cla
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6957-6958
+
+ llvm::Constant *translateNullPtr(const CodeGen::CodeGenModule &CGM,
+ llvm::Constant *C) const override;
};
I was thinking that addrspacecast (generic null) should be valid
erichkeane added a comment.
@rnk, @majnemer and @ABataev : I believe that I've done everything that has
come up in review, and this passes all tests for the convention I can find. Do
you guys see anything that is holding this patch up? What is otherwise the
'next step' in getting this into m
pekka.jaaskelainen added a comment.
Thanks. @tstellarAMD OK to commit for 3.9.1 as well?
Repository:
rL LLVM
https://reviews.llvm.org/D26157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
flx added a comment.
In https://reviews.llvm.org/D26195#584730, @aaron.ballman wrote:
> In https://reviews.llvm.org/D26195#584724, @flx wrote:
>
> > In https://reviews.llvm.org/D26195#584712, @aaron.ballman wrote:
> >
> > > Please add a test case with an incomplete type that would exercise this
arsenm added inline comments.
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:30
+
+// CHECK: icmp eq i8 addrspace(1)* %p, null
+void cmp_global(global char* p) {
Missing check-label
https://reviews.llvm.org/D26196
__
arsenm added inline comments.
Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:49
+}
+
I think there need to be a lot more tests. A few I can think of:
- Tests that compare to NULL instead of 0
- Pointer compares without the explicit 0, i.e. if (p)/if(!p)
aaron.ballman added a comment.
This change is missing a test case.
Comment at: clang-tidy/readability/RedundantMemberInitCheck.cpp:57
"initializer for base class %0 is redundant")
- << Init->getTypeSourceInfo()->getType()
+ << Construct->getType()
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, mehdi_amini, dblaikie.
malcolm.parsons added a subscriber: cfe-commits.
https://reviews.llvm.org/D26206
Files:
lib/ARCMigrate/FileRemapper.cpp
lib/CodeGen/CGObjCGNU.cpp
lib/CodeGen/TargetInfo.cpp
lib/Dr
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
malcolm.parsons created this revision.
malcolm.parsons added reviewers: pcc, dblaikie.
malcolm.parsons added a subscriber: cfe-commits.
https://reviews.llvm.org/D26205
Files:
clang-query/tool/ClangQuery.cpp
Index: clang-query/tool/ClangQuery.cpp
===
ddcc added a comment.
Yes, I've been writing a Z3 solver interface, which motivated this patch.
However, this patch has snowballed into something that it's a little too
convoluted, so I'll split it up.
I'm not sure whether the RangedConstraintManager interface is useful or not; I
preserved it
smeenai added a comment.
Ping :)
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 76593.
omtcyfz added a comment.
Reversed "tabwidth:2 -> tabwidth:4" change.
Removed unused dependency (`re`).
Got rid of `sys.argv[0]` via using Pythonic `__file__` and removed (now)
redundant dependency (`sys`).
https://reviews.llvm.org/D25074
Files:
cl
flx created this revision.
flx added reviewers: alexfh, sbenza.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Suppress fixes for functions that are referenced within the compilation unit
outside of a call expression as the signature change could break t
neil.hickey updated this revision to Diff 76587.
neil.hickey added a comment.
Sorry for the delay. It looks like the code to handle extensions was changed
since Neil Henning added the check against opencl 1.2. Perhaps the best
approach is just to remove the check.
https://reviews.llvm.org/D242
krememek added a comment.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D26195#584724, @flx wrote:
> In https://reviews.llvm.org/D26195#584712, @aaron.ballman wrote:
>
> > Please add a test case with an incomplete type that would exercise this
> > code path, otherwise, LGTM.
>
>
> Hi Aaron,
>
> do you have a
flx added a comment.
In https://reviews.llvm.org/D26195#584712, @aaron.ballman wrote:
> Please add a test case with an incomplete type that would exercise this code
> path, otherwise, LGTM.
Hi Aaron,
do you have any advise on how to add an incomplete type? When debugging this I
had a compila
arphaman updated this revision to Diff 76577.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch renames the note diagnostic to a more generic rename.
Repository:
rL LLVM
https://reviews.llvm.org/D26189
Files:
include/clang/AST/DeclBase.h
include/clang
aaron.ballman added a comment.
Please add a test case with an incomplete type that would exercise this code
path, otherwise, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D26195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip the tests that expect an exception be thrown and protect unreachable catch
blocks.
https://reviews.llvm.org/D26197
Files:
test/std/language.support/support
yaxunl created this revision.
yaxunl added reviewers: arsenm, tstellarAMD, rjmccall.
yaxunl added a subscriber: cfe-commits.
Herald added subscribers: tony-tye, nhaehnle, wdng, kzhuravl.
In amdgcn target, null pointers in global, constant, and generic address space
take value 0 but null pointers
sdardis added a comment.
Ping.
https://reviews.llvm.org/D24448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285700: [OpenCL] Override supported OpenCL extensions with
-cl-ext option (authored by bader).
Changed prior to commit:
https://reviews.llvm.org/D23712?vs=75568&id=76571#toc
Repository:
rL LLVM
http
Author: bader
Date: Tue Nov 1 10:50:52 2016
New Revision: 285700
URL: http://llvm.org/viewvc/llvm-project?rev=285700&view=rev
Log:
[OpenCL] Override supported OpenCL extensions with -cl-ext option
Summary:
This patch adds a command line option '-cl-ext' to control a set of
supported OpenCL exten
logan added a comment.
Hi @EricWF:
Thanks for your comment.
However, I think `OFF` is a better default for ARM (just like other platforms.)
I usually use `libc++abi` without `libunwind` since `libgcc` is quite stable
and usually linked by default. Besides, it is much more tricky to get the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285697: Protect exceptional paths under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26136?vs=76566&id=76567#toc
Repository:
rL LLVM
https://review
Author: rogfer01
Date: Tue Nov 1 10:46:16 2016
New Revision: 285697
URL: http://llvm.org/viewvc/llvm-project?rev=285697&view=rev
Log:
Protect exceptional paths under libcpp-no-exceptions
These tests are of the form
try {
action-that-may-throw
assert(!exceptional-condition)
assert(some-
rogfer01 updated this revision to Diff 76566.
rogfer01 added a comment.
Const-ify variables.
https://reviews.llvm.org/D26136
Files:
test/std/strings/basic.string/string.access/at.pass.cpp
test/std/strings/basic.string/string.capacity/reserve.pass.cpp
test/std/strings/basic.string/string.c
flx created this revision.
flx added a reviewer: alexfh.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
IsExpensiveToCopy can return false positives for incomplete types, so ignore
them.
All existing ClangTidy tests that depend on this function still pa
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:5946
+if (const LinkageSpecDecl *LSD = Ctx->getExternCContext())
+ Diag(LSD->getExternLoc(), diag::note_module_import_in_extern_c);
+return true;
Can you update the name of
malcolm.parsons updated this revision to Diff 76561.
malcolm.parsons added a comment.
Add quick hack to make methods public.
Cleanup around replacements should be enhanced with rules to remove
empty private/protected/public sections.
private: public: -> public:
public: private: -> private:
https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285695: Protect lock tests under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26184?vs=76545&id=76559#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: rogfer01
Date: Tue Nov 1 10:00:16 2016
New Revision: 285695
URL: http://llvm.org/viewvc/llvm-project?rev=285695&view=rev
Log:
Protect lock tests under libcpp-no-exceptions
Skip tests that expect an exception to be thrown.
Differential Revision: https://reviews.llvm.org/D26184
Modifie
malcolm.parsons updated this revision to Diff 76558.
malcolm.parsons added a comment.
Add FIXME comment.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
clang-tidy/modernize/
malcolm.parsons updated this revision to Diff 76557.
malcolm.parsons added a comment.
Reword diagnostic.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseDefaultCheck.cpp
clang-tidy/modernize/
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:29
+cxxMethodDecl(
+anyOf(isCopyAssignmentOperator(), isMoveAssignmentOperator())),
+cxxDestructorDecl()));
malcolm.parsons wrot
Author: nemanjai
Date: Tue Nov 1 09:46:20 2016
New Revision: 285694
URL: http://llvm.org/viewvc/llvm-project?rev=285694&view=rev
Log:
[PowerPC] Implement vector shift builtins - clang portion
This patch corresponds to review https://reviews.llvm.org/D26092.
Committing on behalf of Tony Jiang.
M
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:29
+cxxMethodDecl(
+anyOf(isCopyAssignmentOperator(), isMoveAssignmentOperator())),
+cxxDestructorDecl()));
aaron.ballman wrot
1 - 100 of 121 matches
Mail list logo
