mgorny added a comment.
In https://reviews.llvm.org/D23754#580441, @chandlerc wrote:
> In https://reviews.llvm.org/D23754#580277, @mgorny wrote:
>
> > The difference is that LLVMgold.so is not used by LLVM or clang directly
> > but by the system binutils, and so it must match the ABI of the link
Author: nemanjai
Date: Thu Oct 27 01:23:57 2016
New Revision: 285268
URL: http://llvm.org/viewvc/llvm-project?rev=285268&view=rev
Log:
[PPC] add vector byte reverse functions to altivec.h
This patch corresponds to review https://reviews.llvm.org/D25915.
Committing on behalf of Sean Fertile.
Modi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285266: [XRay] Check in Clang whether XRay supports the
target when -fxray-instrument… (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D24799?vs=75452&id=75980#toc
Repository:
Author: dberris
Date: Wed Oct 26 23:56:14 2016
New Revision: 285266
URL: http://llvm.org/viewvc/llvm-project?rev=285266&view=rev
Log:
[XRay] Check in Clang whether XRay supports the target when -fxray-instrument
is passed
Summary:
Added the code which explicitly emits an error in Clang in case
`
dberris added a comment.
Actually I tried again, but still the patch doesn't apply cleanly through git
(and it still complains of whitespace issues). Let me go through this manually
again, and see whether there are still failures that come up.
https://reviews.llvm.org/D24799
___
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
Thanks @rSerge -- I'll land this now.
https://reviews.llvm.org/D24799
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
craig.topper created this revision.
craig.topper added reviewers: delena, igorb.
craig.topper added a subscriber: cfe-commits.
Inverting the mask argument currently fails isel and even if that was fixed it
does not reflect the intended semantics of the intrinsic.
https://reviews.llvm.org/D26019
kubabrecka added a comment.
Does this also disable checking for the compiler generated `.cxx_destruct`
Obj-C methods? Can we add a testcase both here and into compiler-rt?
https://reviews.llvm.org/D25857
___
cfe-commits mailing list
cfe-commits@li
Thank you for fixing this!
On Wed, Oct 26, 2016 at 5:53 PM, Samuel Antao via cfe-commits
wrote:
> Author: sfantao
> Date: Wed Oct 26 19:53:34 2016
> New Revision: 285263
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285263&view=rev
> Log:
> Fix bug when compiling CUDA code with -emit-llvm and
sfantao added a comment.
In https://reviews.llvm.org/D18172#580276, @jlebar wrote:
> Hi, Samuel.
>
> This change introduced a new crash / assertion failure in the driver.
>
> $ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null
>
>
> Before this patch, we get an error (perhaps not as
Author: sfantao
Date: Wed Oct 26 20:08:58 2016
New Revision: 285264
URL: http://llvm.org/viewvc/llvm-project?rev=285264&view=rev
Log:
Remove check for -o option in offloading actions builder.
This check is also present when jobs are built, so the offloading builder check
is not needed anymore.
Author: sfantao
Date: Wed Oct 26 19:53:34 2016
New Revision: 285263
URL: http://llvm.org/viewvc/llvm-project?rev=285263&view=rev
Log:
Fix bug when compiling CUDA code with -emit-llvm and -o.
In this case the device code is not injected into an host action and therefore
the
user should get an e
rtrieu added a comment.
In https://reviews.llvm.org/D21675#560297, @rsmith wrote:
> There are a bunch of cases here that do this:
>
> if (auto t = getThing())
> ID.addThing(t);
> if (auto t = getOtherThing())
> ID.addThing(t);
>
>
> That will result in hash collisions between objects
rtrieu updated this revision to Diff 75970.
rtrieu marked 2 inline comments as done.
https://reviews.llvm.org/D21675
Files:
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/Stmt.h
include/clang/AST/TemplateBase.h
include/clang/AST/Type.h
include/clang/Basic/D
Author: rjmccall
Date: Wed Oct 26 18:46:34 2016
New Revision: 285258
URL: http://llvm.org/viewvc/llvm-project?rev=285258&view=rev
Log:
Refactor call emission to package the function pointer together with
abstract information about the callee. NFC.
The goal here is to make it easier to recognize
jlebar added a comment.
So, good news -- these three builtins are already constexpr-evaluatable. :)
I'll add a test.
https://reviews.llvm.org/D25403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
mehdi_amini reopened this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
Reopen: this hasn't been committed yet apparently.
@sashab : are you still interested in moving this forward?
https://reviews.llvm.org/D24289
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285254: Unconditionally pass `-lto_library` to the linker on
Darwin (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D25932?vs=75668&id=75963#toc
Repository:
rL LLVM
http
Author: mehdi_amini
Date: Wed Oct 26 18:23:08 2016
New Revision: 285254
URL: http://llvm.org/viewvc/llvm-project?rev=285254&view=rev
Log:
Unconditionally pass `-lto_library` to the linker on Darwin
We're only doing it with -flto currently, however it never "hurt"
to pass it, and users that are li
hfinkel added a comment.
In https://reviews.llvm.org/D25403#580444, @jlebar wrote:
> //Let "CE" mean "constexpr-evaluatable". //
>
> libc++ attempts to be backwards-compatible with old versions of clang, right?
Yea, we'd need to ifdef the test for older versions of Clang. I've just
summarized
hfinkel added a comment.
Here's what I suggest:
1. We commit this patch (I think it logically makes sense; the builtins should
be constexpr evaluatable, even if they're currently not)
2. We follow up by fixing Clang to make the builtins constexpr evaluatable
(since I think that makes sense rega
jlebar added a comment.
//Let "CE" mean "constexpr-evaluatable". //
libc++ attempts to be backwards-compatible with old versions of clang, right?
Old versions of clang are going to fail, since the builtin will not be CE. Is
the idea to write a test that checks that, if __builtin_isfinite is C
hfinkel added a comment.
In https://reviews.llvm.org/D25403#580439, @jlebar wrote:
> > I'm not sure about that. It seems like a useful feature for the builtins to
> > have. Logically speaking, they should be constexpr.
>
> I agree that it's logically correct for the builtins to be
> constexpr-e
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580277, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580268, @beanz wrote:
>
> > @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
> > sense. It more closely aligns with the tools vended by LLVM even tho
jlebar added a comment.
> I'm not sure about that. It seems like a useful feature for the builtins to
> have. Logically speaking, they should be constexpr.
I agree that it's logically correct for the builtins to be
constexpr-evaluatable. My point is just that doing this work and then writing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285253: [analyzer] Report CFNumberGetValue API misuse
(authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D25876?vs=75488&id=75961#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: zaks
Date: Wed Oct 26 17:51:47 2016
New Revision: 285253
URL: http://llvm.org/viewvc/llvm-project?rev=285253&view=rev
Log:
[analyzer] Report CFNumberGetValue API misuse
This patch contains 2 improvements to the CFNumber checker:
- Checking of CFNumberGetValue misuse.
- Treating all CFNu
hfinkel added a comment.
In https://reviews.llvm.org/D25403#580432, @jlebar wrote:
> In https://reviews.llvm.org/D25403#580422, @hfinkel wrote:
>
> > Okay. Why not fix the Clang builtins so that they're evaluatable for
> > constant inputs in a constexpr context? Then we can do this and test the
jlebar added a comment.
In https://reviews.llvm.org/D25403#580422, @hfinkel wrote:
> Okay. Why not fix the Clang builtins so that they're evaluatable for constant
> inputs in a constexpr context? Then we can do this and test the change.
I am not sure how much value we would derive from testing
hfinkel added a comment.
In https://reviews.llvm.org/D25403#580416, @jlebar wrote:
> > Is this because the functions are in instead of in are
> > you don't want to mark all of as host/device?
>
> Yes. cmath is its own beast; we need to have our own implementation of it in
> order to direct
jlebar added a comment.
> Is this because the functions are in instead of in are you
> don't want to mark all of as host/device?
Yes. cmath is its own beast; we need to have our own implementation of it in
order to direct the std functions to the appropriate low-level device
functions. (A
hfinkel added a comment.
...
>
>
>> I guess I don't understand the motivation for this change.
>
> To make work in CUDA, we do the following terrible, awful,
> horrible, no good thing: ...well, I can just show you the code.
> https://github.com/llvm-project/llvm-project/blob/master/clang/l
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Tools.cpp:334
+ LksStream << " OpenMP Offload Linker Script.\n";
+ LksStream << "*/\n";
+ LksStream << "TARGET(binary)\n";
Author: jlebar
Date: Wed Oct 26 17:13:26 2016
New Revision: 285251
URL: http://llvm.org/viewvc/llvm-project?rev=285251&view=rev
Log:
[CUDA] Move device placement new definitions into a wrapper header.
Previously, these were always included -- after this change, you have to
#include , which is co
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Driver.cpp:2091
+InputArg->getOption().getKind() == llvm::opt::Option::InputClass &&
+!types::isSrcFile(HostAction->getType()))
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: jlebar
Date: Wed Oct 26 17:13:20 2016
New Revision: 285250
URL: http://llvm.org/viewvc/llvm-project?rev=285250&view=rev
Log:
[CUDA] Switch cuda_wrappers/complex to use a proper include guard instead of
#pragma once.
This is consistent with the rest of our internal headers.
Modified:
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Driver/Driver.cpp:1949
+SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
//
sfantao wrote:
> hfinke
ahatanak updated this revision to Diff 75956.
ahatanak added a comment.
Add the variable to the list of potential captures only if it's declared
outside of the lambda expression. I don't think we need to check that the
variable is declared outside of the lambda because
getStackIndexOfNearestEnc
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
https://reviews.llvm.org/D25925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aaron.ballman added a comment.
In https://reviews.llvm.org/D22346#580242, @falho wrote:
> removed semicolon, and replaced it with a comma that only appears in .cpp
> diagnostics
The semicolon was the correct punctuator to use, but thank you for moving it
into the cpp message.
> test cases co
falho updated this revision to Diff 75935.
falho marked an inline comment as done.
falho added a comment.
removed semicolon, and replaced it with a comma that only appears in .cpp
diagnostics
test cases corrected according to this
removed junk .swo file
https://reviews.llvm.org/D22346
Files:
malcolm.parsons updated this revision to Diff 75951.
malcolm.parsons added a comment.
Add more tests.
https://reviews.llvm.org/D25925
Files:
clang-tidy/cert/StaticObjectExceptionCheck.cpp
docs/clang-tidy/checks/cert-err58-cpp.rst
test/clang-tidy/cert-static-object-exception.cpp
Index: te
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:274
+if (Invalid)
+ continue;
+std::ofstream OutFile(FilePath.c_str());
zaks.anna wrote:
> Would it be better to break if the buffer is invalid?
> Should this be hois
sfantao added a comment.
Hi Justin
Thanks for letting me know. I'm looking into it.
Thanks again,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
joerg added a comment.
Can we please avoid adding more (pseudo) keywords in the double-underscore name
space? Those tend to be used a lot by existing libc implementations and
existing attribute cases like __strong and __weak have created enough trouble.
https://reviews.llvm.org/D25204
_
malcolm.parsons updated this revision to Diff 75947.
malcolm.parsons added a comment.
Remove braces.
Use Twine.
https://reviews.llvm.org/D25898
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tidy/modernize/MakeSmartPtrCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/moderni
zaks.anna added a comment.
Please, add multi-file tests and tests where a line is covered more than once.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:262
+
+static void dumpCoverageInfo(llvm::SmallVectorImpl &Path,
+ SourceManager &SM) {
-
mgorny added a comment.
In https://reviews.llvm.org/D23754#580268, @beanz wrote:
> @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
> sense. It more closely aligns with the tools vended by LLVM even though it is
> a shared library not an executable.
>
> Runtime librarie
jlebar added a comment.
Hi, Samuel.
This change introduced a new crash / assertion failure in the driver.
$ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null
Before this patch, we get an error (perhaps not as helpful as we might want,
but still):
clang-3.8: error: cannot specify
beanz added a comment.
@mgorny, I don't think LLVMgold qualifies as a runtime in the traditional
sense. It more closely aligns with the tools vended by LLVM even though it is a
shared library not an executable.
Runtime libraries are specifically libraries that products of clang are linked
agai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285239: [RecursiveASTVisitor] Visit the implicit expression
of a CXXDefaultArgExpr (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25992?vs=75899&id=75944#toc
Reposito
Author: malcolm.parsons
Date: Wed Oct 26 15:39:54 2016
New Revision: 285239
URL: http://llvm.org/viewvc/llvm-project?rev=285239&view=rev
Log:
[RecursiveASTVisitor] Visit the implicit expression of a CXXDefaultArgExpr
Summary:
The matcher
varDecl(hasDescendant(
callExpr(hasDeclaration(function
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I appreciate the doc for each of the magic numbers.
https://reviews.llvm.org/D25483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added inline comments.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36
+using DecayTag = std::decay_t;
+static_assert(!std::is_constructible::value, "");
+}
CaseyCarter wrote:
> I'm generously calling this a "libc++ exten
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285234: Cleanup nonportable behavior in tests for std::any
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D26007?vs=75936&id=75938#toc
Repository:
rL LLVM
https://revie
Author: caseycarter
Date: Wed Oct 26 15:18:13 2016
New Revision: 285234
URL: http://llvm.org/viewvc/llvm-project?rev=285234&view=rev
Log:
Cleanup nonportable behavior in tests for std::any
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
* "Moves are alway
CaseyCarter marked 2 inline comments as done.
CaseyCarter added a comment.
DecayTag destroyed.
https://reviews.llvm.org/D26007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CaseyCarter removed rL LLVM as the repository for this revision.
CaseyCarter updated this revision to Diff 75936.
CaseyCarter added a comment.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
- "Moves a
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the improved docs!
Repository:
rL LLVM
https://reviews.llvm.org/D25995
___
cfe-commits mailing list
cfe-comm
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25992
___
cfe-commits mailing list
cfe-commits@lists
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:1
+//===--===//
+//
--
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:74
+ if (Construct) {
+checkConstruct(SM, Construct, Type, New);
Can elide the braces for the `if` and `else`.
Comment at: clang-tidy/modernize/M
rsmith added inline comments.
Comment at: include/clang/Lex/Preprocessor.h:283-286
+ Off = 0,
+ Recording = 1,
+ Replaying = 2,
+ Done = 3
What's the difference between the `Off` and `Done` states? They seem to be the
same to me?
==
erikjv added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:2061-2062
+ auto Builder = Diag(R.getNameLoc(), diagnostic) << Name;
+ if (Name.isIdentifier())
+Builder << SourceRange(R.getNameLoc());
return true;
rsmith wrote:
> I'm indifferent on this
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2509
+to suppress specific clang-tidy warnings. They can be attached to a scope,
+statement or type. The ``[[gsl::suppress]]`` is an alias of
``[[clang::suppress]]``
+which is intended to be used fo
CaseyCarter added inline comments.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36
+using DecayTag = std::decay_t;
+static_assert(!std::is_constructible::value, "");
+}
I'm generously calling this a "libc++ extension." From my i
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
CaseyCarter set the repository for this revision to rL LLVM.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/a
rsmith added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:2061-2062
+ auto Builder = Diag(R.getNameLoc(), diagnostic) << Name;
+ if (Name.isIdentifier())
+Builder << SourceRange(R.getNameLoc());
return true;
I'm indifferent on this change: I don't
mclow.lists added inline comments.
Comment at: src/cxa_personality.cpp:363
+ "Unexpected TTypeEncoding");
(void)ttypeEncoding;
logan wrote:
> mclow.lists wrote:
> > It's not clear to me how this accomplishes what you want.
> > You're looking for
Author: nemanjai
Date: Wed Oct 26 14:27:11 2016
New Revision: 285229
URL: http://llvm.org/viewvc/llvm-project?rev=285229&view=rev
Log:
[PowerPC] Implement vector_insert_exp builtins - clang portion
This patch corresponds to review https://reviews.llvm.org/D25956.
Committing on behalf of Zaara Sye
CaseyCarter closed this revision.
CaseyCarter added a comment.
Committed as r285213.
https://reviews.llvm.org/D25958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:26
+ unless(hasAnyTemplateArgument(refersToType(voidType(,
+ hasAnyName("::std::plus", "::std::minus", "::std::multiplies",
+ "::std::divides", "::s
xazax.hun removed rL LLVM as the repository for this revision.
xazax.hun updated this revision to Diff 75923.
https://reviews.llvm.org/D25985
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/ExprEngine.cpp
test/
aaron.ballman added a comment.
clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo was added and should not have
been; also, there's one minor issue with the diagnostic wording that is still
outstanding.
Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35
+ diag(MatchedDec
syzaara created this revision.
syzaara added reviewers: nemanjai, kbarton, amehsan, sfertile, jtony, lei.
syzaara added subscribers: cfe-commits, echristo.
Implement builtins for prototypes:
signed int vec_cntlz_lsbb (vector signed char);
signed int vec_cntlz_lsbb (vector unsigned char);
signed in
Author: nemanjai
Date: Wed Oct 26 13:25:45 2016
New Revision: 285218
URL: http://llvm.org/viewvc/llvm-project?rev=285218&view=rev
Log:
[PPC] Implement vector reverse elements builtins (vec_reve)
This patch corresponds to review https://reviews.llvm.org/D25906.
Committing on behalf of Tony Jiang.
chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.
Please add a stub tree and tests. You can find similar tests for other Linux
distros in 'tests/Driver'.
https://reviews.llvm.org/D25604
erichkeane updated this revision to Diff 75919.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/Specifiers.h
include/clang/Basic/TokenKinds.def
lib/AST/Expr.cpp
erichkeane marked 8 inline comments as done.
erichkeane added a comment.
New diff coming that fixes Reid & David's comments
https://reviews.llvm.org/D25204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
majnemer added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:433
Out << Prefix;
+
mangleName(D);
Please remove this stray newline.
Comment at: lib/CodeGen/TargetInfo.cpp:
+ if (classifyArgumentType(FD->getType(),
+
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: include/clang/Basic/Attr.td:1291
+ let Subjects = SubjectList<[ObjCInterface], ErrorDiag>;
+ let Documentation = [Undocumented];
+}
Author: caseycarter
Date: Wed Oct 26 12:22:25 2016
New Revision: 285213
URL: http://llvm.org/viewvc/llvm-project?rev=285213&view=rev
Log:
Silence unused parameter warnings in archetypes.hpp
Reviewed at: https://reviews.llvm.org/D25958
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modif
manmanren accepted this revision.
manmanren added a reviewer: manmanren.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cf
If you're working on it, let's just wait for that :-)
On Wed, Oct 26, 2016 at 12:01 PM, Erik Pilkington wrote:
> Hi Nico,
> All that is left for the diagnostic to make sense it CodeGen support for
> @available, which is something I’m working on now. I should have a patch up
> for it in a couple
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks!
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya updated this revision to Diff 75915.
hiraditya added a comment.
Added macro to keep the definition of destructor of basic_string in string.cpp
https://reviews.llvm.org/D25624
Files:
libcxx/include/string
libcxx/src/string.cpp
Index: libcxx/src/string.cpp
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Please add a line testing the nested-array case to warn-unused-variables.cpp,
but with that, LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25937
__
jordan_rose added a comment.
Looks good from my end.
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:1263
+On x86 targets, this attribute changes the calling convention to
+__regcall convention. This convention aims to pass as many arguments
+as possible in registers. It also tries to utilize registers for th
Author: yaxunl
Date: Wed Oct 26 11:40:21 2016
New Revision: 285211
URL: http://llvm.org/viewvc/llvm-project?rev=285211&view=rev
Log:
AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.
Patch by Laurent Morichetti.
Differential Revision: https://reviews.llvm.org/D25920
Modified:
cfe/trunk/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285211: AMDGPU: Add missing ISA versions gfx7.x.x and 8.x.x.
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D25920?vs=75627&id=75912#toc
Repository:
rL LLVM
https://reviews.
sebpop marked 2 inline comments as done.
sebpop added inline comments.
Comment at: libcxx/include/memory:3802
+{
+ return __libcpp_atomic_add(&t, 1, _AO_Relaxed);
+}
EricWF wrote:
> Why add `increment` and `decrement` at all? Just manually inline
> `__libcpp_at
sebpop removed rL LLVM as the repository for this revision.
sebpop updated this revision to Diff 75908.
sebpop added a comment.
The patch also implements the idea that Marshall proposed in:
http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161010/173780.html
> I have an idea; it involves
tstellarAMD added a comment.
LGTM.
https://reviews.llvm.org/D25920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
arphaman added a reviewer: aaron.ballman.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds a bit of documentation for the `transparent_union` attribute.
Repository:
rL LLVM
https://reviews.llvm.
erichkeane added a comment.
After much debate, the architects have agreed to change the "Decoration"
section to the following.
The next patch does these, so I'm ready for continued review. Thanks for your
patience!
-Erich
__regcall Decoration
Names of functions that use __regcall are decorate
erichkeane updated this revision to Diff 75903.
erichkeane added a comment.
Corrected Decoration settings to match the soon-to-be-updated spec.
https://reviews.llvm.org/D25204
Files:
include/clang-c/Index.h
include/clang/AST/Type.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDoc
1 - 100 of 138 matches
Mail list logo
