r283085 - Keep the test only for Itanium abi

2016-10-02 Thread Aditya Kumar via cfe-commits
Author: hiraditya Date: Sun Oct 2 21:36:33 2016 New Revision: 283085 URL: http://llvm.org/viewvc/llvm-project?rev=283085&view=rev Log: Keep the test only for Itanium abi Modified: cfe/trunk/test/CodeGenCXX/alias-available-externally.cpp Modified: cfe/trunk/test/CodeGenCXX/alias-available-ex

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

2016-10-02 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Going to accept this pending the backend patch, but when that one is applied I wanted you to feel OK to add this. A couple of inline nitpick comments and some agreement that we should do s

[PATCH] D25171: clang-format: Add two new formatting options

2016-10-02 Thread Robin Sommer via cfe-commits
rsmmr created this revision. rsmmr added reviewers: djasper, lodato. rsmmr added a subscriber: cfe-commits. Herald added a subscriber: klimek. This patch adds two new options, feedback welcome. SpacesAroundConditions (bool) If true, spaces will be inserted around if/for/while conditions. Spac

[PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

2016-10-02 Thread Victor Leschuk via cfe-commits
vleschuk marked 3 inline comments as done. vleschuk added inline comments. > vleschuk wrote in CGDebugInfo.cpp:608 > Will check if this works in all cases. I think it's worth putting this > snippet into helper function within anon namespace. That is correct for types, for particular decls we st

[PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

2016-10-02 Thread Victor Leschuk via cfe-commits
vleschuk updated this revision to Diff 73228. vleschuk added a comment. - Move alignment detection into helper functions in anon namespace - Use updated LLVM DIBuilder API (from https://reviews.llvm.org/D24425) https://reviews.llvm.org/D24426 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/C

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-02 Thread Steve O'Brien via cfe-commits
elsteveogrande updated this revision to Diff 73224. elsteveogrande added a comment. Updated to actually use the include token's text, not a hardcoded `#include`. Updated unit test to expect the right word here. https://reviews.llvm.org/D25153 Files: include/clang/Driver/Options.td include

[PATCH] D25166: [CUDA] Mark device functions as nounwind.

2016-10-02 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. This prevents clang from emitting 'invoke's and catch statements. Things previously mostly worked thanks to TryToMarkNoThrow() in CodeGenFunction. But this is not a proper IPO, and it doesn't prop

[PATCH] D25161: [cmake] Install 'clang-cpp' symlink

2016-10-02 Thread Michał Górny via cfe-commits
mgorny added a comment. Thanks for the review. Proceeding with the commit now. https://reviews.llvm.org/D25161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r283075 - [cmake] Install 'clang-cpp' symlink

2016-10-02 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Sun Oct 2 14:28:57 2016 New Revision: 283075 URL: http://llvm.org/viewvc/llvm-project?rev=283075&view=rev Log: [cmake] Install 'clang-cpp' symlink Install the 'clang-cpp' symlink used to spawn the preprocessor. The code handling this suffix is already included in Driver. Fre

r283073 - [AVX-512] Use native IR for masked 512-bit add/sub/mul/div ps/pd intrinsics when rounding mode isn't used.

2016-10-02 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Oct 2 12:43:00 2016 New Revision: 283073 URL: http://llvm.org/viewvc/llvm-project?rev=283073&view=rev Log: [AVX-512] Use native IR for masked 512-bit add/sub/mul/div ps/pd intrinsics when rounding mode isn't used. Modified: cfe/trunk/lib/Headers/avx512fintrin.h

[PATCH] D25161: [cmake] Install 'clang-cpp' symlink

2016-10-02 Thread Joerg Sonnenberger via cfe-commits
joerg accepted this revision. joerg added a reviewer: joerg. joerg added a comment. This revision is now accepted and ready to land. LGTM, have been doing that in NetBSD for ages as well. Side note, someone from Apple please make sure that xcode gets a similar link. https://reviews.llvm.org/D25

[PATCH] D25123: [OpenCL] Fix bug in __builtin_astype causing invalid LLVM cast instructions

2016-10-02 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! https://reviews.llvm.org/D25123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: r283063 - Alias must point to a definition

2016-10-02 Thread Yaron Keren via cfe-commits
The mangling is different when targeting MSVC ABI, see failure at http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/29889/steps/test_all/logs/Clang%20%3A%3A%20CodeGenCXX__alias-available-externally.cpp maybe -triple x86_64-pc-linux ? 2016-10-02 6:06 GMT+03:00 Aditya Kumar via cfe-com

[PATCH] D24933: Enable configuration files in clang

2016-10-02 Thread Michał Górny via cfe-commits
mgorny requested changes to this revision. mgorny added a reviewer: mgorny. mgorny added a comment. This revision now requires changes to proceed. Few minor nits. However, I'd like to say that I like the idea in general and see forward to deploy it in Gentoo. One use case which doesn't seem to h

[PATCH] D24894: [clang-tidy] Prefer transparent functors to non-transparent one.

2016-10-02 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. > UseTransparentFunctorsCheck.cpp:26 > + unless(hasAnyTemplateArgument(refersToType(voidType(, > + hasAnyName("::std::plus", "::std::minus", "::std::multiplies", > + "::std::divides", "::std::modulus", "::std::negate", Should we

[PATCH] D25153: preprocessor supports `-dI` flag

2016-10-02 Thread Steve O'Brien via cfe-commits
elsteveogrande added a comment. Added a couple of notes > PrintPreprocessedOutput.cpp:241 >} > - >return false; Re-reading this diff, I saw hat my editor trimmed EOL whitespace automatically and I let these minor changes become part of the patch. Sorry for the noise :) > PrintPrep

r283068 - [CUDA] Allow extern __shared__ on empty-length arrays.

2016-10-02 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Sun Oct 2 10:24:50 2016 New Revision: 283068 URL: http://llvm.org/viewvc/llvm-project?rev=283068&view=rev Log: [CUDA] Allow extern __shared__ on empty-length arrays. "extern __shared__ int x[]" is OK. Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/test/Sema

[clang-tools-extra] r283067 - [clang-rename] Overhaul clang-rename.el.

2016-10-02 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Sun Oct 2 09:51:33 2016 New Revision: 283067 URL: http://llvm.org/viewvc/llvm-project?rev=283067&view=rev Log: [clang-rename] Overhaul clang-rename.el. * Use lexical binding, as recommended for new libraries. * Fix customization variable (set correct group and type). * Crea

[PATCH] D25008: [libcxx] Include unwinder library in the linker script

2016-10-02 Thread Michał Górny via cfe-commits
mgorny planned changes to this revision. mgorny added a comment. I will be reworking this to use CMake's PRIVATE and PUBLIC linked libs consistently across the build, linker scripts and possibly tests. @EricWF, would you prefer if I killed the `add_library_flags*` macros or extended them to sup

[PATCH] D25162: Make DeletedLines local variables in checkEmptyNamespace.

2016-10-02 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: djasper. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. https://reviews.llvm.org/D25162 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp

[PATCH] D25161: [cmake] Install 'clang-cpp' symlink

2016-10-02 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: beanz, doug.gregor. mgorny added a subscriber: cfe-commits. Herald added a subscriber: emaste. Install the 'clang-cpp' symlink used to spawn the preprocessor. The code handling this suffix is already included in Driver. FreeBSD is already crea