mgorny added a comment.
@rafael, ping. Could you review this, please? This is the solution you
suggested on the bug.
https://reviews.llvm.org/D23754
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
omtcyfz updated this revision to Diff 72604.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Address two comments from Alex.
https://reviews.llvm.org/D24914
Files:
clang-rename/RenamingAction.cpp
Index: clang-rename/RenamingAction.cpp
==
mgorny retitled this revision from "[libcxx] [cmake] Stop stripping -m32 from
compiler flags" to "[libcxx] [cmake] Strip possibly-inherited compiler flags in
in-tree build only".
mgorny updated the summary for this revision.
mgorny added a reviewer: beanz.
mgorny updated this revision to Diff 726
mgorny added a comment.
In https://reviews.llvm.org/D24809#553415, @EricWF wrote:
> > Stop stripping -m32 from the user-supplied flags. There is no valid reason
> > to do that, stripping it silently is thoroughly confusing and makes it
> > impossible to do distribution multi-ABI builds without
vsk added a subscriber: vsk.
vsk added a comment.
It should be fine to XFAIL this test temporarily. Is there a PR for this?
https://reviews.llvm.org/D24601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
vitalybuka added a comment.
My assumption is that "start" makes access valid, and "end" makes access
invalid, up to the next "start".
I see no problems problems with loops and multiple regions, as soon as access
is happening between start and end. Loops always call "start" for nested alloca
on
mclow.lists accepted this revision.
mclow.lists added a comment.
I guess this is OK. I'd rather not have naked `_WIN32` references outside of
<__config>, but this is not the first one.
https://reviews.llvm.org/D14259
___
cfe-commits mailing list
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282470: [libc++abi] Default to DLL annotations on Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24945?vs=72598&id=72599#toc
Repository:
rL LLVM
https://reviews.ll
Author: smeenai
Date: Mon Sep 26 22:44:09 2016
New Revision: 282470
URL: http://llvm.org/viewvc/llvm-project?rev=282470&view=rev
Log:
[libc++abi] Default to DLL annotations on Windows
`__declspec(dllexport)` and `__declspec(dllimport)` should only be used
when building libc++abi as a DLL, but tha
smeenai updated this revision to Diff 72598.
smeenai added a comment.
Addressing @EricWF's comment
https://reviews.llvm.org/D24945
Files:
CMakeLists.txt
include/__cxxabi_config.h
Index: include/__cxxabi_config.h
===
--- includ
smeenai marked an inline comment as done.
smeenai added a comment.
https://reviews.llvm.org/D24945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM.
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Sep 26 21:13:27 2016
New Revision: 282468
URL: http://llvm.org/viewvc/llvm-project?rev=282468&view=rev
Log:
Fix possible division by zero
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified: libcxx/trunk/src/experimental/filesystem/operations.c
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
https://reviews.llvm.org/D24119
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
EricWF added a comment.
> Stop stripping -m32 from the user-supplied flags. There is no valid reason to
> do that, stripping it silently is thoroughly confusing and makes it
> impossible to do distribution multi-ABI builds without resorting to ugly
> hacks.
The reason for stripping it is conf
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL259651.
https://reviews.llvm.org/D13280
___
cfe-commits mailing list
cfe-commits@lists.ll
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL249301.
https://reviews.llvm.org/D13349
___
cfe-commits mailing list
cfe-commits@lists.ll
rsmith added a comment.
Before we start with heroics here, we should consider whether the LLVM
intrinsics are actually specified the right way. The current specification does
the wrong thing for even trivial cases, such as a variable declared within a
loop, so there's some impedance mismatch be
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments. Unfortunately libc++abi doesn't have a
way to make `_LIBCXXABI_DISABLE_DLL_IMPORT_EXPORT` persistent, but this
solution works for now.
===
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D13419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Author: ericwf
Date: Mon Sep 26 20:28:47 2016
New Revision: 282466
URL: http://llvm.org/viewvc/llvm-project?rev=282466&view=rev
Log:
Remove out of date items in TODO.txt
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/TOD
ahatanak added a comment.
This looks fine to me.
https://reviews.llvm.org/D23236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Sep 26, 2016 at 5:57 PM, Kostya Serebryany via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Looks like yours:
>
> FAILED: tools/clang/lib/CodeGen/CMakeFiles/clangCodeGen.dir/CGExpr.cpp.obj
> C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~1\cl.exe /nologo /TP
> -DCLANG_ENABLE_ARCMT -DCLANG_E
Author: rsmith
Date: Mon Sep 26 19:53:24 2016
New Revision: 282464
URL: http://llvm.org/viewvc/llvm-project?rev=282464&view=rev
Log:
Remove default argument from lambda to appease old MSVC.
Modified:
cfe/trunk/lib/CodeGen/CGExpr.cpp
Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp
URL:
http://llv
Author: rsmith
Date: Mon Sep 26 19:52:29 2016
New Revision: 282463
URL: http://llvm.org/viewvc/llvm-project?rev=282463&view=rev
Log:
Defend test against differences between 32-bit and 64-bit MSABI manglings.
Modified:
cfe/trunk/test/CodeGenCXX/cxx1z-eval-order.cpp
Modified: cfe/trunk/test/Co
Looks like yours:
FAILED: tools/clang/lib/CodeGen/CMakeFiles/clangCodeGen.dir/CGExpr.cpp.obj
C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~1\cl.exe /nologo /TP
-DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER
-DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -DUNICODE
-D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_
aprantl added a comment.
Awesome. Sorry!
Repository:
rL LLVM
https://reviews.llvm.org/D24820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL250536.
https://reviews.llvm.org/D13813
___
cfe-commits mailing list
cfe-commits@lists.ll
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D13891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: rsmith
Date: Mon Sep 26 18:56:57 2016
New Revision: 282457
URL: http://llvm.org/viewvc/llvm-project?rev=282457&view=rev
Log:
P0145R3 (C++17 evaluation order tweaks): evaluate the base expression before
the pointer-to-member expression in calls through .* and ->* expressions.
Modified:
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
https://reviews.llvm.org/D24946
Files:
lib/Driver/ToolChains.cpp
lib/Headers/__clang_cuda_runtime_wrapper.h
test/Driver/Inputs/CUDA/usr/local/cuda/nvvm/libdevice
Author: rsmith
Date: Mon Sep 26 18:49:47 2016
New Revision: 282453
URL: http://llvm.org/viewvc/llvm-project?rev=282453&view=rev
Log:
P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array
subscripting before the RHS, regardless of which is the base and which is the
index.
Add
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
`__declspec(dllexport)` and `__declspec(dllimport)` should only be used
when building libc++abi as a DLL, but that's the more com
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D14259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL252170.
https://reviews.llvm.org/D14353
___
cfe-commits mailing list
cfe-commits@lists.ll
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Herald added subscribers: jlebar, jholewinski.
https://reviews.llvm.org/D24944
Files:
include/clang/Basic/BuiltinsNVPTX.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-n
Author: oleg
Date: Mon Sep 26 16:39:38 2016
New Revision: 282446
URL: http://llvm.org/viewvc/llvm-project?rev=282446&view=rev
Log:
[libc++] Fix typos causing compilation errors when _LIBCPP_DEBUG_LEVEL >= 2
Summary: This patch fixes a couple of typos that cause compilation errors when
applicatio
EricWF added a comment.
LGTM other than the inline comments. I'll give it a final once over tonight or
tomorrow.
Comment at: include/__cxxabi_config.h:36
@@ -35,1 +35,3 @@
#endif
+ #if defined(_MSC_VER) && !defined(__clang__)
+ // Using Microsoft Visual C++ compiler
loladiro updated this revision to Diff 72581.
loladiro added a comment.
back to _VSTD::forward, address review comments, add tests for non-empty
deleter and unique_ptrs of arrays.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
Files:
include/memory
test/std/utilities/memory/unique.
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-rename/RenamingAction.cpp:73
@@ -73,1 +72,3 @@
llvm::Error Err = FileToReplaces[Replace.getFilePath()].add(Replace);
+ // FIXME: As for clang-rename, replacement
smeenai abandoned this revision.
smeenai added a comment.
Your patch looks good to me and is a nicer way of accomplishing this. Thanks
for taking care of it!
https://reviews.llvm.org/D24877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
compnerd closed this revision.
compnerd added a comment.
r282447
https://reviews.llvm.org/D24609
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I fixed this with a slightly different patch in r282449. I hope you don't mind
that I didn't use this patch, I just wanted to add support for generating
custom __config headers for static builds on Win
djasper closed this revision.
djasper added a comment.
Committed as r282448.
https://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon Sep 26 17:19:41 2016
New Revision: 282449
URL: http://llvm.org/viewvc/llvm-project?rev=282449&view=rev
Log:
Expect DLL builds on Windows by default and require a custom __config for static
builds.
On Windows the __declspec(dllimport) and __declspec(dllexport) attributes
r
Author: djasper
Date: Mon Sep 26 17:19:08 2016
New Revision: 282448
URL: http://llvm.org/viewvc/llvm-project?rev=282448&view=rev
Log:
[clang-format] Don't allow newline after uppercase Obj-C block return types
Fixes the following:
BOOL (^aaa)(void) = ^BOOL {
};
The first BOOL's token was get
ksuther updated this revision to Diff 72578.
ksuther added a comment.
Added a unit test.
https://reviews.llvm.org/D15643
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
Author: compnerd
Date: Mon Sep 26 17:12:43 2016
New Revision: 282447
URL: http://llvm.org/viewvc/llvm-project?rev=282447&view=rev
Log:
headers: add missing Windows ARM Interlocked intrinsics
On ARM, there are multiple versions of each of the intrinsics, with
acquire/relaxed/release barrier semant
djasper added a comment.
Ah, sorry for dropping this on the floor :(.
May I nonetheless ask you to add a test (unittests/Format/FormatTest.cpp)?
https://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D15643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL256838.
https://reviews.llvm.org/D15691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D15994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: rsmith
Date: Mon Sep 26 16:27:23 2016
New Revision: 282443
URL: http://llvm.org/viewvc/llvm-project?rev=282443&view=rev
Log:
[Modules TS] Diagnose 'export' declaration within 'export' declaration.
Modified:
cfe/trunk/include/clang/AST/DeclBase.h
cfe/trunk/include/clang/Basic/Diagn
andriigrynenko updated this revision to Diff 72571.
andriigrynenko added a comment.
Do CHECKs for all iterations of the loop.
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapcon
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r258107.
https://reviews.llvm.org/D16262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Was committed in r260265, but reverted in r260536.
https://reviews.llvm.org/D16761
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D16951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a comment.
It's fine. I just walk through all accepted revisions to find forgotten ones.
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ericwf
Date: Mon Sep 26 15:55:02 2016
New Revision: 282439
URL: http://llvm.org/viewvc/llvm-project?rev=282439&view=rev
Log:
[libc++] Extension: Make `move` and `forward` constexpr in C++11.
Summary:
`std::move` and `std::forward` were not marked constexpr in C++11. This can be
very dam
EricWF added a comment.
FYI `std::move` and `std::forward` are now constexpr in C++11. There is no need
to use `__forward`.
Repository:
rL LLVM
https://reviews.llvm.org/D24372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the inline comments.
Comment at: src/fallback_malloc.cpp:58
@@ +57,3 @@
+
+#define HEAP_SIZE 512
+char heap [ HEAP_SIZE ];
A static co
Correct. I haven't had a chance to get back to this. I'm aiming to pick it up
again in the next week or two, but if this is specifically blocking you, feel
free to rebase and commit on my behalf.
> On 2016-Sep-26, at 13:39, Eugene Zelenko wrote:
>
> Eugene.Zelenko added a subscriber: Eugene.
Author: matze
Date: Mon Sep 26 15:48:34 2016
New Revision: 282438
URL: http://llvm.org/viewvc/llvm-project?rev=282438&view=rev
Log:
Fix test on windows
Modified:
cfe/trunk/test/Driver/save-stats.c
Modified: cfe/trunk/test/Driver/save-stats.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trun
MatzeB added inline comments.
Comment at: test/Driver/save-stats.c:12
@@ +11,3 @@
+// RUN: %clang -target x86_64-apple-darwin -save-stats=obj -c -o
obj/dir/save-stats.o %s -### 2>&1 | FileCheck %s -check-prefix=CHECK-OBJ
+// CHECK-OBJ: "-stats-file=obj/dir{{/|}}save-stats.sta
rSerge updated this revision to Diff 72554.
rSerge added a comment.
Implemented a workaround for XFAIL not differentiating between `x86` and
`x86_64` because it searches for a substring in the triple string, thus `x86`
matches both `x86-X-Y-Z` and `x86_64-X-Y-Z`.
https://reviews.llvm.org/D2479
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199
@@ -164,7 +175,26 @@
ret += Run(argc - 1, 0, stack);
+// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]]
+// CHECK: Main context from: [[CHILD_STACK]] 524288
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282435: [include] Declare __STDC_*_MACROS for C++11 compat
in old libc (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24903?vs=72492&id=72552#toc
Repository:
rL LLVM
https:
Author: mgorny
Date: Mon Sep 26 15:20:00 2016
New Revision: 282435
URL: http://llvm.org/viewvc/llvm-project?rev=282435&view=rev
Log:
[include] Declare __STDC_*_MACROS for C++11 compat in old libc
Declare __STDC_FORMAT_MACROS, __STDC_LIMIT_MACROS and
__STDC_CONSTANT_MACROS before including real in
mgorny added a comment.
Ok. Thanks for the review.
https://reviews.llvm.org/D24903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D17840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D17890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
Repository:
rL LLVM
https://reviews.llvm.org/D17979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Please remove the `LIBCXX` macros before committing.
Comment at: include/stdint.h:118
@@ +117,3 @@
+# define __STDC_CONSTANT_MACROS
+# define __STDC_CONSTANT_MACROS_
aaron.ballman added a comment.
In https://reviews.llvm.org/D24886#552859, @rsmith wrote:
> Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This
> attribute is specified by the C++ core guidelines, not by clang, and
> presumably we want code using this attribute to be portable a
rsmith added a comment.
Giving this the name `[[clang::suppress(...)]]` seems unhelpful. This attribute
is specified by the C++ core guidelines, not by clang, and presumably we want
code using this attribute to be portable across implementations of the C++ code
guidelines. I'd suggest asking th
mstorsjo added a comment.
Ping, can someone commit this one now?
https://reviews.llvm.org/D24609
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin added a comment.
LGTM, added Richard in case he has something to add.
Repository:
rL LLVM
https://reviews.llvm.org/D24932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ddunbar added a comment.
I am too out of the loop on Clang development to be able to comment on the
specific direction, but I will just say that I am highly in favor of adding new
features in this direction. Thank you!
https://reviews.llvm.org/D24933
Nice!
-Hal
- Original Message -
> From: "Matthias Braun via cfe-commits"
> To: cfe-commits@lists.llvm.org
> Sent: Monday, September 26, 2016 1:53:34 PM
> Subject: r282426 - CC1: Add -save-stats option
>
> Author: matze
> Date: Mon Sep 26 13:53:34 2016
> New Revision: 282426
>
> URL: h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282426: CC1: Add -save-stats option (authored by matze).
Changed prior to commit:
https://reviews.llvm.org/D24820?vs=72376&id=72532#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24820
Files:
c
Author: matze
Date: Mon Sep 26 13:53:34 2016
New Revision: 282426
URL: http://llvm.org/viewvc/llvm-project?rev=282426&view=rev
Log:
CC1: Add -save-stats option
This option behaves in a similar spirit as -save-temps and writes
internal llvm statistics in json format to a file.
Differential Revisi
v.g.vassilev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102
@@ -95,5 +101,3 @@
// as a note.
-DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID);
-for (unsigned i = 1; i < Group.Sequences.size(); ++i) {
- DiagEng
compnerd added inline comments.
Comment at: src/config.h:41
@@ +40,3 @@
+defined(__CloudABI__) || \
+defined(__sun__)
+# define _LIBCXXABI_HAS_THREAD_API_PTHREAD
Can you change this to `defined(__sun__) && defined(_POSIX_THREADS)` at the
very least? The
hokein accepted this revision.
hokein added a comment.
LGTM.
https://reviews.llvm.org/D24862
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sepavloff created this revision.
sepavloff added reviewers: rnk, ddunbar.
sepavloff added a subscriber: cfe-commits.
The implementation follows the discussion in mail list
(http://lists.llvm.org/pipermail/cfe-dev/2016-September/050776.html).
Main part of the config file support is implemented in l
arphaman created this revision.
arphaman added a reviewer: DmitryPolukhin.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes PR 30440 by initializing CXXNameMangler's FunctionTypeDepth in
the two constructors added in r274222 (The
NoQ updated this revision to Diff 72521.
NoQ added a comment.
Addressed inline comments on the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278. Changed warning messages completely according
to Anna's comments in https://reviews.llvm
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
NoQ updated this revision to Diff 72520.
NoQ added a comment.
Addressed two inline comments by Devin in the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278.
https://reviews.llvm.org/D24915
Files:
lib/StaticAnalyzer/Checkers/Chec
NoQ updated this revision to Diff 72519.
NoQ marked 10 inline comments as done.
NoQ added a comment.
Addressed inline comments. Renamed extra notes to notes.
https://reviews.llvm.org/D24278
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/BugRepor
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! Commit in r282417
https://reviews.llvm.org/D24874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aaronballman
Date: Mon Sep 26 12:04:27 2016
New Revision: 282417
URL: http://llvm.org/viewvc/llvm-project?rev=282417&view=rev
Log:
Complete support for the cxxCtorInitializer() AST matcher so that it can be
used as a top-level matcher.
Modified:
cfe/trunk/include/clang/ASTMatchers/AS
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the clarifications!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3395
@@ -3392,1 +3394,3 @@
+/// \brief Matches variable/function decl
vbyakovlcl added inline comments.
Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticGroups.td:522
@@ -521,2 +521,3 @@
def GNUZeroVariadicMacroArguments :
DiagGroup<"gnu-zero-variadic-macro-arguments">;
+def GNUVecElemSize : DiagGroup<"gnu-vec-elem-size">;
def Fallback
omtcyfz added a comment.
@arphaman, thank you for the comments! Improved the wording.
https://reviews.llvm.org/D24914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 72511.
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Address two comments.
https://reviews.llvm.org/D24914
Files:
clang-rename/RenamingAction.cpp
Index: clang-rename/RenamingAction.cpp
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D24928
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
unittests/ASTMatchers/ASTMatchers
lukasza added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2119
@@ +2118,3 @@
+ "template \n"
+ "void Function(Namespace::Template param) {\n"
+ " param.Method();\n"
klimek wrote:
> Given your use case: why do we
bruno added a comment.
Ping
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 160 matches
Mail list logo
