This revision was automatically updated to reflect the committed changes.
Closed by commit rL282328: [libc++] Remove math_win32.h (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24879?vs=72330&id=72389#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24879
Files:
Author: smeenai
Date: Sat Sep 24 01:27:28 2016
New Revision: 282328
URL: http://llvm.org/viewvc/llvm-project?rev=282328&view=rev
Log:
[libc++] Remove math_win32.h
Visual Studio 2013 and onward have all the required functions in their
CRT headers, and we don't support older versions anymore.
Diff
smeenai added a comment.
It's worth noting that the entirety of the deleted file was guarded by a `#if
((_VC_CRT_MAJOR_VERSION-0) < 12)` anyway (i.e. it would only be included on
Visual Studio 2012 and below), so the code was already dead :)
https://reviews.llvm.org/D24879
_
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I'll take your word for it. Thanks for the patch.
https://reviews.llvm.org/D24879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282322: Remove excessive padding from RedeclarableResult
(authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D24754?vs=71903&id=72388#toc
Repository:
rL LLVM
https://reviews.ll
Author: alexshap
Date: Fri Sep 23 23:21:53 2016
New Revision: 282322
URL: http://llvm.org/viewvc/llvm-project?rev=282322&view=rev
Log:
Remove excessive padding from RedeclarableResult
This diff reorders the fields of the class RedeclarableResult
to remove excessive padding.
Test plan: make -j8
zaks.anna added a comment.
Here are more comments. Could you address/answer these and upload the latest
patch that compares NSNumber to other numbers?
Thanks!
Comment at: lib/StaticAnalyzer/Checkers/BoolConversionChecker.cpp:88
@@ +87,3 @@
+
+auto NSNumberExprM =
+
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:39
@@ -38,2 +38,3 @@
// generate a non-definition FunctionDecl too. Ignore those.
- unless
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: xazax
Date: Fri Sep 23 21:13:45 2016
New Revision: 282319
URL: http://llvm.org/viewvc/llvm-project?rev=282319&view=rev
Log:
[clang-tidy] Cleaning up language options.
Differential Revision: https://reviews.llvm.org/D24881
Modified:
clang-tools-extra/trunk/clang-tidy/cert/StrToNumChec
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
If this kind of an error is not too frequent, it might make sense as a clang
diagnostic, indeed. Having it in clang-tidy until then doesn't hurt, though.
Comment at
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282319: [clang-tidy] Cleaning up language options. (authored
by xazax).
Changed prior to commit:
https://reviews.llvm.org/D24881?vs=72341&id=72387#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: alexshap
Date: Fri Sep 23 21:07:19 2016
New Revision: 282318
URL: http://llvm.org/viewvc/llvm-project?rev=282318&view=rev
Log:
Remove excessive padding from ObjCCategoriesVisitor
This diff reorders the fields of ObjCCategoriesVisitor
to remove excessive padding.
Test plan: make -j8 che
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome, thanks!
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:303
@@ +302,3 @@
+if (!Loc.isMacroID())
+ break;
+Loc = SM.getImmediateExpansionRange(Loc)
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for the updates!
Please re-run the check on LLVM to see what has changed.
Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:53
@@ +52,3 @@
+}
+stat
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thank you for the cleanup! Please clang-format-diff the files before
submitting. Otherwise looks good.
Repository:
rL LLVM
https://reviews.llvm.org/D24881
__
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r264092.
https://reviews.llvm.org/D18325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D18639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a comment.
I think it's reasonable to compile code in C++11 with minimal changes (only
modernize-replace-auto-ptr is really needed) and test it before further
modernization.
Repository:
rL LLVM
https://reviews.llvm.org/D24881
_
xazax.hun added a comment.
In https://reviews.llvm.org/D24881#551487, @Eugene.Zelenko wrote:
> I think will be good idea to enable modernize-loop-convert,
> modernize-use-auto, modernize-use-default, modernize-use-nullptr only in
> C++11 mode.
>
> Probably modernize-avoid-bind code code be simp
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
I think will be good idea to enable modernize-loop-convert, modernize-use-auto,
modernize-use-default, modernize-use-nullptr only in C++11 mode.
Probably modernize-avoid-bind code code be simplified too.
Reposit
rizsotto.mailinglist closed this revision.
rizsotto.mailinglist added a comment.
commited at r282317
https://reviews.llvm.org/D19260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rizsotto
Date: Fri Sep 23 19:20:59 2016
New Revision: 282317
URL: http://llvm.org/viewvc/llvm-project?rev=282317&view=rev
Log:
[analyzer][scan-build-py] subprocess output handling reviewed in clang module
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
cfe/trunk/to
andrewford added a subscriber: andrewford.
andrewford added a comment.
This is breaking our android lldb build, because it uses std::to_string. Looks
like there is llvm::to_string, which should be preferred. Would someone mind
changing it? I don't have commit access or I would myself. :)
Than
arphaman added a comment.
(Forgot to mention) This is a a fix for the regression introduced by r274049.
Repository:
rL LLVM
https://reviews.llvm.org/D24884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
On Fri, Sep 23, 2016, 4:38 PM Andrew Ford wrote:
> andrewford added a subscriber: andrewford.
> andrewford added a comment.
>
> This is breaking our android lldb build, because it uses std::to_string.
> Looks like there is llvm::to_string, which should be preferred. Would
> someone mind changing
Hi Dmitry,
I think that this commit has caused a regression that's tracked by PR
30440. I'll try working on a fix for it.
Alex
On 30 June 2016 at 02:40, Dmitry Polukhin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dpolukhin
> Date: Thu Jun 30 04:40:38 2016
> New Revision: 2742
Eugene.Zelenko added a comment.
Please add dependencies to Differential revisions, so reasons for holding will
be clear.
https://reviews.llvm.org/D19170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
mlemay-intel added a comment.
In https://reviews.llvm.org/D19170#551426, @Eugene.Zelenko wrote:
> Looks like patch was not committed.
This patch, https://reviews.llvm.org/D17092, https://reviews.llvm.org/D17094,
and https://reviews.llvm.org/D17095 are all interdependent. I think it makes
sen
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D19170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D19260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
MatzeB added inline comments.
Comment at: test/Driver/save-stats.c:1
@@ +1,2 @@
+// RUN: %clang -target x86_64-apple-darwin -save-stats %s -### 2>&1 |
FileCheck %s
+// RUN: %clang -target x86_64-apple-darwin -save-stats=cwd %s -### 2>&1 |
FileCheck %s
bruno wrot
MatzeB updated this revision to Diff 72376.
MatzeB marked an inline comment as done.
MatzeB added a comment.
Thanks for the reviews.
Addressed comments.
Repository:
rL LLVM
https://reviews.llvm.org/D24820
Files:
docs/CommandGuide/clang.rst
include/clang/Basic/DiagnosticFrontendKinds.td
Author: tejohnson
Date: Fri Sep 23 17:25:03 2016
New Revision: 282308
URL: http://llvm.org/viewvc/llvm-project?rev=282308&view=rev
Log:
Use llvm::to_string instead of std::to_string to fix bot
This should fix the android build in this bot:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.0
That's not a great long-term solution for obvious reasons, but I think it's a
great quick fix.
Sent from my iPhone
> On Sep 23, 2016, at 5:53 PM, Hal Finkel wrote:
>
> We currently have logic in the test suite that sets -ffp-contract=off on
> PowerPC (because the default for GCC and other com
mlemay-intel added a comment.
In https://reviews.llvm.org/D19854#551260, @Eugene.Zelenko wrote:
> Looks like patch was not committed.
This patch is only useful in combination with https://reviews.llvm.org/D19852,
so I was waiting for that one to be approved so these can be committed at the
sa
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D24821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mgehre updated this revision to Diff 72366.
mgehre added a comment.
Include link to corresponding clang-tidy patch
https://reviews.llvm.org/D24886
Files:
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaStmtAttr.cpp
Index: lib/Sema/SemaStmtAttr.cpp
=
mgehre updated this revision to Diff 72365.
mgehre added a comment.
Minor fix
https://reviews.llvm.org/D24888
Files:
clang-tidy/cppcoreguidelines/ProTypeReinterpretCastCheck.cpp
clang-tidy/cppcoreguidelines/Suppression.h
docs/clang-tidy/checks/cppcoreguidelines-pro-type-reinterpret-cast.r
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman.
mgehre added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
This is a proof-of-concept how the [[clang::suppress(tags,...)]] attribute can
work with suppressing clang-tidy warnings.
The list of tags that
We currently have logic in the test suite that sets -ffp-contract=off on
PowerPC (because the default for GCC and other compilers on PowerPC/Linux
systems is essentially -ffp-contract=fast). We might just want to do this now
for all platforms.
-Hal
- Original Message -
> From: "Steve
Author: pcc
Date: Fri Sep 23 16:43:51 2016
New Revision: 282301
URL: http://llvm.org/viewvc/llvm-project?rev=282301&view=rev
Log:
Update clang for r282299.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.org/viewvc/llvm-projec
lukasza updated the summary for this revision.
lukasza updated this revision to Diff 72350.
lukasza marked an inline comment as done.
lukasza added a comment.
- Added test where both TemplateSpecializationType and TypedefType are present
and both should match regardless of code order inside
HasD
lukasza added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:750
@@ +749,3 @@
+else if (auto *ET = Node->getAs())
+ return matchesSpecialized(ET->getNamedType(), Finder, Builder);
+else if (auto *TST = Node->getAs())
luka
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8090
@@ +8089,3 @@
+ *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast);
+ return VecType;
+}
ahatanak wrote:
> Sorry I wasn't clear, but I was asking whether you were plan
Without digging into them yet, these are almost caused by overly-sensitive
tests that are erroneously expecting bit-exact results.
- Steve
Sent from my iPhone
> On Sep 23, 2016, at 4:42 PM, Renato Golin wrote:
>
> rengolin added a subscriber: rengolin.
> rengolin added a comment.
>
> Folks,
Author: compnerd
Date: Fri Sep 23 16:36:24 2016
New Revision: 282300
URL: http://llvm.org/viewvc/llvm-project?rev=282300&view=rev
Log:
annotate more function visibility
These data and text symbols were missing annotations for building with hidden
visibility. As we do not currently enable hidden
mgehre created this revision.
mgehre added reviewers: alexfh, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
This patch implements parsing of [[clang::suppress(rule, ...)]]
attributes.
C++ Core Guidelines depend heavily on tool support for
rule enforcement. They also propose a way
ahatanak updated this revision to Diff 72356.
ahatanak added a comment.
I agree that extending the logic of getTemplateInstantiationArgs seems like a
better approach. I changed Sema::getTemplateInstantiationArgs to search for the
template arguments twice, first for the initializer's template arg
ahatanak added a comment.
In https://reviews.llvm.org/D24693#551050, @vitalybuka wrote:
> I can see how to insert starts, e.g. on every label which bypass declaration,
> but I am not sure where to put ends.
> Probably it's possible, but patch will be significantly more complicated.
> I'd prefe
bruno added a comment.
Maybe add some docs to explain the new flags?
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
MatzeB wrote:
> bruno wrote:
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D19854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282293: [analyzer] Fix crash in
RetainCountChecker::checkEndFunction (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D24792?vs=72206&id=72354#toc
Repository:
rL LLVM
https:
Author: alexshap
Date: Fri Sep 23 15:49:01 2016
New Revision: 282293
URL: http://llvm.org/viewvc/llvm-project?rev=282293&view=rev
Log:
[analyzer] Fix crash in RetainCountChecker::checkEndFunction
The class BodyFarm creates bodies for
OSAtomicCompareAndSwap*, objc_atomicCompareAndSwap*, dispatch_s
beanz added a reviewer: rnk.
beanz added a comment.
This looks reasonable to me, but I'm not super familiar with multi-lib
conventions. I think @chandlerc is more familiar with how that stuff works.
https://reviews.llvm.org/D23752
___
cfe-commits m
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This fixes PR 30274 by making sure that we skip the 'Using' and
'ConstructorUsingShadowDecl' declarations when evaluating the
'__
Funny, git-svnrevert is buggy, I had to do it by hand, but now it's
done: r282289.
Let me know if you need help testing it.
--renato
On 23 September 2016 at 21:28, Renato Golin wrote:
> Now has broken the other:
>
> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
>
> But
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282291: [LTO] Add -flto-jobs=N to control backend
parallelism (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D24826?vs=72317&id=72349#toc
Repository:
rL LLVM
https://revi
Author: tejohnson
Date: Fri Sep 23 15:38:09 2016
New Revision: 282291
URL: http://llvm.org/viewvc/llvm-project?rev=282291&view=rev
Log:
[LTO] Add -flto-jobs=N to control backend parallelism
Summary:
Currently, a linker option must be used to control the backend
parallelism of ThinLTO. The linker
rengolin added a subscriber: rengolin.
rengolin added a comment.
Folks, this commit has broken both AArch64 test-suite buildbots:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/10449
I have reverted in r2
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r275460.
Repository:
rL LLVM
https://reviews.llvm.org/D22270
___
cfe-commits mailing list
cfe-commits@lists.llvm.
xazax.hun created this revision.
xazax.hun added reviewers: hokein, alexfh.
xazax.hun added a subscriber: cfe-commits.
xazax.hun set the repository for this revision to rL LLVM.
xazax.hun added a project: clang-tools-extra.
Herald added a subscriber: nemanjai.
In some cases do not register the mat
Now has broken the other:
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/3162
But when I try to revert, git get entangled with another commit and
brings a lot of unrelated changes to it.
I'll continue trying to revert, but if you can do it faster, I'd appreciate.
thanks!
--re
khazem added a comment.
This diff is a continuation of https://reviews.llvm.org/D14326, which was
accepted for inclusion but has not been merged in for the past couple of months.
I added a small patch so that it rebases cleanly onto master:
--- a/lib/AST/ASTImporter.cpp
+++ b/lib/AST/ASTImp
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks!
https://reviews.llvm.org/D24826
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 and onward have all the required functions in their
CRT headers, and we don't support older versions anymore.
https://reviews.llvm.org/D24879
Files:
khazem created this revision.
khazem added reviewers: spyffe, sepavloff.
khazem added subscribers: phosek, khazem, NoQ, xazax.hun, cfe-commits.
This patch implements some expression-related AST node import (patch #2).
- Some code cleanup
- Add tests not present in http://reviews.llvm.org/D14
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
On Windows builds, we currently require `_LIBCPP_DLL` to be specified in
order for dllexport/dllimport annotations to be generated. I believe
it's better to do the opposi
khazem added a comment.
I'm updating this patch so that it rebases cleanly onto master, as this patch
hasn't been updated for a couple of months...
At the time of writing, one of Clang's tests is failing with this patch.
Specifically, there is a segfault at line 130 of
test/ASTMerge/Inputs/exp
vitalybuka added a comment.
In https://reviews.llvm.org/D24693#550119, @ahatanak wrote:
> Thank you for the great example! I can now see this patch does fix
> mis-compiles.
>
> There are probably other lifetime bugs you'll see when the code being
> compiled includes gotos that jump past variabl
aturetsk abandoned this revision.
aturetsk added a comment.
New version in https://reviews.llvm.org/D21374
https://reviews.llvm.org/D21066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Hello,
https://reviews.llvm.org/D14326
has been accepted but hasn't seen any activity for a couple of months.
Are there any plans to merge it?
There is now a small conflict with master, which I have resolved in
the patch below. There is currently one test failing, which I am
working to fix now.
Do you have some data on the true/false positive rate for this warning?
On Fri, Sep 23, 2016 at 6:12 AM Daniel Marjamäki <
daniel.marjam...@evidente.se> wrote:
> danielmarjamaki created this revision.
> danielmarjamaki added reviewers: dblaikie, rtrieu.
> danielmarjamaki added a subscriber: cfe-c
tejohnson updated this revision to Diff 72317.
tejohnson added a comment.
Update option help message per Mehdi's suggestion
https://reviews.llvm.org/D24826
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/lto-jobs.c
Index: test/Driver/lto-jobs.c
===
MatzeB added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
bruno wrote:
> Why removing StatsFile here? IIUC, at this point StatsF
rSerge updated this revision to Diff 72312.
rSerge added a comment.
Herald added a subscriber: rampitec.
Added a test.
Changed the error message to:
> clang++.exe: error: the clang compiler does not support '-fxray-instrument on
> armv6kz--linux-gnueabihf'
https://reviews.llvm.org/D24799
Fil
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:6102
@@ +6101,3 @@
+StatsFile.assign(Output.getFilename());
+llvm::sys::path::remove_filename(StatsFile);
+ }
Why removing StatsFile here? IIUC, at this point StatsFile is still the
mehdi_amini added inline comments.
Comment at: include/clang/Driver/Options.td:818
@@ -815,1 +817,3 @@
+ HelpText<"Controls the backend parallelism of -flto=thin (default "
+ "of 0 means use std::thread::hardware_concurrency)">;
def fthinlto_index_EQ : Joined<["-"], "f
On 23 September 2016 at 17:12, Sjoerd Meijer wrote:
> I don't think I am committing at will: I thought it was okay to commit
> directly because it is a simple fix (or should be) for my own previous
> half-working patch, but I don't mind going through phab.
A review would have caught many issu
aaron.ballman created this revision.
aaron.ballman added reviewers: klimek, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
It turns out that our support for the `cxxCtorInitializer()` matcher was
incomplete in that it could not be used as a top-level mat
alexshap added a comment.
Thanks, Chris has recently granted me commit access, i will rebase, rerun all
the tests and then commit.
Repository:
rL LLVM
https://reviews.llvm.org/D24792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
zaks.anna added a comment.
Thanks!
@alexshap, Do yon have commit access or should we commit on your behalf?
Repository:
rL LLVM
https://reviews.llvm.org/D24792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
tejohnson added a comment.
> > I do see other uses of -mllvm in lib/Driver/Tools.cpp, but are you talking
> > about something else?
>
> I think this is okay, since clang is talking to the same version of
> libLTO.dylib. I feel like there might be another case where
> clang talks to libLTO
tejohnson updated this revision to Diff 72301.
tejohnson added a comment.
Update option description as per decision to split from parallel code gen.
https://reviews.llvm.org/D24826
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/lto-jobs.c
Index: test/Driver/lto-j
dim accepted this revision.
dim added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
On 23 September 2016 at 16:21, Sjoerd Meijer via cfe-commits
wrote:
> Author: sjoerdmeijer
> Date: Fri Sep 23 10:21:33 2016
> New Revision: 282255
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
> Log:
> Fix for r280064 that added options for fp denormals and exceptions.
> These o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282259: set the underlying value of “#pragma STDC
FP_CONTRACT” on by default (authored by spop).
Changed prior to commit:
https://reviews.llvm.org/D24481?vs=72186&id=72299#toc
Repository:
rL LLVM
ht
Nothing was breaking, but it wasn't working either (because those options were
not copied).
I've reverted the patch directly after the first buildbot failure.
I don't think I am committing at will: I thought it was okay to commit
directly because it is a simple fix (or should be) for my own pr
Author: sjoerdmeijer
Date: Fri Sep 23 10:37:17 2016
New Revision: 282257
URL: http://llvm.org/viewvc/llvm-project?rev=282257&view=rev
Log:
Revert of r282255 because of "Fell off the end of a string-switch" buildbot
failures.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk
mgorny added a comment.
For the record: I've tested the patch with and without zlib installed, using
in-tree and stand-alone builds.
https://reviews.llvm.org/D24869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
mgorny created this revision.
mgorny added reviewers: rsmith, beanz, samsonov.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Fix the test run to declare missing HAVE_LIBZ value in stand-alone builds,
using the LLVM_ENABLE_ZLIB that is exported in LLVMConfig.cmak
Author: sjoerdmeijer
Date: Fri Sep 23 10:21:33 2016
New Revision: 282255
URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
Log:
Fix for r280064 that added options for fp denormals and exceptions.
These options were forgotten to be copied in setCommandLineOpts.
Modified:
cfe/trunk/l
Author: ioeric
Date: Fri Sep 23 10:10:56 2016
New Revision: 282253
URL: http://llvm.org/viewvc/llvm-project?rev=282253&view=rev
Log:
[clang-format] support header deletion in cleanupAroundReplacemnts.
Summary:
- If a replacement has offset UINT_MAX, length 0, and a replacement text
that is an #
ioeric updated this revision to Diff 72284.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24862
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282253: [clang-format] support header deletion in
cleanupAroundReplacemnts. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24829?vs=72285&id=72286#toc
Repository:
rL LLVM
h
ioeric updated this revision to Diff 72285.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D24829
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTe
ioeric added a comment.
Thanks for the comments!
Comment at: change-namespace/ChangeNamespace.cpp:279
@@ -276,2 +278,3 @@
Finder->addMatcher(
- usingDecl(hasAnyUsingShadowDecl(IsInMovedNs)).bind("using_decl"), this);
+ usingDecl(IsInMovedNs, hasAnyUsingShadowDecl(de
emaste created this revision.
emaste added reviewers: dim, brooks.
emaste added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
It seems a bad idea to change the default in the middle of a release branch due
to possible changes in global ctor / dtor ordering between .ctors and
.ini
aaron.ballman added a comment.
In https://reviews.llvm.org/D24862#550665, @ioeric wrote:
> Sorry for the confusion. I guess I should've been clearer in the comments and
> patch summary... The changes would've been what we wanted even without the
> underlying bugs and would not be reverted after
ioeric added a comment.
In https://reviews.llvm.org/D24862#550654, @aaron.ballman wrote:
> In https://reviews.llvm.org/D24862#550646, @ioeric wrote:
>
> > Acked, and I totally agree with you :) It's just that the change in this
> > patch would still be valid after the underlying bugs are fixed,
1 - 100 of 141 matches
Mail list logo
