Re: Submodule semantics with macro guard

On 19 Sep 2016 6:53 pm, "Manman via cfe-commits" wrote: On Sep 19, 2016, at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: Your c.h is not correct. It would introduce a definition of c in every file where it's included, so it's not a modular header. Hi Richard, W

Re: [clang-tools-extra] r281954 - clang-change-namespace: Update libdeps.

Thanks for the fix! On Tue, Sep 20, 2016, 02:53 NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Mon Sep 19 19:44:45 2016 > New Revision: 281954 > > URL: http://llvm.org/viewvc/llvm-project?rev=281954&view=rev > Log: > clang-change-namespace: Update l

[PATCH] D24752: [Modules] Add missing dependencies to clang builtins modulemap

eladcohen created this revision. eladcohen added a reviewer: rsmith. eladcohen added a subscriber: cfe-commits. X86 intrinsic header files mm3dnow.h and wmmintrin.h include and depend on mmintrin.h and emmintrin.h respectively. This patch adds these missing dependencies to the corresponding submo

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. That sounds reasonable. https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: r281277 - [Sema] Fix PR30346: relax __builtin_object_size checks.

WFM; I'll put together a patch that only allows this under -fno-strict-aliasing. I'm entirely unfamiliar with struct-path-tbaa, so Hal, do you see a reason why struct-path-tbaa wouldn't play nicely with flexible arrays at the end of types? Glancing at it, I don't think it should cause problems, bu

Re: [PATCH] D24751: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position

majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D24751 ___ c

Re: [PATCH] D24751: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position

alexshap added a comment. F2434937: Screen Shot 2016-09-19 at 7.33.38 PM.png the order BufferStart, BufferEnd,BufferPtr,BufferStartLoc,CurToken works as well Repository: rL LLVM https://reviews.llvm.org/D24751 ___

[PATCH] D24751: [cleanup] Remove excessive padding from TextTokenRetokenizer::Position

alexshap created this revision. alexshap added reviewers: gribozavr, craig.topper. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Re

Re: Submodule semantics with macro guard

> On Sep 19, 2016, at 5:55 PM, Richard Smith via cfe-commits > wrote: > > Your c.h is not correct. It would introduce a definition of c in every file > where it's included, so it's not a modular header. Hi Richard, What do you mean by c.h is not correct? It is guarded by a macro, so if we ar

Buildbot numbers for the week of 9/11/2016 - 9/17/2016

Hello everyone, Below are some buildbot numbers for the last week of 9/11/2016 - 9/17/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 9/04/2016 - 9/10/201

Hello everyone, Below are some buildbot numbers for the week of 9/04/2016 - 9/10/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

Re: [PATCH] D24411: [Analyzer] Suppress false positives on the clang static analyzer

zaks.anna added a comment. The thread from cfe-dev is called "Clang Static Analyzer: False Positive Suppression Support": http://clang-developers.42468.n3.nabble.com/Clang-Static-Analyzer-False-Positive-Suppression-Support-tt4053071.html https://reviews.llvm.org/D24411 __

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna added a comment. This checker is now in alpha.unix, because it is new and is in active development. However, alpha checkers are not supported and are not turned on by default, so we should move it into unix package once we think it is ready to be used. Evaluation on a large real code

Re: Submodule semantics with macro guard

Your c.h is not correct. It would introduce a definition of c in every file where it's included, so it's not a modular header. On 19 Sep 2016 5:21 pm, "Manman via cfe-commits" wrote: > > Hi Richard & Ben, > > Given a simple testing case, where we have two submodules X.A (A.h) and > X.B (B.h, it

[clang-tools-extra] r281954 - clang-change-namespace: Update libdeps.

Author: chapuni Date: Mon Sep 19 19:44:45 2016 New Revision: 281954 URL: http://llvm.org/viewvc/llvm-project?rev=281954&view=rev Log: clang-change-namespace: Update libdeps. FIXME: It seems clangFormat is not referred. Modified: clang-tools-extra/trunk/change-namespace/tool/CMakeLists.txt M

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

@Valentin: It would be great if you could give it a go. I tried resurrecting it earlier today but noticed getDataLayout() had been removed and then I got tied up with other pending work. On Mon, Sep 19, 2016 at 5:11 PM, Valentin Churavy wrote: > vchuravy added a comment. > > @jpienaar are you pl

Re: [PATCH] D20392: [CodeView] Modify emitTypeInformation to use MemoryTypeTableBuilder

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r270106. https://reviews.llvm.org/D20392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D22577: Include unreferenced nested types in member list only for CodeView

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r276271. Please specify Differential revision in commit message. https://reviews.llvm.org/D22577 ___ cfe-commits mai

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. @jpienaar are you planning to work on this again? Or should I give it a go? https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Submodule semantics with macro guard

Hi Richard & Ben, Given a simple testing case, where we have two submodules X.A (A.h) and X.B (B.h, it includes C.h, and C.h is guarded with a macro), when we import X.A and then textually include a header C.h, we get redefinition error. This is because the macro guard is owned by module X.B t

Re: [PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

On 19 September 2016 at 15:58, John McCall wrote: > rjmccall added a comment. > > Actually, that should demonstrate the difference, assuming the LLVM > function looks through selects, since IRGen should generate that as a > select. > It doesn't look past the Value* you hand it. As well as isa, i

Re: [PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

rjmccall added a comment. Oh. One danger with invoking a generic LLVM routine is that they often expect a well-formed function, not something that is plausibly still being emitted. https://reviews.llvm.org/D24712 ___ cfe-commits mailing list cfe-c

Re: [PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

rjmccall added a comment. Actually, that should demonstrate the difference, assuming the LLVM function looks through selects, since IRGen should generate that as a select. https://reviews.llvm.org/D24712 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D24712: Replace 'isProvablyNonNull' with existing utility llvm::IsKnownNonNull.

rjmccall added a comment. The formation restrictions on ARC writeback conversions probably make this more-or-less impossible to test, but I can try to explain when they happen. They happen when you have an argument of type "id __strong *" and pass it as a parameter of type "id __autoreleasing

Re: [PATCH] D21863: Fix typo in atomic macros

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in r280607. https://reviews.llvm.org/D21863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lodato added a comment. Sorry for the delay - I haven't had a chance to review. I'll be sure to review by tomorrow. Thanks for the updates! https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D24319: clang-format: Add an option to git-clang-format to diff between to commits

lhchavez added a comment. Gentle ping. Is there anything else that needs addressing? Did I miss anything? https://reviews.llvm.org/D24319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D24743: Fix signatures of fallback tow(upper|lower)_l.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281936: Fix signatures of fallback tow(upper|lower)_l. (authored by danalbert). Changed prior to commit: https://reviews.llvm.org/D24743?vs=71871&id=71876#toc Repository: rL LLVM https://reviews.llv

[libcxx] r281936 - Fix signatures of fallback tow(upper|lower)_l.

Author: danalbert Date: Mon Sep 19 15:42:57 2016 New Revision: 281936 URL: http://llvm.org/viewvc/llvm-project?rev=281936&view=rev Log: Fix signatures of fallback tow(upper|lower)_l. Summary: These functions take and return wint_t, not int: http://pubs.opengroup.org/onlinepubs/9699919799/function

[clang-tools-extra] r281935 - Add missing dependency to change-namespace.

Author: ioeric Date: Mon Sep 19 15:41:39 2016 New Revision: 281935 URL: http://llvm.org/viewvc/llvm-project?rev=281935&view=rev Log: Add missing dependency to change-namespace. Modified: clang-tools-extra/trunk/change-namespace/tool/CMakeLists.txt clang-tools-extra/trunk/change-namespace/

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL281934: [analyzer] Calculate extent size for memory regions allocated by new expression. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D24307?vs=70821&id=71874#toc Repository:

r281934 - [analyzer] Calculate extent size for memory regions allocated by new expression.

Author: xazax Date: Mon Sep 19 15:39:52 2016 New Revision: 281934 URL: http://llvm.org/viewvc/llvm-project?rev=281934&view=rev Log: [analyzer] Calculate extent size for memory regions allocated by new expression. ArrayBoundChecker did not detect out of bounds memory access errors in case an array

Re: [PATCH] D24411: [Analyzer] Suppress false positives on the clang static analyzer

nikhgupt added a comment. In https://reviews.llvm.org/D24411#545381, @zaks.anna wrote: > It is not clear to me that we've reached a consensus on cfe-dev list that > suppressing with comments and printing the checker name is the way to go. I'm new to the LLVM upstreaming process and have not be

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

yaxunl added a comment. In https://reviews.llvm.org/D21698#540237, @Anastasia wrote: > I have made an experiment with a simple kernel: > > void foo1(void); > void foo2(void); > void foo3(void); > void foo4(void); > void foo5(void); > void foo6(void); > void foo7(void); > void foo8

[PATCH] D24743: Fix signatures of fallback tow(upper|lower)_l.

danalbert created this revision. danalbert added reviewers: EricWF, mclow.lists. danalbert added a subscriber: cfe-commits. danalbert set the repository for this revision to rL LLVM. These functions take and return wint_t, not int: http://pubs.opengroup.org/onlinepubs/9699919799/functions/towupper

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

bruno updated this revision to Diff 71870. bruno added a comment. Update again (now with the right patch) after Akira's comment https://reviews.llvm.org/D24472 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c ==

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

bruno updated this revision to Diff 71869. bruno marked an inline comment as done. bruno added a comment. Update after Akira's comment https://reviews.llvm.org/D24472 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c ===

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

bruno marked an inline comment as done. Comment at: lib/Sema/SemaExpr.cpp:8084 @@ +8083,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return LHSType; +} ahatanak wrote: > My understanding is that, when we have a compound

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL281925: [libc++] Fix extern template visibility for Windows (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24679?vs=71685&id=71861#toc Repository: rL LLVM https://reviews.

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 71862. vitalybuka added a comment. Test https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/CodeGen/VarBy

[libcxx] r281925 - [libc++] Fix extern template visibility for Windows

Author: smeenai Date: Mon Sep 19 13:29:07 2016 New Revision: 281925 URL: http://llvm.org/viewvc/llvm-project?rev=281925&view=rev Log: [libc++] Fix extern template visibility for Windows On Windows, marking an `extern template class` declaration as exported actually forces an instantiation, which

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

vitalybuka updated this revision to Diff 71860. vitalybuka added a comment. Fixed accidentally changed test https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h Index: lib/CodeGen/CodeGenFunction.h ===

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka updated this revision to Diff 71858. vitalybuka added a comment. recovered test https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarBypassDetector.cpp lib/Cod

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif smeenai wrote: > compnerd w

Re: [PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

vitalybuka updated this revision to Diff 71856. vitalybuka added a comment. Removed unrelated test https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h test/CodeGen/lifetime2.c Index: test/CodeGen/lifetime2.c ==

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

vitalybuka marked an inline comment as done. vitalybuka added a comment. The patch was split in two and I moved the test into the wrong one. I'll fix this. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

r281923 - Reorder initializers in CallStackFrame so that we don't get a warning.

Author: sfantao Date: Mon Sep 19 13:13:13 2016 New Revision: 281923 URL: http://llvm.org/viewvc/llvm-project?rev=281923&view=rev Log: Reorder initializers in CallStackFrame so that we don't get a warning. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.c

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

smeenai added inline comments. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif compnerd wrote: > Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a comment. It looks like the test case was removed when this patch we rebased. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r281920 - Trying to fix name conflict in change-namespace tool.

Author: ioeric Date: Mon Sep 19 12:58:59 2016 New Revision: 281920 URL: http://llvm.org/viewvc/llvm-project?rev=281920&view=rev Log: Trying to fix name conflict in change-namespace tool. Modified: clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp clang-tools-extra/trunk/change-

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

ahatanak added a subscriber: ahatanak. ahatanak added a comment. Can you add some test cases? https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24679: [libc++] Fix extern template visibility for Windows

compnerd added inline comments. Comment at: include/__config:559 @@ -554,1 +558,3 @@ +# define _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS +# define _LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS #endif Does it make sense for `_LIBCPP_CLASS_TEMPLATE_INSTANTIATION_VIS` to ever be

Re: [PATCH] D24690: Replace __ANDROID__ with __BIONIC__.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281921: Replace __ANDROID__ with __BIONIC__. (authored by danalbert). Changed prior to commit: https://reviews.llvm.org/D24690?vs=71714&id=71852#toc Repository: rL LLVM https://reviews.llvm.org/D246

[libcxx] r281921 - Replace __ANDROID__ with __BIONIC__.

Author: danalbert Date: Mon Sep 19 13:00:45 2016 New Revision: 281921 URL: http://llvm.org/viewvc/llvm-project?rev=281921&view=rev Log: Replace __ANDROID__ with __BIONIC__. Summary: None of these checks are specific to Android devices. If libc++ was used with Bionic on a normal Linux system these

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281918: A clang tool for changing surrouding namespaces of class/function definitions. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24183?vs=71689&id=71848#toc Repository:

[clang-tools-extra] r281918 - A clang tool for changing surrouding namespaces of class/function definitions.

Author: ioeric Date: Mon Sep 19 12:40:32 2016 New Revision: 281918 URL: http://llvm.org/viewvc/llvm-project?rev=281918&view=rev Log: A clang tool for changing surrouding namespaces of class/function definitions. Summary: A tool for changing surrouding namespaces of class/function definitions whil

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

yaxunl added inline comments. Comment at: lib/Sema/SemaExpr.cpp:3431 @@ -3410,1 +3430,3 @@ +.getSupportedOpenCLOpts() +.cl_khr_fp64) || getOpenCLOptions().cl_khr_fp64)) { This check (getLangOpt

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8084 @@ +8083,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return LHSType; +} My understanding is that, when we have a compound assign like "LHS += RHS",

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric added a comment. In https://reviews.llvm.org/D24380#544720, @hokein wrote: > Sorry for the delay. > The patch only contains an unittest for `HeaderGenerato`r, which is not > quite enough. Should we create a fake migrate-tool binary to illustrate APIs > usage? Done. Good idea. I want

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

ioeric updated this revision to Diff 71845. ioeric marked 4 inline comments as done. ioeric added a comment. - Added MigrationEnvironment class and a dummy migrate-tool binary. https://reviews.llvm.org/D24380 Files: CMakeLists.txt migrate-tool/AffectedFilesFinder.h migrate-tool/BuildManag

Re: r281278 - [DebugInfo] Deduplicate debug info limiting logic

On Mon, Sep 12, 2016 at 5:20 PM, David Blaikie wrote: > On Mon, Sep 12, 2016 at 5:09 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Mon Sep 12 19:01:23 2016 >> New Revision: 281278 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=281278&view=re

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

eugenis added inline comments. Comment at: lib/CodeGen/VarBypassDetector.h:50 @@ +49,3 @@ +public: + void Reset(const Stmt *Body); + rename to smth like StartFunction()? add some API documentation. https://reviews.llvm.org/D24693

r281915 - [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

Author: yaxunl Date: Mon Sep 19 12:11:22 2016 New Revision: 281915 URL: http://llvm.org/viewvc/llvm-project?rev=281915&view=rev Log: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled Modified: cfe/trunk/lib/Sema/SemaDecl.cpp cfe/trunk/test/SemaOpenCL/half.cl cfe/tru

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

yaxunl marked 6 inline comments as done. Comment at: lib/Sema/SemaDecl.cpp:7600 @@ +7599,3 @@ +// Do not diagnose half type since it is diagnosed as invalid argument +// type for any function eleswhere. +if (!PT->isHalfType()) Anastasia wrote: > -> els

Re: r281278 - [DebugInfo] Deduplicate debug info limiting logic

ping On Mon, Sep 12, 2016 at 5:20 PM David Blaikie wrote: > On Mon, Sep 12, 2016 at 5:09 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: rnk > Date: Mon Sep 12 19:01:23 2016 > New Revision: 281278 > > URL: http://llvm.org/viewvc/llvm-project?rev=281278&view=re

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. I have a potential test-case for this, but the patch doesn't apply cleanly to master so I was unable to test if this solves the problem. F2433038: strip.ll https://reviews.llvm.org/D9168 __

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Oh, sorry, I didn't see your response before I clicked abandoned. It has been a while, so this patch is pretty stale. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7599-7602 @@ -7595,3 +7598,6 @@ // of event_t type. -S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT; +// Do not diagnose half type since it is diagnosed as invalid argument +// ty

r281910 - Remove InstructionCombining and its related pass from sample pgo passes as we can handle "invoke" correctly.

Author: dehao Date: Mon Sep 19 11:02:52 2016 New Revision: 281910 URL: http://llvm.org/viewvc/llvm-project?rev=281910&view=rev Log: Remove InstructionCombining and its related pass from sample pgo passes as we can handle "invoke" correctly. Summary: We previously relies on InstructionCombining p

r281907 - Remove excessive padding from the struct CallStackFrame

Author: alexshap Date: Mon Sep 19 10:57:29 2016 New Revision: 281907 URL: http://llvm.org/viewvc/llvm-project?rev=281907&view=rev Log: Remove excessive padding from the struct CallStackFrame The struct CallStackFrame is in lib/AST/ExprConstant.cpp inside anonymous namespace. This diff reorders th

Re: [PATCH] D23901: Minor cleanup of the class CallStackFrame

This revision was automatically updated to reflect the committed changes. Closed by commit rL281907: Remove excessive padding from the struct CallStackFrame (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D23901?vs=69310&id=71838#toc Repository: rL LLVM https://rev

Re: [PATCH] D24235: [OpenCL] Improve double literal handling

neil.hickey added a reviewer: tstellarAMD. neil.hickey updated this revision to Diff 71837. neil.hickey added a comment. Herald added subscribers: yaxunl, wdng. There was a bug whereby an implicitcast was being applied from float to float, this caused issues later on in builin processing which ca

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

aaron.ballman added a comment. In https://reviews.llvm.org/D24507#546241, @urusant wrote: > Thank you for the feedback. > > > The patch is missing Sema tests for the attribute (that it only applies to > > declarations you expect, accepts no args, etc). > > > There is one test case for that in te

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

JDevlieghere updated this revision to Diff 71835. JDevlieghere added a comment. Herald added subscribers: mgorny, beanz. Still working on comment #2 from Alex but wanted to update my diff since it's been a while and I haven't gotten around to looking into it further. So no need to review yet.

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

sebpop added a comment. The change looks good to me. Somebody else should approve. https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

daphnediane added a comment. In https://reviews.llvm.org/D24703#545917, @djasper wrote: > Looks good. Thank you! Thanks. Are there additional steps I need to get it commited or do I just wait for a commiter to notice? https://reviews.llvm.org/D24703 ___

Re: [PATCH] D24666: [OpenCL] Allow half type kernel argument when cl_khr_fp16 is enabled

bader added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7599-7602 @@ -7595,3 +7598,6 @@ // of event_t type. -S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT; +// Do not diagnose half type since it is diagnosed as invalid argument +// typ

Re: [PATCH] D24717: Merge deletions that are contained in a larger deletion.

ioeric added a comment. In https://reviews.llvm.org/D24717#546279, @djasper wrote: > I actually think this is a good example. So lets assume we'd write a tool to > fully quote binary expressions, e.g. that turns > > if (a * b + c * d == 10) ... > > > into > > if (((a * b) + (c * d)) == 10

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

hiraditya marked 2 inline comments as done. hiraditya added a comment. https://reviews.llvm.org/D24682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24682: [PR30341] Alias must point to a definition

hiraditya updated this revision to Diff 71827. hiraditya added a comment. Added a test case (contributed by Eric). https://reviews.llvm.org/D24682 Files: clang/lib/CodeGen/CGCXX.cpp clang/test/CodeGenCXX/alias-available-externally.cpp Index: clang/test/CodeGenCXX/alias-available-externally

Re: [PATCH] D24626: [OpenCL] Diagnose assignment to dereference of half type pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL281904: [OpenCL] Diagnose assignment to dereference of half type pointer (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D24626?vs=71548&id=71823#toc Repository: rL LLVM http

r281904 - [OpenCL] Diagnose assignment to dereference of half type pointer

Author: yaxunl Date: Mon Sep 19 09:54:41 2016 New Revision: 281904 URL: http://llvm.org/viewvc/llvm-project?rev=281904&view=rev Log: [OpenCL] Diagnose assignment to dereference of half type pointer Differential Revision: https://reviews.llvm.org/D24626 Modified: cfe/trunk/include/clang/Basic

Re: [PATCH] D24717: Merge deletions that are contained in a larger deletion.

djasper added a comment. I actually think this is a good example. So lets assume we'd write a tool to fully quote binary expressions, e.g. that turns if (a * b + c * d == 10) ... into if (((a * b) + (c * d)) == 10) ... So, here, we would be inserting two "(" and two ")" at the same locati

Re: [PATCH] D24717: Merge deletions that are contained in a larger deletion.

ioeric added a comment. In https://reviews.llvm.org/D24717#546096, @djasper wrote: > Thinking about this some more, starting to merge deletions now, but only some > of them is a bit suspect. I think we either want to allow even more or > continue to be restrictive for now. > > I think fundament

Re: r281785 - CodeGen: Add more checks to nobuiltin.c test, add a negative test.

Hi, On 09/17/2016 12:05 AM, Peter Collingbourne via cfe-commits wrote: Author: pcc Date: Fri Sep 16 17:05:53 2016 New Revision: 281785 URL: http://llvm.org/viewvc/llvm-project?rev=281785&view=rev Log: CodeGen: Add more checks to nobuiltin.c test, add a negative test. Modified: cfe/trunk/te

Re: [PATCH] D16309: Use getCharWidth() instead of magic number

danielmarjamaki added a comment. ping. https://reviews.llvm.org/D16309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

daphnediane updated this revision to Diff 71767. daphnediane added a comment. Adds test case, changes to suggested fix allowing break after template opener that is not immediately followed by template closer. https://reviews.llvm.org/D24703 Files: lib/Format/TokenAnnotator.cpp unittests/Fo

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin updated this revision to Diff 71778. DmitryPolukhin marked an inline comment as done. https://reviews.llvm.org/D24704 Files: lib/AST/ItaniumMangle.cpp test/CodeGenCXX/mangle-abi-tag.cpp Index: test/CodeGenCXX/mangle-abi-tag.cpp =

Re: [PATCH] D24704: PR30401: Fix substitutions for functions with abi_tag

DmitryPolukhin added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:668 @@ -664,3 +667,3 @@ llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf); CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream); // Output name of the function

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

urusant added a comment. Thank you for the feedback. > The patch is missing Sema tests for the attribute (that it only applies to > declarations you expect, accepts no args, etc). There is one test case for that in test/ReturnNonBoolTestCompileTime.cpp. I've added another one for attribute ac

Re: [PATCH] D24507: Add attribute for return values that shouldn't be cast to bool

urusant updated this revision to Diff 71807. urusant added a comment. Made some changes based on the comments. Please refer to the replies below. Repository: rL LLVM https://reviews.llvm.org/D24507 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/D

[PATCH] [CMake] Pass NO_CMAKE_SYSTEM_PATH to find_library

Searching system path causes to find the host library and could lead to failure when cross-compiling. --- tools/libclang/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libclang/CMakeLists.txt b/tools/libclang/CMakeLists.txt index 630be12..7e5906a 100644 --

Re: [PATCH] D24628: [ASAN] Pass previous stack information through __sanitizer_finish_switch_fiber

dvyukov added a comment. We need a test that passes non-NULL to these arguments and shows how to use the returned values. Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199 @@ -164,7 +175,26 @@ ret += Run(argc - 1, 0, stack); +// CHECK: Child stack

r281899 - Reverting r281714 due to causing an assert when calling builtins that expect a double, from CL

Author: neil.hickey Date: Mon Sep 19 06:42:14 2016 New Revision: 281899 URL: http://llvm.org/viewvc/llvm-project?rev=281899&view=rev Log: Reverting r281714 due to causing an assert when calling builtins that expect a double, from CL Modified: cfe/trunk/lib/Sema/SemaExpr.cpp cfe/trunk/lib

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

malcolm.parsons updated this revision to Diff 71802. malcolm.parsons added a comment. Handle delegating and base class constructors https://reviews.llvm.org/D24339 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/Redundan

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

dkrupp added a comment. Thanks. Gabor, could you please merge this? I don't have commit right. https://reviews.llvm.org/D24307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24717: Merge deletions that are contained in a larger deletion.

djasper added a comment. Thinking about this some more, starting to merge deletions now, but only some of them is a bit suspect. I think we either want to allow even more or continue to be restrictive for now. I think fundamentally, there are two questions that we need to answer: 1. Is this so

[PATCH] D24719: [include-fixer] Add customized editor settings documents.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24719 Files: docs/include-fixer.rst Index: docs/include-fixer.rst === --- docs/include-fixer.rst +++

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

ioeric added inline comments. Comment at: clang-refactor/driver/ModuleManager.h:14-20 @@ +13,9 @@ +#include "clang/Basic/LLVM.h" +#include "llvm/ADT/StringRef.h" + +#include +#include +#include + +#include "core/RefactoringModule.h" + curdeius wrote: > I though

Re: [PATCH] D24606: Recommit r281457 "Supports adding insertion around non-insertion replacements".

This revision was automatically updated to reflect the committed changes. Closed by commit rL281891: Recommit r281457 "Supports adding insertion around non-insertion replacements". (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24606?vs=71777&id=71779#toc Repository:

  1   2   >