pirama added a comment.
Ping... I am not the author of this patch, but am interested in seeing the
issue fixed :)
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
compnerd added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
compnerd added a subscriber: compnerd.
compnerd added a comment.
So, the only thing that Im confused about is where does `__BIONIC__` get
defined?
Comment at: include/__config:766
@@ -761,3 +765,3 @@
// Most unix variants have catopen. These are the specific ones that don't.
Author: kcc
Date: Sat Sep 17 00:03:05 2016
New Revision: 281809
URL: http://llvm.org/viewvc/llvm-project?rev=281809&view=rev
Log:
[sanitizer-coverage] change trace-pc to use 8-byte guards
Modified:
cfe/trunk/docs/SanitizerCoverage.rst
Modified: cfe/trunk/docs/SanitizerCoverage.rst
URL:
http
rsmith added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:752
@@ -749,1 +751,3 @@
+else if (auto *TST = Node->getAs())
+ return matchesSpecialized(*TST, Finder, Builder);
else if (auto *TT = Node->getAs())
lukasza wrot
hfinkel added a comment.
In https://reviews.llvm.org/D18639#533807, @hfinkel wrote:
> In https://reviews.llvm.org/D18639#527285, @hfinkel wrote:
>
> > In https://reviews.llvm.org/D18639#515000, @hfinkel wrote:
> >
> > > Updated to use scheme suggested by Marshall.
> >
> >
> > Ping.
>
>
> Ping.
vitalybuka updated this revision to Diff 71721.
vitalybuka added a comment.
Rebase on https://reviews.llvm.org/D24695
https://reviews.llvm.org/D24693
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CMakeLists.txt
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/VarB
vitalybuka created this revision.
vitalybuka added a reviewer: eugenis.
vitalybuka added a subscriber: cfe-commits.
D24693 will need access to it from other places
https://reviews.llvm.org/D24695
Files:
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CodeGenFunction.cpp
lib/CodeGen/CodeGenFunction.h
vitalybuka created this revision.
vitalybuka added a reviewer: eugenis.
vitalybuka added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Current generation of lifetime intrinsics does not handle cases like:
{
char x;
l1:
bar(&x, 1);
}
goto l1;
Intrinsics were b
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:176-199
@@ -164,7 +175,26 @@
ret += Run(argc - 1, 0, stack);
+// CHECK: Child stack: [[CHILD_STACK:0x[0-9a-f]*]]
+// CHECK: Main context from: [[CHILD_STACK]] 524288
andriigrynenko updated this revision to Diff 71717.
andriigrynenko added a comment.
Addressing comments.
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapcontext_annotation.cc
I
Author: compnerd
Date: Fri Sep 16 18:41:13 2016
New Revision: 281798
URL: http://llvm.org/viewvc/llvm-project?rev=281798&view=rev
Log:
CodeGen: refactor the ObjC cstring literal creation
This refactors the cstring literal creation as mentioned in the couple of FIXMEs
littered in the various invoc
danalbert created this revision.
danalbert added reviewers: EricWF, mclow.lists.
danalbert added a subscriber: cfe-commits.
danalbert set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
None of these checks are specific to Android devices. If
Author: rsmith
Date: Fri Sep 16 18:30:39 2016
New Revision: 281797
URL: http://llvm.org/viewvc/llvm-project?rev=281797&view=rev
Log:
Fix a couple of wrong-code bugs in switch-on-constant optimization:
* recurse through intermediate LabelStmts and AttributedStmts when checking
whether a statem
zaks.anna added a comment.
I do not have any more comments; however, let's wait for @NoQ to review this as
well.
Thanks!
https://reviews.llvm.org/D24307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: pcc
Date: Fri Sep 16 17:56:12 2016
New Revision: 281796
URL: http://llvm.org/viewvc/llvm-project?rev=281796&view=rev
Log:
Add REQUIRES line.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/t
Author: tstellar
Date: Fri Sep 16 17:43:29 2016
New Revision: 281791
URL: http://llvm.org/viewvc/llvm-project?rev=281791&view=rev
Log:
amdgcn-amdhsa: Add get_global_size() implementation
Added:
libclc/trunk/amdgcn-amdhsa/lib/workitem/get_global_size.ll
Modified:
libclc/trunk/amdgcn-amdhsa
Author: tstellar
Date: Fri Sep 16 17:43:33 2016
New Revision: 281793
URL: http://llvm.org/viewvc/llvm-project?rev=281793&view=rev
Log:
configure: Add amdgcn-mesa-mesa3d target
Modified:
libclc/trunk/configure.py
Modified: libclc/trunk/configure.py
URL:
http://llvm.org/viewvc/llvm-project/li
Author: tstellar
Date: Fri Sep 16 17:43:31 2016
New Revision: 281792
URL: http://llvm.org/viewvc/llvm-project?rev=281792&view=rev
Log:
amdgcn-amdhsa: Add get_num_groups implementation
Added:
libclc/trunk/amdgcn-amdhsa/lib/workitem/get_num_groups.cl
Modified:
libclc/trunk/amdgcn-amdhsa/lib
twoh added a comment.
@rsmith Thank you for your review! I added tests to cxx11-crashes.cpp, as the
goal of this patch is not handling __has_* traits right but preventing ICE.
Also, I tried to use ConstructorUsingShadowDecl::getConstructor instead of
ConstructorUsingShadowDecl::getTargetDecl fo
twoh updated this revision to Diff 71711.
twoh added a comment.
Updated diff. For ConstructorUsingShadowDecl, test with its target
CXXConstructorDecl, but only when it is not a default/copy/move constructor.
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx11
Author: pcc
Date: Fri Sep 16 17:26:45 2016
New Revision: 281790
URL: http://llvm.org/viewvc/llvm-project?rev=281790&view=rev
Log:
Add target triples to fix test on non-x86.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
http://llvm.org/viewvc/
zaks.anna added a comment.
It is not clear to me that we've reached a consensus on cfe-dev list that
suppressing with comments and printing the checker name is the way to go.
https://reviews.llvm.org/D24411
___
cfe-commits mailing list
cfe-commits@
pcc created this revision.
pcc added reviewers: mehdi_amini, dexonsmith.
pcc added subscribers: llvm-commits, cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added subscribers: nhaehnle, nemanjai, mehdi_amini, jyknight, qcolombet.
This module flag is used to mark modules which were compi
Author: pcc
Date: Fri Sep 16 17:05:53 2016
New Revision: 281785
URL: http://llvm.org/viewvc/llvm-project?rev=281785&view=rev
Log:
CodeGen: Add more checks to nobuiltin.c test, add a negative test.
Modified:
cfe/trunk/test/CodeGen/nobuiltin.c
Modified: cfe/trunk/test/CodeGen/nobuiltin.c
URL:
bruno added a comment.
Ping!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D24472
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
filcab added a comment.
Please add some printf calls to the test, to show that you have the correct
stack+size, too.
Thanks for working on this.
Filipe
Comment at: lib/asan/asan_thread.cc:141
@@ -140,3 +140,3 @@
if (!fake_stack_save && current_fake_stack)
current_fake_
andriigrynenko updated this revision to Diff 71698.
andriigrynenko added a comment.
update unit test to use non-null values
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapconte
sebpop added inline comments.
Comment at: clang/lib/CodeGen/CGCXX.cpp:137
@@ -136,1 +136,3 @@
+ // r254170: Disallow aliases to available_externally.
+ if (TargetLinkage == llvm::GlobalValue::AvailableExternallyLinkage)
Please remove the reference to r254170.
hiraditya added a comment.
Please also see: https://reviews.llvm.org/D24682
https://reviews.llvm.org/D24599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hiraditya created this revision.
hiraditya added reviewers: rafael, eugenis.
hiraditya added subscribers: sebpop, mclow.lists, cfe-commits, EricWF.
Inlining the destructor caused the compiler to generate bad IR which failed the
Verifier in the backend.
https://llvm.org/bugs/show_bug.cgi?id=30341
dcoughlin added a comment.
This is awesome! I have some minor comments on the dealloc notes. It is also
fine to remove them entirely; we can add them in a later commit.
Comment at: lib/StaticAnalyzer/Checkers/CheckObjCDealloc.cpp:604
@@ -588,1 +603,3 @@
+addExtraNoteForDe
blastrock added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9
@@ -8,3 +8,3 @@
// This test is too subtle to try on non-x86 arch for now.
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86-target-arch
--
ioeric updated this revision to Diff 71689.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Updated commenting, and fix a bug in the binary.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamespace.cpp
chan
ioeric added a comment.
In https://reviews.llvm.org/D24663#544993, @klimek wrote:
> Test? Why are we doing this (should go into the CL description)?
There is no behavioral change intended, and the goal here is not to break any
test. A test for this change can be having an insertion and a delet
RKSimon added a subscriber: RKSimon.
Comment at: lib/Headers/avx512fintrin.h:9124
@@ +9123,3 @@
+{
+ return (__m128) __builtin_ia32_movss_mask ((__v4sf) __A, (__v4sf) __B,
+ (__v4sf) __W,
delena wrote:
> please try the following:
> if (__U)
> retu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281766: [libc++] Fix inline attribute for non-MSVC Windows
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D24678?vs=71680&id=71687#toc
Repository:
rL LLVM
https://reviews.l
Author: smeenai
Date: Fri Sep 16 14:12:54 2016
New Revision: 281766
URL: http://llvm.org/viewvc/llvm-project?rev=281766&view=rev
Log:
[libc++] Fix inline attribute for non-MSVC Windows
gcc and clang in gcc compatibility mode do not accept __forceinline. Use
the gcc attribute for them instead.
Di
dvyukov added a comment.
We need a test that passes non-NULL to these arguments and shows how to use the
returned values.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:47
@@ -46,3 +46,3 @@
CallNoReturn();
- __sanitizer_finish_switch_fiber();
+ __sanitizer
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
On Windows, marking an `extern template class` declaration as exported
actually forces an instantiation, which is not the desired behavior.
Instead, the actual explicit i
Eugene.Zelenko added inline comments.
Comment at: test/clang-tidy/readability-redundant-declaration.cpp:9
@@ +8,3 @@
+extern int A;
+extern int A,B;
+// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: redundant variable A declaration
Please run Clang-format over test.
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
https://reviews.llvm.org/D24678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
gcc and clang in gcc compatibility mode do not accept __forceinline. Use
the gcc attribute for them instead.
https://reviews.llvm.org/D24678
Files:
include/__config
yaxunl added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+// ty
andriigrynenko added inline comments.
Comment at: test/asan/TestCases/Linux/swapcontext_annotation.cc:9
@@ -8,3 +8,3 @@
// This test is too subtle to try on non-x86 arch for now.
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86-target-arch
-
andriigrynenko updated this revision to Diff 71677.
andriigrynenko added a comment.
fix the unit test
https://reviews.llvm.org/D24628
Files:
include/sanitizer/common_interface_defs.h
lib/asan/asan_thread.cc
lib/asan/asan_thread.h
test/asan/TestCases/Linux/swapcontext_annotation.cc
Inde
bader added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:7599-7602
@@ -7595,3 +7598,6 @@
// of event_t type.
-S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
+// Do not diagnose half type since it is diagnosed as invalid argument
+// typ
Author: niravd
Date: Fri Sep 16 12:42:02 2016
New Revision: 281753
URL: http://llvm.org/viewvc/llvm-project?rev=281753&view=rev
Log:
Introduce inline assembly parsing test is PR30372.
Added:
cfe/trunk/test/Sema/pr30372.c
Added: cfe/trunk/test/Sema/pr30372.c
URL:
http://llvm.org/viewvc/llvm-
dcoughlin added a comment.
In https://reviews.llvm.org/D20811#544981, @NoQ wrote:
> Hmm, what about
>
> CONSTRAIN
> ARGUMENT_VALUE(0, WithinRange)
> RANGE('0', '9')
> RANGE('A', 'Z')
> RANGE('a', 'z')
> END_ARGUMENT_VALUE
> RETURN_VALUE(OutOfRange)
> VALUE(0)
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Will be good idea to detect redundant function prototypes.
However, I think this check should be part of Clang diagnostics. GCC has
-Wre
smeenai added a subscriber: smeenai.
Comment at: docs/DesignDocs/VisibilityMacros.rst:33
@@ +32,3 @@
+ Mark a type's typeinfo and vtable as having default visibility.
+ `_LIBCPP_TYPE_VIS`. This macro has no effect on the visibility of the
+ type's member functions. This attribu
klimek added a comment.
Test? Why are we doing this (should go into the CL description)?
https://reviews.llvm.org/D24663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lefticus updated this revision to Diff 71668.
lefticus added a comment.
Add C++1z check around constexpr tests, based on mclow's feedback
https://reviews.llvm.org/D22584
Files:
include/array
include/iterator
test/std/containers/sequences/array/at.pass.cpp
test/std/containers/sequences/a
NoQ added a comment.
In https://reviews.llvm.org/D20811#544927, @dcoughlin wrote:
> That said, now that I look at it with 'POSTCONDITION' alone I don't think it
> is clear that the provided value describes the return value. What do you
> think about renaming it 'RETURN_VALUE'? Or adding back th
yaxunl updated this revision to Diff 71667.
yaxunl added a comment.
Remove redundant diagnostic msg.
https://reviews.llvm.org/D24666
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/half.cl
test/SemaOpenCL/invalid-kernel-parameters.cl
Index: test/SemaOpenCL/invalid-kernel-parameters.cl
=
Ping.
Thanks,
--Serge
2016-09-08 20:43 GMT+07:00 Serge Pavlov :
> Any feedback?
>
> Thanks,
> --Serge
>
> 2016-09-02 13:11 GMT+07:00 Serge Pavlov :
>
>> sepavloff updated this revision to Diff 70134.
>> sepavloff marked an inline comment as done.
>> sepavloff added a comment.
>>
>> Updated patch
dcoughlin added a comment.
I think this is much clearer! That said, now that I look at it with
'POSTCONDITION' alone I don't think it is clear that the provided value
describes the return value. What do you think about renaming it 'RETURN_VALUE'?
Or adding back the RET_VAL I asked you about rem
bader added inline comments.
Comment at: test/SemaOpenCL/half.cl:29
@@ +28,3 @@
+kernel void half_disabled_kernel(global half *p,
+ half h); // expected-error{{'half' cannot be
used as the type of a kernel parameter}} // expected-error{{declaring
vbyakovlcl created this revision.
vbyakovlcl added reviewers: aaron.ballman, ahatanak.
vbyakovlcl added a subscriber: cfe-commits.
vbyakovlcl set the repository for this revision to rL LLVM.
Gcc prints error if elements of left and right parts of a shift have different
sizes. This patch is provid
On Fri, Sep 16, 2016 at 10:15:06AM -, Neil Hickey via cfe-commits wrote:
> Author: neil.hickey
> Date: Fri Sep 16 05:15:06 2016
> New Revision: 281714
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281714&view=rev
> Log:
> Improve handling of floating point literals in OpenCL to only use dou
Author: asiri
Date: Fri Sep 16 09:32:19 2016
New Revision: 281731
URL: http://llvm.org/viewvc/llvm-project?rev=281731&view=rev
Log:
[libcxx] Add missing c++98 xfail. NFC.
This is the only test failing in c++98 mode at the moment.
Modified:
libcxx/trunk/test/std/iterators/iterator.range/begin
thakis added inline comments.
Comment at: test/SemaCXX/warn-msvc-enum-bitfield.cpp:12
@@ +11,3 @@
+
+ s.e2 = E2;
+ s.f2 = F2;
sashab wrote:
> thakis wrote:
> > Shouldn't this be the version that warns? The assignment with E1 assigns 0
> > which is portable, but
On Tue, Sep 13, 2016 at 11:06 AM, Justin Bogner
wrote:
> Saleem Abdulrasool via cfe-commits writes:
> > Author: compnerd
> > Date: Mon Sep 12 16:15:23 2016
> > New Revision: 281261
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
> > Log:
> > CodeGen: use some range-based for
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader.
yaxunl added subscribers: cfe-commits, nhaustov, rampitec.
Herald added a subscriber: yaxunl.
https://reviews.llvm.org/D24666
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/half.cl
test/SemaOpenCL/invalid-kernel-parameter
Author: compnerd
Date: Fri Sep 16 09:24:26 2016
New Revision: 281730
URL: http://llvm.org/viewvc/llvm-project?rev=281730&view=rev
Log:
CodeGen: use pointer rather than reference in range loop
Address post-commit comments from Justin Bogner. Explicitly indicate
that the dereferenced iterator prov
rSerge updated this revision to Diff 71635.
rSerge added a comment.
Fixed patch file format.
https://reviews.llvm.org/D23932
Files:
test/CodeGen/xray-attributes-supported-arm.cpp
Index: test/CodeGen/xray-attributes-supported-arm.cpp
===
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D24663
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
Index: lib/Tooling/Core/Replacement.cpp
hokein updated this revision to Diff 71631.
hokein added a comment.
Support fully quailified name only.
https://reviews.llvm.org/D24243
Files:
CMakeLists.txt
clang-move/CMakeLists.txt
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/CMakeLists.txt
clang-move/tool/Clan
rSerge updated this revision to Diff 71629.
https://reviews.llvm.org/D23932
Files:
test/CodeGen/xray-attributes-supported-arm.cpp
Index: test/CodeGen/xray-attributes-supported-arm.cpp
===
--- test/CodeGen/xray-attributes-supported
hokein added a comment.
Sorry for the delay.
The patch only contains an unittest for `HeaderGenerato`r, which is not quite
enough. Should we create a fake migrate-tool binary to illustrate APIs usage?
Comment at: migrate-tool/HeaderGenerator.h:22
@@ +21,3 @@
+public:
+ Header
malcolm.parsons updated this revision to Diff 71622.
malcolm.parsons added a comment.
Herald added a subscriber: mgorny.
Handle unions and templated classes.
Add FixItHints (depends on https://reviews.llvm.org/D24572).
https://reviews.llvm.org/D24339
Files:
clang-tidy/readability/CMakeLists.t
omtcyfz accepted this revision.
omtcyfz added a comment.
I have no other objections aswell.
LGTM.
https://reviews.llvm.org/D24183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The patch looks good to me now.
Comment at: change-namespace/ChangeNamespace.h:44
@@ +43,3 @@
+class ChangeNamespaceTool : ast_matchers::MatchFinder::MatchCallback {
+public:
omtcyfz added inline comments.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:41
@@ -40,1 +40,3 @@
+ unless(cxxMethodDecl(ofClass(cxxRecordDecl(anyOf(
+ isLambda(),
ast_matchers::isTemplateInstantiation()),
EricWF abandoned this revision.
EricWF added a comment.
Abandoning. This option is only needed when using old versions of Sphinx.
https://reviews.llvm.org/D24646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
malcolm.parsons added inline comments.
Comment at: clang-tidy/readability/AvoidConstParamsInDecls.cpp:41
@@ -40,1 +40,3 @@
+ unless(cxxMethodDecl(ofClass(cxxRecordDecl(anyOf(
+ isLambda(),
ast_matchers::isTemplateInstantiation()),
danielmarjamaki marked 2 inline comments as done.
danielmarjamaki added a comment.
https://reviews.llvm.org/D24656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielmarjamaki updated this revision to Diff 71614.
danielmarjamaki added a comment.
minor fixes
https://reviews.llvm.org/D24656
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readability/RedundantDeclarationCheck.cpp
clang-tidy
danielmarjamaki added a comment.
For information, I am testing this on debian packages right now. I will see the
results next week.
Comment at: clang-tidy/readability/RedundantDeclarationCheck.cpp:22
@@ +21,3 @@
+void RedundantDeclarationCheck::registerMatchers(MatchFinder *Fin
danielmarjamaki created this revision.
danielmarjamaki added a reviewer: alexfh.
danielmarjamaki added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
This is a new check that warns about redundant variable declarations.
https://reviews.llvm.org/D24656
Files:
clang-tidy/rea
neil.hickey added a comment.
committed @ 281714
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
neil.hickey closed this revision.
neil.hickey added a comment.
Commit merged to trunk
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: neil.hickey
Date: Fri Sep 16 05:15:06 2016
New Revision: 281714
URL: http://llvm.org/viewvc/llvm-project?rev=281714&view=rev
Log:
Improve handling of floating point literals in OpenCL to only use double
precision if the target supports fp64
https://reviews.llvm.org/D24235
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281713: [clang-tidy] Bugfix for
readability-redundant-control-flow check (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D24500?vs=71140&id=71608#toc
Repository:
rL LLVM
htt
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
In https://reviews.llvm.org/D24500#542284, @malcolm.parsons wrote:
> I didn't report a bug for this issue, and there isn't an existing one.
>
> I don't have commit access, so please commit it for me.
Since Alex is away at the moment
Author: omtcyfz
Date: Fri Sep 16 05:12:08 2016
New Revision: 281713
URL: http://llvm.org/viewvc/llvm-project?rev=281713&view=rev
Log:
[clang-tidy] Bugfix for readability-redundant-control-flow check
This check did not create FixItHints when the statement before the redundant
control flow was not
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
Probably it also makes sense to reflect both `lambda` and template
instantiation parts in documentation, since I find current wording totally
confusing at the moment.
Comment at: clang-tidy/readability/AvoidConstPar
Author: ericwf
Date: Fri Sep 16 05:04:38 2016
New Revision: 281712
URL: http://llvm.org/viewvc/llvm-project?rev=281712&view=rev
Log:
Touch up [[clang::require_constant_initialization]] docs
* Fix an egregious comma usage.
* Remove the `static` keyword in the example since the variables should hav
malcolm.parsons created this revision.
malcolm.parsons added reviewers: alexfh, aaron.ballman, hokein.
malcolm.parsons added a subscriber: cfe-commits.
Bugfix for 30398. Don't warn for template instantiations
https://reviews.llvm.org/D24652
Files:
clang-tidy/readability/AvoidConstParamsInDecl
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ continue;
+const std::string &FilePath = FileAndNsMoves.first;
+auto &Replaces = FileToReplacements[FilePath];
ioeric wrote:
> omtcyfz wrote:
> > `Strin
ioeric marked an inline comment as done.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ continue;
+const std::string &FilePath = FileAndNsMoves.first;
+auto &Replaces = FileToReplacements[FilePath];
omtcyfz wrote:
> `StringRef` he
omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ continue;
+const std::string &FilePath = FileAndNsMoves.first;
+auto &Replaces = FileToReplacements[FilePath];
`StringRef` here too.
https://reviews.l
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:200
@@ +199,3 @@
+ while (!NsSplitted.empty()) {
+// FIXME: consider code style for comments.
+Code = ("namespace " + NsSplitted.back() + " {\n" + Code +
hokein wrote:
> Doesn'
ioeric updated this revision to Diff 71605.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D24183
Files:
CMakeLists.txt
change-namespace/CMakeLists.txt
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNam
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D24626
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Author: neil.hickey
Date: Fri Sep 16 04:38:11 2016
New Revision: 281711
URL: http://llvm.org/viewvc/llvm-project?rev=281711&view=rev
Log:
Testing commit rights. Removing trailing white space from test file.
Modified:
cfe/trunk/test/SemaCXX/attr-noreturn.cpp
Modified: cfe/trunk/test/SemaCXX/
mstorsjo added inline comments.
Comment at: lib/Headers/intrin.h:504
@@ +503,3 @@
+_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) {
+ long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE);
+ return (_PrevVal >> _BitPos) & 1;
-
sepavloff created this revision.
sepavloff added reviewers: rsmith, tra.
sepavloff added a subscriber: cfe-commits.
Current version of clang cannot build the program:
```
template int var;
int main(int argc, char *argv[]) {
return var<0>;
}
```
as linker does not find `var<0>`, codegen treats i
1 - 100 of 114 matches
Mail list logo
