This revision was automatically updated to reflect the committed changes.
Closed by commit rL281440: Document option '-rtlib' in clang's man page and
help info (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D24069?vs=69947&id=71298#toc
Repository:
rL LLVM
https://
Author: hahnfeld
Date: Wed Sep 14 00:52:21 2016
New Revision: 281440
URL: http://llvm.org/viewvc/llvm-project?rev=281440&view=rev
Log:
Document option '-rtlib' in clang's man page and help info
This patch adds an entry for "-rtlib" in the output of `man clang` and `clang
-help`.
Patch by Lei Zh
alexshap added a subscriber: alexshap.
Comment at: include/clang/Basic/Builtins.h:142
@@ -141,1 +141,3 @@
+ // \brief Returns true if this builtin requires appropriate header in other
+ // compilers. In Clang it will work even without including it, but we can
emit
---
rnk added a comment.
lgtm We could define a macro that conditionally expands to `extern "C"`, but
then we'd have to undef it, and that seems like no good.
https://reviews.llvm.org/D24330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Author: rsmith
Date: Tue Sep 13 21:24:50 2016
New Revision: 281436
URL: http://llvm.org/viewvc/llvm-project?rev=281436&view=rev
Log:
[docs] Fix formatting of characters so that tables line up properly. Add
padding around table cells so the borders of adjacent tables don't run into
each other (no
Author: rsmith
Date: Tue Sep 13 20:55:42 2016
New Revision: 281434
URL: http://llvm.org/viewvc/llvm-project?rev=281434&view=rev
Log:
[docs] Order diagnostic cross-references alphabetically rather than based on
order in the .td file.
Modified:
cfe/trunk/docs/DiagnosticsReference.rst
cfe/tr
Author: rsmith
Date: Tue Sep 13 20:51:10 2016
New Revision: 281433
URL: http://llvm.org/viewvc/llvm-project?rev=281433&view=rev
Log:
Update DiagnosticsReference and fix emitter to emit -Wpedantic diagnostics and
groups in a deterministic order.
Modified:
cfe/trunk/docs/DiagnosticsReference.r
Author: kcc
Date: Tue Sep 13 20:39:49 2016
New Revision: 281432
URL: http://llvm.org/viewvc/llvm-project?rev=281432&view=rev
Log:
[sanitizer-coverage] add yet another flavour of coverage instrumentation:
trace-pc-guard. The intent is to eventually replace all of {bool coverage,
8bit-counters, tr
meikeb marked an inline comment as done.
Comment at: lib/Sema/SemaChecking.cpp:3864-3867
@@ +3863,6 @@
+ResOffset = Offset.sadd_ov(Addend, Ov);
+ else {
+assert(AddendIsRight && BinOpKind == BO_Sub &&
+ "operator must be add or sub with addend on the right");
+
meikeb updated this revision to Diff 71286.
meikeb added a comment.
Correct assert position in offset sum helper function.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
=
meikeb marked 2 inline comments as done.
meikeb added a comment.
https://reviews.llvm.org/D23820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
meikeb updated this revision to Diff 71284.
meikeb added a comment.
Try to improve offset sum helper function name and fix style issues.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
===
Author: nico
Date: Tue Sep 13 20:16:54 2016
New Revision: 281430
URL: http://llvm.org/viewvc/llvm-project?rev=281430&view=rev
Log:
Follow-up to r281367: Compare uuids case-insensitively.
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
cfe/trunk/test/SemaCXX/ms-uuid.cpp
Modified: cfe/trunk/
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3864-3867
@@ +3863,6 @@
+ResOffset = Offset.sadd_ov(Addend, Ov);
+ else if (AddendIsRight && BinOpKind == BO_Sub)
+ResOffset = Offset.ssub_ov(Addend, Ov);
+ else
+assert(AddendIsRight && BinOpKind ==
Author: rsmith
Date: Tue Sep 13 20:05:35 2016
New Revision: 281429
URL: http://llvm.org/viewvc/llvm-project?rev=281429&view=rev
Log:
[modules] When merging one definition into another, propagate the list of
re-exporting modules from the discarded definition to the retained definition.
Modified:
Thanks for the quick fix. ASAN is happy now.
--Artem
On Tue, Sep 13, 2016 at 3:09 PM, Manman wrote:
> I checked in r281404. Hopefully it will fix the issue.
>
> Let me know if it does not.
>
> Thanks,
> Manman
>
> On Sep 13, 2016, at 3:03 PM, Artem Belevich via cfe-commits <
> cfe-commits@lists
Author: rsmith
Date: Tue Sep 13 19:35:56 2016
New Revision: 281427
URL: http://llvm.org/viewvc/llvm-project?rev=281427&view=rev
Log:
Color warnings purple rather than orange, to match actual Clang output.
Modified:
cfe/trunk/docs/DiagnosticsReference.rst
cfe/trunk/include/clang/Basic/Diag
zlei added a comment.
In https://reviews.llvm.org/D24069#540804, @Hahnfeld wrote:
> @zlei will you commit the patch or do you want me to do that on your behalf?
I don't have commit access, so please do me a favor :)
https://reviews.llvm.org/D24069
__
agutowski updated this revision to Diff 71271.
agutowski added a comment.
Add extern "C" to Intel intrinsics declarations
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
li
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This basically looks fine to me now. I'm not 100% sold on
`sumUpStringLiteralOffset` being the best name, but I think we have better
things to worry about, and it's good enough. Just a couple
agutowski reopened this revision.
agutowski added a comment.
This revision is now accepted and ready to land.
xmmintrin.h and emmintrin.h broke compilation when included inside extern "C++"
block
Repository:
rL LLVM
https://reviews.llvm.org/D24330
_
Author: rsmith
Date: Tue Sep 13 18:03:41 2016
New Revision: 281415
URL: http://llvm.org/viewvc/llvm-project?rev=281415&view=rev
Log:
Missed update from r281412.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL:
r281413 for the constructors.
On Tue, Sep 13, 2016 at 2:58 PM, Hans Wennborg wrote:
> Good point. Constructors are also a problem, I'll try to fix.
>
> It's not exactly the same issue, because they do show up in the AST,
> but they're referenced with a CXXConstructExpr, and not the
> DeclRefExpr
Author: hans
Date: Tue Sep 13 17:51:42 2016
New Revision: 281413
URL: http://llvm.org/viewvc/llvm-project?rev=281413&view=rev
Log:
Also don't inline dllimport functions referring to non-dllimport constructors.
The AST walker wasn't visiting CXXConstructExprs before.
This is a follow-up to r28139
Author: rsmith
Date: Tue Sep 13 17:51:09 2016
New Revision: 281412
URL: http://llvm.org/viewvc/llvm-project?rev=281412&view=rev
Log:
Warning flag updates:
-Wdiv-by-zero may as well be an alias for -Wdivision-by-zero rather than a
GCC-compatibility no-op.
-Wno-shadow should disable -Wshadow-ivar.
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, omtcyfz.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Repository:
rL LLVM
https://reviews.llvm.org/D24526
Files:
docs/ReleaseNotes.rst
Index: docs
Author: rnk
Date: Tue Sep 13 17:22:56 2016
New Revision: 281408
URL: http://llvm.org/viewvc/llvm-project?rev=281408&view=rev
Log:
Fix a FIXME about MSVC 2013 in the diagnostic doc generation code
Ultimately it boiled down to adding a move constructor.
Modified:
cfe/trunk/utils/TableGen/Clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281406: [CUDA] Do not merge CUDA target attributes.
(authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D24522?vs=71244&id=71249#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24
Author: tra
Date: Tue Sep 13 17:16:30 2016
New Revision: 281406
URL: http://llvm.org/viewvc/llvm-project?rev=281406&view=rev
Log:
[CUDA] Do not merge CUDA target attributes.
CUDA target attributes are used for function overloading and must not be merged.
This fixes a bug where attributes were in
Author: ahatanak
Date: Tue Sep 13 17:13:02 2016
New Revision: 281405
URL: http://llvm.org/viewvc/llvm-project?rev=281405&view=rev
Log:
[CodeGen] Fix an assert in EmitNullConstant.
r235815 changed CGRecordLowering::accumulateBases to ignore non-virtual
bases of size 0, which prevented adding those
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281405: [CodeGen] Fix an assert in EmitNullConstant.
(authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D24312?vs=70589&id=71248#toc
Repository:
rL LLVM
https://reviews.llvm.o
Buildbot failure -
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/323
On Tue, Sep 13, 2016 at 3:05 PM, David Majnemer
wrote:
> What issue is this addressing?
>
> On Tue, Sep 13, 2016 at 2:51 PM, Albert Gutowski via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Auth
tra updated this revision to Diff 71244.
tra marked an inline comment as done.
tra added a comment.
Removed REQUIRED lines.
https://reviews.llvm.org/D24522
Files:
lib/Sema/SemaDecl.cpp
test/SemaCUDA/function-overload.cu
test/SemaCUDA/target_attr_inheritance.cu
Index: test/SemaCUDA/target
I checked in r281404. Hopefully it will fix the issue.
Let me know if it does not.
Thanks,
Manman
> On Sep 13, 2016, at 3:03 PM, Artem Belevich via cfe-commits
> wrote:
>
> Manman,
>
> FYI, It appears that some of your ObjC commits today trigger asan error.
> Sanitizer bots are broken by PR3
loladiro added inline comments.
Comment at: include/memory:2137
@@ -2132,3 +2136,3 @@
-_LIBCPP_INLINE_VISIBILITY
+_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR
__libcpp_compressed_pair_imp& operator=(__libcpp_compressed_pair_imp&& __p)
mclow.lists wro
What issue is this addressing?
On Tue, Sep 13, 2016 at 2:51 PM, Albert Gutowski via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: agutowski
> Date: Tue Sep 13 16:51:37 2016
> New Revision: 281401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281401&view=rev
> Log:
> Temporary fix
Author: mren
Date: Tue Sep 13 16:57:28 2016
New Revision: 281404
URL: http://llvm.org/viewvc/llvm-project?rev=281404&view=rev
Log:
ObjectiveC Generics: follow-up commit to r281355.
Correct getExtraLocalDataSize for ObjCTypeParamTypeLoc.
rdar://24619481
rdar://25060179
Modified:
cfe/trunk/in
mclow.lists added inline comments.
Comment at: include/memory:2137
@@ -2132,3 +2136,3 @@
-_LIBCPP_INLINE_VISIBILITY
+_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR
__libcpp_compressed_pair_imp& operator=(__libcpp_compressed_pair_imp&& __p)
loladiro wro
Manman,
FYI, It appears that some of your ObjC commits today trigger asan error.
Sanitizer bots are broken by PR30341, so they don't report the issue yet.
--Artem
$ llvm/tools/clang/clang -cc1 -internal-isystem
llvm/tools/clang/staging/include -nostdsysteminc -fblocks -fsyntax-only
-Wnullable-to
Author: agutowski
Date: Tue Sep 13 16:51:37 2016
New Revision: 281401
URL: http://llvm.org/viewvc/llvm-project?rev=281401&view=rev
Log:
Temporary fix for MS _Interlocked intrinsics
Modified:
cfe/trunk/include/clang/Basic/Builtins.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/trunk/lib/H
Good point. Constructors are also a problem, I'll try to fix.
It's not exactly the same issue, because they do show up in the AST,
but they're referenced with a CXXConstructExpr, and not the
DeclRefExpr which DLLImportFunctionVisitor is looking for.
There doesn't seem to be any problem with opera
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Yay, this is great.
Comment at: test/SemaCUDA/target_attr_inheritance.cu:4
@@ +3,3 @@
+// REQUIRES: x86-registered-target
+// REQUIRES: nvptx-registered-target
+
-
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
Herald added a subscriber: jlebar.
CUDA target attributes are used for function overloading and must not be merged.
This fixes a bug where attributes were inherited during function template
specializati
Could other implicit functions (operator=, ctors) have similar issues?
On Tue, Sep 13, 2016 at 5:08 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hans
> Date: Tue Sep 13 16:08:20 2016
> New Revision: 281395
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281395
Author: agutowski
Date: Tue Sep 13 16:24:51 2016
New Revision: 281399
URL: http://llvm.org/viewvc/llvm-project?rev=281399&view=rev
Log:
Reverse commit 281375 (breaks building Chromium)
Removed:
cfe/trunk/test/Sema/implicit-intel-builtin-decl.c
cfe/trunk/test/Sema/implicit-ms-builtin-decl.
This breaks building Chromium,
https://build.chromium.org/p/chromium.fyi/builders/ClangToTWin64%28dbg%29/builds/7125/steps/compile/logs/stdio
FAILED: obj/components/webcrypto/webcrypto/aes_gcm.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC @obj/componen
Author: hans
Date: Tue Sep 13 16:08:20 2016
New Revision: 281395
URL: http://llvm.org/viewvc/llvm-project?rev=281395&view=rev
Log:
Try harder to not inline dllimport functions referencing non-dllimport functions
In r246338, code was added to check for this, but it failed to take into
account impl
rsmith added a comment.
I expect this patch to cause problems if the two definitions of the variable
template come from different modules, because at deserialization time we don't
merge the definitions together sensibly (it looks like we end up with a
redeclaration chain with multiple declarati
On Tue, Sep 13, 2016 at 12:51:52PM -0700, Richard Smith wrote:
> On Tue, Sep 13, 2016 at 10:44 AM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > IMO this should be restricted to code that explicitly disables C/C++
> > aliasing rules.
>
>
> Do you mean -fno-stric
bruno added a subscriber: bruno.
bruno added a comment.
Hi Paul,
I'm interested in this patch. Do you have any plans to wrap it up?
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
Yeah, this patch didn't give me the warm fuzzies, either.
AFAICT, our only other options are having some sort of struct whitelist
(either hard-coded, or given as a flag), or telling people to turn
_FORTIFY_SOURCE down if they have code that looks like this. Given that
this is apparently common in
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281385: Remove excessive padding from PTHWriter (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D23902?vs=69311&id=71229#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: alexshap
Date: Tue Sep 13 15:17:57 2016
New Revision: 281385
URL: http://llvm.org/viewvc/llvm-project?rev=281385&view=rev
Log:
Remove excessive padding from PTHWriter
The class PTHWriter is in lib/Frontend/CacheTokens.cpp
inside the anonymous namespace.
This diff changes the order of fie
bruno closed this revision.
bruno added a comment.
Thanks Doug!
Committed r281383
https://reviews.llvm.org/D23852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Tue Sep 13 15:04:35 2016
New Revision: 281383
URL: http://llvm.org/viewvc/llvm-project?rev=281383&view=rev
Log:
[SemaObjC] Be more strict while parsing type arguments and protocols
Fix a crash-on-invalid.
When parsing type arguments and protocols,
parseObjCTypeArgsOrProtocolQ
Author: rsmith
Date: Tue Sep 13 15:00:02 2016
New Revision: 281382
URL: http://llvm.org/viewvc/llvm-project?rev=281382&view=rev
Log:
Work around MSVC 2013's inability to default move special members.
Modified:
cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp
Modified: cfe/trunk/utils/Tab
I think it's better to pass amount in bytes here, as specified by user
(alignas takes bytes, not bits).
On 09/13/2016 09:00 PM, Robinson, Paul wrote:
I hadn't thought Clang wanted to be *quite* so knowledgeable about
targets, and similarly not so tightly tied to byte-addressable
targets. But
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:608
@@ -608,2 +607,3 @@
uint64_t Size = CGM.getContext().getTypeSize(Ty);
+ uint64_t Align = 0;
rnk wrote:
> IMO this is what we should be doing everywhere, rather than manually checking
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281378: Add bunch of _Interlocked builtins (authored by
agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24153?vs=70572&id=71223#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24153
Author: agutowski
Date: Tue Sep 13 14:43:33 2016
New Revision: 281378
URL: http://llvm.org/viewvc/llvm-project?rev=281378&view=rev
Log:
Add bunch of _Interlocked builtins
Reviewers: compnerd, thakis, Prazek, majnemer, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
On Tue, Sep 13, 2016 at 10:44 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Sep 12, 2016 at 11:50:36PM -, George Burgess IV via
> cfe-commits wrote:
> > Author: gbiv
> > Date: Mon Sep 12 18:50:35 2016
> > New Revision: 281277
> >
> > URL: http://llvm.org
vleschuk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3691
@@ -3635,1 +3690,3 @@
+ if (D->hasAttr())
+AlignInBits = D->getMaxAlignment();
StringRef DeclName, LinkageName;
probinson wrote:
> dblaikie wrote:
> > is max alignment the right t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281375: Add some MS aliases for existing intrinsics
(authored by agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24330?vs=71213&id=71220#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: agutowski
Date: Tue Sep 13 14:26:42 2016
New Revision: 281375
URL: http://llvm.org/viewvc/llvm-project?rev=281375&view=rev
Log:
Add some MS aliases for existing intrinsics
Reviewers: thakis, compnerd, majnemer, rsmith, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281373: [analyzer] Fix ExprEngine::VisitMemberExpr (authored
by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D24484?vs=71082&id=71218#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: alexshap
Date: Tue Sep 13 14:17:20 2016
New Revision: 281373
URL: http://llvm.org/viewvc/llvm-project?rev=281373&view=rev
Log:
[analyzer] Fix ExprEngine::VisitMemberExpr
AST may contain intermediate ParenExpr nodes
between MemberExpr and ArrayToPointerDecay.
This diff adjusts the check in
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D24488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
thakis closed this revision.
thakis added a comment.
r281367, thanks!
https://reviews.llvm.org/D24469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nico
Date: Tue Sep 13 13:55:26 2016
New Revision: 281367
URL: http://llvm.org/viewvc/llvm-project?rev=281367&view=rev
Log:
[clang-cl] Diagnose duplicate uuids.
This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some
corner cases and more lenient in others (see the
brtaylor92 created this revision.
brtaylor92 added reviewers: alexfh, craig.topper.
brtaylor92 added a subscriber: cfe-commits.
Assert text for getSingleDecl() is inaccurate. Appears to have been copy pasted
from getDeclGroup()
https://reviews.llvm.org/D24518
Files:
include/clang/AST/DeclGrou
agutowski updated this revision to Diff 71213.
agutowski added a comment.
Merge C and C++ tests
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Basic/Targets.cpp
lib/CodeGen/CGBuiltin.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm after merging the test back.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring libra
agutowski updated this revision to Diff 71212.
agutowski added a comment.
Add test for implicitly declared intel intrinsic diagnostic in C++
https://reviews.llvm.org/D24330
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/BuiltinsX86.def
lib/Bas
loladiro added a comment.
Small bump here. Is it possible to rewrite these without std::forward, so we
can have the const-initialization behavior on C++11 (or is there are different
solution?).
Repository:
rL LLVM
https://reviews.llvm.org/D24372
__
Author: rsmith
Date: Tue Sep 13 13:35:34 2016
New Revision: 281363
URL: http://llvm.org/viewvc/llvm-project?rev=281363&view=rev
Log:
Work around a GCC 4.7-specific issue: due to implementing older rules for
implicit declarations of move operations, GCC 4.7 would find that SelectPiece
has neither a
agutowski added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
decla
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm Sorry, I lost track of this.
https://reviews.llvm.org/D24153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
rnk added inline comments.
Comment at: test/Sema/implicit-intel-builtin-decl.c:4
@@ +3,3 @@
+void f() {
+ (void)_mm_getcsr(); // expected-warning{{implicitly declaring library
function '_mm_getcsr'}} \
+ // expected-note{{include the header or explicitly provide a
declaration
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
LGTM!
Comment at: lib/Sema/SemaDeclAttr.cpp:4609
@@ +4608,3 @@
+ unsigned AttrSpellingListIndex, StringRef Uuid) {
+ if (const auto *
Saleem Abdulrasool via cfe-commits writes:
> Author: compnerd
> Date: Mon Sep 12 16:15:23 2016
> New Revision: 281261
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281261&view=rev
> Log:
> CodeGen: use some range-based for loops
>
> Use range-based for loops to simplify the logic. Add an expli
I hadn't thought Clang wanted to be *quite* so knowledgeable about targets, and
similarly not so tightly tied to byte-addressable targets. But if both of
those things are actually okay, then it's fine to set the alignment value here
to what would be passed through to DWARF.
--paulr
From: David
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Currently, driver level warnings do not show option names (e.g. warning:
complain about foo [-Woption-name]) in a diagnostic unless
-fdiagnostics-show-option is explictly specified. OTOH, the driv
alexshap added a comment.
Thx,
I do.
Repository:
rL LLVM
https://reviews.llvm.org/D24484
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks!
Do you have commit access?
Repository:
rL LLVM
https://reviews.llvm.org/D24484
___
cfe-commits mailing list
cfe-commits@lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281358: ObjectiveC Generics: Start using ObjCTypeParamType.
(authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23080?vs=69765&id=71205#toc
Repository:
rL LLVM
https://reviews.llv
Author: mren
Date: Tue Sep 13 12:41:05 2016
New Revision: 281358
URL: http://llvm.org/viewvc/llvm-project?rev=281358&view=rev
Log:
ObjectiveC Generics: Start using ObjCTypeParamType.
For ObjC type parameter, we used to have TypedefType that is canonicalized to
id or the bound type. We can't repre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281357: AMDGPU: Fix target options fp32/64-denormals
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D24512?vs=71183&id=71201#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: yaxunl
Date: Tue Sep 13 12:37:09 2016
New Revision: 281357
URL: http://llvm.org/viewvc/llvm-project?rev=281357&view=rev
Log:
AMDGPU: Fix target options fp32/64-denormals
Fix target options for fp32/64-denormals so that
+fp64-denormals is set if fp64 is supported
-fp32-denormals if fp32 d
meikeb added a comment.
I explained why I chose the names that you commented on. Feel free to add your
thoughts if you still think another name would be more fitting.
Comment at: lib/Sema/SemaChecking.cpp:3842
@@ -3841,2 +3841,3 @@
-static void CheckFormatString(Sema &S, cons
On Mon, Sep 12, 2016 at 11:50:36PM -, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Mon Sep 12 18:50:35 2016
> New Revision: 281277
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281277&view=rev
> Log:
> [Sema] Fix PR30346: relax __builtin_object_size checks.
>
> This pat
meikeb updated this revision to Diff 71199.
meikeb marked 7 inline comments as done.
meikeb added a comment.
Fix typos and add assert to sum up offset helper.
https://reviews.llvm.org/D23820
Files:
lib/Sema/SemaChecking.cpp
test/Sema/format-strings.c
Index: test/Sema/format-strings.c
=
joerg added a comment.
More precisely, this should re-use the logic from __atomic_is_lock_free and not
reinvent it.
https://reviews.llvm.org/D24448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
joerg added a subscriber: joerg.
joerg added a comment.
While I agree with the general sentiment, the check doesn't work at all. For
example, ARMv4 always has to use libcalls. It's not even true that libcalls are
slow, i.e. on true non-parallel architectures, the libcall can be as simple as
a r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281355: ObjectiveC generics: Add ObjCTypeParamType in the
type system. (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D23079?vs=69764&id=71197#toc
Repository:
rL LLVM
https://
Author: mren
Date: Tue Sep 13 12:25:08 2016
New Revision: 281355
URL: http://llvm.org/viewvc/llvm-project?rev=281355&view=rev
Log:
ObjectiveC generics: Add ObjCTypeParamType in the type system.
We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
representation of "T " where T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281353: ObjectiveC: Refactor applyObjCProtocolQualifiers.
(authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D24059?vs=69766&id=71194#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: mren
Date: Tue Sep 13 12:03:12 2016
New Revision: 281353
URL: http://llvm.org/viewvc/llvm-project?rev=281353&view=rev
Log:
ObjectiveC: Refactor applyObjCProtocolQualifiers.
To construct the canonical type of ObjCTypeParamType, we need to apply
qualifiers on ObjCObjectPointerType. The upda
ioeric created this revision.
ioeric added reviewers: djasper, klimek.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Extend `tooling::Replacements::add()` to support adding order-independent
replacements.
Two replacements are considered order-independent if one of th
beanz added a comment.
You cannot rename the variables that start with `LLVM_*`, but the variables
without the leading `LLVM` can be renamed to whatever makes sense, or left
as-is. I'm fine with either way.
The variables starting with `LLVM_*` are effectively public interface to the
build syst
yaxunl added inline comments.
Comment at: lib/Basic/Targets.cpp:1962
@@ -1961,3 +1961,3 @@
bool hasLDEXPF:1;
- bool hasDenormSupport:1;
+ bool hasFP32DenormSupport:1;
tstellarAMD wrote:
> I think this name is a little confusing, because the hardware does su
1 - 100 of 152 matches
Mail list logo
