[libcxx] r280643 - Fix Bug 30240 - std::string: append(first, last) error when aliasing. Add test cases for append/insert/assign/replace while we're at it, and fix a similar bug in insert.

2016-09-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Sep 4 20:54:30 2016 New Revision: 280643 URL: http://llvm.org/viewvc/llvm-project?rev=280643&view=rev Log: Fix Bug 30240 - std::string: append(first, last) error when aliasing. Add test cases for append/insert/assign/replace while we're at it, and fix a similar bug i

Re: [PATCH] D24183: A clang tool for changing surrouding namespaces of class/function definitions.

2016-09-04 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:30 @@ +29,3 @@ + std::string Result = Namespaces.front(); + for (auto I = Namespaces.begin() + 1, E = Namespaces.end(); I != E; ++I) { +Result += ("::" + *I).str(); Braces around

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

2016-09-04 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D24192#533220, @ioeric wrote: > Don't worry about a patch being small. Reviewers like small patches :) > > The reason that I suggested a dummy sub-tool is to lower the bar for > developers, especially those who have never developed a clang too

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

2016-09-04 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D24192#533233, @ioeric wrote: > It was not trivial to me why USREngine is so important to those tools. You > might want to address that in the design doc as well. And given the weight > USREngine carries in clang-refactor as you suggested, I

[PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

2016-09-04 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: alexfh, ioeric, vmiklos. omtcyfz added subscribers: cfe-commits, Eugene.Zelenko. Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. Allowing to use both -qualified-name and -offset at once while

[clang-tools-extra] r280640 - [clang-rename] Enforce LLVM policy about braces around single line control flow statement body.

2016-09-04 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Sun Sep 4 17:50:41 2016 New Revision: 280640 URL: http://llvm.org/viewvc/llvm-project?rev=280640&view=rev Log: [clang-rename] Enforce LLVM policy about braces around single line control flow statement body. Although it is not explicitly stated in LLVM Coding Standards, LLV

[clang-tools-extra] r280639 - [clang-rename] add failing test

2016-09-04 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Sun Sep 4 17:28:39 2016 New Revision: 280639 URL: http://llvm.org/viewvc/llvm-project?rev=280639&view=rev Log: [clang-rename] add failing test For some reason clang-rename fails to rename method of templated class. Add XFAIL test reproducing the issue. Added: clang-too

Re: [PATCH] D24178: [clang-rename] Fix some Clang-tidy modernize-use-override and Include What You Use warnings; other minor fixes

2016-09-04 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280638: [clang-rename] Fix Clang-tidy and IWYU warnings; other minor fixes (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24178?vs=70119&id=70293#toc Repository: rL LLVM h

[clang-tools-extra] r280638 - [clang-rename] Fix Clang-tidy and IWYU warnings; other minor fixes

2016-09-04 Thread Kirill Bobyrev via cfe-commits
Author: omtcyfz Date: Sun Sep 4 17:19:52 2016 New Revision: 280638 URL: http://llvm.org/viewvc/llvm-project?rev=280638&view=rev Log: [clang-rename] Fix Clang-tidy and IWYU warnings; other minor fixes Patch by Eugene Zelenko! Differential Revision: https://reviews.llvm.org/D24178 Reviewers: omt

r280635 - [AVX-512] Remove 128-bit and 256-bit masked floating point add/sub/mul/div builtins and replace with native operations.

2016-09-04 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun Sep 4 13:30:17 2016 New Revision: 280635 URL: http://llvm.org/viewvc/llvm-project?rev=280635&view=rev Log: [AVX-512] Remove 128-bit and 256-bit masked floating point add/sub/mul/div builtins and replace with native operations. We can't do the 512-bit ones because they

Re: r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-04 Thread Joerg Sonnenberger via cfe-commits
On Sat, Sep 03, 2016 at 10:06:48PM -0700, Richard Smith wrote: > Thanks for the fix. Can you add a simple test that we provide macros with > the right name? Other than that, it makes sense to me for this to go to the > release branches. Done. > (I'm not sure whether we're doing more 3.8 point rel

Re: [PATCH] D24054: Do not validate pch when -fno-validate-pch is set

2016-09-04 Thread Alexey Bader via cfe-commits
bader added a comment. Could you a regression test, please? https://reviews.llvm.org/D24054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280622 - Test case for r280607 to check presence and sanity of the *_LOCK_FREE

2016-09-04 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Sun Sep 4 06:21:27 2016 New Revision: 280622 URL: http://llvm.org/viewvc/llvm-project?rev=280622&view=rev Log: Test case for r280607 to check presence and sanity of the *_LOCK_FREE macros. Added: cfe/trunk/test/Headers/stdatomic.c Added: cfe/trunk/test/Headers/stdatomic.

[libcxx] r280621 - [libcxx] Fix a data race in call_once

2016-09-04 Thread Kuba Brecka via cfe-commits
Author: kuba.brecka Date: Sun Sep 4 04:55:12 2016 New Revision: 280621 URL: http://llvm.org/viewvc/llvm-project?rev=280621&view=rev Log: [libcxx] Fix a data race in call_once call_once is using relaxed atomic load to perform double-checked locking, which contains a data race. The fast-path load