Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-09-03 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D18639#527285, @hfinkel wrote: > In https://reviews.llvm.org/D18639#515000, @hfinkel wrote: > > > Updated to use scheme suggested by Marshall. > > > Ping. Ping. https://reviews.llvm.org/D18639

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-09-03 Thread Asiri Rathnayake via cfe-commits
@mclow.lists: Ping ? On 24 Aug 2016 22:46, "Asiri Rathnayake via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > rmaprath added inline comments. > > > Comment at: include/__config:830 > @@ -829,1 +829,3 @@ > +!defined(_LIBCPP_HAS_THREAD_API_PTHREAD) && \ > +!defined(_L

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

2016-09-03 Thread Asiri Rathnayake via cfe-commits
@mclow.lists: Our C library is aware of the fact that it may be used from a C++ context, yes. So you think it's OK for libc++ to expect C99 operations at all language standards? Cheers, / Asiri On 4 Sep 2016 01:16, "Marshall Clow via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > mclow.lis

Re: [PATCH] D23871: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

2016-09-03 Thread Elad Cohen via cfe-commits
eladcohen added a comment. Thanks Richard, committed r280613. Repository: rL LLVM https://reviews.llvm.org/D23871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280613 - [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

2016-09-03 Thread Elad Cohen via cfe-commits
Author: eladcohen Date: Sun Sep 4 01:00:42 2016 New Revision: 280613 URL: http://llvm.org/viewvc/llvm-project?rev=280613&view=rev Log: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list. This adds support for modules that require (non-)freestanding environment, such as the c

Re: [PATCH] D23871: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list.

2016-09-03 Thread Elad Cohen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280613: [Modules] Add 'freestanding' to the 'requires-declaration' feature-list. (authored by eladcohen). Changed prior to commit: https://reviews.llvm.org/D23871?vs=69239&id=70279#toc Repository: rL

Re: r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-03 Thread Richard Smith via cfe-commits
On 3 Sep 2016 6:01 p.m., "Joerg Sonnenberger via cfe-commits" < cfe-commits@lists.llvm.org> wrote: On Sat, Sep 03, 2016 at 05:56:43PM -0700, Richard Smith wrote: > /* 7.17.2 Initialization */ > > #define ATOMIC_VAR_INIT(value) (value) > #define atomic_init __c11_atomic_init > > -/* 7.17.3 Order

[libcxx] r280612 - Apply curr_symbol.pass.cpp test fix to missed test case

2016-09-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 3 23:09:25 2016 New Revision: 280612 URL: http://llvm.org/viewvc/llvm-project?rev=280612&view=rev Log: Apply curr_symbol.pass.cpp test fix to missed test case Modified: libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byna

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

2016-09-03 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a subscriber: alexshap. Comment at: clang-refactor/driver/Rename.h:192 @@ +191,3 @@ + auto ID = Sources.translateFile(Entry); + Rewrite.getEditBuffer(ID).write(outs()); +} if i am not mistaken if the file has not been modified this wil

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF added a comment. This is not correct. We need the `-nodefaultlibs` on most platforms to prevent libstdc++ from being linked. I think the correct fix is to change `--rtlib=` https://reviews.llvm.org/D24083 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D24087: [lit] Allow more file extensions for test cases.

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Woops I see the test case now. LGTM. Comment at: test/libcxx/test/format.py:69 @@ +68,3 @@ +name_root, name_ext = os.path.splitext(name) +is_sh_test = name_ro

Re: [PATCH] D24087: [lit] Allow more file extensions for test cases.

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF added a comment. I don't think assembly based `.pass` and `.fail` tests will work quite yet. The `CXXCompiler` object used by the test format explicitly passes `-xc++ %s` in some cases. I'm assuming you already have a libc++abi assembly test? Could you put it up for review? https://re

Re: [PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 70278. EricWF marked 3 inline comments as done. EricWF added a comment. Address all inline comments. https://reviews.llvm.org/D24218 Files: src/locale.cpp test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/decimal_point.p

Re: [PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname

2016-09-03 Thread George Burgess IV via cfe-commits
george.burgess.iv added a subscriber: george.burgess.iv. george.burgess.iv added a comment. Just a few drive-by nits. Thanks for the patch! Comment at: src/locale.cpp:5849 @@ -5828,4 +5848,3 @@ __decimal_point_ = base::do_decimal_point(); -if (*lc->mon_thousands_sep

Re: r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-03 Thread Joerg Sonnenberger via cfe-commits
On Sat, Sep 03, 2016 at 05:56:43PM -0700, Richard Smith wrote: > /* 7.17.2 Initialization */ > > #define ATOMIC_VAR_INIT(value) (value) > #define atomic_init __c11_atomic_init > > -/* 7.17.3 Order and consistency */ > +/* 7.17.3 Order and consistency */. > > > Stray period here. Do we not ha

Re: [PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF updated the summary for this revision. EricWF updated this revision to Diff 70277. EricWF added a comment. Remove secondary locale fix. https://reviews.llvm.org/D24218 Files: src/locale.cpp test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/decimal_po

r280609 - Trailing dot that shouldn't have been committed.

2016-09-03 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Sat Sep 3 19:51:02 2016 New Revision: 280609 URL: http://llvm.org/viewvc/llvm-project?rev=280609&view=rev Log: Trailing dot that shouldn't have been committed. Modified: cfe/trunk/lib/Headers/stdatomic.h Modified: cfe/trunk/lib/Headers/stdatomic.h URL: http://llvm.org/v

[libcxx] r280608 - Fix bad locale test data when using the newest glibc

2016-09-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 3 19:48:54 2016 New Revision: 280608 URL: http://llvm.org/viewvc/llvm-project?rev=280608&view=rev Log: Fix bad locale test data when using the newest glibc Modified: libcxx/trunk/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/

Re: r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-03 Thread Richard Smith via cfe-commits
On 3 Sep 2016 5:52 p.m., "Joerg Sonnenberger via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: joerg Date: Sat Sep 3 19:44:10 2016 New Revision: 280607 URL: http://llvm.org/viewvc/llvm-project?rev=280607&view=rev Log: PR 27200: Fix names of the atomic lock-free macros. Modified:

Re: r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-03 Thread Joerg Sonnenberger via cfe-commits
Hi Tom, can I merge this into 3.8 and 3.9? Joerg On Sun, Sep 04, 2016 at 12:44:10AM -, Joerg Sonnenberger via cfe-commits wrote: > Author: joerg > Date: Sat Sep 3 19:44:10 2016 > New Revision: 280607 > > URL: http://llvm.org/viewvc/llvm-project?rev=280607&view=rev > Log: > PR 27200: Fix na

r280607 - PR 27200: Fix names of the atomic lock-free macros.

2016-09-03 Thread Joerg Sonnenberger via cfe-commits
Author: joerg Date: Sat Sep 3 19:44:10 2016 New Revision: 280607 URL: http://llvm.org/viewvc/llvm-project?rev=280607&view=rev Log: PR 27200: Fix names of the atomic lock-free macros. Modified: cfe/trunk/lib/Headers/stdatomic.h Modified: cfe/trunk/lib/Headers/stdatomic.h URL: http://llvm.or

[PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname

2016-09-03 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. The underlying C locales provide the `thousands_sep` and `decimal_point` as strings, possible with more than one character. We currently don't handle this case even for `wchar_t`. This pa

[libcxx] r280605 - Mark test as XFAIL for C++03, rather than providing a dummy pass.

2016-09-03 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sat Sep 3 19:37:06 2016 New Revision: 280605 URL: http://llvm.org/viewvc/llvm-project?rev=280605&view=rev Log: Mark test as XFAIL for C++03, rather than providing a dummy pass. Modified: libcxx/trunk/test/std/iterators/iterator.range/begin-end.pass.cpp Modified: libcx

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

2016-09-03 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > We have quite a strict C library which is picky about what it exposes under > different standards. For example, it won't expose C99 math ops if it is being > used under `__cplusplus < 201103L` ... That sounds .. odd to me, having the behavior of the C library dep

r280597 - [AVX-512] Remove masked integer mullo builtins and replace with native IR.

2016-09-03 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Sep 3 14:19:49 2016 New Revision: 280597 URL: http://llvm.org/viewvc/llvm-project?rev=280597&view=rev Log: [AVX-512] Remove masked integer mullo builtins and replace with native IR. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Headers/av

r280596 - [AVX-512] Remove masked integer add/sub builtins and replace with native IR.

2016-09-03 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat Sep 3 13:29:35 2016 New Revision: 280596 URL: http://llvm.org/viewvc/llvm-project?rev=280596&view=rev Log: [AVX-512] Remove masked integer add/sub builtins and replace with native IR. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Headers/

r280591 - Fix the attribute documentation build.

2016-09-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Sep 3 10:36:52 2016 New Revision: 280591 URL: http://llvm.org/viewvc/llvm-project?rev=280591&view=rev Log: Fix the attribute documentation build. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: http

Re: [PATCH] D22910: Add support for CXXOperatorCallExpr in Expr::HasSideEffects

2016-09-03 Thread Andi via cfe-commits
Abpostelnicu added inline comments. Comment at: lib/AST/Expr.cpp:2869 @@ +2868,3 @@ +OverloadedOperatorKind Op = cast(this)->getOperator(); +if (CXXOperatorCallExpr::isAssignmentOp(Op)) { + const Decl *FD = cast(this)->getCalleeDecl(); aaron.ballman w

[libcxx] r280588 - Fix PR30202 - notify_all_at_thread_exit seg faults if run from a raw pthread context.

2016-09-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 3 03:07:40 2016 New Revision: 280588 URL: http://llvm.org/viewvc/llvm-project?rev=280588&view=rev Log: Fix PR30202 - notify_all_at_thread_exit seg faults if run from a raw pthread context. Summary: This patch allows threads not created using `std::thread` to use `s

Re: [PATCH] D23957: Replace the Radeon GCN GPU family names by more descriptive ones

2016-09-03 Thread Niels Ole Salscheider via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280587: Replace the Radeon GCN GPU family names by more descriptive ones (authored by olesalscheider). Changed prior to commit: https://reviews.llvm.org/D23957?vs=69486&id=70264#toc Repository: rL LL

r280587 - Replace the Radeon GCN GPU family names by more descriptive ones

2016-09-03 Thread Niels Ole Salscheider via cfe-commits
Author: olesalscheider Date: Sat Sep 3 02:13:54 2016 New Revision: 280587 URL: http://llvm.org/viewvc/llvm-project?rev=280587&view=rev Log: Replace the Radeon GCN GPU family names by more descriptive ones Differential Revision: https://reviews.llvm.org/D23957 Modified: cfe/trunk/lib/Basic/T

Re: [PATCH] D23926: [libcxx] Don't use C99 math ops in -std=c++03 mode

2016-09-03 Thread Asiri Rathnayake via cfe-commits
@Eric: Ping? On 1 Sep 2016 11:33, "Asiri Rathnayake via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > rmaprath updated this revision to Diff 69962. > rmaprath added a comment. > > Simplified the patch a little bit more. > > Now, library vendors should be able to define > `_LIBCPP_STRICT_C99

[libcxx] r280585 - memory_resource still needs init_priority when built with GCC 4.9

2016-09-03 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat Sep 3 02:05:40 2016 New Revision: 280585 URL: http://llvm.org/viewvc/llvm-project?rev=280585&view=rev Log: memory_resource still needs init_priority when built with GCC 4.9 Modified: libcxx/trunk/src/experimental/memory_resource.cpp Modified: libcxx/trunk/src/experi