Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

rogfer01 added a comment. Hi, this is a friendly ping. Thank you! :) https://reviews.llvm.org/D23657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279613 - [AST] Make InitListExpr::isExplicit const (NFC)

Author: vedantk Date: Wed Aug 24 01:44:57 2016 New Revision: 279613 URL: http://llvm.org/viewvc/llvm-project?rev=279613&view=rev Log: [AST] Make InitListExpr::isExplicit const (NFC) Patch by Alexander Shaposhnikov! Differential Revision: https://reviews.llvm.org/D23828 Modified: cfe/trunk/i

Re: [PATCH] D23828: Make InitListExpr::isExplicit const

This revision was automatically updated to reflect the committed changes. Closed by commit rL279613: [AST] Make InitListExpr::isExplicit const (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23828?vs=69083&id=69084#toc Repository: rL LLVM https://reviews.llvm

Re: [PATCH] D23828: Make InitListExpr::isExplicit const

alexshap added a comment. Thx, i don't have commit access, if u could land this diff i would be grateful Repository: rL LLVM https://reviews.llvm.org/D23828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D23828: Make InitListExpr::isExplicit const

vsk added a subscriber: vsk. vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. LGTM - it's just calling const methods. Repository: rL LLVM https://reviews.llvm.org/D23828

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:152 @@ +151,3 @@ + // SourceLocation::isValid is const. + if (!const_cast(InitListEx)->isExplicit() || + !InitListEx->getNumInits()) djasper wrote: > I think it is an o

[PATCH] D23828: Make InitListExpr::isExplicit const

alexshap created this revision. alexshap added reviewers: djasper, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Mark the

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. regarding writing the comments - yeah, i will add them - just have not updated the diff yet (writing comments doesn't come to me easily) Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list c

Re: [PATCH] D23821: Minor cleanup of the class Pattern

vsk added a subscriber: vsk. vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. I couldn't find any sites which rely on implicit construction of Pattern after a quick scan. The field re-ordering change also looks innocuous.

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.h:31 @@ +30,3 @@ + +public: + ReorderFieldsAction( djasper wrote: > I don't why clang-rename does what it does at the moment. My main point is > that we have already implemented

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/tool/ClangReorderFields.cpp:44 @@ +43,3 @@ + bool parse(cl::Option &O, StringRef ArgName, const std::string &ArgValue, + SmallVector &Val) { +Val.clear(); djasper wrote: > Don't use

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. I am serious about writing more comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:41 @@ +40,3 @@ + } + if (Results.size() != 1) { +errs() << "The name " << RecordName Make this "> 1" instead of "!= 1". Not really i

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

compnerd added inline comments. Comment at: CMakeLists.txt:372 @@ +371,3 @@ +# Relax this restriction from HandleLLVMOptions +string(REPLACE "-Wl,-z,defs" "" CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS}") + endif() There is a similar change in

r279608 - [Pragma] Clear loop distribution attribute between loops

Author: anemet Date: Tue Aug 23 23:31:56 2016 New Revision: 279608 URL: http://llvm.org/viewvc/llvm-project?rev=279608&view=rev Log: [Pragma] Clear loop distribution attribute between loops Added: cfe/trunk/test/CodeGenCXX/pragma-loop-distribute.cpp Modified: cfe/trunk/lib/CodeGen/CGLoopI

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

This revision was automatically updated to reflect the committed changes. Closed by commit rL279607: Remove excessive padding from PTHStatData (NFC) (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D23826?vs=69071&id=69077#toc Repository: rL LLVM https://reviews.

r279607 - Remove excessive padding from PTHStatData (NFC)

Author: mehdi_amini Date: Tue Aug 23 23:26:57 2016 New Revision: 279607 URL: http://llvm.org/viewvc/llvm-project?rev=279607&view=rev Log: Remove excessive padding from PTHStatData (NFC) This diff reorders the fields and removes excessive padding. This fixes the following warning: PTHLexer.cpp:62

[libcxx] r279606 - libc++: add an option to build against compiler-rt

Author: compnerd Date: Tue Aug 23 23:22:52 2016 New Revision: 279606 URL: http://llvm.org/viewvc/llvm-project?rev=279606&view=rev Log: libc++: add an option to build against compiler-rt This mirrors the option in libc++abi to build without libgcc. Modified: libcxx/trunk/CMakeLists.txt li

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D22090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

alexshap added a comment. Ok, thanks. Could you land this diff ? (i don't have commit access) Repository: rL LLVM https://reviews.llvm.org/D23826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D23826: Remove excessive padding from PTHStatData

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM, thanks. (In the future, please upload patches with full context) Repository: rL LLVM https://reviews.llvm.org/D23826 ___ cfe-

[PATCH] D23826: Remove excessive padding from PTHStatData

alexshap created this revision. alexshap added reviewers: mehdi_amini, bkramer. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". The c

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

rsmith added a comment. Please also handle expressions of the form `&"str"[i]`. We warn (under `-Wstring-plus-int`) for `"str" + i` and suggest rewriting into that form, so we should also handle that form here. Comment at: lib/Sema/SemaChecking.cpp:3864 @@ -3864,1 +3863,3 @@ +

r279603 - Adding an additional test to ensure the frame pointer is emitted

Author: dyung Date: Tue Aug 23 21:02:32 2016 New Revision: 279603 URL: http://llvm.org/viewvc/llvm-project?rev=279603&view=rev Log: Adding an additional test to ensure the frame pointer is emitted when compiling with optimization when PS4 is the target. Modified: cfe/trunk/test/Driver/frame-

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 69057. meikeb added a comment. Fix typo. https://reviews.llvm.org/D23820 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c === --- test/Sema/form

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb marked an inline comment as done. Comment at: lib/Sema/SemaChecking.cpp:3856 @@ -3855,3 +3855,3 @@ // format string, we will usually need to emit a warning. // True string literals are then checked by CheckFormatString. static StringLiteralCheckType I'm

Re: r267338 - Improve diagnostic checking for va_start to also warn on other instances of undefined behavior, such as a parameter declared with the register keyword in C, or a parameter of a type that

Hey Aaron, This commit triggers warnings when the argument to va_start is an enum type. The standard says: 7.16.1.4 The va_start macro • 4 The parameter parmN is the identifier of the rightmost parameter in the variable parameter list in the function definition (the one just before t

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69065. alexshap added a comment. minor cleanup Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt clang-reorder-fields/ReorderFieldsAction.cpp clang-reorder-fields/ReorderFieldsAction.h

[libcxx] r279596 - Revert "libc++: Perform configuration checks with -nodefaultlibs"

Author: compnerd Date: Tue Aug 23 19:24:05 2016 New Revision: 279596 URL: http://llvm.org/viewvc/llvm-project?rev=279596&view=rev Log: Revert "libc++: Perform configuration checks with -nodefaultlibs" This reverts SVN r279584 which broke the buildbots. Will re-apply once the issue has been root-

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.h:30 @@ +29,3 @@ + std::map &Replacements; + +public: the thing is that a few weeks ago there was a diff https://reviews.llvm.org/D21748?id=64016. That diff contains a lot of cha

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69056. alexshap added a comment. Drop the callbacks (the worst-case complexity might be worse, but this approach requires less code). Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt cl

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

srhines added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3856 @@ -3855,3 +3855,3 @@ // format string, we will usually need to emit a warning. // True string literals are then checked by CheckFormatString. static StringLiteralCheckType It might be go

[PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb created this revision. meikeb added a reviewer: rsmith. meikeb added a subscriber: cfe-commits. The warning for a format string not being a sting literal and therefore being potentially insecure is overly strict for indecies into sting literals. This fix checks if the index into the string

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

compnerd closed this revision. compnerd added a comment. SVN r279584. https://reviews.llvm.org/D23791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r279584 - libc++: Perform configuration checks with -nodefaultlibs

Author: compnerd Date: Tue Aug 23 18:01:16 2016 New Revision: 279584 URL: http://llvm.org/viewvc/llvm-project?rev=279584&view=rev Log: libc++: Perform configuration checks with -nodefaultlibs We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration c

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. Sorry, didn't have much time so far, will give this some more review later today. One thing those is that the code could do with a bit more comments. It would help reviewing (and future maintenance) of functions such as reorderFieldsInConstructor to have brief comment (

[PATCH] D23821: Minor cleanup of the class Pattern

alexshap created this revision. alexshap added reviewers: dsanders, probinson. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Herald

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

doug.gregor added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:1037 @@ -1036,1 +1036,3 @@ +DEF_TRAVERSE_TYPE(ObjCTypeParamType, {}) + manmanren wrote: > doug.gregor wrote: > > I'm sorta shocked that we don't visit the protocol qualifiers

[PATCH] D23816: clang-cl: Add support for /FC: absolute paths in diagnostics and __FILE__

hans created this revision. hans added reviewers: thakis, rsmith. hans added a subscriber: cfe-commits. It turns out several Chromium developers rely on this on Windows. I'm not sure about the internal flag name. And do we want to expose this in non-cl mode too? https://reviews.llvm.org/D23816

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

ahatanak added a comment. In https://reviews.llvm.org/D23236#523173, @parallaxe wrote: > In https://reviews.llvm.org/D23236#509013, @ahatanak wrote: > > > +cfe-commits > > > > If this patch is applied, does clang issue a warning if a method marked > > "nonnull" returns a null value? I see a warn

[PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

Eugene.Zelenko created this revision. Eugene.Zelenko added a reviewer: alexfh. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D23815 Files: docs/clang-tidy/checks/google-readability-

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think this makes sense. https://reviews.llvm.org/D23791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

I just tested on Ubuntu 14.04 as well. The configuration goes through correctly. There are 30 unexpected failures both with and without the patch when I run check-libcxx. Are there any other platforms in particular which I should be testing on? From: cfe-commits on behalf of Shoaib Meenai via

r279571 - Fix member call on null pointer, found by sanitizer buildbot.

Author: rsmith Date: Tue Aug 23 16:12:54 2016 New Revision: 279571 URL: http://llvm.org/viewvc/llvm-project?rev=279571&view=rev Log: Fix member call on null pointer, found by sanitizer buildbot. Modified: cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Modified: cfe/trunk/lib/Sema/SemaTem

Re: [PATCH] D23279: clang-reorder-fields

bcraig added a comment. In https://reviews.llvm.org/D23279#523449, @alexshap wrote: > @djasper, @bcraig, @aaron.ballman - many thanks for the comments and > suggestions, > please, let me know if you are waiting for any other changes on my side (for > v0) or if there is anything else i can do t

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Thanks a lot! On 23/08/16 22:50, Richard Smith via cfe-commits wrote: Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth > wrote: Reverted this per Richard's request in r279500. On Mon, Aug 22, 2016 at 3:33 PM Richard

Re: [libcxx] r279552 - libcxx: Fix libcxx tests on aarch64 with libunwind

Would be nice if you can also add a comment around the double-checking of llvm_unwinder, even something along the lines of "we need libgcc to appear both before and after... in the link order, for reasons thus far unknown to me" is fine. Just so that anyone looking through this in the future is at

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. @djasper, @bcraig, @aaron.ballman - many thanks for the comments and suggestions, please, let me know if you are waiting for any other changes on my side (for v0) or if there is anything else i can do to make reviewing easier. Repository: rL LLVM https://reviews.ll

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

This revision was automatically updated to reflect the committed changes. Closed by commit rL279559: driver: Support checking for rlimits via cmake (when bootstrapping) (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D23744?vs=68775&id=69028#toc Repository: rL LLVM

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

Landed in r279559! Thanks, -Chris > On Aug 23, 2016, at 10:44 AM, Michał Górny wrote: > > mgorny added a comment. > > Thanks for the review. Could you commit it for me, please? I don't have > commit access. > > > https://reviews.llvm.org/D23744 > > >

r279559 - driver: Support checking for rlimits via cmake (when bootstrapping)

Author: cbieneman Date: Tue Aug 23 15:07:07 2016 New Revision: 279559 URL: http://llvm.org/viewvc/llvm-project?rev=279559&view=rev Log: driver: Support checking for rlimits via cmake (when bootstrapping) Summary: Add a cmake check for sys/resource.h and replace the __has_include() check with its

r279558 - Remove two dos line endings.

Author: nico Date: Tue Aug 23 14:59:55 2016 New Revision: 279558 URL: http://llvm.org/viewvc/llvm-project?rev=279558&view=rev Log: Remove two dos line endings. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp URL: http://llvm.org/viewvc/llvm-proj

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth wrote: > Reverted this per Richard's request in r279500. > > > On Mon, Aug 22, 2016 at 3:33 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Mon Aug 22 17

r279557 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Author: rsmith Date: Tue Aug 23 14:41:39 2016 New Revision: 279557 URL: http://llvm.org/viewvc/llvm-project?rev=279557&view=rev Log: Fix regression introduced by r279164: only pass definitions as the PatternDef to DiagnoseUninstantiableTemplate, teach hasVisibleDefinition to correctly determine wh

Re: [PATCH] D23805: clang-cl: Make /Brepro actually work.

thakis closed this revision. thakis added a comment. 279555, thanks! https://reviews.llvm.org/D23805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279555 - clang-cl: Make /Brepro actually work.

Author: nico Date: Tue Aug 23 14:32:02 2016 New Revision: 279555 URL: http://llvm.org/viewvc/llvm-project?rev=279555&view=rev Log: clang-cl: Make /Brepro actually work. /Brepro means we want reproducible builds, i.e. we _don't_ want the timestamp that's needed to be compatible with the incrementa

Re: [PATCH] D23805: clang-cl: Make /Brepro actually work.

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:8657-8658 @@ +8656,4 @@ + DeclContext *SemanticDC = D->getDeclContext(); + if (SemanticDC->isDependentContext()) +return false; + // Get here only for out-of-line declarations: lexical context is dependent, ---

[libcxx] r279552 - libcxx: Fix libcxx tests on aarch64 with libunwind

Author: azanella Date: Tue Aug 23 14:25:12 2016 New Revision: 279552 URL: http://llvm.org/viewvc/llvm-project?rev=279552&view=rev Log: libcxx: Fix libcxx tests on aarch64 with libunwind Some tests uses 'long double' to/from conversions and for some targets they are provided by compiler runtime (e

r279546 - ARM-Darwin: ignore and diagnose attempts to omit frame pointer.

Author: tnorthover Date: Tue Aug 23 13:12:58 2016 New Revision: 279546 URL: http://llvm.org/viewvc/llvm-project?rev=279546&view=rev Log: ARM-Darwin: ignore and diagnose attempts to omit frame pointer. iOS (and other 32-bit ARM variants) always require a valid frame pointer to improve backtraces.

[clang-tools-extra] r279541 - [Documentation] Fix style of Clang-tidy readability-non-const-parameter.

Author: eugenezelenko Date: Tue Aug 23 12:57:24 2016 New Revision: 279541 URL: http://llvm.org/viewvc/llvm-project?rev=279541&view=rev Log: [Documentation] Fix style of Clang-tidy readability-non-const-parameter. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-non-const-

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

mgorny added a comment. Thanks for the review. Could you commit it for me, please? I don't have commit access. https://reviews.llvm.org/D23744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Patch LGTM. https://reviews.llvm.org/D23744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

vsk resigned from this revision. vsk edited reviewers, added: beanz; removed: vsk. vsk added a comment. I don't see any issues with this patch, but I'm generally unfamiliar with the bootstrapping process and think Chris could give a better review. (Also, as Richard pointed out earlier, including

Re: r278483 - This patch implements PR#22821.

On Tue, Aug 23, 2016 at 4:11 AM, Roger Ferrer Ibanez via cfe-commits wrote: > Yes it was approved on IRC by Aaron Ballman: Sorry for not mentioning this on the mailing list as well as in IRC! ~Aaron > > > > T 1470758009 zygoloid: do you have any further thoughts about > https://reviews.llvm.or

Re: r278483 - This patch implements PR#22821.

Ok, thanks! On Tue, Aug 23, 2016 at 4:11 AM, Roger Ferrer Ibanez < roger.ferreriba...@arm.com> wrote: > Yes it was approved on IRC by Aaron Ballman: > > > > T 1470758009 zygoloid: do you have any further thoughts about > https://reviews.llvm.org/D20561 ? thank you very much :) > > T 1470758207

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Yes, I look forward to testing this in LLDB. Thanks for your hard work. https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

I tested on OS X 10.11 and Ubuntu 16.04. Get Outlook for iOS On Mon, Aug 22, 2016 at 8:37 PM -0700, "Eric Fiselier" mailto:e...@efcs.ca>> wrote: What platforms was this tested on? On Aug 22, 2016 9:20 PM, "Shoaib Meenai" mailto:smee...@fb.com>> wrote: smeenai create

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

rmaprath updated this revision to Diff 69010. rmaprath added a comment. Addressed above comments from @mclow.lists. Getting this to work on shared library builds was a bit tricky, had to use `-undefined dynamic_lookup` linker option on OSX and strip off the default `-Wl,-z,defs` linker option o

Re: [PATCH] D23807: clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.

thakis closed this revision. thakis added a comment. 279531, thanks! https://reviews.llvm.org/D23807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279531 - clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.

Author: nico Date: Tue Aug 23 11:47:09 2016 New Revision: 279531 URL: http://llvm.org/viewvc/llvm-project?rev=279531&view=rev Log: clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag. clang already treats all inputs as utf-8. Warn if anything but utf-8 is passed. Do this by mapping source-

Re: [PATCH] D23780: [analyzer] Fixed crash in StmtDataCollector when analyzing methods of template classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279529: [analyzer] Fix CloneDetector crash on calling methods of class templates. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23780?vs=68883&id=69007#toc Repository: r

r279529 - [analyzer] Fix CloneDetector crash on calling methods of class templates.

Author: dergachev Date: Tue Aug 23 11:42:00 2016 New Revision: 279529 URL: http://llvm.org/viewvc/llvm-project?rev=279529&view=rev Log: [analyzer] Fix CloneDetector crash on calling methods of class templates. If a call expression represents a method call of a class template, and the method itsel

Re: [PATCH] D23807: clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

Any feedback? Thanks, --Serge 2016-08-18 0:08 GMT+07:00 Serge Pavlov : > sepavloff updated this revision to Diff 68376. > sepavloff added a comment. > > Rebased the patch > > > https://reviews.llvm.org/D16989 > > Files: > include/clang/Sema/Sema.h > lib/Sema/SemaDecl.cpp > test/SemaCXX/PR2

Re: [PATCH] D23780: [analyzer] Fixed crash in StmtDataCollector when analyzing methods of template classes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yeah, it seems that these need to be checked. https://reviews.llvm.org/D23780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

sepavloff accepted this revision. sepavloff added a comment. LGTM. https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23807: clang-cl: Accept MSVC 2015's `/source-charset:utf-8` flag.

thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. clang already treats all inputs as utf-8. Warn if anything but utf-8 is passed. Do this by mapping source-charset to finput-charset, which already behaves like this. Slightly tweak finput-charset

Re: r279485 - Module debug info: Don't assert when encountering an incomplete definition

Might be good to mention in an email on this thread what the revision number of the missing test is (& hopefully that test commit also mentions the revision number of this change as well - so people can track through in either direction) On Tue, Aug 23, 2016 at 8:31 AM Adrian Prantl wrote: > Yes

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

parallaxe updated this revision to Diff 69000. parallaxe added a comment. Moved the tests into `nullability_nullonly.mm` according to @dcoughlin. Applied the changes according to @aaron.ballman. https://reviews.llvm.org/D23236 Files: lib/Sema/SemaStmt.cpp test/Analysis/nullability_nullonly.

Re: r279485 - Module debug info: Don't assert when encountering an incomplete definition

Yes, that's because I forgot to git-add the actual testcase :-) It came commits after this one. -- adrian > On Aug 22, 2016, at 11:00 PM, David Blaikie wrote: > > Generally I'd expect a test case to exercise/demonstrate the behavior that > was previously hidden behind an assertion. (put another

[PATCH] D23805: clang-cl: Make /Brepro actually work.

thakis created this revision. thakis added a reviewer: majnemer. thakis added a subscriber: cfe-commits. /Brepro means we want reproducible builds, i.e. we _don't_ want the timestamp that's needed to be compatible with the incremental linker. https://reviews.llvm.org/D23805 Files: include/cla

Re: [PATCH] D23236: When ARC is enabled, no warning will be generated when a method1. Returns 'nil' in a method that is attributed to return a 'nonnull'2. The return-statement is a ConditionalOperator

parallaxe marked 4 inline comments as done. parallaxe added a comment. In https://reviews.llvm.org/D23236#509013, @ahatanak wrote: > +cfe-commits > > If this patch is applied, does clang issue a warning if a method marked > "nonnull" returns a null value? I see a warning is issued for conditiona

Re: [PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis updated this revision to Diff 68993. sdardis added a comment. Rebase + ping. https://reviews.llvm.org/D21072 Files: include/clang/Driver/ToolChain.h lib/Driver/MSVCToolChain.cpp lib/Driver/MinGWToolChain.cpp lib/Driver/ToolChain.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolC

Re: [PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

sdardis commandeered this revision. sdardis added a reviewer: dsanders. sdardis added a comment. Herald added a reviewer: vkalintiris. Taking over this patch series. https://reviews.llvm.org/D21072 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang-tools-extra] r279519 - [clang-tidy] Merge ExtraArgs(Before) instead of overriding them.

Author: alexfh Date: Tue Aug 23 09:48:29 2016 New Revision: 279519 URL: http://llvm.org/viewvc/llvm-project?rev=279519&view=rev Log: [clang-tidy] Merge ExtraArgs(Before) instead of overriding them. Added proper tests. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp clan

[clang-tools-extra] r279516 - [clang-tidy] Fix the order of ExtraArgsBefore

Author: alexfh Date: Tue Aug 23 09:13:31 2016 New Revision: 279516 URL: http://llvm.org/viewvc/llvm-project?rev=279516&view=rev Log: [clang-tidy] Fix the order of ExtraArgsBefore Added tests for the relative order of -extra-arg(-before) and ExtraArgs(Before). Added: clang-tools-extra/trunk/t

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

a.sidorin updated this revision to Diff 68987. a.sidorin added a comment. Add plist output; give test files meaningful names. https://reviews.llvm.org/D22090 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/diagnostics/Inputs/include/plist-diagnostics-include-check-macro.d

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. Serge, Sean, is this patch OK to commit? https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

sdardis added a subscriber: sdardis. sdardis commandeered this revision. sdardis added a reviewer: dsanders. sdardis added a comment. Herald added a reviewer: vkalintiris. Taking over this patch series. https://reviews.llvm.org/D21070 ___ cfe-commit

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz updated the summary for this revision. kparzysz updated this revision to Diff 68973. kparzysz marked an inline comment as done. kparzysz added a comment. Changed the option description to be nont Repository: rL LLVM https://reviews.llvm.org/D22766 Files: include/clang/Driver/Optio

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet added inline comments. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:75 @@ +74,3 @@ +// We check if there is at most 2 not power-of-2 value in the enum type and +// the +// it contains enough element to make sure it could be a biftield, but we aaron.ballm

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

szepet updated this revision to Diff 68968. szepet marked 18 inline comments as done. szepet added a comment. Changes based on comments. https://reviews.llvm.org/D22507 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/EnumMisuseCheck.cpp clang-tidy/misc/EnumMisuseCheck.h clang-tidy

Re: [PATCH] D22766: Handle -mlong-calls on Hexagon

kparzysz marked an inline comment as done. Comment at: include/clang/Driver/Options.td:1380 @@ +1379,3 @@ +def mlong_calls : Flag<["-"], "mlong-calls">, Group, + HelpText<"ARM: Generate an indirect jump to enable jumps further than 64M, Hexagon: Generate constant-extended branch

[PATCH] D23796: [libcxx] Make it possible to test static builds of libc++ on OSX

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. Being used to doing static builds and being a complete noob to OSX, this really confused me. Currently if you build `libc++` (in-tree) like so: ``` -DLIBCXX_ENABLE_SHARED=OFF

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh marked an inline comment as done. Comment at: zorg/buildbot/builders/SphinxDocsBuilder.py:46 @@ +45,3 @@ + defaultBranch='trunk', + workdir=clang_srcdir)) + gribozavr wrote: > I think workdir should be `clang_tools_

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh updated this revision to Diff 68967. alexfh added a comment. - Set proper working directory and build step name for clang extra tools SVN checkout. https://reviews.llvm.org/D23787 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zo

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL279507: [clang-tidy] readability-non-const-parameter: add new check that warns when… (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D15332?vs=68531&id=68963#toc Reposi

[clang-tools-extra] r279507 - [clang-tidy] readability-non-const-parameter: add new check that warns when function parameters should be const

Author: danielmarjamaki Date: Tue Aug 23 05:09:08 2016 New Revision: 279507 URL: http://llvm.org/viewvc/llvm-project?rev=279507&view=rev Log: [clang-tidy] readability-non-const-parameter: add new check that warns when function parameters should be const The check will warn when the constness wil

  1   2   >