Re: [PATCH] D22834: Added 'inline' attribute to basic_string's destructor

2016-08-20 Thread Laxman Sole via cfe-commits
laxmansole added a comment. Ping https://reviews.llvm.org/D22834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r279382 - Wdocumentation fix

2016-08-20 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Aug 20 15:21:27 2016 New Revision: 279382 URL: http://llvm.org/viewvc/llvm-project?rev=279382&view=rev Log: Wdocumentation fix Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL: http://llvm.org/viewvc/llvm-p

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Benjamin Kramer via cfe-commits
It cycled back to green. flake? On Sat, Aug 20, 2016 at 7:27 PM, Vitaly Buka wrote: > msan is not happy about this change > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15681/steps/check-llvm%20msan/logs/stdio > > On Sat, Aug 20, 2016 at 9:59 AM Benjamin Kramer via cfe-com

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279378: [analyzer] Use faster hashing (MD5) in CloneDetector. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22515?vs=68778&id=68784#toc Repository: rL LLVM https://revi

r279378 - [analyzer] Use faster hashing (MD5) in CloneDetector.

2016-08-20 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sat Aug 20 12:35:53 2016 New Revision: 279378 URL: http://llvm.org/viewvc/llvm-project?rev=279378&view=rev Log: [analyzer] Use faster hashing (MD5) in CloneDetector. This replaces the old approach of fingerprinting every AST node into a string, which avoided collisions and

Re: [PATCH] D23279: clang-reorder-fields

2016-08-20 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. ping Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Vitaly Buka via cfe-commits
msan is not happy about this change http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15681/steps/check-llvm%20msan/logs/stdio On Sat, Aug 20, 2016 at 9:59 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Sat Aug 20 11:51:33 2016 > N

Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

2016-08-20 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:11 @@ -10,3 +10,3 @@ -The check can generate fixes after the option `GslHeader` has been set +The c

r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Sat Aug 20 11:51:33 2016 New Revision: 279374 URL: http://llvm.org/viewvc/llvm-project?rev=279374&view=rev Log: [Sema] Don't crash on scanf on forward-declared enums. This is valid in GNU C, which allows pointers to incomplete enums. GCC just pretends that the underlying type is

Re: [PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

2016-08-20 Thread Vassil Vassilev via cfe-commits
v.g.vassilev added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:235 @@ +234,3 @@ + /// respective virtual methods. + class Constraint { + public: I am still unsure about the name. It is too generic. What about `CloneConstraint`? https

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-08-20 Thread WuZhao via cfe-commits
WuZhao added a comment. I wan to point to some issues, because I am also doing AIX support based on your patch and I tested and verified. Firstly, in the lib/Driver/ToolChains.cpp line 3756 case llvm::Triple::ppc64: addPathIfExists(D, getDriver().SysRoot + getDriver().Dir + "/../lib64",

r279366 - [analyzer] Make CloneDetector consider template arguments.

2016-08-20 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sat Aug 20 04:57:21 2016 New Revision: 279366 URL: http://llvm.org/viewvc/llvm-project?rev=279366&view=rev Log: [analyzer] Make CloneDetector consider template arguments. For example, code samples `isa(S)' and `isa(S)' are no longer considered to be clones. Patch by Rapha

r279367 - [analyzer] Make CloneDetector consider macro expansions.

2016-08-20 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Sat Aug 20 05:06:59 2016 New Revision: 279367 URL: http://llvm.org/viewvc/llvm-project?rev=279367&view=rev Log: [analyzer] Make CloneDetector consider macro expansions. So far macro-generated code was treated by the CloneDetector as normal code. This caused that some macro

[PATCH] D23745: cmake: Adjust llvm-lit search to match the one in LLVM

2016-08-20 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: chapuni, garious. mgorny added a subscriber: cfe-commits. Adjust the system lit executable search to look for llvm-lit as that is the name used in AddLLVM.cmake installed by LLVM. https://reviews.llvm.org/D23745 Files: CMakeLists.txt Ind

[PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

2016-08-20 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added reviewers: rsmith, vsk. mgorny added a subscriber: cfe-commits. Add a cmake check for sys/resource.h and replace the __has_include() check with its result, in order to make it possible to use rlimits when building with compilers not supporting __has_inc

r279371 - PR28423: Compare primary declaration contexts.

2016-08-20 Thread Vassil Vassilev via cfe-commits
Author: vvassilev Date: Sat Aug 20 09:50:22 2016 New Revision: 279371 URL: http://llvm.org/viewvc/llvm-project?rev=279371&view=rev Log: PR28423: Compare primary declaration contexts. In certain cases (mostly coming from modules), Sema's idea of the StdNamespace does not point to the first declara

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

2016-08-20 Thread Niels Ole Salscheider via cfe-commits
olesalscheider updated this revision to Diff 68779. https://reviews.llvm.org/D23746 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ lib/Basic/Targets.cpp @@ -1955,7 +1955,8 @@ GK_CA

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-20 Thread Raphael Isemann via cfe-commits
teemperor marked an inline comment as done. teemperor added a comment. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-20 Thread Raphael Isemann via cfe-commits
teemperor updated this revision to Diff 68778. teemperor added a comment. - Replaced hash_stream with MD5 in the sub-sequence code. https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker.cpp

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-20 Thread Joerg Sonnenberger via cfe-commits
On Sat, Aug 20, 2016 at 12:45:59AM +, Chandler Carruth wrote: > I feel like this thread has two very unrelated concerns and it might be > useful to separate them. > > 1) Should an application be changing the stack limit, or should the system > be able to enforce this? > > Fortunately, there a

[PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

2016-08-20 Thread Niels Ole Salscheider via cfe-commits
olesalscheider created this revision. olesalscheider added reviewers: cfe-commits, tstellarAMD, arsenm. https://reviews.llvm.org/D23746 Files: lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp === --- lib/Basic/Targets.cpp +++ li

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

2016-08-20 Thread Artem Dergachev via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:550 @@ -548,2 +549,3 @@ CloneDetector::CloneSignature SubSignature; +llvm::hash_stream SubHash; Hmm, this still uses `hash_stream`. https://reviews.llvm.org/D22515 _

Re: [PATCH] D23316: [analyzer] Fixed the false-positives caused by macro generated code.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279367: [analyzer] Make CloneDetector consider macro expansions. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23316?vs=68684&id=68771#toc Repository: rL LLVM https://r

Re: [PATCH] D23555: [analyzer] CloneDetector now checks template arguments of function calls.

2016-08-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279366: [analyzer] Make CloneDetector consider template arguments. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D23555?vs=68683&id=68770#toc Repository: rL LLVM https:/