omtcyfz updated this revision to Diff 67289.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
`auto` -> `SourceLocation`
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/
jlebar added a comment.
In https://reviews.llvm.org/D23239#508863, @tra wrote:
> I think we need to add `noexcept` for these in c++11.
Argh, you are completely right.
Thank you for the review.
https://reviews.llvm.org/D23239
___
cfe-commits mail
jlebar updated this revision to Diff 67282.
jlebar added a comment.
Add noexcept.
https://reviews.llvm.org/D23239
Files:
clang/lib/Headers/__clang_cuda_runtime_wrapper.h
Index: clang/lib/Headers/__clang_cuda_runtime_wrapper.h
==
Prazek added a subscriber: Prazek.
Prazek added a comment.
I remember that it was pissing me off when I used clang-tidy first time. Thanks
for fixing that!
https://reviews.llvm.org/D23257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
2016-08-08 8:33 GMT-07:00 Aaron Ballman :
> aaron.ballman added inline comments.
>
>
> Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61
> @@ +58,5 @@
> + IncludeStyle(utils::IncludeSorter::parseIncludeStyle(
> + Options.get("IncludeStyle", "llvm"))) {
> +
Author: ericwf
Date: Mon Aug 8 22:05:43 2016
New Revision: 278087
URL: http://llvm.org/viewvc/llvm-project?rev=278087&view=rev
Log:
Remove *super* old test suite results doc for Linux and Windows.
Neither of these results files has been update in years. Linux now has a dozen
or so buildbots trac
jojo created this revision.
jojo added a reviewer: rengolin.
jojo added a subscriber: cfe-commits.
Some missing usage of TargetParser in Tools.cpp and Targets.cpp.
https://reviews.llvm.org/D23293
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
=
zlei added a comment.
@rovka Thanks a lot :)
Repository:
rL LLVM
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: phosek
Date: Mon Aug 8 19:27:19 2016
New Revision: 278076
URL: http://llvm.org/viewvc/llvm-project?rev=278076&view=rev
Log:
Add lib directory to linker paths when using libunwind
When using libunwind and not building as standalone project, we
need to add LLVM library directory to the lis
Ping!
On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote:
>
>> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes
>> wrote:
>>
>> Hi Eric,
>>
>> After we upgraded our green dragon bots to El Captain (10.11), the
>> test below started to fail on some of our machines:
>>
>> --
>> test/std/experime
dcoughlin added inline comments.
Comment at: test/Analysis/nullability.mm:114
@@ -112,1 +113,3 @@
+NSString *_Nonnull testNullReturnInTernaryOperator(int x) {
+return x > 3 ? nil : [@"" stringByAppendingString:@""]; //
expected-warning {{Null is returned from a function tha
ariccio added a comment.
In https://reviews.llvm.org/D18073#504216, @dcoughlin wrote:
> No. The identifier info will be null for C++ operators.
I assume you mean `operator new/new[]/delete/delete[]
> > Thus, when`! isWindowsMSVCEnvironment`, I leave the Windows-only memory
> > allocating func
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
LG
https://reviews.llvm.org/D23004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:59-61
@@ +58,5 @@
+ IncludeStyle(utils::IncludeSorter::parseIncludeStyle(
+ Options.get("IncludeStyle", "llvm"))) {
+
+ for (const auto &KeyValue :
+ {std::make_pair("memcpy",
Agreed. Normally, arc copies the full patch description from Phab, but this
time the patch didn't apply cleanly, so I had to copy the commit message by
hand and missed a substantial part of it.
On Mon, Aug 8, 2016 at 5:35 PM, David Blaikie wrote:
>
>
> On Wed, Aug 3, 2016 at 4:13 PM Alexander Ko
Author: phosek
Date: Mon Aug 8 17:57:25 2016
New Revision: 278068
URL: http://llvm.org/viewvc/llvm-project?rev=278068&view=rev
Log:
Allow building both shared and static library
This change allows building both shared and static version of libc++
in a single build, sharing object files between b
Author: phosek
Date: Mon Aug 8 17:55:48 2016
New Revision: 278067
URL: http://llvm.org/viewvc/llvm-project?rev=278067&view=rev
Log:
Allow building both shared and static library
This change allows building both shared and static version of libunwind
in a single build, sharing object files betwee
anemet created this revision.
anemet added reviewers: hfinkel, rjmccall, aaron.ballman.
anemet added a subscriber: cfe-commits.
I've recently added the ability for optimization remarks to include the
hotness of the corresponding code region. This uses PGO and allows
filtering of the optimization
Author: phosek
Date: Mon Aug 8 17:09:54 2016
New Revision: 278058
URL: http://llvm.org/viewvc/llvm-project?rev=278058&view=rev
Log:
Do not depend on unwind when building standalone
When libcxxabi is being built standalone, unwind dependency is not
available, so do not use it even when LLVM unwin
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
A bunch of nits. Otherwise looks good.
Thank you for the fix!
Comment at: clang-tidy/ClangTidy.cpp:519
@@ -513,2 +518,3 @@
tooling::TranslationUnitReplacements TUR;
for
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Removing from my dashboard until the comments are addressed.
https://reviews.llvm.org/D23158
___
cfe-commits mailing list
cfe-commits@l
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The test is fine now. Looks good once the other comment is addressed.
https://reviews.llvm.org/D23193
___
cfe-commits mailing list
cfe-commits@li
ddcc added a comment.
Can you land it? I don't have commit access.
https://reviews.llvm.org/D23244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cdavis
Date: Mon Aug 8 16:19:08 2016
New Revision: 278052
URL: http://llvm.org/viewvc/llvm-project?rev=278052&view=rev
Log:
Revert "[Attr] Add support for the `ms_hook_prologue` attribute."
This reverts commit r278050. It depends on r278048, which will be
reverted.
Removed:
cfe/trun
Eugene.Zelenko added a comment.
I would prefer CMake option to link rarely used tools (list should be
adjustable) with libclang, which contain a lot of LLVM/Clang code already.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278051: [Driver] Enable CFI for WebAssembly (authored by
dschuff).
Changed prior to commit:
https://reviews.llvm.org/D23244?vs=67090&id=67226#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23244
Author: dschuff
Date: Mon Aug 8 16:14:15 2016
New Revision: 278051
URL: http://llvm.org/viewvc/llvm-project?rev=278051&view=rev
Log:
[Driver] Enable CFI for WebAssembly
Since CFI support has landed in the WebAssembly backend, enable it in
the frontend driver.
Patch by Dominic Chen
Differential
compnerd added a comment.
This isn't really a renaming tool per se. If you squint really hard, yes, it
does rename fields. But, if we really want to save space, perhaps we should
collapse all the tools into `clang-tidy` or create a new `clang-refactor` tool
and just make the other things a pa
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Few nits, but looks good otherwise.
Should be add few tests for calling device functions from host-side global
initializers? Perhaps for device->host, too, as there may be unexpected
interplay with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278050: [Attr] Add support for the `ms_hook_prologue`
attribute. (authored by cdavis).
Changed prior to commit:
https://reviews.llvm.org/D19909?vs=66729&id=67224#toc
Repository:
rL LLVM
https://revi
Author: cdavis
Date: Mon Aug 8 16:03:39 2016
New Revision: 278050
URL: http://llvm.org/viewvc/llvm-project?rev=278050&view=rev
Log:
[Attr] Add support for the `ms_hook_prologue` attribute.
Summary:
Based on a patch by Michael Mueller.
This attribute specifies that a function can be hooked or pa
Eugene.Zelenko added a comment.
May be this could be Clang-rename mode?
My concern is that every added tool is ~ 15-20 MB on Linux and there are no
CMake options to link part of them dynamically.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
lgtm.
https://reviews.llvm.org/D23244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
alexshap added a comment.
Thank you for the feedback. I was keeping in mind some other use-cases as well
- someone might want to change the order of fields even if the padding is not
affected.
Repository:
rL LLVM
https://reviews.llvm.org/D23279
___
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Do we really need standalone tool for this purpose? If I'm not mistaken, Static
Analyzer already has clang-analyzer-optin.performance.Padding check, which is
also available through Clang-tidy.
https://reviews.ll
Richard: ping?
On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote:
> Should this be merged to 3.9?
>
> Thanks,
> Hans
>
> On Wed, Jul 27, 2016 at 11:25 AM, Erik Pilkington via cfe-commits
> wrote:
>> Author: epilk
>> Date: Wed Jul 27 13:25:10 2016
>> New Revision: 276900
>>
>> URL: http://llvm
ahatanak added a subscriber: cfe-commits.
ahatanak added a comment.
+cfe-commits
If this patch is applied, does clang issue a warning if a method marked
"nonnull" returns a null value? I see a warning is issued for conditional
expressions in the test case you've added, but I don't see a test ca
I didn't merge this one to 3.9 because the PACKAGE_VERSION seems to
have always been trunk-svn, and it's at least not as misleading as
having the wrong number.
I wonder if PACKAGE_VERSION is actually important for anything in
libcxx, libcxxabi and libunwind? At least for libcxx, the important
vers
alexshap created this revision.
alexshap added reviewers: klimek, compnerd.
alexshap added a subscriber: cfe-commits.
alexshap changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
This diff adds v0 of clang-reorder-fields tool to clang/tools/extra
tra added a comment.
cuda-detect.cu may be a better place for this test.
Comment at: test/Driver/cuda-simple.cu:27
@@ -16,1 +26,3 @@
+// CHECK-CXXINCLUDE: clang{{.*}} "-cc1" "-triple" "x86_64--linux-gnu"
{{.*}}"-internal-isystem" "{{.+}}/include/c++/4.8"
+// CHECK-CXXINCLUDE: l
Merged to 3.9 in r278044 with the version number adjusted.
On Mon, Aug 8, 2016 at 10:59 AM, Eugene Zelenko via cfe-commits
wrote:
> Author: eugenezelenko
> Date: Mon Aug 8 12:59:02 2016
> New Revision: 278030
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev
> Log:
> CMakeLists.tx
Author: hans
Date: Mon Aug 8 15:06:27 2016
New Revision: 278044
URL: http://llvm.org/viewvc/llvm-project?rev=278044&view=rev
Log:
Merging r278030 with version number adjusted:
r278030 | eugenezelenko | 2016-08-08 10:59:02 -0
Merged to 3.9 in r278043 with the version number adjusted.
On Mon, Aug 8, 2016 at 10:56 AM, Eugene Zelenko via cfe-commits
wrote:
> Author: eugenezelenko
> Date: Mon Aug 8 12:56:28 2016
> New Revision: 278029
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev
> Log:
> CMakeLists.tx
Author: hans
Date: Mon Aug 8 15:04:18 2016
New Revision: 278043
URL: http://llvm.org/viewvc/llvm-project?rev=278043&view=rev
Log:
Merging r278029 with version number adjusted:
r278029 | eugenezelenko | 2016-08-08 10:56:28 -0
sfantao added a comment.
Friendly ping.
Thanks!
https://reviews.llvm.org/D22946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aprantl added a comment.
Thanks, now all that's missing is an LLVM IR round-trip test. Adding the new
flag to test/Assembler/disubprogram would work.
Comment at: test/DebugInfo/noreturn_c11.ll:9
@@ +8,3 @@
+
+; CHECK: DW_AT_noreturn
+
Maybe
vmiklos added a comment.
> .cpp.rename-at.yaml?
I just discovered that lit provides %S that allows getting rid of the confusing
.cpp.yaml, I'm using that now.
> Ah, and yes, it's better to move *.yaml to extra/test/clang-rename/Inputs
Done.
https://reviews.llvm.org/D23198
___
vmiklos updated this revision to Diff 67215.
https://reviews.llvm.org/D23198
Files:
clang-rename/tool/ClangRename.cpp
docs/clang-rename.rst
test/clang-rename/ClassTestMultiByNameYAML.cpp
test/clang-rename/Inputs/ClassTestMultiByNameYAMLRenameAll.yaml
test/clang-rename/Inputs/ClassTestMu
vleschuk updated this revision to Diff 67212.
vleschuk added a comment.
Added C++11, C11 and ObjC textual llvm-dwarfdump tests.
https://reviews.llvm.org/D23167
Files:
include/llvm/IR/DebugInfoFlags.def
include/llvm/IR/DebugInfoMetadata.h
include/llvm/Support/Dwarf.h
lib/CodeGen/AsmPrint
Ping.
Thanks,
--Serge
2016-08-01 21:47 GMT+07:00 Serge Pavlov :
> sepavloff created this revision.
> sepavloff added a subscriber: cfe-commits.
>
> Function specializations used in friend declarations in class templates,
> like:
> ```
> template class C1 {
> friend void func<>(int);
NoQ accepted this revision.
This revision is now accepted and ready to land.
Comment at: test/Analysis/out-of-bounds.c:153
@@ +152,3 @@
+// The result is unknown for the same reason as above.
+void test_asume_after_access(unsigned long x) {
+ int buf[100];
Yay, t
tra added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2886
@@ +2885,3 @@
+ // Check if this function has diagnostics that should be emitted when we
+ // codegen it. If so, don't eit this function definition, but don't emit the
+ // diags just yet. Emittin
Author: eugenezelenko
Date: Mon Aug 8 13:01:50 2016
New Revision: 278032
URL: http://llvm.org/viewvc/llvm-project?rev=278032&view=rev
Log:
CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent
spacing.
Differential revision: https://reviews.llvm.org/D23091
Modified:
li
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Author: eugenezelenko
Date: Mon Aug 8 12:59:02 2016
New Revision: 278030
URL: http://llvm.org/viewvc/llvm-project?rev=278030&view=rev
Log:
CMakeLists.txt cleanups: synchronize version with rest of LLVM, consistent
spacing.
Differential revision: https://reviews.llvm.org/D23092
Modified:
li
tra added a comment.
I think we need to add `noexcept` for these in c++11.
https://reviews.llvm.org/D23239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenezelenko
Date: Mon Aug 8 12:56:28 2016
New Revision: 278029
URL: http://llvm.org/viewvc/llvm-project?rev=278029&view=rev
Log:
CMakeLists.txt cleanups: synchronize version and CMake minimum required version
with rest of LLVM, consistent spacing.
Differential revision: https://review
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D23238
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
Alexander_Droste added a comment.
Great; thanks again for the review!
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 67195.
omtcyfz added a comment.
More strict test messages.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-literals.cpp
Ind
omtcyfz updated this revision to Diff 67199.
omtcyfz added a comment.
Added more info to the test.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
==
Okay, r278023.
Thanks,
Hans
On Fri, Aug 5, 2016 at 2:46 PM, Saleem Abdulrasool
wrote:
> On Fri, Aug 5, 2016 at 2:35 PM, Saleem Abdulrasool via cfe-commits
> wrote:
>>
>> Author: compnerd
>> Date: Fri Aug 5 16:35:28 2016
>> New Revision: 277868
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev
Author: hans
Date: Mon Aug 8 12:18:56 2016
New Revision: 278023
URL: http://llvm.org/viewvc/llvm-project?rev=278023&view=rev
Log:
Merging r277868:
r277868 | compnerd | 2016-08-05 14:35:28 -0700 (Fri, 05 Aug 2016) | 4 lines
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278022: [clang-tidy] enhance modernize-use-bool-literals to
check ternary operator (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23243?vs=67195&id=67197#toc
Repository:
rL
Author: omtcyfz
Date: Mon Aug 8 12:11:56 2016
New Revision: 278022
URL: http://llvm.org/viewvc/llvm-project?rev=278022&view=rev
Log:
[clang-tidy] enhance modernize-use-bool-literals to check ternary operator
modernize-use-bool-literals doesn't checks operands in ternary operator.
For example:
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 67193.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Update test to not use
https://reviews.llvm.org/D23257
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tidy/ClangTidyDiagnosticConsumer.h
test
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: test/clang-tidy/modernize-use-bool-literals.cpp:124
@@ +123,3 @@
+ bool Result = Value == 1 ? 1 : 0;
+ // CHECK-MESSAGES: :[[@LINE-1]]:30: {{.*}}
ioeric updated this revision to Diff 67191.
ioeric added a comment.
- Check code that is not in affected range is not reformatted in lit test.
https://reviews.llvm.org/D23274
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
test/Format/remove-duplicate-includes.cpp
tools/clang
omtcyfz updated this revision to Diff 67189.
omtcyfz added a comment.
Remove redundant `anyOf` and `anything`.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-lit
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D23274
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
test/Format/remove-duplicate-includes.cpp
tools/clang-forma
Thanks!
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 08 August 2016 17:40
To: Anastasia Stulova
Cc: Alexey Bader; cfe-commits@lists.llvm.org; nd
Subject: Re: r277743 - [OpenCL] Added underscores to the names of 'to_addr'
Ope
Author: dergachev
Date: Mon Aug 8 11:01:02 2016
New Revision: 278018
URL: http://llvm.org/viewvc/llvm-project?rev=278018&view=rev
Log:
[analyzer] Change -analyze-function to accept qualified names.
Both -analyze-function and -analyzer-display-progress now share the same
convention for naming fun
I've merged the lot in r278020.
Thanks,
Hans
On Fri, Aug 5, 2016 at 7:43 PM, Hans Wennborg wrote:
> These all sgtm for 3.9. Go ahead and merge with
> utils/release/merge.sh, or I'll do it when I get in on Monday.
>
> Cheers,
> Hans
>
> On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote:
>> Typ
Okay, merged in r278019.
Cheers,
Hans
On Fri, Aug 5, 2016 at 9:36 AM, Anastasia Stulova
wrote:
> Hans,
>
> If still possible could we merge this into 3.9. It contains just a minor
> renaming but it makes all those new OpenCL Builtins usable.
>
> Thanks,
> Anastasia
>
> -Original Message
a.sidorin added inline comments.
Comment at: lib/Rewrite/HTMLRewrite.cpp:304
@@ -303,2 +303,3 @@
+ " border-radius:5px; box-shadow:1px 1px 7px #000; "
" -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; "
"position: absolute; top: -
NoQ created this revision.
NoQ added reviewers: dcoughlin, zaks.anna.
NoQ added subscribers: xazax.hun, a.sidorin, cfe-commits.
Use the official CSS3 properties `border-radius` and `box-shadow` (not only
`-webkit-`specific properties).
Fixes analyzer's diagnostic pieces in HTML diagnostics mode
alexfh added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1
@@ +1,2 @@
+#include
+
hokein wrote:
> Usually test should not use STL headers as it relies on the system headers.
>
> You don't have to use std::string
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278018: [analyzer] Change -analyze-function to accept
qualified names. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22856?vs=66360&id=67180#toc
Repository:
rL LLVM
htt
alexfh added a comment.
In https://reviews.llvm.org/D23193#508563, @omtcyfz wrote:
> Do these symbolic pointers in test seem reasonable?
Yes, kind of. I'd change these to C-style comments, place them on the same line
with the interesting identifier (probably, right after the identifier), and
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief The absolute path to the file being processed.
+ std::string FilePath;
---
hokein updated this revision to Diff 67178.
hokein marked 2 inline comments as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D23266
Files:
include-fixer/IncludeFixer.cpp
include-fixer/IncludeFixer.h
include-fixer/IncludeFixerContext.cpp
include-fixer/In
On Mon, Aug 8, 2016 at 8:37 AM Benjamin Kramer wrote:
> -Wmissing-prototype only warns for functions, I want to catch classes
> too.
Ah, fair enough. Yeah, a clang-tidy check for things in the global
namespace that are in a main file rather than a header could be another
pivot there.
> Also f
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:48
@@ +47,3 @@
+
+ auto D =
+ diag(ArraySubscriptE->getLocStart(),
alexfh wrote:
> aaron.ballman wrote:
> > Should not use `auto` here because the type is no
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:39
@@ +38,3 @@
+ eachOf(
+ // anyOf() is not evaluating second argument if first is
evaluated
+ /
On Mon, Aug 8, 2016 at 11:50 AM, H.J Lu wrote:
> hjl.tools added a comment.
>
> In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
>
>> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>>
>> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>> >
>> > > For what i
alexfh added inline comments.
Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.cpp:48
@@ +47,3 @@
+
+ auto D =
+ diag(ArraySubscriptE->getLocStart(),
aaron.ballman wrote:
> Should not use `auto` here because the type is not spelled out in the
> i
hjl.tools added a comment.
In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>
> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> >
> > > For what it is worth, this certainly seems to be misnamed. By nature,
NoQ added a comment.
Hmm. The test in `unwanted-programstate-data-propagation.c` passes on my
machine even without the patch, and the return value on the respective path is
correctly represented as `(conj_$6{void *}) != 0U`, which comes from the
`evalCast()` call in `VisitLogicalExpr()` and is
hokein added a comment.
> Can you add a lit test for this? We should've added that earlier :|
I forgot to upload the test first time. But I have already uploaded it, see
`multiple_fixes.cpp`
Comment at: include-fixer/IncludeFixerContext.h:78
@@ -72,1 +77,3 @@
+ /// \brief
hokein added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-pass-by-value/header-with-fix.h:1
@@ +1,2 @@
+#include
+
Usually test should not use STL headers as it relies on the system headers.
You don't have to use std::string to reproduce the cra
erichkeane added a comment.
In https://reviews.llvm.org/D22045#508648, @aaron.ballman wrote:
> In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
>
> > In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> >
> > > For what it is worth, this certainly seems to be misnamed. By nature
aaron.ballman added a comment.
In https://reviews.llvm.org/D22045#508644, @hjl.tools wrote:
> In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>
> > For what it is worth, this certainly seems to be misnamed. By nature, if it
> > doesn't preserve at least the stack pointer, there is no wa
alexfh added a comment.
In https://reviews.llvm.org/D21134#508524, @jroelofs wrote:
> I think the replacement is wrong for something like:
>
> int *arr; int offs1, offs2;
> offs1[arr + offs2] = 42;
>
>
> which I think would give:
>
> int *arr; int offs1, offs2;
> arr + offs2[offs1] = 42;
hjl.tools added a comment.
In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> For what it is worth, this certainly seems to be misnamed. By nature, if it
> doesn't preserve at least the stack pointer, there is no way to recover on
> return, right?
This is the best name we came up with
-Wmissing-prototype only warns for functions, I want to catch classes
too. Also functions in the global namespace with a prototype are still
badness in some coding styles. The limitation on definitions was to
cut down on false positives, the current version of the patch doesn't
have that limitation
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278016: [ARM] Command-line options for embedded
position-independent code (authored by olista01).
Changed prior to commit:
https://reviews.llvm.org/D23196?vs=66921&id=67176#toc
Repository:
rL LLVM
h
Author: olista01
Date: Mon Aug 8 10:28:40 2016
New Revision: 278016
URL: http://llvm.org/viewvc/llvm-project?rev=278016&view=rev
Log:
[ARM] Command-line options for embedded position-independent code
This patch (with the corresponding ARM backend patch) adds support for
some new relocation model
On Wed, Aug 3, 2016 at 4:13 PM Alexander Kornienko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: alexfh
> Date: Wed Aug 3 18:06:03 2016
> New Revision: 277677
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277677&view=rev
> Log:
> [clang-tidy] Inefficient string operation
>
A
1 - 100 of 153 matches
Mail list logo
