compnerd added a comment.
Hmm, could do something devious. Write the test and run that through the c
preprocessor and then use that to compare the string. Ugly, but would be
completely generic and ensure that we see the value we expect always.
https://reviews.llvm.org/D18478
_
compnerd added inline comments.
Comment at: lib/Driver/MSVCToolChain.cpp:478
@@ +477,3 @@
+ // toolset, if it exists.
+ if (llvm::sys::fs::exists(X64BinDir)) {
+path = X64BinDir.str();
As per the consensus, this should be:
if (llvm::sys::getProcessTripl
Author: sepavloff
Date: Sun Aug 7 23:02:15 2016
New Revision: 277976
URL: http://llvm.org/viewvc/llvm-project?rev=277976&view=rev
Log:
Pass information in a record instead of stack. NFC
Functions of Sema that work with building of nested name specifiers have too
many parameters (BuildCXXNestedNa
zlei added a comment.
@rengolin Could you please apply this patch? I don't have the permission.
Thanks.
https://reviews.llvm.org/D22904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#506884, @compnerd wrote:
> The `\01` is to prevent the mangler from touching the function name. If you
> noticed the check tags in the quoted test, some targets expect it to be
> decorated and others do not. What exactly do you m
Author: ericwf
Date: Sun Aug 7 21:22:41 2016
New Revision: 277970
URL: http://llvm.org/viewvc/llvm-project?rev=277970&view=rev
Log:
Fix copy/move constructor annotation for the uses-allocator test types.
Previously the copy/move constructors of the test types did not
properly set the arg_id to T
2016-08-06 5:45 GMT-07:00 Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org>:
> Author: d0k
> Date: Sat Aug 6 07:45:16 2016
> New Revision: 277923
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277923&view=rev
> Log:
> [ASTReader] Use real move semantics instead of emulating them in
2016-08-07 15:38 GMT-07:00 Aaron Ballman :
On Sun, Aug 7, 2016 at 6:33 PM, Piotr Padlewski
> wrote:
> > Prazek added a comment.
> >
> > Yea, I also have never heard of it. I don't think it is worth even
> discussing
>
Just because you've never heard of a compiler extension that gets
> pointed out
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/ExprConstant.cpp:5775
@@ +5774,3 @@
+Info.FFDiag(E, diag::note_unimplemented_constexpr_lambda_feature_ast)
+<< "can not evaluate lambda expressions with captures";
+return false;
Min
On Sun, Aug 7, 2016 at 6:33 PM, Piotr Padlewski
wrote:
> Prazek added a comment.
>
> Yea, I also have never heard of it. I don't think it is worth even discussing
Just because you've never heard of a compiler extension that gets
pointed out during review does not mean it's not worth discussing. N
Author: hubert.reinterpretcast
Date: Sun Aug 7 17:26:04 2016
New Revision: 277968
URL: http://llvm.org/viewvc/llvm-project?rev=277968&view=rev
Log:
[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor
Summary:
The synopsis in C++11 subclause 28.8 [re.regex] has:
```
basic_regex(const
Prazek added a comment.
Yea, I also have never heard of it. I don't think it is worth even discussing
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hubert.reinterpretcast
Date: Sun Aug 7 17:23:24 2016
New Revision: 277967
URL: http://llvm.org/viewvc/llvm-project?rev=277967&view=rev
Log:
Revert r277966. Forgot patch attribution.
Removed:
libcxx/trunk/test/std/re/re.regex/re.regex.construct/ptr_size.pass.cpp
Modified:
libcxx/t
Author: hubert.reinterpretcast
Date: Sun Aug 7 17:18:33 2016
New Revision: 277966
URL: http://llvm.org/viewvc/llvm-project?rev=277966&view=rev
Log:
[libcxx] Add "flag" default arg: basic_regex ptr_size_flag ctor
Summary:
The synopsis in C++11 subclause 28.8 [re.regex] has:
```
basic_regex(const
Author: ericwf
Date: Sun Aug 7 16:47:06 2016
New Revision: 277964
URL: http://llvm.org/viewvc/llvm-project?rev=277964&view=rev
Log:
Mark LWG 2726 as complete. No code change needed.
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.
On Sun, Aug 07, 2016 at 11:08:22AM +, Amjad Aboud via cfe-commits wrote:
> aaboud marked 3 inline comments as done.
> aaboud added a comment.
>
> In https://reviews.llvm.org/D22045#506996, @joerg wrote:
>
> > For what it is worth, this certainly seems to be misnamed. By nature, if it
> > doe
I've seen couple of projects that have similar opening brace placement
for multiline conditions. Here are links to their style guides:
https://github.com/mpv-player/mpv/blob/master/DOCS/contribute.md
and
http://gem5.org/Coding_Style#Braces
>Воскресенье, 7 августа 2016, 3:04 +03:00 от Rinat Ib
omtcyfz added a comment.
In https://reviews.llvm.org/D23243#508097, @aaron.ballman wrote:
> LGTM! We may want to consider BinaryConditionalOperator as well, but that can
> be in as a separate patch.
Well, I personally have never seen `BinaryConditionalOperator `in my life.
And honestly I'm no
omtcyfz updated this revision to Diff 67102.
omtcyfz added a comment.
Added ternary operator example to docs.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
docs/clang-tidy/checks/modernize-use-bool-literals.rst
test/clang-tidy/modernize-use-bool-lite
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM! We may want to consider BinaryConditionalOperator as well, but that can
be in as a separate patch.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsC
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Resu
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Resu
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Resu
omtcyfz added inline comments.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Result) {
- const auto *Literal = Result.Nodes.getNodeAs("literal");
- const auto *Cast = Result.Nod
aaron.ballman added a comment.
Would it also make sense to support `BinaryConditionalOperator` as well as the
ternary operator?
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:51-52
@@ -34,4 +50,4 @@
void UseBoolLiteralsCheck::check(const MatchFinder::MatchResult &Re
omtcyfz marked 2 inline comments as done.
omtcyfz added a comment.
Thanks.
Yes, sure.
https://reviews.llvm.org/D23243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM, but wait a day, maybe someone will have other comments.
https://reviews.llvm.org/D23243
___
cfe-commits ma
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1674
@@ +1673,3 @@
+ TargetSpecificAttr {
+ let Spellings = [GNU<"no_caller_saved_registers">];
+ let Subjects = SubjectList<[FunctionLike], WarnDiag, "ExpectedFunction
aaboud marked an inline comment as not done.
Comment at: include/clang/Basic/Attr.td:1674
@@ +1673,3 @@
+ TargetSpecificAttr {
+ let Spellings = [GNU<"no_caller_saved_registers">];
+ let Subjects = SubjectList<[FunctionLike], WarnDiag, "Expected
aaboud marked 3 inline comments as done.
aaboud added a comment.
In https://reviews.llvm.org/D22045#506996, @joerg wrote:
> For what it is worth, this certainly seems to be misnamed. By nature, if it
> doesn't preserve at least the stack pointer, there is no way to recover on
> return, right?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277955: [AVX512] integer comparisions enumeration. (authored
by abadouh).
Changed prior to commit:
https://reviews.llvm.org/D22212?vs=63486&id=67097#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: abadouh
Date: Sun Aug 7 05:43:04 2016
New Revision: 277955
URL: http://llvm.org/viewvc/llvm-project?rev=277955&view=rev
Log:
[AVX512] integer comparisions enumeration.
fix Bug 28842 https://llvm.org/bugs/show_bug.cgi?id=28842
Differential Revision: https://reviews.llvm.org/D22212
Mo
omtcyfz marked 2 inline comments as done.
Comment at: clang-tidy/modernize/UseBoolLiteralsCheck.cpp:38-43
@@ +37,8 @@
+ unless(isInTemplateInstantiation(,
+ anyOf(hasTrueExpression(ignoringParenImpCasts(
+integerLiteral().bind("trueBra
omtcyfz removed rL LLVM as the repository for this revision.
omtcyfz updated this revision to Diff 67095.
omtcyfz added a comment.
Comment `anyOf()` part in check's matcher and extend testset.
https://reviews.llvm.org/D23243
Files:
clang-tidy/modernize/UseBoolLiteralsCheck.cpp
test/clang-ti
Author: majnemer
Date: Sun Aug 7 03:28:58 2016
New Revision: 277953
URL: http://llvm.org/viewvc/llvm-project?rev=277953&view=rev
Log:
Update clang tests for LLVM r277950
We infer inbounds on GEPs of allocas leading to minor perturbations in
tests.
Modified:
cfe/trunk/test/CodeGenObjCXX/exce
delena accepted this revision.
This revision is now accepted and ready to land.
Comment at: ../tunkClang/tools/clang/test/CodeGen/avx512vl-builtins.c:504
@@ -503,3 +503,3 @@
__mmask8 test_mm_cmp_epi32_mask(__m128i __a, __m128i __b) {
// CHECK-LABEL: @test_mm_cmp_epi32_mask
-
40 matches
Mail list logo
