Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

honggyu.kim added a comment. I see the difference now. Below is the originally generated IR without this patch. It shows `\01` clearly in `call void @"\01__gnu_mcount_nc"()`. $ clang -target armv7-unknown-none-eabi -pg -meabi gnu -S -emit-llvm -o - test-mcount.c ; ModuleID = 'mcount.c' s

Re: Diagnostics improvements for 3.9

These all sgtm for 3.9. Go ahead and merge with utils/release/merge.sh, or I'll do it when I get in on Monday. Cheers, Hans On Fri, Aug 5, 2016 at 6:52 PM, Richard Trieu wrote: > Typos and unused test variables fixed in r277900 > > On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: >> >> On F

r277906 - [NFC] Silence noisy -Wreturn-type warnings

Author: epilk Date: Fri Aug 5 20:54:50 2016 New Revision: 277906 URL: http://llvm.org/viewvc/llvm-project?rev=277906&view=rev Log: [NFC] Silence noisy -Wreturn-type warnings Modified: cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/trunk/lib/Sema/SemaExpr.cpp URL: http://llvm.org/viewvc/llvm

Re: Diagnostics improvements for 3.9

Typos and unused test variables fixed in r277900 On Fri, Aug 5, 2016 at 6:46 PM, Richard Smith wrote: > On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith > wrote: > >> These all look OK for the branch. Hans, the second one fixes a crasher, >> so I'd like to take at least that one. The others fix wa

r277900 - Fix typos from r277797 and unused variable from r277889.

Author: rtrieu Date: Fri Aug 5 20:44:06 2016 New Revision: 277900 URL: http://llvm.org/viewvc/llvm-project?rev=277900&view=rev Log: Fix typos from r277797 and unused variable from r277889. Modified: cfe/trunk/lib/AST/ASTDiagnostic.cpp cfe/trunk/test/SemaCXX/return-stack-addr-2.cpp Modif

Re: Diagnostics improvements for 3.9

On Fri, Aug 5, 2016 at 6:33 PM, Richard Smith wrote: > These all look OK for the branch. Hans, the second one fixes a crasher, so > I'd like to take at least that one. The others fix warning false positives > (which are not regressions) and look fairly safe. > Correction: looks like the final on

Re: Diagnostics improvements for 3.9

These all look OK for the branch. Hans, the second one fixes a crasher, so I'd like to take at least that one. The others fix warning false positives (which are not regressions) and look fairly safe. On Fri, Aug 5, 2016 at 4:39 PM, Richard Trieu wrote: > Hans, Richard, > > These are some last mi

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

honggyu.kim added a comment. In https://reviews.llvm.org/D22666#506884, @compnerd wrote: > The `\01` is to prevent the mangler from touching the function name. If you > noticed the check tags in the quoted test, some targets expect it to be > decorated and others do not. What exactly do you m

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

compnerd accepted this revision. compnerd added a comment. Ah, okay. Sounds good. https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Diagnostics improvements for 3.9

Hans, Richard, These are some last minute diagnostic improvements for 3.9. http://llvm.org/viewvc/llvm-project?rev=277796&view=rev r277796 Don't warn when negative values, like -1, are used to initialize unsigned bit fields. http://llvm.org/viewvc/llvm-project?rev=277797&view=rev r277797 Fix cra

r277889 - Fix two false positives in -Wreturn-stack-address

Author: rtrieu Date: Fri Aug 5 18:24:47 2016 New Revision: 277889 URL: http://llvm.org/viewvc/llvm-project?rev=277889&view=rev Log: Fix two false positives in -Wreturn-stack-address If the return type is a pointer and the function returns the reference to a pointer, don't warn since only the val

Re: [PATCH] D23221: [NFC][ObjC Availability] Split up DiagnoseAvailabilityOfDecl, remove redundant enumeration

This revision was automatically updated to reflect the committed changes. Closed by commit rL277887: [NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D23221?vs=66996&id=67044#toc Repository: rL LLVM https://r

r277887 - [NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl

Author: epilk Date: Fri Aug 5 17:59:03 2016 New Revision: 277887 URL: http://llvm.org/viewvc/llvm-project?rev=277887&view=rev Log: [NFC][ObjC Availability] Refactor DiagnoseAvailabilityOfDecl Differential revision: https://reviews.llvm.org/D23221 Modified: cfe/trunk/include/clang/Sema/Delay

r277885 - [clang-tblgen] Remove unused #include (NFC)

Author: vedantk Date: Fri Aug 5 17:48:53 2016 New Revision: 277885 URL: http://llvm.org/viewvc/llvm-project?rev=277885&view=rev Log: [clang-tblgen] Remove unused #include (NFC) Modified: cfe/trunk/utils/TableGen/TableGen.cpp Modified: cfe/trunk/utils/TableGen/TableGen.cpp URL: http://llvm.

Re: [PATCH] D23221: [NFC][ObjC Availability] Split up DiagnoseAvailabilityOfDecl, remove redundant enumeration

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. Thanks, Manman https://reviews.llvm.org/D23221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [libunwind] r277868 - unwind: disable executable stacks

On Fri, Aug 5, 2016 at 2:35 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Fri Aug 5 16:35:28 2016 > New Revision: 277868 > > URL: http://llvm.org/viewvc/llvm-project?rev=277868&view=rev > Log: > unwind: disable executable stacks > > Similar

[libunwind] r277868 - unwind: disable executable stacks

Author: compnerd Date: Fri Aug 5 16:35:28 2016 New Revision: 277868 URL: http://llvm.org/viewvc/llvm-project?rev=277868&view=rev Log: unwind: disable executable stacks Similar to compiler-rt, ensure that we disable executable stacks for the custom assembly. Modified: libunwind/trunk/src/Unw

r277866 - Fix false positive in -Wunsequenced and templates.

Author: rtrieu Date: Fri Aug 5 16:02:34 2016 New Revision: 277866 URL: http://llvm.org/viewvc/llvm-project?rev=277866&view=rev Log: Fix false positive in -Wunsequenced and templates. For builtin logical operators, there is a well-defined ordering of argument evaluation. For overloaded operator

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added a comment. In https://reviews.llvm.org/D23086#507203, @yaxunl wrote: > How about assuming ndrange_t is a struct type defined by user and identify it > by struct type name in Clang? This gives user freedom of implementing it > differently than SPIR. In opencl-c.h define it as a stru

[PATCH] D23221: [NFC][ObjC Availability] Split up DiagnoseAvailabilityOfDecl, remove redundant enumeration

erik.pilkington created this revision. erik.pilkington added a reviewer: manmanren. erik.pilkington added a subscriber: cfe-commits. This patch removes the enum `Sema::AvailabilityDiagnostic`, which is redundant with `clang::AvailabilityResult`, and pulls out a function, `ShouldDiagnoseAvailabil

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

rengolin added a comment. The include_next is to make sure that, whatever other environment that happens to have the same include name, should pick it up if the user or the environment provides one, or errors out if it doesn't. Pretty standard. https://reviews.llvm.org/D22774 __

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos marked 2 inline comments as done. vmiklos added a comment. > Would also be nice to support at least `offset + new-name` in YAML input > files, too. Done. > Please move this block upwards [preferably right after line 42]. I consider > information about limitations and editor more impo

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos updated this revision to Diff 66993. https://reviews.llvm.org/D23198 Files: clang-rename/tool/ClangRename.cpp docs/clang-rename.rst test/clang-rename/ClassTestMultiByNameYAML.cpp test/clang-rename/ClassTestMultiByNameYAML.cpp.rename-all.yaml test/clang-rename/ClassTestMultiByNam

r277852 - PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type

Author: dblaikie Date: Fri Aug 5 14:03:01 2016 New Revision: 277852 URL: http://llvm.org/viewvc/llvm-project?rev=277852&view=rev Log: PR26423: Assert on valid use of using declaration of a function with an undeduced auto return type For now just disregard the using declaration in this case. Sub

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

majnemer added a comment. In https://reviews.llvm.org/D23086#507203, @yaxunl wrote: > How about assuming ndrange_t is a struct type defined by user and identify it > by struct type name in Clang? This gives user freedom of implementing it > differently than SPIR. In opencl-c.h define it as a st

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added a comment. How about assuming ndrange_t is a struct type defined by user and identify it by struct type name in Clang? This gives user freedom of implementing it differently than SPIR. In opencl-c.h define it as a struct type as SPIR required. Repository: rL LLVM https://revie

[PATCH] D23218: [ADT] Change iterator_adaptor_base's default template arguments to forward more underlying typedefs

timshen created this revision. timshen added reviewers: chandlerc, bkramer. timshen added a subscriber: cfe-commits. The corresponding LLVM change: D23217. LazyVector::iterator breaks, because int isn't an iterator type. Since iterator_adaptor_base shouldn't be blamed to break at the call to iter

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

mstorsjo added a comment. In https://reviews.llvm.org/D22774#507014, @compnerd wrote: > Why `include_next` the header if not on Windows? Mostly because intrin.h uses the same logic. Normally, there's probably no such system header in other SDKs, but say if you happen to have a custom one named

Re: [PATCH] D22940: [OpenCL] Handle -cl-fp32-correctly-rounded-divide-sqrt

Anastasia accepted this revision. Anastasia added a comment. LGTM! Comment at: include/clang/Driver/Options.td:393 @@ -392,1 +392,3 @@ +def cl_fp32_correctly_rounded_divide_sqrt : Flag<["-"], "cl-fp32-correctly-rounded-divide-sqrt">, Group, Flags<[CC1Option]>, + HelpText<"Ope

r277840 - [SemaOpenMP] Some miscellaneous cleanups

Author: majnemer Date: Fri Aug 5 12:44:54 2016 New Revision: 277840 URL: http://llvm.org/viewvc/llvm-project?rev=277840&view=rev Log: [SemaOpenMP] Some miscellaneous cleanups Clean up some typos, follow the coding style a little more rigorously. No functionality change is intended. Modified:

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

majnemer added a comment. In https://reviews.llvm.org/D23086#507098, @Anastasia wrote: > In https://reviews.llvm.org/D23086#507055, @majnemer wrote: > > > This approach seems wrong to me. > > > > Instead, why not just make `ndrange_t` a typedef of a real struct in > > `Sema::Initialize`? > > > I

Re: [PATCH] D22815: [OpenCL][AMDGPU] Add support for -cl-denorms-are-zero

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D22815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added a comment. In https://reviews.llvm.org/D23086#507055, @majnemer wrote: > This approach seems wrong to me. > > Instead, why not just make `ndrange_t` a typedef of a real struct in > `Sema::Initialize`? I think we have an issue because in that case during the diagnostic of enque

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

yaxunl added a comment. In https://reviews.llvm.org/D23086#507055, @majnemer wrote: > This approach seems wrong to me. > > Instead, why not just make `ndrange_t` a typedef of a real struct in > `Sema::Initialize`? ndrange_t is an OpenCL builtin type and the spec does not define its layout. Th

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

majnemer added a subscriber: majnemer. majnemer requested changes to this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision now requires changes to proceed. This approach seems wrong to me. Instead, why not just make `ndrange_t` a typedef of a real struct in

Re: r277787 - [Sema] Add sizeof diagnostics for bzero

On Thu, Aug 4, 2016 at 4:55 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Thu Aug 4 18:55:22 2016 > New Revision: 277787 > > URL: http://llvm.org/viewvc/llvm-project?rev=277787&view=rev > Log: > [Sema] Add sizeof diagnostics for bzero > > For

Re: [PATCH] D23086: [OpenCL] Generate concrete struct type for ndrange_t

Anastasia added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:43 @@ +42,3 @@ + + return llvm::StructType::create(EleTypes, "ndrange_t"); +} yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > > yaxunl wrote: > > > > struct name should be "struct

Re: r277787 - [Sema] Add sizeof diagnostics for bzero

Hi Gabor, Thanks for the PR, I reverted it in r277830 until I can manage to fix it. On Fri, Aug 5, 2016 at 6:44 AM, Gabor Ballabas wrote: > Hi Bruno, > > My name is Gabor Ballabas, I work at the University of Szeged, Hungary. > We run daily code size benchmarks testing trunk Clang. After your pa

r277830 - Revert "[Sema] Add sizeof diagnostics for bzero"

Author: bruno Date: Fri Aug 5 11:41:00 2016 New Revision: 277830 URL: http://llvm.org/viewvc/llvm-project?rev=277830&view=rev Log: Revert "[Sema] Add sizeof diagnostics for bzero" This reverts commit r277787, which caused PR28870. Modified: cfe/trunk/lib/AST/Decl.cpp cfe/trunk/lib/Sema/

RE: r277743 - [OpenCL] Added underscores to the names of 'to_addr' OpenCL built-ins.

Hans, If still possible could we merge this into 3.9. It contains just a minor renaming but it makes all those new OpenCL Builtins usable. Thanks, Anastasia -Original Message- From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of Alexey Bader via cfe-commits Sent:

Re: [PATCH] D22774: [MSVC] Add ARM support to intrin.h for MSVC compatibility

compnerd added a comment. I had reversed the condition in my head. Why `include_next` the header if not on Windows? https://reviews.llvm.org/D22774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 66971. Alexander_Droste marked an inline comment as done. Alexander_Droste added a comment. - check for `nullptr` in `addBuffer` https://reviews.llvm.org/D22729 Files: clang-tidy/mpi/BufferDerefCheck.cpp clang-tidy/mpi/BufferDerefCheck.h clan

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste marked an inline comment as done. Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:88 @@ +87,3 @@ +while (true) { + if (BufferType->isPointerType()) { +BufferType = BufferType->getPointeeType().getTypePtr(); I just realized, you me

r277824 - AMDGPU : Add Clang builtin intrinsics for compare with the full

Author: wdng Date: Fri Aug 5 10:38:46 2016 New Revision: 277824 URL: http://llvm.org/viewvc/llvm-project?rev=277824&view=rev Log: AMDGPU : Add Clang builtin intrinsics for compare with the full wavefront result. Differential Revision: http://reviews.llvm.org/D22934 Modified: cfe/trunk/inclu

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

joerg added a subscriber: joerg. joerg added a comment. For what it is worth, this certainly seems to be misnamed. By nature, if it doesn't preserve at least the stack pointer, there is no way to recover on return, right? https://reviews.llvm.org/D22045 _

Re: [PATCH] D22702: [libcxx]Missing default argument for flag_type parameter in one of std::basic_regex constructors

jasonliu marked an inline comment as done. jasonliu added a comment. Gentle ping? https://reviews.llvm.org/D22702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

NoQ added a comment. Something like this, what do you think?: F2247884: TestAlmostNonPOD.patch https://reviews.llvm.org/D22374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

compnerd added a comment. The `\01` is to prevent the mangler from touching the function name. If you noticed the check tags in the quoted test, some targets expect it to be decorated and others do not. What exactly do you mean that `lit` has a strings matching with `\01`? Its not a string `

Re: [PATCH] D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma

kkwli0 added a comment. Thanks. I will update it when I commit the patch. https://reviews.llvm.org/D23189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23196: [ARM] Command-line options for embedded position-independent code

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Hi Oliver, The driver part looks good to me, thanks! I haven't looked at the LLVM side of the patch. The other reviews probably know more than I do about that, anyway. :) cheers, --renat

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

omtcyfz added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:140 @@ -116,1 +139,3 @@ cl::value_desc("filename"), cl::cat(*Category)); + cl::opt Input( + "input", cl::desc("YAML file to load oldname-newname pairs from."), vmiklos wrote:

Re: r277787 - [Sema] Add sizeof diagnostics for bzero

Hi Bruno, My name is Gabor Ballabas, I work at the University of Szeged, Hungary. We run daily code size benchmarks testing trunk Clang. After your patch landed we started to get a Clang crash when compiling one of the files in our benchmark system. I created a bugreport with the details: htt

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:140 @@ -116,1 +139,3 @@ cl::value_desc("filename"), cl::cat(*Category)); + cl::opt Input( + "input", cl::desc("YAML file to load oldname-newname pairs from."), omtcyfz wrote:

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

omtcyfz added a comment. Still don't see general use case for that one, but since we already support multiple renamings "at once"... Would also be nice to support at least `offset + new-name` in YAML input files, too. Comment at: clang-rename/tool/ClangRename.cpp:140 @@ -116,

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste updated this revision to Diff 66940. Alexander_Droste marked 3 inline comments as done. Alexander_Droste added a comment. - add release docs - simplify reverse for loop -> `rbegin`, `rend` https://reviews.llvm.org/D22729 Files: clang-tidy/mpi/BufferDerefCheck.cpp clang-tidy

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

Alexander_Droste marked 4 inline comments as done. Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87 @@ +86,3 @@ +// Capture the depth and types of indirections for the passed buffer. +while (true) { + if (BufferType->isPointerType()) { hokein wrote:

Re: [PATCH] D23160: [Coverage] Prevent creating a redundant counter if a nested body ends with a macro.

ikudrin added a comment. I've reduced the last sample to the following: 0|1|void dummy() {} |2| 0|3|#define MACRO_1 dummy() |4| 1|5|#define MACRO_2 MACRO_1 |6| 1|7|int main() { 1|8| int i = 0; 1|9| if (

Re: [PATCH] D23199: [include-fixer] Correct some header mappings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277811: [include-fixer] Correct some header mappings. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23199?vs=66926&id=66930#toc Repository: rL LLVM https://reviews.llvm.or

[clang-tools-extra] r277811 - [include-fixer] Correct some header mappings.

Author: hokein Date: Fri Aug 5 06:54:34 2016 New Revision: 277811 URL: http://llvm.org/viewvc/llvm-project?rev=277811&view=rev Log: [include-fixer] Correct some header mappings. Reviewers: bkramer Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D23199 Modified: c

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support diagnos

Re: [PATCH] D23199: [include-fixer] Correct some header mappings.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D23199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D23199: [include-fixer] Correct some header mappings.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D23199 Files: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp ==

Re: [PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos added a comment. As a side note, this is the last feature that LibreOffice's simple clang-based rename tool (https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/clang/rename.cxx) supports, and clang-rename does not. (That one takes a CSV file, but in case -export-fixes outp

[PATCH] D23198: clang-rename rename-all: support reading old/newname pairs from a YAML file

vmiklos created this revision. vmiklos added reviewers: klimek, omtcyfz. vmiklos added a subscriber: cfe-commits. This is handy in case by the time clang-rename is invoked, an external tool already genereated a list of oldname -> newname pairs to handle. https://reviews.llvm.org/D23198 Files:

Re: [PATCH] D23189: [OpenMP] Sema and parsing for 'teams distribute' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: include/clang/Sema/Sema.h:8254 @@ -8253,1 +8253,3 @@ llvm::DenseMap &VarsWithImplicitDSA); + /// \brief Called on well-formed '\#pragma omp

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

baloghadamsoftware added a comment. In https://reviews.llvm.org/D22374#506098, @NoQ wrote: > I guess i could post a patch-over-a-patch if what i'm expressing isn't clear. I think this would be the best :-) https://reviews.llvm.org/D22374 ___ cfe-

[clang-tools-extra] r277806 - Reapply r276973 "Adjust Registry interface to not require plugins to export a registry"

Author: john.brawn Date: Fri Aug 5 06:01:08 2016 New Revision: 277806 URL: http://llvm.org/viewvc/llvm-project?rev=277806&view=rev Log: Reapply r276973 "Adjust Registry interface to not require plugins to export a registry" This differs from the previous version by being more careful about temp

r277806 - Reapply r276973 "Adjust Registry interface to not require plugins to export a registry"

Author: john.brawn Date: Fri Aug 5 06:01:08 2016 New Revision: 277806 URL: http://llvm.org/viewvc/llvm-project?rev=277806&view=rev Log: Reapply r276973 "Adjust Registry interface to not require plugins to export a registry" This differs from the previous version by being more careful about temp

Re: [PATCH] D22729: MPIBufferDerefCheck for Clang-Tidy

hokein added inline comments. Comment at: clang-tidy/mpi/BufferDerefCheck.cpp:87 @@ +86,3 @@ +// Capture the depth and types of indirections for the passed buffer. +while (true) { + if (BufferType->isPointerType()) { check whether `BufferType` is `nul

[PATCH] D23196: [ARM] Command-line options for embedded position-independent code

olista01 created this revision. olista01 added reviewers: t.p.northover, rengolin, srhines, weimingz. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: samparker, rengolin, aemerson. This patch (with the corresponding ARM

Re: [PATCH] D21072: [mips] Account for -mabi when determining whether IAS is the default or not.

dsanders added a comment. One last ping since I need to either commit this series next week or hand over to a colleague to continue it. https://reviews.llvm.org/D21072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D21070: Pass the ABI in the triple when appropriate (currently for MIPS) for 'clang -cc1' and 'clang -cc1as'

dsanders added a comment. One last ping since I need to either commit this series next week or hand over to a colleague to continue it. https://reviews.llvm.org/D21070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

Hahnfeld added a comment. Any chance we can get this fixed? Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:89-95 @@ +88,9 @@ +} +if (ec) { +assert(old_write_time == new_write_time); +return false;

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

Hahnfeld added a subscriber: Hahnfeld. Hahnfeld added a comment. In https://reviews.llvm.org/D18172#500029, @sfantao wrote: > Any more comments on this patch or depending ones? > > Thanks! > Samuel I can report that the latest patches are working for me and that they fix all points that I prev

[PATCH] D23193: [clang-rename] fix bug with initializer lists

omtcyfz created this revision. omtcyfz added a reviewer: alexfh. omtcyfz added a subscriber: cfe-commits. `clang-rename` is currently not able to find a symbol in initializer list. This patch is a fix of that bug. https://reviews.llvm.org/D23193 Files: clang-rename/USRFinder.cpp clang-renam

Re: [PATCH] D22220: [clang-tidy] Add check 'misc-move-forwarding-reference'

mboehme updated this revision to Diff 66914. mboehme marked 2 inline comments as done. mboehme added a comment. Renamed canReferToDecl to hasAnyDeclaration. This is for consistency with the corresponding change in https://reviews.llvm.org/D23004. https://reviews.llvm.org/D0 Files:

Re: [PATCH] D23004: [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()

mboehme marked 5 inline comments as done. mboehme added a comment. https://reviews.llvm.org/D23004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23004: [ASTMatchers] Add matchers canReferToDecl() and hasUnderlyingDecl()

mboehme updated this revision to Diff 66912. mboehme added a comment. - Rename canReferToDecl to hasAnyDeclaration https://reviews.llvm.org/D23004 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/