Alexander_Droste added a comment.
Thanks for re-committing this patch!
Repository:
rL LLVM
https://reviews.llvm.org/D21962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277576: [clang/test] Fix a flaky unittest on windows
(authored by etienneb).
Changed prior to commit:
https://reviews.llvm.org/D23105?vs=66615&id=66616#toc
Repository:
rL LLVM
https://reviews.llvm.o
Author: etienneb
Date: Wed Aug 3 01:10:15 2016
New Revision: 277576
URL: http://llvm.org/viewvc/llvm-project?rev=277576&view=rev
Log:
[clang/test] Fix a flaky unittest on windows
Summary:
The append operator on a shell command for quick command-line is
causing trouble on windows. [NFC]
The easie
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added subscribers: chrisha, cfe-commits.
The append operator on a shell command for quick command-line is
causing trouble on windows. [NFC]
The easiest way to fix them is to avoid using them.
This patch is an attempt to fix
Author: ericwf
Date: Wed Aug 3 00:51:19 2016
New Revision: 277575
URL: http://llvm.org/viewvc/llvm-project?rev=277575&view=rev
Log:
Add MSVC specifics to .gitignore. Patch from s...@microsoft.com
Modified:
libcxx/trunk/.gitignore
Modified: libcxx/trunk/.gitignore
URL:
http://llvm.org/viewv
EricWF closed this revision.
EricWF added a comment.
r277575.
https://reviews.llvm.org/D22819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Why not.
https://reviews.llvm.org/D22819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
EricWF closed this revision.
EricWF added a comment.
r277574.
https://reviews.llvm.org/D22972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Aug 3 00:50:03 2016
New Revision: 277574
URL: http://llvm.org/viewvc/llvm-project?rev=277574&view=rev
Log:
Fix compile error due to mismatched iterator types. Patch from
s...@microsoft.com
Modified:
libcxx/trunk/test/std/containers/sequences/list/list.cons/initiali
Author: ericwf
Date: Wed Aug 3 00:48:09 2016
New Revision: 277573
URL: http://llvm.org/viewvc/llvm-project?rev=277573&view=rev
Log:
Fix an MSVC x64 compiler warning. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/utilities/memory/allocator.traits/allocator.traits.members/allo
EricWF closed this revision.
EricWF added a comment.
r277573.
https://reviews.llvm.org/D22971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF closed this revision.
EricWF added a comment.
r277572.
https://reviews.llvm.org/D22818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Aug 3 00:46:36 2016
New Revision: 277572
URL: http://llvm.org/viewvc/llvm-project?rev=277572&view=rev
Log:
Silence another occurrence of MSVC's suprious unused warning. Patch from
s...@microsoft.com
Modified:
libcxx/trunk/test/support/test_allocator.h
Modified: lib
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D22818#496220, @majnemer wrote:
> Do we have a way to keep track of this change so we can remove it when MSVC
> gets fixed?
No, but I'm not concerned about a void
EricWF added a subscriber: EricWF.
EricWF added a comment.
LGTM.
However I would like to see a small benchmark that demonstrates the performance
change. Please try and write the benchmark using Google Benchmark.
Some helpful links:
http://libcxx.llvm.org/docs/TestingLibcxx.html#building-benchma
Author: akirtzidis
Date: Wed Aug 3 00:38:53 2016
New Revision: 277570
URL: http://llvm.org/viewvc/llvm-project?rev=277570&view=rev
Log:
[index] Fix crash with indexing designated init expressions inside templates.
rdar://27452869
Modified:
cfe/trunk/lib/Index/IndexBody.cpp
cfe/trunk/tes
On Mon, Aug 1, 2016 at 2:20 PM, David Blaikie via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Tue, Jul 26, 2016 at 4:37 PM Laxman Sole via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> laxmansole created this revision.
>> laxmansole added reviewers: mclow.lists, howard.hinn
On Sat, Jul 30, 2016 at 1:47 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Jul 26, 2016 at 10:30:22PM +, Laxman Sole via cfe-commits
> wrote:
> > Currently basic_string's destructor is not getting inlined. So adding
> 'inline' attribute to ~basic_string(
EricWF added a subscriber: EricWF.
EricWF added a comment.
The change itself LGTM, although we probably want to inline the forward/input
iterator __init's as well.
However I would like to see a small benchmark that demonstrates the performance
change. Please try and write the benchmark using Go
djasper added a comment.
No, I don't think so. Because you need a "double-indent" within classes.
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
In https://reviews.llvm.org/D20196#504397, @bittnerbarni wrote:
> I'm planning to submit more patches in the future, as I have time for them.
> So it wouldn't be in vain :)
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
https://reviews.llvm.org/D201
bittnerbarni added a comment.
I'm planning to submit more patches in the future, as I have time for them. So
it wouldn't be in vain :)
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Prazek added a subscriber: Prazek.
Prazek added a comment.
In https://reviews.llvm.org/D20196#504394, @bittnerbarni wrote:
> Thank you for all the assistance. Could you please do that?
btw obtaining commit access and commiting is very simple, so if you are
planning to send us some more cool pa
bittnerbarni added a comment.
Thank you for all the assistance. Could you please do that?
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
laxmansole added a comment.
Ping
https://reviews.llvm.org/D22782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
In https://reviews.llvm.org/D22853#503303, @chapuni wrote:
> Seems a couple of tests would be incompatible to -fdelayed-template-parsing.
> Appeased in r277452.
Thank you! And sorry for the inconvenience.
Repository:
rL LLVM
https://reviews.llvm.org/D22853
_
CUDA tests should be fixed in r277552.
On Tue, Aug 2, 2016 at 4:48 PM, Artem Belevich wrote:
> Sorry about that. I'll commit the fix shortly.
>
> On Tue, Aug 2, 2016 at 4:33 PM, Bruno Cardoso Lopes <
> bruno.card...@gmail.com> wrote:
>
>> Hi Artem,
>>
>> This broke
>> http://lab.llvm.org:8080/
Author: tra
Date: Tue Aug 2 18:43:04 2016
New Revision: 277552
URL: http://llvm.org/viewvc/llvm-project?rev=277552&view=rev
Log:
[CUDA] Updated CUDA tests that must run w/o CUDA installation.
Fixes test failures after r277542 on systems that don't have
CUDA installed.
Modified:
cfe/trunk/te
Sorry about that. I'll commit the fix shortly.
On Tue, Aug 2, 2016 at 4:33 PM, Bruno Cardoso Lopes wrote:
> Hi Artem,
>
> This broke
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856
> ,
> can you take a look?
>
> Thanks,
>
> On Tue, Aug 2, 2016 at 4:12 PM, Artem
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for working on this!
Do you need me to commit the patch for you?
https://reviews.llvm.org/D20196
___
cfe-commits mailing l
ahatanak created this revision.
ahatanak added reviewers: rsmith, sepavloff.
ahatanak added a subscriber: cfe-commits.
This fixes PR28795.
https://llvm.org/bugs/show_bug.cgi?id=28795
Sema wasn't replacing DependentScopeDeclRefExpr with DeclRefExpr during
template instantiation of the default ar
Hi Artem,
This broke
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856,
can you take a look?
Thanks,
On Tue, Aug 2, 2016 at 4:12 PM, Artem Belevich via cfe-commits
wrote:
> Author: tra
> Date: Tue Aug 2 18:12:51 2016
> New Revision: 277542
>
> URL: http://llvm.o
Author: dcoughlin
Date: Tue Aug 2 18:24:40 2016
New Revision: 277547
URL: http://llvm.org/viewvc/llvm-project?rev=277547&view=rev
Log:
[analyzer] Update two comments in MPI-Checker. NFC.
Correct two comments that do not match the current behavior of the checker.
A patch by Alexander Droste!
Di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277547: [analyzer] Update two comments in MPI-Checker. NFC.
(authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D22670?vs=65047&id=66594#toc
Repository:
rL LLVM
https://review
dcoughlin added a comment.
In https://reviews.llvm.org/D18073#437171, @ariccio wrote:
> I should elaborate. The principle of operation of this latest patch is that
> the `FunctionDecl` in `IsCMemFunction` should never return a `nullptr`
> `IdentifierInfo*` from `getIdentifier` (is that a valid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277542: [CUDA] Fix libdevice selection. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D23037?vs=66579&id=66589#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23037
Files:
Author: tra
Date: Tue Aug 2 18:12:51 2016
New Revision: 277542
URL: http://llvm.org/viewvc/llvm-project?rev=277542&view=rev
Log:
[CUDA] Fix libdevice selection.
This makes clang's libdevice selection match that of NVCC as described in
http://docs.nvidia.com/cuda/libdevice-users-guide/basic-usage
tra marked an inline comment as done.
tra added a comment.
https://reviews.llvm.org/D23037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 66579.
tra added a comment.
Now that https://reviews.llvm.org/D23042 / r277537 makes sure that
CudaToolchain is only used on device side, we can
remove defaults for -march and restore asserts() ensuring that -march is added
by the driver.
https://reviews.llvm
Author: etienneb
Date: Tue Aug 2 17:51:46 2016
New Revision: 277539
URL: http://llvm.org/viewvc/llvm-project?rev=277539&view=rev
Log:
[clang-tidy] Fix missing dependency to static analyzer
Summary:
This patch is fixing the build bot broken for a missing dependency.
The missing dependency is bre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277537: [CUDA] Do not allow using NVPTX target for host
compilation. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D23042?vs=66560&id=66578#toc
Repository:
rL LLVM
https://rev
Author: tra
Date: Tue Aug 2 17:37:47 2016
New Revision: 277537
URL: http://llvm.org/viewvc/llvm-project?rev=277537&view=rev
Log:
[CUDA] Do not allow using NVPTX target for host compilation.
Differential Revision: https://reviews.llvm.org/D23042
Modified:
cfe/trunk/include/clang/Basic/Diagno
tra marked an inline comment as done.
tra added a comment.
https://reviews.llvm.org/D23042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated the summary for this revision.
tra updated this revision to Diff 66560.
tra added a comment.
Added a comment describing why we delibrartly error out on use of NVPTX for
host compilation.
https://reviews.llvm.org/D23042
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Dri
tra added a comment.
In https://reviews.llvm.org/D23042#503869, @jlebar wrote:
> > Restore assertions for presence of -march flag.
>
>
> We don't need an explicit assertion in TranslateArgs?
Nope. The action we create for fatbin uses CudaToolChain, but has nullptr
BoundArch and there's no way
Author: hubert.reinterpretcast
Date: Tue Aug 2 16:34:48 2016
New Revision: 277526
URL: http://llvm.org/viewvc/llvm-project?rev=277526&view=rev
Log:
[libcxx] basic_regex: add traits_type, string_type
Summary:
In the synopsis in C++11 subclause 28.8 [re.regex], `basic_regex` is
specified to have m
Merged in r277525.
Thanks,
Hans
On Tue, Aug 2, 2016 at 2:33 PM, Erik Pilkington via cfe-commits
wrote:
> Sure, this is a pretty harmless bugfix.
> Cheers,
> Erik
>
>> On Aug 2, 2016, at 11:05 AM, Hans Wennborg wrote:
>>
>> Should we merge this to 3.9?
>>
>> Thanks,
>> Hans
>>
>> On Thu, Jul 28,
Sure, this is a pretty harmless bugfix.
Cheers,
Erik
> On Aug 2, 2016, at 11:05 AM, Hans Wennborg wrote:
>
> Should we merge this to 3.9?
>
> Thanks,
> Hans
>
> On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits
> wrote:
>> Author: epilk
>> Date: Thu Jul 28 19:55:40 2016
>> New
erik.pilkington updated this revision to Diff 66555.
erik.pilkington added a comment.
@dcoughlin: Yes, good point!
This new patch uses the enclosing version to diagnose both branches of the '*'
case, as opposed to ignoring them.
https://reviews.llvm.org/D23003
Files:
include/clang/AST/Stmt.
yaxunl added a comment.
ASTContext::getTypeInfoImpl in lib/AST/ASTContext.cpp needs to be updated for
the real size of ndrange_t.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:43
@@ +42,3 @@
+
+ return llvm::StructType::create(EleTypes, "ndrange_t");
+}
struct n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277523: [clang-tidy] Fix segfault in
cppcore-guidelines-special-member-functions check (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D23008?vs=66541&id=66558#toc
Repository:
Author: jbcoe
Date: Tue Aug 2 16:18:37 2016
New Revision: 277523
URL: http://llvm.org/viewvc/llvm-project?rev=277523&view=rev
Log:
[clang-tidy] Fix segfault in cppcore-guidelines-special-member-functions check
Summary:
Use a set rather than a vector of defined special member functions so
that mu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277522: [CFG] Fix crash finding destructor of
lifetime-extended temporary. (authored by dcoughlin).
Changed prior to commit:
https://reviews.llvm.org/D22419?vs=65545&id=66554#toc
Repository:
rL LLVM
Author: dcoughlin
Date: Tue Aug 2 16:07:23 2016
New Revision: 277522
URL: http://llvm.org/viewvc/llvm-project?rev=277522&view=rev
Log:
[CFG] Fix crash finding destructor of lifetime-extended temporary.
Fix a crash under -Wthread-safety when finding the destructor for a
lifetime-extending referen
ashi1 created this revision.
ashi1 added reviewers: bader, Anastasia, yaxunl.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
ndrange_t needs to be emitted as a struct type since it has to be allocated on
a stack as a local variable or function return
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. I will commit. Thanks Nandor!
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Author: alexfh
Date: Tue Aug 2 15:29:35 2016
New Revision: 277516
URL: http://llvm.org/viewvc/llvm-project?rev=277516&view=rev
Log:
[clang-tidy] MPITypeMismatchCheck
This check verifies if buffer type and MPI (Message Passing Interface)
datatype pairs match. All MPI datatypes defined by the MPI
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277516: [clang-tidy] MPITypeMismatchCheck (authored by
alexfh).
Changed prior to commit:
https://reviews.llvm.org/D21962?vs=65404&id=66544#toc
Repository:
rL LLVM
https://reviews.llvm.org/D21962
Fi
Author: alexfh
Date: Tue Aug 2 15:29:47 2016
New Revision: 277517
URL: http://llvm.org/viewvc/llvm-project?rev=277517&view=rev
Log:
[docs] Fix links format.
Modified:
clang-tools-extra/trunk/docs/clang-rename.rst
clang-tools-extra/trunk/docs/include-fixer.rst
Modified: clang-tools-extra
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
// RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN:
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
> Restore assertions for presence of -march flag.
We don't need an explicit assertion in TranslateArgs?
Comment at: lib/Driver/Driver.cpp:1412
@@ +1411,3 @@
+ assert(HostTC
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM now, thank you for switching back! I was mostly worried about an
unrestricted template argument in this case, not the particular form of the
change. :-)
https://reviews.llvm.org/D23008
Author: ericwf
Date: Tue Aug 2 15:21:07 2016
New Revision: 277512
URL: http://llvm.org/viewvc/llvm-project?rev=277512&view=rev
Log:
Pass compilers when configuring Google Benchmark.
Modified:
libcxx/trunk/benchmarks/CMakeLists.txt
Modified: libcxx/trunk/benchmarks/CMakeLists.txt
URL:
http
jbcoe marked an inline comment as done.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,3 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+static std::string
+join(ArrayRef SMFS,
+
jbcoe updated this revision to Diff 66541.
jbcoe added a comment.
static `join` function is no longer a function template.
https://reviews.llvm.org/D23008
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
test/cl
alexfh added a comment.
Running tests, will submit shortly.
Comment at: docs/clang-tidy/checks/mpi-type-mismatch.rst:13
@@ +12,3 @@
+.. code:: c++
+ // In this case, the buffer type matches MPI datatype.
+ char buf;
This doesn't parse - an extra newline is nee
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &S
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &SMFS, llv
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
Depends on https://reviews.llvm.org/D23078 and https://reviews.llvm.org/D23079
We say ObjCTypeParamType is ObjCObjectPointerType, but we assert
fail when trying to call Type::getP
manmanren created this revision.
manmanren added a reviewer: doug.gregor.
manmanren added a subscriber: cfe-commits.
This depends on https://reviews.llvm.org/D23078
ObjC generics: Add ObjCTypeParamType in the type system.
We also need to add ObjCTypeParamTypeLoc. ObjCTypeParamType supports the
r
LokiAstari added a comment.
> That should already be doable with a negative offset today, right?
Yes. So I don't need to add any changes. right?
https://reviews.llvm.org/D22505
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
manmanren created this revision.
manmanren added reviewers: dexonsmith, doug.gregor.
manmanren added a subscriber: cfe-commits.
For ObjC type parameter, we used to have TypedefType that is canonicalized to
id or the bound type. We can't represent "T " and thus will lose
the type information in the
dcoughlin added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:6611
@@ +6610,3 @@
+ if (auto *E = dyn_cast(If->getCond())) {
+// If we're using the '*' case here, then we cannot emit any warnings for
+// the 'then' branch.
Do you still want to sup
klimek added a comment.
In https://reviews.llvm.org/D22505#503472, @LokiAstari wrote:
> I don't have a problem changing it so the default behaviour is:
>
> class C {
> int v1;
> private:
> int v2;
> };
>
>
> But I would like to retain the functionality that if there is no e
nhaustov accepted this revision.
nhaustov added a comment.
This revision is now accepted and ready to land.
LGTM, thanks.
Could you also note in commit message that online HTML docs are not very clear,
but pdf of OpenCL specification has it right.
Repository:
rL LLVM
https://reviews.llvm.or
Prazek added a subscriber: Prazek.
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23008
___
cfe-commits mailing list
cfe-commits
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &S
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:2809
@@ +2808,3 @@
+/// matches \c foo in \c foo(t);
+AST_MATCHER_P(OverloadExpr, canReferToDecl, internal::Matcher,
+ InnerMatcher) {
I find the name of this m
Author: cbieneman
Date: Tue Aug 2 13:23:56 2016
New Revision: 277492
URL: http://llvm.org/viewvc/llvm-project?rev=277492&view=rev
Log:
Revert "[Order Files] Remove dtrace predicate"
This reverts commit r277487.
Removing the probe predicate was a red herring. It results in more symbols
being pl
Author: omtcyfz
Date: Tue Aug 2 13:23:08 2016
New Revision: 277491
URL: http://llvm.org/viewvc/llvm-project?rev=277491&view=rev
Log:
[clang-rename] fix Emacs integration script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.el
Modified: clang-tools-extra/trunk/clang-rename
ashi1 created this revision.
ashi1 added reviewers: Anastasia, yaxunl, nhaustov.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
There should be no native_ builtin functions with double type arguments.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: niravd
Date: Tue Aug 2 12:58:14 2016
New Revision: 277490
URL: http://llvm.org/viewvc/llvm-project?rev=277490&view=rev
Log:
Update Clang Parser test error message to match new parser errors
Update clang tests in light of r277489.
Modified:
cfe/trunk/test/Parser/ms-inline-asm.c
Modi
Prazek marked 5 inline comments as done.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> Pr
Prazek added a comment.
In https://reviews.llvm.org/D22208#503194, @alexfh wrote:
> Please add revision number (this can be automated, if include differential
> revision URL in your commit message as described in
> http://llvm.org/docs/Phabricator.html#committing-a-change).
I normally use arc
Should we merge this to 3.9?
Thanks,
Hans
On Thu, Jul 28, 2016 at 5:55 PM, Erik Pilkington via cfe-commits
wrote:
> Author: epilk
> Date: Thu Jul 28 19:55:40 2016
> New Revision: 277095
>
> URL: http://llvm.org/viewvc/llvm-project?rev=277095&view=rev
> Log:
> [Parser] Fix bug where delayed typo
tra updated this revision to Diff 66505.
tra added a comment.
Herald added a subscriber: klimek.
Abort pipeline constructions early if we detect that NVPTX is used for host
compilation.
Restore assertions for presence of -march flag.
https://reviews.llvm.org/D23042
Files:
include/clang/Basic
Author: vitalybuka
Date: Tue Aug 2 12:51:48 2016
New Revision: 277488
URL: http://llvm.org/viewvc/llvm-project?rev=277488&view=rev
Log:
Updated documentation
Reviewers: kcc, eugenis
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D22992
Modified:
cfe/trunk/docs/A
Author: cbieneman
Date: Tue Aug 2 12:50:53 2016
New Revision: 277487
URL: http://llvm.org/viewvc/llvm-project?rev=277487&view=rev
Log:
[Order Files] Remove dtrace predicate
Having the dtrace predicate setup to only show probes in clang filters out
static initializers executed by dyld, which we
erik.pilkington updated this revision to Diff 66501.
erik.pilkington added a comment.
This new patch removes the warning `diag::warn_available_using_star_case`, as
per Devin's suggestion.
https://reviews.llvm.org/D23003
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticGroups.t
nandor added a comment.
ping
https://reviews.llvm.org/D22419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added inline comments.
Comment at: include-fixer/find-all-symbols/tool/CMakeLists.txt:22
@@ +21,2 @@
+ DESTINATION share/clang
+ COMPONENT find-all-symbols)
hokein wrote:
> I think we can put it in `clang-include-fixer` as find-all-symbols is a
>
bittnerbarni marked 14 inline comments as done.
bittnerbarni added a comment.
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bittnerbarni updated this revision to Diff 66492.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
LokiAstari added a comment.
I don't have a problem changing it so the default behaviour is:
class C {
int v1;
private:
int v2;
};
But I would like to retain the functionality that if there is no explicit
public/private/protected that it follows the original.
But if there is
Author: tstellar
Date: Tue Aug 2 11:29:52 2016
New Revision: 277481
URL: http://llvm.org/viewvc/llvm-project?rev=277481&view=rev
Log:
Creating release_38 off revision 260304
Added:
libclc/branches/release_38/
- copied from r260304, libclc/trunk/
___
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
cameron314 added a comment.
Anyone have time to check this out this week?
It's a one-line fix, includes a test, and is for a fairly important bug :-)
https://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
dcoughlin added a comment.
Other than a naming/documentation suggestion, looks good to me. Thanks Gábor!
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:424
@@ +423,3 @@
+if (!val.isZeroConstant()) {
+ val = getStoreManager().evalDynamicCast(val, T, Failed);
Author: dergachev
Date: Tue Aug 2 10:16:06 2016
New Revision: 277473
URL: http://llvm.org/viewvc/llvm-project?rev=277473&view=rev
Log:
[analyzer] Hotfix for buildbot failure due to unspecified triple in r277449
If a target triple is not specified, the default host triple is used,
which is not go
Author: omtcyfz
Date: Tue Aug 2 10:10:17 2016
New Revision: 277469
URL: http://llvm.org/viewvc/llvm-project?rev=277469&view=rev
Log:
[clang-rename] fix Emacs script build failure
Clang-rename Emacs integration script sometimes doesn't work correctly.
Modified:
clang-tools-extra/trunk/clang
1 - 100 of 157 matches
Mail list logo
