Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

Sanitizers are different IMO. Different santizers are rather independent, and there is no such thing as -fsantize to mean -fsantize=all For PGO, in most of the cases, users do not need to care about the sub-options implied -- by default they should just get the best profiling (whatever that is). F

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Sat, Jul 2, 2016 at 1:57 PM, Xinliang David Li wrote: > > > On Fri, Jul 1, 2016 at 4:32 PM, Sean Silva wrote: > >> silvas added inline comments. >> >> >> Comment at: lib/Driver/Tools.cpp:3560 >> @@ +3559,3 @@ >> +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_trai

r274454 - [Refactor NFC] Rename the (non-CCE, fold-failure) Diag during constant expression evaluation as FFDiag.

Author: faisalv Date: Sat Jul 2 17:34:24 2016 New Revision: 274454 URL: http://llvm.org/viewvc/llvm-project?rev=274454&view=rev Log: [Refactor NFC] Rename the (non-CCE, fold-failure) Diag during constant expression evaluation as FFDiag. Currently, we have CCEDiags (C++11 core constant expressio

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Fri, Jul 1, 2016 at 4:32 PM, Sean Silva wrote: > silvas added inline comments. > > > Comment at: lib/Driver/Tools.cpp:3560 > @@ +3559,3 @@ > +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) { > + if (StringRef(PGOTrainArg->getValue()) == "source-cfg"

r274447 - fix two typos in the doc

Author: sylvestre Date: Sat Jul 2 14:17:58 2016 New Revision: 274447 URL: http://llvm.org/viewvc/llvm-project?rev=274447&view=rev Log: fix two typos in the doc Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst cfe/trunk/docs/doxygen.cfg.in Modified: cfe/trunk/docs/SourceBasedCodeCove

Re: [PATCH] D20795: Added ASTStructure for analyzing the structure of Stmts.

v.g.vassilev requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Basic/SourceManager.h:1173 @@ +1172,3 @@ + + // + A leftover from something else? Comment at: include/clang/Basic/SourceMan

r274442 - [X86][AVX512] Converted the MOVDDUP/MOVSLDUP/MOVSHDUP masked intrinsics to generic IR

Author: rksimon Date: Sat Jul 2 12:16:25 2016 New Revision: 274442 URL: http://llvm.org/viewvc/llvm-project?rev=274442&view=rev Log: [X86][AVX512] Converted the MOVDDUP/MOVSLDUP/MOVSHDUP masked intrinsics to generic IR llvm companion patch imminent Modified: cfe/trunk/include/clang/Basic/B

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

Ilod added a comment. The PrintFunctionNames plugin works fine, but not the SampleAnalyzerPlugin? The checker-plugins test fails. Not sure, but I suppose it's because the regitration method for checkers is different (a C method called clang_registerCheckers is retrieved in the DLL from the main

r274433 - [CUDA] Move argument type lists to the stack. NFC.

Author: d0k Date: Sat Jul 2 07:03:57 2016 New Revision: 274433 URL: http://llvm.org/viewvc/llvm-project?rev=274433&view=rev Log: [CUDA] Move argument type lists to the stack. NFC. Modified: cfe/trunk/lib/CodeGen/CGCUDANV.cpp Modified: cfe/trunk/lib/CodeGen/CGCUDANV.cpp URL: http://llvm.org

r274432 - Use arrays or initializer lists to feed ArrayRefs instead of SmallVector where possible.

Author: d0k Date: Sat Jul 2 06:41:41 2016 New Revision: 274432 URL: http://llvm.org/viewvc/llvm-project?rev=274432&view=rev Log: Use arrays or initializer lists to feed ArrayRefs instead of SmallVector where possible. No functionality change intended Modified: cfe/trunk/include/clang/Sema/