EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
Please make the changes in the above comment.
http://reviews.llvm.org/D21706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
C++03 does not support default member initializers but libc++ provides both of
these classes an extensions in C++03.
C++03 also does not support defaulted special members.
I think th
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. I benchmarked the change against different key types and:
1. The change doesn't have a large detrimental impact when the key equality is
as expensive as hash equality. I benchmarked std:
Author: mgottesman
Date: Thu Jun 30 00:51:18 2016
New Revision: 274212
URL: http://llvm.org/viewvc/llvm-project?rev=274212&view=rev
Log:
[cmake] Remove stale comment. NFC.
Modified:
cfe/trunk/cmake/modules/ClangConfig.cmake.in
Modified: cfe/trunk/cmake/modules/ClangConfig.cmake.in
URL:
http
Author: ericwf
Date: Thu Jun 30 00:00:32 2016
New Revision: 274211
URL: http://llvm.org/viewvc/llvm-project?rev=274211&view=rev
Log:
Make futures.overview enum tests more portable. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/thread/futures/futures.overview/future_errc.pass.c
EricWF closed this revision.
EricWF added a comment.
r274211.
http://reviews.llvm.org/D21878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I committed a similar change in r274210. It changes the asserts to
LIBCPP_STATIC_ASSERT but it also adds additional tests that the iterators
provide the correct typedefs and tags.
http://rev
Author: ericwf
Date: Wed Jun 29 23:54:00 2016
New Revision: 274210
URL: http://llvm.org/viewvc/llvm-project?rev=274210&view=rev
Log:
Make std::array typedef tests more portable.
Modified:
libcxx/trunk/test/std/containers/sequences/array/types.pass.cpp
Modified: libcxx/trunk/test/std/containe
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
I fixed both the libc++ implementation and tests in r274209.
http://reviews.llvm.org/D21875
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: ericwf
Date: Wed Jun 29 23:40:50 2016
New Revision: 274209
URL: http://llvm.org/viewvc/llvm-project?rev=274209&view=rev
Log:
Fix ::reference typedef in insert iterators.
Since at least the C++11 standard insert iterators are specified
as having ::reference typedef void. Libc++ was not doi
ABataev added a comment.
No '\brief's
Comment at: include/clang/Driver/Action.h:204
@@ -159,1 +203,3 @@
+/// kind to its dependences.
+class OffloadAction : public Action {
virtual void anchor();
'final'
Comment at: include/clang/Driver/Acti
EricWF closed this revision.
EricWF added a comment.
r274207.
http://reviews.llvm.org/D21876
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 29 23:31:09 2016
New Revision: 274207
URL: http://llvm.org/viewvc/llvm-project?rev=274207&view=rev
Log:
Make instreambuf.iterator/types.pass.cpp more portable.
Modified:
libcxx/trunk/test/std/iterators/stream.iterators/istreambuf.iterator/types.pass.cpp
Modified
Author: ericwf
Date: Wed Jun 29 23:29:12 2016
New Revision: 274206
URL: http://llvm.org/viewvc/llvm-project?rev=274206&view=rev
Log:
Fix use of terse static assert. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_swappable_include_or
EricWF closed this revision.
EricWF added a comment.
r274206.
http://reviews.llvm.org/D21877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF closed this revision.
EricWF added a comment.
r274205.
http://reviews.llvm.org/D21872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 29 23:28:12 2016
New Revision: 274205
URL: http://llvm.org/viewvc/llvm-project?rev=274205&view=rev
Log:
Fix unary_function inheritance assumption. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/containers/sequences/vector.bool/vector_bool.pass.cpp
EricWF added a comment.
The fact that they are not noexcept in the working paper seems like an
oversight. Is there a reason your vector default constructor can't be
noexcept?
http://reviews.llvm.org/D21871
___
cfe-commits mailing list
cfe-commits@
What Warren said. We've been carrying the private patch for 4 years or so, and
now that we're getting the test changes upstream it will be progressively less
of a problem for us. (And thanks Sean for actually trying it on a couple of
titles! You read my mind.)
I also wanted to add that I agr
ABataev added a comment.
No '\brief's
Comment at: lib/Driver/Driver.cpp:1393
@@ +1392,3 @@
+/// generate the required device actions.
+class OffloadingActionBuilder {
+ /// \brief Flag used to trace errors in the builder.
1. 'final'
2. default initializers for
EricWF closed this revision.
EricWF added a comment.
r274204.
http://reviews.llvm.org/D21879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 29 23:22:58 2016
New Revision: 274204
URL: http://llvm.org/viewvc/llvm-project?rev=274204&view=rev
Log:
Fix unreferenced parameter warning. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.
EricWF closed this revision.
EricWF added a comment.
r274203.
http://reviews.llvm.org/D21870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed Jun 29 23:21:52 2016
New Revision: 274203
URL: http://llvm.org/viewvc/llvm-project?rev=274203&view=rev
Log:
Avoid applying unary minus to unsigned integers. Patch from s...@microsoft.com
Modified:
libcxx/trunk/test/std/depr/depr.c.headers/stdint_h.pass.cpp
libcxx/
ABataev added inline comments.
Comment at: lib/Driver/Driver.cpp:1778
@@ +1777,3 @@
+ /// phase.
+ class OpenMPActionBuilder : public DeviceActionBuilder {
+/// \brief The OpenMP actions for the current input.
'final'
http://reviews.llvm.org/D21845
ABataev added inline comments.
Comment at: lib/Driver/Tools.cpp:297
@@ +296,3 @@
+ StringRef Name = llvm::sys::path::filename(Output.getFilename());
+ StringRef Prefix = Name.rsplit('.').first;
+ if (C.getDriver().isSaveTempsEnabled()) {
Use llvm::sys::path::re
ABataev added a comment.
Remove empty 'return' and ';' statements where they are not required.
Comment at: test/Driver/clang-offload-bundler.c:14
@@ +13,3 @@
+//
+// RUN: touch %t.empty
+
Hmm, will it work on Windows? Maybe it is better just to add an empty test
ABataev added inline comments.
Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+ /// architecture, and device offload kind.
+ struct TCArgsKey {
+const ToolChain *TC;
1. 'final'
2. default initializers for fields.
Comment at:
craig.topper added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1568
@@ -1569,1 +1567,3 @@
+ case X86::BI__builtin_ia32_vpermilps_mask:
+ case X86::BI__builtin_ia32_vpermilps256_mask:
i = 1; l = 0; u = 255;
Can you put these adjacent to vpermilps5
ABataev added inline comments.
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:324-334
@@ -314,1 +323,13 @@
+// Handler for object files. The bundles are organized by sections with a
+// designated name.
+//
+// In order to bundle we create an IR file with the co
ABataev added inline comments.
Comment at: include/clang/Driver/Action.h:493
@@ -491,1 +492,3 @@
+class OffloadUnbundlingJobAction : public JobAction {
+ void anchor() override;
'final'?
Comment at: include/clang/Driver/Action.h:499
@@ +498,3
ABataev added a comment.
Remove '\brief'
Comment at: include/clang/Driver/Action.h:158-160
@@ -158,1 +157,5 @@
+ /// non-device kinds, except if \a CreatePrefixForHost is set.
+ static std::string
+ getOffloadingFileNamePrefix(OffloadKind Kind, StringRef NormalizedTriple,
+
majnemer added a subscriber: majnemer.
majnemer accepted this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21863
___
cfe-commits mailing list
ABataev added inline comments.
Comment at: include/clang/Driver/Action.h:158
@@ -157,1 +157,3 @@
std::string getOffloadingFileNamePrefix(StringRef NormalizedTriple) const;
+ /// \brief Return a string containing a offload kind name.
+ static std::string getOffloadKindName(Off
Author: majnemer
Date: Wed Jun 29 22:01:59 2016
New Revision: 274201
URL: http://llvm.org/viewvc/llvm-project?rev=274201&view=rev
Log:
[CodeView] Implement support for bitfields in Clang
Emit the underlying storage offset in addition to the starting bit
position of the field.
This fixes PR28162.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274201: [CodeView] Implement support for bitfields in Clang
(authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D21783?vs=62095&id=62333#toc
Repository:
rL LLVM
http://reviews.l
Author: majnemer
Date: Wed Jun 29 22:02:03 2016
New Revision: 274202
URL: http://llvm.org/viewvc/llvm-project?rev=274202&view=rev
Log:
[MS ABI] Pick an inheritance model if we resolve an overload set
We didn't assign an inheritance model for 'Foo' if the event an
exrepssion like '&Foo::Bar' occur
ABataev added a comment.
General comment: remove '\brief' tags, they are not required anymore, just
'\\\' is enough
Comment at: include/clang/Driver/Action.h:94
@@ -93,1 +93,3 @@
+ /// \brief Flag that is set to true if this action can be collapsed with
+ /// others actions
ABataev added inline comments.
Comment at: lib/Driver/Driver.cpp:464-468
@@ +463,7 @@
+ RuntimeName = A->getValue();
+HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName)
+ .Case("libomp", true)
+
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D21841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D21860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
On Wed, Jun 29, 2016 at 11:57 AM, Manman Ren wrote:
> Good point! In r274133.
Thank you!
~Aaron
>
> Manman
>
> On Wed, Jun 29, 2016 at 7:30 AM, Aaron Ballman
> wrote:
>>
>> On Tue, Jun 28, 2016 at 4:55 PM, Manman Ren via cfe-commits
>> wrote:
>> > Author: mren
>> > Date: Tue Jun 28 15:55:30 2
lihuang added a comment.
You are right. A regression test could be:
void foo2(int *dw, int *uw, int *A, int *B, int *C, int *D, int N) {
for (int i = 0; i < N; i++) {
dw[i] = A[i] + B[i - 1] + C[i - 2];
uw[i] = A[i] + B[i + 2];
}
}
need to fix the fundamental problem.
h
zmahler created this revision.
zmahler added a reviewer: hfinkel.
zmahler added a subscriber: cfe-commits.
Some of the macros should be defined without the extra "_T_".
Fix https://llvm.org/bugs/show_bug.cgi?id=27200
http://reviews.llvm.org/D21863
Files:
lib/Headers/stdatomic.h
Index: lib/Hea
Hi all,
>
> It may be feasible for us to use a "-std=gnu++latest" behavior and not have
> to have a PS4-specific default; CC'ing Warren and Paul.
As Sean pointed out, he did some tests and found we'd need to enable the GNU
keywords on PS4. Having a PS4-specific patch for this wouldn't be a probl
AntonBikineev updated this revision to Diff 62321.
AntonBikineev added a comment.
Test Parser/cxx1z-init-statement.cpp has been updated according to Sema changes
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt
AntonBikineev updated this revision to Diff 62320.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/CodeGen/CGStmt.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/TreeTransform.h
li
dberris added a comment.
Changed the description to provide a justification.
http://reviews.llvm.org/D21830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, Jun 29, 2016, 17:43 Joerg Sonnenberger wrote:
> On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits
> wrote:
> > We need to benchmark this to see if it still makes a difference.
> >
> > My canonical test is the .s of a lto of clang.
>
> That won't exercise it? Assem
Author: ahatanak
Date: Wed Jun 29 19:07:17 2016
New Revision: 274190
URL: http://llvm.org/viewvc/llvm-project?rev=274190&view=rev
Log:
Use the same type for adjacent bit field members.
MSVC doesn't pack the bit field members if different types are used.
This came up in a patch review.
http://lis
AntonBikineev updated this revision to Diff 62317.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/CodeGen/CGStmt.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/TreeTransform.h
li
AntonBikineev added a comment.
@rsmith,
> This is not correct; TryParseSimpleDeclaration usually stops long before it
> reaches the end of the simple-declaration, so this will give false negatives
> in lots of cases.
Yes, I noticed that, that's why I changed use of TryParseSimpleDeclaration t
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix MSVC "warning C4100: 'argv': unreferenced formal parameter".
http://reviews.llvm.org/D21879
Files:
test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Make futures.overview/future_errc.pass.cpp and launch.pass.cpp more portable.
future_errc.pass.cpp was assuming specific values, which aren't guaranteed by
the Standard, and M
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
is_swappable_include_order.pass.cpp was using a terse static_assert.
As before, this unnecessarily limits compatibility with MSVC and old versions
of GCC.
http://reviews.llvm
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Make istreambuf.iterator/types.pass.cpp more portable.
There are two issues here. First, istreambuf_iterator::pointer is unspecified
(and MSVC uses a different type). Second,
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
The Standard requires meow_insert_iterator::reference to be void.
This is a libcxx product and test bug, since the type is observable. Mark these
static_asserts as libcxx-spec
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
std::array's iterators aren't guaranteed to be pointers.
Include test_macros.h and mark these static_asserts as libcxx-specific.
http://reviews.llvm.org/D21874
Files:
test/
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Fix unary_function inheritance assumption.
C++11 didn't require std::hash to derive from std::unary_function. The portable
thing to do is to inspect the typedefs, as the other
pirama updated this revision to Diff 62305.
pirama added a comment.
Added GroupInfo to warning.
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Expr.cpp
lib/Sema/SemaExprMember.cp
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Make vector.bool/construct_default.pass.cpp more portable.
vector's default ctor and allocator ctor aren't depicted as noexcept in
the Working Paper. We're already directly in
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Avoid applying unary minus to unsigned integers.
This is confusing because first you have to remember what unsigned negation
does, then you have to worry about the usual arith
dimitry added a subscriber: dimitry.
Comment at: src/cxa_thread_atexit.cpp:46
@@ +45,3 @@
+ pthread_key_delete(key_);
+}
+
run_dtors() is called when/if libc++.so gets unloaded... but only for the
thread calling dlclose()?
http://reviews.llvm.org/D2180
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Remove the "Cuda" prefix from these variables -- it's clear that they
related to CUDA given their containing type.
http://reviews.llvm.org/D21868
Files:
lib/Driver/ToolChains.cpp
lib/Driver/To
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Raise an error if you're using a CUDA installation that's too old for
the requested architectures. In practice, this means that you need a
CUDA 8 install to compile for sm_6*.
http://reviews.llvm.
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Currently our handling of CUDA architectures is scattered all around
clang. This patch centralizes it.
A key advantage of this centralization is that you can now write a C++
switch on e.g. CudaArc
sivachandra added a comment.
Thanks for the review; Committed.
http://reviews.llvm.org/D21666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sivachandra
Date: Wed Jun 29 17:38:59 2016
New Revision: 274185
URL: http://llvm.org/viewvc/llvm-project?rev=274185&view=rev
Log:
[Tooling] Add optional argument to getFullyQualifiedName to prepend "::".
Reviewers: rsmith, saugustine, rnk
Subscribers: klimek, cfe-commits
Differential Re
On Wed, Jun 29, 2016 at 03:07:33PM -0700, Richard Smith wrote:
> On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> > On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote:
> > > Hi all!
> > >
> > > I'd like to establi
On Wed, Jun 29, 2016 at 2:48 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote:
> > Hi all!
> >
> > I'd like to establish a policy for Clang's default language standard (if
> > none is specified w
Author: mgottesman
Date: Wed Jun 29 16:59:14 2016
New Revision: 274176
URL: http://llvm.org/viewvc/llvm-project?rev=274176&view=rev
Log:
[cmake] Instead of just copying ClangConfig.cmake, configure it using
ClangConfig.cmake.in.
This will allow for cmake to expand variables in ClangConfig.cmake
- Original Message -
> From: "Hal Finkel via cfe-dev"
> To: "Richard Smith"
> Cc: "Clang Dev" , "cfe-commits"
>
> Sent: Wednesday, June 29, 2016 4:17:18 PM
> Subject: Re: [cfe-dev] RFC: Default language standard mode policy
> - Original Message -
> > From: "Richard Smith"
>
Author: mgottesman
Date: Wed Jun 29 16:59:19 2016
New Revision: 274178
URL: http://llvm.org/viewvc/llvm-project?rev=274178&view=rev
Log:
[ClangConfig] Instead of hard coding the ClangTargets location to
/ClangTargets.cmake, follow LLVM's example and use a pre-computed cmake
variable @CLANG_CONFI
Author: mgottesman
Date: Wed Jun 29 16:59:20 2016
New Revision: 274179
URL: http://llvm.org/viewvc/llvm-project?rev=274179&view=rev
Log:
[ClangConfig] Unset some variables after we are done using them to configure
ClangConfig.cmake.in files.
This ensures that the values do not bleed over in betw
Author: mgottesman
Date: Wed Jun 29 16:59:15 2016
New Revision: 274177
URL: http://llvm.org/viewvc/llvm-project?rev=274177&view=rev
Log:
[ClangConfig] Follow LLVM's example and only install Clang{Config,Target}.cmake
when LLVM_INSTALL_TOOLCHAIN_ONLY is disabled.
Modified:
cfe/trunk/cmake/mod
Author: mgottesman
Date: Wed Jun 29 16:59:23 2016
New Revision: 274180
URL: http://llvm.org/viewvc/llvm-project?rev=274180&view=rev
Log:
[ClangConfig] Store all of the targets exported in the variable
CLANG_EXPORTED_TARGETS.
Modified:
cfe/trunk/cmake/modules/CMakeLists.txt
cfe/trunk/cmak
On Wed, Jun 29, 2016 at 12:09:37PM -0700, Richard Smith via cfe-dev wrote:
> Hi all!
>
> I'd like to establish a policy for Clang's default language standard (if
> none is specified with -std), as follows:
>
> Clang defaults to the most recent published standard for the selected
> language that
On Wed, Jun 29, 2016 at 11:00:26AM -0400, Rafael Espíndola via cfe-commits
wrote:
> We need to benchmark this to see if it still makes a difference.
>
> My canonical test is the .s of a lto of clang.
That won't exercise it? Assembler sources are exempt from this.
Joerg
_
joerg added a subscriber: joerg.
joerg added a comment.
On the topic of __cxa_thread_atexit, was it ever specified how it interacts
with things like thread cancellation?
http://reviews.llvm.org/D21803
___
cfe-commits mailing list
cfe-commits@lists.
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
The proposal has changed since the pre-meeting mailing, and now covers `switch`
as well as `if`. You also need to handle the //expression-statement// form of
//init-statement//.
As
Author: rsmith
Date: Wed Jun 29 16:17:59 2016
New Revision: 274169
URL: http://llvm.org/viewvc/llvm-project?rev=274169&view=rev
Log:
P0305R1: Parsing support for init-statements in 'if' and 'switch' statements.
No semantic analysis yet.
This is a pain to disambiguate correctly, because the parsin
Author: rsmith
Date: Wed Jun 29 16:12:37 2016
New Revision: 274167
URL: http://llvm.org/viewvc/llvm-project?rev=274167&view=rev
Log:
Convert another case over to RevertingTentativeParsingAction.
Modified:
cfe/trunk/lib/Parse/ParseTentative.cpp
Modified: cfe/trunk/lib/Parse/ParseTentative.cpp
Author: mgottesman
Date: Wed Jun 29 16:12:38 2016
New Revision: 274168
URL: http://llvm.org/viewvc/llvm-project?rev=274168&view=rev
Log:
[ClangConfig] Copy ClangConfig.cmake to
${CMAKE_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR} instead of to
${CLANG_BINARY_DIR}/${CLANG_INSTALL_PACKAGE_DIR}.
This
- Original Message -
> From: "Richard Smith"
> To: "Hal Finkel"
> Cc: "Clang Dev" , "cfe-commits"
>
> Sent: Wednesday, June 29, 2016 3:01:46 PM
> Subject: Re: [cfe-dev] RFC: Default language standard mode policy
> On Wed, Jun 29, 2016 at 12:55 PM, Hal Finkel via cfe-dev <
> cfe-...@lis
Author: rsmith
Date: Wed Jun 29 16:06:51 2016
New Revision: 274165
URL: http://llvm.org/viewvc/llvm-project?rev=274165&view=rev
Log:
Switch to an RAII object to revert tentative parsing automatically.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseTentative.cpp
amccarth updated this revision to Diff 62283.
amccarth added a comment.
Applied suggestion from the comments, which eliminates the need to alter the
ObjectiveC test.
http://reviews.llvm.org/D21705
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenCXX/debug-info-dup
amccarth marked 2 inline comments as done.
amccarth added a comment.
http://reviews.llvm.org/D21705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xur added a comment.
Thanks for doing this. I like the patch in general. Hers are my minor
feedbacks:
(1) It seems the original options of -fprofile-instr-generate and
-fprofile-instr-use will be kept. Is so, what is the guideline to use these two
sets of options. Also, we need some documentat
jakev updated this revision to Diff 62282.
jakev marked 5 inline comments as done.
jakev added a comment.
Address comments.
Repository:
rL LLVM
http://reviews.llvm.org/D21823
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/clang_f_opts
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thank you so much for your patience and hard work on this change!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@l
On Wed, Jun 29, 2016 at 1:34 PM, Sean Silva wrote:
>
>
> On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
> wrote:
>
>> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
>> wrote:
>>
>>>
>>>
>>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>
On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
wrote:
> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
> wrote:
>
>>
>>
>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hi all!
>>>
>>> I'd like to establish a policy for Clang's defa
Author: mgottesman
Date: Wed Jun 29 15:22:46 2016
New Revision: 274158
URL: http://llvm.org/viewvc/llvm-project?rev=274158&view=rev
Log:
[ClangConfig] Replace paths with the same value as CLANG_INSTALL_PACKAGE_DIR
with a deref of the variable.
Modified:
cfe/trunk/cmake/modules/CMakeLists.txt
Author: mgottesman
Date: Wed Jun 29 15:22:44 2016
New Revision: 274157
URL: http://llvm.org/viewvc/llvm-project?rev=274157&view=rev
Log:
[cmake] Move creation of ClangTargets and installation of ClangConfig.cmake
from ./CMakeLists.txt -> ./cmake/modules/CMakeLists.txt.
This matches LLVM.
Added:
hokein updated this revision to Diff 62278.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D21833
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/clang-tidy/misc-unused-using-decls.cpp
Index: test/clang-tidy/misc-unused-using-decls.cpp
==
hokein marked an inline comment as done.
Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:22
@@ +21,3 @@
+namespace {
+// FIXME: Move this node matcher to ASTMatcher.
+const internal::VariadicDynCastAllOfMatcher enumType;
Done in D21860.
http://reviews.llvm
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D21860
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.c
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907
@@ -7904,1 +7906,3 @@
+def ext_opencl_ext_vector_type_rgba_selector: ExtWarn<
+ "vector component name '%0' is an OpenCL version 2.2 feature">;
} // end of sema category
As
bcraig added a comment.
> Hmm, maybe? If other global destructors run after ~DtorListHolder(), and
> they cause a thread_local to be initialized for the first time,
> __cxa_thread_atexit() might be called again. I was thinking that dtors would
> get re-initialized in that case but it appears
On Wed, Jun 29, 2016 at 12:55 PM, Hal Finkel via cfe-dev <
cfe-...@lists.llvm.org> wrote:
>
> --
>
> *From: *"Richard Smith via cfe-commits"
> *To: *"cfe-commits" , "Clang Dev" <
> cfe-...@lists.llvm.org>
> *Sent: *Wednesday, June 29, 2016 2:09:37 PM
> *Subject: *RFC:
1 - 100 of 169 matches
Mail list logo
