Re: r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

+Richard, Hans This patch fixes a crash that's also present in Clang 3.8. So, I think it should find its way into 3.8.2, if possible. Thank you! :) -- Forwarded message -- From: George Burgess IV via cfe-commits Date: Mon, Jun 27, 2016 at 12:40 PM Subject: r273911 - [ExprConstan

Re: r273950 -

Reverted it in r273994. I expect you may recommit it. ;) On Tue, Jun 28, 2016 at 9:12 AM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Did you land this intentionally? What was the commit message supposed to > be? > > On Mon, Jun 27, 2016 at 6:11 PM, Chris Dewhurst via cfe-com

r273994 - Revert r273950, (empty). Please recommit it with readable commit message.

Author: chapuni Date: Tue Jun 28 01:10:54 2016 New Revision: 273994 URL: http://llvm.org/viewvc/llvm-project?rev=273994&view=rev Log: Revert r273950, (empty). Please recommit it with readable commit message. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp

[clang-tools-extra] r273993 - clang-rename: Update libdeps corresponding to r273910.

Author: chapuni Date: Tue Jun 28 01:08:10 2016 New Revision: 273993 URL: http://llvm.org/viewvc/llvm-project?rev=273993&view=rev Log: clang-rename: Update libdeps corresponding to r273910. Modified: clang-tools-extra/trunk/clang-rename/tool/CMakeLists.txt Modified: clang-tools-extra/trunk/cl

Re: [PATCH] D20352: Add XRay flags to Clang

dberris added inline comments. Comment at: include/clang/Basic/Attr.td:436 @@ +435,3 @@ + CXX11<"clang", "xray_never_instrument">]; + let Subjects = SubjectList<[CXXMethod, ObjCMethod, Function], WarnDiag, + "ExpectedFunctionOrMethod

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 62056. dberris marked 2 inline comments as done. dberris added a comment. - Undo formatting changes - Re-apply changes post-review - Address more comments http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

r273987 - [clang-cl] Define _MSVC_LANG

Author: majnemer Date: Mon Jun 27 22:13:16 2016 New Revision: 273987 URL: http://llvm.org/viewvc/llvm-project?rev=273987&view=rev Log: [clang-cl] Define _MSVC_LANG Recently, Microsoft added support for a flag, /std, which controls which version of the language rules MSVC should use. MSVC hasn't u

r273986 - [intrin.h] Certain _Interlocked intrinsics return the old value

Author: majnemer Date: Mon Jun 27 21:54:43 2016 New Revision: 273986 URL: http://llvm.org/viewvc/llvm-project?rev=273986&view=rev Log: [intrin.h] Certain _Interlocked intrinsics return the old value This fixes PR28326. Modified: cfe/trunk/lib/Headers/intrin.h Modified: cfe/trunk/lib/Headers

[PATCH] D21783: [CodeView] Implement support for bitfields in Clang

majnemer created this revision. majnemer added reviewers: rnk, aaboud. majnemer added a subscriber: cfe-commits. Emit the underlying storage offset in addition to the starting bit position of the field. http://reviews.llvm.org/D21783 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo

Re: [PATCH] D21659: AMDGPU: Add builtin to read exec mask

arsenm closed this revision. arsenm added a comment. r273965 http://reviews.llvm.org/D21659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273976 - Avoid accessing an invalid PresumedLoc.

Author: jrose Date: Mon Jun 27 20:02:31 2016 New Revision: 273976 URL: http://llvm.org/viewvc/llvm-project?rev=273976&view=rev Log: Avoid accessing an invalid PresumedLoc. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the presumed lo

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose closed this revision. jordan_rose added a comment. Committed as r273976. Repository: rL LLVM http://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

zaks.anna added a comment. I missed that! Sorry about that. http://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21778: [CUDA] Add support for CUDA 8 and sm_60-62.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Also add sm_32, which was missing. http://reviews.llvm.org/D21778 Files: lib/Basic/Targets.cpp lib/Driver/Action.cpp lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp =

r273972 - Frontend: clang-format a statement, NFC

Author: compnerd Date: Mon Jun 27 19:19:32 2016 New Revision: 273972 URL: http://llvm.org/viewvc/llvm-project?rev=273972&view=rev Log: Frontend: clang-format a statement, NFC Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

r273965 - AMDGPU: Add builtin to read exec mask

Author: arsenm Date: Mon Jun 27 19:13:17 2016 New Revision: 273965 URL: http://llvm.org/viewvc/llvm-project?rev=273965&view=rev Log: AMDGPU: Add builtin to read exec mask Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.def cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/Code

Re: r273950 -

Any tests? On Mon, Jun 27, 2016 at 5:12 PM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Did you land this intentionally? What was the commit message supposed to > be? > > On Mon, Jun 27, 2016 at 6:11 PM, Chris Dewhurst via cfe-commits < > cfe-commits@lists.llvm.org> wrote: >

Re: r273950 -

Did you land this intentionally? What was the commit message supposed to be? On Mon, Jun 27, 2016 at 6:11 PM, Chris Dewhurst via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lerochris > Date: Mon Jun 27 17:11:12 2016 > New Revision: 273950 > > URL: http://llvm.org/viewvc/llvm-projec

[PATCH] D21773: [clang] Update an optimization remark test for change D18777

lihuang created this revision. lihuang added reviewers: sanjoy, reames. lihuang added a subscriber: cfe-commits. Update an optimization remark test for change D18777. This test checks the loop-vectorization remarks when pointer checking threshold is exceeded. The change in D18777 would introduce

r273950 -

Author: lerochris Date: Mon Jun 27 17:11:12 2016 New Revision: 273950 URL: http://llvm.org/viewvc/llvm-project?rev=273950&view=rev Log: (empty) Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Ta

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

beanz requested changes to this revision. beanz added a comment. This revision now requires changes to proceed. It looks like @samsonov had quite a few valid review comments that are still unresolved. I know he hasn't been active lately, but I think those points deserve discussion. -Chris htt

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

zaks.anna added a comment. LGTM. Any other comments to this? http://reviews.llvm.org/D15225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273948 - Attempting to fix lit test test/Headers/opencl-c-header.cl on cygwin.

Author: yaxunl Date: Mon Jun 27 16:43:00 2016 New Revision: 273948 URL: http://llvm.org/viewvc/llvm-project?rev=273948&view=rev Log: Attempting to fix lit test test/Headers/opencl-c-header.cl on cygwin. "chmod u-x *" does not work for lit on cygwin. Modified: cfe/trunk/test/Headers/opencl-c-

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Please see PR28334. I'm not sure if Krystyna has Bugzilla account, so I report problem here. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[clang-tools-extra] r273941 - clang-rename: try to make ClassTestReplacements more reliable

Author: vmiklos Date: Mon Jun 27 16:04:53 2016 New Revision: 273941 URL: http://llvm.org/viewvc/llvm-project?rev=273941&view=rev Log: clang-rename: try to make ClassTestReplacements more reliable As it failed on e.g.

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

teemperor updated this revision to Diff 62015. teemperor added a comment. - Stmt traversal is now always postorder, even if child statements don't support iterative traversal (thanks Richard). http://reviews.llvm.org/D20382 Files: include/clang/AST/RecursiveASTVisitor.h unittests/AST/CMake

[PATCH] D21767: Fix instantiation of friend function templates

sepavloff created this revision. sepavloff added a reviewer: rsmith. sepavloff added a subscriber: cfe-commits. If a function template was defined in a friend declaration in a template class, it was not instantiated because template definition was not found. http://reviews.llvm.org/D21767 Files:

Re: [PATCH] D21453: Add support for attribute "overallocated"

rsmith requested changes to this revision. Comment at: include/clang/Basic/AttrDocs.td:2073-2079 @@ +2072,9 @@ + let Content = [{ +Use ``overallocated`` to indicate a class or union can have extra memory +allocated at its end. This attribute is primarily used when we want +__buil

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

ahatanak added a comment. Sorry for not replying for a long time. I'll get back to this soon. http://reviews.llvm.org/D14471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

benlangmuir added a subscriber: benlangmuir. benlangmuir added a comment. LGTM Repository: rL LLVM http://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273913 - Add simple, stupid, pattern-based fuzzer / reducer for modules bugs. I've

Author: rsmith Date: Mon Jun 27 14:43:46 2016 New Revision: 273913 URL: http://llvm.org/viewvc/llvm-project?rev=273913&view=rev Log: Add simple, stupid, pattern-based fuzzer / reducer for modules bugs. I've already used this to find and reduce quite a few bugs, and it works pretty well if you can

r273911 - [ExprConstant] Fix PR28314 - crash while evluating objectsize.

Author: gbiv Date: Mon Jun 27 14:40:41 2016 New Revision: 273911 URL: http://llvm.org/viewvc/llvm-project?rev=273911&view=rev Log: [ExprConstant] Fix PR28314 - crash while evluating objectsize. This fixes a crash in code like: ``` struct A { struct B b; char c[1]; } int foo(struct A* a) { re

Re: [PATCH] D21676: clang-rename: add a -export-fixes option

This revision was automatically updated to reflect the committed changes. Closed by commit rL273910: clang-rename: add a -export-fixes option (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21676?vs=61833&id=62004#toc Repository: rL LLVM http://reviews.llvm.org/D216

[clang-tools-extra] r273910 - clang-rename: add a -export-fixes option

Author: vmiklos Date: Mon Jun 27 14:34:47 2016 New Revision: 273910 URL: http://llvm.org/viewvc/llvm-project?rev=273910&view=rev Log: clang-rename: add a -export-fixes option Use case: a class is declared in a header, and defined in two translation units. clang-rename is asked to rename a class m

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

kkwli0 closed this revision. kkwli0 added a comment. At revision: 273908 http://reviews.llvm.org/D21617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273908 - [OpenMP] Diagnose missing cases of statements between target and teams directives

Author: kli Date: Mon Jun 27 14:15:43 2016 New Revision: 273908 URL: http://llvm.org/viewvc/llvm-project?rev=273908&view=rev Log: [OpenMP] Diagnose missing cases of statements between target and teams directives Clang fails to diagnose cases such as #pragma omp target while(0) { #pragma om

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

rsmith added inline comments. Comment at: include/clang/AST/RecursiveASTVisitor.h:630-635 @@ -593,1 +629,8 @@ + if (getDerived().shouldTraversePostOrder()) { +for (auto Iter = ReverseLocalQueue.rbegin(); + Iter != ReverseLocalQueue.rend(); ++Iter) { + TRY_TO(Po

Re: [PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62003. STL_MSFT added a comment. Population, 9 billion. All test macros. http://reviews.llvm.org/D21718 Files: test/std/containers/associative/map/map.cons/move_assign_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/move_assig

Re: [PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62002. STL_MSFT added a comment. Test macros for the test macro throne! http://reviews.llvm.org/D21716 Files: test/std/containers/associative/map/map.cons/move_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/move_noexcept.pass.

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

STL_MSFT updated this revision to Diff 62001. STL_MSFT added a comment. Adding test_macros.h as requested. http://reviews.llvm.org/D21717 Files: test/std/containers/associative/map/map.cons/dtor_noexcept.pass.cpp test/std/containers/associative/multimap/multimap.cons/dtor_noexcept.pass.cpp

Re: [PATCH] D21766: [codeview][clang] Added support for unnamed bitfield type.

majnemer added a comment. As I said in the other differential, I do not think this is the right approach. We should use the extraData for the bitfield member to indicate the offset of the storage unit. http://reviews.llvm.org/D21766 ___ cfe-commits

[PATCH] D21766: [codeview][clang] Added support for unnamed bitfield type.

aaboud created this revision. aaboud added reviewers: rnk, majnemer. aaboud added subscribers: cfe-commits, bwyma. Allow creating DI metadata for non-zero width unnamed bitfield members when emitting CodeView. This is needed for patch D21489. http://reviews.llvm.org/D21766 Files: lib/CodeGen/

Re: [PATCH] D5896: Emit more intrinsics for builtin functions

arsenm added a comment. ping http://reviews.llvm.org/D5896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

wolfgangp updated this revision to Diff 61987. wolfgangp added a comment. Herald added a subscriber: mehdi_amini. Updating this patch against a recent revision. http://reviews.llvm.org/D11360 Files: lib/CodeGen/CGStmt.cpp test/CodeGen/forwarding-blocks-if.c Index: test/CodeGen/forwarding-b

Re: [PATCH] D21508: Make friend function template definition available if class is instantiated.

sepavloff updated this revision to Diff 61989. sepavloff added a comment. Make more correct template function definition lookup Lookup is made recursive to cover more cases. http://reviews.llvm.org/D21508 Files: include/clang/AST/DeclTemplate.h lib/AST/DeclTemplate.cpp lib/Sema/SemaDecl.

Re: [PATCH] D21392: [clang-tidy] Enhance redundant-expression check

etienneb updated this revision to Diff 61984. etienneb marked 12 inline comments as done. etienneb added a comment. address comments http://reviews.llvm.org/D21392 Files: clang-tidy/misc/RedundantExpressionCheck.cpp clang-tidy/misc/RedundantExpressionCheck.h test/clang-tidy/misc-redundant

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

nhaustov added a comment. In http://reviews.llvm.org/D21367#467894, @yaxunl wrote: > I am wondering what's the difference between this calling convention and > spir_kernel. spir_kernel has only effect and was created only for SPIR target. In theory it could perhaps be reused for AMDGPU target

Re: [PATCH] D21453: Add support for attribute "overallocated"

On Mon, Jun 27, 2016 at 2:07 PM, Duncan P. N. Exon Smith wrote: > >> On 2016-Jun-27, at 11:02, Aaron Ballman wrote: >> >> aaron.ballman requested changes to this revision. >> aaron.ballman added a comment. >> This revision now requires changes to proceed. >> >> Missing Sema tests for the attribut

Re: [PATCH] D21453: Add support for attribute "overallocated"

> On 2016-Jun-27, at 11:02, Aaron Ballman wrote: > > aaron.ballman requested changes to this revision. > aaron.ballman added a comment. > This revision now requires changes to proceed. > > Missing Sema tests for the attribute. > > > > Comment at: include/clang/Basic/AttrDocs.

Re: [PATCH] D21453: Add support for attribute "overallocated"

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Missing Sema tests for the attribute. Comment at: include/clang/Basic/AttrDocs.td:2082 @@ +2081,3 @@ + +struct S { + char a[4], char b[4]; ---

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

yaxunl added a comment. In http://reviews.llvm.org/D21367#467982, @nhaustov wrote: > In http://reviews.llvm.org/D21367#467894, @yaxunl wrote: > > > I am wondering what's the difference between this calling convention and > > spir_kernel. > > > spir_kernel has only effect and was created only for

Re: [PATCH] D21545: CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.

tejohnson added a comment. Sorry for the delay, comments below. Comment at: lib/CodeGen/BackendUtil.cpp:733 @@ +732,3 @@ + StringMap ExportLists; + ComputeCrossModuleImport(*CombinedIndex, ModuleToDefinedGVSummaries, + ImportLists, ExportLists); -

Re: [PATCH] D21741: Add test for D21736 and D21737.

koriakin added a comment. In http://reviews.llvm.org/D21741#467969, @vsk wrote: > Is the plan to commit this along with http://reviews.llvm.org/D21737? Yes, and with http://reviews.llvm.org/D21736+http://reviews.llvm.org/D21739. Repository: rL LLVM http://reviews.llvm.org/D21741 ___

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

nhaustov added a comment. In http://reviews.llvm.org/D21367#467894, @yaxunl wrote: > I am wondering what's the difference between this calling convention and > spir_kernel. spir_kernel has only effect and was created only for SPIR target. In theory it could perhaps be reused for AMDGPU target

Re: [PATCH] D21741: Add test for D21736 and D21737.

vsk added a comment. Is the plan to commit this along with http://reviews.llvm.org/D21737? Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exce

[PATCH] D21753: Comprehensive Static Instrumentation (2/2): Clang flag

tdenniston created this revision. tdenniston added reviewers: kcc, zhaoqin, bruening, mehdi_amini. tdenniston added subscribers: cfe-commits, eugenis, pcc, vitalybuka, aizatsky, neboat. tdenniston set the repository for this revision to rL LLVM. tdenniston added a project: Comprehensive Static Ins

Re: [PATCH] D21446: Comprehensive static instrumentation (2/3): Clang support

tdenniston abandoned this revision. tdenniston added a comment. Abandoning. We are resubmitting the CSI patches in smaller increments. Repository: rL LLVM http://reviews.llvm.org/D21446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D21741: Add test for D21736 and D21737.

koriakin added inline comments. Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple %itanium_abi_triple | FileCheck %s +// RUN: %

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

erik.pilkington added a comment. Ping! http://reviews.llvm.org/D21030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. If there's no more executable size bloat this seems fine to me. http://reviews.llvm.org/D20382 ___ cfe-commits mailing list cfe-commits@lists.l

Re: [PATCH] D21741: Add test for D21736 and D21737.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, with one nit. Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profil

Re: [PATCH] D20382: Add postorder support to RecursiveASTVisitor

v.g.vassilev added a comment. @bkramer are those modifications enough to accept this patch? It is holding back quite a lot of ongoing development from @teemperor as part of his GSoC project. http://reviews.llvm.org/D20382 ___ cfe-commits mailing l

Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

carlo.bertolli added a comment. Resubmitted at revision 273884 after fixes. Repository: rL LLVM http://reviews.llvm.org/D21564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21747: [clang-tidy] Warning enum unused using declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273882: [clang-tidy] Warning enum unused using declarations. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21747?vs=61955&id=61966#toc Repository: rL LLVM http://reviews.ll

[clang-tools-extra] r273882 - [clang-tidy] Warning enum unused using declarations.

Author: hokein Date: Mon Jun 27 09:47:39 2016 New Revision: 273882 URL: http://llvm.org/viewvc/llvm-project?rev=273882&view=rev Log: [clang-tidy] Warning enum unused using declarations. Reviewers: alexfh, aaron.ballman Subscribers: aaron.ballman, cfe-commits Differential Revision: http://review

Re: [PATCH] D21367: AMDGPU: Set amdgpu_kernel calling convention for OpenCL kernels.

yaxunl added a comment. I am wondering what's the difference between this calling convention and spir_kernel. http://reviews.llvm.org/D21367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D21747: [clang-tidy] Warning enum unused using declarations.

alexfh accepted this revision. alexfh added a comment. LG http://reviews.llvm.org/D21747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20352: Add XRay flags to Clang

aaron.ballman added a comment. It looks like you ran clang-format over the entire file in some instances, causing a lot of unrelated changes to creep in. Can you back those changes out and only run clang-format over just your patch instead (http://clang.llvm.org/docs/ClangFormat.html#script-for

Re: [PATCH] D21747: [clang-tidy] Warning enum unused using declarations.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D21747 __

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

rengolin added a comment. If this patch was abandoned, please "Abandon" it. If not, please implement it using the AArch64 TargetParser. http://reviews.llvm.org/D14471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

dnovillo accepted this revision. dnovillo added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D21747: [clang-tidy] Warning enum unused using declarations.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D21747 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls.cpp Index: test/clang-tidy/misc-unused-using-decls.cpp ==

[libcxx] r273861 - Fix bad link for P0006

Author: marshall Date: Mon Jun 27 06:14:34 2016 New Revision: 273861 URL: http://llvm.org/viewvc/llvm-project?rev=273861&view=rev Log: Fix bad link for P0006 Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/llvm-project/li

[PATCH] D21746: [AVX512] Zero extend cmp intrinsic return value.

igorb created this revision. igorb added reviewers: delena, craig.topper. igorb added a subscriber: cfe-commits. igorb set the repository for this revision to rL LLVM. [AVX512] Zero extend cmp intrinsic return value. Repository: rL LLVM http://reviews.llvm.org/D21746 Files: lib/CodeGen/CGBu

Re: [PATCH] D21676: clang-rename: add a -export-fixes option

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D21676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D21228: Deprecated (legacy) string literal conversion to 'char *' causes strange overloading resolution

a.makarov added a reviewer: rnk. a.makarov added a comment. Reid, please, take a look. http://reviews.llvm.org/D21228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20249: [OpenCL] Hierarchical/dynamic parallelism - enqueue kernel in OpenCL 2.0

bader accepted this revision. bader added a comment. LGTM. A few style nitpicks. Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181 @@ +2179,4 @@ +} +// Could have events and/or vaargs. +if (NumArgs >= 5) { + if (E->getArg(3)->getType()->isBlockPointerType()) { ---

Re: [PATCH] D21470: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL273849: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D21470?vs=61092&id=61938#toc Repository: rL LLV

[clang-tools-extra] r273849 - [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs.

Author: hokein Date: Mon Jun 27 03:04:01 2016 New Revision: 273849 URL: http://llvm.org/viewvc/llvm-project?rev=273849&view=rev Log: [clang-tidy] Don't run misc-definitions-in-headers check in failing TUs. Reviewers: alexfh Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org

[PATCH] D21744: [OpenCL] Fix code generation of kernel pipe parameters.

bader created this revision. bader added reviewers: Anastasia, pxli168. bader added subscribers: cfe-commits, yaxunl. Improved test with user define structure pipe type case. http://reviews.llvm.org/D21744 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/pipe_types.cl Index: test/C