Re: [PATCH] D20352: Add XRay flags to Clang

dberris marked an inline comment as done. Comment at: include/clang/Basic/Attr.td:432 @@ +431,3 @@ + CXX11<"clang", "xray_always_instrument">]; + let Subjects = SubjectList<[CXXMethod, Function], WarnDiag, + "ExpectedFunctionOrMethod

Re: [PATCH] D20352: Add XRay flags to Clang

dberris updated this revision to Diff 61932. dberris marked 2 inline comments as done. dberris added a comment. - Address review comments; see details. http://reviews.llvm.org/D20352 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Driver/Options.td inclu

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

ABataev added a comment. LG http://reviews.llvm.org/D21617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r273841 - [clang-cl] Implement support for /std

Author: majnemer Date: Sun Jun 26 21:32:12 2016 New Revision: 273841 URL: http://llvm.org/viewvc/llvm-project?rev=273841&view=rev Log: [clang-cl] Implement support for /std /std: supports two arguments, c++14 and c++latest. Currently, c++latest maps to c++1z but this might change down the road.

[PATCH] D21741: Add test for D21736 and D21737.

koriakin created this revision. koriakin added reviewers: vsk, betulb. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. Repository: rL LLVM http://reviews.llvm.org/D21741 Files: test/Profile/c-indirect-call.c test/Profile/cxx-indirect-call

[libcxx] r273840 - Fix UB in uses_alloc_types.hpp

Author: ericwf Date: Sun Jun 26 20:52:14 2016 New Revision: 273840 URL: http://llvm.org/viewvc/llvm-project?rev=273840&view=rev Log: Fix UB in uses_alloc_types.hpp Modified: libcxx/trunk/test/support/uses_alloc_types.hpp Modified: libcxx/trunk/test/support/uses_alloc_types.hpp URL: http://l

[PATCH 1/1] tools/clang-format: fix git-clang-format shebang

git-clang-format requires python2.7, but the current shebang uses whatever is the system default, making it fail on python3 systems. This was originally reported here: https://bugs.gentoo.org/show_bug.cgi?id=562688 -- -Austin GPG: 14FB D7EA A041 937B From 67b271552f228bb6f92518ff13c6f89639d0a920

[libcxx] r273839 - Implement P0163r0. Add shared_ptr::weak_type.

Author: ericwf Date: Sun Jun 26 20:02:43 2016 New Revision: 273839 URL: http://llvm.org/viewvc/llvm-project?rev=273839&view=rev Log: Implement P0163r0. Add shared_ptr::weak_type. This patch adds the weak_type typedef in shared_ptr. It is available in C++17 and newer. This patch also updates the

[libcxx] r273838 - Implement p0337r0. Delete operator= for polymorphic_allocator.

Author: ericwf Date: Sun Jun 26 19:55:25 2016 New Revision: 273838 URL: http://llvm.org/viewvc/llvm-project?rev=273838&view=rev Log: Implement p0337r0. Delete operator= for polymorphic_allocator. Modified: libcxx/trunk/include/experimental/memory_resource libcxx/trunk/test/std/experiment

[libcxx] r273837 - Implement P0358r1. Fixes for not_fn.

Author: ericwf Date: Sun Jun 26 19:40:41 2016 New Revision: 273837 URL: http://llvm.org/viewvc/llvm-project?rev=273837&view=rev Log: Implement P0358r1. Fixes for not_fn. Modified: libcxx/trunk/include/functional libcxx/trunk/test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp

[libcxx] r273836 - Fix C++03 failure in enable_shared_from_this test

Author: ericwf Date: Sun Jun 26 19:38:28 2016 New Revision: 273836 URL: http://llvm.org/viewvc/llvm-project?rev=273836&view=rev Log: Fix C++03 failure in enable_shared_from_this test Modified: libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pas

[libcxx] r273835 - Fix PR27115 - enable_shared_from_this does not work as a virtual base class.

Author: ericwf Date: Sun Jun 26 18:56:32 2016 New Revision: 273835 URL: http://llvm.org/viewvc/llvm-project?rev=273835&view=rev Log: Fix PR27115 - enable_shared_from_this does not work as a virtual base class. See https://llvm.org/bugs/show_bug.cgi?id=27115 The problem was that the conversion fr

[clang-tools-extra] r273834 - clang-tools-extra/test/clang-tidy/modernize-use-using.cpp: Satisfy thiscall.

Author: chapuni Date: Sun Jun 26 18:56:07 2016 New Revision: 273834 URL: http://llvm.org/viewvc/llvm-project?rev=273834&view=rev Log: clang-tools-extra/test/clang-tidy/modernize-use-using.cpp: Satisfy thiscall. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using.cpp Modifie

[libcxx] r273832 - Fix C++03 build

Author: ericwf Date: Sun Jun 26 18:18:23 2016 New Revision: 273832 URL: http://llvm.org/viewvc/llvm-project?rev=273832&view=rev Log: Fix C++03 build Modified: libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp libcxx/trunk/

[libcxx] r273831 - Fix PR28079 - std::wstring_convert move constructor broken.

Author: ericwf Date: Sun Jun 26 17:56:26 2016 New Revision: 273831 URL: http://llvm.org/viewvc/llvm-project?rev=273831&view=rev Log: Fix PR28079 - std::wstring_convert move constructor broken. The move constructor for wstring_convert accidentally copied the state member into the converted count m

Re: [PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

asl added a comment. Hrm? Why I'm set to review this? Repository: rL LLVM http://reviews.llvm.org/D21737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21673: [libcxx] guard throw with exception enabling check

rmaprath added a comment. In http://reviews.llvm.org/D21673#467317, @mclow.lists wrote: > Just a reminder - the people who can approve patches for libc++ are > @mclow.lists and @ericWF. My bad, I thought it was too trivial. Won't happen again :) / Asiri Repository: rL LLVM http://reviews

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

koriakin created this revision. koriakin added a reviewer: asl. koriakin added a subscriber: cfe-commits. koriakin set the repository for this revision to rL LLVM. Currently, TargetLibraryInfoWrapperPass is inserted by PMBuilder. However, some passes are inserted manually before the PMBuilder ones

[libcxx] r273824 - Implement LWG 2488 - Make the placeholders constexpr.

Author: ericwf Date: Sun Jun 26 16:01:34 2016 New Revision: 273824 URL: http://llvm.org/viewvc/llvm-project?rev=273824&view=rev Log: Implement LWG 2488 - Make the placeholders constexpr. This patch makes the bind placeholders in std::placeholders both (1) const and (2) constexpr (See below). Thi

Re: [PATCH] D21718: [libcxx] [test] Make move_assign_noexcept.pass.cpp tests more portable.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please add the missing "test_macros.h" includes. http://reviews.llvm.org/D21718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21717: [libcxx] [test] Make dtor_noexcept.pass.cpp tests more portable.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please add the missing "test_macros.h" includes. http://reviews.llvm.org/D21717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21716: [libcxx] [test] Make move_noexcept.pass.cpp tests more portable.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. Please add the required "test_macros.h" includes. http://reviews.llvm.org/D21716 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D21734: [Intrinsics][AVX512][BuiltIn] adding intrinsics for vrangesd instruction set

igorb accepted this revision. igorb added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D21715: [libcxx] [test] Make default_noexcept.pass.cpp tests more portable.

EricWF closed this revision. EricWF added a comment. r273823. http://reviews.llvm.org/D21715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273823 - Make default_noexcept.pass.cpp container tests more portable. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jun 26 15:21:22 2016 New Revision: 273823 URL: http://llvm.org/viewvc/llvm-project?rev=273823&view=rev Log: Make default_noexcept.pass.cpp container tests more portable. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/containers/associative/map/map.con

Re: [PATCH] D21715: [libcxx] [test] Make default_noexcept.pass.cpp tests more portable.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. This is missing "test_macros.h" includes, but I'll add them before committing. I'm sure that we pick them up through another include path, but they should be direct includes. http://reviews.

Re: [PATCH] D21714: [libcxx] [test] In atomics.types.generic/address.pass.cpp, use T(0) for consistency.

EricWF closed this revision. EricWF added a comment. r273822. http://reviews.llvm.org/D21714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273822 - Work around MSVC bug in atomics.types.generic/address.pass.cpp test. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jun 26 14:59:11 2016 New Revision: 273822 URL: http://llvm.org/viewvc/llvm-project?rev=273822&view=rev Log: Work around MSVC bug in atomics.types.generic/address.pass.cpp test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/atomics/atomics.types.generi

Re: [PATCH] D21714: [libcxx] [test] In atomics.types.generic/address.pass.cpp, use T(0) for consistency.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Never thrilled working around a compiler bug, but this seems harmless enough. http://reviews.llvm.org/D21714 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D21713: [libcxx] [test] Use L"cat" L"dog" when concatenating string literals.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. r273821. http://reviews.llvm.org/D21713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[libcxx] r273821 - Use L"cat" L"dog" when concatenating string literals. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jun 26 14:53:46 2016 New Revision: 273821 URL: http://llvm.org/viewvc/llvm-project?rev=273821&view=rev Log: Use L"cat" L"dog" when concatenating string literals. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/localization/locale.categories/category.ti

Re: [PATCH] D21629: [libcxx] [test] Add assertions to quiet analysis warnings about array bounds.

EricWF closed this revision. EricWF added a comment. r273820. http://reviews.llvm.org/D21629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r273820 - Add array bounds assertions to satisfy MSVC's /analyze flag. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jun 26 14:48:29 2016 New Revision: 273820 URL: http://llvm.org/viewvc/llvm-project?rev=273820&view=rev Log: Add array bounds assertions to satisfy MSVC's /analyze flag. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/algorithms/alg.sorting/alg.sort/par

Re: [PATCH] D21625: [libcxx] [test] Mark throw_bad_alloc_helper() as [[noreturn]].

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Accepting before closing. I committed something similar in r273819. Please let me know if it doesn't work. http://reviews.llvm.org/D21625 ___ cfe

[libcxx] r273819 - Add [[noreturn]] attribute to throw_bad_alloc_helper().

Author: ericwf Date: Sun Jun 26 14:42:59 2016 New Revision: 273819 URL: http://llvm.org/viewvc/llvm-project?rev=273819&view=rev Log: Add [[noreturn]] attribute to throw_bad_alloc_helper(). Modified: libcxx/trunk/test/support/count_new.hpp libcxx/trunk/test/support/test_macros.h Modified:

Re: [PATCH] D21625: [libcxx] [test] Mark throw_bad_alloc_helper() as [[noreturn]].

EricWF added a comment. I don't think all the compilers libc++ tests with support `[[noreturn]]` yet. I'll commit a similar patch to this though. http://reviews.llvm.org/D21625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[libcxx] r273818 - Avoid narrowing conversions in quoted test. Patch from s...@microsoft.com

Author: ericwf Date: Sun Jun 26 14:37:23 2016 New Revision: 273818 URL: http://llvm.org/viewvc/llvm-project?rev=273818&view=rev Log: Avoid narrowing conversions in quoted test. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/input.output/iostream.format/quoted.manip/quoted.pass

Re: [PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

EricWF closed this revision. EricWF added a comment. r273818. http://reviews.llvm.org/D21712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. It seems like this has the possibility to lose some useful diagnostics if a narrowing conversion actually occurs. However I'm OK with the change. http://reviews.llvm.org/D21712 ___

Re: [clang-tools-extra] r273786 - [clang-tidy] Add modernize-use-using

Hi, On Sat, Jun 25, 2016 at 06:37:54PM -, Krystyna Gajczyk via cfe-commits wrote: > Author: krystynka > Date: Sat Jun 25 13:37:53 2016 > New Revision: 273786 > > URL: http://llvm.org/viewvc/llvm-project?rev=273786&view=rev > Log: > [clang-tidy] Add modernize-use-using Thanks, sounds like a

Re: [PATCH] D21642: [clang-tidy] boost-use-to-string arg expr location bugfix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Comment at: test/clang-tidy/boost-use-to-string.cpp:154 @@ +153,3 @@ + float floating; + Fields* wierd; + const int &getConstInteger() const {retu

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

This revision was automatically updated to reflect the committed changes. Closed by commit rL273812: [X86] add _mm_loadu_si64 (authored by abadouh). Changed prior to commit: http://reviews.llvm.org/D21504?vs=61903&id=61912#toc Repository: rL LLVM http://reviews.llvm.org/D21504 Files: cfe/

r273812 - [X86] add _mm_loadu_si64

Author: abadouh Date: Sun Jun 26 08:51:54 2016 New Revision: 273812 URL: http://llvm.org/viewvc/llvm-project?rev=273812&view=rev Log: [X86] add _mm_loadu_si64 Differential Revision: http://reviews.llvm.org/D21504 Modified: cfe/trunk/lib/Headers/emmintrin.h cfe/trunk/test/CodeGen/sse2-bui

Re: [PATCH] D21145: [Sema] Fix crash on valid where instantiation of lambda cannot access type of 'this'

faisalv accepted this revision. faisalv added a comment. This revision is now accepted and ready to land. With the assert, I would feel comfortable committing the patch. It always helps to get Richard's approval too - so feel free to ping him aggressively to see if he's interested in stopping i

Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

faisalv resigned from this revision. faisalv removed a reviewer: faisalv. faisalv added a comment. Should be fixed by: http://reviews.llvm.org/D19783. Thanks again for your feedback and all the time you put into this =) http://reviews.llvm.org/D20349 _

[PATCH] D21734: [Intrinsics][AVX512][BuiltIn] adding intrinsics for vrangesd instruction set

m_zuckerman created this revision. m_zuckerman added reviewers: AsafBadouh, igorb, delena. m_zuckerman added a subscriber: cfe-commits. http://reviews.llvm.org/D21734 Files: lib/Headers/avx512dqintrin.h test/CodeGen/avx512dq-builtins.c Index: test/CodeGen/avx512dq-builtins.c

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

RKSimon accepted this revision. RKSimon added a reviewer: RKSimon. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM http://reviews.llvm.org/D21504 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D21504: [X86] add _mm_loadu_si64

AsafBadouh updated this revision to Diff 61903. Repository: rL LLVM http://reviews.llvm.org/D21504 Files: tools/clang/lib/Headers/emmintrin.h tools/clang/test/CodeGen/sse2-builtins.c Index: tools/clang/lib/Headers/emmintrin.h ===