Author: ericwf
Date: Fri Jun 17 23:10:23 2016
New Revision: 273078
URL: http://llvm.org/viewvc/llvm-project?rev=273078&view=rev
Log:
Fix 3 bugs in filesystem tests and implementation.
This patch fixes the following bugs, all of which were discovered while
testing a 32 bit build on a 64 bit machin
tstellarAMD added a comment.
Does this new patch fix the OpenCL regression?
http://reviews.llvm.org/D21367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Jun 17 21:12:53 2016
New Revision: 273076
URL: http://llvm.org/viewvc/llvm-project?rev=273076&view=rev
Log:
Enable building and using atomic shared_ptr for GCC.
Summary:
Currently the implementation of [util.smartptr.shared.atomic] is provided only
when using Clang, and
On Fri, Jun 17, 2016 at 12:45 PM, Rafael Espíndola <
rafael.espind...@gmail.com> wrote:
> Looks like this broke a few bots:
>
Yeah, sorry about that. It should all be cleared up by now (I had a couple
of follow ups to make the test more generic).
>
> http://lab.llvm.org:8011/builders/llvm-clan
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting.
http://reviews.llvm.org/D21407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: ericwf
Date: Fri Jun 17 21:11:48 2016
New Revision: 273075
URL: http://llvm.org/viewvc/llvm-project?rev=273075&view=rev
Log:
Add additional tests in an attempt to diagnose ARM test failures.
Currently 4 tests are failing on the ARM buildbot. To try and diagnose each
of the failures this p
ahatanak added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:2073-2079
@@ +2072,9 @@
+ let Content = [{
+Use ``overallocated`` to indicate a struct or union is over-allocated. For
example,
+
+.. code-block:: c++
+
+struct S {
+ char a[4], char b[4];
+} __attribut
ahatanak updated this revision to Diff 61145.
ahatanak added a comment.
Fix a bug in tryEvaluateBuiltinObjectSize. If the pointer passed to
__builtin_object_size doesn't point to an array, it should be able to compute
the exact size of the subobject the pointer points to. Therefore, it should be
There are probably a few more places that need to be patched.
In particular, take a look at lib/Target/ARM. There are things like
computeTargetABI and isTargetHardFloat that probably need to be
updated (and tested).
CCing Peter for an arm opinion.
Cheers,
Rafael
On 17 June 2016 at 05:50, Lei Z
Author: ericwf
Date: Fri Jun 17 19:23:13 2016
New Revision: 273072
URL: http://llvm.org/viewvc/llvm-project?rev=273072&view=rev
Log:
Add checkpoints to string allocation test to help with debugging arm failures.
Modified:
libcxx/trunk/test/std/experimental/filesystem/class.path/path.member/p
Author: ericwf
Date: Fri Jun 17 18:57:16 2016
New Revision: 273070
URL: http://llvm.org/viewvc/llvm-project?rev=273070&view=rev
Log:
Fix bugs in recursive_directory_iterator::increment(ec) implementation and
tests.
r273060 didn't completely fix the issues in recursive_directory_iterator and
the
Prazek added a reviewer: sbenza.
Prazek added a comment.
You might be interested.
http://reviews.llvm.org/D20964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek marked 8 inline comments as done.
Prazek added a comment.
http://reviews.llvm.org/D20964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated the summary for this revision.
Prazek updated this revision to Diff 61143.
http://reviews.llvm.org/D20964
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseEmplaceCheck.cpp
clang-tidy/modernize/UseEmplaceCheck.h
mclow.lists added inline comments.
Comment at:
test/std/strings/string.view/string.view.template/nothing_to_do.pass.cpp:10
@@ +9,3 @@
+
+#include
+
This should be ``
http://reviews.llvm.org/D21459
___
cfe-commits
Author: ericwf
Date: Fri Jun 17 18:30:40 2016
New Revision: 273068
URL: http://llvm.org/viewvc/llvm-project?rev=273068&view=rev
Log:
Work around GCC bug in tests. The bug has been fixed in GCC 6.0
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.enum/check_bitmask_types.hpp
Modifi
Author: ericwf
Date: Fri Jun 17 17:36:47 2016
New Revision: 273065
URL: http://llvm.org/viewvc/llvm-project?rev=273065&view=rev
Log:
Fix initialization of test case array in C++11
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.canonical/canonical.pass.cpp
Modified
Author: rnk
Date: Fri Jun 17 17:27:59 2016
New Revision: 273063
URL: http://llvm.org/viewvc/llvm-project?rev=273063&view=rev
Log:
[MS] Put member pointer representation flags in our debug info
Added:
cfe/trunk/test/CodeGenCXX/debug-info-ms-ptr-to-member.cpp
Modified:
cfe/trunk/lib/CodeGen
Author: ericwf
Date: Fri Jun 17 17:22:37 2016
New Revision: 273060
URL: http://llvm.org/viewvc/llvm-project?rev=273060&view=rev
Log:
Fix bugs in recursive_directory_iterator implementation and tests.
There are two fixes in this patch:
* Fix bug where the constructor of recursive_directory_iterat
Author: vedantk
Date: Fri Jun 17 16:53:55 2016
New Revision: 273056
URL: http://llvm.org/viewvc/llvm-project?rev=273056&view=rev
Log:
[Coverage] Adopt llvm::coverage::encodeFilenamesAndRawMappings (NFC)
Use an llvm helper function to encode filenames and raw mappings.
Modified:
cfe/trunk/lib
Author: ericwf
Date: Fri Jun 17 16:44:26 2016
New Revision: 273054
URL: http://llvm.org/viewvc/llvm-project?rev=273054&view=rev
Log:
Get filesystem tests passing for single-threaded configurations.
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy_file/copy_file.
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ericwf
Date: Fri Jun 17 16:24:11 2016
New Revision: 273051
URL: http://llvm.org/viewvc/llvm-project?rev=273051&view=rev
Log:
Update status of filesystem issues, and add tests for LWG issue 2683
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.copy/copy.pass.c
Author: ericwf
Date: Fri Jun 17 16:00:27 2016
New Revision: 273049
URL: http://llvm.org/viewvc/llvm-project?rev=273049&view=rev
Log:
Reorder permissions test so they are not dependent on the processes umask
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.permissions
Author: ericwf
Date: Fri Jun 17 15:54:25 2016
New Revision: 273048
URL: http://llvm.org/viewvc/llvm-project?rev=273048&view=rev
Log:
Respect the processes umask in the create_directory test
Modified:
libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.create_directory/create_dire
eugenis closed this revision.
eugenis added a comment.
r272717
Repository:
rL LLVM
http://reviews.llvm.org/D21317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jvesely
Date: Fri Jun 17 15:30:49 2016
New Revision: 273043
URL: http://llvm.org/viewvc/llvm-project?rev=273043&view=rev
Log:
nvptx: Drop feature defines.
This is now handled by clang
Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
Modified:
libclc/trunk/configure.py
Modified
Author: jvesely
Date: Fri Jun 17 15:30:41 2016
New Revision: 273042
URL: http://llvm.org/viewvc/llvm-project?rev=273042&view=rev
Log:
64 bit integers are legal in full profile without an extension
Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
Modified:
libclc/trunk/configure.py
l
Author: jvesely
Date: Fri Jun 17 15:30:50 2016
New Revision: 273044
URL: http://llvm.org/viewvc/llvm-project?rev=273044&view=rev
Log:
configure: Remove device specific defines
Signed-off-by: Jan Vesely
Reviewed-by: Tom Stellard
Modified:
libclc/trunk/configure.py
Modified: libclc/trunk/co
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK.
-eric
http://reviews.llvm.org/D21469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: ericwf
Date: Fri Jun 17 15:16:46 2016
New Revision: 273037
URL: http://llvm.org/viewvc/llvm-project?rev=273037&view=rev
Log:
Add missing space between >> in template declaration. Fixes C++03 build.
Modified:
libcxx/trunk/include/iomanip
Modified: libcxx/trunk/include/iomanip
URL:
ht
Author: compnerd
Date: Fri Jun 17 14:59:01 2016
New Revision: 273036
URL: http://llvm.org/viewvc/llvm-project?rev=273036&view=rev
Log:
test: support / and \ as directory separators
Windows uses \ as the directory separator and this causes the tests to fail on
Windows.
Modified:
cfe/trunk/tes
Author: ericwf
Date: Fri Jun 17 14:57:54 2016
New Revision: 273035
URL: http://llvm.org/viewvc/llvm-project?rev=273035&view=rev
Log:
Fix a couple of warnings present in the filesystem tests.
Modified:
libcxx/trunk/test/std/experimental/filesystem/class.directory_iterator/directory_iterator.m
EricWF closed this revision.
EricWF added a comment.
Committed as r273034.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Looks like this broke a few bots:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7311
Cheers,
Rafael
On 17 June 2016 at 13:23, Saleem Abdulrasool via cfe-commits
wrote:
> Author: compnerd
> Date: Fri Jun 17 12:23:16 2016
> New Revision: 273016
>
> URL
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting before committing. Speak now or forever hold your peace. (Or just
speak post commit)
http://reviews.llvm.org/D16948
_
This corresponds to binutils' --enable-x86-relax-relocations.
Cheers,
Rafael
From 1d5920b88d06afe0575313f3b2fc327a5069e32c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafael=20=C3=81vila=20de=20Esp=C3=ADndola?=
Date: Fri, 17 Jun 2016 15:33:29 -0400
Subject: [PATCH] Add a ENABLE_X86_RELAX_RELOCATION
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273031: NVPTX: Add supported CL features (authored by
jvesely).
Changed prior to commit:
http://reviews.llvm.org/D20389?vs=60257&id=61119#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20389
File
Author: jvesely
Date: Fri Jun 17 14:02:14 2016
New Revision: 273031
URL: http://llvm.org/viewvc/llvm-project?rev=273031&view=rev
Log:
NVPTX: Add supported CL features
Fixes libclc compilation broken by r269670
Reviewers: jholewinsky
Differential Revision: http://reviews.llvm.org/D20389
Added:
sbenza added a comment.
Missing the .rst file.
Did you use the check_clang_tidy.py script to create the template?
Comment at: clang-tidy/performance/EmplaceCheck.cpp:25
@@ +24,3 @@
+ cxxMemberCallExpr(
+ on(expr(hasType(cxxRecordDecl(hasName("std::vector"),
+
probinson added a subscriber: probinson.
probinson added a comment.
I'm still bemused that Clang thinks of a defined-in-class method and a method
marked with 'inline' as significantly different things. But given that it
does, a way to make them be treated the same will be nice.
==
Author: majnemer
Date: Fri Jun 17 12:47:24 2016
New Revision: 273020
URL: http://llvm.org/viewvc/llvm-project?rev=273020&view=rev
Log:
[CodeGen] Use pointer-sized integers for ptrtoint sources
Given something like:
void *v = (void *)100;
We need to synthesize a ptrtoint operation from 100. Duri
Author: compnerd
Date: Fri Jun 17 12:33:36 2016
New Revision: 273018
URL: http://llvm.org/viewvc/llvm-project?rev=273018&view=rev
Log:
test: generalise the matching
Use a regex for the clang version as that will change all the time.
Modified:
cfe/trunk/test/Driver/windows-cross.c
Modified:
mmasten added a subscriber: cfe-commits.
mmasten updated this revision to Diff 61110.
http://reviews.llvm.org/D19544
Files:
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/Frontend/CompilerInvocation.cpp
Index: lib/CodeGen
mmasten updated this revision to Diff 6.
http://reviews.llvm.org/D19544
Files:
include/llvm/Analysis/TargetLibraryInfo.h
lib/Analysis/TargetLibraryInfo.cpp
Index: lib/Analysis/TargetLibraryInfo.cpp
===
--- lib/Analysis/Targe
Author: compnerd
Date: Fri Jun 17 12:23:16 2016
New Revision: 273016
URL: http://llvm.org/viewvc/llvm-project?rev=273016&view=rev
Log:
Driver: introduce and use `-isystem-after` for cross-windows
This mirrors the many other -i*after options to insert a new system search
directory at the end of th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273015: [OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver
(authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20630?vs=58978&id=61109#toc
Repository:
rL LLVM
http://reviews.llv
Author: yaxunl
Date: Fri Jun 17 12:19:28 2016
New Revision: 273015
URL: http://llvm.org/viewvc/llvm-project?rev=273015&view=rev
Log:
[OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver
Fix a regression which forbids using -std=cl|CL1.1|CL1.2|CL2.0 in driver.
Allow -std and -cl-std={cl|CL}{|1.1|1
bryanpkc added a comment.
Thanks for the review! I have committed the patch.
http://reviews.llvm.org/D14727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bryanpkc
Date: Fri Jun 17 11:47:14 2016
New Revision: 273012
URL: http://llvm.org/viewvc/llvm-project?rev=273012&view=rev
Log:
[Driver] Adapt Linux::GCCVersion::Parse to match GCC 5 installations
Summary:
Some GCC 5 installations store the libstdc++ includes and GCC-specific files in
pat
Prazek added inline comments.
Comment at: test/clang-tidy/modernize-use-emplace.cpp:2
@@ +1,3 @@
+// RUN: %check_clang_tidy %s modernize-use-emplace %t
+
+namespace std {
hokein wrote:
> Could you also add the following case in the test?
> ```
> vector> v1;
> v1.p
Author: rnk
Date: Fri Jun 17 11:11:20 2016
New Revision: 273008
URL: http://llvm.org/viewvc/llvm-project?rev=273008&view=rev
Log:
[codeview] Stop emitting fully qualified subprogram display names
This effectively reverts r255744, and leaves the printing option tweaks.
We can add the name qualifi
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM. Do you want me to commit it for you?
http://reviews.llvm.org/D14727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
rnk added a comment.
In http://reviews.llvm.org/D20647#460520, @Ilod wrote:
> I don't think weak linkage defines this.
Right, sorry, normal external linkage is the obvious case. I was hung up
thinking about cases like this:
volatile int x;
template
struct A {
void f();
void g()
hokein added a comment.
A few comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:59
@@ -57,2 +58,3 @@
CheckFactories.registerCheck("modernize-use-nullptr");
+CheckFactories.registerCheck("modernize-use-emplace");
CheckFactories.registerCheck("modern
JamesReynolds added a comment.
I'm not 100% sure that my regexes are the best balance between readability and
terseness - or that I've named the case types particularly well. If there are
better ideas for either of those things I'm very happy to accept criticism!
http://reviews.llvm.org/D21472
JamesReynolds created this revision.
JamesReynolds added a reviewer: alexfh.
JamesReynolds added a subscriber: cfe-commits.
Added Stroustrup_Case and stroustrup_Back
(http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#S-naming)
```
class Stroustrup_Case_Class_Name
{
void private_Strou
jmolloy added a comment.
Private reply:
fine by me but a clang person needs to a accept it.
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rksimon
Date: Fri Jun 17 09:28:16 2016
New Revision: 273003
URL: http://llvm.org/viewvc/llvm-project?rev=273003&view=rev
Log:
[X86][SSE4A] Use native IR for mask movntsd/movntss intrinsics.
Depends on llvm side commit r273002.
Modified:
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
cfe/tru
Prazek added a comment.
In http://reviews.llvm.org/D21303#460814, @alexfh wrote:
> 3. What's so special about `return`? Looks like a more general problem is:
> passing an lvalue to a function/constructor/operator by const reference where
> it could instead be moved (the lvalue isn't used afterw
rogfer01 added a comment.
Ping? Thank you.
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added a subscriber: cfe-commits.
http://reviews.llvm.org/D21470
Files:
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
Index: clang-tidy/misc/DefinitionsInHeadersCheck.cpp
==
teemperor added a comment.
ping
http://reviews.llvm.org/D20382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jholewinski accepted this revision.
jholewinski added a comment.
This revision is now accepted and ready to land.
Looks good to me
Repository:
rL LLVM
http://reviews.llvm.org/D20389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
rogfer01 updated this revision to Diff 61089.
rogfer01 added a comment.
Following @rsmith suggestion, the diagnostic is silenced if the address is
converted to a pointer with lower or equal alignment requirements.
http://reviews.llvm.org/D20561
Files:
include/clang/Basic/DiagnosticSemaKinds.
aturetsk created this revision.
aturetsk added reviewers: bruno, echristo.
aturetsk added subscribers: cfe-commits, zinovy.nis.
Herald added a subscriber: mehdi_amini.
Add -mno-iamcu option to:
1) Countervail -miamcu option easily
2) Be compatible with GCC which supports this option
http://review
rogfer01 marked an inline comment as done.
rogfer01 added a comment.
http://reviews.llvm.org/D20561
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Yes, you're probably not the right person to fix our test coverage. Thanks for
fixing the stuff that broke and I hope we'll figure out what else needs to be
fixed in a finite time after the ch
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Removing from my dashboard until http://reviews.llvm.org/D20428 is submitted.
Repository:
rL LLVM
http://reviews.llvm.org/D19201
___
alexfh added a comment.
Removing from my dashboard until http://reviews.llvm.org/D20428 is submitted.
http://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Apart from the other reviewers' comments, I have a few concerns:
1. The "performance-returning-type" name is missing an important part of
information. Maybe "performance-return-value
alexfh added a comment.
A few nits. Otherwise looks good, if Sam has no objections.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34
@@ -29,1 +33,3 @@
+template bool isSetDifferenceEmpty(const S &S1, const S &S2) {
+ for (const auto &E : S1)
-
Author: alexfh
Date: Fri Jun 17 07:01:15 2016
New Revision: 272995
URL: http://llvm.org/viewvc/llvm-project?rev=272995&view=rev
Log:
[clang-tidy] More doc fixes. NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/utils/IncludeSorter.h
clang-tools-extra/trunk/clang-tidy/utils/LexerUtils.h
Author: alexfh
Date: Fri Jun 17 06:43:33 2016
New Revision: 272994
URL: http://llvm.org/viewvc/llvm-project?rev=272994&view=rev
Log:
[clang-tidy] Fix doxygen errors. NFC.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.h
clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedHeader
2016-06-15 16:28 GMT+08:00 Lei Zhang :
> Here's another patch including test cases for various non-x86 archs,
> which should just work with my previous patches. ARM is left out
> purposely since it involves extra complexity. I'll work on it later.
Hi,
Here are another two patches which add suppor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272993: [clang-tidy] readability-identifier-naming - Support
for Macros (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D21020?vs=61071&id=61074#toc
Repository:
rL LLVM
http:/
Author: alexfh
Date: Fri Jun 17 04:25:24 2016
New Revision: 272993
URL: http://llvm.org/viewvc/llvm-project?rev=272993&view=rev
Log:
[clang-tidy] readability-identifier-naming - Support for Macros
Summary:
Added support for macro definitions.
--
1. Added a pre-processor callback to catch macro d
alexfh added a comment.
In http://reviews.llvm.org/D21020#460734, @JamesReynolds wrote:
> Thanks! All fixed now. Could you land this for me please?
Sure, will do. Thank you for working on this!
http://reviews.llvm.org/D21020
___
cfe-commits maili
JamesReynolds marked an inline comment as done.
JamesReynolds added a comment.
Thanks! All fixed now. Could you land this for me please?
http://reviews.llvm.org/D21020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
JamesReynolds marked 2 inline comments as done.
Comment at: clang-tidy/readability/IdentifierNamingCheck.h:98
@@ +97,3 @@
+
+ /// Add a usage of a macro if it already has a violation.
+ void expandMacro(const Token &MacroNameTok, const MacroInfo *MI);
Fixed this
JamesReynolds updated this revision to Diff 61071.
JamesReynolds added a comment.
Fixed nits.
http://reviews.llvm.org/D21020
Files:
clang-tidy/readability/IdentifierNamingCheck.cpp
clang-tidy/readability/IdentifierNamingCheck.h
docs/ReleaseNotes.rst
test/clang-tidy/readability-identifie
81 matches
Mail list logo
