Author: abataev
Date: Wed May 25 23:56:05 2016
New Revision: 270822
URL: http://llvm.org/viewvc/llvm-project?rev=270822&view=rev
Log:
[OPENMP] Set '_OPENMP' macro to '201511' value to reflect support for
OpenMP 4.5.
According to OpenMP 4.5 the _OPENMP macro name is defined to have the decimal
va
EricWF added a comment.
A couple of comments.
1. there's probably a better way to state `_LIBCPP_STD_VER <= 14 ||
defined(_LIBCPP_NO_REMOVE_AUTO_PTR)`. Maybe `_LIBCPP_HAS_NO_AUTO_PTR` which
`__config` defines if `_LIBCPP_STD_VER > 14 &&
!defined(_LIBCPP_NO_REMOVE_AUTO_PTR)`.
2. `// XFAIL c++1
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
mclow.lists added a subscriber: cfe-commits.
[[ http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190 | N4190 ]]
removed `auto_ptr` from C++1z. (and other stuff)
Wrap all the auto_ptr bits in an #ifdef so they disap
majnemer added a subscriber: majnemer.
Comment at: lib/Headers/emmintrin.h:598
@@ -594,3 +597,3 @@
static __inline__ void __DEFAULT_FN_ATTRS
-_mm_store_pd(double *__dp, __m128d __a)
+_mm_store_pd1(double *__dp, __m128d __a)
{
You could use `__attribute__((align_
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
Given that its documented as being aligned. I'm ok with it. LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20617
___
cfe-commit
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, with a small nit.
Comment at: lib/Sema/SemaOpenMP.cpp:10214
@@ +10213,3 @@
+// expressions.
+struct MappableVarListInfo {
+ // The list of expressions.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
alexeagle added a subscriber: alexeagle.
Comment at: lib/Format/FormatTokenLexer.cpp:23
@@ -22,1 +22,3 @@
+#include "llvm/Support/Debug.h"
+
revert this file
Comment at: lib/Format/TokenAnnotator.cpp:698
@@ +697,3 @@
+
+if (Style.Language =
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: ahatanak
Date: Wed May 25 21:32:10 2016
New Revision: 270817
URL: http://llvm.org/viewvc/llvm-project?rev=270817&view=rev
Log:
Don't feed standard error to FileCheck.
This is an attempt to fix the buildbot that started failing after
r270808.
http://lab.llvm.org:8011/builders/sanitizer-x8
ldionne added a comment.
No problem for the delay; we're all busy :-). Unfortunately, the patch does not
apply cleanly on `master` anymore, so I'll rebase it and someone can then
commit it for me.
http://reviews.llvm.org/D15421
___
cfe-commits mai
compnerd closed this revision.
compnerd added a comment.
SVN r270816 with the changes.
Repository:
rL LLVM
http://reviews.llvm.org/D20270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: compnerd
Date: Wed May 25 21:12:20 2016
New Revision: 270816
URL: http://llvm.org/viewvc/llvm-project?rev=270816&view=rev
Log:
libc++abi: build with -fvisibility=hidden
Enable building libc++abi with hidden visibility by default. The ABI mandated
interfaces (and a few extra) are already
tstellarAMD accepted this revision.
tstellarAMD added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: ahatanak
Date: Wed May 25 19:37:30 2016
New Revision: 270808
URL: http://llvm.org/viewvc/llvm-project?rev=270808&view=rev
Log:
[ObjC] Remove _Atomic from return type and parameter type of
objective-c properties.
This fixes an assert in CodeGen that fires when the getter and setter
functio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270808: [ObjC] Remove _Atomic from return type and parameter
type of (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D20407?vs=58544&id=58549#toc
Repository:
rL LLVM
http://
ahatanak updated this revision to Diff 58544.
ahatanak added a comment.
Thanks for the review. I've removed parameter ASTContext that was unused.
http://reviews.llvm.org/D20407
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CGObjC.cpp
lib/Sema/SemaObjCProperty.cpp
test/C
manmanren added a comment.
Doug and Richard,
Can you take a look at this when you have time?
Thanks,
Manman
http://reviews.llvm.org/D20383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rjmccall added a comment.
One minor improvement to the API and LGTM.
Comment at: include/clang/AST/Type.h:1084
@@ +1083,3 @@
+ /// Remove all qualifiers including _Atomic.
+ QualType getAtomicUnqualifiedType(const ASTContext &ctx) const;
+
This doesn't need an
rjmccall added a comment.
In http://reviews.llvm.org/D20407#440050, @ahatanak wrote:
> In http://reviews.llvm.org/D20407#439951, @rjmccall wrote:
>
> > The C standard is poorly-written in this area, but I think it would be
> > reasonable for CheckFunctionReturnType to just silently remove _Atomi
eric_niebler added a comment.
> Please add some tests for the FixItHint replacement text. See test/FixIt for
> examples of how to do this.
Thanks for the suggestion. After adding tests for this, I noticed badness with
the path separators in the FixIt hint when running on Windows. I'm working o
pirama updated this revision to Diff 58537.
pirama added a comment.
Renamed diagnostic to use ext_ prefix.
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Expr.cpp
lib/Sema/SemaExprMember.cpp
test/CodeGen/ext-vector.c
pirama updated this revision to Diff 58535.
pirama added a comment.
Switched to ExtWarn, updated warning's message and made the version check
strict w.r.t. 2.2.
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Expr.cpp
li
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0.
sfantao added subscribers: cfe-commits, caomhin.
This patch implements the code generation for the `target update` directive.
The implemntation relies on the logic already in place for
mprobst updated this revision to Diff 58529.
mprobst added a comment.
- use #include style shebang parsing.
http://reviews.llvm.org/D20632
Files:
lib/Format/FormatTokenLexer.cpp
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
=
ahatanak added a comment.
In http://reviews.llvm.org/D20334#439248, @bcraig wrote:
> ASAN is complaining about an excessively large read. If the problem was in
> overflow, I would expect ASAN to complain about an out-of-bounds write
> instead.
According to the example shown in the link below
Author: gbiv
Date: Wed May 25 17:38:36 2016
New Revision: 270784
URL: http://llvm.org/viewvc/llvm-project?rev=270784&view=rev
Log:
[Sema] Use the failure bits introduced by r270781.
r270781 introduced the ability to track whether or not we might have
had unmodeled side-effects during constant exp
Ilod created this revision.
Ilod added a subscriber: cfe-commits.
Add two flags (-finline-implicit-hint and -fno-inline-implicit-hint) to allow
to add InlineHint on implicitly inline functions (constexpr and member
functions of class that was defined in the class body).
This is needed to add sup
Author: gbiv
Date: Wed May 25 17:31:54 2016
New Revision: 270781
URL: http://llvm.org/viewvc/llvm-project?rev=270781&view=rev
Log:
[Sema] Note when we encounter a problem in ExprConstant.
Currently, the constexpr evaluator is very conservative about unmodeled
side-effects when we're evaluating an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270781: [Sema] Note when we encounter a problem in
ExprConstant. (authored by gbiv).
Changed prior to commit:
http://reviews.llvm.org/D18540?vs=52834&id=58526#toc
Repository:
rL LLVM
http://reviews.
rsmith added a comment.
Looks good other than the recent information about the version of OpenCL that
actually specifies this.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7899
@@ +7898,3 @@
+// OpenCL v2.2 s2.1.2.3 - Vector Component Access
+def warn_opencl_ext_vecto
pirama added a comment.
> > > I'm not suggesting it be treated as invalid. This extension is part of at
> > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is
> > > Clang's implementation of the OpenCL vector type. Therefore if the user
> > > asks us to support OpenCL 1.0
pirama updated this revision to Diff 58525.
pirama added a comment.
Added warnings when rgba is used with OpenCL
http://reviews.llvm.org/D20602
Files:
include/clang/AST/Type.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/AST/Expr.cpp
lib/Sema/SemaExprMember.cpp
test/CodeGen/ext-vect
rsmith added a comment.
In http://reviews.llvm.org/D18035#437715, @rengolin wrote:
> The 3.8.1 deadline is tomorrow and I'd really like to see these two patches
> (plus the related fixes) in it,
Realistically, this seems unlikely to make it in time.
> or some LTS Linux distributions will live
- Original Message -
> From: "David Blaikie"
> To: "Hal Finkel"
> Cc: "Richard Smith" , "Adrian Prantl"
> , "Duncan P. N. Exon Smith"
> , "Eric Christopher" ,
> "Jun Bum Lim" , "cfe-commits"
> ,
> reviews+d19708+public+e9ddc42503732...@reviews.llvm.org
> Sent: Thursday, May 12, 2016 2:54
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270775: [CGDebugInfo] Modify the preferred expression
location for member calls. (authored by hfinkel).
Changed prior to commit:
http://reviews.llvm.org/D19708?vs=55610&id=58521#toc
Repository:
rL LL
Author: hfinkel
Date: Wed May 25 17:08:27 2016
New Revision: 270775
URL: http://llvm.org/viewvc/llvm-project?rev=270775&view=rev
Log:
[CGDebugInfo] Modify the preferred expression location for member calls.
If the callee has a valid location (not all do), then use that. Otherwise, fall
back to th
Author: rsmith
Date: Wed May 25 17:06:25 2016
New Revision: 270774
URL: http://llvm.org/viewvc/llvm-project?rev=270774&view=rev
Log:
Fix rejects-valid on constexpr function that accesses a not-yet-defined 'extern
const' variable. That variable might be defined as 'constexpr', so we cannot
prove th
On Wed, May 25, 2016 at 2:20 PM, Aleksey Bader
wrote:
> On Wed, May 25, 2016 at 11:53 PM, Richard Smith
> wrote:
>
>> On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> bader added a subscriber: bader.
>>> bader added a comment.
>>>
>>> I
hfinkel closed this revision.
hfinkel added a comment.
r270772, thanks!
http://reviews.llvm.org/D19739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
Author: hfinkel
Date: Wed May 25 16:53:24 2016
New Revision: 270772
URL: http://llvm.org/viewvc/llvm-project?rev=270772&view=rev
Log:
Add a loop's debug location to its llvm.loop metadata
Getting accurate locations for loops is important, because those locations are
used by the frontend to genera
ahatanak added a comment.
In http://reviews.llvm.org/D20407#439951, @rjmccall wrote:
> The C standard is poorly-written in this area, but I think it would be
> reasonable for CheckFunctionReturnType to just silently remove _Atomic. (You
> will not be able to just re-use your new method there;
yaxunl added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
majnemer added a comment.
In http://reviews.llvm.org/D18035#434095, @DmitryPolukhin wrote:
> One more friendly ping.. :(
I think the best way to make progress on this is to refactor this patch along
the lines @rsmith suggested back on May 3.
http://reviews.llvm.org/D18035
On Wed, May 25, 2016 at 11:53 PM, Richard Smith
wrote:
> On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> bader added a subscriber: bader.
>> bader added a comment.
>>
>> In http://reviews.llvm.org/D20602#438667, @rsmith wrote:
>>
>> > I'm
ahatanak updated this revision to Diff 58512.
ahatanak added a comment.
Rename variables.
http://reviews.llvm.org/D20407
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CGObjC.cpp
lib/Sema/SemaObjCProperty.cpp
test/CodeGenObjC/property-atomic-bool.m
test/SemaObjC/proper
rjmccall added a comment.
In http://reviews.llvm.org/D20407#439887, @ahatanak wrote:
> I reverted the changes I made in SemaDeclObjC.cpp as they weren't needed to
> pass the regression tests I added. clang still asserts when it compiles an
> objective-c method returning _Atomic and those change
etienneb added a comment.
This patch needs land after http://reviews.llvm.org/D20346.
thx for the review.
http://reviews.llvm.org/D20347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
etienneb updated this revision to Diff 58502.
etienneb marked an inline comment as done.
etienneb added a comment.
more tests
http://reviews.llvm.org/D20347
Files:
include/clang/Driver/CLCompatOptions.td
lib/Driver/Tools.cpp
test/Driver/cl-fallback.c
test/Driver/cl-options.c
Index: tes
rjmccall added inline comments.
Comment at: lib/AST/Type.cpp:1282
@@ -1277,1 +1281,3 @@
+}
+
Optional> Type::getObjCSubstitutions(
ahatanak wrote:
> I added getTypePtr() because the code didn't compile.
Sure.
Comment at: lib/CodeGen/CGObjC.cpp:9
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
I reverted the changes I made in SemaDeclObjC.cpp as they weren't needed to
pass the regression tests I added. clang still asserts when it compiles an
objective-c method returning _Atomic and those changes will become necessary
Author: hans
Date: Wed May 25 15:49:14 2016
New Revision: 270754
URL: http://llvm.org/viewvc/llvm-project?rev=270754&view=rev
Log:
Revert r270748 "clang-cl: Treat dllimport explicit template instantiation
definitions as declarations (PR27810, PR27811)"
It seems to have broken the sanitizer-windo
On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> bader added a subscriber: bader.
> bader added a comment.
>
> In http://reviews.llvm.org/D20602#438667, @rsmith wrote:
>
> > I'm not suggesting it be treated as invalid. This extension is part of
>
ahatanak marked 7 inline comments as done.
Comment at: lib/AST/Type.cpp:1282
@@ -1277,1 +1281,3 @@
+}
+
Optional> Type::getObjCSubstitutions(
I added getTypePtr() because the code didn't compile.
Comment at: lib/CodeGen/CGObjC.cpp:901
@@ -903,1
ahatanak updated this revision to Diff 58495.
ahatanak added a comment.
Address John's review comments.
http://reviews.llvm.org/D20407
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
lib/CodeGen/CGObjC.cpp
lib/Sema/SemaObjCProperty.cpp
test/CodeGenObjC/property-atomic-bool.m
test/S
rsmith added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
rsmith added inline comments.
Comment at: lib/Basic/FileManager.cpp:389
@@ -383,2 +388,3 @@
UFE->File.reset();
+ UFE->IsVirtual = true;
return UFE;
Rather than adding this `IsVirtual` flag, could you just set `UFE->IsValid` to
`true` here? It looks like a
sfantao added a comment.
Hi Alexey,
Thanks for the review!
In http://reviews.llvm.org/D18488#438841, @ABataev wrote:
> Missed a test for printing and serialization/deserialization
Maybe it is `test/OpenMP/target_update_ast_print.cpp` what you were looking
for? Let me know if not.
Thanks aga
sfantao updated this revision to Diff 58490.
sfantao marked an inline comment as done.
sfantao added a comment.
- Rebase and remove changes from the nesting tests.
http://reviews.llvm.org/D18488
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270748: clang-cl: Treat dllimport explicit template
instantiation definitions as… (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D20608?vs=58484&id=58488#toc
Repository:
rL LLVM
Author: hans
Date: Wed May 25 15:16:43 2016
New Revision: 270748
URL: http://llvm.org/viewvc/llvm-project?rev=270748&view=rev
Log:
clang-cl: Treat dllimport explicit template instantiation definitions as
declarations (PR27810, PR27811)
This matches what MSVC does, and should make compiles faster
sfantao updated this revision to Diff 58486.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Address comments from the last review by Alexey.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/B
sfantao added a comment.
Hi Alexey,
Thanks for the review.
Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220
@@ +10217,5 @@
+Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind,
+ArrayRef VarList, SmallVector &Vars,
+OMPClauseMappableExprCommon::MappableExprCompon
hans updated this revision to Diff 58484.
hans added a comment.
Fix the "dllexport trumps" comment, and add a test.
http://reviews.llvm.org/D20608
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/dllimport.cpp
Index: test/CodeGenCXX/dllimport.cpp
===
hans added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7382
@@ +7381,3 @@
+ if (A->getKind() == AttributeList::AT_DLLExport) {
+// dllexport trumps dllexport here.
+DLLImport = false;
thakis wrote:
> trumps _dllimport_ here
>
> (te
kzhuravl created this revision.
kzhuravl added a reviewer: tstellarAMD.
kzhuravl added a subscriber: cfe-commits.
Herald added a subscriber: kzhuravl.
http://reviews.llvm.org/D20640
Files:
lib/Driver/ToolChains.h
test/Driver/amdgpu-toolchain.c
Index: test/Driver/amdgpu-toolchain.c
==
djasper added a comment.
That's the same for #include directives (with <>). Just turn the tokens into
TT_ImplicitStringLiteral, same as is done for #includes. I am not saying it's
better, but I don't think we should have to different approaches..
http://reviews.llvm.org/D20632
_
thakis accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaTemplate.cpp:7382
@@ +7381,3 @@
+ if (A->getKind() == AttributeList::AT_DLLExport) {
+// dllexport trumps dllexport here.
+DLLImport = false;
-
kromanova updated this revision to Diff 58472.
kromanova added a comment.
I attached full svn diff. Thank you Michael!
I had to clean up the trailing spaces from doxygen comments (because it mess up
our post-processing scripts), but since I was doing it, I decided to clean up
the rest of the he
yaxunl updated this revision to Diff 58471.
yaxunl added a comment.
Revised as Richard suggested.
http://reviews.llvm.org/D20630
Files:
lib/Frontend/CompilerInvocation.cpp
test/Driver/opencl.cl
test/Frontend/stdlang.c
Index: test/Frontend/stdlang.c
===
A factory required a successful step of removing the llvm.obj directory,
which could be missing in some cases.
The fix is committed as r270773
Thanks
Galina
On Wed, May 25, 2016 at 12:22 PM, Sean Silva wrote:
> What was the issue?
>
> On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llv
bkramer added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.py:84
@@ +83,3 @@
+index = 1;
+for header in lines[1:]:
+ choices_message += "&" + str(index) + header + "\n"
ioeric wrote:
> If there is only one candidate, it doesn't
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:241
@@ +240,3 @@
+ IncludeFixerContext
+ GetIncludeFixerContext(const clang::SourceManager &SourceManager,
+ clang::HeaderSearch &HeaderSearch) {
I think function na
mprobst added a comment.
How would I disable the formatting using that way?
When I special case `parsePreprocessorDirective()`, consume the line, and
return `LT_ImportStatement`, clang-format still tries to format tokens within
the shebang. E.g. I get `#!/usr/bin / env node`, note the whitespac
What was the issue?
On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> Hello,
>
> Builder
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
> is back to normal.
> Sorry for the noise.
>
> Thanks
>
> Galina
Hello,
Builder
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
is back to normal.
Sorry for the noise.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
I will fix that. Thanks.
Sam
From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith
Sent: Wednesday, May 25, 2016 2:54 PM
To: Liu, Yaxun (Sam) ;
reviews+d20630+public+1c58d99d1f368...@reviews.llvm.org
Cc: alexey.ba...@intel.com; Anastasia Stulova ;
cfe-commits
Subject: R
sfantao updated this revision to Diff 58469.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add nestings test.
http://reviews.llvm.org/D15944
Files:
include/clang-c/Index.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/StmtOpenMP.h
include/clang/Basic/D
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1084
@@ +1083,3 @@
+ /// Strip typedefs and atomic from the given type.
+ QualType getDesugaredAtomicValueType(const ASTContext &ctx) const;
+
Please name this getAtomicUnqualifiedType() and ha
On 25 May 2016 9:13 a.m., "Yaxun Liu via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> yaxunl created this revision.
> yaxunl added a reviewer: Anastasia.
> yaxunl added subscribers: pxli168, bader, tstellarAMD, cfe-commits.
>
> Fix a regression which forbids using -std=CL|CL1.1|CL1.2|CL2.0
vmiklos created this revision.
vmiklos added reviewers: klimek, cfe-commits.
The check failed, 'Cla *C = new Cla();' was renamed 'D *C = new Cla();'.
http://reviews.llvm.org/D20635
Files:
clang-rename/USRLocFinder.cpp
test/clang-rename/ConstructExpr.cpp
Index: test/clang-rename/ConstructExp
hans added a comment.
Thanks for the review!
In http://reviews.llvm.org/D20608#439480, @thakis wrote:
> Do we have test coverage for `template class __declspec(dllexport)
> codecvt;` somewhere already?
Yes, that's covered by tests in CodeGenCXX/dllexport.cpp
Comment at: lib
hans updated this revision to Diff 58461.
hans added a comment.
tweaks
http://reviews.llvm.org/D20608
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/dllimport.cpp
Index: test/CodeGenCXX/dllimport.cpp
bruno added a comment.
You can probably find a way to test this by taking a look at
unittests/Basic/VirtualFileSystemTest.cpp
Repository:
rL LLVM
http://reviews.llvm.org/D20338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
bruno added a comment.
Hi,
Comment at: lib/Driver/Tools.cpp:3657
@@ +3656,3 @@
+ if (IsIAMCU && types::isCXX(Input.getType()))
+D.Diag(diag::err_drv_cxx_not_supported) <<
getToolChain().getTriple().str();
+
Taking a look at this again I don't think there's
bcraig added a comment.
r270735
http://reviews.llvm.org/D20573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig closed this revision.
bcraig added a comment.
r270732
http://reviews.llvm.org/D20574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pirama added a comment.
To summarize, there are two scenarios where a warning is warranted when the
source language is OpenCL:
> > I'm not suggesting it be treated as invalid. This extension is part of at
> > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is
> > Clang's i
djasper added a comment.
Thinking some more, I think this is actually very close to what we do for
#include(-like) statements. That is done in TokenAnnotator::parseLine() and
TokenAnnotator::parseIncludeDirective(). Could you move the logic there?
http://reviews.llvm.org/D20632
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bcraig
Date: Wed May 25 12:40:09 2016
New Revision: 270735
URL: http://llvm.org/viewvc/llvm-project?rev=270735&view=rev
Log:
[libcxx] Allow explicit pthread opt-in
The existing pthread detection code in __config is pretty good for
common operating systems. It doesn't allow cmake-time choi
arsenm added a comment.
Also some tests for non-kernel functions. We might want to keep this as byval
for calling those
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: bcraig
Date: Wed May 25 12:37:38 2016
New Revision: 270732
URL: http://llvm.org/viewvc/llvm-project?rev=270732&view=rev
Log:
Allow explicit pthread opt-in
When building libcxxabi in tree (i.e. in llvm/projects/libcxxabi,
along with llvm/projects/libcxx), libcxx's config_site.in doesn't
ge
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639
@@ -5599,6 +5629,12 @@
// type, the default is 'tofrom'.
CurMapTypes.push_back(ElementType->isAggregateType()
sfantao updated this revision to Diff 58453.
sfantao marked an inline comment as done.
sfantao added a comment.
- Create function for the generation of the default map information.
http://reviews.llvm.org/D20112
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/target_firstprivate_codegen.
Author: davidxl
Date: Wed May 25 12:25:57 2016
New Revision: 270728
URL: http://llvm.org/viewvc/llvm-project?rev=270728&view=rev
Log:
Use new triple API to check comdat /NFC
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
1 - 100 of 184 matches
Mail list logo
