r269632 - [X86] Add typecasts to remove most assumptions about what __m128i/__m256i is defined as. Add similar typecasts for the fp types as well.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 16 01:38:42 2016 New Revision: 269632 URL: http://llvm.org/viewvc/llvm-project?rev=269632&view=rev Log: [X86] Add typecasts to remove most assumptions about what __m128i/__m256i is defined as. Add similar typecasts for the fp types as well. Modified: cfe/trunk/l

r269631 - [AVX512] Add typecasts to some intrinsics to avoid doing operations on the __m512/__m512i/__m512d types.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon May 16 01:38:36 2016 New Revision: 269631 URL: http://llvm.org/viewvc/llvm-project?rev=269631&view=rev Log: [AVX512] Add typecasts to some intrinsics to avoid doing operations on the __m512/__m512i/__m512d types. Modified: cfe/trunk/lib/Headers/avx512fintrin.h c

[PATCH] D20279: [clang-tidy] Cleanups utils files

2016-05-15 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Cleanup some code by using appropriate APIs. Some coding style cleanups. There is no behavior changes. http://reviews.llvm.org/D20279 Files: clang-tidy/utils/DeclRefExprUtils.cpp cla

r269630 - CodeGen: convert some const char * to StringRef

2016-05-15 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon May 16 00:06:49 2016 New Revision: 269630 URL: http://llvm.org/viewvc/llvm-project?rev=269630&view=rev Log: CodeGen: convert some const char * to StringRef Convert some use of const char * to StringRef. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified:

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

2016-05-15 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 57316. etienneb added a comment. nits: indent http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp clang-tidy/modernize/UseNullptrCheck.cpp clang-tidy/performance/FasterStringFindCheck.cpp clang-tidy/readabil

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57315. hintonda added a comment. - Fix some function names. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoe

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

2016-05-15 Thread Etienne Bergeron via cfe-commits
etienneb updated this revision to Diff 57314. etienneb marked an inline comment as done. etienneb added a comment. rebase over trunk. matchers are lifted to ASTMatchers. http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp clang-tidy/modernize/UseNull

r269625 - Make this SourceLocation getter const LLVM_READONLY like others in the same file.

2016-05-15 Thread Nick Lewycky via cfe-commits
Author: nicholas Date: Sun May 15 21:46:07 2016 New Revision: 269625 URL: http://llvm.org/viewvc/llvm-project?rev=269625&view=rev Log: Make this SourceLocation getter const LLVM_READONLY like others in the same file. Modified: cfe/trunk/include/clang/AST/StmtObjC.h Modified: cfe/trunk/inclu

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

2016-05-15 Thread Xiuli PAN via cfe-commits
pxli168 added a comment. Comment at: lib/Headers/opencl-c.h:9110 @@ +9109,3 @@ + */ +float __const_func remainder(float x, float y); +float2 __const_func remainder(float2 x, float2 y); Anastasia wrote: > Overloadable here and in other places too? It seems macro

r269623 - Simple visualization of expressions

2016-05-15 Thread Mike Spertus via cfe-commits
Author: mps Date: Sun May 15 20:36:09 2016 New Revision: 269623 URL: http://llvm.org/viewvc/llvm-project?rev=269623&view=rev Log: Simple visualization of expressions While more could be done, showing the type is a lot better than what is there now. Modified: cfe/trunk/utils/ClangVisualizers

r269622 - [AVX512] Use correct types in test case.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 20:09:19 2016 New Revision: 269622 URL: http://llvm.org/viewvc/llvm-project?rev=269622&view=rev Log: [AVX512] Use correct types in test case. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c URL: http://

r269621 - [X86] Remove bad cast from the 'int' return type of __builtin_ia32_kortestchi to '__mask16' before return in an 'int' intrinsic.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 20:09:16 2016 New Revision: 269621 URL: http://llvm.org/viewvc/llvm-project?rev=269621&view=rev Log: [X86] Remove bad cast from the 'int' return type of __builtin_ia32_kortestchi to '__mask16' before return in an 'int' intrinsic. Modified: cfe/trunk/lib/Heade

r269620 - [AVX512] Fix bad typecasts on return value for 512-bit integer byte/word compare builtins.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 19:51:06 2016 New Revision: 269620 URL: http://llvm.org/viewvc/llvm-project?rev=269620&view=rev Log: [AVX512] Fix bad typecasts on return value for 512-bit integer byte/word compare builtins. Modified: cfe/trunk/lib/Headers/avx512bwintrin.h Modified: cfe/tru

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread Etienne Bergeron via cfe-commits
etienneb added inline comments. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:22 @@ +21,3 @@ +static StringRef +MakeDynamicExceptionString(const SourceManager &SM, + const CharSourceRange &FileMoveRange) { coding style: MakeDynami

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

2016-05-15 Thread Etienne Bergeron via cfe-commits
etienneb added inline comments. Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:35 @@ +34,3 @@ + cxxOperatorCallExpr(hasAnyArgument(ignoringImpCasts(declRefExpr(BasicStringType))), + hasOverloadedOperatorName("+")); + --

[PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

2016-05-15 Thread Felix Berger via cfe-commits
flx created this revision. flx added reviewers: alexfh, sbenza. flx added a subscriber: cfe-commits. flx set the repository for this revision to rL LLVM. Make check more useful in the following two cases: 1. The parameter is passed by non-const value, has a non-deleted move constructor and is on

r269619 - [X86] Add immediate range checks for many of the builtins.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 17:18:00 2016 New Revision: 269619 URL: http://llvm.org/viewvc/llvm-project?rev=269619&view=rev Log: [X86] Add immediate range checks for many of the builtins. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp cfe/trunk/test/CodeGen/avx512vl-builtins.c Modifi

r269618 - [AVX512] Immediate argument for PALIGNR builtin should be an ICE./

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 17:17:57 2016 New Revision: 269618 URL: http://llvm.org/viewvc/llvm-project?rev=269618&view=rev Log: [AVX512] Immediate argument for PALIGNR builtin should be an ICE./ Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/B

r269617 - [AVX512] Add intrinsics for 512-bit insertf32x8/insertf32x4/inserti32x4.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 16:26:20 2016 New Revision: 269617 URL: http://llvm.org/viewvc/llvm-project?rev=269617&view=rev Log: [AVX512] Add intrinsics for 512-bit insertf32x8/insertf32x4/inserti32x4. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def cfe/trunk/lib/Headers/avx5

r269612 - [AVX512] Move unary negations to the left side of typecasts to specific vector type. The __m128/__m256/__m512 types should be treated more opaquely and not have any operations performed on t

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 15:10:03 2016 New Revision: 269612 URL: http://llvm.org/viewvc/llvm-project?rev=269612&view=rev Log: [AVX512] Move unary negations to the left side of typecasts to specific vector type. The __m128/__m256/__m512 types should be treated more opaquely and not have a

r269613 - [AVX512] Mark some integer builtin arguments that go to immediates in final instructions as an ICE.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 15:10:06 2016 New Revision: 269613 URL: http://llvm.org/viewvc/llvm-project?rev=269613&view=rev Log: [AVX512] Mark some integer builtin arguments that go to immediates in final instructions as an ICE. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r269610 - [AVX512] Fix an intrinsic that was passing -2 as a mask instead of -1.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 15:09:58 2016 New Revision: 269610 URL: http://llvm.org/viewvc/llvm-project?rev=269610&view=rev Log: [AVX512] Fix an intrinsic that was passing -2 as a mask instead of -1. Modified: cfe/trunk/lib/Headers/avx512bwintrin.h Modified: cfe/trunk/lib/Headers/avx512

r269611 - [AVX512] Use the correct mask type in an intrinsic.

2016-05-15 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sun May 15 15:10:00 2016 New Revision: 269611 URL: http://llvm.org/viewvc/llvm-project?rev=269611&view=rev Log: [AVX512] Use the correct mask type in an intrinsic. Modified: cfe/trunk/lib/Headers/avx512erintrin.h Modified: cfe/trunk/lib/Headers/avx512erintrin.h URL: ht

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda added a comment. I think this is now ready for review. Thanks again for your patience... http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57305. hintonda added a comment. - A bit more refactoring and cleanup. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/moder

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57301. hintonda added a comment. - Added asserts for indexes into Tokens array. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-t

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57299. hintonda added a comment. - Make helper functions static. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/U

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-15 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57298. hintonda added a comment. - Complete refactor http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/UseNoexceptCh

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

2016-05-15 Thread Bittner Barni via cfe-commits
bittnerbarni updated this revision to Diff 57294. bittnerbarni added a comment. Sorry for uploading 2 line long diffs. I uploaded the whole diff now. http://reviews.llvm.org/D20196 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientStringAdditionCheck.cpp clang