rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: rsmith
Date: Fri May 13 01:47:56 2016
New Revision: 269398
URL: http://llvm.org/viewvc/llvm-project?rev=269398&view=rev
Log:
Add support for derived class special members hiding functions brought in from
a base class via a using-declaration. If a class has a using-declaration
declaring eit
Author: rsmith
Date: Fri May 13 01:42:55 2016
New Revision: 269397
URL: http://llvm.org/viewvc/llvm-project?rev=269397&view=rev
Log:
Extend this test to also be valid in C++14.
Modified:
cfe/trunk/test/SemaCXX/constexpr-nqueens.cpp
Modified: cfe/trunk/test/SemaCXX/constexpr-nqueens.cpp
URL:
On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: filcab
> Date: Thu May 12 11:51:36 2016
> New Revision: 269309
>
> URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev
> Log:
> [ubsan] Add -fsanitize-undefined-strip-path-com
etienneb added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:42
@@ -27,3 +41,3 @@
llvm::Optional isExpensiveToCopy(QualType Type, ASTContext &Context) {
if (Type->isDependentType())
You're right too.
But, it's possible to fix these prototypes:
etienneb created this revision.
etienneb added a reviewer: rsmith.
etienneb added a subscriber: cfe-commits.
Add some missing const qualifiers to AstContext.
The ASTContext can't be modified with accessors.
There is no behavior change. This patch is cleanup only.
http://reviews.llvm.org/D20226
etienneb added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:22
@@ -20,2 +21,3 @@
+
bool classHasTrivialCopyAndDestroy(QualType Type) {
auto *Record = Type->getAsCXXRecordDecl();
My bad! I didn't saw the file change when reading. Forget about it
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269389: [clang-tidy] -
PerformanceUnnecesaryCopyInitialization - only trigger for… (authored by flx).
Changed prior to commit:
http://reviews.llvm.org/D19865?vs=56573&id=57130#toc
Repository:
rL LLVM
Author: flx
Date: Thu May 12 21:47:56 2016
New Revision: 269389
URL: http://llvm.org/viewvc/llvm-project?rev=269389&view=rev
Log:
[clang-tidy] - PerformanceUnnecesaryCopyInitialization - only trigger for decl
stmts with single VarDecl.
Summary: This fixes bug: https://llvm.org/bugs/show_bug.cgi?
flx added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:24
@@ -20,2 +23,3 @@
+
bool classHasTrivialCopyAndDestroy(QualType Type) {
auto *Record = Type->getAsCXXRecordDecl();
etienneb wrote:
> Should this be lifted to 'type_traits' ?
>
>
> The
flx updated this revision to Diff 57129.
flx marked 5 inline comments as done.
http://reviews.llvm.org/D20170
Files:
clang-tidy/utils/TypeTraits.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269385: [ObjC][CodeGen] Remove an assert that is no longer
correct. (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D20045?vs=57111&id=57125#toc
Repository:
rL LLVM
http://r
etienneb updated this revision to Diff 57124.
etienneb added a comment.
nit: indentation
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests
Author: ahatanak
Date: Thu May 12 20:21:23 2016
New Revision: 269385
URL: http://llvm.org/viewvc/llvm-project?rev=269385&view=rev
Log:
[ObjC][CodeGen] Remove an assert that is no longer correct.
clang asserts when compiling the following code because r231508 made
changes to promote constant tempo
etienneb added a comment.
In http://reviews.llvm.org/D19871#428997, @jroelofs wrote:
> Drive-by thought: I think it would be useful to be able to match implicit
> casts separately from explicit casts when using this new matcher.
Jonathan, I think what you are asking for is already supported.
I
etienneb updated this revision to Diff 57123.
etienneb added a comment.
add unittest
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/AST
Author: rsmith
Date: Thu May 12 18:45:49 2016
New Revision: 269382
URL: http://llvm.org/viewvc/llvm-project?rev=269382&view=rev
Log:
Preserve the FoundDecl properly in constructor overload resolution. No
functionality change; this information is not yet in use.
Modified:
cfe/trunk/include/cla
rtrieu added inline comments.
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
-if (Same) {
+if (Same && FromTD) {
OS << "template " << FromTD->getNameAsString();
apelete wrote:
> rtrieu wrote:
> > dblaikie wrote:
> > > Should this
rjmccall added a comment.
LGTM, thanks.
http://reviews.llvm.org/D20045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 57111.
ahatanak added a comment.
Thanks, I updated the comment in the new patch.
http://reviews.llvm.org/D20045
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenObjCXX/arc-cxx11-init-list.mm
Index: test/CodeGenObjCXX/arc-cxx11-init-list.mm
==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269371: Fix Clang-tidy modernize-use-bool-literals in
generated code. (authored by eugenezelenko).
Changed prior to commit:
http://reviews.llvm.org/D20213?vs=57106&id=57110#toc
Repository:
rL LLVM
h
Author: eugenezelenko
Date: Thu May 12 17:27:08 2016
New Revision: 269371
URL: http://llvm.org/viewvc/llvm-project?rev=269371&view=rev
Log:
Fix Clang-tidy modernize-use-bool-literals in generated code.
Reduce space in empty constructors and between data members and first public
section.
Fix som
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:365
@@ +364,3 @@
+ // If the global variable already has an initializer, there is no need to
+ // emit code for initialization or push a cleanup.
+ if (Var->hasInitializer())
As we d
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
http://reviews.llvm.org/D20213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: rsmith
Date: Thu May 12 17:16:28 2016
New Revision: 269367
URL: http://llvm.org/viewvc/llvm-project?rev=269367&view=rev
Log:
Refactor constant expression evaluation of CXXConstructExpr to reduce
duplication between array and class initialization.
Modified:
cfe/trunk/lib/AST/ExprConst
Eugene.Zelenko updated this revision to Diff 57106.
Eugene.Zelenko added a comment.
Implement Hans' suggestion.
Repository:
rL LLVM
http://reviews.llvm.org/D20213
Files:
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/TableGen/ClangAttrEmitter.cpp
amccarth added a comment.
Are there any remaining concerns with this patch? Is everyone satisfied with
the performance numbers?
http://reviews.llvm.org/D20136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
hintonda added inline comments.
Comment at: clang-tidy/utils/LexerUtils.cpp:38
@@ -37,1 +37,3 @@
+SmallVector ParseTokens(const ASTContext &Context,
+ const SourceManager &Sources,
I regenerated the diff -- the last few arc diff
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
Drive-by thought: I think it would be useful to be able to match implicit casts
separately from explicit casts when using this new matcher.
http://reviews.llvm.org/D19871
___
cfe-comm
hintonda updated this revision to Diff 57103.
hintonda added a comment.
Regenerated diff to make sure I pick up all changed files.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.c
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:99
@@ +98,3 @@
+ if (Tok.is(tok::l_paren)) {
+Tok = getPreviousNonCommentToken(Context, Tok.getLocation());
+found = std::string(GetText(Tok, SM)) + "(true)";
---
etienneb updated this revision to Diff 57101.
etienneb marked an inline comment as done.
etienneb added a comment.
regenerate doc
http://reviews.llvm.org/D19871
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/AST
etienneb added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:98
@@ +97,3 @@
+ const auto *FuncDecl = Result.Nodes.getNodeAs("functionDecl");
+ if (!FuncDecl)
+return;
I'm not saying to use 'const *FuncDecl', but 'const auto*'
==
hintonda added inline comments.
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:97
@@ +96,3 @@
+void UseNoexceptCheck::check(const MatchFinder::MatchResult &Result) {
+ auto FuncDecl = Result.Nodes.getNodeAs("functionDecl");
+ if (!FuncDecl)
etienneb wrote
Author: etienneb
Date: Thu May 12 15:58:56 2016
New Revision: 269347
URL: http://llvm.org/viewvc/llvm-project?rev=269347&view=rev
Log:
[AST] Move operations enum to a definition file.
Summary:
This patch moves the enum definitions to a definition (.def) file.
These modifications provide way to l
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me, but please make sure you don't inject Windows line
endings into the real repository.
Cheers.
Tim.
Repository:
rL LLVM
http://reviews.llvm.org/D
hintonda updated this revision to Diff 57097.
hintonda added a comment.
- Addressed a few comments for clarity/readability.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
cl
etienneb added a subscriber: etienneb.
Comment at: clang-tidy/misc/UnnecessaryMutableCheck.cpp:38
@@ +37,3 @@
+
+ void RunSearch(Decl *Declaration) {
+auto *Body = Declaration->getBody();
nit: Decl *Declaration -> const Decl *Declaration
and other visitor fu
etienneb added a subscriber: etienneb.
Comment at: clang-tidy/modernize/UseUsingCheck.cpp:32
@@ +31,3 @@
+
+ diag(MatchedDecl->getLocStart(), "use using instead of typedef")
+ << FixItHint::CreateReplacement(
I think 'using' should be quote.
This message is
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269341: [clang-tidy] Adds modernize-avoid-bind check
(authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D16962?vs=57067&id=57095#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: jbcoe
Date: Thu May 12 15:06:04 2016
New Revision: 269341
URL: http://llvm.org/viewvc/llvm-project?rev=269341&view=rev
Log:
[clang-tidy] Adds modernize-avoid-bind check
Summary:
This patch adds a check that replaces std::bind with a lambda.
Not yet working for member functions.
Reviewer
ahatanak added a comment.
In http://reviews.llvm.org/D20045#425903, @manmanren wrote:
> After r231508 made changes to promote constant temporaries to globals, the
> assert fires when a std::initializer_list is constructed using Objective-C
> string literals.
>
> --> Can you explain the code pat
etienneb added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:24
@@ -20,2 +23,3 @@
+
bool classHasTrivialCopyAndDestroy(QualType Type) {
auto *Record = Type->getAsCXXRecordDecl();
Should this be lifted to 'type_traits' ?
The same function exist
etienneb added a subscriber: etienneb.
Comment at: clang-tidy/utils/TypeTraits.cpp:35
@@ +34,3 @@
+return false;
+ for (const CXXConstructorDecl *Constructor : Record->ctors()) {
+if (Constructor->isCopyConstructor() && Constructor->isDeleted())
aaron.bal
Author: etienneb
Date: Thu May 12 14:51:18 2016
New Revision: 269334
URL: http://llvm.org/viewvc/llvm-project?rev=269334&view=rev
Log:
[Tooling] Fix broken dependency for shared build
Summary:
There virtual destructor can't be found and cause a compilation error
on a shared build.
To repro: [Rel
etienneb added a subscriber: etienneb.
etienneb added a comment.
drive by
Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:40
@@ +39,3 @@
+ unsigned &Len) {
+ SourceManager &SM = *Result.SourceManager;
+ const ASTContext &Context = *Resul
On Mon, May 2, 2016 at 1:17 PM, Hal Finkel wrote:
> - Original Message -
> > From: "David Blaikie"
> > To: reviews+d19708+public+e9ddc42503732...@reviews.llvm.org, "Hal
> Finkel"
> > Cc: "Richard Smith" , "Adrian Prantl" <
> apra...@apple.com>, "Duncan P. N. Exon Smith"
> > , "Eric Chri
iid_iunknown created this revision.
iid_iunknown added reviewers: rengolin, t.p.northover, compnerd.
iid_iunknown added subscribers: cfe-commits, asl.
iid_iunknown set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.
Clang does not detect `aapcs-vfp` for t
ahatanak updated this revision to Diff 57088.
ahatanak added a comment.
Add a comment explaining why it is OK to return early if the global variable
has an initializer.
http://reviews.llvm.org/D20045
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenObjCXX/arc-cxx11-init-list.mm
Index: test/CodeG
bader added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:64
@@ +63,3 @@
+OPENCLEXT_INTERNAL(cl_khr_initialize_memory, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_spir, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U)
Minimum requ
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
etienneb added a comment.
note: To repro, you must compile the tests.
% ninja check-all
http://reviews.llvm.org/D20218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
etienneb created this revision.
etienneb added a reviewer: alexfh.
etienneb added a subscriber: cfe-commits.
There virtual destructor can't be found and cause a compilation error
on a shared build.
To repro: [Release + Shared]
```
-DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
```
Which produ
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/CodeGenOpenCL/as_type.cl:6
@@ +5,3 @@
+
+//CHECK: define spir_func <3 x i8> @f1(<4 x i8> %[[x:.*]])
+//CHECK: %[[astype:.*]] = shufflevector <4 x i8> %[[x
etienneb added a subscriber: etienneb.
etienneb added a comment.
drive-by, some nits.
Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:31
@@ +30,3 @@
+void InefficientStringAdditionCheck::registerMatchers(MatchFinder *Finder) {
+ auto BasicStringType =
has
Author: bruno
Date: Thu May 12 14:13:07 2016
New Revision: 269327
URL: http://llvm.org/viewvc/llvm-project?rev=269327&view=rev
Log:
[VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup
Reapply r269100 and r269270, reverted due to
https://llvm.org/bugs/show_bug.cgi?id=27725.
Author: bruno
Date: Thu May 12 14:13:04 2016
New Revision: 269326
URL: http://llvm.org/viewvc/llvm-project?rev=269326&view=rev
Log:
[Unittests] Reverse the order of arguments for correct debug output
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50
@@ +49,2 @@
+
+if the :option:`ReplacementString` option is set to `NOEXCEPT`.
I'll get it eventually... ;-)
http://reviews.llvm.org/D18575
_
hintonda updated this revision to Diff 57080.
hintonda added a comment.
- Add :option: prefix for clarity.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderniz
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:50
@@ +49,2 @@
+
+if the `ReplacementString` option is set to `NOEXCEPT`.
Actually :option: still need to prepend `ReplacementString`.
http://reviews.llvm.org/D18
hintonda updated this revision to Diff 57078.
hintonda added a comment.
- Fix quote problem in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/UseN
vmiklos created this revision.
vmiklos added subscribers: cfe-commits, klimek.
This more general check could have prevented the specific problem
"getSourceOrder() == -1" guards.
http://reviews.llvm.org/D20216
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRLocFinder.cpp
clang-rename
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintai
hintonda added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintaining s
rsmith added a comment.
In http://reviews.llvm.org/D20207#428486, @aaron.ballman wrote:
> Generally, I think this looks good. It will definitely help with AST
> matchers. Richard, do you have any problems with this approach?
Not at all. This would be a nice improvement even if it didn't also p
mprobst added a comment.
PTAL.
Comment at: lib/Format/SortJavaScriptImports.cpp:162
@@ +161,3 @@
+std::string ImportsText;
+for (unsigned i = 0, e = Indices.size(); i != e; ++i) {
+ JsImportExport ImpExp = Imports[Indices[i]];
djasper wrote:
> Is th
mprobst updated this revision to Diff 57073.
mprobst marked 9 inline comments as done.
mprobst added a comment.
- extract TokenAnalyzer.h and SortJavaScriptImports.h/cpp
- clean up imports/
- includes
- address review comments
- pull out implementations from header files.
http://reviews.llvm.org
a.makarov updated this revision to Diff 57071.
a.makarov added a comment.
Renamed option 'DefaultMSCallingConv' into 'DefaultCallingConv' and enum
'DefaultMSCallingConvention' into 'DefaultCallingConvention'.
http://reviews.llvm.org/D20171
Files:
include/clang/Basic/LangOptions.def
include
rsmith added a comment.
Rather than threading through a new flag, can you test the existing `TUKind`
field?
http://reviews.llvm.org/D19815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.rst:32
@@ +31,3 @@
+``noexcept(false)``. Additinally, users can also use
+:option:``ReplacementString`` to specify a macro to use instead of
+``noexcept``. This is useful when maintai
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I've been trying to say that ABI compatibility is not the same thing as
generating the same set of exported symbols, but it really doesn't matter. If
MSVC 2013 and 2015 are not ABI compatible
hintonda updated this revision to Diff 57070.
hintonda added a comment.
- Added 's around keywords in docs.
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/moderni
jbcoe updated this revision to Diff 57067.
jbcoe added a comment.
update diff to allow arc to apply patch.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cpp
clang-tidy/modernize/AvoidBindCheck.h
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moderni
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:197
@@ +196,3 @@
+
+ Replaces dynamic exception specifications with noexcept.
+
Please highlight noexcept with ``.
Comment at: docs/clang-tidy/checks/modernize-use-noexcept.
mprobst updated this revision to Diff 57066.
mprobst added a comment.
- simplify logic by parsing forward, reduce complexity to O(n) from O(n^2)
http://reviews.llvm.org/D20208
Files:
lib/Format/Format.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
hintonda updated this revision to Diff 57065.
hintonda added a comment.
- Renamed private helper method
http://reviews.llvm.org/D18575
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptCheck.cpp
clang-tidy/modernize/U
majnemer added inline comments.
Comment at: include/clang/Basic/LangOptions.def:175
@@ -174,2 +174,3 @@
ENUM_LANGOPT(MSPointerToMemberRepresentationMethod,
PragmaMSPointersToMembersKind, 2, PPTMK_BestCase, "member-pointer
representation method")
+ENUM_LANGOPT(DefaultMSCallingCo
apelete added inline comments.
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
-if (Same) {
+if (Same && FromTD) {
OS << "template " << FromTD->getNameAsString();
rtrieu wrote:
> dblaikie wrote:
> > Should this be a condition, or
Anastasia added inline comments.
Comment at: lib/Sema/SemaType.cpp:2055
@@ -2054,3 +2054,3 @@
- return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser,
- S.LangOpts.GNUMode).isInvalid();
+ return S
+ .VerifyIntege
djasper added inline comments.
Comment at: lib/Format/Format.cpp:21
@@ -19,1 +20,3 @@
#include "TokenAnnotator.h"
+#include "FormatTokenLexer.h"
+#include "TokenAnalyzer.h"
Use clang-format to fix the order :-)
Comment at: lib/Format/FormatToken
Anastasia added a comment.
In http://reviews.llvm.org/D18369#424617, @yaxunl wrote:
> In http://reviews.llvm.org/D18369#424347, @pxli168 wrote:
>
> > In http://reviews.llvm.org/D18369#422367, @yaxunl wrote:
> >
> > > In http://reviews.llvm.org/D18369#421963, @pxli168 wrote:
> > >
> > > > If we wa
Author: filcab
Date: Thu May 12 11:51:36 2016
New Revision: 269309
URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev
Log:
[ubsan] Add -fsanitize-undefined-strip-path-components=N
Summary:
This option allows the user to control how much of the file name is
emitted by UBSan. Tuning this
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269309: [ubsan] Add
-fsanitize-undefined-strip-path-components=N (authored by filcab).
Changed prior to commit:
http://reviews.llvm.org/D19666?vs=56396&id=57063#toc
Repository:
rL LLVM
http://review
a.makarov updated this revision to Diff 57062.
a.makarov added a comment.
Thanks for the review! I've updated the patch, please take a look.
Modifications:
- the dependency from MS compatibility mode is removed;
- the option is renamed into '-fdefault-calling-conv' (since it's not in MS
compatib
etienneb marked an inline comment as done.
etienneb added a comment.
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @file OperationKinds.def
+///
aaron.ballman wrote:
> Do we use @file doxygen comments usually? I'm not certain if I've
hans added inline comments.
Comment at: utils/TableGen/ClangAttrEmitter.cpp:338
@@ -310,1 +337,3 @@
+OS << "\n\n static const " << getType() << " Default" <<
getUpperName()
+ << " = " << Default << ";";
}
Everything up to the " = " part is
djasper added a comment.
I experimented a bit. What do you think of this?
Comment at: lib/Format/Format.cpp:1822
@@ +1821,3 @@
+cleanupRight(Line->First, Line->Last, tok::comma, tok::comma);
+checkConstructorInitList(*Line);
+ }
You could tu
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:501
@@ -500,1 +500,3 @@
def err_builtin_needs_feature : Error<"%0 needs target feature %1">;
+def err_builtin_needs_opencl_version
+: Error<"%0 needs OpenCL version %1%select{| or above}2"
wristow added a comment.
Ping
http://reviews.llvm.org/D19815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Sure. Committed in r269305!
Thanks!
http://reviews.llvm.org/D19780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stulova
Date: Thu May 12 11:28:25 2016
New Revision: 269305
URL: http://llvm.org/viewvc/llvm-project?rev=269305&view=rev
Log:
[OpenCL] Output OpenCL version in diagnostics.
Diagnostics should note version dependent issues by giving
a hint about current version being compiled for.
This pa
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: hans, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Reduce space in empty constructors and between data members and first public
section.
Fix som
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/performance-inefficient-string-addition.rst:8
@@ +7,3 @@
+--
+This ch
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Generally, I think this looks good. It will definitely help with AST matchers.
Richard, do you have any problems with this approach?
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @
alexfh added inline comments.
Comment at: clang-tidy/utils/TypeTraits.cpp:22
@@ +21,3 @@
+
+using namespace ::clang::ast_matchers;
+
Now seems to be unused.
http://reviews.llvm.org/D20170
___
cfe-commits mailing lis
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
http://reviews.llvm.org/D20203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
bkramer requested changes to this revision.
bkramer added a comment.
This revision now requires changes to proceed.
This needs more tests (check that using stuff from a different namespace in
namespace scope still works). It's also better written as a unit test against
the in-memory database, th
etienneb marked 3 inline comments as done.
etienneb added a comment.
This patch has been modified to support dynamic matchers.
It rely on : http://reviews.llvm.org/D20207
Comments?
Comment at: lib/ASTMatchers/Dynamic/Marshallers.h:102
@@ +101,3 @@
+ static clang::CastKind getC
mprobst created this revision.
mprobst added reviewers: djasper, bkramer.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Simply looking at the final text greatly simplifies the algorithm and also
fixes a reported issue. This requires duplicating the "actual encoding wi
1 - 100 of 146 matches
Mail list logo
