Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

On Tue, May 10, 2016 at 11:14 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Sean, > > > So sorry! It had gone quiet for a few hours and I wanted to avoid > leaving it > > red any longer. > > No problem, the priority is to get bot greens! > > > Does any platform define a guaranteed

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Hi Sean, > So sorry! It had gone quiet for a few hours and I wanted to avoid leaving it > red any longer. No problem, the priority is to get bot greens! > Does any platform define a guaranteed directory iteration order? I feel like > depending on it in the first place is unwise (or maybe I'm mis

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

On Tue, May 10, 2016 at 9:49 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Thanks Sean, > > I was about to ask for help and try a 4th attempt, as you noted after > 3 attempts I was not yet able to make this work on windows though... > So sorry! It had gone quiet for a few hours and

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Thanks Sean, I was about to ask for help and try a 4th attempt, as you noted after 3 attempts I was not yet able to make this work on windows though... The new tests I added first failed on windows because looks like a missing "/" on the dir name forces "\\" to be generated while appending the fi

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Hi Bruno, I had to revert this in r269100 because it was looking like the bot was going to be left red overnight. Changes to this VFS code seem to have a trend of breaking on windows. Any idea why that is? I can understand things breaking on windows when writing low-level parts of an FS abstracti

Re: [PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5452 @@ +5451,3 @@ + // in there. + for (const auto *C : D.getClausesOfKind()) { +for (const auto *D : C->varlists()) { I think this is too greedy. You're rescanning list of firstpriv

r269160 - Hopefully bring llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast back to life

Author: silvas Date: Tue May 10 23:04:59 2016 New Revision: 269160 URL: http://llvm.org/viewvc/llvm-project?rev=269160&view=rev Log: Hopefully bring llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast back to life Bruno made a couple valiant attempts but the bot is still red. This reverts r269100 (

Re: [PATCH] D20131: Fixed crash during code completion in file included within declaration

rsmith added a comment. Please add a test to test/CodeCompletion. Comment at: lib/Lex/PPLexerChange.cpp:380-382 @@ -379,3 +379,5 @@ CurLexer->FormTokenWithChars(Result, CurLexer->BufferEnd, tok::eof); CurLexer.reset(); +if (CurLexerKind == CLK_Lexer) +

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne added a comment. ping http://reviews.llvm.org/D15421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

rsmith added a comment. This looks reasonable, but please add a test. http://reviews.llvm.org/D20132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20134: [libclang] Fixed bug where ranges in spelling locations (in macro expansions) would get mangled

rsmith added a comment. I agree that this looks wrong. Does test/Index/cindex-on-invalid.m still pass with this change? (See http://reviews.llvm.org/rL129872 in which it was added.) It looks like the problem is that we lose the information about whether we're supposed to be pointing to the sta

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

pxli168 added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntegerC

Re: [PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

rsmith added a comment. Ugh. Yes. I suppose it's too late to make this actually do the right thing. @akyrtzi, what do you think? Please add a test for this (see unittests/libclang/LibclangTest.cpp). http://reviews.llvm.org/D20125 ___ cfe-commits m

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

pxli168 added inline comments. Comment at: test/SemaOpenCL/to_addr_builtin.cl:25 @@ +24,3 @@ + glob = to_global(con); +#if __OPENCL_C_VERSION__ < CL_VERSION_2_0 + // expected-error@-2{{'to_global' needs OpenCL version 2.0 or above}} yaxunl wrote: > pxli168 wrote

r269154 - [Sema] Fix value-dependent enable_if bug.

Author: gbiv Date: Tue May 10 20:38:27 2016 New Revision: 269154 URL: http://llvm.org/viewvc/llvm-project?rev=269154&view=rev Log: [Sema] Fix value-dependent enable_if bug. This patch fixes a bug where we would assume all value-dependent enable_if conditions give successful results. Instead, we

Re: [PATCH] D20130: Fix enable_if evaluation in value-dependent contexts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269154: [Sema] Fix value-dependent enable_if bug. (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D20130?vs=56786&id=56849#toc Repository: rL LLVM http://reviews.llvm.org/D20130

Re: r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

The review and commit message of r269116 both stated this was disabled by default because Reid hadn't evaluated the impact yet. I just fixed the glitch. :-) On Tue, May 10, 2016 at 6:00 PM, David Majnemer via cfe-commits wrote: > Er, why? Why not just disable this warning in chromium? > Clangs di

Re: r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

I asked Reid the same thing on the review. He said he wanted to try the warning in practice first and maybe polish it a bit before enabling it. (It was supposed to land in disabled state.) On Tue, May 10, 2016 at 9:00 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Er, w

Re: r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

Er, why? Why not just disable this warning in chromium? Clangs diagnostics wouldn't have developed as well as they have if we took this approach to all warnings. On Tuesday, May 10, 2016, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Tue May 10 19:49:20

Re: r269116 - Add -Wcast-calling-convention to warn when casting away calling conventions

On Tue, May 10, 2016 at 2:00 PM, Reid Kleckner via cfe-commits wrote: > Author: rnk > Date: Tue May 10 16:00:03 2016 > New Revision: 269116 > > URL: http://llvm.org/viewvc/llvm-project?rev=269116&view=rev > Log: > Add -Wcast-calling-convention to warn when casting away calling conventions > > Summ

r269148 - Disable -Wcast-calling-convention by default (follow-up to r269116)

Author: hans Date: Tue May 10 19:49:20 2016 New Revision: 269148 URL: http://llvm.org/viewvc/llvm-project?rev=269148&view=rev Log: Disable -Wcast-calling-convention by default (follow-up to r269116) Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/test/Sema/calling

Re: [PATCH] D20034: [CUDA] Only __shared__ variables can be static local on device side.

jlebar added a comment. This patch regresses Eigen, because it raises an error even on host+device functions. Repository: rL LLVM http://reviews.llvm.org/D20034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

Ping. Thanks again, Hal - Original Message - > From: "Hal Finkel via cfe-commits" > To: "David Blaikie" > Cc: "Jun Bum Lim" , "Richard Smith" > , "cfe-commits" > , > reviews+d19708+public+e9ddc42503732...@reviews.llvm.org > Sent: Monday, May 2, 2016 3:17:22 PM > Subject: Re: [PATCH] D

Re: [PATCH] D20141: Check for nullptr argument.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. OK, if the function explicitly says it accepts null values and if we check elsewhere in the function, I'm personally OK adding the checks. http://reviews.llvm.org/D20141 __

Re: [PATCH] D20141: Check for nullptr argument.

If you have a check that doesn't have a test/is never triggered - simple thing to do is just make it an assert & run some testing of your own (selfhost, etc) then if there's insufficient evidence that it's needed, ship it and wait until it fails on a buildbot, etc. Then reduce the test case and che

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

probinson added a subscriber: probinson. probinson added a comment. In http://reviews.llvm.org/D20136#426586, @amccarth wrote: > now using wide-chars for WinAPI calls, Dōmo arigatō gozaimashita! http://reviews.llvm.org/D20136 ___ cfe-commits mail

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth marked 4 inline comments as done. Comment at: lib/Driver/MSVCToolChain.cpp:478 @@ +477,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeW(ClExeWide.c_str(), + nullptr); Yes, it looks in the e

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth updated this revision to Diff 56833. amccarth marked an inline comment as done. amccarth added a comment. Addressed most comments: now using wide-chars for WinAPI calls, made getMSVCVersionFromExe a virtual method, removed extraneous typo-correction. http://reviews.llvm.org/D20136 Fil

Re: [PATCH] D20141: Check for nullptr argument.

tra added a comment. I've never seen it triggered. Fix is based on the comment above the function that D==nullptr is acceptable and the fact that we are checking D in other places in this function. Two cases where nullptr D is passed explicitly has something to do with -fblocks, but that does

Re: [PATCH] D20141: Check for nullptr argument.

jlebar added a comment. Can we have a test? http://reviews.llvm.org/D20141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20141: Check for nullptr argument.

tra created this revision. tra added reviewers: jlebar, jordan_rose. tra added a subscriber: cfe-commits. GetOrCreateLLVMGlobal() accepts nullptr D, but in some cases we end up dereferencing it without checking if it's non-null. Fixes PR15492. http://reviews.llvm.org/D20141 Files: lib/CodeGe

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

rnk added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:41 @@ -40,1 +40,3 @@ + + #pragma comment(lib, "version.lib") #endif Personally, I think this is OK but I know Aaron Ballman and other people don't like using pragma comment lib. The alternative

[clang-tools-extra] r269135 - Disable IncludeFixerTests/IncludeFixer.NestedName for now. It doesn't pass for targeting win32. Investigating.

Author: chapuni Date: Tue May 10 17:46:32 2016 New Revision: 269135 URL: http://llvm.org/viewvc/llvm-project?rev=269135&view=rev Log: Disable IncludeFixerTests/IncludeFixer.NestedName for now. It doesn't pass for targeting win32. Investigating. Modified: clang-tools-extra/trunk/unittests/inc

Re: [PATCH] D20139: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.

tra added inline comments. Comment at: test/SemaCUDA/device-var-init.cu:7-11 @@ -6,9 +6,7 @@ // RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fcuda-is-device -std=c++11 \ -// RUN: -fno-threadsafe-statics -emit-llvm -o - %s | FileCheck %s -// RUN: %clang_cc1 -triple nvptx64-nvi

Re: [PATCH] D20140: [CUDA] Do not allow non-empty destructors for global device-side variables.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. lgtm, but I'd like Richard to sign off on this too. Comment at: lib/Sema/SemaDecl.cpp:10438 @@ -10437,1 +10437,3 @@ + // Also make sure that destructor, ifthere is one,

[PATCH] D20140: [CUDA] Do not allow non-empty destructors for global device-side variables.

tra created this revision. tra added reviewers: jlebar, rsmith, jingyue. tra added a subscriber: cfe-commits. According to Cuda Programming guide (v7.5, E2.3.1): > __device__, __constant__ and __shared__ variables defined in namespace > scope, that are of class type, cannot have a non-empty constr

r269133 - [VFS] One more unittest change to fix win10 buildbot

Author: bruno Date: Tue May 10 17:30:01 2016 New Revision: 269133 URL: http://llvm.org/viewvc/llvm-project?rev=269133&view=rev Log: [VFS] One more unittest change to fix win10 buildbot http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5110 Follow up from r2

Re: [PATCH] D20139: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Rubber stamp. http://reviews.llvm.org/D20139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D20139: [CUDA] Split device-var-init.cu tests into separate Sema and CodeGen parts.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. Codegen tests for device-side variable initialization are subset of test cases used to verify Sema's part of the job. Including CodeGenCUDA/device-var-init.cu from SemaCUDA makes it easier to keep both

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

etienneb updated this revision to Diff 56826. etienneb added a comment. nits http://reviews.llvm.org/D19941 Files: include/clang/Tooling/FixIt.h lib/Tooling/CMakeLists.txt lib/Tooling/FixIt.cpp unittests/Tooling/CMakeLists.txt unittests/Tooling/FixItTest.cpp Index: unittests/Tooling/

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

etienneb updated this revision to Diff 56825. etienneb marked 5 inline comments as done. etienneb added a comment. address alexfh comments http://reviews.llvm.org/D19941 Files: include/clang/Tooling/FixIt.h lib/Tooling/CMakeLists.txt lib/Tooling/FixIt.cpp unittests/Tooling/CMakeLists.tx

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:472 @@ +471,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr); + if (VersionSize == 0) { amccarth wrote: > majnemer wrote: > > Why not use the `GetFileVer

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

On Tue, May 10, 2016 at 6:09 PM, Adrian McCarthy via cfe-commits wrote: > amccarth added inline comments. > > > Comment at: lib/Driver/MSVCToolChain.cpp:472 > @@ +471,3 @@ > + > + const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), > nullptr); > + if (VersionSize

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:472 @@ +471,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr); + if (VersionSize == 0) { majnemer wrote: > Why not use the `GetFileVersionInfoSizeW` varia

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth added inline comments. Comment at: lib/Driver/MSVCToolChain.cpp:477 @@ +476,3 @@ + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize, + VersionBlock.data())) { thakis wrote: > W

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

majnemer added a subscriber: majnemer. Comment at: lib/Driver/MSVCToolChain.cpp:472 @@ +471,3 @@ + + const DWORD VersionSize = ::GetFileVersionInfoSizeA(ClExe.c_str(), nullptr); + if (VersionSize == 0) { Why not use the `GetFileVersionInfoSizeW` variant? http:

Re: [PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

thakis added a subscriber: thakis. Comment at: lib/Driver/MSVCToolChain.cpp:477 @@ +476,3 @@ + std::vector VersionBlock(VersionSize); + if (!::GetFileVersionInfoA(ClExe.c_str(), 0, VersionSize, + VersionBlock.data())) { We already sta

[PATCH] D20137: [PCH] Fixed bugs with preamble invalidation when files change (on Windows)

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. There were two bugs relating to remapped files, that are not specific to Windows but happen more often there: - When remapped files were changed, they would never cause the preamble'

[PATCH] D20136: Get default -fms-compatibility-version from cl.exe's version

amccarth created this revision. amccarth added a reviewer: rnk. amccarth added a subscriber: cfe-commits. `-fms-compatibility-version` was defaulting to 18 (VS 2013), which is a pain if your environment is pointing to version 19 (VS 2015) libraries. If cl.exe can be found, this patch uses its ve

r269118 - Wildcard away paths in fixit CHECKs in my last testcase

Author: rnk Date: Tue May 10 16:10:25 2016 New Revision: 269118 URL: http://llvm.org/viewvc/llvm-project?rev=269118&view=rev Log: Wildcard away paths in fixit CHECKs in my last testcase Oops. :( Modified: cfe/trunk/test/Sema/callingconv-cast.c Modified: cfe/trunk/test/Sema/callingconv-cast.

Re: [PATCH] D19871: Add an AST matcher for CastExpr kind

sbenza added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:78 @@ -77,2 +77,3 @@ // Need Variant/Parser fixes: + // hasCastKind // ofKind Is it registered or not? You add this comment, but also add the matcher in the registry below. h

[PATCH] D20134: [libclang] Fixed bug where ranges in spelling locations (in macro expansions) would get mangled

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. The end location of the range would be changed into its expansion location, but the beginning of the range would stay as a spelling location. This would lead to very weird ranges sp

Re: [PATCH] D17348: Add -Wcast-calling-convention to warn when casting away calling conventions

This revision was automatically updated to reflect the committed changes. Closed by commit rL269116: Add -Wcast-calling-convention to warn when casting away calling conventions (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D17348?vs=56802&id=56814#toc Repository: rL LLV

r269116 - Add -Wcast-calling-convention to warn when casting away calling conventions

Author: rnk Date: Tue May 10 16:00:03 2016 New Revision: 269116 URL: http://llvm.org/viewvc/llvm-project?rev=269116&view=rev Log: Add -Wcast-calling-convention to warn when casting away calling conventions Summary: This only warns on casts of the address of a function defined in the current TU. I

[PATCH] D20133: [OpenCL] Fix __builtin_astype for vec3 types.

yaxunl created this revision. yaxunl added reviewers: Anastasia, pxli168, bader. yaxunl added subscribers: cfe-commits, tstellarAMD. __builtin_astype does not generate correct LLVM IR for vec3 types. This patch inserts bitcasts to/from vec4 when necessary in addition to generating vector shuffle

[PATCH] D20132: [libclang] Add clang_getAllSkippedRanges function

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. This complements the `clang_getSkippedRanges` function which returns skipped ranges filtered by a specific file. This function is useful when all the ranges are desired (and a lot m

Re: [PATCH] D17348: Add -Wcast-calling-convention to warn when casting away calling conventions

rnk added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:294 @@ -293,2 +293,3 @@ def SelTypeCast : DiagGroup<"cast-of-sel-type">; +def CastCallingConvention : DiagGroup<"cast-calling-convention">; def FunctionDefInObjCContainer : DiagGroup<"function-def-in-

Re: [PATCH] D17348: Add -Wcast-calling-convention to warn when casting away calling conventions

rnk updated this revision to Diff 56802. rnk marked 3 inline comments as done. rnk added a comment. - address comments http://reviews.llvm.org/D17348 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp test/Sema/callingconv-cast.c Index: test/Sema/callingconv-cast.c =

Re: [PATCH] D18914: [clang-tidy] new readability-redundant-inline

mgehre updated this revision to Diff 56800. mgehre added a comment. Update for review comment: - Return Optional when looking for 'inline' - Add test that hides 'inline' in a macro http://reviews.llvm.org/D18914 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/Readabilit

[PATCH] D20131: Fixed crash during code completion in file included within declaration

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. When triggering code completion within a file that is included in the middle of a declaration in another file, clang would crash while parsing the code. This occurred with real-worl

Re: [PATCH] D18425: [Sema] Make enable_if act correctly with value dependent conditions/arguments

george.burgess.iv abandoned this revision. george.burgess.iv added a comment. Abandoning this; http://reviews.llvm.org/D20130 is our new approach. http://reviews.llvm.org/D18425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D20130: Fix enable_if evaluation in value-dependent contexts.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. This patch is meant to be applied instead of D18425, but is a new review because we're taking an entirely different approach. This patch makes us fail `enable_i

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

alexfh added inline comments. Comment at: include/clang/Tooling/Fixit.h:1 @@ +1,2 @@ +//===--- FixIt.h - FixIt Hint utilities -*- C++ -*-===// +// nit: s/FixIt Hint/FixItHint/, since this is a reference to the type. Comm

r269111 - Update clang for LLVM API change.

Author: pcc Date: Tue May 10 15:23:29 2016 New Revision: 269111 URL: http://llvm.org/viewvc/llvm-project?rev=269111&view=rev Log: Update clang for LLVM API change. Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp URL: http://llvm.org/viewvc/llvm-pr

r269108 - [VFS] Change unittest to try appeasing win10 buildbot

Author: bruno Date: Tue May 10 15:20:55 2016 New Revision: 269108 URL: http://llvm.org/viewvc/llvm-project?rev=269108&view=rev Log: [VFS] Change unittest to try appeasing win10 buildbot http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5103 Follow up from r

[PATCH] D20129: [libclang] Properly expose linkage spec cursors

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. All the groundwork for `CXCursor_LinkageSpec` already existed, but because of a missing case in a switch, cursors of that type were never actually created for linkage specifications

[PATCH] D20127: [libclang] Expose cursors for alias/weak attributes

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. This patch introduces `CXCursor_AliasAttr`/`CXCursor_WeakAttr` and `clang_getAliasTargetSpelling()` for inspecting alias attributes via libclang. http://reviews.llvm.org/D20127 Fil

Re: [PATCH] D19941: [tooling] FixItHint Tooling refactoring

etienneb updated this revision to Diff 56790. etienneb added a comment. more unittests http://reviews.llvm.org/D19941 Files: include/clang/Tooling/Fixit.h lib/Tooling/CMakeLists.txt lib/Tooling/Fixit.cpp unittests/Tooling/CMakeLists.txt unittests/Tooling/FixitTest.cpp Index: unittest

[PATCH] D20125: [libclang] Added clang_getRealSpellingLocation to compensate for clang_getSpellingLocation returning the expansion location

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. All the libclang functions for expanding a location, namely `clang_getExpansionLocation`, `clang_getPresumedLocation`, `clang_getInstantiationLocation`, and most surprisingly `clan

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

cameron314 created this revision. cameron314 added a reviewer: rsmith. cameron314 added a subscriber: cfe-commits. cameron314 set the repository for this revision to rL LLVM. This fixes, for example, libclang's `clang_getAllSkippedRanges` returning zero ranges after reparsing a translation unit.

Re: [PATCH] D19941: [clang-tidy] FixItHint Tooling refactoring

etienneb updated this revision to Diff 56781. etienneb marked 3 inline comments as done. etienneb added a comment. add unittests http://reviews.llvm.org/D19941 Files: include/clang/Tooling/Fixit.h lib/Tooling/CMakeLists.txt lib/Tooling/Fixit.cpp unittests/Tooling/CMakeLists.txt unitte

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath marked an inline comment as done. rmaprath added a comment. http://reviews.llvm.org/D20119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath updated this revision to Diff 56779. rmaprath added a comment. Address review comments by @rengolin: - Define and use `_LIBUNWIND_CONTEXT_SIZE` and `_LIBUNWIND_CURSOR_SIZE` macros http://reviews.llvm.org/D20119 Files: CMakeLists.txt include/__libunwind_config.h include/libunwind

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath added inline comments. Comment at: include/libunwind.h:49 @@ -48,1 +48,3 @@ struct unw_context_t { +#if defined(_LIBUNWIND_NATIVE_I386) + uint64_t data[8]; rengolin wrote: > Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or >

r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Author: bruno Date: Tue May 10 13:43:00 2016 New Revision: 269100 URL: http://llvm.org/viewvc/llvm-project?rev=269100&view=rev Log: [VFS] Reconstruct the VFS overlay tree for more accurate lookup The way we currently build the internal VFS overlay representation leads to inefficient path search a

r269099 - [WebAssembly] Reduce strictness of static destructor test

Author: dschuff Date: Tue May 10 13:35:31 2016 New Revision: 269099 URL: http://llvm.org/viewvc/llvm-project?rev=269099&view=rev Log: [WebAssembly] Reduce strictness of static destructor test It didn't work on non-asserts builds Modified: cfe/trunk/test/CodeGenCXX/static-destructor.cpp Modi

RE: [Clang] Convergent Attribute

> CUDA? In any case, I don't see how the restriction helps users, and the > attribute at the IR level has a well-defined meaning regardless. If a user > were to have a use case, they'd simply find the restriction arbitrary and > frustrating. Yes, CUDA was already considered as well. I just thin

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntege

Re: [PATCH] D19920: [libunwind][ARM] Improve unwinder stack usage on baremetal targets - part 1

rmaprath abandoned this revision. rmaprath added a comment. Superseded by http://reviews.llvm.org/D20119. http://reviews.llvm.org/D19920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [PATCH] D15674: [CodeGen] Fix assignments of inline layouts into the byref structure

vsk accepted this revision. vsk added a reviewer: vsk. vsk added a comment. This revision is now accepted and ready to land. Closing old review. http://reviews.llvm.org/D15674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D17299: [ASTReader] Report error when accessing corrupt record data

vsk abandoned this revision. vsk added a comment. I haven't measured the performance overhead of this patch. The failure case it's supposed to protect against is exceptionally rare: we haven't seen it happen again. In light of that, and considering that it clutters up the code, I think it'd be

Re: [PATCH] D20119: [libunwind] Improve unwinder stack usage

rengolin added a subscriber: rengolin. Comment at: include/libunwind.h:49 @@ -48,1 +48,3 @@ struct unw_context_t { +#if defined(_LIBUNWIND_NATIVE_I386) + uint64_t data[8]; Wouldn't it be a lot simpler to just define a macro _LIBUNWIND_DATA_SIZE or something and

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

Anastasia added inline comments. Comment at: lib/Sema/SemaChecking.cpp:480 @@ +479,3 @@ + .getQualifiers().getAddressSpace() == LangAS::opencl_constant) { +S.Diag(Call->getLocStart(), diag::err_opencl_builtin_to_addr_invalid_arg) +<< Call->getArg(0) << Call->getDi

[PATCH] D20119: [libunwind] Improve unwinder stack usage

rmaprath created this revision. rmaprath added reviewers: jroelofs, bcraig. rmaprath added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This patch is generalization of D19920. A new native-only libunwind variant (selectable through the `-DLIBUNWIND_ENABLE_CROSS_UNWINDING=OFF`

[PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe created this revision. spyffe added reviewers: sepavloff, a.sidorin. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. spyffe added a project: clang-c. The AST importer currently does not handle injected class names properly (it does not bind t

Re: [PATCH] D19275: Do not register incompatible C++ destructors with __cxa_atexit

dschuff added a comment. Well, I forgot to squash my local commits before landing, so this is r269085 thru r269089 :( Repository: rL LLVM http://reviews.llvm.org/D19275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D19275: Do not register incompatible C++ destructors with __cxa_atexit

This revision was automatically updated to reflect the committed changes. Closed by commit rL269085: Do not register incompatible C++ destructors with __cxa_atexit (authored by dschuff). Changed prior to commit: http://reviews.llvm.org/D19275?vs=56218&id=56751#toc Repository: rL LLVM http:/

r269089 - Introduce CGCXXABI::canCallMismatchedFunctionType

Author: dschuff Date: Tue May 10 12:44:55 2016 New Revision: 269089 URL: http://llvm.org/viewvc/llvm-project?rev=269089&view=rev Log: Introduce CGCXXABI::canCallMismatchedFunctionType Modified: cfe/trunk/lib/CodeGen/CGCXXABI.h cfe/trunk/lib/CodeGen/CGDeclCXX.cpp cfe/trunk/lib/CodeGen/

r269088 - more cleanup

Author: dschuff Date: Tue May 10 12:44:52 2016 New Revision: 269088 URL: http://llvm.org/viewvc/llvm-project?rev=269088&view=rev Log: more cleanup Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/l

r269085 - Do not register incompatible C++ destructors with __cxa_atexit

Author: dschuff Date: Tue May 10 12:44:46 2016 New Revision: 269085 URL: http://llvm.org/viewvc/llvm-project?rev=269085&view=rev Log: Do not register incompatible C++ destructors with __cxa_atexit Summary: For a static object with a nontrivial destructor, clang generates an initializer function (

r269086 - Clean up condition, add ARM to test

Author: dschuff Date: Tue May 10 12:44:48 2016 New Revision: 269086 URL: http://llvm.org/viewvc/llvm-project?rev=269086&view=rev Log: Clean up condition, add ARM to test Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp cfe/trunk/test/CodeGenCXX/static-destructor.cpp Modified: cfe/trunk/lib/

r269087 - Clarify condition, remove redundant check

Author: dschuff Date: Tue May 10 12:44:50 2016 New Revision: 269087 URL: http://llvm.org/viewvc/llvm-project?rev=269087&view=rev Log: Clarify condition, remove redundant check Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp Modified: cfe/trunk/lib/CodeGen/CGDeclCXX.cpp URL: http://llvm.org/vi

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. Overall I'm very enthusiastic about this and only have a few nitpicks. Thanks for the hard work! Comment at: lib/AST/ASTImporter.cpp:2364 @@ +2363,3 @@ + if (Arg.

[PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

sdefresne created this revision. sdefresne added a reviewer: rjmccall. sdefresne added a subscriber: cfe-commits. When a function/method use a parameter with "ns_consumed" attribute, ensure that the mangled name is the same whether -fobjc-arc is used or not. Since "ns_consumed" attribute is gener

r269079 - clang/test/CodeGen/avx512f-builtins.c: Fix for -Asserts.

Author: chapuni Date: Tue May 10 12:16:12 2016 New Revision: 269079 URL: http://llvm.org/viewvc/llvm-project?rev=269079&view=rev Log: clang/test/CodeGen/avx512f-builtins.c: Fix for -Asserts. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified: cfe/trunk/test/CodeGen/avx512f-builtins

Re: [PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

rjmccall added a comment. This is a good catch, thanks! As a slight adjustment, It's probably better to just ignore this attribute when mangling the function type of an entity, the same way that we generally don't mangle return types because they don't affect overloading. That will require an

Re: [PATCH] D19275: Do not register incompatible C++ destructors with __cxa_atexit

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. lgtm http://reviews.llvm.org/D19275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20112: [OpenMP] Add support for the 'private pointer' flag to signal variables captured in target regions and used in first-private clauses.

sfantao created this revision. sfantao added reviewers: ABataev, hfinkel, carlo.bertolli, arpith-jacob, kkwli0. sfantao added subscribers: cfe-commits, caomhin. If a variable is implicitly mapped (doesn't show in a map clause), the runtime library has to be informed if the corresponding capture s

Re: [PATCH] D19275: Do not register incompatible C++ destructors with __cxa_atexit

jfb accepted this revision. jfb added a reviewer: jfb. jfb added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D19275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D19992: [libcxx] Prefer C++14 over C++11 when building libc++experimental.

This revision was automatically updated to reflect the committed changes. Closed by commit rL269070: [libcxx] Prefer C++14 over C++11 when building libc++experimental. (authored by EricWF). Changed prior to commit: http://reviews.llvm.org/D19992?vs=56333&id=56732#toc Repository: rL LLVM htt

  1   2   >