r268870 - [OpenMP] Check for associated statements with hasAssociatedStmt() when scanning for device code.

2016-05-07 Thread Samuel Antao via cfe-commits
Author: sfantao Date: Sun May 8 01:43:56 2016 New Revision: 268870 URL: http://llvm.org/viewvc/llvm-project?rev=268870&view=rev Log: [OpenMP] Check for associated statements with hasAssociatedStmt() when scanning for device code. Summary: `getAssociatedStmt()` contains an assertion that assumes

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-07 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 56511. hintonda added a comment. Addressed additional comments. http://reviews.llvm.org/D18575 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNoexceptCheck.cpp clang-tidy/modernize/Us

[PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

2016-05-07 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: alexfh. hintonda added a subscriber: cfe-commits. Herald added a subscriber: klimek. Add new ASTMatcher that matches dynamic exception specifications. http://reviews.llvm.org/D20052 Files: include/clang/ASTMatchers/ASTMatchers.h Index

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-05-07 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin added a comment. Thank you for reporting this issue, I'll take a look. I'm mostly testing on x86_64 so I may not notice the problem. http://reviews.llvm.org/D18035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-05-07 Thread Evangelos Foutras via cfe-commits
foutrelis added a subscriber: foutrelis. Comment at: test/CodeGenCXX/mangle-abi-tag.cpp:115 @@ +114,3 @@ +C1 f9() { return C1(); } +// CHECK: @_Z2f9B6Names1v() + I'm seeing a test failure on i686 on Arch Linux (all tests pass on x86_64): {F1899075} I'm using thi

Re: [PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

2016-05-07 Thread Miklos Vajna via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268857: clang-rename: when renaming a field, rename initializers of that field as well (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D19957?vs=56241&id=56497#toc Repository:

[clang-tools-extra] r268857 - clang-rename: when renaming a field, rename initializers of that field as well

2016-05-07 Thread Miklos Vajna via cfe-commits
Author: vmiklos Date: Sat May 7 09:32:59 2016 New Revision: 268857 URL: http://llvm.org/viewvc/llvm-project?rev=268857&view=rev Log: clang-rename: when renaming a field, rename initializers of that field as well Summary: The second check failed, the initializer wasn't renamed. Reviewers: cfe-co

r268740 - Revert "AMDGPU/SI: Use amdgpu_kernel calling convention for OpenCL kernels."

2016-05-07 Thread Nikolay Haustov via cfe-commits
Author: nhaustov Date: Fri May 6 10:00:51 2016 New Revision: 268740 URL: http://llvm.org/viewvc/llvm-project?rev=268740&view=rev Log: Revert "AMDGPU/SI: Use amdgpu_kernel calling convention for OpenCL kernels." This reverts commit f7053ec90d0fc56f0837e43c2c759e85b56c21a1. It broke calling OpenC

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

2016-05-07 Thread Vedran Miletić via cfe-commits
rivanvx updated this revision to Diff 56479. rivanvx added a comment. Make that int const as well. http://reviews.llvm.org/D19780 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Parse/ParseDecl.cpp test/Parser/opencl-cl20.cl test/Parser/opencl-storage-class.cl test/SemaOpenCL/in

Re: [PATCH] RHEL: Look in more places to find g++ headers and runtime

2016-05-07 Thread Michael Lampe via cfe-commits
No, I'm hoping on someone else to commit this. (You?) Same with this one: https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg18696.html -Michael Rafael Espíndola wrote: LGTM. Do you have commit access? Cheers, Rafael On 11 April 2016 at 14:49, Michael Lampe wrote: New patch attac

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

2016-05-07 Thread Vedran Miletić via cfe-commits
rivanvx added inline comments. Comment at: lib/Parse/ParseDecl.cpp:3519 @@ +3518,3 @@ + / 100); +const char *VerSpec = (VerMajor + std::string (".") + VerMinor).c_str(); +Diag(Tok, DiagID) << VerSpec << PrevSpec << isS

Re: [PATCH] D17092: [X86] Add -mseparate-stack-seg

2016-05-07 Thread Michael Kuperstein via cfe-commits
mkuper resigned from this revision. mkuper removed a reviewer: mkuper. mkuper added a comment. I really don't know enough about this part of clang either. http://reviews.llvm.org/D17092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

2016-05-07 Thread Vedran Miletić via cfe-commits
rivanvx updated this revision to Diff 56478. rivanvx marked 3 inline comments as done. rivanvx added a comment. I am neither aware how to convert ints to StringRef nor how to concatenate StringRefs. Apologies if I missed something in the API. In any case, this approach looks pretty clean to me.

Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

2016-05-07 Thread Vedran Miletić via cfe-commits
rivanvx added a comment. @Anastasia would you still prefer to make VerSpec a std::string? http://reviews.llvm.org/D19780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268860 - Enable Pthread threading API on Solaris. Fix PR27677

2016-05-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sat May 7 12:05:46 2016 New Revision: 268860 URL: http://llvm.org/viewvc/llvm-project?rev=268860&view=rev Log: Enable Pthread threading API on Solaris. Fix PR27677 Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org/view

Re: [PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

2016-05-07 Thread Miklos Vajna via cfe-commits
vmiklos added a comment. Not really, I just copied VarTest.cpp. I'll put it to top for new tests. Repository: rL LLVM http://reviews.llvm.org/D19957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D19957: clang-rename: when renaming a field, rename initializers of that field as well

2016-05-07 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. This revision is now accepted and ready to land. Comment at: test/clang-rename/FieldTest.cpp:7-9 @@ +6,5 @@ +}; +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=18 -new-name=hector %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s + --